github-actions[bot] commented on pull request #7393:
URL: https://github.com/apache/arrow/pull/7393#issuecomment-641850516
https://issues.apache.org/jira/browse/ARROW-9087
This is an automated message from the Apache Git
svenwb commented on a change in pull request #7379:
URL: https://github.com/apache/arrow/pull/7379#discussion_r437992880
##
File path: rust/arrow/src/json/reader.rs
##
@@ -448,42 +453,55 @@ impl Reader {
let mut builder =
github-actions[bot] commented on pull request #7394:
URL: https://github.com/apache/arrow/pull/7394#issuecomment-641888709
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
pitrou commented on pull request #7272:
URL: https://github.com/apache/arrow/pull/7272#issuecomment-641922866
@jorisvandenbossche Do you need help on this?
This is an automated message from the Apache Git Service.
To respond
veprbl commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438157379
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1879,13 +1879,26 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-642045115
This went fine so I'm gonna merge once Travis-CI is green.
This is an automated message from the Apache Git
jorisvandenbossche commented on pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#issuecomment-642017016
cc @martindurant
This is an automated message from the Apache Git Service.
To respond to the message,
martindurant commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438138900
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -324,6 +350,14 @@ def hdfs(request, hdfs_connection):
pytest.lazy_fixture('py_localfs'),
eerhardt closed pull request #7158:
URL: https://github.com/apache/arrow/pull/7158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-642053207
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To
wesm commented on pull request #7396:
URL: https://github.com/apache/arrow/pull/7396#issuecomment-642063926
cc @pravindra @projjal
This is an automated message from the Apache Git Service.
To respond to the message, please
martindurant commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438137975
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -511,7 +545,8 @@ def test_get_file_info(fs, pathfn):
assert 'aaa' in repr(aaa_info)
veprbl commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438155204
##
File path: cpp/cmake_modules/FindZSTD.cmake
##
@@ -65,4 +66,5 @@ if(ZSTD_FOUND)
set_target_properties(ZSTD::zstd
PROPERTIES
github-actions[bot] commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-642013492
Revision: 8a68d49ac16638be845800404288890e7f2417d8
Submitted crossbow builds: [ursa-labs/crossbow @
martindurant commented on pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#issuecomment-642019560
I hope to look at this soon.
Just a quick note that the name of the implementation might cause confusion
with https://www.pyfilesystem.org/
wesm commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-642039038
I noticed some bugs while reviewing, I'll push some changes here in a few
minutes
This is an automated message from
wesm commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-642057943
Done. Please review
This is an automated message from the Apache Git Service.
To respond to the message, please log
wesm opened a new pull request #7396:
URL: https://github.com/apache/arrow/pull/7396
This unblocks LLVM 9 users from running the test suite. Whoever merges this,
please leave the JIRA issue open.
This is an automated
jorisvandenbossche commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438129306
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -324,6 +350,14 @@ def hdfs(request, hdfs_connection):
jorisvandenbossche commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438136127
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -511,7 +545,8 @@ def test_get_file_info(fs, pathfn):
assert 'aaa' in repr(aaa_info)
tobim commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438141186
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1879,13 +1879,26 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
jorisvandenbossche commented on pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#issuecomment-642027149
The `PyFilesystem` is not really meant for typical end-users (but initially
internally to wrap incoming fsspec filesystems, or potentially later in
packages like dask
tobim commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438140636
##
File path: cpp/cmake_modules/FindZSTD.cmake
##
@@ -65,4 +66,5 @@ if(ZSTD_FOUND)
set_target_properties(ZSTD::zstd
PROPERTIES
github-actions[bot] commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-642054359
Revision: 760a0981e48f1549ef138c989ac590847c7fb718
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7396:
URL: https://github.com/apache/arrow/pull/7396#issuecomment-642069300
https://issues.apache.org/jira/browse/ARROW-9092
This is an automated message from the Apache Git
jorisvandenbossche commented on a change in pull request #7169:
URL: https://github.com/apache/arrow/pull/7169#discussion_r438202601
##
File path: python/pyarrow/pandas_compat.py
##
@@ -699,6 +699,22 @@ def _reconstruct_block(item, columns=None,
extension_columns=None):
pitrou closed pull request #7390:
URL: https://github.com/apache/arrow/pull/7390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7390:
URL: https://github.com/apache/arrow/pull/7390#issuecomment-641863361
Thanks for the fix!
This is an automated message from the Apache Git Service.
To respond to the message, please
svenwb commented on a change in pull request #7379:
URL: https://github.com/apache/arrow/pull/7379#discussion_r437995071
##
File path: rust/arrow/src/json/reader.rs
##
@@ -448,42 +453,55 @@ impl Reader {
let mut builder =
pitrou commented on a change in pull request #7174:
URL: https://github.com/apache/arrow/pull/7174#discussion_r438036975
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -273,7 +267,29 @@ class GrpcClientInterceptorAdapter : public
grpc::experimental::Interceptor {
}
jorisvandenbossche opened a new pull request #7395:
URL: https://github.com/apache/arrow/pull/7395
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jorisvandenbossche closed pull request #7348:
URL: https://github.com/apache/arrow/pull/7348
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641942765
Revision: 959fc8c3d6e9ef6353544d90f3c7122dc2358ae7
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641962638
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To
pitrou commented on pull request #7393:
URL: https://github.com/apache/arrow/pull/7393#issuecomment-641969824
Thank you @zhouyuan for improving this part of the code!
This is an automated message from the Apache Git Service.
pitrou closed pull request #7373:
URL: https://github.com/apache/arrow/pull/7373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#issuecomment-641927363
Thank you @cyb70289 !
This is an automated message from the Apache Git Service.
To respond to the message, please
pitrou commented on pull request #7174:
URL: https://github.com/apache/arrow/pull/7174#issuecomment-641927046
(also rebased to force AppVeyor rebuild)
This is an automated message from the Apache Git Service.
To respond to
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641955112
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To
pitrou closed pull request #7393:
URL: https://github.com/apache/arrow/pull/7393
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
zhztheplayer commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-641936183
Hi @fsaintjacques, @emkornfield it would be much appreciated if you would
like to continue reviewing this, here is a list for modifications since latest
review comment:
pitrou commented on a change in pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#discussion_r438120986
##
File path: python/pyarrow/tests/test_fs.py
##
@@ -511,7 +545,8 @@ def test_get_file_info(fs, pathfn):
assert 'aaa' in repr(aaa_info)
assert
lidavidm commented on pull request #7224:
URL: https://github.com/apache/arrow/pull/7224#issuecomment-641961534
> LGTM. Do you need someone to review the Java changes?
> Also, can you rebase to try and fix the AppVeyor failure?
Thanks! Rebased. Ryan already looked at the Java
jba commented on pull request #7376:
URL: https://github.com/apache/arrow/pull/7376#issuecomment-641965490
I confirmed that either of these will work:
- Putting LICENSE.txt into go/arrow (this PR)
- Renaming the top-level LICENSE.txt to LICENSE.
We (pkg.go.dev) need to do a
github-actions[bot] commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641981287
Revision: feb26d522766ee46a4b5207e82a1440e96c6b2e7
Submitted crossbow builds: [ursa-labs/crossbow @
fsaintjacques closed pull request #7377:
URL: https://github.com/apache/arrow/pull/7377
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-642002881
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641929318
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641934785
Revision: 3f1c8f8f7bc897b669977daeaa1733fae4b5a4a5
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou commented on pull request #7165:
URL: https://github.com/apache/arrow/pull/7165#issuecomment-641942004
@github-actions crossbow submit wheel-win-cp36m
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7395:
URL: https://github.com/apache/arrow/pull/7395#issuecomment-641942032
https://issues.apache.org/jira/browse/ARROW-9089
This is an automated message from the Apache Git
pitrou closed pull request #7386:
URL: https://github.com/apache/arrow/pull/7386
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-641971704
Thanks for the review. What do you think about having
`RecordBatchWriter::WritePayload(const IpcPayload&)` along with
`DictionaryMemo* RecordBatchWriter::dictionary_memo`? I
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r438092236
##
File path: README.md
##
@@ -32,16 +32,24 @@ set of technologies that enable big data systems to process
and move data fast.
Major components of the
pitrou commented on a change in pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#discussion_r438018616
##
File path: cpp/src/arrow/ipc/writer.h
##
@@ -330,6 +306,11 @@ ARROW_EXPORT
Status GetRecordBatchPayload(const RecordBatch& batch, const IpcWriteOptions&
zhouyuan commented on pull request #7393:
URL: https://github.com/apache/arrow/pull/7393#issuecomment-641848793
https://issues.apache.org/jira/browse/ARROW-9087
This is an automated message from the Apache Git Service.
pitrou commented on pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#issuecomment-641869288
Rebased to (hopefully) fix AppVeyor.
This is an automated message from the Apache Git Service.
To respond to the
nevi-me commented on a change in pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#discussion_r437923771
##
File path: rust/arrow/src/compute/kernels/concat.rs
##
@@ -0,0 +1,310 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
sagnikc-dremio closed pull request #7392:
URL: https://github.com/apache/arrow/pull/7392
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pitrou commented on a change in pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#discussion_r438027429
##
File path: cpp/src/arrow/array/array_nested.h
##
@@ -396,70 +445,43 @@ class ARROW_EXPORT UnionArray : public Array {
/// \param[in] children Vector
pitrou commented on pull request #7263:
URL: https://github.com/apache/arrow/pull/7263#issuecomment-641922347
@alexbaden Are you willing to update this? Otherwise I may take a look.
This is an automated message from the
nealrichardson closed pull request #7308:
URL: https://github.com/apache/arrow/pull/7308
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nealrichardson commented on pull request #6725:
URL: https://github.com/apache/arrow/pull/6725#issuecomment-642139864
Can we merge this?
This is an automated message from the Apache Git Service.
To respond to the message,
pitrou opened a new pull request #7397:
URL: https://github.com/apache/arrow/pull/7397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nevi-me opened a new pull request #7399:
URL: https://github.com/apache/arrow/pull/7399
The change removes the buffer allocation, ensures that no default null
buffers are written, and verifies that a roundtrip of an array with nulls works
correctly.
As a side effect, the NullArray
nevi-me commented on pull request #7297:
URL: https://github.com/apache/arrow/pull/7297#issuecomment-642223515
@andygrove @nealrichardson Rust tests are now running (binary found). The
problem was that we were setting the build output directory to
`build/rust/target/...` instead of the
nevi-me commented on pull request #7384:
URL: https://github.com/apache/arrow/pull/7384#issuecomment-642225601
@maxburke may you please also look at this if you have a moment
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7399:
URL: https://github.com/apache/arrow/pull/7399#issuecomment-642227866
https://issues.apache.org/jira/browse/ARROW-9095
This is an automated message from the Apache Git
alexbaden commented on pull request #7263:
URL: https://github.com/apache/arrow/pull/7263#issuecomment-642111550
Hi @pitrou, sorry about that -- I'll rebase and make the requested changes
today or tomorrow.
This is an
nealrichardson commented on pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#issuecomment-642135635
@rymurr @lidavidm @emkornfield is this good to go now?
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7397:
URL: https://github.com/apache/arrow/pull/7397#issuecomment-642153499
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nealrichardson commented on pull request #7297:
URL: https://github.com/apache/arrow/pull/7297#issuecomment-642118355
Hi @andygrove @nevi-me, what do we need to do to merge this and get Rust
integration tests (at least those that are currently supported) running on all
commits?
nealrichardson commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-642122248
I agree that trying to improve this in Thrift itself should be our first step
This is an automated message
nealrichardson closed pull request #7224:
URL: https://github.com/apache/arrow/pull/7224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lidavidm commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642168091
> Why is `WriteIpcPayload` not sufficient for that?
`WriteIpcPayload` targets an `io::OutputStream` but in Flight, you get only
a `RecordBatchWriter`.
pitrou commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642168852
Who is "you"? The application?
This is an automated message from the Apache Git Service.
To respond to the
lidavidm commented on pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#issuecomment-642168659
I am good with this.
This is an automated message from the Apache Git Service.
To respond to the message, please
lidavidm commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642169852
Sorry, yes - the application only gets a RecordBatchWriter.
This is an automated message from the Apache Git
pitrou commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642170854
But then why would the application write payloads directly?
This is an automated message from the Apache Git
lidavidm commented on a change in pull request #7174:
URL: https://github.com/apache/arrow/pull/7174#discussion_r43831
##
File path: cpp/src/arrow/flight/client.cc
##
@@ -273,7 +267,29 @@ class GrpcClientInterceptorAdapter : public
grpc::experimental::Interceptor {
}
nealrichardson closed pull request #7289:
URL: https://github.com/apache/arrow/pull/7289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lidavidm commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642173870
So, gRPC has a default limit on the max size of any message on the wire.
Flight disables this limit to allow you to write large record batches. However,
we've found that it's
pitrou commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642179329
Ah, well, then let's reopen #7299 instead of violating API layers in
`RecordBatchWriter`.
This is an automated
lidavidm commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-642183620
Reopened as #7398 since I rebased before reopening the PR.
This is an automated message from the Apache Git
lidavidm opened a new pull request #7398:
URL: https://github.com/apache/arrow/pull/7398
(Recreated since I rebased before reopening.)
I'd appreciate feedback on this. This is a specialized API to limit the
payload size when a client is sending data to a server.
While Flight
lidavidm commented on pull request #7398:
URL: https://github.com/apache/arrow/pull/7398#issuecomment-642183483
See #7299 and #7387 for context.
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #7398:
URL: https://github.com/apache/arrow/pull/7398#issuecomment-642184909
https://issues.apache.org/jira/browse/ARROW-8487
This is an automated message from the Apache Git
nevi-me commented on pull request #7297:
URL: https://github.com/apache/arrow/pull/7297#issuecomment-642206959
> Hi @andygrove @nevi-me, what do we need to do to merge this and get Rust
integration tests (at least those that are currently supported) running on all
commits?
I think
pitrou commented on pull request #7397:
URL: https://github.com/apache/arrow/pull/7397#issuecomment-642194035
@github-actions crossbow submit wheel-win-cp38
This is an automated message from the Apache Git Service.
To
pitrou closed pull request #7174:
URL: https://github.com/apache/arrow/pull/7174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on pull request #7297:
URL: https://github.com/apache/arrow/pull/7297#issuecomment-642240631
I think
https://github.com/apache/arrow/pull/7297/files#diff-7a8805436a6884ddf74fe3eaec697e71R624
is sufficient to get them to run on each commit/PR.
If you've
tobim commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r438407635
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1879,13 +1879,26 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
kou commented on pull request #7397:
URL: https://github.com/apache/arrow/pull/7397#issuecomment-642282140
@github-actions crossbow submit -g linux
This is an automated message from the Apache Git Service.
To respond to the
kou commented on a change in pull request #7397:
URL: https://github.com/apache/arrow/pull/7397#discussion_r438421515
##
File path: cpp/cmake_modules/FindgRPCAlt.cmake
##
@@ -100,19 +109,35 @@ if(gRPCAlt_FOUND)
PROPERTIES IMPORTED_LOCATION
kou closed pull request #7391:
URL: https://github.com/apache/arrow/pull/7391
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7391:
URL: https://github.com/apache/arrow/pull/7391#issuecomment-642284289
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wesm commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-642285703
I am preparing another large patch that uses this branch as a base so this
patch will need to be reviewed and merged before the next patch (providing a
streamlined Filter
wesm edited a comment on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-642285703
I am preparing another large patch that uses this branch as a base so this
patch will need to be reviewed and merged before the next patch (providing a
streamlined Filter
github-actions[bot] commented on pull request #7400:
URL: https://github.com/apache/arrow/pull/7400#issuecomment-642241964
https://issues.apache.org/jira/browse/ARROW-9088
This is an automated message from the Apache Git
nevi-me opened a new pull request #7400:
URL: https://github.com/apache/arrow/pull/7400
It does not compile under the wasm target
This is an automated message from the Apache Git Service.
To respond to the message, please
1 - 100 of 129 matches
Mail list logo
