[GitHub] [beam] ibzib opened a new pull request #11374: [DO NOT MERGE]Start snapshot build for release process

2020-04-09 Thread GitBox
ibzib opened a new pull request #11374: [DO NOT MERGE]Start snapshot build for release process URL: https://github.com/apache/beam/pull/11374 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] ibzib commented on issue #11374: [DO NOT MERGE]Start snapshot build for release process

2020-04-09 Thread GitBox
ibzib commented on issue #11374: [DO NOT MERGE]Start snapshot build for release process URL: https://github.com/apache/beam/pull/11374#issuecomment-611873205 Run Gradle Publish This is an automated message from the Apache

[GitHub] [beam] HuangLED commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-09 Thread GitBox
HuangLED commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-611871116 pull from head and rebased (no changes to previous commits) please try again

[GitHub] [beam] HuangLED edited a comment on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-09 Thread GitBox
HuangLED edited a comment on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-611868777 gradlew lint and test both work fine on my local repository. test command: python

[GitHub] [beam] HuangLED commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-09 Thread GitBox
HuangLED commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-611868777 lint and test both work fine on my local repository. And the PythonLint by github reports

[GitHub] [beam] damondouglas commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-09 Thread GitBox
damondouglas commented on issue #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#issuecomment-611857902 @lostluck @henryken I've made the recommended changes. Thank you for reviewing.

[GitHub] [beam] damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-09 Thread GitBox
damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r406584290 ## File path: learning/katas/go/Introduction/task1/task-info.yaml ## @@ -0,0 +1,39 @@ +# +# Licensed

[GitHub] [beam] damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-09 Thread GitBox
damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r406584247 ## File path: learning/katas/go/Introduction/task2/test/task_test.go ## @@ -0,0 +1,44 @@ +//

[GitHub] [beam] damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata

2020-04-09 Thread GitBox
damondouglas commented on a change in pull request #11340: [BEAM-9678] Create Go SDK introduction kata URL: https://github.com/apache/beam/pull/11340#discussion_r406583732 ## File path: learning/katas/go/Introduction/lesson-info.yaml ## @@ -0,0 +1,23 @@ +# +# Licensed to

[GitHub] [beam] lukecwik commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
lukecwik commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364#issuecomment-611840338 They would run automatically as a cron PostCommit or you can manually launch them from the Jenkins UI.

[GitHub] [beam] lukecwik commented on a change in pull request #11373: [BEAM-9562] Update Element.timer to Element.timers

2020-04-09 Thread GitBox
lukecwik commented on a change in pull request #11373: [BEAM-9562] Update Element.timer to Element.timers URL: https://github.com/apache/beam/pull/11373#discussion_r406567717 ## File path: model/fn-execution/src/main/proto/beam_fn_api.proto ## @@ -516,7 +516,7 @@ message

[GitHub] [beam] lukecwik commented on issue #11373: [BEAM-9562] Update Element.timer to Element.timers

2020-04-09 Thread GitBox
lukecwik commented on issue #11373: [BEAM-9562] Update Element.timer to Element.timers URL: https://github.com/apache/beam/pull/11373#issuecomment-611839103 please regenerate the go protos This is an automated message from

[GitHub] [beam] lukecwik commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
lukecwik commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11368#issuecomment-611838764 Run Java PreCommit This is an automated message from

[GitHub] [beam] aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-09 Thread GitBox
aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#issuecomment-611822669 retest this please This is an automated

[GitHub] [beam] aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size

2020-04-09 Thread GitBox
aaltay commented on issue #11292: [BEAM-9674] Don't specify selected fields when fetching BigQuery table size URL: https://github.com/apache/beam/pull/11292#issuecomment-611822518 retest this please This is an automated

[GitHub] [beam] aaltay merged pull request #11247: add missing bracket

2020-04-09 Thread GitBox
aaltay merged pull request #11247: add missing bracket URL: https://github.com/apache/beam/pull/11247 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] boyuanzz opened a new pull request #11373: [BEAM-9562] Update Element.timer to Element.timers

2020-04-09 Thread GitBox
boyuanzz opened a new pull request #11373: [BEAM-9562] Update Element.timer to Element.timers URL: https://github.com/apache/beam/pull/11373 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this

[GitHub] [beam] aaltay commented on issue #10487: [BEAM-5504] Introduce PubsubAvroTable

2020-04-09 Thread GitBox
aaltay commented on issue #10487: [BEAM-5504] Introduce PubsubAvroTable URL: https://github.com/apache/beam/pull/10487#issuecomment-611821536 Is this PR still active? This is an automated message from the Apache Git Service.

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-04-09 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r406551322 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -454,6 +455,7 @@ class

[GitHub] [beam] pabloem commented on issue #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-09 Thread GitBox
pabloem commented on issue #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#issuecomment-611816596 Run Python 3.5 PostCommit This is an automated message from the Apache

[GitHub] [beam] robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt…

2020-04-09 Thread GitBox
robertwb commented on issue #11371: Update dataflow runner to setup docker environment with the right opt… URL: https://github.com/apache/beam/pull/11371#issuecomment-611816276 test this please This is an automated message

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11372: [BEAM-9443] support direct_num_workers=0

2020-04-09 Thread GitBox
Hannah-Jiang commented on a change in pull request #11372: [BEAM-9443] support direct_num_workers=0 URL: https://github.com/apache/beam/pull/11372#discussion_r406546390 ## File path: CHANGES.md ## @@ -67,6 +67,7 @@ [Ensuring Python Type

[GitHub] [beam] Hannah-Jiang opened a new pull request #11372: [BEAM-9443] support direct_num_workers=0

2020-04-09 Thread GitBox
Hannah-Jiang opened a new pull request #11372: [BEAM-9443] support direct_num_workers=0 URL: https://github.com/apache/beam/pull/11372 R: @ibzib Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] robertwb commented on a change in pull request #11370: Update environments.py to add a method to specify container image

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11370: Update environments.py to add a method to specify container image URL: https://github.com/apache/beam/pull/11370#discussion_r406545577 ## File path: sdks/python/apache_beam/transforms/environments.py ## @@ -252,11

[GitHub] [beam] lukecwik commented on a change in pull request #11366: Allow unset write threshold for state backed iterable coder.

2020-04-09 Thread GitBox
lukecwik commented on a change in pull request #11366: Allow unset write threshold for state backed iterable coder. URL: https://github.com/apache/beam/pull/11366#discussion_r406545747 ## File path: sdks/python/apache_beam/coders/coders.py ## @@ -1385,7 +1388,8 @@ def

[GitHub] [beam] ananvay commented on issue #11370: Update environments.py to add a method to specify container image

2020-04-09 Thread GitBox
ananvay commented on issue #11370: Update environments.py to add a method to specify container image URL: https://github.com/apache/beam/pull/11370#issuecomment-611814439 R @robertwb This is an automated message from the

[GitHub] [beam] ananvay commented on issue #11371: Update dataflow runner to setup docker environment with the right opt…

2020-04-09 Thread GitBox
ananvay commented on issue #11371: Update dataflow runner to setup docker environment with the right opt… URL: https://github.com/apache/beam/pull/11371#issuecomment-611814531 R @robertwb (this is a followup to https://github.com/apache/beam/pull/11370).

[GitHub] [beam] ananvay opened a new pull request #11371: Update dataflow runner to setup docker environment with the right opt…

2020-04-09 Thread GitBox
ananvay opened a new pull request #11371: Update dataflow runner to setup docker environment with the right opt… URL: https://github.com/apache/beam/pull/11371 …ions **Please** add a meaningful description for your change here Thank you for

[GitHub] [beam] lukecwik merged pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
lukecwik merged pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] robertwb merged pull request #11366: Allow unset write threshold for state backed iterable coder.

2020-04-09 Thread GitBox
robertwb merged pull request #11366: Allow unset write threshold for state backed iterable coder. URL: https://github.com/apache/beam/pull/11366 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-09 Thread GitBox
lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-611812812 retest this please This is an

[GitHub] [beam] lukecwik merged pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2.

2020-04-09 Thread GitBox
lukecwik merged pull request #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2. URL: https://github.com/apache/beam/pull/11355 This is an automated message from the Apache Git Service.

[GitHub] [beam] reuvenlax commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
reuvenlax commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11368#issuecomment-611808657 run dataflow validatesrunner This is an automated

[GitHub] [beam] reuvenlax commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
reuvenlax commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11368#issuecomment-611808620 retest this please This is an automated message

[GitHub] [beam] scwhittle edited a comment on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
scwhittle edited a comment on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11368#issuecomment-611808055 R: @reuvenlax Please trigger the tests before merging

[GitHub] [beam] scwhittle commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
scwhittle commented on issue #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11368#issuecomment-611808055 R: @reuvenlax With tests this time :) This is

[GitHub] [beam] ibzib opened a new pull request #11369: [BEAM-9600] Get metrics in Flink uber jar job server.

2020-04-09 Thread GitBox
ibzib opened a new pull request #11369: [BEAM-9600] Get metrics in Flink uber jar job server. URL: https://github.com/apache/beam/pull/11369 Accumulators are visible in the Flink REST API at the `/accumulators` endpoint, including the Beam Flink runner's custom accumulator,

[GitHub] [beam] scwhittle opened a new pull request #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
scwhittle opened a new pull request #11368: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11368 Reduce StreamPool synchronized block by excluding stream creation and requiring it for release. Some Dataflow pipelines were

[GitHub] [beam] reuvenlax merged pull request #11367: Revert "[BEAM-9651] Prevent StreamPool and stream initialization livelock"

2020-04-09 Thread GitBox
reuvenlax merged pull request #11367: Revert "[BEAM-9651] Prevent StreamPool and stream initialization livelock" URL: https://github.com/apache/beam/pull/11367 This is an automated message from the Apache Git Service. To

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406523425 ## File path: sdks/java/container/license_scripts/pull_licenses_java.py ## @@ -0,0 +1,186 @@

[GitHub] [beam] scwhittle opened a new pull request #11367: Revert "[BEAM-9651] Prevent StreamPool and stream initialization livelock"

2020-04-09 Thread GitBox
scwhittle opened a new pull request #11367: Revert "[BEAM-9651] Prevent StreamPool and stream initialization livelock" URL: https://github.com/apache/beam/pull/11367 Reverts apache/beam#11364 because the tests were not run before merging.

[GitHub] [beam] scwhittle commented on issue #11367: Revert "[BEAM-9651] Prevent StreamPool and stream initialization livelock"

2020-04-09 Thread GitBox
scwhittle commented on issue #11367: Revert "[BEAM-9651] Prevent StreamPool and stream initialization livelock" URL: https://github.com/apache/beam/pull/11367#issuecomment-611793406 R: @reuvenlax This is an automated

[GitHub] [beam] ananvay commented on issue #11366: Allow unset write threshold for state backed iterable coder.

2020-04-09 Thread GitBox
ananvay commented on issue #11366: Allow unset write threshold for state backed iterable coder. URL: https://github.com/apache/beam/pull/11366#issuecomment-611788481 /cc: @HuangLED This is an automated message from the

[GitHub] [beam] ananvay commented on issue #11366: Allow unset write threshold for state backed iterable coder.

2020-04-09 Thread GitBox
ananvay commented on issue #11366: Allow unset write threshold for state backed iterable coder. URL: https://github.com/apache/beam/pull/11366#issuecomment-611788388 Thanks Robert! LGTM. This is an automated message from the

[GitHub] [beam] reuvenlax commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
reuvenlax commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364#issuecomment-611787993 @lukecwik my bad - I missed that the tests hadn't triggered. is it possible to trigger tests now, or do we need a

[GitHub] [beam] reuvenlax commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
reuvenlax commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364#issuecomment-611787817 run dataflow validatesrunner This is an automated

[GitHub] [beam] robertwb commented on issue #11366: Allow unset write threshold for state backed iterable coder.

2020-04-09 Thread GitBox
robertwb commented on issue #11366: Allow unset write threshold for state backed iterable coder. URL: https://github.com/apache/beam/pull/11366#issuecomment-611787004 R: @ananvay This is an automated message from the Apache

[GitHub] [beam] robertwb opened a new pull request #11366: Allow unset write threshold for state backed iterable coder.

2020-04-09 Thread GitBox
robertwb opened a new pull request #11366: Allow unset write threshold for state backed iterable coder. URL: https://github.com/apache/beam/pull/11366 In the SDK these are generally only used for reading. Thank you for your contribution! Follow this

[GitHub] [beam] lukecwik commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
lukecwik commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364#issuecomment-611785948 Note that the tests never ran on this change. Please only merge on green. Only committers can start tests on

[GitHub] [beam] lukecwik commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2.

2020-04-09 Thread GitBox
lukecwik commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2. URL: https://github.com/apache/beam/pull/11355#issuecomment-611785115 > > Consider adding the logic here instead: > >

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-09 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-611782665 There appears to be a compilation failure in Java This is an

[GitHub] [beam] reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-09 Thread GitBox
reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#discussion_r406508479 ## File path: runners/core-java/src/main/java/org/apache/beam/runners/core/DoFnRunner.java ## @@

[GitHub] [beam] reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-09 Thread GitBox
reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#discussion_r406510585 ## File path:

[GitHub] [beam] reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-09 Thread GitBox
reuvenlax commented on a change in pull request #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#discussion_r406508585 ## File path: runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-09 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-611777422 Run Java Flink PortableValidatesRunner Streaming This is an

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-09 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-611777030 run flink validatesrunner This is an automated message from

[GitHub] [beam] reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods

2020-04-09 Thread GitBox
reuvenlax commented on issue #11154: [BEAM-1819] Key should be available in @OnTimer methods URL: https://github.com/apache/beam/pull/11154#issuecomment-611777072 run spark validatesrunner This is an automated message from

[GitHub] [beam] angoenka opened a new pull request #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle

2020-04-09 Thread GitBox
angoenka opened a new pull request #11365: [BEAM-9735] Adding Always trigger and using it in Reshuffle URL: https://github.com/apache/beam/pull/11365 R: @robertwb **Please** add a meaningful description for your change here Thank you for your

[GitHub] [beam] ananvay commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2.

2020-04-09 Thread GitBox
ananvay commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2. URL: https://github.com/apache/beam/pull/11355#issuecomment-611776464 LGTM This is an automated message from

[GitHub] [beam] reuvenlax merged pull request #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
reuvenlax merged pull request #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406502531 ## File path: sdks/java/container/license_scripts/license_script.sh ## @@ -0,0 +1,37 @@ + #

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406502326 ## File path: sdks/java/container/build.gradle ## @@ -16,7 +16,11 @@ * limitations under the

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406495748 ## File path: sdks/java/container/license_scripts/pull_licenses_java.py ## @@ -0,0 +1,186 @@

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
Hannah-Jiang commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406494846 ## File path: sdks/java/container/build.gradle ## @@ -68,6 +73,28 @@ golang { } } +//

[GitHub] [beam] alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406488322 ## File path: sdks/java/container/license_scripts/license_script.sh ## @@ -0,0 +1,37 @@ + #

[GitHub] [beam] alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406491805 ## File path: sdks/java/container/license_scripts/pull_licenses_java.py ## @@ -0,0 +1,186 @@ +#

[GitHub] [beam] alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r40641 ## File path: sdks/java/container/build.gradle ## @@ -68,6 +73,28 @@ golang { } } +//

[GitHub] [beam] alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java

2020-04-09 Thread GitBox
alanmyrvold commented on a change in pull request #11243: [BEAM-9136]Add licenses for dependencies for Java URL: https://github.com/apache/beam/pull/11243#discussion_r406487569 ## File path: sdks/java/container/build.gradle ## @@ -16,7 +16,11 @@ * limitations under the

[GitHub] [beam] dpmills commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
dpmills commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364#issuecomment-611764743 LGTM This is an automated message from the Apache Git

[GitHub] [beam] takidau commented on a change in pull request #11360: [WIP][BEAM-9722] added SnowflakeIO with Read operation

2020-04-09 Thread GitBox
takidau commented on a change in pull request #11360: [WIP][BEAM-9722] added SnowflakeIO with Read operation URL: https://github.com/apache/beam/pull/11360#discussion_r406491845 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java

[GitHub] [beam] y1chi commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2.

2020-04-09 Thread GitBox
y1chi commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2. URL: https://github.com/apache/beam/pull/11355#issuecomment-611764830 > Consider adding the logic here instead: >

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406491316 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406490454 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -1272,6 +1272,8 @@ def

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406490504 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -837,25 +869,59

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406490556 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@

[GitHub] [beam] reuvenlax commented on issue #10767: Document Beam Schemas

2020-04-09 Thread GitBox
reuvenlax commented on issue #10767: Document Beam Schemas URL: https://github.com/apache/beam/pull/10767#issuecomment-611758641 @iemejia the conflict appears to be in a file that should not be in this PR - looks like accidental keystrokes. @TheNeuralBit have you had time to look at

[GitHub] [beam] scwhittle commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
scwhittle commented on issue #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364#issuecomment-611756669 R: @dpmills @reuvenlax This is an automated

[GitHub] [beam] scwhittle opened a new pull request #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock

2020-04-09 Thread GitBox
scwhittle opened a new pull request #11364: [BEAM-9651] Prevent StreamPool and stream initialization livelock URL: https://github.com/apache/beam/pull/11364 Reduce StreamPool synchronized block section to not include stream creation which includes sending initial messages. Additionally

[GitHub] [beam] boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
boyuanzz commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406481820 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -1323,12 +1325,47 @@ def

[GitHub] [beam] lukecwik commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2.

2020-04-09 Thread GitBox
lukecwik commented on issue #11355: [BEAM-9727] Automatically set required experiment flags for dataflow runner v2. URL: https://github.com/apache/beam/pull/11355#issuecomment-611754766 retest this please This is an

[GitHub] [beam] chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-04-09 Thread GitBox
chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#discussion_r406479773 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -410,13

[GitHub] [beam] chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO

2020-04-09 Thread GitBox
chamikaramj commented on a change in pull request #11122: [BEAM-9346] Improve the efficiency of TFRecordIO URL: https://github.com/apache/beam/pull/11122#discussion_r406478334 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/WriteFiles.java ## @@ -410,13

[GitHub] [beam] lukecwik commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-04-09 Thread GitBox
lukecwik commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r406476510 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -454,6 +455,7 @@ class

[GitHub] [beam] lukecwik commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-04-09 Thread GitBox
lukecwik commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r406476510 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -454,6 +455,7 @@ class

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406471091 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406467481 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406468331 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406444781 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -1323,12 +1325,47 @@ def

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406444656 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -1272,6 +1272,8 @@ def

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406474463 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ## @@

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406466215 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@

[GitHub] [beam] robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements

2020-04-09 Thread GitBox
robertwb commented on a change in pull request #11314: [BEAM-9562] Send Timers over Data Channel as Elements URL: https://github.com/apache/beam/pull/11314#discussion_r406465514 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -837,25 +869,59

[GitHub] [beam] lukecwik edited a comment on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation.

2020-04-09 Thread GitBox
lukecwik edited a comment on issue #11350: [BEAM-1589] Added @onWindowExpiration annotation. URL: https://github.com/apache/beam/pull/11350#issuecomment-611749077 Any discussion about adding support for @OnWindowExpiration for portable runners?

[GitHub] [beam] lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test.

2020-04-09 Thread GitBox
lukecwik commented on issue #11319: [BEAM-9703]Include user distritribution into metric-dedicated validate runner test. URL: https://github.com/apache/beam/pull/11319#issuecomment-611748599 retest this please This is an

[GitHub] [beam] lukecwik merged pull request #11363: [BEAM-4374] Fix missing deletion of metrics.

2020-04-09 Thread GitBox
lukecwik merged pull request #11363: [BEAM-4374] Fix missing deletion of metrics. URL: https://github.com/apache/beam/pull/11363 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] boyuanzz commented on a change in pull request #11298: add 2.20.0 blog post

2020-04-09 Thread GitBox
boyuanzz commented on a change in pull request #11298: add 2.20.0 blog post URL: https://github.com/apache/beam/pull/11298#discussion_r406469566 ## File path: website/src/_posts/2020-03-01-beam-2.20.0.md ## @@ -0,0 +1,76 @@ +--- +layout: post +title: "Apache Beam 2.20.0"

[GitHub] [beam] lukecwik commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.

2020-04-09 Thread GitBox
lukecwik commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-611743983 Run Python PreCommit This is an automated message from the Apache

[GitHub] [beam] lukecwik commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.

2020-04-09 Thread GitBox
lukecwik commented on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-611743908 Run Python PreCommit" This is an automated message from the

[GitHub] [beam] lukecwik removed a comment on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup.

2020-04-09 Thread GitBox
lukecwik removed a comment on issue #11358: [BEAM-9729] Runner-side bundle registration cleanup. URL: https://github.com/apache/beam/pull/11358#issuecomment-611743908 Run Python PreCommit" This is an automated message from

[GitHub] [beam] ibzib merged pull request #11353: [BEAM-9726] Make region optional for non-service runner.

2020-04-09 Thread GitBox
ibzib merged pull request #11353: [BEAM-9726] Make region optional for non-service runner. URL: https://github.com/apache/beam/pull/11353 This is an automated message from the Apache Git Service. To respond to the message,

  1   2   3   >