Re: [PR] Bump com.gradle.enterprise from 3.15.1 to 3.17.2 [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31032: URL: https://github.com/apache/beam/pull/31032#issuecomment-2063001057 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 2.0.1 [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31033: URL: https://github.com/apache/beam/pull/31033#issuecomment-2063001028 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

[PR] Bump commons-cli:commons-cli from 1.6.0 to 1.7.0 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] opened a new pull request, #31034: URL: https://github.com/apache/beam/pull/31034 Bumps commons-cli:commons-cli from 1.6.0 to 1.7.0. [![Dependabot compatibility

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 2.0 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] commented on PR #30885: URL: https://github.com/apache/beam/pull/30885#issuecomment-2062980823 Superseded by #31033. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Bump com.gradle.enterprise from 3.15.1 to 3.17.2 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] opened a new pull request, #31032: URL: https://github.com/apache/beam/pull/31032 Bumps com.gradle.enterprise from 3.15.1 to 3.17.2. [![Dependabot compatibility

[PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 2.0.1 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] opened a new pull request, #31033: URL: https://github.com/apache/beam/pull/31033 Bumps com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 2.0.1. [![Dependabot compatibility

Re: [PR] Bump com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 2.0 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] closed pull request #30885: Bump com.gradle.common-custom-user-data-gradle-plugin from 1.12.1 to 2.0 URL: https://github.com/apache/beam/pull/30885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Bump com.gradle.enterprise from 3.15.1 to 3.17.1 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] closed pull request #30916: Bump com.gradle.enterprise from 3.15.1 to 3.17.1 URL: https://github.com/apache/beam/pull/30916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump com.gradle.enterprise from 3.15.1 to 3.17.1 [beam]

2024-04-17 Thread via GitHub
dependabot[bot] commented on PR #30916: URL: https://github.com/apache/beam/pull/30916#issuecomment-2062980782 Superseded by #31032. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] beam build error [Bug]: [beam]

2024-04-17 Thread via GitHub
zhoujianjun opened a new issue, #31031: URL: https://github.com/apache/beam/issues/31031 ### What happened? when I execute gradle clean in beam project root dir,build failed,error info is below: FAILURE: Build failed with an exception. 1A> Building buildSrc * Where:

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on code in PR #31013: URL: https://github.com/apache/beam/pull/31013#discussion_r1569812583 ## sdks/python/apache_beam/runners/common.py: ## @@ -761,6 +761,17 @@ def __init__(self, self.current_window_index = None self.stop_window_index = None

Re: [PR] Remove caching of global window side input param when invoking. [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on code in PR #30991: URL: https://github.com/apache/beam/pull/30991#discussion_r1569805506 ## sdks/python/apache_beam/runners/common.py: ## @@ -926,31 +922,16 @@ def _invoke_process_per_window(self, additional_kwargs,

Re: [PR] Updates Python Dev container used by Dataflow [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31029: URL: https://github.com/apache/beam/pull/31029#issuecomment-2062791159 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label python. Available commands: -

Re: [I] [Documentation Request]: Including reference to Dataflow Metrics exporter tool in README.md [beam]

2024-04-17 Thread via GitHub
svetakvsundhar commented on issue #31030: URL: https://github.com/apache/beam/issues/31030#issuecomment-2062770980 @damccorm @liferoad -- can we add this in our `Beam ReadMe` even though it isn't necessarily maintained by the "Beam" community? I'm thinking we can add a section called

Re: [PR] Replace Source type for BigTable and Kafka stress tests [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #30999: URL: https://github.com/apache/beam/pull/30999#issuecomment-2062765501 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @johnjcasey added as fallback since no labels match configuration

[PR] Updates Python Dev container used by Dataflow [beam]

2024-04-17 Thread via GitHub
chamikaramj opened a new pull request, #31029: URL: https://github.com/apache/beam/pull/31029 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] fix website embedding issue [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on PR #31019: URL: https://github.com/apache/beam/pull/31019#issuecomment-2062629026 waiting on author -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [PRISM] Connect Web UI cancel requests with backend [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31028: URL: https://github.com/apache/beam/pull/31028#issuecomment-2062625828 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569642022 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java: ## @@ -51,14 +54,14 @@ public class

[PR] Connect Web UI cancel requests with backend [beam]

2024-04-17 Thread via GitHub
damondouglas opened a new pull request, #31028: URL: https://github.com/apache/beam/pull/31028 # About This PR addresses #29669 connecting Web UI cancel requests with the backend Job Management server. # Changes - Fixes loading of CANCELED state for previously canceled

Re: [PR] Remove caching of global window side input param when invoking. [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on code in PR #30991: URL: https://github.com/apache/beam/pull/30991#discussion_r1569601398 ## sdks/python/apache_beam/runners/common.py: ## @@ -1086,6 +1053,9 @@ def _invoke_process_batch_per_window( kwargs_for_process_batch =

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569586395 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java: ## @@ -51,14 +54,14 @@ public class

Re: [PR] Add ScaleToGaussian TFTransform [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31026: URL: https://github.com/apache/beam/pull/31026#issuecomment-2062447067 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @tvalentyn for label python. Available commands: -

Re: [PR] Update KeysExample [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31027: URL: https://github.com/apache/beam/pull/31027#issuecomment-2062447021 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] Don't re-encode byte[] values in SortValues transform [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31025: URL: https://github.com/apache/beam/pull/31025#issuecomment-2062330830 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. Available commands: - `stop

[PR] Update KeysExample [beam]

2024-04-17 Thread via GitHub
regadas opened a new pull request, #31027: URL: https://github.com/apache/beam/pull/31027 Updates comment and variable names to reflect the proper intent. Thank you for your contribution! Follow this checklist to help us incorporate your

[PR] Add ScaleToGaussian TFTransform [beam]

2024-04-17 Thread via GitHub
jrmccluskey opened a new pull request, #31026: URL: https://github.com/apache/beam/pull/31026 Adds the `scale_to_gaussian` [Tensorflow Transform](https://github.com/tensorflow/transform/blob/fdef5f3fab6dd2dcade260cc80ec229948de448b/tensorflow_transform/mappers.py#L71) to `MLTransform` with

Re: [PR] Don't re-encode byte[] values in SortValues transform [beam]

2024-04-17 Thread via GitHub
clairemcginty commented on code in PR #31025: URL: https://github.com/apache/beam/pull/31025#discussion_r1569472136 ## sdks/java/extensions/sorter/src/main/java/org/apache/beam/sdk/extensions/sorter/SortValues.java: ## @@ -167,6 +170,55 @@ public void

[PR] Don't re-encode byte[] values in SortValues transform [beam]

2024-04-17 Thread via GitHub
clairemcginty opened a new pull request, #31025: URL: https://github.com/apache/beam/pull/31025 A small optimization for `SortValues` transform to avoid doubly roundtrip encoding values that are already `byte[]`s -- they can be passed directly to the Sorter.

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569460364 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java: ## @@ -51,14 +54,14 @@ public class

Re: [PR] Fix typo in count_unique_words() [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31023: URL: https://github.com/apache/beam/pull/31023#issuecomment-2062125990 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @shunping for label python. Available commands: - `stop

Re: [PR] Fix workflow param value for Grafana link [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31011: URL: https://github.com/apache/beam/pull/31011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] add new user info to metrics Readme [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #30989: URL: https://github.com/apache/beam/pull/30989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569449523 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java: ## @@ -51,14 +54,14 @@ public class

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569447460 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [I] [Task]: Re-enable schedule trigger for PostCommit Java IO Performance Tests [beam]

2024-04-17 Thread via GitHub
damccorm commented on issue #30787: URL: https://github.com/apache/beam/issues/30787#issuecomment-2062114945 I have #31024 to fix this once the 2.56 release is out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] Re-enable schedule trigger for PostCommit Java IO Performance Tests [beam]

2024-04-17 Thread via GitHub
damccorm opened a new pull request, #31024: URL: https://github.com/apache/beam/pull/31024 Once 2.56.0 is in, we can safely do this Fixes #30787 Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
tvalentyn merged PR #31021: URL: https://github.com/apache/beam/pull/31021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31020: URL: https://github.com/apache/beam/pull/31020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569421542 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java: ## @@ -51,14 +54,14 @@ public class

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569419609 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/ManagedSchemaTransformProvider.java: ## @@ -51,14 +54,14 @@ public class

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569413654 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [PR] remove CLOUDSDK from javausingpython dataflow xvr workflow [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31016: URL: https://github.com/apache/beam/pull/31016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [changes] Update CHANGES.md (#29939) (#31017) [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31022: URL: https://github.com/apache/beam/pull/31022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Fix typo in count_unique_words() [beam]

2024-04-17 Thread via GitHub
jrmccluskey opened a new pull request, #31023: URL: https://github.com/apache/beam/pull/31023 Small typo fix for a helper function Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Re: [PR] [changes] Update CHANGES.md (#29939) (#31017) [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #31022: URL: https://github.com/apache/beam/pull/31022#issuecomment-2062026778 R. @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [changes] Update CHANGES.md (#29939) (#31017) [beam]

2024-04-17 Thread via GitHub
je-ik opened a new pull request, #31022: URL: https://github.com/apache/beam/pull/31022 Cherry-pick #31017 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the

Re: [PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #31017: URL: https://github.com/apache/beam/pull/31017 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Managed Transform protos & translation; Iceberg SchemaTransforms & translation [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1569225112 ## model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/schema_aware_transforms.proto: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31013: URL: https://github.com/apache/beam/pull/31013#issuecomment-2062008850 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] fix website embedding issue [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31019: URL: https://github.com/apache/beam/pull/31019#issuecomment-2062014433 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowles for label website. Available commands: -

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
scwhittle commented on PR #31013: URL: https://github.com/apache/beam/pull/31013#issuecomment-2062005944 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31021: URL: https://github.com/apache/beam/pull/31021#issuecomment-2061941839 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on PR #31021: URL: https://github.com/apache/beam/pull/31021#issuecomment-2061940036 R: @aaltay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Allow IFrames to youtube. [beam]

2024-04-17 Thread via GitHub
tvalentyn opened a new pull request, #31021: URL: https://github.com/apache/beam/pull/31021 Partially address https://github.com/apache/beam/issues/30981 Thank you for your contribution! Follow this checklist to help us incorporate your

Re: [PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #31020: URL: https://github.com/apache/beam/pull/31020#issuecomment-2061937779 Will merge once checks complete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31020: URL: https://github.com/apache/beam/pull/31020#issuecomment-2061930085 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

[PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
je-ik opened a new pull request, #31020: URL: https://github.com/apache/beam/pull/31020 Cherry pick #30988 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the

Re: [PR] [runners-flink] remove 1.12 and 1.13 runners [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #31020: URL: https://github.com/apache/beam/pull/31020#issuecomment-2061923858 R: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
je-ik merged PR #30988: URL: https://github.com/apache/beam/pull/30988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix website embedding issue [beam]

2024-04-17 Thread via GitHub
tvalentyn commented on code in PR #31019: URL: https://github.com/apache/beam/pull/31019#discussion_r1569257366 ## website/www/site/content/en/get-started/resources/videos-and-podcasts.md: ## @@ -133,15 +133,14 @@ Strata+Hadoop World, New York, 2016 Presented by Kenneth

[PR] fix website embedding issue [beam]

2024-04-17 Thread via GitHub
svetakvsundhar opened a new pull request, #31019: URL: https://github.com/apache/beam/pull/31019 Fixes https://github.com/apache/beam/issues/30981 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [I] [Bug]: Side effect during the for loop execution in beam Pipeline [beam]

2024-04-17 Thread via GitHub
liferoad commented on issue #31014: URL: https://github.com/apache/beam/issues/31014#issuecomment-2061888279 For your first example, I think this is expected. the pipeline won't be executed after the entire pipeline is construct. After that, the variable `i` has the final value, which will

Re: [PR] [Testing] Try fixing inference benchmark tests [beam]

2024-04-17 Thread via GitHub
riteshghorse closed pull request #30855: [Testing] Try fixing inference benchmark tests URL: https://github.com/apache/beam/pull/30855 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Python] Update tensorflow version in relevant tests [beam]

2024-04-17 Thread via GitHub
riteshghorse closed pull request #30822: [Python] Update tensorflow version in relevant tests URL: https://github.com/apache/beam/pull/30822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31017: URL: https://github.com/apache/beam/pull/31017#issuecomment-2061846807 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

[PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
je-ik opened a new pull request, #31017: URL: https://github.com/apache/beam/pull/31017 Update CHNAGES.md Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the

Re: [PR] [changes] Update CHANGES.md (#29939) [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #31017: URL: https://github.com/apache/beam/pull/31017#issuecomment-2061844953 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
Polber commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061800255 > Given the uncertainty with what's going on here, another option is to put the changes in to the dataflow template itself in the short term. I'll draft up a PR for that -- This

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
Abacn commented on PR #30988: URL: https://github.com/apache/beam/pull/30988#issuecomment-2061799535 Also please open another PR to update CHANGES.md (changing on this PR will cause many test rerun) -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
Abacn commented on PR #30988: URL: https://github.com/apache/beam/pull/30988#issuecomment-2061797998 Java PreCommit failing test testExampleEchoPipeline (org.apache.beam.examples.subprocess.ExampleEchoPipelineTest) failed ```

Re: [PR] Enable BigQueryMetrics by default [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31015: URL: https://github.com/apache/beam/pull/31015#issuecomment-2061785502 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
robertwb commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061769275 Given the uncertainty with what's going on here, another option is to put the changes in to the dataflow template itself in the short term. -- This is an automated message from the

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
damccorm commented on code in PR #30976: URL: https://github.com/apache/beam/pull/30976#discussion_r1569161181 ## sdks/python/apache_beam/yaml/main.py: ## @@ -64,9 +72,19 @@ def _pipeline_spec_from_args(known_args): return pipeline_yaml +class

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
ahmedabu98 commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1569144621 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] remove CLOUDSDK from javausingpython dataflow xvr workflow [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31016: URL: https://github.com/apache/beam/pull/31016#issuecomment-2061727846 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop

Re: [PR] Minor updates to StreamingInsertsMetrics [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31003: URL: https://github.com/apache/beam/pull/31003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31000: URL: https://github.com/apache/beam/pull/31000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Use base 2 exponential histograms in BigQuerySinkMetrics [beam]

2024-04-17 Thread via GitHub
JayajP commented on code in PR #31000: URL: https://github.com/apache/beam/pull/31000#discussion_r1569127726 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySinkMetrics.java: ## @@ -106,15 +106,15 @@ static Counter

Re: [I] [Feature Request]: Support for Apache Flink 1.18 in Beam Runners [beam]

2024-04-17 Thread via GitHub
dan-clst commented on issue #30789: URL: https://github.com/apache/beam/issues/30789#issuecomment-2061699463 @thebozzcl looks like 1.17 support was just merged in https://github.com/apache/beam/pull/30197 -- This is an automated message from the Apache Git Service. To respond to

Re: [I] [Bug]: Uber jar not register coders causing `UnknownCoderWrapper` error [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on issue #30994: URL: https://github.com/apache/beam/issues/30994#issuecomment-2061688287 > Presumably this used to work and doesn't now? Or do we need better instructions on creating an uberjar that correctly preserves all the registration information? Yeah,

Re: [PR] Enable BigQueryMetrics by default [beam]

2024-04-17 Thread via GitHub
JayajP commented on PR #31015: URL: https://github.com/apache/beam/pull/31015#issuecomment-2061689237 Run Java Precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
robertwb commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061683074 So I'm still trying to figure out why these same tests pass in isolation ( https://github.com/apache/beam/actions/runs/8722508185/job/23928542728?pr=30976 ) but fail when all tests are

Re: [PR] Support BQ clustering with value provider [beam]

2024-04-17 Thread via GitHub
chamikaramj commented on code in PR #30460: URL: https://github.com/apache/beam/pull/30460#discussion_r1569109482 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java: ## @@ -455,8 +454,8 @@ public Row

Re: [PR] Add /job/cancel endpoint to prism web server. [beam]

2024-04-17 Thread via GitHub
damondouglas merged PR #30825: URL: https://github.com/apache/beam/pull/30825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [YAML] Add the ability to pre-process yaml files with jinja2. [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #30976: URL: https://github.com/apache/beam/pull/30976#issuecomment-2061635197 Oh whoops, missed https://github.com/apache/beam/pull/30976/commits/91d4dc1af683c87808048bc03ed180522b12c13d - thanks for catching -- This is an automated message from the Apache Git

Re: [PR] Revert "Docker - Remove Deprecated Types" [beam]

2024-04-17 Thread via GitHub
lostluck merged PR #31010: URL: https://github.com/apache/beam/pull/31010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] remove CLOUDSDK from javausingpython dataflow xvr workflow [beam]

2024-04-17 Thread via GitHub
volatilemolotov opened a new pull request, #31016: URL: https://github.com/apache/beam/pull/31016 CLOUDSDK env not needed here and is causing issues Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [PR] [yaml] add --providers and --providers_file flags [beam]

2024-04-17 Thread via GitHub
Polber closed pull request #30835: [yaml] add --providers and --providers_file flags URL: https://github.com/apache/beam/pull/30835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Propagate display_data to Job proto [beam]

2024-04-17 Thread via GitHub
Polber closed pull request #30809: Propagate display_data to Job proto URL: https://github.com/apache/beam/pull/30809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] [Bug]: Uber jar not register coders causing `UnknownCoderWrapper` error [beam]

2024-04-17 Thread via GitHub
robertwb commented on issue #30994: URL: https://github.com/apache/beam/issues/30994#issuecomment-2061613599 Long term, should we try to move away from autoservice for built in components (at least if standard uberjar building tools do not do the right thing with them)? Is this more

Re: [PR] Remove flink 1.12 1.13 [beam]

2024-04-17 Thread via GitHub
je-ik commented on PR #30988: URL: https://github.com/apache/beam/pull/30988#issuecomment-2061597620 Marking this as blocker for 2.56.0, this should be trivial to merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Create YAML Join Transform [beam]

2024-04-17 Thread via GitHub
damccorm commented on PR #30734: URL: https://github.com/apache/beam/pull/30734#issuecomment-2061559694 Merging to make the release cut; @Polber will follow up and do some additional validation, and we will cherry-pick any changes if needed -- This is an automated message from the Apache

Re: [PR] Create YAML Join Transform [beam]

2024-04-17 Thread via GitHub
damccorm merged PR #30734: URL: https://github.com/apache/beam/pull/30734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Change caching of global window inputs to be guarded by experiment [beam]

2024-04-17 Thread via GitHub
github-actions[bot] commented on PR #31013: URL: https://github.com/apache/beam/pull/31013#issuecomment-2061489406 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated

[PR] Enable BigQueryMetrics by default [beam]

2024-04-17 Thread via GitHub
JayajP opened a new pull request, #31015: URL: https://github.com/apache/beam/pull/31015 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] Flink 1.17 [beam]

2024-04-17 Thread via GitHub
je-ik merged PR #30197: URL: https://github.com/apache/beam/pull/30197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] add Yaml_Xlang_Direct PreCommit to README [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31009: URL: https://github.com/apache/beam/pull/31009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Cache parsed metrics in StreamingStepMetricsContainer [beam]

2024-04-17 Thread via GitHub
Abacn merged PR #31005: URL: https://github.com/apache/beam/pull/31005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug]: Uber jar not work with Dataflow runner v2 due to `UnknownCoderWrapper` for Beam 2.55 [beam]

2024-04-17 Thread via GitHub
Abacn commented on issue #30994: URL: https://github.com/apache/beam/issues/30994#issuecomment-2061431242 I see, so - the underlying issue---coder register auto service not working in uber jar packed in this way---always exist - some change on 2.55.0 makes prefix coder involved in

  1   2   >