Bash and PHP are mentioned.
AFAICT bash needs property `lexer.bash.styling.inside.string` set but the
default is unset.
Php styles `$word` inside strings as `SCE_HPHP_HSTRING_VARIABLE` so it depends
on what it maps to and what the theme set it to.
--
Reply to this email directly or view it
@b4n:
> Yet, does it currently matter?
Well if you are willing to maintain them in sync its fine. But who knows if a
security alert will require them to change libsoup3.1 API, its a web library
after all!
@xiota:
> You're too far ahead. Takes a while to catch up.
Just around longer, but
The desktop specification requires desktop managers (like Cinnamon) to search
the list of directories in `$XDG_DATA_DIRS` for desktop files and use the first
found only to add to menus, two applications with the same name cannot show in
any desktop spec compliant menu. Geany installs to
Lets move the build tool discussion elsewhere rather than polluting this FR
which has pointed to your plugin, but users have to compile it themselves.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/issues/1282#issuecomment-2080655894
You are
> just keep using the libsoup implementation
Yeah, but then its back to four plugins to synchronise on
libsoup3/webkit2gtk-4.1.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2080645295
You are receiving this because you
> Do Debian and Ubuntu even bother rebuilding packages for old releases?
Bugfixes, security fixes and those sorts of things, but rarely new versions.
To be honest @xiota has a point, if the plugin causes constraints on others we
need to look at what value it adds, and if it only works for one
@xiota:
> (win/mac – the platforms most likely to need update checkers).
has again pointed out the point I made a while back about this, its useful for
Windows and Macos, but for Linux it lies, just because the project releases a
new Geany does not put it in the distro they are using. And for
> hum… @elextr @xiota so what's your conclusion? Depend on libsoup3 as this PR
> because it's HTTP, or depend on a GVFS backend for HTTP?
Waiting for
https://github.com/geany/geany-plugins/pull/1340#issuecomment-2079741003
If it works `?` #1340 `:` #1336
--
Reply to this email di
Duplicate of #2736
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3857#issuecomment-2080307580
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3857 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3857#event-12629720274
You are receiving this because you are subscribed to this thread.
Message ID:
Closed #3855 as completed.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3855#event-12629711665
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr approved this pull request.
Bearing in mind my lack of knowledge of libsoup it looks ok.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1342#pullrequestreview-2026126069
You are receiving this because you are subscribed to this thread
@elextr commented on this pull request.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *uri;
+
+ /* document m
Well, I interpret the very first words in the readme "GVfs is a userspace
virtual filesystem implementation for GIO" to mean its part of GIO. IIUC it
provides the implementations for the abstract file/URL/dbus stream operations
in GIO and thats why you get an error if its not installed and you
> Looks like it depends on gvfs... After uninstalling...
Well, IIUC GVFS is _part_ of GIO (not to be confused with GnomeVFS), so if its
uninstalled its not surprising parts of GIO don't work.
But that probably means reading URLs won't work on Windows, dunno about Macos,
so back to the soup I
Yeah, `pkg-config` is the Freedesktop original, `pkgconf` would appear to be a
re-implementation. Your distro installs `pkgconf` and links the original
command to it so existing scripts will work, if they happen to conform to what
`pkgconf` considers "correct".
If an existing script fails
Unfortunately the GIO docs don't say when `g_file_new_from_URI()` and the
associated stream was supported (that I could see) but it works on the machine
I'm on ATM which is pretty olde.
PS I expect not everyone has your alias pkgconf == pkg-config :wink:
--
Reply to this email directly or
@xiota it would be great if you are willing to be maintainer for those plugins,
in that case simply make a PR changing the MAINTAINERS file with your details
for them. Geanylua is orphaned so thats no problem, and codebrainz has not
contributed to Geany or Geany-plugins for many years so
Geany plugins doesn't "freeze" changes, but yes it does slow them down with
reviews etc.
The benefit though is that it gets access to the Geany packagers to put it in
distros if its part of the plugins collection.
The real problem is plugins where there is no maintainer for the plugin to
@xiota neat, and simple, although it has one theoretical bug (though unlikely
in practice) [hint: what if 32 bytes were returned].
Just for general information, Geany used (a __long__ time ago) to avoid GIO,
which is probably why the plugin used libsoup directly. But now GIO is
required by
I don't know enough about libsoup to sensibly review (and don't have the time
to learn), but since Geany uses GIO why not `g_file_new_for_uri()` and
`g_file_read()` (or `g_file_read_async()/g_file_read_finish()` to not block the
UI) instead of using libsoup directly?
--
Reply to this email
@elextr approved this pull request.
LGBI except for one query.
> @@ -950,6 +1005,23 @@ gwh_browser_set_uri (GwhBrowser *self,
g_free (real_uri);
}
+gboolean
+gwh_browser_set_uri_from_document (GwhBrowser*self,
+ GeanyDocument *doc)
+{
+ gchar *
As @xiota says, the plugin is still a work in progress, but I'm sure they would
be happy to have someone testing it.
When it is complete they may wish to add it to the plugins collection, in which
case they need to raise a PR to add it, like #1331 or #1337, or they may decide
to keep it
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. I
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. I
@b4n said:
> if the replacement contains the search term, it'll be replaced recursively
> forever (infinite loop + steady memory growth).
@xiota said:
> replace_all searches for needle starting from the beginning of haystack. If
> replacement contains needle, the result is an infinite loop.
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. I
Parsing is not sufficient for new languages, it needs semantics as well.
For example inferred types need semantics like type evaluation of expressions,
for example C++ `auto f = 1 + 1.0;` has to know the semantics of mixed type
arithmetic `1 + 1.0` to get the result type as `float` and then
@elextr commented on this pull request.
> @@ -185,15 +191,30 @@ version_compare(const gchar *current_version)
}
-static void update_check_result_cb(SoupSession *session,
-SoupMessage *msg, gpointer user_data)
+static gchar *bytes_to_string(GBytes *bytes)
+{
+gsize bytes_s
Not very helpful but it shows the problem is entirely within the
GTK/GIO/GObject/Glib libraries, the only Geany code present is the initial call
to GTK.
So its something in the version of those libraries that doesn't like your X11.
Is it actual Xorg X11 or XWayland?
--
Reply to this email
https://sourceware.org/gdb/current/onlinedocs/gdb#Backtrace
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2736#issuecomment-2075917818
You are receiving this because you are subscribed to this thread.
Message ID:
When it stops at "(gdb)" type "backtrace" and return.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2736#issuecomment-2075915174
You are receiving this because you are subscribed to this thread.
Message ID:
Without a backtrace have no idea whats wrong.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2736#issuecomment-2075906669
You are receiving this because you are subscribed to this thread.
Message ID:
Need the whole backtrace, and watch it might print some and ask if you want to
continue.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/2736#issuecomment-2075878844
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr commented on this pull request.
> @@ -26,9 +26,9 @@ Prominent features
Requirements
-This plugin requires GTK+ (>= 2.16), GLib (>= 2.16), GIO (>= 2.18),
-GdkPixbuf (>= 2.0), WebKitGTK (>= 1.1.18), and obviously Geany (>= 0.20) to
-work. I
Needs to update README
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1335#issuecomment-2074723649
You are receiving this because you are subscribed to this thread.
Message ID:
Maybe should update the requirements section of README as well.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1295#issuecomment-2074716996
You are receiving this because you are subscribed to this thread.
Message ID:
If by UI font you mean everything except the editor pane then you need to set
it in `geany.css` I think since Windows font settings won't be transferred to
the GTK themes.
--
Reply to this email directly or view it on GitHub:
> Plus browsers are sort of crazy, so I don't think mimicking their behavior is
> necessarily a good idea.
+1, I just tried Chrome, sometimes it went to previous, sometimes to the one on
the right, I can't tell what makes the decision.
I think (without checking) in Geany it is simply that
LGBI, the removals look good but did not check thats all that needs removing.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1335#issuecomment-2074588921
You are receiving this because you are subscribed to this thread.
Message ID:
IIRC someone commented somewhere that the behaviour mirrors what browsers do.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3855#issuecomment-2074551017
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n, the highlighted text was copied from part way down
[this](https://docs.oracle.com/en/java/javase/22/language/local-variable-type-inference.html)
page (about para 4). Making it a predefined typename is how "contextuality"
is implemented I guess, as it is a typename it makes `var i = 10;`
There were already some mumblings about a point release due to fixes of
potential crashes being merged IIUC, and hopefully the next release won't be as
far away as 2.0 was from 1.38, but its hard to tell.
--
Reply to this email directly or view it on GitHub:
IIUC any Ubuntu 20.04 LTS or derivative (eg Linux Mint 20) does not have
webkit2gtk-4.1.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1232#issuecomment-2073939609
You are receiving this because you are subscribed to this thread.
Message ID:
LGBI but someone needs to test it.
The problem is that the markdown plugin has been in and out of plugins due to
its delayed GTK3 port so its not clear how many users there are, and its likely
to go away again due to wekkit2gtk-4.1 (see
I don't understand your image:
1. it does not use `var`
2. the class `Var` is highlighted correctly
Oracle says `var is a reserved type name, not a keyword` so not sure how its
meant to be highlighted.
--
Reply to this email directly or view it on GitHub:
@elextr commented on this pull request.
> @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs
gbooleanuse_current_file_dir; /* find in files directory to
use on showing dialog */
gbooleanhide_find_dialog; /* hide the find dialog
on n
Which plugin did you mean? There are four listed in the previous two comments.
Since I would think that it is not possible to load old and new versions of
webkit2gtk and libsoup at the same time probably the version needs to be
selected once and builds of all four need to disable them if the
@ineuw to be fair to us, you are not just installing, you are building and
installing, and building is a development activity that assumes that you know
enough to install the relevant tools, because its not the job of every project
to teach the tools they use.
You have not specified what
@b4n the only one that I would question is the one that @eht16 had questioned,
so I was waiting until that was decided. :-P
"Data contains NULs" is referring to the result of the conversion, but the user
doesn't know that, they only have the input file and it may not contain NULs,
eg it might
@elextr requested changes on this pull request.
LGBI except the ABI thing.
> @@ -60,6 +60,8 @@ typedef struct GeanySearchPrefs
gbooleanuse_current_file_dir; /* find in files directory to
use on showing dialog */
gbooleanhide_find_dialog; /* h
Well, Ubuntu LTS 20.04 has a year of support left (April 2025) and it has Meson
0.54, maybe it has to be `#ifdef`ed (or whatever the meson equivalent is) to
change what it uses at 0.56 to get rid of the message.
Kind of annoying that a Windows only feature causes a message on Linux, maybe
@eht16 sure, doesn't break anything if nobody wants to fix it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3656#issuecomment-2068044244
You are receiving this because you are subscribed to this thread.
Message ID:
The problem with loading all external tags into the wordlists is that the
lexers only recognise syntactic elements, in this case "identifier" and not the
semantics that it is a typename or a function name. Also they have no
knowledge of scope and no way to pass that information to them.
The
The Pascal parser only recognises functions and procedures, it would need
extending (upstream in uctags) to recognise type declarations before anything
can happen in Geany.
And as @b4n says, only type names are passed to the lexer for highlighting.
--
Reply to this email directly or view it
@elextr approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3846#pullrequestreview-2013080468
You are receiving this because you are subscribed to this thread.
Message ID:
> And so you think I should use NFKC rather than NFC?
I had another look at UAX#15 and its not really clear that either is better,
both are likely to get different things wrong/right, selecting initials isn't
what they are made for, so `(rand() % 100) > 50 ? "yes" : "no"` :-)
--
Reply to this
> How should this be identified then? Just by ranges or something?
Its a while since I came across this, but IIRC there is a separate indic
setting in the unicode standard that says something about how it combines,
because the rules of indic languages are complex (see comments above ;-)
> If
@elextr commented on this pull request.
> gchar *utils_get_initials(const gchar *name)
{
- gint i = 1, j = 1;
- gchar *initials = g_malloc0(5);
+ GString *initials;
+ gchar *composed;
+ gboolean at_bound = TRUE;
+ gboolean prev_matched = FA
@elextr commented on this pull request.
> @@ -766,21 +766,47 @@ gchar *utils_get_date_time(const gchar *format, time_t
> *time_to_use)
}
+/* Extracts initials from @p name, with some Unicode support */
+GEANY_EXPORT_SYMBOL
Ok.
--
Reply to this email directly or view it on GitHub:
Having the ability to set the filetype of new files is reasonable, just add a
setting to `Edit->Preferences->Files->New Files` with a combo box to select the
filetype. The semantics can simply be the same as `Files->New` then
`Document->Set filetype->[what the setting says]`.
--
Reply to
> The current behavior does not indent anything
What I mean is that the usual use case is to type return to get a new line to
paste on, but that indents with the usual settings for Python, so extra indent
is added to the first line unless the user does return then backspaces to
remove the
And what about pasting Python (or other offside languages)?
Are we pasting:
1. _at_ the levels indicated by the clipboard indentation, or
2. _at_ the level at the cursor, or
3. _into_ the level at the cursor?
So just taking deltas into account is still not enough because of 2. vs 3.
Too
@elextr requested changes on this pull request.
Neat.
Its not perfect (eg Indic combining chars have class 0), but at least it should
not result in invalid strings and the user can always override it with the
preference.
> @@ -766,21 +766,47 @@ gchar *utils_get_date_time(const gchar *for
The
[manual](https://www.geany.org/manual/current/index.html#configuration-file-paths)
tells you where Geany is looking.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-themes/issues/72#issuecomment-2066279241
You are receiving this because you are
> this is (for better or for worse) a util function
Well only within Geany, its not available to plugins. Its just located in a
file called `utils.c` but its not really a util, it seems unlikely that any
other part of Geany will need a function that returns the _byte_ (not
character) after
This is a function that has only a single user but has been pulled out and put
in another file to make life more complicated instead of doing it locally where
the conditions of the parameters are visible [end rant].
The overflow is when name is `\0` and the use probably thinks it is never
There are some reports of weirdnesses with XWayland and GTK, which have been
fixed by running Geany as Wayland as I mentioned. But havn't had any reports
that can be traced to real xorg and GTK (that my quick search on Geany issues
found anyway), and it is just fine on my Linux Mint (which is
Sounds like something is wrong with your brand new Ubuntu.
Are you running Wayland? If so try `GDK_BACKEND=wayland geany`.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/issues/3843#issuecomment-2058899522
You are receiving this because you are subscribed
Its hard to say anything except that the problem occurs inside the X11 library
called from GDK called from GTK during the initialisation of the displays
called from Geany at line `#11`. We don't even know the version of Geany.
--
Reply to this email directly or view it on GitHub:
You can copy the whole configuration directory back and forwards but the
experience might not be totally acceptable since:
1. session files, recent files, and other paths are likely to be in different
locations
2. tools settings may not be the same between Windows and Linux
3. some settings may
The Php lexer (part of the HTML lexer) sets the styling, but only has one word
list (see
[here](https://github.com/geany/geany/blob/32bbe106195f953e980bfa756b5a7ccad1ee209d/scintilla/lexilla/lexers/LexHTML.cxx#L724))
which is used as you noticed for the Php words. The lexer is purely
Not knowing what language you are using its hard to help, does the lexer
recognise style something as "function" ?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/discussions/3840#discussioncomment-9117972
You are receiving this because you are subscribed
@ntrel You seem to have misunderstood the point of my objection. The problem
was the process, merging a change before others had the chance to assess it,
not that there was a technical problem with the PR. Since as I noted I had not
had time to see its contents I could not be commenting on
@frlan as devhelp has been removed just close it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/93#issuecomment-2054307272
You are receiving this because you are subscribed to this thread.
Message ID:
Does Filezilla set the file modified date/time of the file to the remote file
date/time each upload?
If so it won't change if the file on disk has not changed since the last upload
(the scenario you describe above "... but haven't saved it").
As Geany uses the modified date/time of the file
LGBI.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3833#issuecomment-2054035862
You are receiving this because you are subscribed to this thread.
Message ID:
> (I did the cinnamon install and I don't have nautilus).
Welcome to the light ;-)
As the default `xdg-open %d` opens a file manager then thats safe, it won't
open some random software on the users system. If they change the setting they
are responsible for the consequences.
So my opinion
> It was open for a week
Availability of our contributors is limited, a week is nowhere near time that
guarantees people have time to notice, and review it. Most only have weekends,
but if they are busy one weekend they have missed your PR.
> you didn't object to the change after seeing it
@elextr commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
@b4n I am normally the one complaining about single use functions where a lump
of functionality is broken out for no good rea
> hum… sounds hacky, but might happen to work, I don't know.
Totally hacky :-). But if it works it keeps the scrolling under Scintilla's
control and IIUC Scintilla makes attempts to match the environment scrolling
speed.
--
Reply to this email directly or view it on GitHub:
> The mouse wheel would look broken if scrolling stopped when control is
> accidentally pressed.
Hmm, ok, in that case is it safe for us to simply edit the event to remove the
control mask then let it go to Scintilla, maybe @b4n knows, or you could try it.
--
Reply to this email directly or
I had a short time to try things.
Based on your status window code, set `wrap-mode` and `wrap-width` (which is
pixels not characters).
Testing with status window on the right so the width can be changed with the
pane separator sees wrapping happen fine at the set `wrap-width` or the window
@elextr commented on this pull request.
> +void sci_scroll_lines(ScintillaObject *sci, gint lines)
+{
+ SSM(sci, SCI_LINESCROLL, 0, (uptr_t) lines);
+}
+
+
Disagree with @b4n, all Scintilla interfacing should go through wrappers so
that changes Scintilla makes can be abstracted a
@ntrel, where does anybody say they have tested or reviewed this?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3816#issuecomment-2053823635
You are receiving this because you are subscribed to this thread.
Message ID:
Why is it transforming ctrl+scroll to scroll differently (as @b4n pointed out
on the code) instead of doing nothing when `scrollwheel_zoom_disable` is set?
On #2954 you say:
> I have the editor font sent to a comfortable size. Many shortcuts consist of
> combining the Control key with
According to the GTK wrap-mode link in your OP the `wrap-width` property also
needs to be set as well, its not in your WIP commit so unless its already set
somewhere else in Geany it needs to be added.
Note the Python code sets `wrap-width`.
--
Reply to this email directly or view it on
The Scintilla editing widget Geany uses only recently added the capability with
the new [element
API](https://www.scintilla.org/ScintillaDoc.html#ElementColours), but Geany
does not expose it, well written PRs that integrate it into colour schemes are
welcome.
--
Reply to this email directly
> all I was saying was that wrapping is not always an improvement.
Ok, true, which suggests having a menu item to turn it on and off quickly and
easily, not a preference.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3816#issuecomment-2052987288
You
Probably cleaner to make a new one
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/2954#issuecomment-2050941280
You are receiving this because you are subscribed to this thread.
Message ID:
Just thinking about it again, rather than waiting for Scintilla to get the
ctrl+scroll and then resetting it, a better way would be to intercept the event
in Geany
[here](https://github.com/geany/geany/blob/dbaf99e3528a2f9007c4ab0ced416bdd87c22574/src/editor.c#L4778)
and not propagate it to
> who start by @, but I can't color them.
The Rust lexer does not detect them as identifiers, its identifier code is:
```c++
static bool IsIdentifierStart(int ch) {
return (IsASCII(ch) && (isalpha(ch) || ch == '_')) || !IsASCII(ch);
}
/* This isn't quite right for Unicode identifiers */
The visible whitespace artefacts are drawn by Scintilla which only allows one
foreground and one background setting to cover both spaces and tabs and it has
no way of controlling the dot size. There is a setting to remove the head of
the tab (so its just the horizontal line) which has not
> Often when doing Find in Files I'm not interested in any matches on long
> lines (e.g. text files), I'm only interested in matches in code which are
> almost always short lines. Wrapping would just add more vertical noise (in
> this case).
See your use-case and raise you a different
> The difference with opening a terminal or file manager from the desktop, is
> that this opens it inside the same directory as the file, saving a whole lot
> of time compared to manually navigating to the same directory.
I knew that the file manager opened in the current file directory, but I
Agree, improving input validation is a better solution since the command return
error does not actually identify the error.
LGBI
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3818#issuecomment-2043949401
You are receiving this because you are
Don't know why its disabled, perhaps there were problems on GTK2. But if it
works ok why not, finding "required from here" in 3000 lines of C++ errors from
one misplaced character could be very useful :grin:.
--
Reply to this email directly or view it on GitHub:
There is probably something wrong with the theme, note the text in the document
tree is white. Customisations can be put in `Tools->Configuration
Files->geany.css` but as this project isn't responsible for the theme we can't
advise what you need to change, you will need to look at the theme
If I read the linked notepad issue correctly notepad can't undo the reload, so
truncating there makes sense, but Geany can undo the reload (depending on the
option but its default is true IIRC) like Scite. So as Neil says on the
Scintilla issue, (thanks for finding, I thought I had seen it
@elextr approved this pull request.
Agree its a better idea to put the common parts in the shared function and the
different parts in the callers.
Not tested but LGBI.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3826#pullrequestreview-1987842008
201 - 300 of 6768 matches
Mail list logo
