(Merging as it is to avoid complicating things further.)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1755019676
You are receiving this because you are subscribed to this thread.
Message ID:
Merged #3547 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#event-10602619740
You are receiving this because you are subscribed to this thread.
Message ID:
@techee I don't think it matters much here (but maybe the "all all"? :grin:),
but it could also be one single commit (basically your first one already
combines various things together)
--
Reply to this email directly or view it on GitHub:
Should I somehow squash the commits or is it OK to merge it as it is?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1754907758
You are receiving this because you are subscribed to this thread.
Message ID:
@elextr approved this pull request.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#pullrequestreview-1665860120
You are receiving this because you are subscribed to this thread.
Message ID:
@techee commented on this pull request.
> if (! first && have_best)
- /* For translators: it's the filename and line number
of a symbol in the goto-symbol popup menu */
- text = g_markup_printf_escaped(_("%s:%lu: %s"),
fname,
@techee pushed 1 commit.
3fbc4269063230facc8104b8cab0bd5c74de3fe6 Remove translatable strings where not
needed
--
View it on GitHub:
https://github.com/geany/geany/pull/3547/files/0764b642b64f54af8f11e8dd07a9c60dd2a21acc..3fbc4269063230facc8104b8cab0bd5c74de3fe6
You are receiving this because
@b4n commented on this pull request.
> if (! first && have_best)
- /* For translators: it's the filename and line number
of a symbol in the goto-symbol popup menu */
- text = g_markup_printf_escaped(_("%s:%lu: %s"),
fname, tmtag->line,
@techee commented on this pull request.
> if (! first && have_best)
- /* For translators: it's the filename and line number
of a symbol in the goto-symbol popup menu */
- text = g_markup_printf_escaped(_("%s:%lu: %s"),
fname,
Works (with 10 mins testing) and aligning the signatures makes file:line much
easier to distinguish from the signature. And code looks ok by quick
inspection except the translation comments.
--
Reply to this email directly or view it on GitHub:
@elextr commented on this pull request.
Looks ok by quick inspection
> if (! first && have_best)
- /* For translators: it's the filename and line number
of a symbol in the goto-symbol popup menu */
- text =
I'll test it a bit but I quite like it at the moment. And it basically adds a
new column from what I think I remember was the previous release (if I can
still remember), so it's almost less different, yet adding the extra info
@ntrel wanted, and that I grew to like as well.
I agree that it
Regardless of whether this PR gets used for the next release, I just tested the
Colomban's code and added his patch to this PR (I just updated the "For
translators" strings). It works and looks great IMO and my personal vote would
be to use this patch for the next release.
--
Reply to this
@techee pushed 1 commit.
0764b642b64f54af8f11e8dd07a9c60dd2a21acc Align all all signatures in the goto
tag popup
--
View it on GitHub:
https://github.com/geany/geany/pull/3547/files/188038a06a1050308fd7621f11147883d7e5b8fc..0764b642b64f54af8f11e8dd07a9c60dd2a21acc
You are receiving this
> The problem is that that now it looks this way:
What I mean is, yes its very ugly[^1], and that makes it hard for humans to
use, but it doesn't crash or provide wrong information. We seem to have
concentrated on C++ (probably my fault) but its likely to be useful for simple
situations (ie
> So I'm thinking this shouldn't be rushed into 2.0, it certainly is still
> needed until LSP is more widely available, but its not a bug that needs
> fixing NOW!!
The problem is that that now it looks this way:
https://github.com/geany/geany/pull/3475#issuecomment-1540476259
and this is a
> Just a shameless promotion - with my LSP plugin the clangd server seems to
> always return the "right" symbol based on its true visibility from the given
> position so no popup like that seems to be necessary.
You took the words right out my mouth, thats what happens with Vscode using LSP
> There is a LSP plugin for Geany? Nice, I should give that a try :)
See https://github.com/techee/geany-lsp
and https://github.com/geany/geany/pull/3571
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751821714
You are receiving
> The disadvantage of your version is that the popup could get much bigger in
> some extreme cases but I think it's acceptable.
Yeah, if we want we can also limit the symbol side under 80 if it's a concern
-- although again, if there isn't enough info it can stop being useful.
> (Just a
> PS: this has string changes, not sure how bad that is for release… but I
> think this PR might be worth sorting out anyway.
Yes, I am aware of that and I actually talked with @frlan about it today in
person at Prague Linux Days. And he wasn't too serious about the string freeze
in this case.
> I really dislike italics, I think it makes things a lot harder to read, and I
> don't see the need (esp. as the symbol part has a different font). We had
> them before but only for the non-best match, which is IMO better. If you
> wanna keep them, let's only do so for those, not for the bold
PS: this has string changes, not sure how bad that is for release… but I think
this PR might be worth sorting out anyway.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751803793
You are receiving this because you are subscribed to
First thoughts:
* I really dislike italics, I think it makes things a lot harder to read, and I
don't see the need (esp. as the symbol part has a different font). We had them
before but only for the non-best match, which is IMO better. If you wanna keep
them, let's only do so for those, not
> @techee I haven't looked at the code, but the screenshot and description look
> fine. Much better than just showing file and line like the last release and
> before.
OK, good to hear, thanks.
--
Reply to this email directly or view it on GitHub:
@techee I haven't looked at the code, but the screenshot and description look
fine. Much better than just showing file and line like the last release and
before.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751132767
You are
@ntrel Any opinion on this PR and how it behaves? Does it look acceptable or
would you prefer something else?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1751108921
You are receiving this because you are subscribed to this thread.
I've just added the 2.0 milestone to this issue as I think it should be fixed
some way. I don't insist it should be done exactly the way this patch proposes
- some other variant is of course possible too. Or we could revert back to the
original behavior.
--
Reply to this email directly or
> you should always see what you saw in the previous Geany releases and it's
> the extra part could possibly be truncated.
Ok, neat.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3547#issuecomment-1691186531
You are receiving this because you are
> To be clear the former was a question, did the answer mean fixed width 80
> chars? Or is it fixed width user settable, default 80?
It's fixed 80 now. But if it started truncating paths, we could also get the
`max_path_length` and set the length to `MAX(80, max_path_length)` to make sure
we
> This is done using HTML tags like , , , , etc.
Ahh, ok, I guess it gets more complex to use a full font spec that can be set
from a dialog in prefs.
> I'd expect that GTK does something reasonably sane
sane? GTK? no chance!!
> > how is the list width set,
> ... unless the path is over 80
> differing fonts is a good idea, but probably means they should be user
> settable, we don't know their screen and eye resolution and forcing using a
> smaller font may make it hard to read for some people who might like bold for
> example instead.
This is done using HTML tags like ``, ``,
First thoughts
1. I don't hate it [^1]
2. differing fonts is a good idea, but probably means they should be user
settable, we don't know their screen and eye resolution and forcing using a
smaller font may make it hard to read for some people who might like bold for
example instead.
3. how is
32 matches
Mail list logo
