kiszk commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-729580682
@pitrou Sounds good, I will close this PR.
This is an automated message from the Apache Git Service.
To respond to
Ulimo commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r526016969
##
File path:
csharp/src/Apache.Arrow.Flight/Reader/RecordBatcReaderImplementation.cs
##
@@ -0,0 +1,110 @@
+// Licensed to the Apache Software Foundation
github-actions[bot] commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-729562831
https://issues.apache.org/jira/browse/ARROW-10634
This is an automated message from the Apache Git
jorisvandenbossche commented on pull request #8677:
URL: https://github.com/apache/arrow/pull/8677#issuecomment-729632072
Indeed, it seems the full `test_ipc.py` file is being skipped on the "Python
3.8 Without Pandas" build
pitrou opened a new pull request #8703:
URL: https://github.com/apache/arrow/pull/8703
ArrayEquals now defers to ArrayRangeEquals under the hood.
ArrayRangeEquals now allows passing an EqualOptions argument.
Also add ArrayRangeApproxEquals.
Comparison speed is massively
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r525984128
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Ulimo opened a new pull request #8702:
URL: https://github.com/apache/arrow/pull/8702
Upgraded build version to 3.1 and C# version to 8.
Also added EmbedUntrackedSources so auto generated code will work with
sourcelink.
pitrou commented on pull request #8674:
URL: https://github.com/apache/arrow/pull/8674#issuecomment-729570863
@kiszk I will, unless you beat me to it.
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on pull request #8703:
URL: https://github.com/apache/arrow/pull/8703#issuecomment-729584943
https://issues.apache.org/jira/browse/ARROW-10143
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-729554537
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r525984998
##
File path: rust/arrow/src/compute/kernels/comparison.rs
##
@@ -570,27 +570,26 @@ where
));
}
-let num_bytes =
Ulimo commented on pull request #8702:
URL: https://github.com/apache/arrow/pull/8702#issuecomment-729559868
I did not change the version under examples, should
FluentBuilderExample.csproj also be updated to 3.1?
This is an
vertexclique commented on a change in pull request #8701:
URL: https://github.com/apache/arrow/pull/8701#discussion_r526013126
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -111,7 +111,22 @@ pub fn not(left: ) -> Result {
vertexclique commented on a change in pull request #8701:
URL: https://github.com/apache/arrow/pull/8701#discussion_r526013126
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -111,7 +111,22 @@ pub fn not(left: ) -> Result {
sighingnow commented on pull request #8677:
URL: https://github.com/apache/arrow/pull/8677#issuecomment-729642276
Hi @jorgecarleitao Then could we get this one merged first ? Or should I
enable pandas with python 3.8 tests on github workflow?
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r525980049
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
jorisvandenbossche commented on pull request #8677:
URL: https://github.com/apache/arrow/pull/8677#issuecomment-729633901
But don't we have a ursabot build with python 3.8? (they don't seem active /
be triggered on this PR, though)
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526346099
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
sunchao commented on pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#issuecomment-729911859
Unrelated: there is also the [fuzz
module](https://github.com/sunchao/parquet-rs/tree/master/fuzz) which is quite
useful for detecting bad crashes in the code. It probably worth
yordan-pavlov commented on a change in pull request #8630:
URL: https://github.com/apache/arrow/pull/8630#discussion_r526371625
##
File path: rust/arrow/src/buffer.rs
##
@@ -888,6 +888,15 @@ impl MutableBuffer {
}
self.len += bytes.len();
}
+
+///
alamb commented on pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#issuecomment-729809822
Here is a potential contribution to this effort:
https://github.com/apache/arrow/pull/8708 (a PR with the bench marks ported --
fyi @GregBowyer ).
To run:
```
cd
jorgecarleitao commented on a change in pull request #8630:
URL: https://github.com/apache/arrow/pull/8630#discussion_r526252139
##
File path: rust/arrow/src/buffer.rs
##
@@ -888,6 +888,15 @@ impl MutableBuffer {
}
self.len += bytes.len();
}
+
+///
jhorstmann commented on pull request #8686:
URL: https://github.com/apache/arrow/pull/8686#issuecomment-729823739
@nevi-me @vertexclique thanks for the reviews. I put the json dependency now
behind a `json_output` feature gate and fixed the clippy warning.
andygrove commented on pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#issuecomment-729838339
Build error seems unrelated to these changes.
This is an automated message from the Apache Git Service.
To
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526358664
##
File path: rust/arrow/src/buffer.rs
##
@@ -258,39 +259,52 @@ impl Buffer {
/// Returns a slice of this buffer starting at a certain bit
Ulimo commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r525941887
##
File path: .github/workflows/csharp.yml
##
@@ -38,8 +38,12 @@ jobs:
strategy:
fail-fast: false
matrix:
-dotnet: [2.2.103]
+
lidavidm opened a new pull request #8707:
URL: https://github.com/apache/arrow/pull/8707
On Windows, gRPC sometimes gives us a blank peer address.
This is an automated message from the Apache Git Service.
To respond to the
andygrove commented on pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#issuecomment-729825709
@jorgecarleitao @alamb This adds the Rust-native utility to convert the
TPC-H data to CSV and Parquet.
I will create follow-on PRs to add support for re-partitioning the
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526309397
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526344874
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
kiszk closed pull request #8674:
URL: https://github.com/apache/arrow/pull/8674
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #8707:
URL: https://github.com/apache/arrow/pull/8707#issuecomment-729801384
https://issues.apache.org/jira/browse/ARROW-10646
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8706:
URL: https://github.com/apache/arrow/pull/8706#issuecomment-729801385
https://issues.apache.org/jira/browse/ARROW-10032
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#issuecomment-729801386
https://issues.apache.org/jira/browse/ARROW-10464
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8704:
URL: https://github.com/apache/arrow/pull/8704#issuecomment-729801389
https://issues.apache.org/jira/browse/ARROW-10644
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#issuecomment-729811338
https://issues.apache.org/jira/browse/ARROW-10647
This is an automated message from the Apache Git
jorgecarleitao commented on a change in pull request #8630:
URL: https://github.com/apache/arrow/pull/8630#discussion_r526252139
##
File path: rust/arrow/src/buffer.rs
##
@@ -888,6 +888,15 @@ impl MutableBuffer {
}
self.len += bytes.len();
}
+
+///
alamb commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526371716
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
alamb commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526371341
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
yordan-pavlov commented on a change in pull request #8630:
URL: https://github.com/apache/arrow/pull/8630#discussion_r526371625
##
File path: rust/arrow/src/buffer.rs
##
@@ -888,6 +888,15 @@ impl MutableBuffer {
}
self.len += bytes.len();
}
+
+///
nevi-me commented on pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#issuecomment-729813794
This will also close https://issues.apache.org/jira/browse/ARROW-4063
This is an automated message from the
sunchao commented on a change in pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#discussion_r526370843
##
File path: rust/parquet/benches/codec.rs
##
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
lidavidm opened a new pull request #8706:
URL: https://github.com/apache/arrow/pull/8706
Update the docs on replicating the AppVeyor build.
This is an automated message from the Apache Git Service.
To respond to the message,
aibaars commented on pull request #7926:
URL: https://github.com/apache/arrow/pull/7926#issuecomment-729804800
@alamb @kszucs I ran into the same error on one of our repositories and were
pointed to https://github.com/actions/cache/issues/403#issuecomment-678348989
by a colleague .
alamb opened a new pull request #8708:
URL: https://github.com/apache/arrow/pull/8708
This PR ports the parquet benchmarks from the original
[parquet-rs](https://github.com/sunchao/parquet-rs/tree/master/benches) repo in
service of helping to get https://github.com/apache/arrow/pull/8698
alamb commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526364599
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
jorisvandenbossche commented on pull request #8677:
URL: https://github.com/apache/arrow/pull/8677#issuecomment-729705678
> Then could we get this one merged first ?
Ideally we would first ensure we have such a build, so we can know it is
failing before applying this patch (so we
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526137607
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
Fonsan commented on a change in pull request #8661:
URL: https://github.com/apache/arrow/pull/8661#discussion_r526204115
##
File path: docs/source/format/Columnar.rst
##
@@ -1053,7 +1053,7 @@ the dictionaries can be properly interpreted: ::
The dictionary ``id`` in the
andygrove opened a new pull request #8705:
URL: https://github.com/apache/arrow/pull/8705
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Ulimo commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r526102674
##
File path:
csharp/test/Apache.Arrow.Flight.TestWeb/Apache.Arrow.Flight.TestWeb.csproj
##
@@ -0,0 +1,16 @@
+
+
+
+netcoreapp3.0
Review comment:
jorisvandenbossche opened a new pull request #8704:
URL: https://github.com/apache/arrow/pull/8704
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jorisvandenbossche commented on pull request #8704:
URL: https://github.com/apache/arrow/pull/8704#issuecomment-729793788
- Slight downside is that we now do a `get_file_info` twice, but only in the
case of a local file path with no filesystem specified (so I think for this
case this is
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526143753
##
File path: rust/arrow/src/util/utils.rs
##
@@ -0,0 +1,119 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526122655
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526161079
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -219,24 +223,27 @@ where
let data_chunks = data.chunks_exact(64);
nevi-me closed pull request #8700:
URL: https://github.com/apache/arrow/pull/8700
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Ulimo commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r526101991
##
File path: .github/workflows/csharp.yml
##
@@ -38,8 +38,12 @@ jobs:
strategy:
fail-fast: false
matrix:
-dotnet: [2.2.103]
+
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526122170
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526122010
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526121662
##
File path: rust/arrow/src/util/bit_ops.rs
##
@@ -0,0 +1,407 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
jorisvandenbossche commented on a change in pull request #8661:
URL: https://github.com/apache/arrow/pull/8661#discussion_r526136508
##
File path: docs/source/format/Columnar.rst
##
@@ -1053,7 +1053,7 @@ the dictionaries can be properly interpreted: ::
The dictionary ``id``
vertexclique commented on a change in pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#discussion_r526145990
##
File path: rust/arrow/src/array/array_list.rs
##
@@ -711,8 +722,9 @@ mod tests {
assert_eq!(1, sliced_array.offset());
nevi-me closed pull request #8695:
URL: https://github.com/apache/arrow/pull/8695
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on a change in pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#discussion_r526207035
##
File path: rust/parquet/src/column/writer.rs
##
@@ -955,81 +963,31 @@ impl ColumnWriterImpl {
/// Trait to define default encoding for types, including
Ulimo commented on a change in pull request #8694:
URL: https://github.com/apache/arrow/pull/8694#discussion_r526101764
##
File path: csharp/src/Apache.Arrow.Flight/Apache.Arrow.Flight.csproj
##
@@ -0,0 +1,28 @@
+
+
+
+netstandard2.1
+8.0
+true
Review comment:
jorgecarleitao commented on a change in pull request #8630:
URL: https://github.com/apache/arrow/pull/8630#discussion_r526401885
##
File path: rust/arrow/src/buffer.rs
##
@@ -888,6 +888,15 @@ impl MutableBuffer {
}
self.len += bytes.len();
}
+
+///
jorgecarleitao commented on a change in pull request #8630:
URL: https://github.com/apache/arrow/pull/8630#discussion_r526401885
##
File path: rust/arrow/src/buffer.rs
##
@@ -888,6 +888,15 @@ impl MutableBuffer {
}
self.len += bytes.len();
}
+
+///
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526462964
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
jorgecarleitao commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526473704
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
alamb commented on a change in pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#discussion_r526473525
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -1187,6 +1219,47 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async fn
alamb closed pull request #8697:
URL: https://github.com/apache/arrow/pull/8697
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on pull request #8697:
URL: https://github.com/apache/arrow/pull/8697#issuecomment-730026146
Thank you @Dandandan !
This is an automated message from the Apache Git Service.
To respond to the message, please
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526498177
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
Dandandan commented on a change in pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#discussion_r526508067
##
File path: rust/arrow/src/csv/reader.rs
##
@@ -77,15 +70,20 @@ fn infer_field_schema(string: ) -> DataType {
return DataType::Utf8;
}
Dandandan commented on a change in pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#discussion_r526512058
##
File path: rust/arrow/src/csv/reader.rs
##
@@ -77,15 +70,20 @@ fn infer_field_schema(string: ) -> DataType {
return DataType::Utf8;
}
alamb commented on a change in pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#discussion_r526411337
##
File path: rust/parquet/benches/codec.rs
##
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
alamb commented on pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#issuecomment-729945589
@GregBowyer -- sounds great!
This is an automated message from the Apache Git Service.
To respond to the message,
alamb commented on a change in pull request #8682:
URL: https://github.com/apache/arrow/pull/8682#discussion_r526488579
##
File path: rust/parquet/src/file/metadata.rs
##
@@ -433,6 +433,21 @@ impl ColumnChunkMetaData {
self.dictionary_page_offset
}
+///
alamb commented on a change in pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#discussion_r526502537
##
File path: rust/arrow/src/csv/reader.rs
##
@@ -77,15 +70,20 @@ fn infer_field_schema(string: ) -> DataType {
return DataType::Utf8;
}
vertexclique commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526511029
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
jhorstmann commented on a change in pull request #8685:
URL: https://github.com/apache/arrow/pull/8685#discussion_r526388987
##
File path: rust/arrow/src/datatypes.rs
##
@@ -618,7 +628,7 @@ macro_rules! make_numeric_type {
fn mask_from_u64(mask: u64) ->
alamb edited a comment on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-729965696
I ran the filtering selectivity benchmark on my laptop again and this time
it shows a ~400% slowdown... So I wonder if that unsafe code is actually giving
us a performance
alamb commented on a change in pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#discussion_r526441242
##
File path: rust/benchmarks/README.md
##
@@ -49,45 +49,16 @@ data. This value can be increased to generate larger data
sets.
The benchmark can then be
alamb commented on a change in pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#discussion_r526432425
##
File path: rust/benchmarks/README.md
##
@@ -49,45 +49,16 @@ data. This value can be increased to generate larger data
sets.
The benchmark can then be
andygrove commented on a change in pull request #8705:
URL: https://github.com/apache/arrow/pull/8705#discussion_r526460805
##
File path: rust/benchmarks/README.md
##
@@ -49,45 +49,16 @@ data. This value can be increased to generate larger data
sets.
The benchmark can then
jorgecarleitao opened a new pull request #8709:
URL: https://github.com/apache/arrow/pull/8709
This PR is based on top of #8630 and contains a physical node to perform an
inner join in DataFusion.
This is still a draft, but IMO the design is here and the two tests already
pass.
andygrove commented on a change in pull request #8709:
URL: https://github.com/apache/arrow/pull/8709#discussion_r526467098
##
File path: rust/datafusion/src/physical_plan/hash_join.rs
##
@@ -0,0 +1,467 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
jorgecarleitao commented on a change in pull request #8709:
URL: https://github.com/apache/arrow/pull/8709#discussion_r526476310
##
File path: rust/datafusion/src/physical_plan/hash_join.rs
##
@@ -0,0 +1,467 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
alamb closed pull request #8705:
URL: https://github.com/apache/arrow/pull/8705
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb closed pull request #8699:
URL: https://github.com/apache/arrow/pull/8699
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb edited a comment on pull request #8701:
URL: https://github.com/apache/arrow/pull/8701#issuecomment-730029379
CI failure looks unrelated
.https://github.com/apache/arrow/pull/8701/checks?check_run_id=1416672486
```
Post job cleanup.
/bin/tar -cz -f
alamb commented on pull request #8701:
URL: https://github.com/apache/arrow/pull/8701#issuecomment-730029379
CI failure looks unrelated . I am restarting it
https://github.com/apache/arrow/pull/8701/checks?check_run_id=1416672486
```
Post job cleanup.
/bin/tar -cz -f
velvia commented on a change in pull request #8688:
URL: https://github.com/apache/arrow/pull/8688#discussion_r526498177
##
File path: rust/arrow/src/compute/kernels/boolean.rs
##
@@ -457,4 +517,42 @@ mod tests {
assert_eq!(true, res.value(2));
Dandandan commented on a change in pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#discussion_r526506545
##
File path: rust/arrow/src/csv/reader.rs
##
@@ -77,15 +70,20 @@ fn infer_field_schema(string: ) -> DataType {
return DataType::Utf8;
}
Dandandan commented on a change in pull request #8710:
URL: https://github.com/apache/arrow/pull/8710#discussion_r526520746
##
File path: rust/arrow/src/csv/reader.rs
##
@@ -77,15 +70,20 @@ fn infer_field_schema(string: ) -> DataType {
return DataType::Utf8;
}
alamb commented on pull request #8708:
URL: https://github.com/apache/arrow/pull/8708#issuecomment-729945761
vertexclique commented on pull request #8664:
URL: https://github.com/apache/arrow/pull/8664#issuecomment-729991100
Weird, on my machine when I pushed the initial implementation of this PR I
got the numbers above. Seems like it is regressed for me too.
github-actions[bot] commented on pull request #8709:
URL: https://github.com/apache/arrow/pull/8709#issuecomment-729995084
https://issues.apache.org/jira/browse/ARROW-9555
This is an automated message from the Apache Git
andygrove commented on a change in pull request #8709:
URL: https://github.com/apache/arrow/pull/8709#discussion_r526466282
##
File path: rust/datafusion/src/physical_plan/hash_utils.rs
##
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
1 - 100 of 153 matches
Mail list logo
