Re: [GNUnet-developers] gnunet-gtk segfault and other issues

Ricardo Wurmus writes: > Hi, > > I packaged gnunet-gtk at 0.10.1 for GNU Guix but it doesn’t seem fully > functional. I see a segfault when switching tabs in “gnunet-setup” > after first interacting with the URL dropdown. This seems to be > reproducible behaviour. > > In

[GNUnet-developers] Correction (was: plan: better descriptions and texts for gnunet.org)

As I am not sure if the first message was a bit unclear and if the first reply was sarcasm, let me be a bit more descriptive: I want to provide descriptions and texts for the public who is not interested in technical details. Something I see currently a lack of. Technical and academical

[GNUnet-developers] plan: better descriptions and texts for gnunet.org

TL;DR: better descriptions and better public presence for GNUnet coming up soon, one preview on guix-devel list right now. gmane.comp.gnu.guix.devel message id 17647 contains the description I currently use for GNUnet in packaging. I will work this out soon to - best case scenario - make the

[GNUnet-developers] gentoo, last tweaks and questions

Currently I am doing last tweaks on the gnunet packages in the ybti overlay which lynX started, fixing the gnunet ebuilds before I can push the to portage of gentoo to be hopefully finally included. There might be more questions coming afterwards, but currently I wonder why my gentoo system (KDE

[GNUnet-developers] [Brandon Invergo] Re: [bug-womb] gnunet description

Hi everyone, the description for gnunet on womb of gnu.org just got updated with my recommendation. Hopefully tomorrow, if not on the weekend, I'll update (part of) the description on the gnunet.org website to fit the new description.

Re: [GNUnet-developers] gentoo, last tweaks and questions

t '../src/sensordashboard/gnunet-sensordashboard.c' needed by 'gnunet.pot-update" > On 04/08/2016 01:10 AM, Nils Gillmann wrote: >> Ay, sorry I wasn't going into detail enough. I was talking about >> the filesharing part of gnunet-gtk. There I can select files, but >> wh

Re: [GNUnet-developers] gentoo, last tweaks and questions

Christian Grothoff writes: > On 04/10/2016 02:04 PM, ng0 wrote: >> Christian Grothoff writes: >> >>> This should have been self-fixing if you ran './bootstrap' to generate >>> configure. Next time you see this (kind of) message, just re-run >>>

Re: [GNUnet-developers] gentoo, last tweaks and questions

Ebuilds are submitted, bugzilla to track: https://bugs.gentoo.org/show_bug.cgi?id=579580 gnunet, gnunet-gtk, gnurl -- ng0 ___ GNUnet-developers mailing list GNUnet-developers@gnu.org https://lists.gnu.org/mailman/listinfo/gnunet-developers

Re: [GNUnet-developers] gentoo, last tweaks and questions

Christian Grothoff <groth...@gnunet.org> writes: > On 04/08/2016 12:20 AM, Nils Gillmann wrote: >> Currently I am doing last tweaks on the gnunet packages in the >> ybti overlay which lynX started, fixing the gnunet ebuilds before >> I can push the to portage of gen

Re: [GNUnet-developers] gnunet-gtk weirdness and gnunet-setup segfault

Christian Grothoff writes: > On 01/17/2016 05:28 PM, Ricardo Wurmus wrote: >> Hi, >> >> I just built gnunet-gtk 0.10.1 with GNU Guix and noticed some problems. >> >> When running "gnunet-gtk" all I see is five big icons that I can click, >> but nothing else. There seems

[GNUnet-developers] Shepperd service and guixsd declarative configuration of gnunet

I am currently in the planning stages of writing a system service for GuixSD. With system service I mean that it will be able to start a service through our init system, shepperd, and be able to define the complete gnunet configuration through the file which handles the complete system

Re: [GNUnet-developers] Shepperd service and guixsd declarative configuration of gnunet

application for secure publication of files, it has +grown to include all kinds of basic applications for the foundation of a GNU +internet. + +gnunet-0.10.1 is the last stable release candidate, however for +development purposes and keeping up with latest changes, the SVN version +might be preferable until a new ve

Re: [GNUnet-developers] using $TMPDIR instead of /tmp

Christian Grothoff transcribed 3.9K bytes: > On 05/06/2018 08:34 PM, Nils Gillmann wrote: > > Christian Grothoff transcribed 2.9K bytes: > >> On 05/05/2018 09:58 PM, Nils Gillmann wrote: > >>> Anyways I just had some time t

Re: [GNUnet-developers] using $TMPDIR instead of /tmp

Nils Gillmann transcribed 1.8K bytes: > Christian Grothoff transcribed 3.9K bytes: > > On 05/06/2018 08:34 PM, Nils Gillmann wrote: > > > Christian Grothoff transcribed 2.9K bytes: > > >> On 05/05/2018 09:58 PM, Nils Gillmann wrote: > > >>> Anyways I

Re: [GNUnet-developers] using $TMPDIR instead of /tmp

ouched almost 7 years ago. Before I use something similar in the mostly test-related files, is there a quick way to resolve this fixme note? > Naturally, there may be places in the code that don't use this, but they > should ;-). > > -Christian > > On 05/05/2018 02:33 PM, Nils

Re: [GNUnet-developers] using $TMPDIR instead of /tmp

c/util/disc.c when it's not already the case? > -Christian > > On 05/05/2018 02:33 PM, Nils Gillmann wrote: > > I would like to replace our use of /tmp in the source repository > > with $TMPDIR. > > > > Before I go ahead and try: > > > > * Is that po

Re: [GNUnet-developers] using $TMPDIR instead of /tmp

Christian Grothoff transcribed 3.0K bytes: > On 05/05/2018 02:41 PM, Nils Gillmann wrote: > >> I grepped for "/tmp" in "src" and a not so small number of files was > >> returned, > >> which is why I asked. > >> I didn't check the context

Re: [GNUnet-developers] texinfo+images (for grothoff)

Christian Grothoff transcribed 2.7K bytes: > I now ran run-gendocs.sh on my system, and it additionally wanted a JPG > for the HTML. But without it, the error message was completely > different, so I don't know if that helps on your system. > > On 05/09/2018 11:36 AM, Nils Gillman

Re: [GNUnet-developers] texinfo+images (for grothoff)

Christian Grothoff transcribed 2.7K bytes: > On 05/09/2018 10:44 AM, Nils Gillmann wrote: > > Hi Christian, > > > > I tried to clean up the last documentation commit you made. However I > > have no time right now to read into how images are to be included in > >

Re: [GNUnet-developers] texinfo+images (for grothoff)

Nils Gillmann transcribed 2.3K bytes: > Christian Grothoff transcribed 2.7K bytes: > > On 05/09/2018 10:44 AM, Nils Gillmann wrote: > > > Hi Christian, > > > > > > I tried to clean up the last documentation commit you made. However I > > > h

Re: [GNUnet-developers] using $TMPDIR instead of /tmp

Christian Grothoff transcribed 3.8K bytes: > On 05/05/2018 03:01 PM, Nils Gillmann wrote: > >> Agreed, it would be great if you could change the tests to use the > > > > Okay, any idea how the .conf files should be adjusted, given that > > you most likely

[GNUnet-developers] Buildbot request: a machine building with python3

Hi, I know our gnunet.org site builders are still not very reliable, but Taler project is most likely reading this list too. I pciked up my work again on making the testsuite python2+3 compatible, therefore it now requires the future module. Adjust your builders accordingly. Next, the

[GNUnet-developers] testsuite fail: trapnsport blacklisting

For a couple of days now my Guix based test environment has these tests failing in src/transport without any special configuration: FAIL: test_transport_blacklisting_outbound_bl_full == May 19 18:07:55-348708 test-transport-api-blacklisting-26560

Re: [GNUnet-developers] contrib/sounds (Re: contrib folder)

Christian Grothoff transcribed 3.4K bytes: > On 05/19/2018 06:43 PM, Nils Gillmann wrote: > > Nils Gillmann transcribed 2.5K bytes: > >> Nils Gillmann transcribed 2.6K bytes: > >>> Christian Grothoff transcribed 2.8K bytes: > > … > >> What abou

[GNUnet-developers] contrib/sounds (Re: contrib folder)

Nils Gillmann transcribed 2.5K bytes: > Nils Gillmann transcribed 2.6K bytes: > > Christian Grothoff transcribed 2.8K bytes: … > What about "sound"? This looks like it should be moved into gnunet-gtk > instead. lynX told me this is for 'conversation'. Since c

Re: [GNUnet-developers] website and logo rework

Christian Grothoff transcribed 34K bytes: > Dear all, > > > I think this is the time where I have to disclose a major unfortunate > development (but which may be resolved soon without too much drama). > > Basically, GNUnet e.V. has received a cease and desist letter from > Deutsche Telekom AG

Re: [GNUnet-developers] website and logo rework

t; Do we need to manually add all the www_* tags? Can't we just have them > optional? They can be optional, but it would be better if we have them. iirc, won't look at it right now, this is used as the source to fetch the file from or something. > > On 17. May 2018, at 18:57, Nils Gillmann

Re: [GNUnet-developers] website and logo rework

Schanzenbach, Martin transcribed 10K bytes: > Hey, > > > On 17. May 2018, at 17:12, Nils Gillmann <n...@n0.is> wrote: > > > > Christian Grothoff transcribed 34K bytes: > >> Dear all, … > >> On 05/17/2018 04:07 PM, Schanzenbach, Ma

[GNUnet-developers] duplicate tool

Is there any particular reason why we have src/integration-tests/gnunet_pyexpect.py.in and contrib/scripts/gnunet_pyexpect.py.in ? I have already adjusted the one in contrib. the one in src/int.. is not adjusted but they look like they are the same file.

[GNUnet-developers] [release] gnURL 7.60.0

Yesterday I released gnURL/libgnurl 7.60.0. The sha512sums for the files are: cdfa6cf5d576b7db63612bf77c2bb0d03dbde143dbf1c61f8fbab526e7c20bf46ac13df44babaa8a0d8ab78b38ca30d50c944e3c1843043c5fbd07553a00ffcb gnurl-7.60.0.tar.gz

Re: [GNUnet-developers] New gnunet bibliography

Schanzenbach, Martin transcribed 3.7K bytes: > Ok. Commit 2902e10ead621f4b2172edbc7161e36af9bfb42f should make it build the > full bib now. > I had to add a few "author" fields as "author = {TODO}", else it failed. I > did not bother to find the actual authors for now. Unfortunately you cannot

Re: [GNUnet-developers] New gnunet bibliography

Schanzenbach, Martin transcribed 3.1K bytes: > I do not want to hijack the other thread so I open this. > I can help with the bib, but when I do a "make" in the gnunetbib (after I fix > all the quote errors) I get 2295 "ERROR"s a la: > > ERROR: Misformed pages in 1962 > ERROR: reed60polynomial

Re: [GNUnet-developers] contrib folder

it involves moving around some undocumented files I can only assume which will break people's or servers work-flow in the worst case. One of the cases where a review is good. > On 05/17/2018 10:15 PM, Nils Gillmann wrote: > > Hi, > > > > I'm cleaning up the contrib fol

[GNUnet-developers] contrib folder

Hi, I'm cleaning up the contrib folder a bit. Restructuring and moving some files into new folders. What I wasn't able to find is information about "zonewalk-to-types", is it used manually? grep returned nothing. ___ GNUnet-developers mailing list

[GNUnet-developers] documentation: Rewriting the Installation Handbook with a focus on simplicity and coverage

Hi all, I took the recent reports and non-reports[0] I've read over the last year and decided the only good solution is a Bakunin one this time. So in Bakunin's tradition I'm erasing what we have and I'm rewriting the Installation Handbook. I might reuse some old parts, but basically I'm aiming

Re: [GNUnet-developers] documentation: Rewriting the Installation Handbook with a focus on simplicity and coverage

tem integration. Like, I have started looking into BSDs and reasons why GNUnet was dropped from FreeBSD ports (gnurl was one point), packaging for smaller OS frameworks, getting GNUnet into Gentoo proper is also just a tiny step,... Thanks, N. > BR > Martin > > > On 3. Jun 2018, at 20:5

Re: [GNUnet-developers] documentation: Rewriting the Installation Handbook with a focus on simplicity and coverage

Schanzenbach, Martin transcribed 10K bytes: > > > > On 3. Jun 2018, at 22:33, Nils Gillmann wrote: > > > > Hi, > > > > Schanzenbach, Martin transcribed 6.5K bytes: > > Ideally it works like this: identify package manager. Look at > > the comman

Re: [GNUnet-developers] documentation: Rewriting the Installation Handbook with a focus on simplicity and coverage

gt; 1. The easy way (for users, docker image) > 2. The hard way (for devs, from source) > 3. The future way (binary packages/installer) (WIP!) > > Eventually this could be changed into: > > 1. I just want to use it (binary packages/installer) > 2. I want to develop! (from source)

Re: [GNUnet-developers] The General Color Scheme of GNUnet

Just some quick remarks, a real comment has to wait a few days I guess because of my schedule: once there is a branding/corporate identity guide (which goes in the direction of what you are proposing to start) We should have variants for the static generated website. Beyond a default we somehow

Re: [GNUnet-developers] building db67f7e2f62e38ee9b7cf5526609431a04f9bc9d

Ludovic Courtès transcribed 819 bytes: > Hello Nils, > > I’m late to the party but… > > Nils Gillmann <n...@n0.is> skribis: > > > ld-wrapper: error: attempt to use impure library > > "/home/user/src/gnunet/gnunet/src/util/.libs/libgnunetutil.so"

Re: [GNUnet-developers] New README.md and Github

Hi Christian and Devan, here's my take on this: Christian Grothoff transcribed 4.8K bytes: > Hi Devan, > > I don't quite see the point of the README.md: the existing README is > perfectly readable for everybody, and having duplicate information is > confusing (now one has to update two

[GNUnet-developers] gnurl 7.61.0 released

Hi, today gnurl has been released in version 7.61.0, following curl 7.61.0 (released earlier this month). The download is available at the usual place, https://ftp.gnu.org/gnu/gnunet The tarballs of this version has been signed with the OpenPG Key A88C8ADD129828D7EAC02E52E22F9BBFEE348588 Since

Re: [GNUnet-developers] New README.md and Github

GNOME is still a GNU project, right? Because they have a very active mirror account: https://github.com/GNOME Just as an example for GNU on Github. ___ GNUnet-developers mailing list GNUnet-developers@gnu.org

[GNUnet-developers] gnurl 7.61.0 delayed

Hi all, last week I started rebasing gnurl on the curl-7.61.0 tag. I probably won't finish before August since a hell lot of things are happening right now which require my full attention. This is just to let you know what's up with the delay. ___

Re: [GNUnet-developers] contrib/guix

Florian Dold transcribed 1.3K bytes: > On Fri, Sep 7, 2018 at 4:25 PM Nils Gillmann wrote: > > could you please document 'contrib/guix' somewhere? I will keep using > > my personal modules which were moved around. > > The purpose of the directory is already explain

[GNUnet-developers] contrib/guix

Hi Florian, could you please document 'contrib/guix' somewhere? I will keep using my personal modules which were moved around. I know there was some discussion I was CC'd into a while back, but if you want to reach an audience with this module outside of our circle documentation is the key in my

[GNUnet-developers] gnurl-7.61.1 released

Hi Taler, GNUnet, and everyone who's packaging gnurl. Today gnurl has been released in version 7.61.1, following curl 7.61.1 (released earlier this month). The download is available at the usual place, https://ftp.gnu.org/gnu/gnunet The tarballs of this version has been signed with the OpenPG

Re: [GNUnet-developers] womb / maintainers description rewrite

Okay, done. Or at least initiated. Blurb description change has to wait a while longer. Nils Gillmann transcribed 2.5K bytes: > Christian Grothoff transcribed 4.1K bytes: > > On 06/28/2018 04:13 PM, Nils Gillmann wrote: > > > link in line 1 returns: > > > > > >

Re: [GNUnet-developers] womb / maintainers description rewrite

Mike just told me the changes will (probably) be done this weekend. Nils Gillmann transcribed 2.9K bytes: > Okay, done. > Or at least initiated. > Blurb description change has to wait a while longer. > > Nils Gillmann transcribed 2.5K bytes: > > Christian Grothoff t

Re: [GNUnet-developers] GNUnet hacker meeting: 22.6.-29.6.

Christian Grothoff transcribed 2.8K bytes: > On 04/04/2018 10:27 AM, Nils Gillmann wrote: > > Can't make it, we have no Vorlesungsfreie Zeit in NRW in the time > > you organized this to be. > > :-( > > > When you do it next time, could we make a doodle or something

Re: [GNUnet-developers] action required on improving curl support

Nils Gillmann transcribed 666 bytes: > Hi, > > there's this really annoying issue with only GuixSD (and Guix?) that > applications making use of CA's sometimes need to be patched. > > Could we implement support for the curl supported/recommended > CURL_CA_BUNDLE? It depends

Re: [GNUnet-developers] gnunet-gtk configure check

Nils Gillmann transcribed 831 bytes: > Something is not quite right with our configure check for gtk+-3 in > gnunet-gtk. > > C-version of pkg-config finds gtk+ in version 3. > perl-version of pkg-config finds everything but gtk+. The weird thing: it > picks up > gtk+-2 alth

Re: [GNUnet-developers] Guix based tooling for GNUNet

Nils Gillmann transcribed 1.8K bytes: > Catonano transcribed 3.6K bytes: > > Hello > > > > I opened this thread on the gnunet-develop mailing list > > > > https://lists.gnu.org/archive/html/gnunet-developers/2018-03/msg00030.html > > > > Chr

[GNUnet-developers] gnunet-gtk configure check

Something is not quite right with our configure check for gtk+-3 in gnunet-gtk. C-version of pkg-config finds gtk+ in version 3. perl-version of pkg-config finds everything but gtk+. The weird thing: it picks up gtk+-2 although I provide gtk+-3 to the recipe. I'm not super familar with the m4

Re: [GNUnet-developers] Guix based tooling for GNUNet

Catonano transcribed 3.6K bytes: > Hello > > I opened this thread on the gnunet-develop mailing list > > https://lists.gnu.org/archive/html/gnunet-developers/2018-03/msg00030.html > > Christian Grothoff suggested that Hartmut Goebel and Andreas Enge helped in > setting up the GNUNet building

Re: [GNUnet-developers] Towards a new formalized release policy

Christian Grothoff transcribed 9.8K bytes: > On 03/30/2018 07:45 PM, Catonano wrote: > > Hello > > > > this is the first time I write on this mailing list > > Welcome ;-). > > > I should probably introduce myself but Iì m not exact6ly comfortable > > with introductions > > Not really

Re: [GNUnet-developers] Towards a new formalized release policy

Nils Gillmann transcribed 15K bytes: > Christian Grothoff transcribed 9.8K bytes: > > On 03/30/2018 07:45 PM, Catonano wrote: > > > Hello > > > > > > this is the first time I write on this mailing list > > > > Welcome ;-). > > > >

Re: [GNUnet-developers] Towards a new formalized release policy

Mike Mestnik transcribed 784 bytes: > This is great, there are several issues I had working with GNUNet that > existed entirely because there were no current releases. > > There are a few things to consider above simply having regular releases and I've had my doubts about this in the beginning

Re: [GNUnet-developers] womb / maintainers description rewrite

Christian Grothoff transcribed 4.1K bytes: > On 06/28/2018 04:13 PM, Nils Gillmann wrote: > > link in line 1 returns: > > > > package: gnunet > > doc-category: Internet > > doc-summary: Secure, decentralized, peer-to-peer networking framework > > doc-url:

Re: [GNUnet-developers] Encrypted Message

I'm responding to the list since I see no reason why this should be offlist. I hope this is okay for you. Christian Grothoff transcribed 4.4K bytes: > >> I will probably finish this today or tomorrow, if it builds then, we need > >> a couple more eyes to review the content, types, URLs and so

[GNUnet-developers] attn: www.git

Hi, I just pushed a couple of commits to make the build of the website as neutral as possible while keeping compatibility with python3.6 in mind. If this broke something for you: Don't fix it. Add the error message and your environment here, let's work it out in a way which works for the

Re: [GNUnet-developers] fix typo in gnunet-fuse man

Thanks! I've applied the patch to gnunet-fuse master. Naomi Phillips transcribed 1.3K bytes: > See attached > -- > Naomi Phillips > 5F90 BE04 8090 3AFB 2DED > CF7A 89F2 1B16 F041 E630 > > diff --git a/doc/gnunet-fuse.1 b/doc/gnunet-fuse.1 > index 2dba984..b126264 100644 > ---

Re: [GNUnet-developers] uk.gnunet.org

carlo von lynX transcribed 936 bytes: > Received this message from a supporter: > > hey, I lack the time to chase this and I figure you have the right > contacts to chase this, googling gnunet from the UK (you can try via > google.co.uk) yields uk.gnunet.org as the first result. > >

[GNUnet-developers] 5b5b317f1e7667371de0695d16eb862997585781

Can we solve this commit differently? -@include gversion.texi +@include version.texi My intention here was to drop version.texi (apparently not possible with autotools then...) and build the content of it that we really use with the make rules. What is necessary for the build-system to run

[GNUnet-developers] [release] gnurl 7.62.0

Hi Taler, GNUnet, and everyone who's packaging gnurl. Today gnurl has been released in version 7.62.0, following curl 7.62.0 (released on 2018-10-30). The download is available at the usual place, https://ftp.gnu.org/gnu/gnunet The tarballs of this version has been signed with the OpenPG Key

Re: [GNUnet-developers] GNUnet Hacker Meeting

Hi, As most of you participated the first time I have a question (you can mail me offlist): how much did you (single person) pay for the week + travel + food etc? Julius Bünger transcribed 5.7K bytes: > Dear all, > > location and date for the next GNUnet Hacker Meeting are set: > > It will

[GNUnet-developers] gnunetbib needs some last finishing touches

Hi, I sed'ed a bit through the gnunet.bib tonight. What's left to do is hopefully the content of the log I appended. With some logic some of this can be programmed, some of this can be done in sed, other parts have to be done entirely by hand. We could probably be done with this missing part

Re: [GNUnet-developers] gnunetbib needs some last finishing touches

Nils Gillmann transcribed 764 bytes: > Hi, > > I sed'ed a bit through the gnunet.bib tonight. What's left to do is > hopefully the content of the log I appended. > > With some logic some of this can be programmed, some of this can be > done in sed, other parts have to be

Re: [GNUnet-developers] Encrypted Message

Nils Gillmann transcribed 3.0K bytes: > I'm responding to the list since I see no reason why this > should be offlist. I hope this is okay for you. > > Christian Grothoff transcribed 4.4K bytes: > > > >> I will probably finish this today or tomorrow, if it builds th

Re: [GNUnet-developers] anonbib

... > I am currently going through our .bib file with a newer python application. > This showed more remaining errors (This time: with the linenumber, much > faster) > and I am confident that simply using something which makes use of for example > pybtex will be easier to maintain. I decided to

Re: [GNUnet-developers] gnunetbib needs some last finishing touches

Nils Gillmann transcribed 978 bytes: > Nils Gillmann transcribed 764 bytes: > > Hi, > > > > I sed'ed a bit through the gnunet.bib tonight. What's left to do is > > hopefully the content of the log I appended. > > > > With some logic some of this can be p

Re: [GNUnet-developers] gnunetbib needs some last finishing touches

Nils Gillmann transcribed 1.4K bytes: > Nils Gillmann transcribed 978 bytes: > > Nils Gillmann transcribed 764 bytes: > > > Hi, > > > > > > I sed'ed a bit through the gnunet.bib tonight. What's left to do is > > > hopefully the content of the log

Re: [GNUnet-developers] Report of GNUnet-Workshop at Datenspuren/Dresden

sva transcribed 5.3K bytes: > Dear all, Dear xrs, thanks for that summary, > > > I'll add some links and some personal notes, too: > > > On 09/25/2018 02:10 PM, xrs wrote: > > > t3sserakt held a little presentation on the "State of GNUnet" > > In German:

Re: [GNUnet-developers] [release] gnurl 7.62.0

I was notified yesterday that the upload did not really appear on the server. I think FSF had some problems with the infrastructure. The tarballs are now published. Nils Gillmann transcribed 3.8K bytes: > Hi Taler, GNUnet, and everyone who's packaging gnurl. > > Today gnurl has been

Re: [GNUnet-developers] proposal: changes to documentation

ime chain. Texinfo usually brings in at least 2 GB - you turn it off, now you have to read online documentation or get the documentation elsewhere. > - Florian > > On 9/16/18 12:48 AM, Nils Gillmann wrote: > > Hi all, > > > > I have a proposal. If this in rough shape o

Re: [GNUnet-developers] proposal: changes to documentation

and especially in the beginning or when you just rush it, it is easy to overlook a detail and make a mistake. > Happy hacking! > > Christian > > On 09/16/2018 12:48 AM, Nils Gillmann wrote: > > Hi all, > > > > I have a proposal. If this in rough shape or you have q