Re: Implementing Go modules in F34
Hi, My plan was to keep the current implementation in parallel with the new one, so old specs would have kept working as is, but people kept delaying during the F33 change process till I had to move to other things. Now I can’t take it up again before end of january at best :( (switching job and cities, that takes lots of time). People got used to indulging in black magic accusations while reviewing nothing and blocking everything, I hope they get something out of it because it wasted a year of dev for no good reason. Regards -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: Packaging of Go modules
Hi Olivier, You are very right, and all this has been rewritten and fixed in my devel branch. Unfortunately the F33 change process ate all the time I had to spend on the subject on the summer, and now personal problems and covid consequences are preventing me from finishing things. You can see a working POC here https://copr.fedorainfracloud.org/coprs/nim/go-modules/packages/ (at the time I also successfully tested multi-module packaging with different versions from a single spec) If you have some cycles to spend on the subject you can try to un-stick https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/109 because I don’t have the time right now to beg people to look at it again. Besides after months of the same unchanged code sitting in the review queue I’m franckly sick of it all Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #27: Add macro for packages with `replace` in go.mod
nim added a new comment to an issue you are following: `` rpm dependencies are transitive. That means replace can not be supported in rpm. That means the only sane way to handle replace is to remove it by patching code imports (which is not long or hard) As to why non-transitive deps and 'to hell will everyone else, I only care about by own leaf node' approaches are a false good idea see the discussion on modules in devel right now. You win a little short term, you lose a lot long term as soon as the deferred technical debts catches up with you (as it caught up with the java module experiment). `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #27: Add macro for packages with `replace` in go.mod
nim added a new comment to an issue you are following: `` replace can not work in Fedora anyway because it is not transitive (it’s the kind of broken by design idea people invent when their primary target is to bundle piles of junk and avoid fixing their code). source code that uses replace needs patching to use the real module/import name with or without modules. We have %patch and (soonish) patchlists for that, not sure a macro would be a lot more convenient, and it would certainly be more brittle. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: Go rpm macroses in rhel8 and epel
Le 2020-09-01 15:17, Nicolas Mailhot a écrit : Le 2020-08-20 22:05, Denis Fateyev a écrit : Could anybody provide some more info: are Go rpm macroses not fully backported to RHEL8 currently? Any kind of blockers, perhaps? Unfortunately, while the Go-specific logic of the macros is quite release-agnostic, they depend on some common code in redhat-rpm-config that did not make it to EL8. The way @rh freezes common tooling at the start of an EL release inherently conflicts with languages like Go which are still fast evolving and requiring changes not fossilized a decade ago. And it would be quite hard to both froze initial EL implementation in stone and provide parallel updates (modularity & containers only work for leaf features not core shared low level code) Though if anyone is willing to go down this particular rabbit hole, I will provide support and answer questions. From very very very far away :) -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: Go rpm macroses in rhel8 and epel
Le 2020-08-20 22:05, Denis Fateyev a écrit : Could anybody provide some more info: are Go rpm macroses not fully backported to RHEL8 currently? Any kind of blockers, perhaps? Unfortunately, while the Go-specific logic of the macros is quite release-agnostic, they depend on some common code in redhat-rpm-config that did not make it to EL8. The way @rh freezes common tooling at the start of an EL release inherently conflicts with languages like Go which are still fast evolving and requiring changes not fossilized a decade ago. And it would be quite hard to both froze initial EL implementation in stone and provide parallel updates (modularity & containers only work for leaf features not core shared low level code) Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: RPM error: following noarch package built differently on different architectures
Le 2020-09-01 10:56, Robert-André Mauchin a écrit : It's caused by a specific Requirement in an amd64 only file: Since it is hard to make sure every project is perfectly arch-agnostic, I lean towards making go modules archful and forget about this class of problems. Way too late to fix gopath devel packages, unfortunately Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #26: Remove tildes from goname
nim commented on the pull-request: `Remove tildes from goname` that you are following: `` That will work but it’s better to add tilde to the generic forbidden separator cleanup rule: > -- replace various separators rpm does not like with - `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #26: Remove tildes from goname
nim commented on the pull-request: `Remove tildes from goname` that you are following: `` ~ should be replaced with "-" then. "-" is safe as intra-name separator. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/26 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: [Fedocal] Reminder meeting : Go SIG Meeting
Le 2020-03-15 17:00, jca...@fedoraproject.org a écrit : Hi, You are kindly invited to the meeting: Go SIG Meeting on 2020-03-17 from 16:00:00 to 17:00:00 UTC At fedora-gol...@irc.freenode.net It will most likely not attend (longs days @work to handle COVID-19-related changes) -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #23: macros: Accept options for %gotest
nim commented on the pull-request: `macros: Accept options for %gotest` that you are following: `` @atodorov It seems there are all too many of us in your case:(. Let’s try to figure it a bit better before pushing changes that others will expect to be perfectly baked. Right now, our build stage is under-automated, because 1. I could not figure a way to autodetect things that need building 2. I could not figure a way to safely name the result (your -o flag that plagues us every time there is something to build) 1. can be “solved” by a variable listing the things to build 2. is a bit harder, because creating a list of target names won’t work with globs. I need to figure an heuristic solid enough to work in most cases Once those part are done `go test -c` becomes just a trivial variant to implement `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #23: macros: Accept options for %gotest
nim commented on the pull-request: `macros: Accept options for %gotest` that you are following: `` So what you really want, is better automation of the build stage, except the testing module also requires you to use `go test` instead of `go build` as build command? I suppose I could revisit the %build stage and add a variable somewhere to pass the lists of things to build. And another for the lists of tests to build. I don’t suppose, there is a magic inspection command that outputs the list of things that can be built with go test -c ? `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #23: macros: Accept options for %gotest
nim commented on the pull-request: `macros: Accept options for %gotest` that you are following: `` I’m a bit wary of adding flags to such a low level macro: it sets an API in stone, that will be quite hard to evolve later given how primitive and constraining the rpm options parser is. Generic rpm macros controled via generic rpm variables are a lot easier to handle long-term than low-level option parsing. Your -tests rpm looks like a generic thing. I’d rather generate this subpackage in a generic way than expose a low-level non future proof API to packagers. What exactly do you need in `%build` `%install` and `%files` for `-tests` to exist? What info does it need from the packager, and what can be autodetected from the upstream code state? `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Google Go fonts
Hi, The Go font families (Go, Go Mono and Go Smallcaps) are now available in Fedora 32 and 33 as normal system fonts. You’ve all encountered them on godoc.org when reading Go source code examples. Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: Include non-RPM content in buildroot
Le vendredi 21 février 2020 à 15:57 +0100, Martin Sehnoutka a écrit : > Hi, Hi, > Go went even further in this case and it is > common > to bundle all the dependencies as a source code directly in the > upstream > repository. See this repo as an example: > https://github.com/containers/libpod/tree/master/vendor Since you take Go in example – vendoring (bundling) proved such a maintenance headache upstream that Google had to create a complete new packaging system to get rid of it. Not for Fedora or Linux people, but because they had huge problems with unmaintained, holed and non-legal code lurking in this kind of vendor pile. So Go (upstream) is going away from the kind of practice you’re advocating. And Google’s implementation of versionning in Go modules is even stricter and more rigid than the one in rpm (precisely because they tried the lala-lala let’s bundle everything without caring about versions, and were badly burned). From a technical POW, we need to improve the mapping of their packaging system and then integrating the Go ecosystem in Fedora will be no harder than integrating any other language component (easier, because the language-specific package manager produces very regular sources). From a maintenance POW dumping huge piles of unmanaged third-party code on build farms just does not work long term. That’s why Google had to break its vendor piles in atomic Go modules. From a process POW, Fedora is not ready. Not because out tech does not work but because our processes can not handle the pile of atomic components generated by upstream practices. Since the problem is process, not technical side, please work on the process side, instead of trying to bypass the process with bad technical solutions. Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: [dev] [changelog] [RPM] cauldron core/release go-rpm-macros-3.0.8-1.mga8
Le 2019-12-17 09:02, Neal Gompa a écrit : On Tue, Dec 17, 2019 at 2:47 AM Nicolas Mailhot wrote: Le 2019-12-16 18:14, Neal Gompa a écrit : > On Mon, Dec 16, 2019 at 12:06 PM Guillaume Rousse > wrote: >> >> Le 14/12/2019 à 18:08, Neal Gompa (via dev Mailing List) a écrit : >> > The go-rpm-macros package is supposed to supersede the old one. >> > Someone forgot to retire the go-srpm-macros and go-compilers packages >> > in Fedora... >> So, does anyone oppose to reuploading the go-rpm-macros with proper >> obsolete tag, and without the bogus dependency on redhat-rpm-config >> package ? >> > > It should be fine, swap the dependency from redhat-rpm-config to > rpm-mageia-setup-build. > > Actually, redhat-rpm-config as a dependency is a bug. It *should* > require system-rpm-config, which is a virtual dependency that allows > us to swap among providers. Right now it depends on quite a lot of lua code in redhat-rpm-config. Unless this code has been imported mageia-side, things won’t work Your forge macros are included in rpm-mageia-setup: http://svnweb.mageia.org/packages/cauldron/rpm-mageia-setup/current/SPECS/rpm-mageia-setup.spec?revision=1453908=markup#l52 Great! That’s nice to know -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: [dev] [changelog] [RPM] cauldron core/release go-rpm-macros-3.0.8-1.mga8
Le 2019-12-16 18:14, Neal Gompa a écrit : On Mon, Dec 16, 2019 at 12:06 PM Guillaume Rousse wrote: Le 14/12/2019 à 18:08, Neal Gompa (via dev Mailing List) a écrit : > The go-rpm-macros package is supposed to supersede the old one. > Someone forgot to retire the go-srpm-macros and go-compilers packages > in Fedora... So, does anyone oppose to reuploading the go-rpm-macros with proper obsolete tag, and without the bogus dependency on redhat-rpm-config package ? It should be fine, swap the dependency from redhat-rpm-config to rpm-mageia-setup-build. Actually, redhat-rpm-config as a dependency is a bug. It *should* require system-rpm-config, which is a virtual dependency that allows us to swap among providers. Right now it depends on quite a lot of lua code in redhat-rpm-config. Unless this code has been imported mageia-side, things won’t work Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #22: rpm/macros.d: Make disabling Go modules configurable for %gobuild and %gotest
nim commented on the pull-request: `rpm/macros.d: Make disabling Go modules configurable for %gobuild and %gotest` that you are following: `` @ngompa: please stay coherent with the exising macros and do not use `__` prefixing Apart from that, why not, but enabling modules will break things right and left, so it’s a fire yourself in the foot setting (go commands will start downloading right and left, go packahe naming resolution will fail because modules have special rules for versions in the import path, etc) `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/22 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @jcajka the macros do not add any policy over golist output. Any policy is manual use of override switches by packagers in their spec As for upstreams… you realise that telling someone that named a package tree root internal that it's not internal for third party tooling is not going very far… As for actual examples, the cznic package set comes to mind From a purely semantical POW, projects that use internal to mean something else than internal are the ones asking for trouble `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @jcajka I agree from a theoretical POW. I was just pointing out that from a practical POW, asking all the Go parts we package to adhere strictly to the specs, means dealing with a lot of build failures. internal is known to be (mis)used by some projects. Do we want to ignore this (mis)use and just deal with failing builds whenever exposing internal makes things break? `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` @obudai a lot of Go projects use internal in the package path to mean the same thing as the internal keyword. Welcome to the wonderful land of underspecified Go behaviour. Therefore, to be safe, golist should filter anything with internal in the path, unless requested explicitly with a specific switch. (and upstreams that use internal to mean something else than internal should probably rename their Go package now that internal as a package name has been used as internal by many Go projects) I know, it's clear as mud. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #27: Fix not listing packages with external tests only
nim commented on the pull-request: `Fix not listing packages with external tests only` that you are following: `` That would wreck havoc on all package BRs since internal is a magic keyword that forbids exposing the result to other Go packages. Returning anything internal in `golist` must be isolated with an '--internal' optional switch (and %gocheck should probably use this flag, once it is created. The R and BR part definitely should not) `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/27 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #21: Expose Go build flags directly to spec files as a macro
nim commented on the pull-request: `Expose Go build flags directly to spec files as a macro` that you are following: `` @berrange That’s awfully nice, both the runtime ifnarch removal and the generalization to pie/nopie macros If you think the PR is cooked and @jcajka agrees with it I see no problem in merging it I probably need to check if the mechanism can be used in go-rpm-macros for tests, having a common way to do things is always good. Remember that you’re going to lose GOPATH and GO111MODULE assignments, and depending on the Go module weirdness of the day, that may not end well when building within koji. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/21 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: [Fedocal] Reminder meeting : Go SIG Meeting
You are kindly invited to the meeting: Go SIG Meeting on 2019-07-09 from 16:00:00 to 17:00:00 UTC At fedora-gol...@irc.freenode.net I will probably be late today, if I manage the meeting at all. -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: New Go Packaging Guidelines landed in rawhide (koji) today
Hi, > What should I do at this moment as a packager that maintaining some > Go packages? > Should I fix my packages and build against f31-go in Koji? Yes, sure, if you can that would be appreciated. The vast majority of packages is easy to clean up (just adapt the templates in go-rpm- templates or use go2rpm), it's just there is an awful lot of them, so Robert-André Mauchin (eclipseo) can not do all of them in a single pass. If you hit one of the cases where a project needs weird stuff, or if you do not understand something, there is help available here and in the #fedora-golang channel. Please just state here (or tell eclispeo directly) what you will convert, so you do not end up doing the same work in parallel. Quite often, eclipseo will have prepared things in his copr, just not built them in koji yet. https://copr.fedorainfracloud.org/coprs/eclipseo/golang-ng/ So taking up from where he prepared, and checking the result builds in koji and works for you, will accelerate things. @eclipseo: please correct if I wrote something that does not make things easier your side Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: HEADS UP: DynamicBuildRequires are available
Le 2019-06-18 10:19, Miroslav Suchý a écrit : Dne 18. 06. 19 v 3:27 Igor Gnatenko napsal(a): as of today, builders have been updated (thanks to Kevin) and DynamicBuildRequires finally work in Rawhide. Change Page: https://fedoraproject.org/wiki/Changes/DynamicBuildRequires Example of real build: https://koji.fedoraproject.org/koji/buildinfo?buildID=1286391 On the Change page we have two examples: one general minimal example and example of Rust. If any of you have more examples how to dynamically generate BuildRequires e.g., for nojs, ruby, golang... then please send it to me privately or here in this thread. I would love to add it to the documentation. The necessary tooling is already available Go-side and has been pushed as part of the https://fedoraproject.org/wiki/Changes/Adopt_new_Go_Packaging_Guidelines change last week (in rawhide only because it depends on changes in redhat-rpm-config not available in previous releases). As documented in the templates provided in go-rpm-templates, activating them is just a %go_generate_buildrequires call in %generate_buildrequires https://pagure.io/go-rpm-macros/blob/master/f/templates/rpm/spectemplate-go-0-source-minimal.spec#_105 (you need the rest of the Go packaging template for this to work) As noted in the template, this generates un-versioned BuildRequires (like our automated Go Requires). Versioning information will be available after we switch to modules our Go stack (the Golang module concept, not the Fedora one). That means Go 1.14 at the earliest, end of the year. The module support in Go 1.13, scheduled for this summer, is not complete enough to be used in rpm packages. @eclipseo: that means you can re-add automated BuildRequires to our Go packaging guidelibnes, it was removed because the Fedora infra was not ready yet. Regards -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #18: Passing extra args to `go test`
nim added a new comment to an issue you are following: `` The whole logic is here: https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-rpm#_352 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/18 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #18: Passing extra args to `go test`
nim added a new comment to an issue you are following: `` `gocheckflags` is here to pass exclusion information to `go-rpm-integration` in `gocheck`, the same way `goinstallflags` works in `goinstall`. To pass information explicitely to the `go test` layer, you need `gotestflags`. Be careful because this variable is already set by the macro parts inherited from `go-compilers`, add to it do not overwrite it. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/18 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #25: Always install SFiles whatever the arch
nim commented on the pull-request: `Always install SFiles whatever the arch`
that you are following:
``
Ok, weird that @jchaloup gone to all this pain for something that does not work
Reading the urfave/cli documentation (that I don’t know well, I used
jawher/mow.cli in modist), it seems you need to define a default extension value
```
cli.NewStringSlice(".s", ".proto")
```
(https://github.com/urfave/cli/pull/392)
and then set it as value
```
Value: cli.NewStringSlice(".s", ".proto")
```
here https://pagure.io/golist/blob/master/f/cmd/golist/golist.go#_80
But, I may be misreading the documentation, and I have no access to by coding
setup right now :( It needs testing
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/pull-request/25
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #25: Always install SFiles whatever the arch
nim commented on the pull-request: `Always install SFiles whatever the arch` that you are following: `` That looks good to me (I assume you checked it builds and works). That's how I would have done it. @qulogic up to you now `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/25 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #17: Go does not install SFiles not required by the arch
nim added a new comment to an issue you are following: `` @qulogic reading `golist` code, it should just need the same kind of processing as for protobuf files https://pagure.io/golist/blob/master/f/pkg/util/util.go#_77 (assuming we want all .s files added inconditionally) `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/17 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #17: Go does not install SFiles not required by the arch
nim added a new comment to an issue you are following: `` That’s not hard to do (just add the flag to %goinstallflags ) but this variable is almost empty now, because all past file selection mistakes where fixed in `golist` @qulogic do you need the workaround added to `go-rpm-macros` or can you fix it `golist`-side in time for @eclipseo ? `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/17 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #4: Issues building golang source package on EL7
nim added a new comment to an issue you are following: `` Closing, since the root cause is actually the same as issue #2 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/4 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #4: Issues building golang source package on EL7
nim added a new comment to an issue you are following: `` Closing, since the root cause is actually the same as issue #2 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/4 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist
nim added a new comment to an issue you are following: `` And the fix is now in rawhide, with go-rpm-macros 3.0.8 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist
The status of the issue: `%goinstall should verify explicit paths exist` of project: `go-rpm-macros` has been updated to: Closed by nim. https://pagure.io/go-rpm-macros/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #1: -devel subpackage is build tag specific
nim added a new comment to an issue you are following: `` This should be fixed with golist 0.10.0 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/1 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #2: EPEL availability
nim added a new comment to an issue you are following: `` A POC implementation is here https://copr.fedorainfracloud.org/coprs/nim/macros-ng/builds/ `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/2 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #2: EPEL availability
nim added a new comment to an issue you are following: `` A POC implementation is here https://copr.fedorainfracloud.org/coprs/nim/macros-ng/builds/ `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/2 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #6: golist needs to be run outside the source tree to avoid panics
nim added a new comment to an issue you are following: `` Modules are now disabled by default, module mode will require a new tooling stack refresh anyway. Closing `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/6 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #6: golist needs to be run outside the source tree to avoid panics
The status of the issue: `golist needs to be run outside the source tree to avoid panics` of project: `go-rpm-macros` has been updated to: Closed by nim. https://pagure.io/go-rpm-macros/issue/6 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #4: Issues building golang source package on EL7
nim added a new comment to an issue you are following: `` So, the whole Go tooling update and cleanup is now finished in rawhide. The corresponding tooling port to EL7 is here: https://copr.fedorainfracloud.org/coprs/nim/macros-ng/builds/ (lightly tested, but it should handle all the divergences between rawhide and EL7) I'm not sure I have enough karma and energy left to get in merged officially EL7-side. The process Fedora-side was already exhausting. If that's of interest to someone, the maintainers to lobby are the epel-rpm-macro and golang ones. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/4 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: New Go Packaging Guidelines landed in rawhide (koji) today
Le 2019-06-12 10:39, Jakub Cajka a écrit : Fedora’s new Go packaging macros landed in rawhide (koji) today. I thought that we have agreed on Go SIG meeting with eclipseo to do this in side tag along with golang rebase(to avoid 2 rebuilds), https://fedoraproject.org/wiki/Changes/Adopt_new_Go_Packaging_Guidelines#Summary “ This proposal consists of: Packaging the new Go macros: go-rpm-macros Getting the Guidelines approved by the FPC Updating all Go libraries with the new macros Mass-rebuilding all the Go package in a side tag ” You complain that step 3 and 4 are separate, but that’s how it was planed from the start up and approved in the change page. You're conflating merging two mass Go package rebuilds (one for the new Go compiler, and another for the new, and first, Go packaging guidelines) with merging step 3 and 4 (which would have had other drawbacks, that were never discussed, because that's not how we planed things). And BTW it was already so in https://pagure.io/GoSIG/go-sig/issue/20 6 months ago (though this page is obsolete, you made us rewrite the plan in so many formats over time I've lost track or what is up to date or not. The change page is up to date, it’s the most recent rewrite) Sincerely, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
New Go Packaging Guidelines landed in rawhide (koji) today
Hi, Fedora’s new Go packaging macros landed in rawhide (koji) today. The corresponding Fedora Go packaging conventions are therefore EFFECTIVE for new rawhide builds. For the first time in Fedora’s history, we will be able to perform Go package builds conforming to an approved Fedora Packaging Guideline. Packaging documentation: https://eclipseo.fedorapeople.org/guidelines/packaging-guidelines/Golang/ and approval: https://pagure.io/packaging-committee/issue/382 The go-rpm-templates package provides more complete info. F31 change page: https://fedoraproject.org/wiki/Changes/Adopt_new_Go_Packaging_Guidelines and approval: https://pagure.io/fesco/issue/2120 While the guidelines will feel familiar to anyone who created a Fedora Go packages in the last two years, they DO include a backwards- incompatible change. Making GOPATH manipulation robust required moving the corresponding logic to %prep with a new %goprep macro. Therefore, existing specs are expected to fail without the addition of the %goprep call. This is of course not the end of the road, just a key step. It opens the way to a mass cleanup and refresh of the Fedora Go stack. https://pagure.io/packaging-committee/issue/901 A preview of this refresh is available here: https://copr.fedorainfracloud.org/coprs/eclipseo/golang-ng/builds/ Enormous thanks to – Robert-André Mauchin (eclipseo) for the gigantic work done reviewing updating and cleaning-up all those packages, and to – Elliott Sales de Andrade (Qulogic), that picked up maintenance of golist and fixed many of its long-standing bugs and limitations. Many thanks to the mock, rpm and redhat-rpm-config maintainers, that integrated the changes, we built upon (Igor Gnatenko, Florian Festi, Miroslav Suchý, Panu Matilainen) The macro set supports Go DynamicBuildRequires https://fedoraproject.org/wiki/Changes/DynamicBuildRequires They will be usable in mock as soon as rpm 4.15 lands https://fedoraproject.org/wiki/Changes/RPM-4.15 Use in koji or copr will have to wait for the corresponding refresh buldsystem-side. So this part of the change is a technology preview for now. Best regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130
nim commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` @bex sadly there are not many (any?) good wills to do regular reviewing. The repo history shows long periods of one-man commits, be it now or when the maintenance was done by others. @eclipseo does most of the second level checking/testing nowadays (thanks a lot!) but that does not happen in PR tickets (and sometimes he tests pre-versions of code before they even end up in a PR) So it's not a SIG policy set in stone, just a side effect of the small kernel of people that work on Fedora Go tooling. It can change any time people show up and propose to take ownership of something (be it reviewing, documenting, or anything else that could benefit from more contributions). If anyone here volunteers to conduct a formal review of the next PRs, there's no problem to keep them open some more. As long as it's not just gathering up dust in the hope some hypothetical reviewer will eventually show up. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/16 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130
nim commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` Ah, that Just because it is trivial does not mean stupid typos can not happen, so the commits cook in a private feature branch (where I can rewrite git history without bothering anyone) and are merged when they pass testing. The commit state that get merged is rarely the first version I wrote. Is there a simpler/better method to move reliably a set of commits from a forked feature branch to the main project? `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/16 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130
nim commented on the pull-request: `make it use the actual code that was merged in redhat-rpm-config-130` that you are following: `` @ignatenkobrain sorry, I didn't know there was much interest in reviewing such a trivial commit (or in go-rpm-macros PRs in general). If you have any comment on the result, please report it, code is not set in stone, merge or no merge. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/16 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` make it use the actual code that was merged in redhat-rpm-config-130 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/16 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #16: make it use the actual code that was merged in redhat-rpm-config-130
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` make it use the actual code that was merged in redhat-rpm-config-130 `` https://pagure.io/go-rpm-macros/pull-request/16 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #15: small fixes
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` small fixes `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/15 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #15: small fixes
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` small fixes `` https://pagure.io/go-rpm-macros/pull-request/15 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #14: make use of golist --with-tests in dynamic buildrequires
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` make use of golist --with-tests in dynamic buildrequires `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/14 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #14: make use of golist --with-tests in dynamic buildrequires
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` make use of golist --with-tests in dynamic buildrequires `` https://pagure.io/go-rpm-macros/pull-request/14 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #24: Add option for querying main and test simultaneously.
nim commented on the pull-request: `Add option for querying main and test simultaneously.` that you are following: `` `--with-tests` (as suggested in the original issue) is a fine API with me. I don’t have better ideas. Please merge `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/24 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #13: make use of golist 0.10.0 fixes
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` make use of golist 0.10.0 fixes `` https://pagure.io/go-rpm-macros/pull-request/13 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #13: make use of golist 0.10.0 fixes
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` make use of golist 0.10.0 fixes `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/13 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: Review Request and Questions
Le mardi 21 mai 2019 à 17:31 +0200, Brian (bex) Exelbierd a écrit : > > > > BUILDDATE=$(date +%Y-%m-%d) > > > > Please don't do that, that breaks build reproducibility. > > My understanding is that reproducible build systems typically provide > a build date value. A reproducible build means the same inputs produce the same (bit- perfect) outputs. Putting a date in the produced builds breaks that. The people Fedora and Debian-side that work on making builds reproducible and auditable have been hunting down this kind of breakage for years, yet people keep reintroducing them. Just don't put build dates into produced files. It's an anti-pattern https://reproducible-builds.org/ “First, the build system needs to be made entirely deterministic: transforming a given source must always create the same result. For example, the current date and time must not be recorded and output always has to be written in the same order.” Regards, -- Nicolas Mailhot ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
Re: Review Request and Questions
Le mardi 21 mai 2019 à 10:43 +0200, Brian (bex) Exelbierd a écrit :
> Hi,
>
> I have submitted the first of my dependency review requests here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1712280
>
> Feedback is greatly appreciated so I can clean anything up on the
> next
> set of dependencies.
>
> I am working on the main application packaging for gocryptfs
> (https://github.com/rfjakob/gocryptfs/) and have hit a few questions:
>
> 1. The upstream provides specific source tarballs for each version
> here, https://github.com/rfjakob/gocryptfs/releases - I am planning
> to
> use these as opposed to the gomacros to determine a git tag to pull.
> Is there a reason not to do this
The downside is that you will lose the ability to switch easily to a
tag or commit shall you need in the future. So, that depends if your
upstream is reactive or not. If your upstream always releases manually
when you need it to, you don't need to use the source our macro
computes
>
> 2. The upstream build script sets up some values to be included in
> the
> executables version string. I presume this helps with debugging. I
> am told that the Go SIG would prefer to see the macros used for
> building rather than the upstream build script. This is fine, except
> I am not sure how to handle these values. Specifically, they are:
>
> GITVERSION=$(cat VERSION)
I don't remember if the macro version in fedora already does this, but
the one that will land in devel soonish will compute that kind of
ldflag by default for all go packages
https://pagure.io/go-rpm-macros/blob/master/f/rpm/lua/rpm/go.lua#_61
> GITVERSIONFUSE=$(rpm -q golang-github-hanwen-fuse-devel --queryformat
> '%{version}')
That really begs for
https://github.com/rpm-software-management/rpm/issues/607
It's sad that eveyone is reinventing its own hack to implement
something taht should be done by default by rpm. If you have the time,
please explain rpm upstream why tracking this kind of info is useful.
> BUILDDATE=$(date +%Y-%m-%d)
Please don't do that, that breaks build reproducibility.
Regards,
--
Nicolas Mailhot
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #12: Force GO111MODULE=off till the macros grow Go module support
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` Force GO111MODULE=off till the macros grow Go module support `` https://pagure.io/go-rpm-macros/pull-request/12 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #12: Force GO111MODULE=off till the macros grow Go module support
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Force GO111MODULE=off till the macros grow Go module support `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/12 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #11: update licensing
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` update licensing `` https://pagure.io/go-rpm-macros/pull-request/11 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #11: update licensing
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` update licensing `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/11 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #10: Move a lot of code unrelated to srpm creation to srpm macros
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` Move a lot of code unrelated to srpm creation to srpm macros `` https://pagure.io/go-rpm-macros/pull-request/10 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #10: Move a lot of code unrelated to srpm creation to srpm macros
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Move a lot of code unrelated to srpm creation to srpm macros `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/10 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #12: golist should be buildroot prefix aware
The status of the issue: `golist should be buildroot prefix aware` of project: `golist` has been updated to: Closed by nim. https://pagure.io/golist/issue/12 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #9: Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 https://github.com/rpm-software-management/rpm/issues/671
nim opened a new pull-request against the project: `go-rpm-macros` that you are following: `` Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 https://github.com/rpm-software-management/rpm/issues/671 `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #9: Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 https://github.com/rpm-software-management/rpm/issues/671
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` Use relative symlinks for goalts; workarounds https://pagure.io/golist/issue/12 https://github.com/rpm-software-management/rpm/issues/671 `` https://pagure.io/go-rpm-macros/pull-request/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #12: golist should be buildroot prefix aware
nim added a new comment to an issue you are following: `` Ok, I found a workaround. Let’s focus on still broken things for now `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/12 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #23: WIP: Add output templating
nim commented on the pull-request: `WIP: Add output templating` that you are following: `` @qulogic Looks good (not tested). Not sure the `\n` is necessary for `BuildRequires` but having the option to put everything on one line may be useful for `go test` `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/23 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #21: Overhaul CLI
nim added a new comment to an issue you are following: `` @eclipseo Please play a little with `modist` and tell us if it is better. I tried to fix the CLI interface. `cobra` is difficult to use in a core utility like `golist`. It has lots of requirements, so bootsrapping a Go stack that required cobra to work would be quite difficult. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/21 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #20: Add ignored Go files install list
nim commented on the pull-request: `Add ignored Go files install list` that you are following: `` Indeed, it is very nice to see `golist` being improved at last! `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/20 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #18: Golist should work without $GOPATH from any directory
nim added a new comment to an issue you are following: `` The download is a no-go since it will be blocked by CI/CD systems like `mock`. It should be possible to avoid setting a build-specific `GOPATH` in golist, by importing directly the directories golist operates on, and taking other code from a static system `GOPATH`. Setting the build-specific `GOPATH` is where most of the problems lie: you have to create a specific directory structure, before golist will even parse your files. The system `GOPATH` OTOH is harmless and fine. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/18 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #13: golist should permit specifying its output format
nim added a new comment to an issue you are following: `` > Do you need format string for file lists (or just the provided/installed)? There's no need to format file lists, as long as the installation is left to something else. If golist was to take over installation (as is done by modist install) it would need to output directories with `%dir` in rpm mode. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/13 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #12: golist should be buildroot prefix aware
nim added a new comment to an issue you are following: `` I don't remember where the files end up (under `BUILD` or `BUILDROOT`) and I may have mixed up the rpm variable representing rpm's last stage staging directory. The basic point is that for `Requires`/`Provides` we are not calling `golist` explicitly, rpm is doing it in [generator](https://rpm.org/user_doc/dependency_generators.html) mode. And the filesystem tree rpm is operating in generator mode is a mirror of the target FHS structure, except `/` is replaced by a prefix directory. That breaks absolute symlinks (they are already pointing to `/` not the prefix directory), so anything that walks the directory structure like golist needs to have special code for computing the correct symlink target in `Requires`/`Provides` generator mode. ie “the symlink is pointing to `/foo/bar` but I’m in prefix mode so the actual target is probably `/prefix/foo/bar/`” This could probably be made better rpm upstream side by making `Requires`/`Provides` on a container that fakes the root properly, but rpm was designed before containers existed and getting the containing logic right is hard . `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/12 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #8: Fix missing variable in license detection
nim merged a pull-request against the project: `go-rpm-macros` that you are following. Merged pull-request: `` Fix missing variable in license detection `` https://pagure.io/go-rpm-macros/pull-request/8 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] PR #8: Fix missing variable in license detection
nim commented on the pull-request: `Fix missing variable in license detection` that you are following: `` Good catch, thanks, the variable was dropped in a recent code cleanup. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/pull-request/8 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist
nim added a new comment to an issue you are following: `` Ok I've checked the current code and the problem also exists here. I have a fix, will commit it once I'm somewhere that allows ssh access to pagure (since pagure does not allow https commits) `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist
nim added a new comment to an issue you are following: `` (BTW did you check what happens with the current macro version? This part has been refactored for more robustness, even though this is definitely a case I didn't check so if it's fixed it's fixed as a side effect of something else ;)) `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #17: Replace Go internals with go/build
nim commented on the pull-request: `Replace Go internals with go/build` that you are following: `` The v2 is module versioning. That's something we need to support to have working Go packaging. It's good that your PR starts picking it up when the previous code does not. However you are right that just doing it that way is going to break things. It needs changes in other parts of `golist` *and* in the macro code (and the current go-rpm-macro code should be in a good enough shape to allow those changes but that ’s not what it in Fedora). Looking at how `github.com/cespare/xxhash` handled the module transition, assuming it is representative of the conversion of a real-world codebase to modules, here is the list of the things I see needing doing (paper analysis, real work implementation and testing is needed) - we have the new module descriptors. That means `golist` needs to include the `go.mod` file as part of the project files, otherwise it will not end up in the -devel package and rpm will (rightfully) ignore it when generating deps - then once the `go.mod` file is in the devel package we need to check the golist call that generates the package provides actually sees it (should probably just work with the code in go-rpm-macros and will almost certainly fail in some case with the code in Fedora because some of the approximations I fixed this year and which are still in the Fedora macro code will definitely hurt module parsing) - then we have the fact that modules break the identity between the URL and the import path. The code is still at `https://github.com/cespare/xxhash` but the logical name is now `github.com/cespare/xxhash/v2`. No matter this is a case that is handled nicely by go-rpm-macros, that just means you need to declare `github.com/cespare/xxhash/v2` as `goipath` and `https://github.com/cespare/xxhash` as `forgeurl` - the module says v2 depends on v1 which means you need a separate v1 spec and package with just `github.com/cespare/xxhash/` `goipath` (and be careful to pull from the V1 banch not the v2 one) - but, what happens when a single git repo ships several `go.mod` files with a logical name that has nothing to do with the URL path ? I suspect things will break badly. the latest go-rpm-macros code is a lot more flexible, but it still assumes some form of identity between the filesystem layout and the import layout. How badly will this identity break with modules? I have no idea. - and then you have the version qualifiers in the module files, we need to map them rpm side one way or another `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/17 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #7: %goinstall should verify explicit paths exist
nim added a new comment to an issue you are following: `` Yes goinstall error checking should be improved (even though the target will be modules soonish that should hopefully remove the need for custom install hacks) `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] PR #17: Replace Go internals with go/build
nim commented on the pull-request: `Replace Go internals with go/build` that you are following: `` Ok, after more work evolving to module support seems a bit simpler than I though, because go mod need requires people to clean up their mess and that's also the assumption of the current go-rpm-macros. Though it will definitely require the coding of a helper in go, since the json structure go mod edit outputs is pretty much unworkable in shell, lua is not available at this stage of the rpm build, and I don't think we need to inject a fourth language in our go tooling (after lua+shell due to how rpm works, and golang for golist). The 1000-dollar question is how much this new helper can subsume current golist functions, or if we end up with 2 helpers because go module is almost there for our needs but not completely. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/pull-request/17 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #6: didn't find "github.com/google/go-cmp/cmp"
The issue: `didn't find "github.com/google/go-cmp/cmp"` of project: `golist` has been assigned to `nim` by nim. https://pagure.io/golist/issue/6 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #6: didn't find "github.com/google/go-cmp/cmp"
nim added a new comment to an issue you are following: `` I will recheck. cloud.google.com/go is a full bag of nastiness, that even other Google projects have problems with (most of them still import it under a legacy name, which means they are afraid of using the latest code. The current cloud.google.com/go asserts its new name which means anything still using the legacy name never tried to use the current codebase). `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/6 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
The issue: `incomplete import detection for tests ` of project: `golist` has been assigned to `nim` by nim. https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
nim added a new comment to an issue you are following: `` golist does not uses this kind or regexes it plugs directly in the Go compiler inner code to match the Go compiler view of what's in a project. This was a deliberate choice by Fedora Go maintainers last year, my initial macro implementation just performed regexes in shell scripts. So golist results should be more correct that what you would expect naïvely from a human file path analysis. Unfortunately that also assumes the integration with Go compiler rules is correct and complete. For example golist would initially parse files starting with '_', even though the Go spec says it should not, I suppose because Google implemented '_' in some other place of its codebase. So basically, it's not as clear cut as that, this issue needs investigating why the Go compiler code thinks this file is a test file, and whether this is correct WRT the Go language spec, and not superseeded by some other exception golist does not implement. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #7: runtime panic, nil dereference when running %gochecks
nim added a new comment to an issue you are following: `` BTW: * thanks an *awful* lot for looking at golist code maintenance * if you can figure how to make golist process module info, and spit out the version constrains that only exists in those modules, that would be much nicer than inhibiting the module code path. Mid term, it would be more efficient for Fedora to process modules info by default, and contribute module descriptors to projects that miss then, rather than having packagers deal with the complexity of not using module info when upstreams already migrated to modules, or (worse) having to deal with some Go components in module mode and others in legacy something else mode That's more or less liked to issue #13. A lot of the un-necessary complexity in the macro code is due to reprocessing the golist output format into something that rpm can use. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #10: unexpected directory layout (whatever that means)
nim added a new comment to an issue you are following: `` Yes, I suppose an alternative would be to track the things that depends on this bit of code and ask them to drop it. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/10 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #9: incomplete import detection for tests
nim added a new comment to an issue you are following: `` Ah ok. I think that's because we only hit it when executing tests. Will look at it once more, maybe the logrus code was refactored since this was filed `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/9 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #8: Crash when processing github.com/kr/pretty 0.1.0
nim added a new comment to an issue you are following: `` Sure it does, however till someone analyses both issues and concludes they are the same, it's dangerous to track only one of them. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/8 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #6: golist needs to be run outside the source tree to avoid panics
The issue: `golist needs to be run outside the source tree to avoid panics` of project: `go-rpm-macros` has been assigned to `nim` by nim. https://pagure.io/go-rpm-macros/issue/6 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #7: runtime panic, nil dereference when running %gochecks
nim added a new comment to an issue you are following: `` For readers that don't understand the latest exchange, the participants wrote their piece here https://pagure.io/GoSIG/go-sig/issue/3 `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #7: runtime panic, nil dereference when running %gochecks
nim added a new comment to an issue you are following: `` @jcajka: how do you expect anyone to understand your position? Months over months of not accepting macro fixes, months over months of finding new reasons not to look at them, refusal to discuss it in SIG meetings, no activity in the pagure tickets that were opened at your request to follow things, etc You complain you're asked to look at a fork. But it's only a fork because you don't take steps to review and merge the result (or merge some other better implementation). Every time I fix a new problem (like the one reported here) that takes the code further from what got into Fedora and makes you less willing to look at the result. `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #7: runtime panic, nil dereference when running %gochecks
nim added a new comment to an issue you are following: `` That sucks since other projects *expect* to be in the source dir when run. So I guess the shell wrapper will need to be changed to run golist outside this dir and switch to it afterwards: ( I've filled it as https://pagure.io/go-rpm-macros/issue/6 Note that even if I write the workaround soonish, Fedora go-rpm-macros import is stuck on https://pagure.io/GoSIG/go-sig/issue/22 and I'm sick of all the unrealistic conditions jcajka invents to relay the review (for example, macro unit tests, when we even a core well supported language like python does not have those and no one know how to do it) `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #1: golist should be ported to a current release of gopkg.in/urfave/cli.v1
nim added a new comment to an issue you are following: `` @qulogic this is all originally @jchaloup 's code. He asked to split it in a separate repository, but I don't know what's the level of involvement he wants (and can) provide here. Ask him politely how he wants to do things (of course if he can not or does not want to answer over a reasonable time that would be an answer in itself) `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/1 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #14: golist should handle naming assertions cleanly
nim reported a new issue against the project: `golist` that you are following: `` Because the naming of Go projects is a mess many of them (including core Google modules) have started asserting how they should be named. This results in golist panics. Because golist is often called by other scripts (for example, rpm dependency scripts) the panic messages are unhelpful, because the recipient of those messages has not called golist directly and does not know what exact golist call resulted in this panic. golist should handle this case by default and: 1. output useful info to stderr, including what exactly it was doing at the panic time 2. abort with an error code `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/14 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #4: Issues building golang source package on EL7
nim added a new comment to an issue you are following: `` Yes that's what I meant by a little tricky. The changes are not big or scary but they are spread over several packages that call one another, it's easier to publish a copr with all the small changes than try to walk you through it manually. Now the result works as well in EL7 and in devel, there are no backport regressions, but I can't promise it will be in EPEL soonish, there's a lot of Fedora admin work before that can happen. Even the Fedora part requires buy-in to execute the [cleanup plan](https://pagure.io/GoSIG/go-sig/issue/20). Mainly, lots of changes and fixes that accumulated in the last year that need someone to step in to review the result. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/4 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #7: runtime panic, nil dereference when running %gochecks
nim added a new comment to an issue you are following: `` The original reporter may not see the question since this is a migrated issue. But even if tests were still being run (not sure about this), a panic is pretty bad behavior: packagers are supposed to care about how builds proceed, we don't want them to ignore errors in build logs because they may be harmless (so the tooling should not inject errors there) `` To reply, visit the link below or just reply to this email https://pagure.io/golist/issue/7 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #4: Issues building golang source package on EL7
nim added a new comment to an issue you are following: `` It's kind of hard to diagnose without the spec file and build logs, but basically there have been a lot of fixing and rewriting in the months since the wiki page was written. Macro usage is still the same but the code itself has changed and moved a bit. That means using them on EL7 takes a bit more work than copying a single file. If you want to play with the code the latest implementation is in this [copr](https://copr.fedorainfracloud.org/coprs/nim/go-rpm-macros/). It still needs [redhat-rpm-macro changes](https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/51) before merging in fedora-devel but it works and is fully documented [here](https://pagure.io/go-rpm-macros/blob/master/f/templates/rpm) Pretty much the same code works for EL7, we're using it extensively internall. But the macro packaging is a bit trickier and the current version is not published right now. I can push it to a copr next week if you're interested. More usage and review is always good. `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/4 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[go-rpm-macros] Issue #3: %goprep should apply patches automatically
nim added a new comment to an issue you are following: `` > How do we handle the case of when patches should be applied > manually/conditionally? That would actually be trivial to handle cleanly ```specfile %if %global source_patches3 6 87 456 # apply patches 6 87 456 after unpacking source 3 in that order %else %global source_patches3 666 # only apply patch 666 ``` `` To reply, visit the link below or just reply to this email https://pagure.io/go-rpm-macros/issue/3 ___ golang mailing list -- golang@lists.fedoraproject.org To unsubscribe send an email to golang-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
[golist] Issue #13: golist should permit specifying its output format
nim reported a new issue against the project: `golist` that you are following:
``
`golist` only implements a single output format, which means this output needs
to be reprocessed in shell before being fed to other software, like rpm¹.
This shell reprocessing is brittle and adds noise to Go package build logs.
Mature utilities allow specifying an output format template, which simplifies
their integration with other software. This can be done:
* either by defining a custom format string using predefined variables (as
[done](http://man7.org/linux/man-pages/man1/time.1.html) by the `time
-f`command),
* or by specifying a specific package dep format built-in (as done by the
`fcquery --format '%{=pkgkit}'` command, that allowed direct integration
[within
rpm](https://github.com/rpm-software-management/rpm/blob/ff4b9111aeba01dd025dd133ce617fb80f7398a0/scripts/fontconfig.prov)
in [2009](https://bugs.freedesktop.org/show_bug.cgi?id=17107)).
`golist` should implement something similar.
¹ Typically to [add
`golang()`](https://pagure.io/go-rpm-macros/blob/master/f/rpm/macros.d/macros.go-rpm#_228)
around dependencies, would need more processing if it ever evolves to list
version constrains
``
To reply, visit the link below or just reply to this email
https://pagure.io/golist/issue/13
___
golang mailing list -- golang@lists.fedoraproject.org
To unsubscribe send an email to golang-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/golang@lists.fedoraproject.org
