Re: TabLayoutPanel, content widget is hidden after select tab

2011-02-09 Thread vkrejcirik
Ok, I tried firebug. I think it isn't attached. I cannot find my widgets in firebug. In the past, I used DecoratedTabPanel in the same way and it worked great. On 8 ún, 22:33, Jeff Larsen larse...@gmail.com wrote: That is the right way to get the doctype set to standards mode. Have you

Re: EditTextCell - avoid escaping signs

2011-02-09 Thread Opal
Thanks, I'll investigate the link. On 8 Lut, 16:36, John LaBanca jlaba...@google.com wrote: I created an issue to track this:http://code.google.com/p/google-web-toolkit/issues/detail?id=5993 We need to do some type of escaping because user values could include unsafe javascript code.  

Re: Implementing Contacts List with 'mark as favorite' checkbox

2011-02-09 Thread Nettar
Thank you very much John, it worked very well.. On Feb 8, 6:14 pm, John LaBanca jlaba...@google.com wrote: You can control selection by passing a DefaultSelectionEventManager with a custom EventTranslator as a second arg into setSelectionModel. It might look something like this: class

Re: RequestFactoryEditorDriver example?

2011-02-09 Thread George Moschovitis
It works perfectly. So I'm not sure what is the issue with your code, can you show a snippet? OK, I still can't get this to work, here is a snippet: public class ArticleEditor extends Composite implements EditorArticleProxy { interface Binder extends UiBinderWidget, ArticleEditor {

Re: OOPHM memory leak?

2011-02-09 Thread Thomas Broyer
See also http://code.google.com/p/google-web-toolkit/issues/detail?id=5486 (fixed in 2.1.1) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this

Re: Partial bean validation

2011-02-09 Thread Lazo Apostolovski
Hello any body please? Its realized? Its not realized? Will be realized? Patch is needed? Cant be realized? Isn't planed? Any answer? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Re: Blank screen in IE7 but normal in IE6, IE8, FF

2011-02-09 Thread eirc
Hey, Do you have any info on this? Did you solve it after all? I have a similar issue where content added to a google maps InfoWindow does not display at all if I use LayoutPanels but is OK if I use the old (and deprecated) panels. -- You received this message because you are subscribed to

Re: selection questions

2011-02-09 Thread tomInNewEngland
Thank you. It has taken some puzzling, but the MVP approach seems to encompass most of my questions about how to structure things. On Jan 26, 8:32 pm, Y2i yur...@gmail.com wrote: It's strange that it loses selection. Anyway, you can always get the selected object in onSelectionChange() method

Re: CellList alternating row background color

2011-02-09 Thread Mike
So I've been trying to figure this out, and I'm just really still missing something... here's as far as I've gotten. I can't seem to wrap my head around how I get from here to using a custom style for the cellList. Anyone feel like writing me a little bit of sample code? Thanks, -Mike

CellTable SelectionModel

2011-02-09 Thread Alejandro D. Garin
Hi, I'm using a CellTable like a vertical menu Widget. i.e. the table is a list of menu items (for navigation) that will fire Places when the user click on any of the availables menues. Everything is OK except in the case that the application need to be started at an specific menu item. I want

debugging: async server won't start -- I think

2011-02-09 Thread tomInNewEngland
Hello all: Another beginning-type question, but I cannot find the answer in the docs: I have constructed an asynchronous service to run on my server, with the yyService, and its matching yyServiceAsync and yyServiceImpl functions, but the issuing callback always goes to the onError() method. In

Re: ServiceLayerDecorator guides

2011-02-09 Thread David Chandler
According to ServiceLayerCache, the cache is implemented as a static variable, so locator services and methods may be cached for all users. Your locators and service instances should therefore not keep any user-specific info, but rather obtain it in each method through a call to

CellTree Selecting nodes programmatically

2011-02-09 Thread Tej Sarup
I just wanted to know if I have a CellTree in the collapsed form and there is a selection model backing the tree. - Is there any way I can select the nodes programmatically if I know the key (used by the KeyProvider) of the nodes which have to be selected? - The individual cells in the tree

Re: CellList alternating row background color

2011-02-09 Thread Thomas Broyer
interface MyCellListResources extends CellList.Resources { @Source(myCellListResources.css) CellList.Style cellListStyle(); } new CellListFoo(cell, GWT.create(MyCellListResources.class)); Then copy the default stylesheet from within gwt-user.jar into your own myCellListResources.css (that

Re: Blank screen in IE7 but normal in IE6, IE8, FF

2011-02-09 Thread luc.steff...@gmail.com
What DOCTYPE do you use? I had blank screens due to wrong DOCTYPE http://stackoverflow.com/questions/2641866/which-doctype-should-i-use-for-gwt-2-0 On 9 feb, 13:58, eirc eirc.e...@gmail.com wrote: Hey, Do you have any info on this? Did you solve it after all? I have a similar issue where

Reference JAR in Widget

2011-02-09 Thread Ümit
Hi everyone I am trying to develop a widget which should be deployed as a standalone JAR. The widget references a DataTable from the com.google.gwt.visualization.Visualization package. So I added the inherits name=com.google.gwt.visualization.Visualization/ to the module XML and reference the

Re: CellList alternating row background color

2011-02-09 Thread ET
I'd suggest overriding the render method if it's available in your implementation @Override public void render(Cell.Context context, YourDataObject value, SafeHtmlBuilder sb) { if (value == null) return; String row_class = ; if (context.getIndex() % 2 == 0) { row_class = even; }

Scroll Panel with only horizontal or only vertical scroll

2011-02-09 Thread Udam
Hello, I'm embedding a list inside the left pane of a SplitPanelLayout and enclosing the list inside the scroll panel. I only want the vertical scrolling. Is there a way to specify only vertical scrolling? Thanks, Udam -- You received this message because you are subscribed to the Google

Your browser does not support charts on IE8 (GWT 2.0.4 + gwt-visualization api 1.1.1)

2011-02-09 Thread SemperVivo
Hi everybody, I recently created a piechart (from the corechart api) using gwt 2.0.4 and gwt-visualization 1.1.1 but when I load the app in IE8 I am getting this message: Your browser does not support charts. Do you know why ? On the other browser everything checks ok. Thank you. -- You

Re: GWT DevMode : logging to a log file

2011-02-09 Thread Приладышев Владимир
Здраствуйте хочу предложить новую платежную систему http://www.paybox.me/r/prgold В Интернете продвигается новая платежная система - PayBox. Так как она только в развитии - регистрация БЕСПЛАТНАЯ, и на счет сразу ложится сумма в $25. Каждый день, если Вы посещаете сайт, добавляется еще $20.

Re: CellTree Selecting nodes programmatically

2011-02-09 Thread Y2i
You should be able to find the node by its key (in your model) and then use selectionModel.setSelected(node, true) to select the node. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

TabLayoutPanel border color

2011-02-09 Thread funkforce
Hi I have not manged to set the border color of the TabLayoutPanel and I wonder how to do that? I can change the tabs with the following code: .gwt-TabLayoutPanel .gwt-TabLayoutPanelTab.gwt-TabLayoutPanelTab { background-color: #99; color: #FF; }

Re: refresh page problem in gwt

2011-02-09 Thread Lukasz
Could you be more specific - e.g. what does the app do? Generally (if you didn't implement any browser history mgmt.) the browser refresh results with a complete reload of your app and a new call to the onModuleLoad method. HTH Lukasz On 9 Feb., 07:15, harry hemangsha...@gmail.com wrote: i m

Re: Partial bean validation

2011-02-09 Thread Lazo Apostolovski
Is this somehow related with this issue? http://code.google.com/p/google-web-toolkit/issues/detail?id=5801 -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To

Re: loading a property file from the backend with RequestBuilder?

2011-02-09 Thread Ed
In the meantime I simple made it myself.. Not so difficult: load the text... read the lines (see the BufferedReader for example code), and separate the key = value pairs... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this

Info. about Gmail Contextual Gadget

2011-02-09 Thread Josh
Hi everyone! I am new to this group. I have recently started working on Gmail Contextual Gadgets. Can you please help me. I am using GWT on Eclipse. Thanks, Josh -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send

Re: CellTable SelectionModel

2011-02-09 Thread John LaBanca
SelectionModels have to fire a SelectionChangeEvent, or the CellTable wouldn't know to highlight the selected item. Can you set the default selected value before adding your ChangeHandler? You'll have to call selectionModel#isSelected() to force it to resolve the selection state.

Re: how to add scroll bar in flowpanel ?

2011-02-09 Thread John LaBanca
You cannot use ScrollPanel on a mobile device because the browser in mobile devices do not support scrollable divs. Scrollbars will only appear at the page level (on the body element). We're working on adding touch event support to ScrollPanel to fix this. Thanks, John LaBanca

Re: how to add scroll bar in flowpanel ?

2011-02-09 Thread Jeff Schwartz
+1 yeah On Wed, Feb 9, 2011 at 11:03 AM, John LaBanca jlaba...@google.com wrote: ... We're working on adding touch event support to ScrollPanel to fix this. Thanks, John LaBanca jlaba...@google.com On Wed, Feb 9, 2011 at 12:04 AM, Hemang shah hemangsha...@gmail.comwrote: hey thanks

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Ernesto Reig
But what if the popup is complex enough to have its own logic? I mean, you have a popup acting as another mini-application. For example, a popup panel with a form asking for some input and a panel to show its search results which the user can interact with. Would it be correct to have its own MVP

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Thomas Broyer
It would be correct to have it's own presenter vs. view (vs. model), but * not* places and activities (or *at least* not using the same PlaceController and EventBus as the rest of the app, and not using PlaceHistoryHandler at all, i.e. running in a sandbox) -- You received this message because

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Jeff Schwartz
I may be treading on thin ice here but I haven't been convinced yet with the merits of MVP, particularly the one native to GWT which I find overly complex and poorly documented. I am developing a rather complex ui for an app which I had looked into using MVP for but it left me with more questions

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Ashton Thomas
I use complex popups and just create new widgets that extend PopupPanel MyComplexWidgetPopup extends PopupPane @Inject public My...(MyWidgetView view) where MyWidgetView is a UiBinder Acts exactly like an Activity where the Widget has the app logic and the view takes care of the

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Ernesto Reig
A question about architecture... Asthon, you said Then in the activity that calls the popup widget..., and my question is: Is it necessary that the popup has to be called by an activity? In my case, the popup is called from a MenuItem in a menu bar (that is static to the app and never changes),

Re: CellTable SelectionModel

2011-02-09 Thread Alejandro D. Garin
Hi John, thanks for the reply. Yes, actually I can do it in the app. first load, but later a Place can be fired programmatically from another UI screens. So, in this case the Place will be fired twice: 1. programmatically fired and 2. when the menu need to be selected to update the UI state.

Re: RequestFactory JPA: Does the table has to has a field called Version?

2011-02-09 Thread Ido
Hi, Sorry for inturrupting this thread, I'm a new to web development and a very junior GWT one, so sorry in advanced for every mistake. I'm implementing these days a GWT application from scratch, the data scope is assembled with Hibernate,Oracle and baking it with the RequestFactory

GWT + Fusioncharts

2011-02-09 Thread cutout33
Hi all, I just wanted to announce the immediate availability for GWT/GXT fusioncharts API. check the demos and sample code here http://aurorarnd.com/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Re: RequestFactory JPA: Does the table has to has a field called Version?

2011-02-09 Thread Thomas Broyer
The version is only used to decide whether to fire EntityProxyChange events with WriteOperation==UPDATE, so if you don't need to use these events, you can simply always return the same value (but not 'null' !) -- You received this message because you are subscribed to the Google Groups Google

Re: CellTable SelectionModel

2011-02-09 Thread Thomas Broyer
On Wednesday, February 9, 2011 7:04:07 PM UTC+1, Ale wrote: Hi John, thanks for the reply. Yes, actually I can do it in the app. first load, but later a Place can be fired programmatically from another UI screens. So, in this case the Place will be fired twice: 1. programmatically fired

Re: CellTable SelectionModel

2011-02-09 Thread Alejandro D. Garin
Well, in my case the activity is not equals because it's like a wrapper activity that calls another activities :( On Wed, Feb 9, 2011 at 4:01 PM, Thomas Broyer t.bro...@gmail.com wrote: On Wednesday, February 9, 2011 7:04:07 PM UTC+1, Ale wrote: Hi John, thanks for the reply. Yes,

Re: RequestFactory JPA: Does the table has to has a field called Version?

2011-02-09 Thread Ido
Hi Thomas, Thanks for the quick reply (and for your blog of course). Seems like I misunderstood the getVersion issue as I thought the locator could resolve it, Actually was mentioned https://groups.google.com/d/msg/google-web-toolkit/jmLQbgjCd2E/6NtUGbWrgLwJin this thread, few posts above.

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Ashton Thomas
Yeah should be just fine. Just pass the instance of the widget to the menu and your good to go. If you use Gin and @Inject the WidgetPopup and @Inject the view into the WidgetPopup, you will reuse the same element. so if you close the popup and then reopen it, you data and stuff will still be

Re: Developing a large scale GWT app and MVP

2011-02-09 Thread Ashton Thomas
An alternative may be to allow something more central than the menu take care of showing and hiding the WidgetPopup: Let's say you have one main Shell (uibinder for the main layout) You could create a new Event (ShowWidgetpopupEvent) and declare the handler and have the main Shell implement the

Re: RequestFactory JPA: Does the table has to has a field called Version?

2011-02-09 Thread Thomas Broyer
On Wednesday, February 9, 2011 8:30:42 PM UTC+1, Ido wrote: Hi Thomas, Thanks for the quick reply (and for your blog of course). Seems like I misunderstood the getVersion issue as I thought the locator could resolve it, Actually was mentioned

Re: Handling clicks on CellWidgets

2011-02-09 Thread Praveen Kumar
I have the same issue. Did anyone has an answer? On Jan 14, 10:39 pm, Ramon Salla rsal...@gmail.com wrote: I think i maybe found another bug: if          @Override           public void render(Context context, MyValue data, SafeHtmlBuilder sb) { sb.appendHtmlConstant(button

Overlays and Hosted mode

2011-02-09 Thread Harold Comere
Hi all, I have some perf issues in hosted mode using javascript object overlays. I am doing bindings for WebGL objects using gwt 2.1.1, for exemple i have the overlayed WebGLRenderingContext : import com.google.gwt.core.client.JavaScriptObject; public class WebGLRenderingContext extends

Re: Implementing Contacts List with 'mark as favorite' checkbox

2011-02-09 Thread Thomas Visser
You could also use a CellTable with two columns instead. The first column then should have a CheckboxCell which depends on the selection. It's value (as given by the getValue of the Column) should be equal to selectionModel.isSelected(object) and its ValueUpdater should update the selection. The

Deploying Application (GWT 2.1.0) on Tomcat

2011-02-09 Thread Veeren
I'm trying to deploy my recently coded HelloWorld application to Tomcat. I used the build scripts to generate the war file. When i deploy to Tomcat the application gets loaded properly. The problem arises when i access the application. In one of my ServiceImpls i have somehow got a runtime

Re: CellTable SelectionModel

2011-02-09 Thread Thomas Visser
Use the 2 parameter alternative: setSelected(T object, boolean selected). If the second parameter is false, the selection model will not fire a SelectionChangeEvent. On Feb 9, 2:43 pm, Alejandro D. Garin aga...@gmail.com wrote: Hi, I'm using a CellTable like a vertical menu Widget. i.e. the

Re: CellTable SelectionModel

2011-02-09 Thread John LaBanca
On Wed, Feb 9, 2011 at 10:01 AM, Thomas Visser thomas.vis...@gmail.comwrote: Use the 2 parameter alternative: setSelected(T object, boolean selected). The second parameter indicates whether or not the object is selected. I think you're thinking about HasValue#setValue(T, boolean), which can

gwt4air 2.0 is out

2011-02-09 Thread nino ekambi
Hello community, i m glad to annouce the release of gwt4air 2.0 the project nows add support for the Titanium Runtime( http://www.appcelerator.com/) For the full release note please look on the project page: http://code.google.com/p/gwt4air/ like always any feedback are very welcome. Regards,

Re: Overlays and Hosted mode

2011-02-09 Thread Thomas Broyer
Each time you go from Java to JS, and from JS to Java, the DevMode communicates with the plugin in your browser, which then communicates with the web page to execute the JS (and in Chrome, that last part is even slower than in other browsers due to chrome's architecture). -- You received this

Re: gwt4air 2.0 is out

2011-02-09 Thread Thomas Broyer
Wow! Looks like you worked hard since the 1.0! Keep up the good work Alain! ;-) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this group, send

Re: Deploying Application (GWT 2.1.0) on Tomcat

2011-02-09 Thread Y2i
May be you can get the commons logging jar? http://commons.apache.org/logging/guide.html -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to google-web-toolkit@googlegroups.com. To unsubscribe from this

Re: debugging: async server won't start -- I think

2011-02-09 Thread tomInNewEngland
Answering my own questions for the benefit of future generations: 1. Yes, it does. 2. Yes, it does. 3. What's described there is correct and there aren't other strings to match. 4. Be careful to examine the console more thoroughly than you did for the exceptions that may have been lost

Re: gwt4air 2.0 is out

2011-02-09 Thread nino ekambi
Thanks Thomas and there is more coming up :) Cheers, Alain 2011/2/9 Thomas Broyer t.bro...@gmail.com Wow! Looks like you worked hard since the 1.0! Keep up the good work Alain! ;-) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To

Re: SSH + RMI in GWT

2011-02-09 Thread A. Stevko
Hi Jim, Your concerns are quite justified. The GWT docs have a JRE emulation reference that shows what is supported at http://code.google.com/webtoolkit/doc/latest/RefJreEmulation.html http://code.google.com/webtoolkit/doc/latest/RefJreEmulation.htmlUnfortunately the java.rmi package is not listed

is it of any value to create RequestContext and EntityProxy test to validate their correctness ?

2011-02-09 Thread zixzigma
I have come across RequestFactoryInterfaceValidator class , which has many methods useful for validating RequestContext and EntityProxies. However I am not sure whether there is any value to use this Validation as part of the unit testing of our RequestFactory communication ? my idea is that

Re: is it of any value to create RequestContext and EntityProxy test to validate their correctness ?

2011-02-09 Thread zixzigma
this is what I am talking about ..., is there any value in creating tests like this ? @Test public void testRequestContextIsValid() { RequestFactoryInterfaceValidator v = new RequestFactoryInterfaceValidator( logger, new RequestFactoryInterfaceValidator.

Re: No Source code is available for type client.Utilityt, did you forget to inherit a required module?

2011-02-09 Thread NAARAYANA REDDY NANDIGAMA
Hi, My requirement is I need to populate the data from my DTO class which is there on serverside. So could you please advise me on how to populate the data from DTO classes to text boxes. On Tue, Feb 8, 2011 at 11:07 AM, NAARAYANA REDDY NANDIGAMA nandigam...@gmail.com wrote: Okay. Thank you.

ValueProxy.EntityProxy.field problem on setViolations()

2011-02-09 Thread Y2i
Hello everyone, It seems there is a problem with driver.setViolations() call when editing structures like ValueProxy.EntityProxy.field If I edit EntityProxy.field and the field is erroneous, the server calls onViolation() and when I call driver.setViolations() the erroneous fields are

sending image file using RequestFactory takes a long time. what is the correct way ?

2011-02-09 Thread zixzigma
What is the correct way to send images from server to the client ? this is my image proxy: public interface ImageProxy extends ValueProxy { String getName(); ListByte getImage(); } I use ListByte, because byte[] is not accepted by RequestFactory. I use Guava Bytes.toArray and

how to convert arbitrary java project using GWT compiler

2011-02-09 Thread Xiahong Gao
I have a non-gwt project. How could I use GWT compiler to convert this non-gwt project to javascript? thanks a lot in advance !! -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send email to

Re: Deploying Application (GWT 2.1.0) on Tomcat

2011-02-09 Thread P Osborne
The gwt-dev jar is there to support hosted mode, it shouldn't be delivered in the application war file. I believe that jar is operating system specific. -- Patrick On Wed, Feb 9, 2011 at 4:42 PM, Y2i yur...@gmail.com wrote: May be you can get the commons logging jar?

Re: Overlays and Hosted mode

2011-02-09 Thread P Osborne
hosted mode isn't for performance it is for debugging. Personally I've found that starting production Jetty is faster than starting hosted mode and waiting for the application to load. On Wed, Feb 9, 2011 at 3:53 PM, Thomas Broyer t.bro...@gmail.com wrote: Each time you go from Java to JS, and

Re: how to convert arbitrary java project using GWT compiler

2011-02-09 Thread Y2i
GWT compiler can only deal with the code written against this java sub-sethttp://code.google.com/webtoolkit/doc/latest/RefJreEmulation.html, not arbitrary java. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To post to this group, send

Re: CellTree Selecting nodes programmatically

2011-02-09 Thread Tej Sarup
Thank you Y2i! I have been able to get the nodes selected by doing what you have said. However one minor point which remains is that, is it possible to expand the tree so that the selected node is visible? Regards, t -- You received this message because you are subscribed to the Google

Re: CellTable SelectionModel

2011-02-09 Thread Thomas Visser
Sorry, I was completely off. On Feb 9, 11:26 pm, John LaBanca jlaba...@google.com wrote: On Wed, Feb 9, 2011 at 10:01 AM, Thomas Visser thomas.vis...@gmail.comwrote: Use the 2 parameter alternative: setSelected(T object, boolean selected). The second parameter indicates whether or not the

Re: To smart GWT or not

2011-02-09 Thread Nagin Kothari
Sanjiv, I know I am reopening this thread, not to criticise Smart GWT, but want to give some feedback. First of all let me acknowledge that it is very good library with lot of cool and fantastic features. I experimented with it and liked it and planning to use it in one of my project.But I have

[gwt-contrib] Re: Announcing GPE/GWT 2.2 RC1

2011-02-09 Thread ep
in addition, in most cases it doesnt matter what java version to use for GWT code, if your environment still allows java1.4 and you want to integrate latest GWT into your project, it will do perfectly if you keep GWT out of serverside as GWT does not dictate to use RPC communications, or the

[gwt-contrib] Re: Added missing validation jars to gwt-user.jar. Fixes Issue 5950. (issue1323803)

2011-02-09 Thread rchandia
Removed the hibernate validation implementation as it is not necessary. I guess we need to decide between adding stuff to gwt-user.jar with this approach or to add the respective jars to each gwtc invocation as in: http://gwt-code-reviews.appspot.com/1342803/show On 2011/02/09 15:19:17,

[gwt-contrib] Re: Generator Result Caching implementation for ClientBundle (issue1236801)

2011-02-09 Thread bobv
LGTM http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014 File user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java (right): http://gwt-code-reviews.appspot.com/1236801/diff/110014/111014#newcode231

[gwt-contrib] Re: Added validation jars to all calls to GWTC to provide classes rquired by (issue1342803)

2011-02-09 Thread rchandia
On 2011/02/08 19:02:29, rjrjr wrote: Don't you need to make the same changes to samples/expenses/pom.xml? Done. http://gwt-code-reviews.appspot.com/1342803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread zundel
I did a spot check. There is one odd thing that happens with the new settings on eclipse 3.5 (found in JsCatchScope) @Override protected JsName findExistingNameNoRecurse(String ident) { if (name.getIdent().equals(ident)) { return name; } } becomes @Override protected

[gwt-contrib] Re: Fix TestUtil.PathImpl to correctly test for non matching (issue1352801)

2011-02-09 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1352801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UiBinder accept IsWidget subinterfaces properly (issue1295806)

2011-02-09 Thread jlabanca
http://gwt-code-reviews.appspot.com/1295806/diff/1/10 File user/src/com/google/gwt/user/client/ui/HTMLTable.java (right): http://gwt-code-reviews.appspot.com/1295806/diff/1/10#newcode1105 user/src/com/google/gwt/user/client/ui/HTMLTable.java:1105: Element td = cleanCell(row, column, true); I

Re: [gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread Eric Ayers
The whitespace is me cutting and pasting. I trimmed the function of some stuff that wasn't pertinent to the problem. On Wed, Feb 9, 2011 at 10:50 AM, John Tamplin j...@google.com wrote: On Wed, Feb 9, 2011 at 10:43 AM, zun...@google.com wrote: I did a spot check.  There is one odd thing that

[gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread Eric Ayers
Was the intention to require all expressions to be put on a new line, or only when the dots are preceeded by whitespace? On Wed, Feb 9, 2011 at 10:48 AM, Ray Ryan rj...@google.com wrote: That's pretty bad. I'll tweak. Even if we can't have perfect builders we can at least wrap long lines

[gwt-contrib] Re: Sort the top level validator class to handle most specific classes first. (issue1346804)

2011-02-09 Thread rchandia
LGTM http://gwt-code-reviews.appspot.com/1346804/diff/1/5 File user/test/org/hibernate/jsr303/tck/tests/constraints/constraintcomposition/TckTestValidatorFactory.java (right): http://gwt-code-reviews.appspot.com/1346804/diff/1/5#newcode37

[gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread Ray Ryan
The intention was all but the first call on its own line, and was not very well thought out — I had builders on the brain. There is another option to have it wrap when it needs to, which we have turned off at the moment. I'll set it to that and do more spot checks. On Wed, Feb 9, 2011 at 7:56 AM,

[gwt-contrib] Re: Make UiBinder accept IsWidget subinterfaces properly (issue1295806)

2011-02-09 Thread Ray Ryan
On Wed, Feb 9, 2011 at 7:54 AM, jlaba...@google.com wrote: http://gwt-code-reviews.appspot.com/1295806/diff/1/10 File user/src/com/google/gwt/user/client/ui/HTMLTable.java (right): http://gwt-code-reviews.appspot.com/1295806/diff/1/10#newcode1105

[gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread rjrjr
http://gwt-code-reviews.appspot.com/1346803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread Ray Ryan
Okay, ready for re-review. Less ambitious now. Allows foo.bar().baz().bang().imagineManyOfThese(hi mom); to wrap as: foo.bar().baz().bang() .imagineManyOfThese(hi mom); instead of what happens now: foo.bar().baz().bang().imagineManyOfThese( hi mom); On Wed, Feb 9, 2011 at

[gwt-contrib] Re: - Use z-index to layer multiple notifications in hosted.html (issue1323801)

2011-02-09 Thread fredsa
http://gwt-code-reviews.appspot.com/1323801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix a NullPointerException in Editor framework when a null sub-Editor is encountered during trav... (issue1354802)

2011-02-09 Thread bobv
Reviewers: rjrjr, Description: Fix a NullPointerException in Editor framework when a null sub-Editor is encountered during traversal. Patch by: bobv Review by: rjrjr Please review this at http://gwt-code-reviews.appspot.com/1354802/show Affected files: M

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-02-09 Thread fredsa
http://gwt-code-reviews.appspot.com/1338804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Re: Follow on to svn r8671, which made the GWT code style allow whitespace (issue1346803)

2011-02-09 Thread John Tamplin
On Wed, Feb 9, 2011 at 2:25 PM, Ray Ryan rj...@google.com wrote: Okay, ready for re-review. Less ambitious now. Allows foo.bar().baz().bang().imagineManyOfThese(hi mom); to wrap as: foo.bar().baz().bang() .imagineManyOfThese(hi mom); instead of what happens now:

[gwt-contrib] Fixing a bug in DeckLayoutPanel where animating the current widget causes the current widget to ... (issue1354801)

2011-02-09 Thread pdr
LGTM http://gwt-code-reviews.appspot.com/1354801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-02-09 Thread bobv
LGTM Rietveld has my username as bobv. http://gwt-code-reviews.appspot.com/1338804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulat... (issue1338804)

2011-02-09 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1338804/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Untangle JSNI methods produced in CompilationStateBuilder to facilitate serialization. (issue1350801)

2011-02-09 Thread zundel
LGTM http://gwt-code-reviews.appspot.com/1350801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r9705 committed - Fix a NullPointerException in Editor framework when a null sub-Editor ...

2011-02-09 Thread codesite-noreply
Revision: 9705 Author: gwt.mirror...@gmail.com Date: Wed Feb 9 12:06:22 2011 Log: Fix a NullPointerException in Editor framework when a null sub-Editor is encountered during traversal. Patch by: bobv Review by: rjrjr Review at http://gwt-code-reviews.appspot.com/1354802

[gwt-contrib] [google-web-toolkit] r9706 committed - Fix TestUtil.PathImpl to correctly test for non matching...

2011-02-09 Thread codesite-noreply
Revision: 9706 Author: ncha...@google.com Date: Wed Feb 9 08:55:13 2011 Log: Fix TestUtil.PathImpl to correctly test for non matching RegExp groups. getGroup returns null or depending on the browser. [JSR 303 TCK Result] 93 of 257 (36.19%) Pass with 33 Failures and 14 Errors. Review at

[gwt-contrib] Re: Recompute whether an interface is dual-implemented by JSO and Java types after each compiler opt... (issue1351801)

2011-02-09 Thread Scott Blum
On Wed, Feb 9, 2011 at 3:36 PM, cromwell...@google.com wrote: It is strange, then again, it is strange that a JSO that is null can still be invoked. :) However, I think I've come back to sanity on rethinking this. Since it is only used for a single use case in my Json library (JsonNull), I

[gwt-contrib] Re: Remove a bunch of unused SOYC infrastructure. (issue1345801)

2011-02-09 Thread cromwellian
LGTM http://gwt-code-reviews.appspot.com/1345801/diff/2001/2004 File dev/core/src/com/google/gwt/core/ext/soyc/Member.java (left): http://gwt-code-reviews.appspot.com/1345801/diff/2001/2004#oldcode44 dev/core/src/com/google/gwt/core/ext/soyc/Member.java:44: Hypothetically, would the

[gwt-contrib] Simplify JArrayType handling; reduce serialization footprint. (issue1352803)

2011-02-09 Thread scottb
Reviewers: jbrosenberg, cromwellian, Please review this at http://gwt-code-reviews.appspot.com/1352803/show Affected files: M dev/core/src/com/google/gwt/dev/jjs/ast/JArrayType.java M dev/core/src/com/google/gwt/dev/jjs/ast/JProgram.java M

[gwt-contrib] Refactor SOYC to reduce memory footprint. (issue1352804)

2011-02-09 Thread scottb
Reviewers: cromwellian, Description: Before: correlations from parents get copied to every single child SourceInfoCorrelation, using lots of extra memory. After: SourceInfoCorrelations have parent pointers, and the list of correlations is computed on demand, saving a lot of memory. Other

[gwt-contrib] [google-web-toolkit] r9708 committed - Sort the top level validator class to handle most specific classes fir...

2011-02-09 Thread codesite-noreply
Revision: 9708 Author: gwt.mirror...@gmail.com Date: Wed Feb 9 13:27:07 2011 Log: Sort the top level validator class to handle most specific classes first. [JSR 303 TCK Result] 87 of 257 (33.85%) Pass with 39 Failures and 14 Errors. Review at http://gwt-code-reviews.appspot.com/1346804

[gwt-contrib] Re: Simplify JArrayType handling; reduce serialization footprint. (issue1352803)

2011-02-09 Thread cromwellian
LGTM. I don't its worth nuking the 'dims' field, I mean, feel free, but I'm ok with leaving it as a transient cache. http://gwt-code-reviews.appspot.com/1352803/diff/1/5 File dev/core/src/com/google/gwt/dev/jjs/impl/ArrayNormalizer.java (right):

[gwt-contrib] [google-web-toolkit] r9709 committed - Quick patch, in follow up to r9344, which replaces remaining uses of t...

2011-02-09 Thread codesite-noreply
Revision: 9709 Author: fre...@google.com Date: Wed Feb 9 11:45:33 2011 Log: Quick patch, in follow up to r9344, which replaces remaining uses of the legacy 'compiler.emulatedStack' property, with the corresponding 'compiler.stackMode'. Fixes issues: 5692 Review at

  1   2   >