[gwt-contrib] UiBinder. Parser for AbsolutePanel. (issue715802)

Reviewers: Ray Ryan, Please review this at http://gwt-code-reviews.appspot.com/715802/show Affected files: user/src/com/google/gwt/uibinder/elementparsers/AbsolutePanelParser.java user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java

[gwt-contrib] Re: Fixing WindowImplIE.getQueryString to look for the first occurence of a ? instead of the last. ... (issue709801)

committed as r8406 http://gwt-code-reviews.appspot.com/709801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UiBinder. Parser for AbsolutePanel. (issue715802)

Thanks! Looks great, just a couple of nits. http://gwt-code-reviews.appspot.com/715802/diff/1/3 File user/test/com/google/gwt/uibinder/elementparsers/AbsolutePanelParserTest.java (right): http://gwt-code-reviews.appspot.com/715802/diff/1/3#newcode37

[gwt-contrib] Re: Patch from Gustav Trede (gustav.tr...@gmail.com) (issue716801)

http://gwt-code-reviews.appspot.com/716801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Replacing Cell#consumesEvents() with Cell#getConsumedEvents(), and using the return value to sin... (issue707803)

committed as r8420 http://gwt-code-reviews.appspot.com/707803/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Patch from Gustav Trede (gustav.tr...@gmail.com) (issue716801)

http://gwt-code-reviews.appspot.com/716801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Phasing in a new, unified linker

On Mon, Jul 26, 2010 at 6:56 PM, John Tamplin j...@google.com wrote: Well, we do know there will be other linkers, and if there aren't extension points defined they will be done via cut-and-paste, which is what led to the current state we are in. No question that extension points are useful.

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

Hold off on this. I forgot to make the list on the left history aware, will update soon. On Mon, Jul 26, 2010 at 6:08 PM, rj...@google.com wrote: Reviewers: bobv, Description: Hard coded History integration for the Scaffold app. This is step zero in the search for a general, generatable

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

Okay, ready now. http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

Reviewers: scottb, conroy, fabbott, Description: - Refactors SpeedTracerLogger so that the start() and stop() methods are static - Adds a new addData() method to annotate the current event with more data. - Updates lists to use com.google.gwt.dev.util.collect.Lists; - Reduces visibility of

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

Nope, still buggy. Back and forth working but refresh messes up the master list on the top of the screen. http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Adds a class to log performance information in a format (issue707802)

Hi Scott, I implemented changes w/r/t your feedback: http://gwt-code-reviews.appspot.com/719801/show On Mon, Jul 26, 2010 at 11:33 AM, Scott Blum sco...@google.com wrote: On Fri, Jul 23, 2010 at 7:51 AM, zun...@google.com wrote: I agree that going back to static methods could save a little

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

LGTM w/ nits. http://gwt-code-reviews.appspot.com/719801/diff/1/12 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode62

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/diff/1/12 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode81 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:81: for (int

[gwt-contrib] Re: UiBinder. Parser for AbsolutePanel. (issue715802)

1. Should I remove groups only from this AbsolutePanelParser test or from DesignTimeUtilsTest too? 2. I agree to use sorting methods with tests, however as with formatting I have one problem. I would like to do this automatically, i.e. just configure this in Save Actions. And this means that

[gwt-contrib] More steps toward separate compilation. (issue702802)

Reviewers: scottb, Description: More steps toward separate compilation. Please review this at http://gwt-code-reviews.appspot.com/702802/show Affected files: M dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java M dev/core/src/com/google/gwt/dev/jdt/BasicWebModeCompiler.java M

[gwt-contrib] Re: More steps toward separate compilation. (issue702802)

LGTM http://gwt-code-reviews.appspot.com/702802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/diff/1/12 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/1/12#newcode62 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:62:

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/diff/5001/6011 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode133

[gwt-contrib] Re: UiBinder. Parser for AbsolutePanel. (issue715802)

On Tue, Jul 27, 2010 at 1:38 PM, konstantin.scheg...@gmail.com wrote: 1. Should I remove groups only from this AbsolutePanelParser test or from DesignTimeUtilsTest too? I guess you might as well do DesignTimeUtilsTest at the same time. Thanks. 2. I agree to use sorting methods with tests,

[gwt-contrib] Adding support for non-propagating events in Cell based widgets. In modern browsers, we make the... (issue720801)

Reviewers: Ray Ryan, Description: Adding support for non-propagating events in Cell based widgets. In modern browsers, we make the widget's outer element the capture element, which allows us to catch and dispatch non-bubbling events from the cells. In IE, we use onfocusin/onfocusout (which

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

Updated patch. http://gwt-code-reviews.appspot.com/719801/diff/5001/6011 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode133

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

On 2010/07/27 22:36:22, zundel wrote: Updated patch. http://gwt-code-reviews.appspot.com/719801/diff/5001/6011 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode133

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/diff/5001/6011 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode72 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:72:

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/diff/5001/6011 File dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java (right): http://gwt-code-reviews.appspot.com/719801/diff/5001/6011#newcode72 dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:72:

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

LGTM then http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] GRIN scene graph for GWT

Hi, GWT-GRIN is a very simple scene graph framework for GWT. It is based on: https://hdcookbook.dev.java.net/grin.html GWT-GRIN is using a GWT generator to parse the GRIN show file. The scripting language for a GTW-GRIN show file is Java. Demo1 (shows translator and fade show features in

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Hard coded History integration for the Scaffold app. This is step zero (issue717801)

No longer buggy, but I think also not to be committed. Bob, don't mind this. On Tue, Jul 27, 2010 at 5:18 PM, rj...@google.com wrote: http://gwt-code-reviews.appspot.com/717801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] GRIN scene graph for GWT

Interesting can you make an official ready to go d/l available so we can skip the checkout and build step. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: GRIN scene graph for GWT

OK, I will prepare a first release at the end of this week. On 28 Ιούλ, 03:45, Miroslav Pokorny miroslav.poko...@gmail.com wrote: Interesting can you make an official ready to go d/l available so we can skip the checkout and build step. --

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: - Refactors SpeedTracerLogger so that the start() and stop() methods are static (issue719801)

Consider this alternative to remove the null check http://gwt-code-reviews.appspot.com/719801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors