On Tue, Jun 7, 2011 at 1:32 AM, Christoph Kern x...@google.com wrote:
It turns out it was easier to fix the specific case this broke in client
code (a test that ended up passing null for a URL).
Which raises the question, should Image gracefully handle null for URLs,
or should the API docs
Earn $1000-$2500 per month
If you Register your name
You Get Sign-up bonus $5
AND
Get $.20 cent for each referral.
Further details
http://www.earnbyforex.com/index.php?id=35678365
Since IsWidget is a first class interface, what is the use case to use
Composite instead of simply implement IsWidget?
Thanks in advance.
- Andrés
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM - and much nicer
We should note the breaking change to former subclasses of
ResizeComposite in the release notes. It probably won't affect anyone,
but you never know.
Reviewers: hermes, rjrjr,
Description:
Adds setTagName to PotentialElement, so that PotentialElement instances
can be passed to the as() method of Element subclasses (it's nicer than
blindly calling .cast(), I think). Let me know if this looks clearner to
you guys.
Please review this at
On 2011/06/07 15:08:26, rdcastro wrote:
Should you put this on an overload of build instead, and make the single
arg version default to span or div?
http://gwt-code-reviews.appspot.com/1451810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10287
Author: jlaba...@google.com
Date: Tue Jun 7 05:10:39 2011
Log: Adding a hook in the servlet build file that can be replaced by
scripts.
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10287
Modified:
In general we try to be null-intolerant, although I don't know how
consistent we are about it. Basically, nulls should never be quietly cleaned
up for you but rather should fail fast if practical. If null is a legal
value, it should serve a specific purpose.
On Tue, Jun 7, 2011 at 12:44 AM,
That is an excellent question.
I don't think anyone has yet tried to go that route in earnest, and I
suspect the first to do so will find that IsWidget is not yet as first class
as it should be, just due to undiscovered corner cases and such. But it sure
would be interesting to try to make it
http://gwt-code-reviews.appspot.com/1453807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Makes sense, will update the code.
On Tue, Jun 7, 2011 at 12:42 PM, rj...@google.com wrote:
On 2011/06/07 15:08:26, rdcastro wrote:
Should you put this on an overload of build instead, and make the single
arg version default to span or div?
http://gwt-code-reviews.appspot.com/1451810/
--
http://gwt-code-reviews.appspot.com/1453807/diff/1/samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
File
samples/mobilewebapp/src/main/java/com/google/gwt/sample/mobilewebapp/client/desktop/MobileWebAppShellDesktop.java
(right):
LGTM
http://gwt-code-reviews.appspot.com/1453807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Although in this specific case, the method in question is deprecated and
only there for legacy support. I think its okay to do the null check in
that case if needed.
On 2011/06/07 16:00:48, rjrjr wrote:
In general we try to be null-intolerant, although I don't know how
consistent we are about
Nope, and I reject several spammers daily. On the GWT group, some have
gotten smarter and are now posting legit-sounding messages in advance.
/dmc
On Tue, Jun 7, 2011 at 4:49 AM, roseanje...@rediffmail.com
roseanje...@rediffmail.com wrote:
Earn $1000-$2500 per month
If you Register your name
Thomas, here's a patch that adds a test case to repro the bug (also changing
uses of fromTrustedString to fromSafeConstant where appropriate).
Would you be able to look into rewriting the regex? My best guess is that
it's falling afoul of
http://gwt-code-reviews.appspot.com/1451810/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
And I, for one, appreciate the effort that goes into moderation!
On that slightly off-topic note, I interact with the group via GMail 99.999%
of the time, rather than the Groups UI. Does reporting spam messages in
GMail translate to Groups at all? Or to put another way, GMail is smart
enough to
http://gwt-code-reviews.appspot.com/1447815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Tue, Jun 7, 2011 at 09:19, jlaba...@google.com wrote:
Although in this specific case, the method in question is deprecated and
only there for legacy support. I think its okay to do the null check in
that case if needed.
There were only a few callers that failed due to passing in nulls
To verify that the annotation processor is working in Eclipse, open up
the Error Log view. You should see diagnostic messages from the
processor. I'll turn those off before final submission. Since this
patch updates the gwt-user project, you might need to shut Eclipse down
first before
http://gwt-code-reviews.appspot.com/1453807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Can you take one more look? Some mocked out tests choked on the move to
IsWidget.
I'd like to hunt those down and fix them, but don't want to gate the API
change on it.
You okay with this instanceof check in the mean time?
http://gwt-code-reviews.appspot.com/1453807/
--
On 2011/06/07 17:46:29, rjrjr wrote:
Can you take one more look? Some mocked out tests choked on the move
to
IsWidget.
I'd like to hunt those down and fix them, but don't want to gate the
API change
on it.
You okay with this instanceof check in the mean time?
LGTM
Seems harmless enough.
http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
On 2011/06/07 16:34:24, xtof wrote:
Thomas, here's a patch that adds a test case to repro the bug (also
changing
uses of fromTrustedString to fromSafeConstant where appropriate).
Would you be able to look into rewriting the regex? My best guess is
that
it's falling afoul of
Reviewers: rdayal,
Description:
Adds support for runtime evaluation of JavaScriptObject methods from a
debugger. Primarily intended as support API for debuggers, but
developers can also use it directly in a debugger (for example, in watch
windows or breakpoint expressions).
Review by:
Revision: 10288
Author: b...@google.com
Date: Tue Jun 7 06:01:17 2011
Log: Support is/has methods in Editor framework.
Issue 6040.
Patch by: bobv
Review by: rjrjr
Review at http://gwt-code-reviews.appspot.com/1443812
http://code.google.com/p/google-web-toolkit/source/detail?r=10288
Revision: 10286
Author: jbrosenb...@google.com
Date: Tue Jun 7 04:42:44 2011
Log: Add concrete SourceInfo for varargs in method calls
Review at http://gwt-code-reviews.appspot.com/1454801
http://code.google.com/p/google-web-toolkit/source/detail?r=10286
Modified:
Revision: 10289
Author: rj...@google.com
Date: Tue Jun 7 08:14:59 2011
Log: Add missing steps to samples/mobilewebapp maven directions
http://code.google.com/p/google-web-toolkit/source/detail?r=10289
Modified:
/trunk/samples/mobilewebapp/README-MAVEN.txt
Updated patch.
http://gwt-code-reviews.appspot.com/1455801/diff/1/dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
(right):
Reviewers: tobyr,
Description:
Minor changes to dashboard notifier interface to enable better
session-tracking
in notifier implementation. Also added some stuff to
...dev.shell.BrowserChannelServerTest to verify that the integration
with the
dashboard is behaving correctly.
Review by:
lgtm
http://gwt-code-reviews.appspot.com/1455801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10290
Author: rj...@google.com
Date: Tue Jun 7 09:30:28 2011
Log: Extracts AbstractCompositeW out of Composite, to allow type safe
calls to gwtWidget(). Deprecates ResizeComposite and replaces it with
RequiresResizeComposite, which moves the must implement
RequireResize
Updated patch, fixes a failing test. I think this is G2G now.
http://gwt-code-reviews.appspot.com/1455801/diff/4002/dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java
File dev/core/src/com/google/gwt/dev/jjs/impl/SourceInfoCorrelator.java
(right):
still LGTM
http://gwt-code-reviews.appspot.com/1455801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
No good, broke various other tests. I'm rolling it back.
On 2011/06/07 17:51:19, jlabanca wrote:
On 2011/06/07 17:46:29, rjrjr wrote:
Can you take one more look? Some mocked out tests choked on the move
to
IsWidget.
I'd like to hunt those down and fix them, but don't want to gate the
API
http://gwt-code-reviews.appspot.com/1453804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1453804/diff/1017/dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java
File dev/core/src/com/google/gwt/dev/jdt/AbstractCompiler.java (right):
Revision: 10291
Author: gwt.mirror...@gmail.com
Date: Tue Jun 7 14:17:17 2011
Log: UnifyAst works with SOYC.
When building serialized ASTs with GwtAstBuilder, we never create
SourceInfoCorrelation nodes, because the same serialized ASTs are later
used both with and without SOYC
Revision: 10292
Author: rj...@google.com
Date: Tue Jun 7 11:13:59 2011
Log: Revert Extracts AbstractCompositeW out of Composite, to allow
type safe
Various mocked out tests broken.
This reverts r10290
http://code.google.com/p/google-web-toolkit/source/detail?r=10292
Deleted:
LGTM
http://gwt-code-reviews.appspot.com/1450812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1453804/diff/1017/dev/core/test/com/google/gwt/lang/LongLibTestBase.java
File dev/core/test/com/google/gwt/lang/LongLibTestBase.java (right):
Reviewers: hermes, rjrjr,
Description:
Merges RenderableComposite into Composite. Version that adds a
setResolver method to PotentialElement.
Please review this at http://gwt-code-reviews.appspot.com/1449813/
Affected files:
M user/src/com/google/gwt/user/client/ui/Composite.java
M
On 2011/06/07 22:14:16, rdcastro wrote:
LGTM
http://gwt-code-reviews.appspot.com/1449813/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/06/07 22:05:56, fredsa wrote:
Tell me more... this is not new - the xsiframe linker does this and we
haven't heard of any problems there...
http://gwt-code-reviews.appspot.com/1454802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
ok - I'm dumb - the file that xsiframe linker is setting the contents of
the script tag and then removing it. This code sets the src of the
script tag. Probably not a good idea to remove it before the contents
come back :-)
Thanks!!
- Unnur
On 2011/06/07 22:38:26, unnurg wrote:
On
On Tue, Jun 7, 2011 at 6:13 PM, sco...@google.com wrote:
http://gwt-code-reviews.appspot.com/1453804/diff/1017/dev/core/test/com/google/gwt/lang/LongLibTestBase.java
File dev/core/test/com/google/gwt/lang/LongLibTestBase.java (right):
Revision: 10293
Author: fre...@google.com
Date: Tue Jun 7 16:34:48 2011
Log: DirectInstallLinker should not immediately remove the script tag
it has inserted into the IFRAME as this can fail in Webkit browsers
Review at http://gwt-code-reviews.appspot.com/1454802
Review by:
LGTM
http://gwt-code-reviews.appspot.com/1443802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/06/08 02:25:30, zundel wrote:
On Tue, Jun 7, 2011 at 6:13 PM, mailto:sco...@google.com wrote:
http://gwt-code-reviews.appspot.com/1453804/diff/1017/dev/core/test/com/google/gwt/lang/LongLibTestBase.java
File dev/core/test/com/google/gwt/lang/LongLibTestBase.java (right):
Earn $1000-$2500 per month
If you Register your name
You Get Sign-up bonus $5
AND
Get $.20 cent for each referral.
Further details
http://www.earnbyforex.com/index.php?id=35678365
LGTM w/nits (which you can ignore)
http://gwt-code-reviews.appspot.com/1453804/diff/1017/user/super/com/google/gwt/emul/java/lang/Object.java
File user/super/com/google/gwt/emul/java/lang/Object.java (right):
53 matches
Mail list logo
