[gwt-contrib] Speed up escapeXml methods

Reviewers: kprobst, Description: Convert \['] into their XML equivalents without using the (very slow) String.replaceAll method. Please review this at http://gwt-code-reviews.appspot.com/34814 Affected files: dev/core/src/com/google/gwt/core/ext/soyc/impl/StoryRecorderImpl.java

[gwt-contrib] Speedups for -soyc compilation

Reviewers: spoon, kprobst, scottb, Description: This patch incorporates Kathrin's StringBuilder work along with other miscellaneous speedups found by using JProfiler. Please review this at http://gwt-code-reviews.appspot.com/34818 Affected files:

[gwt-contrib] Fix issue 3677: gwt-module.dtd does not reflect changes to configuration properties

Reviewers: bobv, Please review this at http://gwt-code-reviews.appspot.com/34819 Affected files: distro-source/core/src/gwt-module.dtd Index: distro-source/core/src/gwt-module.dtd === ---

[gwt-contrib] Speed up JsInliner.InliningVisitor.endVisit()

Reviewers: bobv, Description: Currently JsInliner.InliningVisitor.endVisit() tries a sequence of identifiers of the form A_B_number until it finds one that has not been used in the given scope. Profiling indicates that this loop may execute hundreds of times for a given name, accounting for a

[gwt-contrib] Restore some convenience constructors

Reviewers: scottb, Description: Restore public convenience constructors in JConstructor, JMethod, and JParameter (over-zealously removed in r5410) that turn out to be used by third-party code. Please review this at http://gwt-code-reviews.appspot.com/34826 Affected files:

[gwt-contrib] Fix checkstyle violation

Reviewers: bobv, Please review this at http://gwt-code-reviews.appspot.com/33839 Affected files: dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java Index: dev/core/src/com/google/gwt/core/ext/soyc/impl/StandardClassMember.java

[gwt-contrib] Speed up compilation by rewriting for loops to avoid iterators

Reviewers: Lex, scottb, Description: Rewrite loops of the form: ListT args; for (T arg : args) { } to use an explicit index. This cuts loop overhead by avoiding the need to instantiate an Iterator object. This speeds up a 6-permutation Showcase compile (with -soyc and -style PRETTY) by about

[gwt-contrib] Menu doesn't close when escape is pressed

Reviewers: jlabanca, Description: When a menu is opened, but not entered, pressing escape fails to close the menu because the popup does not yet have focus. Check for this case and manually close the popup. Please review this at http://gwt-code-reviews.appspot.com/33842 Affected files:

[gwt-contrib] Re: SOYC gives drill-down on size for leftover and exclusive fragments

http://gwt-code-reviews.appspot.com/33843/diff/1/3 File tools/soyc-vis/src/com/google/gwt/soyc/SoycDashboard.java (left): http://gwt-code-reviews.appspot.com/33843/diff/1/3#oldcode174 Line 174: return unescaped; This method looks fishy to me. The first argument to String.replaceAll is a regex,

[gwt-contrib] Re: RR : Make ClientBundle and CssResource generators faster

LGTM http://gwt-code-reviews.appspot.com/40804/diff/1/5 File user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java (right): http://gwt-code-reviews.appspot.com/40804/diff/1/5#newcode43 Line 43: private static final MapTypeOracle, MapString, Object CACHES = new

[gwt-contrib] Allow detached JDO objects to be transferred via RPC

Reviewers: bobvawter_google.com, Description: Attempting to transfer objects marked as @PersistenceCapable(detachable=true) via RPC currently fails due to mismatched class bytecode between the server and client. This patch detects such objects and manually serializes the extra information

[gwt-contrib] Re: Allow detached JDO objects to be transferred via RPC

http://gwt-code-reviews.appspot.com/47807/diff/1/9 File user/src/com/google/gwt/user/client/rpc/WeakMapping.java (right): http://gwt-code-reviews.appspot.com/47807/diff/1/9#newcode31 Line 31: public static Object get(Object instance, String key) { I'm not sure what can be said about the

[gwt-contrib] Fix a couple of tiny checkstyle problems in dev

Reviewers: scottb, Please review this at http://gwt-code-reviews.appspot.com/50805 Affected files: dev/core/src/com/google/gwt/core/ext/SelectionProperty.java dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java Index: dev/core/src/com/google/gwt/dev/jjs/ast/JMethod.java

[gwt-contrib] Re: NewParenthesisRemovalOptimization

http://gwt-code-reviews.appspot.com/47808/diff/1/2 File dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java (right): http://gwt-code-reviews.appspot.com/47808/diff/1/2#newcode587 Line 587: // replaced with new Constructor with no parenthesis parentheses (plural)

[gwt-contrib] Fix issue 3756: getRel() and setRel() in AnchorElement access the wrong JavaScript property

Reviewers: jgw, Please review this at http://gwt-code-reviews.appspot.com/47818 Affected files: user/src/com/google/gwt/dom/client/AnchorElement.java Index: user/src/com/google/gwt/dom/client/AnchorElement.java === ---

[gwt-contrib] Fix issue 3353: java.util.LinkedHashMap cannot deserialize because of broken custom serializer.

Reviewers: robertvawter_google.com, Please review this at http://gwt-code-reviews.appspot.com/47819 Affected files: user/src/com/google/gwt/user/client/rpc/core/java/util/LinkedHashMap_CustomFieldSerializer.java Index:

[gwt-contrib] Re: Fix issue 3353: java.util.LinkedHash Map cannot deserialize because of broken custom serializer.

Please ignore this patch, it is incorrect. http://gwt-code-reviews.appspot.com/47819 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: RR : Emulate JS stack traces (phase 1)

http://gwt-code-reviews.appspot.com/47816/diff/1/5 File dev/core/src/com/google/gwt/dev/js/JsStackEmulator.java (right): http://gwt-code-reviews.appspot.com/47816/diff/1/5#newcode174 Line 174: * exitingEarly $stackDepeth = stackIndex - 1; There's a typo here: stackDep_e_th On 2009/07/22

[gwt-contrib] Generalized RPC for server-enhanced objects

Reviewers: robertvawter_google.com, scottb, Description: This patch removes the previous special-case handling of JDO objects in favor of a more general approach. First we determine which classes may be enhanced, based on annotations in the classes themselves or a new rpc.enhancedClasses

[gwt-contrib] Fix issue 3815 - LinkedHashMap RPC serialization error in AppEngine

Reviewers: bobv, Description: LinkedHashMap_CustomFieldSerializer currently uses reflection to access a private field, which fails in AppEngine. This patch provides a (possibly slower) alternative approach that does not require reflection, which is used as a fallback when reflection fails.

[gwt-contrib] Fix issue 3623: The unmodifiable collect ions are missing .toString()

Reviewers: jat, Please review this at http://gwt-code-reviews.appspot.com/55801 Affected files: user/super/com/google/gwt/emul/java/util/Collections.java Index: user/super/com/google/gwt/emul/java/util/Collections.java ===

[gwt-contrib] Fix issue 3623: The unmodifiable collect ions are missing .toString()

Reviewers: jat, Description: Add a toString() method to UnmodifiableCollection that just passes through to the underlying collection. This matches the Sun JRE behavior. Please review this at http://gwt-code-reviews.appspot.com/55802 Affected files:

[gwt-contrib] Update release notes for 1.7.1 release

Reviewers: knorton, Description: Update the release notes Please review this at http://gwt-code-reviews.appspot.com/66807 Affected files: distro-source/core/src/release_notes.html Index: distro-source/core/src/release_notes.html

[gwt-contrib] On Mac, emit a -d32 arg for hosted mode when running on a 64-bit vm

Reviewers: scottb, jat, Please review this at http://gwt-code-reviews.appspot.com/68803 Affected files: user/src/com/google/gwt/user/tools/WebAppCreator.java user/src/com/google/gwt/user/tools/project.ant.xmlsrc Index: user/src/com/google/gwt/user/tools/project.ant.xmlsrc

[gwt-contrib] Move check for 32-bit VM from HostedModeBase to SwtHostedModeBase

Reviewers: jat, Description: Currently the check for a 32-bit VM never gets run on Linux. This CL moves it into SwtHostedModeBase where it can run for all platforms. Please review this at http://gwt-code-reviews.appspot.com/68806 Affected files:

[gwt-contrib] Add a 'session' field to lightweight metrics events

Reviewers: jat, Description: In some enviromnents we are seeing what appear to be stale RPC metrics following a browser refresh. This patch reads a user-defined variable __gwtStatsSessionId at module startup, and copies it into a GWT variable $session. Each time a lightweight stats event is

[gwt-contrib] Ignore @GwtTransient fields in SerializabilityUtil

Reviewers: Lex, bobv, Please review this at http://gwt-code-reviews.appspot.com/84801 Affected files: user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java Index: user/src/com/google/gwt/user/server/rpc/impl/SerializabilityUtil.java

[gwt-contrib] Fix sundry warnings

Reviewers: jat, Ray Ryan, Lex, scottb, Description: Fix some cases of the following classes of warnings: 1) (Obviously correctly) unused variables 2) Redundant interface inheritance 3) Redundant null checks 4) Redundant casts 5) Hidden variables 6) Deprecation 6) (Only in HandlerClassInfo.java)

[gwt-contrib] Re: Fix sundry warnings

http://gwt-code-reviews.appspot.com/86801/diff/1/11 File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java (left): http://gwt-code-reviews.appspot.com/86801/diff/1/11#oldcode558 Line 558: + intfMethod.toString(); On 2009/10/24 01:08:05, Ray Ryan wrote: Why is it okay to delete

[gwt-contrib] Remove unused imports in two tests

Reviewers: jlabanca, Please review this at http://gwt-code-reviews.appspot.com/88806 Affected files: dev/core/test/com/google/gwt/core/ext/typeinfo/test/PrimitiveValuesAnnotation.java user/test/org/apache/commons/collections/TestMap.java Index:

[gwt-contrib] Fix javadoc link errors

Reviewers: scottb, Please review this at http://gwt-code-reviews.appspot.com/89801 Affected files: dev/core/src/com/google/gwt/core/linker/SingleScriptLinker.java doc/build.xml user/src/com/google/gwt/resources/ext/ResourceContext.java

[gwt-contrib] Re: Fix javadoc link errors

http://gwt-code-reviews.appspot.com/89801/diff/1/7 File user/src/com/google/gwt/user/client/ui/LayoutPanel.java (right): http://gwt-code-reviews.appspot.com/89801/diff/1/7#newcode23 Line 23: * A panel that lays its children out in arbitrary {...@link com.google.gwt.layout.client.Layout.Layer

[gwt-contrib] Generate real erros instead of ArrayIndexOOBs in UiBinderWriter

Reviewers: Ray Ryan, Please review this at http://gwt-code-reviews.appspot.com/88809 Affected files: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java Index: user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java

[gwt-contrib] Add a -standardsMode flag to JUnitShell and a new ant target 'test.standards'

Reviewers: jlabanca, Please review this at http://gwt-code-reviews.appspot.com/89803 Affected files: user/build.xml user/src/com/google/gwt/junit/JUnitShell.java user/src/com/google/gwt/junit/public/junit-standards.html

[gwt-contrib] Fix a daylight saving bug

Reviewers: jlabanca, jat, Description: Calling new Date(...) with a time that falls in the 'missing hour' of a daylight savings time transition currently behaves differently in java versus javascript. In java, the time is moved forward by an hour, while in javascript it is moved backward, which

[gwt-contrib] Update the error message when a module requires compilation

Reviewers: jat, Description: The old message references the Compile/Browse button in hosted mode. Please review this at http://gwt-code-reviews.appspot.com/89811 Affected files: dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java Index:

[gwt-contrib] Fix some checkstyle warnings

Reviewers: Ray Ryan, Please review this at http://gwt-code-reviews.appspot.com/89816 Affected files: user/src/com/google/gwt/uibinder/client/UiBinderUtil.java user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java user/src/com/google/gwt/uibinder/rebind/XMLElement.java Index:

[gwt-contrib] Re: Centralize a few standard MockJavaResources

LGTM http://gwt-code-reviews.appspot.com/93810/diff/1/2 File dev/core/test/com/google/gwt/dev/javac/impl/JavaResourceBase.java (right): http://gwt-code-reviews.appspot.com/93810/diff/1/2#newcode200 Line 200: JAVASCRIPTOBJECT, MAP, OBJECT, SERIALIZABLE, STRING, SUPPRESS_WARNINGS, I assume FOO

[gwt-contrib] Improve NumberFormat.format to avoid weird rounding issues

Reviewers: bobv, Description: External issue 4171 points out that: NumberFormat.getFormat(#,##0.##).format(30.555) should yield 30.56 but yields 30.55 instead. This is due to the fact that the fractional part of 30.555 (computed as x - Math.floor(x)) formats as 0.554999... and adding 0.5

[gwt-contrib] Re: Fix issue 4175

LGTM http://gwt-code-reviews.appspot.com/100802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Ensure consistency for RPC of enhanced objects

Reviewers: jat, Description: External issue 4140 points out a bug in how we serialize enhanced objects. In this case, the .gwt.rpc files end up inconsistent with one another -- one contains the @ClientFields annotation but the other does not. This results in the generated field deserializer

[gwt-contrib] Re: Fix handling of real arg names in generic methods

LGTM http://gwt-code-reviews.appspot.com/100806 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix Issue 4045: cannot start in Turkish locale

Reviewers: jat, Description: Ensure all calls to String.to{Lower,Upper}Case in the dev packages specify the English locale, so that Turkish users don't experience 'I' mapping to dotless small 'i'. We also avoid calls to Character.to{Lower,Upper}Case since they do not specify the locale. There's

[gwt-contrib] Ensure server info from superclasses doesn't stomp on subclass info

Reviewers: bobv, Description: This fixes external issue 3969 (http://code.google.com/p/google-web-toolkit/issues/detail?id=3969). When a class with superclasses was being serialized, the extra info for the superclass and the subclass were being stored in the same place using WeakMapping. The

[gwt-contrib] Re: Ensure server info from superclasses doesn't stomp on subclass info

On 2009/11/13 22:01:40, Dan Rice wrote: Ignore the spurious import of Serializable, it's gone now. http://gwt-code-reviews.appspot.com/102817 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Fix bug formatting milliseconds for pre-1970 dates

Reviewers: jat, Description: From external GWT issue 4216: - System.out.println(DateTimeFormat.getFormat(SS).format(new Date(-631151998945))) displays 0-93 instead of the expected 05 or 06. That time is 1.055 seconds after midnight January 1, 1950. - Please review this at

[gwt-contrib] Fix error starting up in DevMode+GAE

Reviewers: jat, scottb, Description: If a GC occurs during startup, the AbstractReferenceMap that maps from the module name to its ModuleDef in ModuleDefLoader can be cleared. When we attempt to reload the module, we cannot because we only have the module's effective name (i.e., a short,

[gwt-contrib] Re: Improve NumberFormat.format to avoid weird rounding issues

ping http://gwt-code-reviews.appspot.com/97812 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

http://gwt-code-reviews.appspot.com/118802/diff/1/3 File user/src/com/google/gwt/user/server/rpc/impl/ServerSerializationStreamReader.java (right): http://gwt-code-reviews.appspot.com/118802/diff/1/3#newcode819 Line 819: return new NumberFormatException(Expected type ' + type + ' but received +

[gwt-contrib] Re: Provide better exceptions for bad values in an RPC stream (not for 2.0)

the failure occurred, but that would require more thought. On 2009/12/02 20:31:49, jat wrote: On 2009/12/02 20:25:39, Dan Rice wrote: It's a subclass of IllegalArgumentException, which gets wrapped in a SerializationException

[gwt-contrib] Re: Remove excess calls to foreign collections

http://gwt-code-reviews.appspot.com/118810/diff/1/3 File user/super/com/google/gwt/emul/java/util/ArrayList.java (right): http://gwt-code-reviews.appspot.com/118810/diff/1/3#newcode110 Line 110: Object[] cArray = c.toArray(); if (cArray.length == 0) { return false; }

[gwt-contrib] Remove a Java 1.6-ism

Reviewers: Lex, Description: String.isEmpty does not exist prior to Java 1.6 Please review this at http://gwt-code-reviews.appspot.com/118811 Affected files: user/test/com/google/gwt/user/client/rpc/RemoteServiceServletTest.java Index:

[gwt-contrib] Re: Remove excess calls to foreign collections

LGTM http://gwt-code-reviews.appspot.com/118810 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Improve NumberFormat

Reviewers: jat, Description: This passes all tests but could probably be made a bit clearer. Please review this at http://gwt-code-reviews.appspot.com/126807 Affected files: user/src/com/google/gwt/i18n/client/NumberFormat.java

[gwt-contrib] Call servlet.log(message) instead of servlet.log(message, (Throwable) null)

Reviewers: bobv, Description: Some servlet containers throw an NPE on servlet.log(message, (Throwable) null) Since the spec doesn't really say what should happen in this case, we should call servlet.log(message) instead, just to be safe. Please review this at

[gwt-contrib] RFE - Issue 3906: Overload GWT.log with a single String arg

Reviewers: jat, Please review this at http://gwt-code-reviews.appspot.com/126810 Affected files: user/src/com/google/gwt/core/client/GWT.java Index: user/src/com/google/gwt/core/client/GWT.java === ---

[gwt-contrib] Use log(...) instead of log(..., null) for GWT and servlet logs (not TreeLogger)

Reviewers: jat, Please review this at http://gwt-code-reviews.appspot.com/126816 Affected files: user/javadoc/com/google/gwt/examples/DateTimeFormatExample.java user/javadoc/com/google/gwt/examples/NumberFormatExample.java user/src/com/google/gwt/core/client/GWT.java

[gwt-contrib] Make java.sql.Timestamp.valueOf() emulation more lenient

Reviewers: jat, Description: To behave more like the JRE, TimeStamp.valueOf() should accept strings without a nanoseconds part. Also, if the nanoseconds part has fewer than 9 digits it should be implicitly right-padded with zeros. Please review this at

[gwt-contrib] Improve inlining by adding String.equals(String) to the JRE emulation

Reviewers: jat, Description: Add String.equals(String) to the String emulation code. Compiled output of Showcase shows that the method is nicely optimized to a == b rather than requiring an instanceof check and a function call. Of course it would be nicer for the compiler to figure this out but

[gwt-contrib] Ensure .split(,) returns { }

Reviewers: jlabanca, Please review this at http://gwt-code-reviews.appspot.com/126821 Affected files: user/super/com/google/gwt/emul/java/lang/String.java user/test/com/google/gwt/emultest/java/lang/StringTest.java Index: user/super/com/google/gwt/emul/java/lang/String.java

[gwt-contrib] Fix issue 4425 - bad escaping when converting strings from Java to JS

Reviewers: jat, Description: We were escaping \u000 as \0 when converting from Java to JavaScript -- however, this fails when the next character is a digit since that digit will be interpreted as part of the escape sequence. For example, \u6 is turned into \06, which is a one-character

[gwt-contrib] Re: Fix issue 4425 - bad escaping when converting strings from Java to JS

http://gwt-code-reviews.appspot.com/128804/diff/1/3 File dev/core/src/com/google/gwt/dev/js/JsToStringGenerationVisitor.java (right): http://gwt-code-reviews.appspot.com/128804/diff/1/3#newcode1352 Line 1352: result.append(\\x); It works on OSX/{Safari,Firefox,Chrome} and Windows/{IE7,Firefox}.

[gwt-contrib] Re: Provide better error messages for incorrect -runStyle argument

LGTM I'm trying to think if this will encounter a problem in the Turkish locale but I think it should be O.K. http://gwt-code-reviews.appspot.com/130804 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Implement java.util.Random - avoid use of longs where possible

Reviewers: scottb, Description: This is based on Harmony code (with Richard Zschech's gwt-java-math changes). I also made some improvements: 1) avoid use of longs where possible -- the common cases should all be int/double only 2) fix a minor bug in nextGaussian when the random variables are

[gwt-contrib] Re: Fix JsonP handling of with multiple modules

This makes sense to me, although instead of passing in a counter/counterName argument I would just hardwire these methods to use CALLBACKS_COUNTER_NAME. On 2010/01/25 15:51:50, jcarlson wrote: Is it necessary for the global jsonp counter to be it's own top-level variable, or wouldn't it be

[gwt-contrib] Re: Fix JsonP handling of with multiple modules

See comment. http://gwt-code-reviews.appspot.com/130820 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: RR : Remove duplicate property setters from deRPC payload

LGTM http://gwt-code-reviews.appspot.com/130825 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Make java.util.Collections.Empty{List,Map,Set} work with GWT RPC

Reviewers: jat, Please review this at http://gwt-code-reviews.appspot.com/146801 Affected files: user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java user/super/com/google/gwt/emul/java/util/Collections.java --

[gwt-contrib] Re: Fix for issue 4595: In TabLayoutPanel, inserting a tab before the currently

LGTM http://gwt-code-reviews.appspot.com/153816 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fix to keep FocusWidget's setElement() implementation from clobbering

LGTM http://gwt-code-reviews.appspot.com/153815 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add side-by-side trees to the bikeshed

Reviewers: jlabanca, Description: Add side-by-side trees to the bikeshed Review by: jlaba...@google.com Please review this at http://gwt-code-reviews.appspot.com/160802 Affected files: M bikeshed/src/com/google/gwt/bikeshed/sample/stocks/client/StockSample.java M

[gwt-contrib] Re: Remove caching of style sheets in IE6 (cache may be invalid when there are multiple modules)

I added a new patch that caches the lengths but not the actual style sheet contents. In the worst case, if the lengths are wrong we will just append in a suboptimal way, but not lose any data. Benchmarking shows that the performance difference is minor -- still just 2-3 ms per injection in my

[gwt-contrib] Re: Reimplement java.util.Date in Java

LGTM with nits. Thanks for doing this! http://gwt-code-reviews.appspot.com/181801/diff/1/2 File user/super/com/google/gwt/emul/java/util/Date.java (right): http://gwt-code-reviews.appspot.com/181801/diff/1/2#newcode285 Line 285: return (int) (time ^ (getTime() 32)); 'getTime()' can be

[gwt-contrib] Re: Reimplement java.util.Date in Java

LGTM http://gwt-code-reviews.appspot.com/181801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Add build.xml file with checkstyle target; pass checkstyle

Reviewers: Ray Ryan, Description: Add build.xml file with checkstyle target; pass checkstyle Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/218801 Affected files: M bikeshed/build.xml M

[gwt-contrib] Re: DOMImpl#eventGetTypeInt returns NULL for unknown event types

LGTM http://gwt-code-reviews.appspot.com/222801 -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Reduce warnings in Eclipse:

Reviewers: jat, Description: Reduce warnings in Eclipse: o Use ? instead of raw types o Add some @SuppressWarnings annotations o Document or remove unused method parameters Please review this at http://gwt-code-reviews.appspot.com/219803 Affected files: M

[gwt-contrib] Add 'view data' to cell, column, and updater classes. (issue248801)

Reviewers: jgw, Description: Add 'view data' to cell, column, and updater classes. Make the Validation example work with view data. Please review this at http://gwt-code-reviews.appspot.com/248801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/cells/client/ButtonCell.java M

[gwt-contrib] Checkstyle fixes (issue249801)

Reviewers: Ray Ryan, Description: Checkstyle fixes Please review this at http://gwt-code-reviews.appspot.com/249801/show Affected files: M bikeshed/src/com/google/gwt/sample/expenses/client/EmployeeList.java M bikeshed/src/com/google/gwt/sample/expenses/client/EntityListView.java M

[gwt-contrib] Re: Array implementation for Lightweight Collections. Pure Java implementation only. (issue232801)

http://gwt-code-reviews.appspot.com/232801/diff/3001/4002 File bikeshed/src/com/google/gwt/collections/Assertions.java (right): http://gwt-code-reviews.appspot.com/232801/diff/3001/4002#newcode24 bikeshed/src/com/google/gwt/collections/Assertions.java:24: assert (index = 0 index maxExclusive)

[gwt-contrib] Checkstyle fixes (issue258801)

Reviewers: jat, Description: Checkstyle fixes Please review this at http://gwt-code-reviews.appspot.com/258801/show Affected files: M bikeshed/src/com/google/gwt/sample/expenses/gen/EmployeeRequestImpl.java M bikeshed/src/com/google/gwt/sample/expenses/gen/ReportRequestImpl.java M

[gwt-contrib] Remove an incorrect @Override of an interface method (issue255802)

Reviewers: Lex, Description: Remove an incorrect @Override of an interface method Please review this at http://gwt-code-reviews.appspot.com/255802/show Affected files: M dev/core/test/com/google/gwt/core/ext/linker/impl/SelectionScriptJavaScriptTest.java Index:

[gwt-contrib] Re: Adds a Precompress linker that can be used to compress public artifacts (issue254801)

LGTM with nits http://gwt-code-reviews.appspot.com/254801/diff/10001/11004 File user/src/com/google/gwt/util/regexfilter/RegexFilter.java (right): http://gwt-code-reviews.appspot.com/254801/diff/10001/11004#newcode31 user/src/com/google/gwt/util/regexfilter/RegexFilter.java:31: * it indicates

[gwt-contrib] Re: Bikeshed: Wait until user stops typing before fetching stocks (issue270801)

LGTM http://gwt-code-reviews.appspot.com/270801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.

[gwt-contrib] Fix external issue 4772 (com.google.gwt.user.client.ui.UIObject.setHeight(1em) causes an asser... (issue271801)

Reviewers: scottb, Description: Fix external issue 4772 (com.google.gwt.user.client.ui.UIObject.setHeight(1em) causes an assert error with rhino) Tighten the regex defining a number (the old one could accept inputs such as '.' and 'e5') Please review this at

[gwt-contrib] Add a demo of SimpleCellList and fix some bugs found by the demo (issue272801)

Reviewers: jlabanca, Description: Add a demo of SimpleCellList and fix some bugs found by the demo Please review this at http://gwt-code-reviews.appspot.com/272801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/list/client/SimpleCellList.java M

[gwt-contrib] Re: Fix external issue 4772 (com.google.gwt.user.client.ui.UIObject.setHeight(1em) causes an asser... (issue271801)

On 2010/03/25 20:39:00, scottb wrote: LGTM if the regexes are right. :D I'll assume it's correct if the tests pass. The heart of the old regex was \d*\.?\d*, which allowed both sets of digits to be empty (thus allowing a '.' by itself). I changed it to force digits to appear either before or

[gwt-contrib] Remove JDK 1.6-isms; fix a checkstyle warning (issue281801)

Reviewers: Lex, Description: Remove JDK 1.6-isms; fix a checkstyle warning Please review this at http://gwt-code-reviews.appspot.com/281801/show Affected files: M dev/core/src/com/google/gwt/core/linker/IFrameLinker.java M

[gwt-contrib] Re: Lightweight collections. ImmutableArray and MutableArray.freeze() implementation. (issue291801)

LGTM http://gwt-code-reviews.appspot.com/291801/diff/1/6 File bikeshed/src/com/google/gwt/collections/MutableArray.java (right): http://gwt-code-reviews.appspot.com/291801/diff/1/6#newcode49 bikeshed/src/com/google/gwt/collections/MutableArray.java:49: * Creates and immutable array based on

[gwt-contrib] Re: Lightweight collections. ImmutableArray and MutableArray.freeze() implementation. (issue291801)

http://gwt-code-reviews.appspot.com/291801/diff/1/6 File bikeshed/src/com/google/gwt/collections/MutableArray.java (right): http://gwt-code-reviews.appspot.com/291801/diff/1/6#newcode97 bikeshed/src/com/google/gwt/collections/MutableArray.java:97: E[] newElems = (E[]) new Object[oldLen + 1];

[gwt-contrib] Re: Remove JDK 1.6-isms; fix a checkstyle warning (issue281801)

http://gwt-code-reviews.appspot.com/281801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe from this group, send email to google-web-toolkit-contributors+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.

[gwt-contrib] Re: Remove JDK 1.6-isms; fix a checkstyle warning (issue281801)

On 2010/03/30 21:40:48, Lex wrote: LGTM. I didn't realize Charset was 1.6-only. It has Charset but not String.getBytes(Charset). http://gwt-code-reviews.appspot.com/281801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors To unsubscribe, reply using remove me as the

[gwt-contrib] Use PagingTableListView in TableEntityListView (issue298801)

Reviewers: Ray Ryan, Description: Use PagingTableListView in TableEntityListView Work on Mail sample app, remove index param from Column.getValue() Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/298801/show Affected files: M

[gwt-contrib] Add convenience classes and method to simplify demo code. (issue299801)

Reviewers: jgw, Description: Add convenience classes and method to simplify demo code. Review by: j...@google.com Please review this at http://gwt-code-reviews.appspot.com/299801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/cells/client/TextCell.java M

[gwt-contrib] Fix checkstyle sort order. (issue316802)

Reviewers: rchandia, Description: Fix checkstyle sort order. Review by: rchan...@google.com Please review this at http://gwt-code-reviews.appspot.com/316802/show Affected files: M bikeshed/test/com/google/gwt/collections/ImmutableArrayTest.java Index:

[gwt-contrib] Checkstyle fixes. (issue320801)

Reviewers: Ray Ryan, Description: Checkstyle fixes. Review by: rj...@google.com Please review this at http://gwt-code-reviews.appspot.com/320801/show Affected files: M bikeshed/src/com/google/gwt/requestfactory/shared/RequestFactory.java M

[gwt-contrib] Re: Added method to change the size of a MutableArray. Added factory method to construct a nonempty ... (issue319801)

LGTM http://gwt-code-reviews.appspot.com/319801/diff/1/3 File bikeshed/src/com/google/gwt/collections/MutableArray.java (right): http://gwt-code-reviews.appspot.com/319801/diff/1/3#newcode150 bikeshed/src/com/google/gwt/collections/MutableArray.java:150: * truncated. If {...@code newSize} is

[gwt-contrib] Add type params for ListRegistration instances. (issue329801)

Reviewers: jgw, Description: Add type params for ListRegistration instances. Review by: j...@google.com Please review this at http://gwt-code-reviews.appspot.com/329801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/tree/client/TreeNodeView.java M

[gwt-contrib] Remove ListModel and add ListView/ListView.Delegate; clean up javadoc (issue336801)

Reviewers: jlabanca, Description: Remove ListModel and add ListView/ListView.Delegate; clean up javadoc Please review this at http://gwt-code-reviews.appspot.com/336801/show Affected files: M bikeshed/src/com/google/gwt/bikeshed/cells/client/ActionCell.java M

[gwt-contrib] Fix a possible null pointer dereference (issue330802)

Reviewers: rchandia, Description: Fix a possible null pointer dereference Review by: rchan...@google.com Please review this at http://gwt-code-reviews.appspot.com/330802/show Affected files: M bikeshed/src/com/google/gwt/collections/MutableArray.java Index:

  1   2   3   >