[PATCH] CLEANUP: log: deinitialization of the log buffer in one function

2024-01-29 Thread Miroslav Zagorac
and free_logformat_list() in src/proxy.c - they were both static functions). The function free_logformat_list() was moved from the file src/proxy.c to src/log.c, and a check of the list before freeing the memory was added to that function. Best regards, -- Miroslav Zagorac Senior DeveloperFrom

[PATCH] DOC: configuration: corrected description of keyword tune.ssl.ocsp-update.mindelay

2024-01-09 Thread Miroslav Zagorac
certificates to entries. This is a LRU cache. Because generating a SSL certificate dynamically is expensive, they are cached. The default cache size is set to 1000 entries. If this is not the case, please ignore this patch. Best regards, -- Miroslav Zagorac Senior DeveloperFrom

[PATCH] MINOR: ot: logsrv struct becomes logger

2024-01-08 Thread Miroslav Zagorac
Hello all, after the patch 18da35c "MEDIUM: tree-wide: logsrv struct becomes logger", the OpenTracing filter can no longer be compiled in debug mode. This patch fixes it. This patch should be backported to branch 2.9. Best regards, -- Miroslav Zagorac Senior Dev

[PATCH] MINOR: properly mark the end of the CLI command in error messages

2023-09-02 Thread Miroslav Zagorac
Hello all, this is a patch related to correctly marking the end of the CLI command in the error message in several places in the file src/ssl_ckch.c . -- Miroslav ZagoracFrom f3d8570a7872f1be4fe0e6d20d278c9397813f21 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Fri, 1 Sep 2023 22:23:27

Re: [PATCH] BUG/MINOR: illegal use of the malloc_trim() function if jemalloc is used

2023-03-22 Thread Miroslav Zagorac
On 22. 03. 2023. 14:33, Willy Tarreau wrote: >> Also, in that case, when calling 'haproxy -vv', it is no longer printed that >> malloc_trim is enabled. > > I'm not sure what you mean here, because for me it's never printed that > malloc_trim() is enabled when building with jemalloc. > Hello

Re: [PATCH] BUG/MINOR: illegal use of the malloc_trim() function if jemalloc is used

2023-03-22 Thread Miroslav Zagorac
On 22. 03. 2023. 13:11, Miroslav Zagorac wrote: > Hello all, > > here is a patch that does not allow the use of malloc_trim() function if > HAProxy is linked with the malloc library. It was checked in some places in .. jemalloc .., sorry for the typo. > the source, but

[PATCH] BUG/MINOR: illegal use of the malloc_trim() function if jemalloc is used

2023-03-22 Thread Miroslav Zagorac
. -- Miroslav Zagorac Senior DeveloperFrom 33a84d19548baf46e8fccbb58a891a3e4c6b4895 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 22 Mar 2023 12:52:19 +0100 Subject: [PATCH] BUG/MINOR: illegal use of the malloc_trim() function if jemalloc is used In the event that HAProxy is linked

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Miroslav Zagorac
use it lacks functions for working with variables. However, given your explanation of how the thing works with backporting functionality, we won’t break that here. If users demand it very much, it could be considered. Now, not to make trouble for ourselves, we don’t need to backport it. -- M

Re: [EXTERNAL] Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Miroslav Zagorac
ot necessary for functionality, so you don't have to apply them. Thank you for your help. Best regards, -- Miroslav Zagorac Senior Developer

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-08 Thread Miroslav Zagorac
ables is significantly faster than the previous one (when variables with names were stored instead of hash). For example, in the worst case, when the rate-limit is set to 100%, the operating speed is almost doubled (this refers to the first result in the 'addons/ot/test/README-speed-ctx' file)." -

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-07 Thread Miroslav Zagorac
On 07.04.2022 20:02, Willy Tarreau wrote: No, really, do not bother doing that. Just tell me which ones are bug fixes that need to be backported, as we'll backport them the usual way as part of the regular maintenance process anyway. If you tell me "those marked bugs ought to be backported

Re: [PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-07 Thread Miroslav Zagorac
in client software. For new development it is recommended to use opentelemetry. I hope I have answered at least some of the questions in some useful way. :) Best regards, -- Miroslav Zagorac Senior Developer

[PATCH 16/16] BUG/BUILD: opentracing: fixed OT_DEFINE variable setting

2022-04-07 Thread Miroslav Zagorac
In case of using parameter 'OT_USE_VARS=1', the value of the OT_DEFINE variable is set incorrectly (i.e. the previous value was deleted and a new one set instead of adding new content). -- Miroslav Zagorac Senior Developer >From c84aea9ff85cdbacddf2207c50b3263c23f2e238 Mon Sep 17 00:00:00 2

[PATCH 15/16] Revert "BUILD: opentracing: display warning in case of using OT_USE_VARS at compile time"

2022-04-07 Thread Miroslav Zagorac
This reverts commit 6c9f7faa62a00a4d028704d7b11e290c83f8a49d. This warning is no longer needed because source code can be compiled with enabled support for OpenTracing context transfer via HAProxy variables. -- Miroslav Zagorac Senior Developer >From 068153bae147beba4f8bba3cd2c467f68d1c19ac

[PATCH 14/16] MAJOR: opentracing: reenable usage of vars to transmit opentracing context

2022-04-07 Thread Miroslav Zagorac
mit is set to 100%, the operating speed is almost doubled (this refers to the first result in the 'addons/ot/test/README-speed-ctx' file). -- Miroslav Zagorac Senior Developer >From 7d6c21e612cf0da76870506e68086ab12e3e7d5f Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Thu, 10 Mar 2022 0

[PATCH 13/16] EXAMPLES: opentracing: refined shell scripts for testing filter performance

2022-04-07 Thread Miroslav Zagorac
) has been added for easier printing of messages at the end of execution. -- Miroslav Zagorac Senior Developer >From ae45db88bc0f6e2904db54d23cfe4258af637377 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 9 Mar 2022 17:34:11 +0100 Subject: [PATCH 13/16] EXAMPLES: opentracing:

[PATCH 12/16] DEBUG: opentracing: display the contents of the err variable after setting

2022-04-07 Thread Miroslav Zagorac
A display of the contents of the err variable has been added to the FLT_OT_ERR() macro, once it has been set. -- Miroslav Zagorac Senior Developer >From e38e00f8eb67010cd607429ece16d39c4b9e0f73 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 8 Mar 2022 01:21:04 +0100 Subject: [PA

[PATCH 11/16] CLEANUP: opentracing: added FLT_OT_PARSE_INVALID_enum enum

2022-04-07 Thread Miroslav Zagorac
It's always good to replace "hard-coded" values with something that looks less "hard-coded" (even though that doesn't change anything in the code). This is done here using FLT_OT_PARSE_INVALID_enum enum. -- Miroslav Zagorac Senior Developer >From 4db45aefc8152947a6c6a97df

[PATCH 10/16] DEBUG: opentracing: show return values of all functions in the debug output

2022-04-07 Thread Miroslav Zagorac
]:} = 0 [ 1]0.038807 [OT]: } = 0 -- Miroslav Zagorac Senior Developer >From 0166aa33fedfa739bc678ca98af6b6a74b0e8c1e Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Fri, 4 Mar 2022 09:56:00 +0100 Subject: [PATCH 10/16] DEBUG: opentracing: show return values of all functi

[PATCH 09/16] MINOR: opentracing: improved normalization of context variable names

2022-04-07 Thread Miroslav Zagorac
The flag_cpy parameter has been added to the flt_ot_normalize_name() function, through which we can determine whether the function converts special characters (which are part of that name) when copying a variable name. -- Miroslav Zagorac Senior Developer >F

[PATCH 08/16] DOC: opentracing: corrected comments in function descriptions

2022-04-07 Thread Miroslav Zagorac
Several comments in the function descriptions have been corrected. -- Miroslav Zagorac Senior Developer >From 0b7cd96bbda98e10108316d087fc1828b9f1f564 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 1 Mar 2022 19:18:34 +0100 Subject: [PATCH 08/16] DOC: opentracing: corrected comme

[PATCH 07/16] CLEANUP: opentracing: added variable to store variable length

2022-04-07 Thread Miroslav Zagorac
The same variable should not be used to store multiple different results, because it can be confusing. Therefore, the var_name_len variable has been added in several functions, in order to avoid the use of the retval variable for several different purposes. -- Miroslav Zagorac Senior Developer

[PATCH 06/16] BUG/MINOR: opentracing: setting the return value in function flt_ot_var_set()

2022-04-07 Thread Miroslav Zagorac
Function flt_ot_var_set() did not check whether the variable was successfully set or not. In case of failure, the value -1 is returned. -- Miroslav Zagorac Senior Developer >From 731892071c47540e2ed04d539121546194322731 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 1 Mar 2022

[PATCH 05/16] CLEANUP: opentracing: added flt_ot_smp_init() function

2022-04-07 Thread Miroslav Zagorac
The flt_ot_smp_init() function has been added to make initializing the sample structure easier. The contents of the structure in question are set in several places in the source of the OpenTracing filter, so it is better to do this in one place. -- Miroslav Zagorac Senior Developer >F

[PATCH 04/16] CLEANUP: opentracing: removed unused function flt_ot_var_get()

2022-04-07 Thread Miroslav Zagorac
The flt_ot_var_get() function is not used anywhere and is unnecessary in the existing implementation of the OpenTracing filter. -- Miroslav Zagorac Senior Developer >From 1faf31cb0ed0cb41e89dc189cee3c753aa1cba55 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 1 Mar 2022 18:39

[PATCH 03/16] CLEANUP: opentracing: removed unused function flt_ot_var_unset()

2022-04-07 Thread Miroslav Zagorac
The flt_ot_var_unset() function is not used anywhere and is unnecessary in the existing implementation of the OpenTracing filter. -- Miroslav Zagorac Senior Developer >From 6f75cb4adc0d2ffa661fe861cc0986aaf99450b5 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 1 Mar 2022 18:38

[PATCH 02/16] MINOR: opentracing: only takes the variables lock on shared entries

2022-04-07 Thread Miroslav Zagorac
Regarding commit #61ecf2838: There's no point taking the variables locks for sess/txn/req/res contexts since these ones always run inside the same thread anyway. -- Miroslav Zagorac Senior Developer >From 099ed5a7cf021d7144aff009a5baa91912375509 Mon Sep 17 00:00:00 2001 From: Miros

[PATCH 01/16] Revert "MINOR: opentracing: change the scope of the variable 'ot.uuid' from 'sess' to 'txn'"

2022-04-07 Thread Miroslav Zagorac
the range 'txn' and 'req' are initialized. This means that we cannot use variables with the specified scopes before that point. -- Miroslav Zagorac Senior Developer >From 8f777edd98512666a40ffc8abd2d00c187fe577b Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 23 Feb 2022 10:28:10 +0

[PATCH 0/16] opentracing: reenable usage of vars to transmit opentracing context

2022-04-07 Thread Miroslav Zagorac
in the 'addons/ot/test/README-speed-ctx' file). Best regards, -- Miroslav Zagorac Senior Developer

Re: [EXTERNAL] Re: [PATCH] BUILD: opentracing: display warning in case of using OT_USE_VARS at compile time

2021-12-28 Thread Miroslav Zagorac
On 12/28/2021 11:59 AM, William Lallemand wrote: On Mon, Dec 27, 2021 at 01:22:57PM +0100, Miroslav Zagorac wrote: On 12/27/2021 01:16 PM, Miroslav Zagorac wrote: Hello all, to avoid misunderstandings (like say github issue #1493) when compiling HAproxy source with the OpenTracing filter

Re: [PATCH] BUILD: opentracing: display warning in case of using OT_USE_VARS at compile time

2021-12-27 Thread Miroslav Zagorac
On 12/27/2021 01:16 PM, Miroslav Zagorac wrote: Hello all, to avoid misunderstandings (like say github issue #1493) when compiling HAproxy source with the OpenTracing filter enabled, a warning has been added if the OT_USE_VARS variable is used. If appropriate, please apply this commit. Best

[PATCH] BUILD: opentracing: display warning in case of using OT_USE_VARS at compile time

2021-12-27 Thread Miroslav Zagorac
Hello all, to avoid misunderstandings (like say github issue #1493) when compiling HAproxy source with the OpenTracing filter enabled, a warning has been added if the OT_USE_VARS variable is used. If appropriate, please apply this commit. Best regards. -- Miroslav Zagorac

Re: [PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-13 Thread Miroslav Zagorac
is slower than strncasecmp() and the duration of the function increases rapidly while the processing time of the function strncasecmp() is quite stable). I’m not writing this to start some deeper discussion, this is purely informative. :) Best regards, -- Miroslav Zagorac Senior Developer

Re: [PATCH 2/4] BUG/MINOR: opentracing: enable the use of http headers without a set value

2021-09-12 Thread Miroslav Zagorac
Hello Willy, On 09/12/2021 08:19 AM, Willy Tarreau wrote: Bah, I discovered that one after merging the first series :-/ I've applied it on top as a cleanup with your description above as the commit message since it's really what it's about. It is no problem. I apologize for the slight

Re: [PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-12 Thread Miroslav Zagorac
Hello Willy, On 09/12/2021 08:11 AM, Willy Tarreau wrote: thanks for working on fixing this, it's now merged. I've added a tiny change to make sure that text_map is always initialized in flt_ot_scope_run() because that made clang rightfully upset, re-enabled OT in the CI since it's now OK.

Re: [PATCH 2/4] BUG/MINOR: opentracing: enable the use of http headers without a set value

2021-09-10 Thread Miroslav Zagorac
On 09/11/2021 12:05 AM, Miroslav Zagorac wrote: Hello all, the second patch from the last series of patches has been redesigned here, the ist() function is used to set an empty string instead of working directly with the string pointer. I thank Tim Düsterhus for his advice. The operation

[PATCH 2/4] BUG/MINOR: opentracing: enable the use of http headers without a set value

2021-09-10 Thread Miroslav Zagorac
? >From 661e87f9b897924d786c887d19b211816443eed5 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Thu, 9 Sep 2021 01:23:42 +0200 Subject: [PATCH 2/4] BUG/MINOR: opentracing: enable the use of http headers without a set value In case we transfer some data that does not have a set value

Re: [PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-10 Thread Miroslav Zagorac
Hello Tim, On 09/10/2021 10:55 PM, Tim Düsterhus wrote: If it's not a NULL pointer then it must be a valid pointer. I don't quite understand why you would need to replace this by an empty constant string then? Is this about a missing NUL terminator? Otherwise a valid pointer with .len == 0

Re: [PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-10 Thread Miroslav Zagorac
On 09/10/2021 07:18 PM, Tim Düsterhus wrote: Patch 2 looks odd to me. Is the issue that .ptr is equal to NULL and *that* is causing issues? Then I recommend the following instead: if (!isttest(v)) v = ist(""); this is much cleaner, because it does not attempt to cram so much logic into that

[PATCH] BUILD: opentracing: excluded use of haproxy variables for, OpenTracing context

2021-09-10 Thread Miroslav Zagorac
the nature of a man? >From 77fb9a98a82c72bd0696412e5d04425d2431a951 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 8 Sep 2021 20:56:05 +0200 Subject: [PATCH 1/4] BUILD: opentracing: exclude the use of haproxy variables for the OpenTracing context Due to a recent change in the handl

Re: I just broke opentracing :-(

2021-09-09 Thread Miroslav Zagorac
Hello Willy, On 09/09/2021 08:43 AM, Willy Tarreau wrote: Yes, that's where I found it but didn't know what its use was. A few points however: - sess.ot.uuid will be shared by all requests on the same session, which is probably not what you want (e.g. for requests coming in H2, the

Re: I just broke opentracing :-(

2021-09-08 Thread Miroslav Zagorac
On 09/08/2021 07:57 PM, Miroslav Zagorac wrote: On 09/08/2021 07:42 PM, Willy Tarreau wrote: No rush on this one, I'll let you think about it, just let me know if we need to temporarily disable it from the CI, or if you just want a day or two of checking before knowing if you can get a quick

Re: I just broke opentracing :-(

2021-09-08 Thread Miroslav Zagorac
On 09/08/2021 07:42 PM, Willy Tarreau wrote: No rush on this one, I'll let you think about it, just let me know if we need to temporarily disable it from the CI, or if you just want a day or two of checking before knowing if you can get a quick solution or if it will take more time. Thank you

Re: I just broke opentracing :-(

2021-09-08 Thread Miroslav Zagorac
On 09/08/2021 04:41 PM, Willy Tarreau wrote: Hi Miroslav, I just discovered that the changes I've made to the totally broken variables API now broke opentracing because apparently it's using some of the variable code's internals for its own use:

[PATCH] BUILD: opentracing: fixed build when using pkg-config utility

2021-07-29 Thread Miroslav Zagorac
rom 5f5bffd72bb10ec80d3fe4cd1c6ea21945c2b498 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Thu, 29 Jul 2021 11:10:08 +0200 Subject: [PATCH] BUILD: opentracing: fixed build when using pkg-config utility In case the OpenTracing C Wrapper library was installed as part of the system (ie in a directory that pkg-config considers p

[PATCH] CLEANUP: server: a separate function for initializing the per_thr field

2021-06-15 Thread Miroslav Zagorac
can change the nature of a man? >From 81ec1afe2a7da947952deedb394970248df6cd8b Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 15 Jun 2021 15:33:20 +0200 Subject: [PATCH] CLEANUP: server: a separate function for initializing the per_thr field To avoid repeating the same source c

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
it is no longer used (after the application of this commit). If there is anything else, feel free to change it. :) Best regards, -- Zaga What can change the nature of a man? >From 252a9c1f425fb3d2e37e6390174a5be4a5081a2a Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Thu, 10 Jun 2021 01:23

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
I forgot to mention that one should take the latest version of the opentracing c wrapper (it is now 1.1.0). https://github.com/haproxytech/opentracing-c-wrapper -- Zaga What can change the nature of a man?

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
On 06/09/2021 11:46 AM, Miroslav Zagorac wrote: On 06/09/2021 09:10 AM, Willy Tarreau wrote: Hi Miroslav, On Mon, Jun 07, 2021 at 04:55:21PM +0200, Miroslav Zagorac wrote: ... In fact, the only access to these files is achieved only once at the beginning of the HAProxy process

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-09 Thread Miroslav Zagorac
On 06/09/2021 09:10 AM, Willy Tarreau wrote: Hi Miroslav, On Mon, Jun 07, 2021 at 04:55:21PM +0200, Miroslav Zagorac wrote: ... In fact, the only access to these files is achieved only once at the beginning of the HAProxy process, in the initialization of threads. After this initialization

Re: [PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-07 Thread Miroslav Zagorac
Hello all, I apologize for resending the patch, part of the description was written twice, now it's fixed Best regards, -- Zaga What can change the nature of a man? >From 4bbbe5fd3e66a37ec9703723ba22b742e7926a07 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Mon, 7 Jun 2021

[PATCH] BUG/MINOR: opentracing: fixed files existence check in chroot mode

2021-06-07 Thread Miroslav Zagorac
xy process, in the initialization of threads. After this initialization, no access to the file system is performed. This resolves GitHub issue #1274. Best regards, -- Zaga What can change the nature of a man? >From 50dadc20167d5d5dfa214baac031160fa9a6c612 Mon Sep 17 00:00:00 2001 From: Miroslav

[PATCH] BUILD/MINOR: opentracing: fixed build when using clang

2021-05-18 Thread Miroslav Zagorac
Hello, this patch should solve the github issue #1242. Best regards, -- Zaga What can change the nature of a man? >From 5ca6a7230952f966a0eb5b0119b45d522c2c5999 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 18 May 2021 20:05:10 +0200 Subject: [PATCH] BUILD/MINOR: opentrac

Re: [PATCH] CI: enable OpenTracing feature

2021-05-18 Thread Miroslav Zagorac
On 05/18/2021 06:49 PM, Илья Шипицин wrote: Miroslav, can you please keep an eye on patch from OpenTracing build failures using clang · Issue #1242 · haproxy/haproxy (github.com) ? Hello Илья, I thought that patch was already applied.. Ok,

[PATCH] BUILD/MINOR: opentracing: fixed compilation with filter, enabled

2021-05-11 Thread Miroslav Zagorac
rom 6fe243c20b938afdfa934d6c075ae154bac9a976 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Tue, 11 May 2021 19:21:54 +0200 Subject: [PATCH] BUILD/MINOR: opentracing: fixed compilation with filter enabled The inclusion of header files proxy.h and tools.h was added to the addons/ot/include/include.h file. Without this HAPr

Re: Opentracing span name from variable

2021-04-15 Thread Miroslav Zagorac
On 04/15/2021 04:24 PM, Andrea Bonini wrote: Hi all, is it possible to use a variable as span name? for example, can i use uri as span name so in zipkin it's visible as service: Thanks Hello Andrea, the name of the span is defined statically and cannot be the content of a variable.

[OT PATCH 2/2] MINOR: opentracing: transfer of context names without prefix

2021-04-14 Thread Miroslav Zagorac
e context and what is not. Best regards, -- Zaga What can change the nature of a man? >From 6ede4cf6e83b327db132e830dd09b728057ae375 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 14 Apr 2021 11:47:28 +0200 Subject: [PATCH 2/2] MINOR: opentracing: transfer of context names without p

[OT PATCH 1/2] MINOR: opentracing: correct calculation of the number of arguments in the args[]

2021-04-14 Thread Miroslav Zagorac
that cannot handle the prefix of that data. Best regards, -- Zaga What can change the nature of a man? >From 0c0c0c77fe5b1a71ea639b5693eab85a917e9df0 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 14 Apr 2021 11:44:58 +0200 Subject: [PATCH 1/2] MINOR: opentracing: correct calculat

[OT PATCH 0/2] opentracing: use of the context name without prefix

2021-04-14 Thread Miroslav Zagorac
Hello all, the next two patches allow you to transfer the OpenTracing context via an HTTP headers without using a name prefix. This is very useful when transferring context from or to some other process that cannot add or remove a prefix from that data. Best regards, -- Zaga What can

Re: haproxy 2.4 opentracing using x-b3-traceid header

2021-04-09 Thread Miroslav Zagorac
On 04/09/2021 01:40 PM, Andrea Bonini wrote: Hi Zaga, thank you for the explanation. My problem is that the external service send the span info in header as x-b3-* format (the opentracing default one). For reading it, which extract context must i configure? if i don't understand wrong if i want

Re: haproxy 2.4 opentracing using x-b3-traceid header

2021-04-09 Thread Miroslav Zagorac
On 04/08/2021 01:48 PM, Andrea Bonini wrote: Hi everyone, i have a question about opentracing addon. Is there a way for using headers info about a trace created from an outside service? what i want is using x-b3-traceid header from an incoming request as traceid and use spanid as parentid

Re: [PATCH] MINOR: opentracing: register config file and line number on log servers

2021-04-07 Thread Miroslav Zagorac
On 04/07/2021 12:13 PM, Илья Шипицин wrote: do you consider adding opentracing to "github actions" CI ? Hello Илья, I don't know how to add it because I never used it. The filter uses specific libraries that are not part of the system but need to be installed and/or compiled

[PATCH] MINOR: opentracing: register config file and line number on log servers

2021-04-07 Thread Miroslav Zagorac
. -- Zaga What can change the nature of a man? >From baae10ef8a2eb487328664a3ff04475cd5d76179 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Wed, 7 Apr 2021 11:14:23 +0200 Subject: [PATCH] MINOR: opentracing: register config file and line number on log servers In commit 9533a7038

[PATCH] BUG/MINOR: opentracing: initialization after establishing daemon mode

2021-04-02 Thread Miroslav Zagorac
change the nature of a man? >From fe482c8adaa703e790b4d1995255b9754799b149 Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Fri, 2 Apr 2021 04:25:47 +0200 Subject: [PATCH] BUG/MINOR: opentracing: initialization after establishing daemon mode This patch solves the problem reported in git

Re: [PATCH] BUILD: trace: include tools.h

2020-09-25 Thread Miroslav Zagorac
On 09/25/2020 05:59 PM, Willy Tarreau wrote: Git uses the "---" marker as an end of commit message, to put your comments to committers below. So when I applied your patch, it dropped this part. I've reintroduced it, but I thought you would like to know in order not to get caught by accident on

[PATCH] BUILD: trace: include tools.h

2020-09-24 Thread Miroslav Zagorac
Hello, haproxy cannot be compiled on debian 9.13 if the TRACE option is used. -- Zaga What can change the nature of a man? >From 97fee9d468d5bd52716fa0352a5ce9b4522730fc Mon Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Thu, 24 Sep 2020 09:15:46 +0200 Subject: [PATCH] BUILD: tr

Re: [PATCH] MINOR: Add either(,) converter

2020-09-11 Thread Miroslav Zagorac
Hello all, there is a small typo in the patch, if says 'iff' instead of 'iif': --- + Example: +http-request set-header x-forwarded-proto %[ssl_fc,iff(https,http)] --- -- Zaga What can change the nature of a man?

Re: [PATCH] MINOR: Add either(,) converter

2020-09-11 Thread Miroslav Zagorac
On 09/11/2020 03:56 PM, Tim Düsterhus, WoltLab GmbH wrote: We've had a bit of discussion regarding the naming of the converter. I wanted to avoid calling it `if`, because then we could have stuff like this: http-request set-var(txn.foo) bool(1),if(bar,baz) which can easily be confused with:

[PATCH] BUG/MINOR: spoe: correction of setting bits for analyzer

2020-06-19 Thread Miroslav Zagorac
001 From: Miroslav Zagorac Date: Fri, 19 Jun 2020 22:17:17 +0200 Subject: [PATCH] BUG/MINOR: spoe: correction of setting bits for analyzer --- src/flt_spoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/flt_spoe.c b/src/flt_spoe.c index 49d7466ae..4790f5945 100644 --- a/

[PATCH] DOC: internals: Fix spelling errors in filters.txt

2020-03-26 Thread Miroslav Zagorac
Sep 17 00:00:00 2001 From: Miroslav Zagorac Date: Thu, 26 Mar 2020 20:45:04 +0100 Subject: [PATCH] DOC: internals: Fix spelling errors in filters.txt --- doc/internals/filters.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/internals/filters.txt b/

[PATCH] CLEANUP: remove unused code in 'my_ffsl/my_flsl' functions

2020-03-08 Thread Miroslav Zagorac
rom: Miroslav Zagorac Date: Sun, 8 Mar 2020 16:32:20 +0100 Subject: [PATCH] CLEANUP: remove unused code in 'my_ffsl/my_flsl' functions Shifting the variable 'a' one bit to the right has no effect on the result of the functions. --- include/common/standard.h | 2 -- 1 file changed, 2 deletions(-) d

Re: mirroragent (haproxy)

2020-03-04 Thread Miroslav Zagorac
On 03/04/2020 07:48 AM, Tuktamyshev Ainur wrote: Dear Christopher Configuration`s and info about haproxy and spoa version in attachment. * If possible, info about the mirror requests Requests coming to haproxy should go to a specific IP, as well as duplicated in our parser located on

Re: haproxy 2.1.2 and 2.1.3

2020-02-21 Thread Miroslav Zagorac
On 02/21/2020 12:32 PM, Tim Düsterhus wrote: Miroslav, I order to save you duplicated effort in helping I'd like to let you know that Marcel also created a GitHub issue upon request from Ilya: https://github.com/haproxy/haproxy/issues/512 Hello Tim, ah.. okay, i missed that. Thank you. :)

Re: haproxy 2.1.2 and 2.1.3

2020-02-21 Thread Miroslav Zagorac
On 02/21/2020 11:42 AM, marcel.klooster...@kpn.com wrote: Hi, It's not working on test-server also. Test-server is a solaris zone on T7 with 11.4 sru 950, production is a solaris zone on T8 with 11.4 sru 950. You can start gdb like this: % gdb -core core-file program , and in your case it

Re: [PATCH v4] BUG/MINOR: dns: allow 63 char in hostname

2020-01-27 Thread Miroslav Zagorac
On 01/28/2020 12:02 AM, Baptiste wrote: On Sun, Jan 26, 2020 at 7:53 PM William Dauchy wrote: hostname were limited to 62 char, which is not RFC1035 compliant; - the parsing loop should stop when above max label char - fix len label test where d[i] was wrongly used - simplify the whole

Re: [PATCH] BUG/MINOR: dns: allow 63 char in hostname

2020-01-25 Thread Miroslav Zagorac
On 01/26/2020 12:39 AM, William Dauchy wrote: hostname were limited to 62 char, which is not RFC1035 compliant; simply remove equality in condition as counter is initialised at zero. (also simplify brackets for readability) this should github issue #387 Signed-off-by: William Dauchy ---

[PATCH] BUG/MINOR: WURFL: fix send_log() function arguments

2019-10-15 Thread Miroslav Zagorac
s% s%" ...', the user agent string is set to '%s s% s%', causing the HAProxy to crash. This only happens if the HAProxy is compiled with the option -DWURFL_DEBUG. This patch could be backported in every version supporting the ScientiaMobile's WURFL. (as far as 1.7) -- Miroslav Zag