Re: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-29 Thread Willy Tarreau
Hi Baptiste, On Wed, Nov 28, 2018 at 03:33:20PM +0100, Baptiste wrote: > Hi there, > > There is a small bug with the function involved in the ssl_fc_cipherlist_* > fetches. > ssl_sock_parse_clienthello() improperly parses the session id, which leads > to not return any client side cipher list whe

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-29 Thread Willy Tarreau
Hi Adis, On Wed, Nov 28, 2018 at 05:35:28PM +0100, Adis Nezirovic wrote: > Hey guys, > > After commit bf89ff3db8be1a8f87de305c144467bbc2503036 > "MEDIUM: stream-int: make stream_int_update() aware of the lower layers" > I'm not able to use client sockets from tasks created with Lua (see > attache

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-29 Thread Adis Nezirovic
On Thu, Nov 29, 2018 at 09:03:34AM +0100, Willy Tarreau wrote: > OK thanks, I'll take a look at it once I've flushed my pending stuff on > H2+HTX :-( Great, I had my morning coffee and visited my optometrist, so here is a fixed test script (correctly setting Host header). P.S. Lua usually suffers

Re: SSL certs

2018-11-29 Thread Johan Hendriks
Op 27-11-18 om 02:53 schreef Azim Siddiqui: > Hello, > > Hope you are doing good. We are using HAproxy in our company. But the ssl > certs has been expired. I want to renew it. As i can see HAproxy only takes > .pem format for certs. So what files should be included in that .pem file ? > And c

[PATCH] REGTEST: Fix LEVEL 4 script 0 of "connection" module.

2018-11-29 Thread Frederic Lecaille
Here is a little reg test fix. Fred. >From 61fd6486eee833b42a342993706b656537079242 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Thu, 29 Nov 2018 14:23:32 +0100 Subject: [PATCH] REGTEST: Fix LEVEL 4 script 0 of "connection" module. Prevent this script from

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-29 Thread Frederic Lecaille
Hi Adis, On 11/29/18 10:03 AM, Adis Nezirovic wrote: On Thu, Nov 29, 2018 at 09:03:34AM +0100, Willy Tarreau wrote: OK thanks, I'll take a look at it once I've flushed my pending stuff on H2+HTX :-( Great, I had my morning coffee and visited my optometrist, so here is a fixed test script (cor

Re: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-29 Thread Baptiste
Hi Willy, (first, before I forget, the patch should be backported in 1.8) Test case was very fun: I have a HAProxy listening on 127.1:443 with my cert. When I "curl" it, I could get the list of ciphers sent by the client in the log using the relevant fetch and when I used Chrome or Firefox, I cou

Re: [PATCH] BUG/MINOR: ssl: ssl_sock_parse_clienthello ignores session id

2018-11-29 Thread Willy Tarreau
On Thu, Nov 29, 2018 at 04:33:21PM +0100, Baptiste wrote: > (first, before I forget, the patch should be backported in 1.8) OK, I've added this in the commit message. > Test case was very fun: I have a HAProxy listening on 127.1:443 with my > cert. When I "curl" it, I could get the list of cipher

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Frederic Lecaille
On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge it and create a temporary "reg-tests2" target in the makefile to u

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread PiBa-NL
Hi Frederic, Op 29-11-2018 om 19:18 schreef Frederic Lecaille: On 11/29/18 8:47 AM, Willy Tarreau wrote: On Thu, Nov 29, 2018 at 05:36:35AM +0100, Willy Tarreau wrote: However I'm well aware that it's easier to work on improvements once the script is merged, so what I've done now is to merge

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Frederic Lecaille
On 11/29/18 5:36 AM, Willy Tarreau wrote: Hi guys, On Wed, Nov 28, 2018 at 11:17:22AM +0100, Frederic Lecaille wrote: Perhaps we should "chmod +x" this script. Good point, done here. However I'm now seeing this when starting it : ## Starting varnishtest #

reg-test failure for /connection/b00000.vtc after commit 3e1f68b

2018-11-29 Thread PiBa-NL
Hi Olivier, List, It seems one of the reg-tests /connection/b0.vtc is failing after this recent commit. http://git.haproxy.org/?p=haproxy.git;a=commit;h=3e1f68bcf9adfcd30e3316b0822c2626cc2a6a84 Using HA-Proxy version 1.9-dev8-3e1f68b 2018/11/29 Some of the output looks like this: *** 

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-29 Thread PiBa-NL
Hi Frederic, Adis, Op 29-11-2018 om 14:53 schreef Frederic Lecaille: Hi Adis, On 11/29/18 10:03 AM, Adis Nezirovic wrote: On Thu, Nov 29, 2018 at 09:03:34AM +0100, Willy Tarreau wrote: OK thanks, I'll take a look at it once I've flushed my pending stuff on H2+HTX :-( Great, I had my morning

Re: [PATCH] REGTEST/MINOR: script: add run-regtests.sh script

2018-11-29 Thread Willy Tarreau
On Thu, Nov 29, 2018 at 10:04:29PM +0100, Frederic Lecaille wrote: > Here is a patch for haproxy (named 0001-REGTEST*) to fix these issues. Works like a charm, thank you Fred! Now applied. Willy

Re: BUG: Lua tasks can't use client sockets after bf89ff3d

2018-11-29 Thread Willy Tarreau
Hi Pieter, On Fri, Nov 30, 2018 at 02:42:26AM +0100, PiBa-NL wrote: > Attached a new test which does, and does indeed fail on versions since the > mentioned commit. Thanks! > Should i make a patch out of it for inclusion in git? Or can you guys do > that once the fix is also ready.? i think it w