Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

Hi Kalle!

On 04.05.2019 at 13:33, Kalle Sommer Nielsen wrote:

> Den lør. 4. maj 2019 kl. 14.19 skrev Christoph M. Becker :
>>
>> On 04.05.2019 at 10:56, Christoph M. Becker wrote:
>>
>>> I have submitted PR #4112 to bring back the common PDO tests, which are
>>> the majority of existing tests for pdo_firebird.  Three tests are
>>> failing (which should be investigated), but these tests already failed
>>> in PHP-7.3 and maybe before.
>
> I had a look at your PRs, both look good! Like I mentioned on the
> common.phpt one, I wasn't aware of this PDO magic, so its good that
> you fixed it quickly.
>
> +1 on both PRs.

Great.  I've merged both.

>> I had a closer look at the tests failing with Firebird 3.0.4.33054 (x64):
>>
>> bug_69356.phpt fails because FB doesn't support `SELECT expr;` queries;
>> apparently, a FROM clause would be required.
>
> If that is the case, we should add the FROM clause. When I tested it,
> it was passing but I'm uncertain how exactly. I was using a 3.0.2 x64
> build on Windows for these, so there seems to be something odd going
> on here.
>
>> bug_71447.phpt fails because there are issues regarding comments with a
>> single quote.
>
> Could this be an SQL dialect setting missing given its pass for me?

That's quite possible.

>> bug_73234.phpt fails because FB doesn't support defining explicit
>> nullable columns, i.e.
>>
>>   CREATE TABLE (id INT NULL)
>>
>> is unsupported.  Removing the NULL let's the test proceed, but binding a
>> zero as PDO::PARAM_NULL apparently inserts `string(1) "0"` which looks
>> like a bug in the driver.
>
> Again odd it did not fail for me, but we should log a bug about this
> issue if there isn't one already and hope that someone will pick it up
> unless you want to invest the time into it.

I'd like to pass this to someone more knowledgeable with PDO and
especially Interbase/Firebird.

> Thanks for looking into these! Much appreciated.

Thanks for the basic port of the test suite to pure PDO, and for your
efforts to move ext/interbase to PECL!

Thanks,
Christoph

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Hi Christoph

Den lør. 4. maj 2019 kl. 14.19 skrev Christoph M. Becker :
>
> On 04.05.2019 at 10:56, Christoph M. Becker wrote:
>
> > I have submitted PR #4112 to bring back the common PDO tests, which are
> > the majority of existing tests for pdo_firebird.  Three tests are
> > failing (which should be investigated), but these tests already failed
> > in PHP-7.3 and maybe before.

I had a look at your PRs, both look good! Like I mentioned on the
common.phpt one, I wasn't aware of this PDO magic, so its good that
you fixed it quickly.

+1 on both PRs.

> I had a closer look at the tests failing with Firebird 3.0.4.33054 (x64):
>
> bug_69356.phpt fails because FB doesn't support `SELECT expr;` queries;
> apparently, a FROM clause would be required.

If that is the case, we should add the FROM clause. When I tested it,
it was passing but I'm uncertain how exactly. I was using a 3.0.2 x64
build on Windows for these, so there seems to be something odd going
on here.

> bug_71447.phpt fails because there are issues regarding comments with a
> single quote.

Could this be an SQL dialect setting missing given its pass for me?

> bug_73234.phpt fails because FB doesn't support defining explicit
> nullable columns, i.e.
>
>   CREATE TABLE (id INT NULL)
>
> is unsupported.  Removing the NULL let's the test proceed, but binding a
> zero as PDO::PARAM_NULL apparently inserts `string(1) "0"` which looks
> like a bug in the driver.

Again odd it did not fail for me, but we should log a bug about this
issue if there isn't one already and hope that someone will pick it up
unless you want to invest the time into it.

Thanks for looking into these! Much appreciated.

-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

On 04.05.2019 at 10:56, Christoph M. Becker wrote:

> I have submitted PR #4112 to bring back the common PDO tests, which are
> the majority of existing tests for pdo_firebird.  Three tests are
> failing (which should be investigated), but these tests already failed
> in PHP-7.3 and maybe before.

I had a closer look at the tests failing with Firebird 3.0.4.33054 (x64):

bug_69356.phpt fails because FB doesn't support `SELECT expr;` queries;
apparently, a FROM clause would be required.

bug_71447.phpt fails because there are issues regarding comments with a
single quote.

bug_73234.phpt fails because FB doesn't support defining explicit
nullable columns, i.e.

  CREATE TABLE (id INT NULL)

is unsupported.  Removing the NULL let's the test proceed, but binding a
zero as PDO::PARAM_NULL apparently inserts `string(1) "0"` which looks
like a bug in the driver.

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

Hi Kalle!

On 03.05.2019 at 19:00, Kalle Sommer Nielsen wrote:

> Den fre. 3. maj 2019 kl. 12.02 skrev Christoph M. Becker :
>
>> While running the tests with a PHP debug version, I've noticed that
>> bug_aaa.phpt is causing a memory leak.  Maybe someone proficient with
>> Firebird/Interbase will want to have a look at it.
>
> Thank you for testing, good to know that they at least run there too!

ACK.  It would be even nicer to have these tests run on a CI, though.

> As for the memory leak, perhaps we should mark the relevant test with
> an --XFAIL-- or something? The name was suspicious in the first place.

The respective commit message[1] explains the test name; it is about a
fix for an unfiled bug, so instead of a concrete bug number the suffix
"aaa" had been chosen.

Anyhow, I have submitted PR #4111 which would fix the memory leak.  I'm
not 100% sure that this couldn't cause a UAF scenario, though, so I have
targeted PHP-7.4 for now.

> Guess this is as good as it gets for PDO_Firebird at least.

I have submitted PR #4112 to bring back the common PDO tests, which are
the majority of existing tests for pdo_firebird.  Three tests are
failing (which should be investigated), but these tests already failed
in PHP-7.3 and maybe before.

[1]

[2] 
[3] 

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Hi Christoph

Den fre. 3. maj 2019 kl. 12.02 skrev Christoph M. Becker :
> While running the tests with a PHP debug version, I've noticed that
> bug_aaa.phpt is causing a memory leak.  Maybe someone proficient with
> Firebird/Interbase will want to have a look at it.

Thank you for testing, good to know that they at least run there too!

As for the memory leak, perhaps we should mark the relevant test with
an --XFAIL-- or something? The name was suspicious in the first place.

Guess this is as good as it gets for PDO_Firebird at least. I can see
the PR regarding adding boolean types to PDO_Firebird was updated too,
to reflect these changes so it should be good to go into 7.4 I suppose
if its rebased.


-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

On 02.05.2019 at 22:21, Kalle Sommer Nielsen wrote:

> Den tor. 2. maj 2019 kl. 22.55 skrev Lester :
>> The problem with including a database is it's dependent on the version
>> of FB running. This will only run with FB3 while FB2.x is still in
>> common use hence it being preferable to use something supplied with the
>> FB installation.
>>
>> https://firebirdsql.org/manual/qsg10-connecting.html
>
> For Windows at least, we only support Firebird3 with the binary-sdk, I
> don't know about Unix.
>
> However I updated my patch, see this for more info:
> http://git.php.net/?p=php-src.git;a=commitdiff;h=1c893b89bdb2b8bd5608c14cd0930727db6ba409
>
> If a brave soul can test on Unix it would be great, but this is about
> as good as it gets.

ACK.

While running the tests with a PHP debug version, I've noticed that
bug_aaa.phpt is causing a memory leak.  Maybe someone proficient with
Firebird/Interbase will want to have a look at it.

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Hi

Den tor. 2. maj 2019 kl. 22.55 skrev Lester :
> The problem with including a database is it's dependent on the version
> of FB running. This will only run with FB3 while FB2.x is still in
> common use hence it being preferable to use something supplied with the
> FB installation.
>
> https://firebirdsql.org/manual/qsg10-connecting.html

For Windows at least, we only support Firebird3 with the binary-sdk, I
don't know about Unix.

However I updated my patch, see this for more info:
http://git.php.net/?p=php-src.git;a=commitdiff;h=1c893b89bdb2b8bd5608c14cd0930727db6ba409

If a brave soul can test on Unix it would be great, but this is about
as good as it gets.

--
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Lester]

On 02/05/2019 19:51, Kalle Sommer Nielsen wrote:

It also includes a 'php.fdb', which I'm not certain whether or not we
should keep as its quite large, but at least it makes the tests run
for me with 15/15 pass.


The problem with including a database is it's dependent on the version 
of FB running. This will only run with FB3 while FB2.x is still in 
common use hence it being preferable to use something supplied with the 
FB installation.


https://firebirdsql.org/manual/qsg10-connecting.html

--
Lester Caine - G8HFL
-
Contact - https://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - https://lsces.co.uk
EnquirySolve - https://enquirysolve.com/
Model Engineers Digital Workshop - https://medw.co.uk
Rainbow Digital Media - https://rainbowdigitalmedia.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Hi Christoph

Den tor. 2. maj 2019 kl. 16.57 skrev Christoph M. Becker :
>
> Hi Kalle,
>
> On 02.05.2019 at 15:35, Kalle Sommer Nielsen wrote:
> Indeed, it seems that pdo_firebird requires to connect to an existing
> database, contrary to e.g. pdo_mysql which supports DSN like
> `mysql:host=localhost`, to my knowledge.  But even if pdo_firebird has
> been connected to an existing database, it appears that it's not
> possible to create a new database via PDO (I got something like "prepare
> does not support CREATE DATABASE", even with emulated prepares turned on).

Please check this commit:
http://git.php.net/?p=php-src.git;a=commitdiff;h=c9599c1c726e3bce8ce5a80c1ac8ee2c81bffb61

It also includes a 'php.fdb', which I'm not certain whether or not we
should keep as its quite large, but at least it makes the tests run
for me with 15/15 pass.


-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Lester]

On 02/05/2019 18:58, Christoph M. Becker wrote:

Glancing that the ext/pgsql and ext/pdo_pgsql tests, though, it looks like
we just require the user to have run "createdb test" before running the
test suite.

Indeed, see
.


https://github.com/bitweaver/install/blob/master/create_firebird_database.php 

Generates a firebird database from PHP via the command line which is the 
other approach.
I've started again with a clean sheet and have a working php-src so I'll 
try and sort a suitable patch ...


--
Lester Caine - G8HFL
-
Contact - https://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - https://lsces.co.uk
EnquirySolve - https://enquirysolve.com/
Model Engineers Digital Workshop - https://medw.co.uk
Rainbow Digital Media - https://rainbowdigitalmedia.co.uk

--
Lester Caine - G8HFL
-
Contact - https://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - https://lsces.co.uk
EnquirySolve - https://enquirysolve.com/
Model Engineers Digital Workshop - https://medw.co.uk
Rainbow Digital Media - https://rainbowdigitalmedia.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

On 02.05.2019 at 18:58, Rowan Collins wrote:

> On Thu, 2 May 2019 at 14:57, Christoph M. Becker  wrote:
>
>> Indeed, it seems that pdo_firebird requires to connect to an existing
>> database, contrary to e.g. pdo_mysql which supports DSN like
>> `mysql:host=localhost`, to my knowledge.
>
> Postgres works the same way - a connection is always to a single database,
> so you cannot have a DSN which doesn't specify one. Default installations
> now ship with an empty database called "postgres" to run administration
> commands like "CREATE DATABASE" on.
>
> Glancing that the ext/pgsql and ext/pdo_pgsql tests, though, it looks like
> we just require the user to have run "createdb test" before running the
> test suite.

Indeed, see
.

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Rowan Collins]

On Thu, 2 May 2019 at 14:57, Christoph M. Becker  wrote:

> Indeed, it seems that pdo_firebird requires to connect to an existing
> database, contrary to e.g. pdo_mysql which supports DSN like
> `mysql:host=localhost`, to my knowledge.
>


Postgres works the same way - a connection is always to a single database,
so you cannot have a DSN which doesn't specify one. Default installations
now ship with an empty database called "postgres" to run administration
commands like "CREATE DATABASE" on.

Glancing that the ext/pgsql and ext/pdo_pgsql tests, though, it looks like
we just require the user to have run "createdb test" before running the
test suite.

Regards,
-- 
Rowan Collins
[IMSoP]

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Lester]

On 02/05/2019 15:24, Christoph M. Becker wrote:

A patch would be welcome!

Looks like every file needs modifying ...
I'll see what I can do, but my local php-src is broken and will not sync 
currently :(


--
Lester Caine - G8HFL
-
Contact - https://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - https://lsces.co.uk
EnquirySolve - https://enquirysolve.com/
Model Engineers Digital Workshop - https://medw.co.uk
Rainbow Digital Media - https://rainbowdigitalmedia.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

On 02.05.2019 at 16:04, Lester wrote:

> On 02/05/2019 14:35, Kalle Sommer Nielsen wrote:
>
>> Yeah that is one thing that is kind of unfortunate and a bad practice.
>> However since interbase was disabled for AppVeyor, these tests had no
>> chance to run in a while. Looking at the actual code in testdb.inc, it
>> seems like it creates the database for testing purposes, I would
>> suppose this is due to PDO_Firebird perhaps requiring a database to
>> continue its connection flow in PDO itself.
>>
>> I'm not sure how we can go about this, maybe a .sql file for testers
>> who run the test suite for schemas and then see if we can integrate
>> some auto importer in our CI build scripts for this special case? (In
>> the case we cannot go around PDO). Either way the test files requires
>> a manual touch to configure credentials to run.
>>
>> I'm personally fine with the simple solution, thoughts?
>
> Firebird requires the database to exist before PDO can make a connection
> and there are a number of ways to handle it, but the simple solution is
> to use the example database that comes with Firebird. What does
> complicate things though is that distributions often bundle it
> separately, and will 'improve security' by not using the default user
> login. Hence the credentials problem becomes installation dependent. A
> default install using the official Firebird distributions should work
> with the test suite using the sample database rather than the temporary
> one.

A patch would be welcome!

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Lester]

On 02/05/2019 14:35, Kalle Sommer Nielsen wrote:

Hi Christoph

Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker :

A problem is that the ext/pdo_firebird tests rely on ext/interbase to
create a test database[1], which would require everybody who intends to
run these tests to install PECL/interbase package now.  It would be
great if somebody would rewrite this, so interbase would no longer be a
dependency of the pdo_firebird tests.

[1] 


Yeah that is one thing that is kind of unfortunate and a bad practice.
However since interbase was disabled for AppVeyor, these tests had no
chance to run in a while. Looking at the actual code in testdb.inc, it
seems like it creates the database for testing purposes, I would
suppose this is due to PDO_Firebird perhaps requiring a database to
continue its connection flow in PDO itself.

I'm not sure how we can go about this, maybe a .sql file for testers
who run the test suite for schemas and then see if we can integrate
some auto importer in our CI build scripts for this special case? (In
the case we cannot go around PDO). Either way the test files requires
a manual touch to configure credentials to run.

I'm personally fine with the simple solution, thoughts?


Firebird requires the database to exist before PDO can make a connection 
and there are a number of ways to handle it, but the simple solution is 
to use the example database that comes with Firebird. What does 
complicate things though is that distributions often bundle it 
separately, and will 'improve security' by not using the default user 
login. Hence the credentials problem becomes installation dependent. A 
default install using the official Firebird distributions should work 
with the test suite using the sample database rather than the temporary 
one.


--
Lester Caine - G8HFL
-
Contact - https://lsces.co.uk/wiki/?page=contact
L.S.Caine Electronic Services - https://lsces.co.uk
EnquirySolve - https://enquirysolve.com/
Model Engineers Digital Workshop - https://medw.co.uk
Rainbow Digital Media - https://rainbowdigitalmedia.co.uk

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

Hi Kalle,

On 02.05.2019 at 15:35, Kalle Sommer Nielsen wrote:

> Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker :
>> A problem is that the ext/pdo_firebird tests rely on ext/interbase to
>> create a test database[1], which would require everybody who intends to
>> run these tests to install PECL/interbase package now.  It would be
>> great if somebody would rewrite this, so interbase would no longer be a
>> dependency of the pdo_firebird tests.
>>
>> [1] > /testdb.inc>
>
> Yeah that is one thing that is kind of unfortunate and a bad practice.
> However since interbase was disabled for AppVeyor, these tests had no
> chance to run in a while. Looking at the actual code in testdb.inc, it
> seems like it creates the database for testing purposes, I would
> suppose this is due to PDO_Firebird perhaps requiring a database to
> continue its connection flow in PDO itself.

Indeed, it seems that pdo_firebird requires to connect to an existing
database, contrary to e.g. pdo_mysql which supports DSN like
`mysql:host=localhost`, to my knowledge.  But even if pdo_firebird has
been connected to an existing database, it appears that it's not
possible to create a new database via PDO (I got something like "prepare
does not support CREATE DATABASE", even with emulated prepares turned on).

> I'm not sure how we can go about this, maybe a .sql file for testers
> who run the test suite for schemas and then see if we can integrate
> some auto importer in our CI build scripts for this special case? (In
> the case we cannot go around PDO). Either way the test files requires
> a manual touch to configure credentials to run.
>
> I'm personally fine with the simple solution, thoughts?

ACK.  Given that these test did not run on our CI (pdo_firebird is not
even built on Travis) anyway, I think a simple solution which allows
someone who wants to run the tests after some manual setup is sufficient
as a first step.  We always could improve on that later.

> (ps. Thanks for the fix for the AppVeyor part I missed)

No problemo! :)

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Hi Christoph

Den tor. 2. maj 2019 kl. 14.56 skrev Christoph M. Becker :
> A problem is that the ext/pdo_firebird tests rely on ext/interbase to
> create a test database[1], which would require everybody who intends to
> run these tests to install PECL/interbase package now.  It would be
> great if somebody would rewrite this, so interbase would no longer be a
> dependency of the pdo_firebird tests.
>
> [1]  /testdb.inc>

Yeah that is one thing that is kind of unfortunate and a bad practice.
However since interbase was disabled for AppVeyor, these tests had no
chance to run in a while. Looking at the actual code in testdb.inc, it
seems like it creates the database for testing purposes, I would
suppose this is due to PDO_Firebird perhaps requiring a database to
continue its connection flow in PDO itself.

I'm not sure how we can go about this, maybe a .sql file for testers
who run the test suite for schemas and then see if we can integrate
some auto importer in our CI build scripts for this special case? (In
the case we cannot go around PDO). Either way the test files requires
a manual touch to configure credentials to run.

I'm personally fine with the simple solution, thoughts?


(ps. Thanks for the fix for the AppVeyor part I missed)

-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Christoph M. Becker]

Hi!

On 23.04.2019 at 18:55, Kalle Sommer Nielsen wrote:

> Den tir. 9. apr. 2019 kl. 20.02 skrev Kalle Sommer Nielsen :
>
> The two weeks voting period for this RFC has passed and the RFC has
> been passed with 46-0 in favor. I will prepare relevant practical
> tasks for this RFC throughout the week.

A problem is that the ext/pdo_firebird tests rely on ext/interbase to
create a test database[1], which would require everybody who intends to
run these tests to install PECL/interbase package now.  It would be
great if somebody would rewrite this, so interbase would no longer be a
dependency of the pdo_firebird tests.

[1] 

--
Christoph M. Becker

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Hi

Den tir. 9. apr. 2019 kl. 20.02 skrev Kalle Sommer Nielsen :
>
> Evening Internals
>
> Apologies for the one day delay, but the voting for the RFC "Unbundle
> ext/interbase" is open[1]. There is only one voting choice, which
> decides if the extension should be moved to PECL.
>
> Since this started a day later than anticipated, then the voting will
> naturally run for one extra day and therefore officially close on
> tuesday, 23th of April, 2019 around noon EET.
>
>
> [1] https://wiki.php.net/start#voting

The two weeks voting period for this RFC has passed and the RFC has
been passed with 46-0 in favor. I will prepare relevant practical
tasks for this RFC throughout the week.

Thanks to everyone who voted.


-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Pierre Joye]

Hi Martin,

On Mon, Apr 15, 2019, 5:08 PM Nikita Popov  wrote:

> On Mon, Apr 15, 2019 at 11:51 AM Köditz, Martin 
> wrote:
>
> > Hello everybody,
> >
> > I want to give you the general state of the Firebird driver. At the end
> of
> > January, I agreed to continue developing the Firebird driver as a
> > maintainer. In this regard, I first took care of getting familiar with
> the
> > code and an important bug (# 72175).
> >
> > Obviously, this information has not got through to the PHP community for
> a
> > variety of reasons. Unfortunately, the project seems to be pulled away by
> > the vote to remove the driver underfoot.
> >
> > It would be nice if someone could agree with me on the further steps
> > regarding further development. I particularly need help with the
> following
> > points:
> > 1. How will I be deposited as a maintainer?
> >
> 2. Who has commit rights for changes?
> > 3. How are changes in the documentation checked in? Here are my changes
> > have not been committed for years.
> > 4. Where are the current development guidelines? I have an old book, but
> > it does not seem to reflect the current quality standards.
> >
> > Maybe it's to late. But maybe we (the Firebird and the PHP community) can
> > continue on a common path.
> >
>
> Hello Martin,
>
> The vote currently under way shouldn't change much for you: It mainly means
> that the code of the extension will be moved into a new repository and that
> the extension has to be installed using "pecl install interbase" instead of
> "./configure --with-interbase".
>
> Unless you already have one, please request a PHP git account at
> https://www.php.net/git-php.php. Once it is approved you will be granted
> access to the ext/interbase extension in php-src, as well as the new PECL
> repository for the extension once the move is completed. You can then
> commit changes using git via git.php.net.


You can also use github and upload releases in pecl.php.net.

best,
Pierre

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Dan Ackroyd]

Hi Martin,

On Mon, 15 Apr 2019 at 10:50, Köditz, Martin  wrote:
>  I agreed to continue developing the Firebird driver as a maintainer.

As mentioned previously, possibly the first thing you should do is to
make clear if you're maintaining it as something that is compatible
with Firebird, or whether you are continuing the compatibility with
InterBase.

The two pieces of software have different capabilities[*]. You seem to
be interested in maintaining it for Firebird, but the extension is
currently called 'InterBase'.

Having the supported DB change silently is quite a surprising thing to happen.

Nikita Popov wrote:
> as well as the new PECL
> repository for the extension once the move is completed.

Will that include mirroring to a github repository?

Martin, either way I would recommend setting up a github repo to use
in your workflow somewhere, as it is much easier for people to
collaborate over (and can have things like TravisCI integration) more
easily that PHP's git account can.

And a Github repo is probably a better place to discuss plans for
future support than PHP's bug tracker.

cheers
Dan
Ack


[*] https://ib-aid.com/en/articles/differences-between-firebird-and-interbase/

--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

AW: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Köditz , Martin]

I cannot find my translations too. I've create German translations for these 
files:
- ibase-add-user.xml
- ibase-delete-user.xml
- ibase-modify-user.xml

Last time I was logged in I saw it still in pending state. I thought nobody was 
able to verify in German. But now the translations are gone completely. Maybe 
someone did a garbage collection ...

Well, it wouldn't be a problem to translate again. But then the changes should 
also be incorporated.

Regards,
Martin

-Ursprüngliche Nachricht-
Von: Nikita Popov [mailto:nikita@gmail.com] 
Gesendet: Montag, 15. April 2019 12:28
An: Köditz, Martin 
Cc: internals@lists.php.net
Betreff: Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On Mon, Apr 15, 2019 at 12:17 PM Köditz, Martin 
wrote:

> Hi Nikita,
>
> > To update the documentation you can either use the editor at
> edit.php.net (useful for smaller changes and does not require 
> permissions),
> > or also request direct commit access to the documentation.
> I've added the changes via edit.php.net. But nothing happened since then.
> I think it will be a good practice to request direct access.
>
> Thank you
> Martin
>

I just tried to find your changes on edit.php.net, but didn't see anything 
related to interbase. Could you maybe provide a link to one of your patches? 
(Right click on the patch, then "View unified diff" and then click on "Direct 
link to this patch" at the top.)

Regards,
Nikita

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Nikita Popov]

On Mon, Apr 15, 2019 at 12:17 PM Köditz, Martin 
wrote:

> Hi Nikita,
>
> > To update the documentation you can either use the editor at
> edit.php.net (useful for smaller changes and does not require
> permissions),
> > or also request direct commit access to the documentation.
> I've added the changes via edit.php.net. But nothing happened since then.
> I think it will be a good practice to request direct access.
>
> Thank you
> Martin
>

I just tried to find your changes on edit.php.net, but didn't see anything
related to interbase. Could you maybe provide a link to one of your
patches? (Right click on the patch, then "View unified diff" and then click
on "Direct link to this patch" at the top.)

Regards,
Nikita

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Köditz , Martin]

Hi Nikita,

> To update the documentation you can either use the editor at edit.php.net 
> (useful for smaller changes and does not require permissions), 
> or also request direct commit access to the documentation.
I've added the changes via edit.php.net. But nothing happened since then. I 
think it will be a good practice to request direct access.

Thank you
Martin


-Ursprüngliche Nachricht-
Von: Nikita Popov [mailto:nikita@gmail.com] 
Gesendet: Montag, 15. April 2019 12:08
An: Köditz, Martin 
Cc: internals@lists.php.net
Betreff: Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

On Mon, Apr 15, 2019 at 11:51 AM Köditz, Martin 
wrote:

> Hello everybody,
>
> I want to give you the general state of the Firebird driver. At the 
> end of January, I agreed to continue developing the Firebird driver as 
> a maintainer. In this regard, I first took care of getting familiar 
> with the code and an important bug (# 72175).
>
> Obviously, this information has not got through to the PHP community 
> for a variety of reasons. Unfortunately, the project seems to be 
> pulled away by the vote to remove the driver underfoot.
>
> It would be nice if someone could agree with me on the further steps 
> regarding further development. I particularly need help with the 
> following
> points:
> 1. How will I be deposited as a maintainer?
>
2. Who has commit rights for changes?
> 3. How are changes in the documentation checked in? Here are my 
> changes have not been committed for years.
> 4. Where are the current development guidelines? I have an old book, 
> but it does not seem to reflect the current quality standards.
>
> Maybe it's to late. But maybe we (the Firebird and the PHP community) 
> can continue on a common path.
>

Hello Martin,

The vote currently under way shouldn't change much for you: It mainly means 
that the code of the extension will be moved into a new repository and that the 
extension has to be installed using "pecl install interbase" instead of 
"./configure --with-interbase".

Unless you already have one, please request a PHP git account at 
https://www.php.net/git-php.php. Once it is approved you will be granted access 
to the ext/interbase extension in php-src, as well as the new PECL repository 
for the extension once the move is completed. You can then commit changes using 
git via git.php.net.

To update the documentation you can either use the editor at edit.php.net 
(useful for smaller changes and does not require permissions), or also request 
direct commit access to the documentation.

Regards,
Nikita

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Nikita Popov]

On Mon, Apr 15, 2019 at 11:51 AM Köditz, Martin 
wrote:

> Hello everybody,
>
> I want to give you the general state of the Firebird driver. At the end of
> January, I agreed to continue developing the Firebird driver as a
> maintainer. In this regard, I first took care of getting familiar with the
> code and an important bug (# 72175).
>
> Obviously, this information has not got through to the PHP community for a
> variety of reasons. Unfortunately, the project seems to be pulled away by
> the vote to remove the driver underfoot.
>
> It would be nice if someone could agree with me on the further steps
> regarding further development. I particularly need help with the following
> points:
> 1. How will I be deposited as a maintainer?
>
2. Who has commit rights for changes?
> 3. How are changes in the documentation checked in? Here are my changes
> have not been committed for years.
> 4. Where are the current development guidelines? I have an old book, but
> it does not seem to reflect the current quality standards.
>
> Maybe it's to late. But maybe we (the Firebird and the PHP community) can
> continue on a common path.
>

Hello Martin,

The vote currently under way shouldn't change much for you: It mainly means
that the code of the extension will be moved into a new repository and that
the extension has to be installed using "pecl install interbase" instead of
"./configure --with-interbase".

Unless you already have one, please request a PHP git account at
https://www.php.net/git-php.php. Once it is approved you will be granted
access to the ext/interbase extension in php-src, as well as the new PECL
repository for the extension once the move is completed. You can then
commit changes using git via git.php.net.

To update the documentation you can either use the editor at edit.php.net
(useful for smaller changes and does not require permissions), or also
request direct commit access to the documentation.

Regards,
Nikita

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Köditz , Martin]

Hello everybody,

I want to give you the general state of the Firebird driver. At the end of 
January, I agreed to continue developing the Firebird driver as a maintainer. 
In this regard, I first took care of getting familiar with the code and an 
important bug (# 72175).

Obviously, this information has not got through to the PHP community for a 
variety of reasons. Unfortunately, the project seems to be pulled away by the 
vote to remove the driver underfoot.

It would be nice if someone could agree with me on the further steps regarding 
further development. I particularly need help with the following points:
1. How will I be deposited as a maintainer?
2. Who has commit rights for changes?
3. How are changes in the documentation checked in? Here are my changes have 
not been committed for years.
4. Where are the current development guidelines? I have an old book, but it 
does not seem to reflect the current quality standards.

Maybe it's to late. But maybe we (the Firebird and the PHP community) can 
continue on a common path.

Regards,
Martin

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Joe Watkins]

Hi Kalle,

You forgot to move to voting on the RFC index.

Cheers
Joe

On Tue, 9 Apr 2019, 19:07 Kalle Sommer Nielsen,  wrote:

> Den tir. 9. apr. 2019 kl. 20.02 skrev Kalle Sommer Nielsen  >:
> >
> > Evening Internals
> >
> > Apologies for the one day delay, but the voting for the RFC "Unbundle
> > ext/interbase" is open[1]. There is only one voting choice, which
> > decides if the extension should be moved to PECL.
> >
> > Since this started a day later than anticipated, then the voting will
> > naturally run for one extra day and therefore officially close on
> > tuesday, 23th of April, 2019 around noon EET.
>
> Apologies for the wrong link, the correct one is:
> https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase#voting
>
>
>
> --
> regards,
>
> Kalle Sommer Nielsen
> ka...@php.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

[PHP-DEV] Re: [RFC VOTE] Unbundle ext/interbase

[Kalle Sommer Nielsen]

Den tir. 9. apr. 2019 kl. 20.02 skrev Kalle Sommer Nielsen :
>
> Evening Internals
>
> Apologies for the one day delay, but the voting for the RFC "Unbundle
> ext/interbase" is open[1]. There is only one voting choice, which
> decides if the extension should be moved to PECL.
>
> Since this started a day later than anticipated, then the voting will
> naturally run for one extra day and therefore officially close on
> tuesday, 23th of April, 2019 around noon EET.

Apologies for the wrong link, the correct one is:
https://wiki.php.net/rfc/deprecate-and-remove-ext-interbase#voting



-- 
regards,

Kalle Sommer Nielsen
ka...@php.net

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php