RE: [PHP-DEV] [RFC] JIT

2019-03-15 Thread Anatol Belski
019 10:53 AM > To: internals@lists.php.net > Subject: Re: [PHP-DEV] [RFC] JIT > > Hi Internals, > > https://wiki.php.net/rfc/jit > > Now JIT also supports ZTS (checked on Linux and Windows). > Please, test and report problems. > > So, complains about JIT compa

Re: [PHP-DEV] [RFC] JIT

2019-03-15 Thread Benjamin Eberlei
On Fri, Mar 15, 2019 at 10:53 AM Dmitry Stogov wrote: > Hi Internals, > > https://wiki.php.net/rfc/jit > > Now JIT also supports ZTS (checked on Linux and Windows). > Please, test and report problems. > > So, complains about JIT compatibility matrix are satisfied. > It should be some

Re: [PHP-DEV] [RFC] JIT

2019-03-15 Thread Dmitry Stogov
Hi Internals, https://wiki.php.net/rfc/jit Now JIT also supports ZTS (checked on Linux and Windows). Please, test and report problems. So, complains about JIT compatibility matrix are satisfied. It should be some incompatibilities with ZTS on Mac, but this easily fixable. I'll spend some

RE: [PHP-DEV] [RFC] JIT

2019-03-07 Thread Anatol Belski
Hi Theodore, > -Original Message- > From: Theodore Brown > Sent: Thursday, March 7, 2019 5:11 PM > To: Anatol Belski ; Dmitry Stogov ; PHP > internals > Cc: Joe Watkins > Subject: Re: [PHP-DEV] [RFC] JIT > > On Tuesday, March 5, 2019 3:52 PM, Anatol Belski

Re: [PHP-DEV] [RFC] JIT

2019-03-07 Thread Theodore Brown
On Tuesday, March 5, 2019 3:52 PM, Anatol Belski wrote: > > On Thursday, January 31, 2019 12:43 PM, Dmitry Stogov wrote: > > > Hi Internals, > > > > > > I'm glad to finally propose including JIT into PHP. > > > > > > https://wiki.php.net/rfc/jit > > > > > > In the current state it may be

RE: [PHP-DEV] [RFC] JIT

2019-03-05 Thread Anatol Belski
. Thanks Anatol > -Original Message- > From: Dmitry Stogov > Sent: Tuesday, March 5, 2019 3:38 PM > To: PHP internals > Cc: Anatol Belski ; Joe Watkins > Subject: Re: [PHP-DEV] [RFC] JIT > > JIT also works for non-ZTS PHP Windows builds now. > &

Re: [PHP-DEV] [RFC] JIT

2019-03-05 Thread Dmitry Stogov
JIT also works for non-ZTS PHP Windows builds now. Thanks. Dmitry. From: Anatol Belski on behalf of Anatol Belski Sent: Friday, March 1, 2019 3:47:07 PM To: Dmitry Stogov; Joe Watkins Cc: PHP internals Subject: RE: [PHP-DEV] [RFC] JIT Hi, > -Origi

RE: [PHP-DEV] [RFC] JIT

2019-03-01 Thread Anatol Belski
Hi, > -Original Message- > From: Dmitry Stogov > Sent: Friday, February 22, 2019 1:49 PM > To: Joe Watkins > Cc: PHP internals ; Anatol Belski > Subject: Re: [PHP-DEV] [RFC] JIT > > Thanks to Anatol, who started working on Windows build and "enforced&qu

Re: [PHP-DEV] [RFC] JIT

2019-02-22 Thread Dmitry Stogov
might be implemented after implementation of proposed > TSRM API improvement. > > > Thanks. Dmitry. > > > > From: Dmitry Stogov mailto:dmi...@zend.com>> > Sent: Wednesday, February 13, 2019 16:07 > To:

Re: [PHP-DEV] [RFC] JIT

2019-02-22 Thread Joe Watkins
ymore. > > > ZTS support might be implemented after implementation of proposed TSRM API > improvement. > > > Thanks. Dmitry. > > > > From: Dmitry Stogov > Sent: Wednesday, February 13, 2019 16:07 > To: PHP internals > Subject: Re:

Re: [PHP-DEV] [RFC] JIT

2019-02-22 Thread Dmitry Stogov
To: PHP internals Subject: Re: [PHP-DEV] [RFC] JIT Hi Internals, According to comments, code reviews and discussions, JIT RFC was extended with few new sections. Please, consider to review the RFC once again. https://wiki.php.net/rfc/jit Any suggestion for RFC improvement are welcome. I'm not going

Re: [PHP-DEV] [RFC] JIT

2019-02-18 Thread Rasmus Schultz
> 1.3-1.5 times speed-up Dare I ask. But is this even worth while? This does not bring PHP to the level of performance where you could reasonably implement, say, interpolated image resampling or a JPEG decoder/encoder, correct? This is still orders of magnitude slower than C, am I wrong?

Re: [PHP-DEV] [RFC] JIT

2019-02-18 Thread Benjamin Eberlei
On Mon, Feb 4, 2019 at 11:48 PM Benjamin Eberlei wrote: > > > On Mon, Feb 4, 2019 at 10:29 PM Benjamin Eberlei > wrote: > >> >> >> On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov wrote: >> >>> Hi Internals, >>> >>> >>> I'm glad to finally propose including JIT into PHP. >>> >>> >>>

Re: [PHP-DEV] [RFC] JIT

2019-02-16 Thread azjezz
Hello internals. Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Wednesday, February 6, 2019 9:23 AM, Pierre Joye wrote: > On Wed, Feb 6, 2019 at 3:17 PM Dmitry Stogov dmi...@zend.com wrote: > > > On 2/5/19 10:31 PM, Kalle Sommer Nielsen wrote: > > > > > Den tir. 5.

Re: [PHP-DEV] [RFC] JIT

2019-02-15 Thread Larry Garfield
On Friday, February 15, 2019 3:36:40 AM CST Dmitry Stogov wrote: > Just two things. > > I definitely don't think, I "just made it 100x more complicated". > I hate complication, and trying to make things simpler and more > efficient. This, sometime, involves new more or less isolated subsystems

Re: [PHP-DEV] [RFC] JIT

2019-02-15 Thread Arvids Godjuks
пт, 15 февр. 2019 г. в 13:05, Benjamin Eberlei : > > > On Fri, Feb 15, 2019 at 10:37 AM Dmitry Stogov wrote: > >> Just two things. >> >> I definitely don't think, I "just made it 100x more complicated". >> I hate complication, and trying to make things simpler and more >> efficient. This,

Re: [PHP-DEV] [RFC] JIT

2019-02-15 Thread Dmitry Stogov
Just two things. I definitely don't think, I "just made it 100x more complicated". I hate complication, and trying to make things simpler and more efficient. This, sometime, involves new more or less isolated subsystems like optimizer and now JIT. Of course, they look complex, if you are not

Re: [PHP-DEV] [RFC] JIT

2019-02-15 Thread Joe Watkins
Morning Dmitry, > I told, I'm not going to do any active JIT development at this point. > Why to waste time, if it's not going to be accepted... At this point, *nobody* can imagine that PHP 8 will not have a JIT, there is no sense in saying or thinking you would be wasting your time. If you

Re: [PHP-DEV] [RFC] JIT

2019-02-15 Thread Dmitry Stogov
Hi, On 2/14/19 5:22 PM, Joe Watkins wrote: > Morning all, > > This idea of an experimental feature as complex as a JIT is dangerous. It > is not finished, and dmitry has said he's not willing to put more time into > until it's merged. That's his prerogative, and it is ours to say that we > don't

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Rowan Collins
On Thu, 14 Feb 2019 at 13:34, Arvids Godjuks wrote: > I agree with this sentiment and the general idea of shipping JIT as > experimental in 7.4 and required to build with a configure flag. > master for 8.0 is going to contain much more and be more unstable and not > practical for testing what

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Joe Watkins
Morning all, This idea of an experimental feature as complex as a JIT is dangerous. It is not finished, and dmitry has said he's not willing to put more time into until it's merged. That's his prerogative, and it is ours to say that we don't want unfinished software that only one or two people

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Dmitry Stogov
On 2/14/19 2:38 PM, Zeev Suraski wrote: > On Thu, Feb 14, 2019 at 12:19 PM Nikita Popov wrote: >> On Thu, Feb 14, 2019 at 10:43 AM Zeev Suraski wrote: >>> On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann >> * First and foremost for me: Maintenance. We are only shortly after >>

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Arvids Godjuks
чт, 14 февр. 2019 г. в 14:54, Nicolas Grekas : > > [...] I think that whether or not we include it in 7.4 > > is a tactical decision (and I'm not sure myself where I stand on it), > but I > > do think there's a reasonable case for both directions. > > > > If I may add some voice to Zeev's

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Björn Larsson
Den 2019-02-13 kl. 14:07, skrev Dmitry Stogov: Hi Internals, According to comments, code reviews and discussions, JIT RFC was extended with few new sections. Please, consider to review the RFC once again. https://wiki.php.net/rfc/jit Any suggestion for RFC improvement are welcome. I'm not

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Nicolas Grekas
> [...] I think that whether or not we include it in 7.4 > is a tactical decision (and I'm not sure myself where I stand on it), but I > do think there's a reasonable case for both directions. > If I may add some voice to Zeev's arguments, being able to play with JIT as early as possible would

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 12:17 PM Rowan Collins wrote: > On Thu, 14 Feb 2019 at 09:43, Zeev Suraski wrote: > >> Does it mean that when PHP 8.0 comes out (in roughly two years' time most >> probably), we'd be saying this is experimental? Or that only in the >> meantime, for the brave folks that

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 12:19 PM Nikita Popov wrote: > On Thu, Feb 14, 2019 at 10:43 AM Zeev Suraski wrote: > > > On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann > > wrote: > > > > > Am 31.01.2019 um 18:08 schrieb Derick Rethans: > > > > I do not believe that something major like this

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Nikita Popov
On Thu, Feb 14, 2019 at 10:43 AM Zeev Suraski wrote: > On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann > wrote: > > > Am 31.01.2019 um 18:08 schrieb Derick Rethans: > > > I do not believe that something major like this should make it into any > > > PHP 7.x release. Having it as experimental

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Rowan Collins
On Thu, 14 Feb 2019 at 09:43, Zeev Suraski wrote: > Does it mean that when PHP 8.0 comes out (in roughly two years' time most > probably), we'd be saying this is experimental? Or that only in the > meantime, for the brave folks that want to experiment PHP 8.0 ~2yrs before > it's released, we'd

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Zeev Suraski
On Thu, Feb 14, 2019 at 10:20 AM Sebastian Bergmann wrote: > Am 31.01.2019 um 18:08 schrieb Derick Rethans: > > I do not believe that something major like this should make it into any > > PHP 7.x release. Having it as experimental new feature in the master/PHP > > 8.0 branch makes the most sense

Re: [PHP-DEV] [RFC] JIT

2019-02-14 Thread Sebastian Bergmann
Am 31.01.2019 um 18:08 schrieb Derick Rethans: I do not believe that something major like this should make it into any PHP 7.x release. Having it as experimental new feature in the master/PHP 8.0 branch makes the most sense to me. ACK -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] [RFC] JIT

2019-02-13 Thread Dmitry Stogov
On 2/14/19 3:02 AM, Eugene Leonovich wrote: > On Tue, Feb 5, 2019 at 6:06 PM Bruce Weirdan > wrote: > > On Tue, Feb 5, 2019 at 8:38 AM Dmitry Stogov > wrote: > > > PHP+optimizer (-dopcache.jit_buffer_size=0):  32.29s  (100%) >

Re: [PHP-DEV] [RFC] JIT

2019-02-13 Thread Eugene Leonovich
On Tue, Feb 5, 2019 at 6:06 PM Bruce Weirdan wrote: > On Tue, Feb 5, 2019 at 8:38 AM Dmitry Stogov wrote: > > > PHP+optimizer (-dopcache.jit_buffer_size=0): 32.29s (100%) > > > PHP+optimizer+JIT (-dopcache.jit_buffer_size=5000): 30.72s (95.1%) > > > PHP+optimizer+minimalJIT

Re: [PHP-DEV] [RFC] JIT

2019-02-13 Thread Dmitry Stogov
Hi Internals, According to comments, code reviews and discussions, JIT RFC was extended with few new sections. Please, consider to review the RFC once again. https://wiki.php.net/rfc/jit Any suggestion for RFC improvement are welcome. I'm not going to invest significant time into JIT

Re: [PHP-DEV] [RFC] JIT

2019-02-06 Thread Dmitry Stogov
On 2/6/19 12:26 PM, Nikita Popov wrote: > On Mon, Feb 4, 2019 at 8:30 AM Dmitry Stogov > wrote: > > > > On 2/3/19 9:00 PM, Nikita Popov wrote: > > On Sun, Feb 3, 2019 at 5:16 PM Zeev Suraski > wrote: > > > >> >

Re: [PHP-DEV] [RFC] JIT

2019-02-06 Thread Nikita Popov
On Mon, Feb 4, 2019 at 8:30 AM Dmitry Stogov wrote: > > > On 2/3/19 9:00 PM, Nikita Popov wrote: > > On Sun, Feb 3, 2019 at 5:16 PM Zeev Suraski wrote: > > > >> > >>> On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: > >>> > >>> Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): >

Re: [PHP-DEV] [RFC] JIT

2019-02-06 Thread Pierre Joye
On Wed, Feb 6, 2019 at 3:17 PM Dmitry Stogov wrote: > On 2/5/19 10:31 PM, Kalle Sommer Nielsen wrote: > > Den tir. 5. feb. 2019 kl. 20.48 skrev Niklas Keller : > >> Shouldn't we introduce annotations instead of relying on doc comments? > > > > Yeah I'm not too happy with that approach either. I

Re: [PHP-DEV] [RFC] JIT

2019-02-06 Thread Dmitry Stogov
On 2/5/19 10:31 PM, Kalle Sommer Nielsen wrote: > Den tir. 5. feb. 2019 kl. 20.48 skrev Niklas Keller : >> Shouldn't we introduce annotations instead of relying on doc comments? > > Yeah I'm not too happy with that approach either. I would rather see > another way to do this and like you said;

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Matthew Brown
I’m not sure it’s a great real-world example - PHP Parser is much more maths-y than the vast amount of PHP code, but if your PHP-based compiler had a similar makeup it might show somewhat similar benefits. > On Feb 5, 2019, at 8:47 PM, Andrea Faulds wrote: > > Hi, > > Dmitry Stogov wrote: >>

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Andrea Faulds
Hi, Dmitry Stogov wrote: I've added info from Nikita: PHP-Parser became 1.5 times faster. That is actually a very good real-world example from my perspective and makes a better case for why JIT compilation to native code would be beneficial. I would like to write a PHP compiler in PHP

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Kalle Sommer Nielsen
Den tir. 5. feb. 2019 kl. 20.48 skrev Niklas Keller : > Shouldn't we introduce annotations instead of relying on doc comments? Yeah I'm not too happy with that approach either. I would rather see another way to do this and like you said; annotations is probably the best way to go about it as

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Niklas Keller
> > Can you give some information on if there are pre-conditions that > > must hold for a function to be jitted, or quit conditions that force > > the JIT to be reverted for a function? > > -dopcache.jit=1245 will lead to JIT only functions with @jit doc-comment > tag. It's possible to

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Bruce Weirdan
On Tue, Feb 5, 2019 at 8:38 AM Dmitry Stogov wrote: > > PHP+optimizer (-dopcache.jit_buffer_size=0): 32.29s (100%) > > PHP+optimizer+JIT (-dopcache.jit_buffer_size=5000): 30.72s (95.1%) > > PHP+optimizer+minimalJIT (-dopcache.jit_buffer_size=5000 > > -dopcache.jit=1201): 29.95s (92.7%)

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Benjamin Eberlei
On Tue, Feb 5, 2019 at 11:45 AM Dmitry Stogov wrote: > > > On 2/5/19 12:40 PM, Benjamin Eberlei wrote: > > > > > > On Tue, Feb 5, 2019 at 7:46 AM Dmitry Stogov > > wrote: > > > > > > > > On 2/5/19 1:48 AM, Benjamin Eberlei wrote: > > > > > > > > > On

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Dmitry Stogov
On 2/5/19 12:40 PM, Benjamin Eberlei wrote: > > > On Tue, Feb 5, 2019 at 7:46 AM Dmitry Stogov > wrote: > > > > On 2/5/19 1:48 AM, Benjamin Eberlei wrote: > > > > > > On Mon, Feb 4, 2019 at 10:29 PM Benjamin Eberlei >

Re: [PHP-DEV] [RFC] JIT

2019-02-05 Thread Benjamin Eberlei
On Tue, Feb 5, 2019 at 7:46 AM Dmitry Stogov wrote: > > > On 2/5/19 1:48 AM, Benjamin Eberlei wrote: > > > > > > On Mon, Feb 4, 2019 at 10:29 PM Benjamin Eberlei > > wrote: > > > > > > > > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov >

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Dmitry Stogov
On 2/5/19 1:48 AM, Benjamin Eberlei wrote: > > > On Mon, Feb 4, 2019 at 10:29 PM Benjamin Eberlei > wrote: > > > > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov > wrote: > > Hi Internals, > > > I'm glad to

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Dmitry Stogov
On 2/4/19 11:39 PM, Bruce Weirdan wrote: > After figuring out that opcache.jit_buffer_size is specified in bytes > (not in megabytes, as RFC states) Thanks for catching this. Fixed. > I got ~5% speedup running > vimeo/psalm (static analyzer) on its own codebase with default > JIT flags and

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Benjamin Eberlei
On Mon, Feb 4, 2019 at 10:29 PM Benjamin Eberlei wrote: > > > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov wrote: > >> Hi Internals, >> >> >> I'm glad to finally propose including JIT into PHP. >> >> >> https://wiki.php.net/rfc/jit >> >> >> In the current state it may be included both into

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Benjamin Eberlei
On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov wrote: > Hi Internals, > > > I'm glad to finally propose including JIT into PHP. > > > https://wiki.php.net/rfc/jit > > > In the current state it may be included both into PHP-8, where we are > going to continue active improvement, and into PHP-7.4,

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Bruce Weirdan
After figuring out that opcache.jit_buffer_size is specified in bytes (not in megabytes, as RFC states) I got ~5% speedup running vimeo/psalm (static analyzer) on its own codebase with default JIT flags and ~7.3% with minimal JIT (1201). PHP+optimizer (-dopcache.jit_buffer_size=0): 32.29s

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Nikita Popov
On Mon, Feb 4, 2019 at 3:44 PM Nikita Popov wrote: > On Mon, Feb 4, 2019 at 2:26 PM Dmitry Stogov wrote: > >> >> >> On 2/1/19 4:23 PM, Dmitry Stogov wrote: >> > >> > >> > On 2/1/19 3:09 PM, Nikita Popov wrote: >> >> On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov > >> >

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Dmitry Stogov
On 2/4/19 6:22 PM, Nikita Popov wrote: > On Mon, Feb 4, 2019 at 4:11 PM Dmitry Stogov > wrote: > > > > On 2/4/19 5:44 PM, Nikita Popov wrote: > > On Mon, Feb 4, 2019 at 2:26 PM Dmitry Stogov > >

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Eugene Leonovich
On Mon, Feb 4, 2019 at 3:45 PM Zeev Suraski wrote: > One our hopes in opening this up for comments, is that people would > actually try the code themselves and experiment with it - well beyond what > we can do ourselves. > Is there a docker image with JIT support that people can try?

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Nikita Popov
On Mon, Feb 4, 2019 at 4:11 PM Dmitry Stogov wrote: > > > On 2/4/19 5:44 PM, Nikita Popov wrote: > > On Mon, Feb 4, 2019 at 2:26 PM Dmitry Stogov > > wrote: > > > > > > > > On 2/1/19 4:23 PM, Dmitry Stogov wrote: > > > > > > > > > On 2/1/19 3:09 PM,

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Dmitry Stogov
On 2/4/19 5:44 PM, Nikita Popov wrote: > On Mon, Feb 4, 2019 at 2:26 PM Dmitry Stogov > wrote: > > > > On 2/1/19 4:23 PM, Dmitry Stogov wrote: > > > > > > On 2/1/19 3:09 PM, Nikita Popov wrote: > >> On Thu, Jan 31, 2019 at 10:44 AM Dmitry

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Dmitry Stogov
On 2/4/19 1:32 PM, Andrea Faulds wrote: > Dmitry Stogov wrote: >> Hi Internals, >> >> >> I'm glad to finally propose including JIT into PHP. >> >> >> https://wiki.php.net/rfc/jit >> >> >> In the current state it may be included both into PHP-8, where we are >> going to continue active

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Nikita Popov
On Mon, Feb 4, 2019 at 2:26 PM Dmitry Stogov wrote: > > > On 2/1/19 4:23 PM, Dmitry Stogov wrote: > > > > > > On 2/1/19 3:09 PM, Nikita Popov wrote: > >> On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov >> > wrote: > >> > >> Hi Internals, > >> > >> > >> I'm glad

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Zeev Suraski
On Mon, Feb 4, 2019 at 12:33 PM Andrea Faulds wrote: > A concern I have with the current RFC is a lack of a good case for why > it should be necessary; While this is a subjective opinion, it's definitely a valid one. Unlike phpng (PHP 7) which was a slam dunk - JIT isn't - and whether or not

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Dmitry Stogov
On 2/1/19 4:23 PM, Dmitry Stogov wrote: > > > On 2/1/19 3:09 PM, Nikita Popov wrote: >> On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov > > wrote: >> >> Hi Internals, >> >> >> I'm glad to finally propose including JIT into PHP. >> >> >>

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Andrea Faulds
Dmitry Stogov wrote: Hi Internals, I'm glad to finally propose including JIT into PHP. https://wiki.php.net/rfc/jit In the current state it may be included both into PHP-8, where we are going to continue active improvement, and into PHP-7.4, as an experimental feature. Thanks. Dmitry.

Re: [PHP-DEV] [RFC] JIT

2019-02-04 Thread Nikita Popov
On Mon, Feb 4, 2019 at 8:30 AM Dmitry Stogov wrote: > > > On 2/3/19 9:00 PM, Nikita Popov wrote: > > On Sun, Feb 3, 2019 at 5:16 PM Zeev Suraski wrote: > > > >> > >>> On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: > >>> > >>> Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): >

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Dmitry Stogov
On 2/3/19 9:00 PM, Nikita Popov wrote: > On Sun, Feb 3, 2019 at 5:16 PM Zeev Suraski wrote: > >> >>> On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: >>> >>> Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): How is that related? >>> >>> It is directly related with

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Dmitry Stogov
On 2/1/19 7:30 PM, Larry Garfield wrote: > On Friday, February 1, 2019 2:41:06 AM CST Dmitry Stogov wrote: >> On 2/1/19 3:29 AM, Larry Garfield wrote: > >>> Question from a non-compiler-engineer: Could we end up in a situation >>> where >>> future language features (in 8.3 or something) are

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Andrey Hristov
Guys, On 3.02.19 г. 18:16 ч., Zeev Suraski wrote: On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): How is that related? It is directly related with your statement that "developers with other host OSs still use Linux for the

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Nikita Popov
On Sun, Feb 3, 2019 at 5:16 PM Zeev Suraski wrote: > > > On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: > > > > Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): > >> > >> > >> How is that related? > > > > It is directly related with your statement that "developers with other > >

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Zeev Suraski
> On 3 Feb 2019, at 16:43, Jan Ehrhardt wrote: > > Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): >> >> >> How is that related? > > It is directly related with your statement that "developers with other > host OSs still use Linux for the actual PHP development". They don't

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Lester Caine
On 03/02/2019 06:51, Zeev Suraski wrote: While this is anecdotal, I think you might find a different perspective from user group organizers. I've encountered many user group members over the years who run PHP on Windows. It's more common that they develop on Windows and deploy to Linux, but I

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Jan Ehrhardt
Zeev Suraski in php.internals (Sun, 3 Feb 2019 11:02:56 +): >Jan Ehrhardt in php.internals (Sun, 03 Feb 2019 11:47:09 +0100): >>Hi Zeev, >> >>Zeev Suraski in php.internals (Sun, 3 Feb 2019 07:05:49 +): >>>2. Most PHP production workloads are on Linux, and as far as I can tell >>>this

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Zeev Suraski
On 3 Feb 2019, at 12:47, Jan Ehrhardt mailto:php...@ehrhardt.nl>> wrote: Hi Zeev, Zeev Suraski in php.internals (Sun, 3 Feb 2019 07:05:49 +): 2. Most PHP production workloads are on Linux, and as far as I can tell this trend is only growing over the years - with virtual machines and now

Re: [PHP-DEV] [RFC] JIT

2019-02-03 Thread Jan Ehrhardt
Hi Zeev, Zeev Suraski in php.internals (Sun, 3 Feb 2019 07:05:49 +): >2. Most PHP production workloads are on Linux, and as far as I can tell >this trend is only growing over the years - with virtual machines and >now containers becoming more and more popular - meaning that even >developers

Re: [PHP-DEV] [RFC] JIT

2019-02-02 Thread Zeev Suraski
On 1 Feb 2019, at 18:30, Larry Garfield mailto:la...@garfieldtech.com>> wrote: I'm... not sure how that answers my question? I'm saying "if we had a VM+JIT, and the JIT part made feature X acceptably fast but it wasn't acceptably fast with just the VM, is that a problem?" Or is that a

Re: [PHP-DEV] [RFC] JIT

2019-02-02 Thread Zeev Suraski
> On 3 Feb 2019, at 7:17, Ben Ramsey wrote: > >> On Thu, Jan 31, 2019, at 11:04, Zeev Suraski wrote: >> I'm honestly a bit perplexed by how many people here viewing Windows >> support as a must have, while at the same time I think we all agree PHP is >> very scarcely found on production Windows

Re: [PHP-DEV] [RFC] JIT

2019-02-02 Thread Ben Ramsey
On Thu, Jan 31, 2019, at 11:04, Zeev Suraski wrote: > I'm honestly a bit perplexed by how many people here viewing Windows > support as a must have, while at the same time I think we all agree PHP is > very scarcely found on production Windows servers, and JIT is a > predominantly production

Re: [PHP-DEV] [RFC] JIT

2019-02-02 Thread Andi Gutmans
Pierre Joye Cc: PHP internals Subject: Re: [PHP-DEV] [RFC] JIT Pierre, On 1.02.19 г. 13:12 ч., Pierre Joye wrote: > On Thu, Jan 31, 2019, 11:39 PM Dmitry Stogov >> >> >> I don't see any problems with including JIT without Windows support. >> Windows runs PHP much slow

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Pierre Joye
On Sat, Feb 2, 2019, 12:46 AM Levi Morrison I strongly with Nikita's points on cost/benefit analysis. I have > written a lot but thrown it away because I think this point is so > important: > > It appears that the JIT does not work on Clang or MSVC compilers. It must some changes needed for php

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Levi Morrison
On Thu, Jan 31, 2019 at 9:01 AM Nikita Popov wrote: > > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov wrote: > > > Hi Internals, > > > > > > I'm glad to finally propose including JIT into PHP. > > > > > > https://wiki.php.net/rfc/jit > > > > > > In the current state it may be included both into

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Rowan Collins
On Fri, 1 Feb 2019 at 13:12, Dmitry Stogov wrote: > >I'm not keen on the idea of merging this into 7.4, for various > > reasons that don't need to be repeated. > > OK. It's not only your opinion. > You may vote against, and persuade others. > I think it would be interesting to clarify the

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Larry Garfield
On Friday, February 1, 2019 2:41:06 AM CST Dmitry Stogov wrote: > On 2/1/19 3:29 AM, Larry Garfield wrote: > > Question from a non-compiler-engineer: Could we end up in a situation > > where > > future language features (in 8.3 or something) are only performant on JIT- > > enabled platforms? I

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Dmitry Stogov
On 2/1/19 4:23 PM, Nikita Popov wrote: > On Fri, Feb 1, 2019 at 2:12 PM Dmitry Stogov > wrote: > > > > On 2/1/19 11:55 AM, Joe Watkins wrote: > > Morning Dmitry, and internals, > > > > This is marvellous stuff, truly brilliant. I particularly >

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Dmitry Stogov
On 2/1/19 3:09 PM, Nikita Popov wrote: > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov > wrote: > > Hi Internals, > > > I'm glad to finally propose including JIT into PHP. > > > https://wiki.php.net/rfc/jit > > > In the current state it may be

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Nikita Popov
On Fri, Feb 1, 2019 at 2:12 PM Dmitry Stogov wrote: > > > On 2/1/19 11:55 AM, Joe Watkins wrote: > > Morning Dmitry, and internals, > > > > This is marvellous stuff, truly brilliant. I particularly appreciate the > > non-intrusive approach of setting jit'd code as the opcode handler, this > >

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Dmitry Stogov
On 2/1/19 2:12 PM, Pierre Joye wrote: > > > On Thu, Jan 31, 2019, 11:39 PM Dmitry Stogov wrote: > > > > I don't see any problems with including JIT without Windows support. > Windows runs PHP much slower any way. > > > How so? I tend to disagree here.

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Dmitry Stogov
On 2/1/19 11:55 AM, Joe Watkins wrote: > Morning Dmitry, and internals, > > This is marvellous stuff, truly brilliant. I particularly appreciate the > non-intrusive approach of setting jit'd code as the opcode handler, this > makes life a little easier for hacky extension authors, I think. >

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Nikita Popov
On Fri, Feb 1, 2019 at 1:09 PM Nikita Popov wrote: > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov wrote: > >> Hi Internals, >> >> >> I'm glad to finally propose including JIT into PHP. >> >> >> https://wiki.php.net/rfc/jit >> >> >> In the current state it may be included both into PHP-8,

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Nikita Popov
On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov wrote: > Hi Internals, > > > I'm glad to finally propose including JIT into PHP. > > > https://wiki.php.net/rfc/jit > > > In the current state it may be included both into PHP-8, where we are > going to continue active improvement, and into PHP-7.4,

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Andrey Hristov
Pierre, On 1.02.19 г. 13:12 ч., Pierre Joye wrote: On Thu, Jan 31, 2019, 11:39 PM Dmitry Stogov I don't see any problems with including JIT without Windows support. Windows runs PHP much slower any way. How so? I tend to disagree here. Except if recent changes affect Windows indirectly

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Pierre Joye
On Thu, Jan 31, 2019, 11:39 PM Dmitry Stogov > > I don't see any problems with including JIT without Windows support. > Windows runs PHP much slower any way. > How so? I tend to disagree here. Except if recent changes affect Windows indirectly (as in optimization done on linux only). Also while

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Andrey Hristov
Hi, On 31.01.19 г. 18:47 ч., Kalle Sommer Nielsen wrote: Den tor. 31. jan. 2019 kl. 18.39 skrev Dmitry Stogov : On 1/31/19 7:01 PM, Nikita Popov wrote: On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov mailto:dmi...@zend.com>> wrote: Hi Internals, I'm glad to finally propose

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Joe Watkins
Morning Dmitry, and internals, This is marvellous stuff, truly brilliant. I particularly appreciate the non-intrusive approach of setting jit'd code as the opcode handler, this makes life a little easier for hacky extension authors, I think. As others have said: I don't like the idea of

Re: [PHP-DEV] [RFC] JIT

2019-02-01 Thread Dmitry Stogov
On 2/1/19 3:29 AM, Larry Garfield wrote: > On Thursday, January 31, 2019 12:30:52 PM CST Chase Peeler wrote: >> On Thu, Jan 31, 2019 at 12:04 PM Zeev Suraski wrote: >>> On Thu, Jan 31, 2019 at 6:47 PM Kalle Sommer Nielsen >>> >>> wrote: Without my usual Windows bias, I do believe it is a

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Larry Garfield
On Thursday, January 31, 2019 12:30:52 PM CST Chase Peeler wrote: > On Thu, Jan 31, 2019 at 12:04 PM Zeev Suraski wrote: > > On Thu, Jan 31, 2019 at 6:47 PM Kalle Sommer Nielsen > > > > wrote: > > > Without my usual Windows bias, I do believe it is a considerable fact > > > like Nikita pointed

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Kalle Sommer Nielsen
Den tor. 31. jan. 2019 kl. 19.04 skrev Zeev Suraski : > As long as we can agree that very few actually deploy on Windows, I think > we're on solid grounds. > As the JIT implementation is likely to have at least some significant > differences compared to Linux, I'm not sure what testing it on

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Dmitry Stogov
On 1/31/19 9:12 PM, Derick Rethans wrote: > On Thu, 31 Jan 2019, Dmitry Stogov wrote: > >> >> >> On 1/31/19 8:08 PM, Derick Rethans wrote: >>> On Thu, 31 Jan 2019, Dmitry Stogov wrote: >>> I'm glad to finally propose including JIT into PHP. https://wiki.php.net/rfc/jit >>> >>> I

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Chase Peeler
On Thu, Jan 31, 2019 at 12:04 PM Zeev Suraski wrote: > On Thu, Jan 31, 2019 at 6:47 PM Kalle Sommer Nielsen > wrote: > > > Without my usual Windows bias, I do believe it is a considerable fact > > like Nikita pointed out as Windows is a first class citizen in terms > > of operating systems we

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Derick Rethans
On Thu, 31 Jan 2019, Dmitry Stogov wrote: > > > On 1/31/19 8:08 PM, Derick Rethans wrote: > > On Thu, 31 Jan 2019, Dmitry Stogov wrote: > > > >> I'm glad to finally propose including JIT into PHP. > >> > >> https://wiki.php.net/rfc/jit > > > > I don't see anywhere in this RFC how it would

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Dmitry Stogov
On 1/31/19 8:08 PM, Derick Rethans wrote: > On Thu, 31 Jan 2019, Dmitry Stogov wrote: > >> I'm glad to finally propose including JIT into PHP. >> >> https://wiki.php.net/rfc/jit > > I don't see anywhere in this RFC how it would affect thigns that do > sneaky things with internals, such as

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Derick Rethans
On Thu, 31 Jan 2019, Dmitry Stogov wrote: > I'm glad to finally propose including JIT into PHP. > > https://wiki.php.net/rfc/jit I don't see anywhere in this RFC how it would affect thigns that do sneaky things with internals, such as Xdebug. How is that going to be affected? > In the

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Zeev Suraski
On Thu, Jan 31, 2019 at 6:47 PM Kalle Sommer Nielsen wrote: > Without my usual Windows bias, I do believe it is a considerable fact > like Nikita pointed out as Windows is a first class citizen in terms > of operating systems we support. While PHP on Windows may not have the > speed that the

Re: [PHP-DEV] [RFC] JIT

2019-01-31 Thread Kalle Sommer Nielsen
Den tor. 31. jan. 2019 kl. 18.39 skrev Dmitry Stogov : > > > > On 1/31/19 7:01 PM, Nikita Popov wrote: > > On Thu, Jan 31, 2019 at 10:44 AM Dmitry Stogov > > wrote: > > > > Hi Internals, > > > > > > I'm glad to finally propose including JIT into PHP. > > > > > >

  1   2   >