[jira] [Commented] (ARTEMIS-1176) Use text messages for management reply messages

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030646#comment-16030646
 ] 

ASF GitHub Bot commented on ARTEMIS-1176:
-

GitHub user gnodet opened a pull request:

https://github.com/apache/activemq-artemis/pull/1305

ARTEMIS-1176 - Turn management reply messages into text messages



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gnodet/activemq-artemis mgmt-reply-message

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1305.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1305


commit c2fca338c2b3a7fbf19ec7927a831d9a0f5418fb
Author: Guillaume Nodet 
Date:   2017-05-19T08:00:32Z

[ARTEMIS-1176] Turn management reply messages into text messages

commit 2d646df0449273c7a6b3e644bbe572c5bd4756cc
Author: Guillaume Nodet 
Date:   2017-05-31T05:14:07Z

[ARTEMIS-1176] Fix extraction of management results from text messages




> Use text messages for management reply messages
> ---
>
> Key: ARTEMIS-1176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1176
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030352#comment-16030352
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1295
  
what I am missing:

- doc how to use this...  (is that internal only)?
- how to read the file...


I am a bit confused with the file format...


Also, it would be nice to be allowed to configure where the file would be 
generated.


> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1186) Consumer.receive hangs if http acceptor with non-zero batch-delay is configured

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030326#comment-16030326
 ] 

ASF GitHub Bot commented on ARTEMIS-1186:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1297


> Consumer.receive hangs if http acceptor with non-zero batch-delay is 
> configured
> ---
>
> Key: ARTEMIS-1186
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1186
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Tomas Hofman
>
> Test scenario:
> # Call consumer.receive(1000) on empty queue.
> # Check whether receive call is unblocked after the 1 second.
> Issue: The receive call is not unblocked.
> I hit the issue which was initially reported in JBEAP-6443. I found out that 
> the issue is somehow related to http connectors/acceptors and {{batch-delay}} 
> parameter. I am able to reproduce it only if a client connects via 
> http-connector with non-zero batch-delay. When I tried classic 
> {{remote-connector}}, everything worked with both zero and non-zero 
> {{batch-delay}}.
> I am able to reproduce the issue with both Artemis 1.1 (EAP 7.0.3) and 
> Artemis 1.4.
> From the thread dump, you can see where the client hangs.
> {code}
> Stack trace of thread: Thread[Thread-10,5,main]
> ---java.lang.Object.wait(Native Method)
> ---org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.receive(ClientConsumerImpl.java:258)
> ---org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.receive(ClientConsumerImpl.java:391)
> ---org.apache.activemq.artemis.jms.client.ActiveMQMessageConsumer.getMessage(ActiveMQMessageConsumer.java:198)
> ---org.apache.activemq.artemis.jms.client.ActiveMQMessageConsumer.receive(ActiveMQMessageConsumer.java:122)
> ---org.jboss.qa.hornetq.apps.clients.Receiver11.receiveMessage(Receiver11.java:140)
> ---org.jboss.qa.hornetq.apps.clients.ReceiverAutoAck.run(ReceiverAutoAck.java:75)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1186) Consumer.receive hangs if http acceptor with non-zero batch-delay is configured

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030325#comment-16030325
 ] 

ASF subversion and git services commented on ARTEMIS-1186:
--

Commit 9b5440e5a4a381d17e475df377a6eef56812cf83 in activemq-artemis's branch 
refs/heads/master from [~thofman]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9b5440e ]

ARTEMIS-1186 Consumer.receive hangs if http acceptor with non-zero batch-delay 
is configured


> Consumer.receive hangs if http acceptor with non-zero batch-delay is 
> configured
> ---
>
> Key: ARTEMIS-1186
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1186
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Tomas Hofman
>
> Test scenario:
> # Call consumer.receive(1000) on empty queue.
> # Check whether receive call is unblocked after the 1 second.
> Issue: The receive call is not unblocked.
> I hit the issue which was initially reported in JBEAP-6443. I found out that 
> the issue is somehow related to http connectors/acceptors and {{batch-delay}} 
> parameter. I am able to reproduce it only if a client connects via 
> http-connector with non-zero batch-delay. When I tried classic 
> {{remote-connector}}, everything worked with both zero and non-zero 
> {{batch-delay}}.
> I am able to reproduce the issue with both Artemis 1.1 (EAP 7.0.3) and 
> Artemis 1.4.
> From the thread dump, you can see where the client hangs.
> {code}
> Stack trace of thread: Thread[Thread-10,5,main]
> ---java.lang.Object.wait(Native Method)
> ---org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.receive(ClientConsumerImpl.java:258)
> ---org.apache.activemq.artemis.core.client.impl.ClientConsumerImpl.receive(ClientConsumerImpl.java:391)
> ---org.apache.activemq.artemis.jms.client.ActiveMQMessageConsumer.getMessage(ActiveMQMessageConsumer.java:198)
> ---org.apache.activemq.artemis.jms.client.ActiveMQMessageConsumer.receive(ActiveMQMessageConsumer.java:122)
> ---org.jboss.qa.hornetq.apps.clients.Receiver11.receiveMessage(Receiver11.java:140)
> ---org.jboss.qa.hornetq.apps.clients.ReceiverAutoAck.run(ReceiverAutoAck.java:75)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1187) Incompatible version when recreating a session with older server

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030312#comment-16030312
 ] 

ASF GitHub Bot commented on ARTEMIS-1187:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1298#discussion_r119236680
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
 ---
@@ -686,7 +686,7 @@ protected CreateSessionMessage newCreateSession(String 
username,
boolean autoCommitSends,
boolean autoCommitAcks,
boolean preAcknowledge) 
{
-  return new CreateSessionMessage(name, sessionChannel.getID(), 
VersionLoader.getVersion().getIncrementingVersion(), username, password, 
minLargeMessageSize, xa, autoCommitSends, autoCommitAcks, preAcknowledge, 
confirmationWindow, null);
+  return new CreateSessionMessage(name, sessionChannel.getID(), 
serverVersion, username, password, minLargeMessageSize, xa, autoCommitSends, 
autoCommitAcks, preAcknowledge, confirmationWindow, null);
--- End diff --

I'm not sure about this... the purpose is the client to tell the server 
which version is being used... it looks wrong to me.


> Incompatible version when recreating a session with older server
> 
>
> Key: ARTEMIS-1187
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1187
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Tomas Hofman
>
> 1.5.x client is able to connect to 1.1.x server. However, when server is 
> reloaded following error occurs:
> {noformat}
> 11:42:29,400 Thread-0 (ActiveMQ-client-global-threads-1319762469) ERROR 
> [org.apache.activemq.artemis.core.client.impl.ClientSessionImpl:993] 
> AMQ214003: Failed to handle failover
> 
> ActiveMQIncompatibleClientServerException[errorType=INCOMPATIBLE_CLIENT_SERVER_VERSIONS
>  message=AMQ119033: Server and client versions incompatible]
> at 
> org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:407)
> at 
> org.apache.activemq.artemis.core.protocol.core.impl.ChannelImpl.sendBlocking(ChannelImpl.java:318)
> at 
> org.apache.activemq.artemis.core.protocol.core.impl.ActiveMQSessionContext.recreateSession(ActiveMQSessionContext.java:637)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionImpl.handleFailover(ClientSessionImpl.java:958)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.reconnectSessions(ClientSessionFactoryImpl.java:771)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.failoverOrReconnect(ClientSessionFactoryImpl.java:614)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.handleConnectionFailure(ClientSessionFactoryImpl.java:504)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl.access$500(ClientSessionFactoryImpl.java:72)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$DelegatingFailureListener.connectionFailed(ClientSessionFactoryImpl.java:1165)
> at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.callFailureListeners(AbstractRemotingConnection.java:67)
> at 
> org.apache.activemq.artemis.core.protocol.core.impl.RemotingConnectionImpl.fail(RemotingConnectionImpl.java:207)
> at 
> org.apache.activemq.artemis.spi.core.protocol.AbstractRemotingConnection.fail(AbstractRemotingConnection.java:215)
> at 
> org.apache.activemq.artemis.core.client.impl.ClientSessionFactoryImpl$CloseRunnable.run(ClientSessionFactoryImpl.java:996)
> at 
> org.apache.activemq.artemis.utils.OrderedExecutorFactory$OrderedExecutor$ExecutorTask.run(OrderedExecutorFactory.java:101)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> This works correctly with 1.5 server and old 1.1 client.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1190) Long/int type mismatch in JDBCSequentialFile.setWritePosition

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030308#comment-16030308
 ] 

ASF subversion and git services commented on ARTEMIS-1190:
--

Commit 69740a987d580c994a287ba533ae34d1bad407f1 in activemq-artemis's branch 
refs/heads/master from [~eduda]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=69740a9 ]

ARTEMIS-1190 Long/int type mismatch in JDBCSequentialFile.setWritePosition


> Long/int type mismatch in JDBCSequentialFile.setWritePosition
> -
>
> Key: ARTEMIS-1190
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1190
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> In the {{JDBCSequentialFile.setWritePosition}} there is mismatch between 
> types. The parameter of the method has type {{int}} but the private field has 
> type {{long}}.
> {code:java}
> private long writePosition = 0;
> void setWritePosition(int writePosition) {
>this.writePosition = writePosition;
> }
> {code}
> Because of this in {{JDBCSequentialFileFactoryDriver.loadFile}} the long is 
> unnecessarily retype to int.
> {code:java}
> public void loadFile(JDBCSequentialFile file) throws SQLException {
> synchronized (connection) {
>connection.setAutoCommit(false);
>readLargeObject.setLong(1, file.getId());
>try (ResultSet rs = readLargeObject.executeQuery()) {
>   if (rs.next()) {
>  Blob blob = rs.getBlob(1);
>  if (blob != null) {
> file.setWritePosition((int) blob.length());
>  } else {
> logger.warn("ERROR NO BLOB FOR FILE" + "File: " + 
> file.getFileName() + " " + file.getId());
>  }
>   }
>   connection.commit();
>} catch (SQLException e) {
>   connection.rollback();
>   throw e;
>}
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1190) Long/int type mismatch in JDBCSequentialFile.setWritePosition

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030309#comment-16030309
 ] 

ASF GitHub Bot commented on ARTEMIS-1190:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1302


> Long/int type mismatch in JDBCSequentialFile.setWritePosition
> -
>
> Key: ARTEMIS-1190
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1190
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> In the {{JDBCSequentialFile.setWritePosition}} there is mismatch between 
> types. The parameter of the method has type {{int}} but the private field has 
> type {{long}}.
> {code:java}
> private long writePosition = 0;
> void setWritePosition(int writePosition) {
>this.writePosition = writePosition;
> }
> {code}
> Because of this in {{JDBCSequentialFileFactoryDriver.loadFile}} the long is 
> unnecessarily retype to int.
> {code:java}
> public void loadFile(JDBCSequentialFile file) throws SQLException {
> synchronized (connection) {
>connection.setAutoCommit(false);
>readLargeObject.setLong(1, file.getId());
>try (ResultSet rs = readLargeObject.executeQuery()) {
>   if (rs.next()) {
>  Blob blob = rs.getBlob(1);
>  if (blob != null) {
> file.setWritePosition((int) blob.length());
>  } else {
> logger.warn("ERROR NO BLOB FOR FILE" + "File: " + 
> file.getFileName() + " " + file.getId());
>  }
>   }
>   connection.commit();
>} catch (SQLException e) {
>   connection.rollback();
>   throw e;
>}
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1195) Artemis.create filters should be independent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030305#comment-16030305
 ] 

ASF GitHub Bot commented on ARTEMIS-1195:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1303


> Artemis.create filters should be independent
> 
>
> Key: ARTEMIS-1195
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1195
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> Filters should be independent from each other entries.
> Once a file is read, the filters should be already applied.. always. no 
> dependency between them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1195) Artemis.create filters should be independent

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030303#comment-16030303
 ] 

ASF subversion and git services commented on ARTEMIS-1195:
--

Commit 91979980d946e0bcf91f8fbe7caa22588f8b3e37 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=9197998 ]

ARTEMIS-1195 Filters should be independent on create

This closes #1301

This commit replaces #1301


> Artemis.create filters should be independent
> 
>
> Key: ARTEMIS-1195
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1195
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> Filters should be independent from each other entries.
> Once a file is read, the filters should be already applied.. always. no 
> dependency between them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1195) Artemis.create filters should be independent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030146#comment-16030146
 ] 

ASF GitHub Bot commented on ARTEMIS-1195:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1303
  
It doesn't hurt to have the Hashmap as  linkedHashMap anyways.. so I will 
also import that commit.


> Artemis.create filters should be independent
> 
>
> Key: ARTEMIS-1195
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1195
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> Filters should be independent from each other entries.
> Once a file is read, the filters should be already applied.. always. no 
> dependency between them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16030119#comment-16030119
 ] 

ASF subversion and git services commented on ARTEMIS-1189:
--

Commit d4a5c70aa5eb51f3d2a36132f531566b62cf9959 in activemq-artemis's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=d4a5c70 ]

ARTEMIS-1189 fixing checkstyle


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1138) OSGI Netty Epoll Fix

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1138.
-

> OSGI Netty Epoll Fix
> 
>
> Key: ARTEMIS-1138
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1138
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: osgi
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.1.0
>
>
> I was going to release today, but ArtemisFeatureTest is failing *... I
> don't want to release with that failure (Karaf integration wouldn't
> work).
>  
> *=https://github.com/apache/activemq-artemis/blob/master/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/karaf/ArtemisFeatureTest.java
> The Current failure is because of the missing epoll package from netty.
> org.osgi.service.resolver.ResolutionException: Unable to resolve root:
> missing requirement [root] osgi.identity; osgi.identity=artemis;
> type=karaf.feature; version="[2.1.0.SNAPSHOT,2.1.0.SNAPSHOT]";
> filter:="(&(osgi.identity=artemis)(type=karaf.feature)(version>=2.1.0.SNAPSHOT)(version<=2.1.0.SNAPSHOT))"
> [caused by: Unable to resolve artemis/2.1.0.SNAPSHOT: missing
> requirement [artemis/2.1.0.SNAPSHOT] osgi.identity;
> osgi.identity=artemis-amqp; type=karaf.feature [caused by: Unable to
> resolve artemis-amqp/2.1.0.SNAPSHOT: missing requirement
> [artemis-amqp/2.1.0.SNAPSHOT] osgi.identity;
> osgi.identity=org.apache.activemq.artemis-amqp-protocol;
> type=osgi.bundle; version="[2.1.0.SNAPSHOT,2.1.0.SNAPSHOT]";
> resolution:=mandatory [caused by: Unable to resolve
> org.apache.activemq.artemis-amqp-protocol/2.1.0.SNAPSHOT: missing
> requirement [org.apache.activemq.artemis-amqp-protocol/2.1.0.SNAPSHOT]
> osgi.wiring.package;
> filter:="(osgi.wiring.package=org.apache.activemq.artemis.api.core)"
> [caused by: Unable to resolve
> org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT: missing
> requirement [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> osgi.wiring.package;
> filter:="(osgi.wiring.package=io.netty.channel.epoll)"
> So, if I edited features.xml and add this:
> mvn:io.netty/netty-transport-native-epoll/${netty.version}
> I will get a different error... and I can't get past that...
> Anyone have any ideas... please?
> org.osgi.service.resolver.ResolutionException: Uses constraint
> violation. Unable to resolve resource
> org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT] because it is
> exposed to package 'io.netty.buffer' from resources
> org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT] and
> io.netty.buffer [io.netty.buffer/4.1.10.Final] via two dependency
> chains.
> Chain 1:
>   org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> import: 
> (&(osgi.wiring.package=io.netty.buffer)(version>=2.1.0)(!(version>=3.0.0)))
>  |
> export: osgi.wiring.package: io.netty.buffer
>   org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> Chain 2:
>   org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> import: (osgi.wiring.package=io.netty.bootstrap)
>  |
> export: osgi.wiring.package=io.netty.bootstrap; uses:=io.netty.buffer
>   io.netty.transport [io.netty.transport/4.1.10.Final]
> import: 
> (&(osgi.wiring.package=io.netty.buffer)(version>=4.1.0)(!(version>=5.0.0)))
> -- 
> Clebert Suconic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-994) Support Netty Native Epoll on Linux

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-994.


> Support Netty Native Epoll on Linux
> ---
>
> Key: ARTEMIS-994
> URL: https://issues.apache.org/jira/browse/ARTEMIS-994
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 1.5.3, 2.0.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.1.0
>
>
> Netty has support for native epoll, this is available only on linux systems. 
> This is more performant.
> http://netty.io/wiki/native-transports.html
> This is inline with supporting asyncio with libaio using such native feature 
> to bring perfomance benefits to artemis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1138) OSGI Netty Epoll Fix

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-1138:
-

Assignee: Michael Andre Pearce

> OSGI Netty Epoll Fix
> 
>
> Key: ARTEMIS-1138
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1138
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: osgi
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.1.0
>
>
> I was going to release today, but ArtemisFeatureTest is failing *... I
> don't want to release with that failure (Karaf integration wouldn't
> work).
>  
> *=https://github.com/apache/activemq-artemis/blob/master/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/karaf/ArtemisFeatureTest.java
> The Current failure is because of the missing epoll package from netty.
> org.osgi.service.resolver.ResolutionException: Unable to resolve root:
> missing requirement [root] osgi.identity; osgi.identity=artemis;
> type=karaf.feature; version="[2.1.0.SNAPSHOT,2.1.0.SNAPSHOT]";
> filter:="(&(osgi.identity=artemis)(type=karaf.feature)(version>=2.1.0.SNAPSHOT)(version<=2.1.0.SNAPSHOT))"
> [caused by: Unable to resolve artemis/2.1.0.SNAPSHOT: missing
> requirement [artemis/2.1.0.SNAPSHOT] osgi.identity;
> osgi.identity=artemis-amqp; type=karaf.feature [caused by: Unable to
> resolve artemis-amqp/2.1.0.SNAPSHOT: missing requirement
> [artemis-amqp/2.1.0.SNAPSHOT] osgi.identity;
> osgi.identity=org.apache.activemq.artemis-amqp-protocol;
> type=osgi.bundle; version="[2.1.0.SNAPSHOT,2.1.0.SNAPSHOT]";
> resolution:=mandatory [caused by: Unable to resolve
> org.apache.activemq.artemis-amqp-protocol/2.1.0.SNAPSHOT: missing
> requirement [org.apache.activemq.artemis-amqp-protocol/2.1.0.SNAPSHOT]
> osgi.wiring.package;
> filter:="(osgi.wiring.package=org.apache.activemq.artemis.api.core)"
> [caused by: Unable to resolve
> org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT: missing
> requirement [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> osgi.wiring.package;
> filter:="(osgi.wiring.package=io.netty.channel.epoll)"
> So, if I edited features.xml and add this:
> mvn:io.netty/netty-transport-native-epoll/${netty.version}
> I will get a different error... and I can't get past that...
> Anyone have any ideas... please?
> org.osgi.service.resolver.ResolutionException: Uses constraint
> violation. Unable to resolve resource
> org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT] because it is
> exposed to package 'io.netty.buffer' from resources
> org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT] and
> io.netty.buffer [io.netty.buffer/4.1.10.Final] via two dependency
> chains.
> Chain 1:
>   org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> import: 
> (&(osgi.wiring.package=io.netty.buffer)(version>=2.1.0)(!(version>=3.0.0)))
>  |
> export: osgi.wiring.package: io.netty.buffer
>   org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> Chain 2:
>   org.apache.activemq.artemis-server-osgi
> [org.apache.activemq.artemis-server-osgi/2.1.0.SNAPSHOT]
> import: (osgi.wiring.package=io.netty.bootstrap)
>  |
> export: osgi.wiring.package=io.netty.bootstrap; uses:=io.netty.buffer
>   io.netty.transport [io.netty.transport/4.1.10.Final]
> import: 
> (&(osgi.wiring.package=io.netty.buffer)(version>=4.1.0)(!(version>=5.0.0)))
> -- 
> Clebert Suconic



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-994) Support Netty Native Epoll on Linux

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-994:


Assignee: Michael Andre Pearce

> Support Netty Native Epoll on Linux
> ---
>
> Key: ARTEMIS-994
> URL: https://issues.apache.org/jira/browse/ARTEMIS-994
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 1.5.3, 2.0.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.1.0
>
>
> Netty has support for native epoll, this is available only on linux systems. 
> This is more performant.
> http://netty.io/wiki/native-transports.html
> This is inline with supporting asyncio with libaio using such native feature 
> to bring perfomance benefits to artemis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1179) Add Optional Client JMS Destination Cache

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1179.
-

> Add Optional Client JMS Destination Cache
> -
>
> Key: ARTEMIS-1179
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1179
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> Some frameworks, constantly resolve the destination by name on every send, 
> rather than caching this.
> Spring is one such very popular framework, but we have seen this 
> unfortunately else where (no doubt replicating springs logic at some point of 
> history)
> This causes a performance issue, and obviously extra calls to the broker as 
> currently the artemis jms client calls the broker to check the address.
> In some enterprise/platform setups where destinations excluding temporary 
> destinations, destinations/address's are created permanently broker side, as 
> such the destination once resolved on the client can be permanently cached 
> thus avoiding the above mentioned performance and extra calls to the broker.
> The default should keep the existing behaviour, but users should be able to 
> opt in to this benefit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1156) Long Autoboxing occurring on Hot Path

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-1156:
-

Assignee: Michael Andre Pearce

> Long Autoboxing occurring on Hot Path
> -
>
> Key: ARTEMIS-1156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1156
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
> Attachments: Screen Shot 2017-05-10 at 02.05.47.png
>
>
> JournalImpl is on the hot path, and whilst a lot of effort seems to have gone 
> into ensuring the use of primitives, unfortunately due to java collections 
> used it is forcing long id's to be auto boxed, this causes un-needed memory 
> pressures. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1179) Add Optional Client JMS Destination Cache

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-1179:
-

Assignee: Michael Andre Pearce

> Add Optional Client JMS Destination Cache
> -
>
> Key: ARTEMIS-1179
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1179
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> Some frameworks, constantly resolve the destination by name on every send, 
> rather than caching this.
> Spring is one such very popular framework, but we have seen this 
> unfortunately else where (no doubt replicating springs logic at some point of 
> history)
> This causes a performance issue, and obviously extra calls to the broker as 
> currently the artemis jms client calls the broker to check the address.
> In some enterprise/platform setups where destinations excluding temporary 
> destinations, destinations/address's are created permanently broker side, as 
> such the destination once resolved on the client can be permanently cached 
> thus avoiding the above mentioned performance and extra calls to the broker.
> The default should keep the existing behaviour, but users should be able to 
> opt in to this benefit.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1164) NameNotFoundException when using java.naming.provider.url to set url via jndi

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1164.
-

> NameNotFoundException when using java.naming.provider.url to set url via jndi 
> --
>
> Key: ARTEMIS-1164
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1164
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> It should be possible to create a connection factory via JNDI simply defining 
> the initial context factory and provider url. 
> {noformat}
> java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
> java.naming.provider.url=tcp://localhost:5445?type=CF
> {noformat}
> As per samples in docs.
> https://activemq.apache.org/artemis/docs/2.0.0/using-jms.html
> This does not seems to be the case, see below test to prove this.
> {code:java}
>   @Test
>public void providerURLTest() throws NamingException {
>   String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>   
>   Properties props = new Properties();
>   props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY, 
> ActiveMQInitialContextFactory.class.getName());
>   props.setProperty(javax.naming.Context.PROVIDER_URL, url);
>   InitialContext context =  new InitialContext(props);
>   ConnectionFactory connectionFactory = 
> (ConnectionFactory)context.lookup("ConnectionFactory");
>}
> {code}
> It seems and mandatory param (duplicating the required and standard 
> java.naming.provider.url), 
> {noformat}
>   props.setProperty("connectionFactory.ConnectionFactory",url);
> {noformat}
> {code:java}
> @Test
>public void connectionFactoryProperty() throws NamingException {
>   String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>   Properties props = new Properties();
>   props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY, 
> ActiveMQInitialContextFactory.class.getName());
>   props.setProperty(javax.naming.Context.PROVIDER_URL, url);
>   props.setProperty("connectionFactory.ConnectionFactory",url);
>   InitialContext context =  new InitialContext(props);
>   ConnectionFactory connectionFactory = 
> (ConnectionFactory)context.lookup("ConnectionFactory");
>}
> {code}
> Either:
> A) the documentation samples need to be changed
> OR
> B) The ActiveMQInitialContextFactory should default register connection 
> factory created using java.naming.provider.url as ConnectionFactory.
> I would propose the latter, as this seems to be the way in Active MQ 5 and 
> some other technologies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1182) Add / Port in support for JNDIReferenceFactory and JNDIStorable

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1182.
-

> Add / Port in support for JNDIReferenceFactory and JNDIStorable
> ---
>
> Key: ARTEMIS-1182
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1182
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> It seems Artemis is missing some class's needed to support tomcat context 
> resource setup via jndi
> https://stackoverflow.com/questions/41846374/connecting-tomcat-to-standalone-artemis-broker-via-jndi
> this is present in ActiveMQ 5.x and also in QPID JMS
> https://github.com/apache/activemq/blob/master/activemq-client/src/main/java/org/apache/activemq/jndi/JNDIReferenceFactory.java
> https://github.com/apache/qpid-jms/blob/master/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JNDIReferenceFactory.java



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1164) NameNotFoundException when using java.naming.provider.url to set url via jndi

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-1164:
-

Assignee: Michael Andre Pearce

> NameNotFoundException when using java.naming.provider.url to set url via jndi 
> --
>
> Key: ARTEMIS-1164
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1164
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> It should be possible to create a connection factory via JNDI simply defining 
> the initial context factory and provider url. 
> {noformat}
> java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
> java.naming.provider.url=tcp://localhost:5445?type=CF
> {noformat}
> As per samples in docs.
> https://activemq.apache.org/artemis/docs/2.0.0/using-jms.html
> This does not seems to be the case, see below test to prove this.
> {code:java}
>   @Test
>public void providerURLTest() throws NamingException {
>   String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>   
>   Properties props = new Properties();
>   props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY, 
> ActiveMQInitialContextFactory.class.getName());
>   props.setProperty(javax.naming.Context.PROVIDER_URL, url);
>   InitialContext context =  new InitialContext(props);
>   ConnectionFactory connectionFactory = 
> (ConnectionFactory)context.lookup("ConnectionFactory");
>}
> {code}
> It seems and mandatory param (duplicating the required and standard 
> java.naming.provider.url), 
> {noformat}
>   props.setProperty("connectionFactory.ConnectionFactory",url);
> {noformat}
> {code:java}
> @Test
>public void connectionFactoryProperty() throws NamingException {
>   String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>   Properties props = new Properties();
>   props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY, 
> ActiveMQInitialContextFactory.class.getName());
>   props.setProperty(javax.naming.Context.PROVIDER_URL, url);
>   props.setProperty("connectionFactory.ConnectionFactory",url);
>   InitialContext context =  new InitialContext(props);
>   ConnectionFactory connectionFactory = 
> (ConnectionFactory)context.lookup("ConnectionFactory");
>}
> {code}
> Either:
> A) the documentation samples need to be changed
> OR
> B) The ActiveMQInitialContextFactory should default register connection 
> factory created using java.naming.provider.url as ConnectionFactory.
> I would propose the latter, as this seems to be the way in Active MQ 5 and 
> some other technologies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1156) Long Autoboxing occurring on Hot Path

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1156.
-

> Long Autoboxing occurring on Hot Path
> -
>
> Key: ARTEMIS-1156
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1156
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
> Attachments: Screen Shot 2017-05-10 at 02.05.47.png
>
>
> JournalImpl is on the hot path, and whilst a lot of effort seems to have gone 
> into ensuring the use of primitives, unfortunately due to java collections 
> used it is forcing long id's to be auto boxed, this causes un-needed memory 
> pressures. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1162) Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1162.
-
Assignee: Michael Andre Pearce

No Fix

> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> 
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-1188:
-

Assignee: Michael Andre Pearce

> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce reassigned ARTEMIS-1189:
-

Assignee: Michael Andre Pearce

> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1189.
-

> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce closed ARTEMIS-1188.
-

> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>Assignee: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ARTEMIS-1129) Client Dependencies

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1129.
-
Resolution: Fixed

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Michael Andre Pearce
>Priority: Minor
>  Labels: documentation
> Fix For: 2.2.0
>
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ARTEMIS-1129) Client Dependencies

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-1129:

Fix Version/s: 2.2.0

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Michael Andre Pearce
>Priority: Minor
>  Labels: documentation
> Fix For: 2.2.0
>
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Reopened] (ARTEMIS-1129) Client Dependencies

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram reopened ARTEMIS-1129:
-

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Michael Andre Pearce
>Priority: Minor
>  Labels: documentation
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AMQ-6689) New logo for ActiveMQ

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029900#comment-16029900
 ] 

ASF subversion and git services commented on AMQ-6689:
--

Commit 44b5d0be658bec973dce4ddfc4be5aae3197925b in activemq's branch 
refs/heads/master from Clebert Suconic
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=44b5d0b ]

[AMQ-6689] placeholder for new logo submissions


> New logo for ActiveMQ
> -
>
> Key: AMQ-6689
> URL: https://issues.apache.org/jira/browse/AMQ-6689
> Project: ActiveMQ
>  Issue Type: Task
>Reporter: clebert suconic
>
> The ActiveMQ logo hasn't changed in a while.
> It would be nice to have a new looking and feel logo, including an abstract 
> image.
> There will be a blog post linking to this issue, that will have more 
> information about the logo submissions...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (ARTEMIS-1129) Client Dependencies

[clebert suconic (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic closed ARTEMIS-1129.

Resolution: Fixed

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Michael Andre Pearce
>Priority: Minor
>  Labels: documentation
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (ARTEMIS-1129) Client Dependencies

[clebert suconic (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

clebert suconic reassigned ARTEMIS-1129:


Assignee: Michael Andre Pearce  (was: Justin Bertram)

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Michael Andre Pearce
>Priority: Minor
>  Labels: documentation
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1129) Client Dependencies

[clebert suconic (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029869#comment-16029869
 ] 

clebert suconic commented on ARTEMIS-1129:
--

[~michael.andre.pearce] I have added you a developer and contributor on JIRA.. 
I believe you can do it now...


I will assign this to you and close it.

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Justin Bertram
>Priority: Minor
>  Labels: documentation
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ARTEMIS-1164) NameNotFoundException when using java.naming.provider.url to set url via jndi

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce resolved ARTEMIS-1164.
---
   Resolution: Fixed
Fix Version/s: 2.2.0

> NameNotFoundException when using java.naming.provider.url to set url via jndi 
> --
>
> Key: ARTEMIS-1164
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1164
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> It should be possible to create a connection factory via JNDI simply defining 
> the initial context factory and provider url. 
> {noformat}
> java.naming.factory.initial=org.apache.activemq.artemis.jndi.ActiveMQInitialContextFactory
> java.naming.provider.url=tcp://localhost:5445?type=CF
> {noformat}
> As per samples in docs.
> https://activemq.apache.org/artemis/docs/2.0.0/using-jms.html
> This does not seems to be the case, see below test to prove this.
> {code:java}
>   @Test
>public void providerURLTest() throws NamingException {
>   String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>   
>   Properties props = new Properties();
>   props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY, 
> ActiveMQInitialContextFactory.class.getName());
>   props.setProperty(javax.naming.Context.PROVIDER_URL, url);
>   InitialContext context =  new InitialContext(props);
>   ConnectionFactory connectionFactory = 
> (ConnectionFactory)context.lookup("ConnectionFactory");
>}
> {code}
> It seems and mandatory param (duplicating the required and standard 
> java.naming.provider.url), 
> {noformat}
>   props.setProperty("connectionFactory.ConnectionFactory",url);
> {noformat}
> {code:java}
> @Test
>public void connectionFactoryProperty() throws NamingException {
>   String url = "(tcp://somehost:62616,tcp://somehost:62616)?ha=true";
>   Properties props = new Properties();
>   props.setProperty(javax.naming.Context.INITIAL_CONTEXT_FACTORY, 
> ActiveMQInitialContextFactory.class.getName());
>   props.setProperty(javax.naming.Context.PROVIDER_URL, url);
>   props.setProperty("connectionFactory.ConnectionFactory",url);
>   InitialContext context =  new InitialContext(props);
>   ConnectionFactory connectionFactory = 
> (ConnectionFactory)context.lookup("ConnectionFactory");
>}
> {code}
> Either:
> A) the documentation samples need to be changed
> OR
> B) The ActiveMQInitialContextFactory should default register connection 
> factory created using java.naming.provider.url as ConnectionFactory.
> I would propose the latter, as this seems to be the way in Active MQ 5 and 
> some other technologies.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1129) Client Dependencies

[Michael Andre Pearce (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029862#comment-16029862
 ] 

Michael Andre Pearce commented on ARTEMIS-1129:
---

It seems i cannot close this, nor assign it to myself. :( anyone idea what i 
can do?

> Client Dependencies 
> 
>
> Key: ARTEMIS-1129
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1129
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.0.0
>Reporter: Bernd Rosstauscher
>Assignee: Justin Bertram
>Priority: Minor
>  Labels: documentation
>
> Currently the documentation is not up to date for the client requirements.
> Section 12. The Client Classpath specifies only the following 
> activemq-core-client.jar, activemq-commons.jar, and netty.jar
> And for JMS the following:
> activemq-jms-client.jar and geronimo-jms_2.0_spec.jar
> If I copy these to my project and try to connect directly via JMS (not via 
> JNDI) I get at runtime ClassNotFoundExceptions of all kind.
> It seems now you need a lot more JAR files as dependencies. It is not really 
> clear what else is needed so you will end up to copy the whole Artemis Jars 
> just to make the client connection work.
> Would it be possible to update the documentation to specify the direct and 
> indirect dependencies for the client. 
> I have the feeling this is at the moment a little bit out of control as it 
> seems I need now to include 10 more Jar files or so including the json 
> libraries, org.jboss logging, all the commons jars and many more?
> Thanks for your great work.
> - Bernd Rosstauscher



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (AMQ-6689) New logo for ActiveMQ

[clebert suconic (JIRA)]

clebert suconic created AMQ-6689:


 Summary: New logo for ActiveMQ
 Key: AMQ-6689
 URL: https://issues.apache.org/jira/browse/AMQ-6689
 Project: ActiveMQ
  Issue Type: Task
Reporter: clebert suconic


The ActiveMQ logo hasn't changed in a while.

It would be nice to have a new looking and feel logo, including an abstract 
image.

There will be a blog post linking to this issue, that will have more 
information about the logo submissions...



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce resolved ARTEMIS-1188.
---
   Resolution: Fixed
Fix Version/s: 2.2.0

> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[Michael Andre Pearce (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Andre Pearce resolved ARTEMIS-1189.
---
   Resolution: Fixed
Fix Version/s: 2.2.0

> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029822#comment-16029822
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119167988
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

fair enough



> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029821#comment-16029821
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119167969
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

@michaelandrepearce It's up to you.. I would settle for what's on master 
now.  


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029817#comment-16029817
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119167641
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

unless someone else have a strong opinion about this.. but it's such a 
small issue... 


if anyone cares.. we can revisit it


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029810#comment-16029810
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119167405
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

no it looks like we can, they introduced "same" in the version also, which 
allows us to define

```

 
 
  
```

to keep the format you're used to.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029813#comment-16029813
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119167535
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

i just started going back through reverting the do-while changes and adding 
that check to replace the old config.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029809#comment-16029809
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119167401
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

@michaelandrepearce  hmmm.. too late now.. already merged it.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029806#comment-16029806
 ] 

ASF subversion and git services commented on ARTEMIS-1189:
--

Commit c65ea783ead733bfd1ca837a5032001efa0ade05 in activemq-artemis's branch 
refs/heads/master from [~michael.andre.pearce]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=c65ea78 ]

ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade

After upgrade of checkstyle, resolve violations

remove checkstyle override added as temp measure at point of upgrade forced by 
sevntu


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029807#comment-16029807
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1304


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029800#comment-16029800
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119166363
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

@michaelandrepearce  ok, so I take that there is no way to enforce this...

```java
do {
} while ();
```

if that's the case.. I'm not making a case about it... I will just fix a 
small issue with extra-tests and move on then/


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029799#comment-16029799
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119166058
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

It seems we can add
  
 
 
  

to keep the old format of a do while, with the while on same line, and have 
it checked by check style , i assume this is what you'd like


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029794#comment-16029794
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119163513
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

I'm happy to keep the change i introduced for sevntu upgrade which is to 
take out LITERAL_DO, but then this essentially removes the check.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029790#comment-16029790
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119163199
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

@michaelandrepearce  I would prefer keeping the checkstyle.xml with your 
previous fix then... and keep do {...} while the way it is now.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029780#comment-16029780
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119162241
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

as it states on the link i sent

"The problem was due to the fact that we treated LITERAL_DO incorrectly in 
Checkstyle 6.19. After fix for issue #3090 RightCurlyCheck began validate next 
part of do-while loop (while-token) correctly."


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029779#comment-16029779
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119161883
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

yes so this change is putting back the config to what we had before (but 
then we have to fix the while do's as on latest / >7 check style it enforces 
the while to a new line.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029698#comment-16029698
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119152397
  
--- Diff: etc/checkstyle.xml ---
@@ -46,9 +46,7 @@ under the License.
 
   
   
-  
- 
-  
+  
--- End diff --

+1


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029697#comment-16029697
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119152153
  
--- Diff: etc/checkstyle.xml ---
@@ -73,7 +71,7 @@ under the License.
   
   
  
- 
+ 
--- End diff --

It seems to me, that all we need is to remove this change, and keep those 
whiles alone?

the build is passing for me... I'm confused though.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029682#comment-16029682
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119150519
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
 ---
@@ -175,7 +176,8 @@ private void piggyBackResponses(ByteBuf buf) {
} catch (InterruptedException e) {
   break;
}
-} while (responses.isEmpty());
+}
--- End diff --

https://github.com/checkstyle/checkstyle/issues/3320


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029680#comment-16029680
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119150183
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
 ---
@@ -175,7 +176,8 @@ private void piggyBackResponses(ByteBuf buf) {
} catch (InterruptedException e) {
   break;
}
-} while (responses.isEmpty());
+}
--- End diff --

everything else is fine... just this while breaking line... unless we agree 
on change the rules...


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029681#comment-16029681
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119150371
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/HttpAcceptorHandler.java
 ---
@@ -175,7 +176,8 @@ private void piggyBackResponses(ByteBuf buf) {
} catch (InterruptedException e) {
   break;
}
-} while (responses.isEmpty());
+}
--- End diff --

it seems thats the upstream change, that came in 7.


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029677#comment-16029677
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1304#discussion_r119149908
  
--- Diff: 
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/UUIDTimer.java 
---
@@ -293,6 +293,7 @@ private static void slowDown(final long startTime, 
final long actDiff) {
  if (++counter > UUIDTimer.MAX_WAIT_COUNT) {
 break;
  }
-  } while (System.currentTimeMillis() < waitUntil);
+  }
--- End diff --

actually, this should be on the same line:/


there was a discussion an year ago more or less... I think @cshannon was 
part of it...


> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1189) Fix checkstyle violations post checkstyle upgrade

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029673#comment-16029673
 ] 

ASF GitHub Bot commented on ARTEMIS-1189:
-

GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1304

ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade

After upgrade of checkstyle, resolve violations
remove checkstyle override added as temp measure at point of upgrade forced 
by sevntu

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
artemis-1189

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1304


commit d797a28711bd2aa076bb780d0a202d5e60b07952
Author: Michael Andre Pearce 
Date:   2017-05-29T22:48:50Z

ARTEMIS-1189 - Fix checkstyle violations post checkstyle upgrade

After upgrade of checkstyle, resolve violations
remove checkstyle override added as temp measure at point of upgrade forced 
by sevntu




> Fix checkstyle violations post checkstyle  upgrade
> --
>
> Key: ARTEMIS-1189
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1189
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Michael Andre Pearce
>
> After upgrading check style as part of resolving ARTEMIS-1188,
> Checkstyle has bug fixes, which has meant it has picked up check style errors 
> that it should have previously.
> A temporary fix was to make check style ignore these, as already present.
> We should remove this override, and fix the check style violations. To reduce 
> future pain.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1195) Artemis.create filters should be independent

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029642#comment-16029642
 ] 

ASF GitHub Bot commented on ARTEMIS-1195:
-

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1303

ARTEMIS-1195 Filters should be independent on create

This closes #1301

This commit replaces #1301

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis artemis-1195

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1303.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1303


commit 01b8b0fe50e0e2b4f2c79023b29d14b9c8dfa48a
Author: Clebert Suconic 
Date:   2017-05-30T16:15:17Z

ARTEMIS-1195 Filters should be independent on create

This closes #1301

This commit replaces #1301




> Artemis.create filters should be independent
> 
>
> Key: ARTEMIS-1195
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1195
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> Filters should be independent from each other entries.
> Once a file is read, the filters should be already applied.. always. no 
> dependency between them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1195) Artemis.create filters should be independent

[clebert suconic (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029640#comment-16029640
 ] 

clebert suconic commented on ARTEMIS-1195:
--

see discussion on https://github.com/apache/activemq-artemis/pull/1301

> Artemis.create filters should be independent
> 
>
> Key: ARTEMIS-1195
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1195
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.1.0
>Reporter: clebert suconic
>Assignee: clebert suconic
> Fix For: 2.2.0
>
>
> Filters should be independent from each other entries.
> Once a file is read, the filters should be already applied.. always. no 
> dependency between them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ARTEMIS-1195) Artemis.create filters should be independent

[clebert suconic (JIRA)]

clebert suconic created ARTEMIS-1195:


 Summary: Artemis.create filters should be independent
 Key: ARTEMIS-1195
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1195
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 2.1.0
Reporter: clebert suconic
Assignee: clebert suconic
 Fix For: 2.2.0


Filters should be independent from each other entries.

Once a file is read, the filters should be already applied.. always. no 
dependency between them.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ARTEMIS-1194) SOCKS proxy support

[Andrius Dagys (JIRA)]

Andrius Dagys created ARTEMIS-1194:
--

 Summary: SOCKS proxy support
 Key: ARTEMIS-1194
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1194
 Project: ActiveMQ Artemis
  Issue Type: New Feature
Reporter: Andrius Dagys
Priority: Minor


Add SOCKS4a & 5 support to the NettyConnector.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029464#comment-16029464
 ] 

ASF GitHub Bot commented on ARTEMIS-1188:
-

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1299
  
@clebertsuconic yeah, and also the other non-prolific one was braces for 
try catch.

Im just working on the prolific ones, almost done actually.


> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029449#comment-16029449
 ] 

ASF subversion and git services commented on ARTEMIS-1188:
--

Commit 2d850680d6ad93e50799e820d969a15960a51f8b in activemq-artemis's branch 
refs/heads/1.x from [~michael.andre.pearce]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=2d85068 ]

ARTEMIS-1188: Update sevntu to 1.24.0 available in maven central

remove custom repo
update groupid to match artifact in maven central.
bump version also to that now deployed to maven central.
bump checkstyle version to 7.7 to make compatible.

updated checkstyle.xml to ignore existing issues which are prolific
which are now flagged in latest version as some bugs in previous meant they 
we'ren't detected e.g. https://github.com/checkstyle/checkstyle/issues/3320

fixing some violations which are not too prolific.

(cherry picked from commit b8ebe0577504fa0b2c39471f36656a0fe0ad59bd)


> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029448#comment-16029448
 ] 

ASF GitHub Bot commented on ARTEMIS-1188:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1299


> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029447#comment-16029447
 ] 

ASF subversion and git services commented on ARTEMIS-1188:
--

Commit b8ebe0577504fa0b2c39471f36656a0fe0ad59bd in activemq-artemis's branch 
refs/heads/master from [~michael.andre.pearce]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=b8ebe05 ]

ARTEMIS-1188: Update sevntu to 1.24.0 available in maven central

remove custom repo
update groupid to match artifact in maven central.
bump version also to that now deployed to maven central.
bump checkstyle version to 7.7 to make compatible.

updated checkstyle.xml to ignore existing issues which are prolific 
which are now flagged in latest version as some bugs in previous meant they 
we'ren't detected e.g. https://github.com/checkstyle/checkstyle/issues/3320

fixing some violations which are not too prolific.


> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1188) Update sevntu to 1.24.0 available in maven central

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029446#comment-16029446
 ] 

ASF GitHub Bot commented on ARTEMIS-1188:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1299
  
I see... hash without equals


> Update sevntu to 1.24.0 available in maven central
> --
>
> Key: ARTEMIS-1188
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1188
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Michael Andre Pearce
>
> Update to: 
> https://repo1.maven.org/maven2/com/github/sevntu-checkstyle/sevntu-checkstyle-maven-plugin/1.24.0/
> remove old plugin repo.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AMQ-6601) AMQ with master and slave broker, shutting down slave causes dead-lock

[Martin Lichtin (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029443#comment-16029443
 ] 

Martin Lichtin commented on AMQ-6601:
-

Upgrading to 5.14.5 I noticed the issue is still there. Can the change be 
included in the next release?


> AMQ with master and slave broker, shutting down slave causes dead-lock
> --
>
> Key: AMQ-6601
> URL: https://issues.apache.org/jira/browse/AMQ-6601
> Project: ActiveMQ
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 5.14.0
>Reporter: Carlo Dapor
> Attachments: jstack-28657
>
>
> We have 2 karaf instances configured to be activemq brokers, broker-amq (b1) 
> and broker2-amq (b2).
> They run on the same machine, use KahaDB with file locking.
> It does not matter if b1 or b2 is started first, it becomes the master.
> The other one, the slave, when shutting down - while the master is running - 
> hits a dead-lock; it must be `kill -9`'d manually in the end.
> We have a classic dead-lock scenario.  I have attached a `jstack` output when 
> the slave broker is shutting down.
> The race is on between thread #20 and thread #17.
> Thread #17 is in 
> {code:java}
> ActiveMQServiceFactory.destroy(ActiveMQServiceFactory.java:173)
> {code}
> and thread #20 is in
> {code:java}
> ActiveMQServiceFactory.updated(ActiveMQServiceFactory.java:140)
> {code}
> {code}
> "CM Configuration Updater (ManagedServiceFactory Update: 
> factoryPid=[org.apache.activemq.server])" #20 daemon prio=5 os_prio=0 
> tid=0x7f793c160800 nid=0x7084 waiting on condition [0x7f799819f000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at java.lang.Thread.sleep(Thread.java:340)
> at java.util.concurrent.TimeUnit.sleep(TimeUnit.java:386)
> at 
> org.apache.activemq.store.SharedFileLocker.doStart(SharedFileLocker.java:83)
> at 
> org.apache.activemq.util.ServiceSupport.start(ServiceSupport.java:55)
> at 
> org.apache.activemq.broker.LockableServiceSupport.preStart(LockableServiceSupport.java:94)
> at 
> org.apache.activemq.util.ServiceSupport.start(ServiceSupport.java:54)
> at 
> org.apache.activemq.broker.BrokerService.doStartPersistenceAdapter(BrokerService.java:674)
> at 
> org.apache.activemq.broker.BrokerService.startPersistenceAdapter(BrokerService.java:658)
> at 
> org.apache.activemq.broker.BrokerService.start(BrokerService.java:622)
> at 
> org.apache.activemq.osgi.ActiveMQServiceFactory.updated(ActiveMQServiceFactory.java:140)
> - locked <0x00072bd74db0> (a 
> org.apache.activemq.osgi.ActiveMQServiceFactory)
> at Proxy8890d2d1_e3a3_4b71_a7a0_88810df56856.updated(Unknown Source)
> at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.updated(ManagedServiceFactoryTracker.java:159)
> at 
> org.apache.felix.cm.impl.helper.ManagedServiceFactoryTracker.provideConfiguration(ManagedServiceFactoryTracker.java:93)
> at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.provide(ConfigurationManager.java:1597)
> at 
> org.apache.felix.cm.impl.ConfigurationManager$ManagedServiceFactoryUpdate.run(ConfigurationManager.java:1540)
> at org.apache.felix.cm.impl.UpdateThread.run(UpdateThread.java:103)
> at java.lang.Thread.run(Thread.java:745)
>  
> "Thread-4" #19 daemon prio=5 os_prio=0 tid=0x7f7940002800 nid=0x7081 
> runnable [0x7f79984b4000]
>java.lang.Thread.State: RUNNABLE
> at java.net.PlainSocketImpl.socketAccept(Native Method)
> at 
> java.net.AbstractPlainSocketImpl.accept(AbstractPlainSocketImpl.java:409)
> at java.net.ServerSocket.implAccept(ServerSocket.java:545)
> at java.net.ServerSocket.accept(ServerSocket.java:513)
> at 
> org.apache.karaf.main.ShutdownSocketThread.run(ShutdownSocketThread.java:56)
>  
> "Thread-3" #18 prio=5 os_prio=0 tid=0x7f79d0c48800 nid=0x7080 waiting on 
> condition [0x7f79985b5000]
>java.lang.Thread.State: TIMED_WAITING (sleeping)
> at java.lang.Thread.sleep(Native Method)
> at org.apache.karaf.main.Main.doMonitor(Main.java:299)
> at org.apache.karaf.main.Main.access$100(Main.java:65)
> at org.apache.karaf.main.Main$1.run(Main.java:275)
>  
> "FelixStartLevel" #17 daemon prio=5 os_prio=0 tid=0x7f79d0c48000 
> nid=0x707f waiting for monitor entry [0x7f79986b5000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at 
> org.apache.activemq.osgi.ActiveMQServiceFactory.destroy(ActiveMQServiceFactory.java:173)
> - waiting to lock <0x00072bd74db0> (a 
> org.apache.activemq.osgi.ActiveMQServiceFactory)
> at 

[jira] [Updated] (ARTEMIS-1193) [extra-tests] StartStopDeadlockTest#testDeadlock gets stuck

[Jiri Danek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Danek updated ARTEMIS-1193:

Labels: tests  (was: )

> [extra-tests] StartStopDeadlockTest#testDeadlock gets stuck
> ---
>
> Key: ARTEMIS-1193
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1193
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Jiri Danek
>  Labels: tests
>
> after it got stuck, I issued {{kill -3}}, see log below
> {noformat}
> [main] 13:50:04,306 INFO  [org.apache.activemq.artemis.core.server] #*#*# 
> Starting test: testDeadlock()...
> #test testDeadlock
> [main] 13:50:04,414 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221000: live Message Broker is starting with configuration Broker 
> Configuration 
> (clustered=false,journalDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/journal0-L,bindingsDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/bindings0-L,largeMessagesDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/large-msg0-L,pagingDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/page0-L)
> [main] 13:50:04,415 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221006: Waiting to obtain live lock
> [main] 13:50:04,415 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221013: Using NIO Journal
> [main] 13:50:04,415 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221043: Protocol module found: [artemis-server]. Adding protocol support 
> for: CORE
> [main] 13:50:04,416 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221043: Protocol module found: [artemis-amqp-protocol]. Adding protocol 
> support for: AMQP
> [main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221043: Protocol module found: [artemis-stomp-protocol]. Adding protocol 
> support for: STOMP
> [main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221043: Protocol module found: [artemis-openwire-protocol]. Adding 
> protocol support for: OPENWIRE
> [main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221043: Protocol module found: [artemis-mqtt-protocol]. Adding protocol 
> support for: MQTT
> [main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221043: Protocol module found: [artemis-hornetq-protocol]. Adding protocol 
> support for: HORNETQ
> [main] 13:50:04,419 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221034: Waiting indefinitely to obtain live lock
> [main] 13:50:04,419 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221035: Live Server Obtained live lock
> [org.apache.commons.beanutils.BeanUtils] : 
> BeanUtils.populate(CoreProtocolManager(server=ActiveMQServerImpl::serverUUID=147cda9b-43ce-11e7-89a8-fa163e5a2b31),
>  {})
> [org.apache.commons.beanutils.BeanUtils] : 
> BeanUtils.populate(org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManager@189b5fb1,
>  {})
> [org.apache.commons.beanutils.BeanUtils] : 
> BeanUtils.populate(org.apache.activemq.artemis.protocol.amqp.broker.ProtonProtocolManager@783ec989,
>  {})
> [org.apache.commons.beanutils.BeanUtils] : 
> BeanUtils.populate(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@1ddd3478,
>  {})
> [org.apache.commons.beanutils.BeanUtils] : 
> BeanUtils.populate(org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager@f973499,
>  {})
> [main] 13:50:04,425 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221020: Started EPOLL Acceptor at localhost:61616 for protocols 
> [CORE,MQTT,AMQP,STOMP,HORNETQ,OPENWIRE]
> [main] 13:50:04,426 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221007: Server is now live
> [main] 13:50:04,426 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221001: Apache ActiveMQ Artemis Message Broker version 2.2.0-SNAPSHOT 
> [localhost, nodeID=147cda9b-43ce-11e7-89a8-fa163e5a2b31] 
> [main] 13:50:04,426 INFO  [org.apache.activemq.artemis.core.server] 
> AMQ221000: backup Message Broker is starting with configuration Broker 
> Configuration 
> 

[jira] [Created] (ARTEMIS-1193) [extra-tests] StartStopDeadlockTest#testDeadlock gets stuck

[Jiri Danek (JIRA)]

Jiri Danek created ARTEMIS-1193:
---

 Summary: [extra-tests] StartStopDeadlockTest#testDeadlock gets 
stuck
 Key: ARTEMIS-1193
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1193
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 2.2.0
Reporter: Jiri Danek


after it got stuck, I issued {{kill -3}}, see log below

{noformat}
[main] 13:50:04,306 INFO  [org.apache.activemq.artemis.core.server] #*#*# 
Starting test: testDeadlock()...
#test testDeadlock
[main] 13:50:04,414 INFO  [org.apache.activemq.artemis.core.server] AMQ221000: 
live Message Broker is starting with configuration Broker Configuration 
(clustered=false,journalDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/journal0-L,bindingsDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/bindings0-L,largeMessagesDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/large-msg0-L,pagingDirectory=/root/workspace/peline_jdanek_artemis_junit-MXKODGBZMK2IRSU3ZGP3WXI5HYEVJ64OU2VN7HHODGYVOJ5FA7IQ/tests/extra-tests/./target/tmp/junit5157438289239255150/page0-L)
[main] 13:50:04,415 INFO  [org.apache.activemq.artemis.core.server] AMQ221006: 
Waiting to obtain live lock
[main] 13:50:04,415 INFO  [org.apache.activemq.artemis.core.server] AMQ221013: 
Using NIO Journal
[main] 13:50:04,415 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-server]. Adding protocol support for: CORE
[main] 13:50:04,416 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-amqp-protocol]. Adding protocol support for: 
AMQP
[main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-stomp-protocol]. Adding protocol support for: 
STOMP
[main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-openwire-protocol]. Adding protocol support 
for: OPENWIRE
[main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-mqtt-protocol]. Adding protocol support for: 
MQTT
[main] 13:50:04,417 INFO  [org.apache.activemq.artemis.core.server] AMQ221043: 
Protocol module found: [artemis-hornetq-protocol]. Adding protocol support for: 
HORNETQ
[main] 13:50:04,419 INFO  [org.apache.activemq.artemis.core.server] AMQ221034: 
Waiting indefinitely to obtain live lock
[main] 13:50:04,419 INFO  [org.apache.activemq.artemis.core.server] AMQ221035: 
Live Server Obtained live lock
[org.apache.commons.beanutils.BeanUtils] : 
BeanUtils.populate(CoreProtocolManager(server=ActiveMQServerImpl::serverUUID=147cda9b-43ce-11e7-89a8-fa163e5a2b31),
 {})
[org.apache.commons.beanutils.BeanUtils] : 
BeanUtils.populate(org.apache.activemq.artemis.core.protocol.mqtt.MQTTProtocolManager@189b5fb1,
 {})
[org.apache.commons.beanutils.BeanUtils] : 
BeanUtils.populate(org.apache.activemq.artemis.protocol.amqp.broker.ProtonProtocolManager@783ec989,
 {})
[org.apache.commons.beanutils.BeanUtils] : 
BeanUtils.populate(org.apache.activemq.artemis.core.protocol.stomp.StompProtocolManager@1ddd3478,
 {})
[org.apache.commons.beanutils.BeanUtils] : 
BeanUtils.populate(org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager@f973499,
 {})
[main] 13:50:04,425 INFO  [org.apache.activemq.artemis.core.server] AMQ221020: 
Started EPOLL Acceptor at localhost:61616 for protocols 
[CORE,MQTT,AMQP,STOMP,HORNETQ,OPENWIRE]
[main] 13:50:04,426 INFO  [org.apache.activemq.artemis.core.server] AMQ221007: 
Server is now live
[main] 13:50:04,426 INFO  [org.apache.activemq.artemis.core.server] AMQ221001: 
Apache ActiveMQ Artemis Message Broker version 2.2.0-SNAPSHOT [localhost, 
nodeID=147cda9b-43ce-11e7-89a8-fa163e5a2b31] 
[main] 13:50:04,426 INFO  [org.apache.activemq.artemis.core.server] AMQ221000: 
backup Message Broker is starting with configuration Broker Configuration 

[jira] [Updated] (ARTEMIS-1192) [extra-tests] both LargeMessageOverReplicationTest test methods fail

[Jiri Danek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Danek updated ARTEMIS-1192:

Attachment: log.tmp

> [extra-tests] both LargeMessageOverReplicationTest test methods fail
> 
>
> Key: ARTEMIS-1192
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1192
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Jiri Danek
>  Labels: tests
> Attachments: log.tmp
>
>
> {noformat}
> commit de9cc2e708480084236c7e18e32454c3e3a01c93 (upstream/master)
> Merge: 28a60bcdf f63ffc7af
> Author: Martyn Taylor 
> Date:   Fri May 26 11:16:42 2017 +0100
> This closes #1294
> {noformat}
> {{mvn test -Ptests -Pextra-tests -Dtest=LargeMessageOverReplicationTest 
> -DfailIfNoTests=false -Drat.ignoreErrors=true -DskipStyleCheck=true}}
> {noformat}
> [...]
> java.lang.AssertionError: Expected a failure here
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage(LargeMessageOverReplicationTest.java:191)
> testSendLargeMessage(org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest)
>   Time elapsed: 33.998 sec  <<< FAILURE!
> java.lang.AssertionError: expected an exception
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage(LargeMessageOverReplicationTest.java:148)
> Results :
> Failed tests: 
>   LargeMessageOverReplicationTest.testReceiveLargeMessage:191->Assert.fail:88 
> Expected a failure here
>   LargeMessageOverReplicationTest.testSendLargeMessage:148->Assert.fail:88 
> expected an exception
> Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
> [ERROR] There are test failures.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ARTEMIS-1192) [extra-tests] both LargeMessageOverReplicationTest test methods fail

[Jiri Danek (JIRA)]

Jiri Danek created ARTEMIS-1192:
---

 Summary: [extra-tests] both LargeMessageOverReplicationTest test 
methods fail
 Key: ARTEMIS-1192
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1192
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Jiri Danek


{noformat}
commit de9cc2e708480084236c7e18e32454c3e3a01c93 (upstream/master)
Merge: 28a60bcdf f63ffc7af
Author: Martyn Taylor 
Date:   Fri May 26 11:16:42 2017 +0100

This closes #1294
{noformat}

{{mvn test -Ptests -Pextra-tests -Dtest=LargeMessageOverReplicationTest 
-DfailIfNoTests=false -Drat.ignoreErrors=true -DskipStyleCheck=true}}

{noformat}
[...]
java.lang.AssertionError: Expected a failure here
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage(LargeMessageOverReplicationTest.java:191)

testSendLargeMessage(org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest)
  Time elapsed: 33.998 sec  <<< FAILURE!
java.lang.AssertionError: expected an exception
at org.junit.Assert.fail(Assert.java:88)
at 
org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage(LargeMessageOverReplicationTest.java:148)


Results :

Failed tests: 
  LargeMessageOverReplicationTest.testReceiveLargeMessage:191->Assert.fail:88 
Expected a failure here
  LargeMessageOverReplicationTest.testSendLargeMessage:148->Assert.fail:88 
expected an exception

Tests run: 2, Failures: 2, Errors: 0, Skipped: 0

[ERROR] There are test failures.
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ARTEMIS-1192) [extra-tests] both LargeMessageOverReplicationTest test methods fail

[Jiri Danek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Danek updated ARTEMIS-1192:

Affects Version/s: 2.2.0

> [extra-tests] both LargeMessageOverReplicationTest test methods fail
> 
>
> Key: ARTEMIS-1192
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1192
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Jiri Danek
>  Labels: tests
>
> {noformat}
> commit de9cc2e708480084236c7e18e32454c3e3a01c93 (upstream/master)
> Merge: 28a60bcdf f63ffc7af
> Author: Martyn Taylor 
> Date:   Fri May 26 11:16:42 2017 +0100
> This closes #1294
> {noformat}
> {{mvn test -Ptests -Pextra-tests -Dtest=LargeMessageOverReplicationTest 
> -DfailIfNoTests=false -Drat.ignoreErrors=true -DskipStyleCheck=true}}
> {noformat}
> [...]
> java.lang.AssertionError: Expected a failure here
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage(LargeMessageOverReplicationTest.java:191)
> testSendLargeMessage(org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest)
>   Time elapsed: 33.998 sec  <<< FAILURE!
> java.lang.AssertionError: expected an exception
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage(LargeMessageOverReplicationTest.java:148)
> Results :
> Failed tests: 
>   LargeMessageOverReplicationTest.testReceiveLargeMessage:191->Assert.fail:88 
> Expected a failure here
>   LargeMessageOverReplicationTest.testSendLargeMessage:148->Assert.fail:88 
> expected an exception
> Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
> [ERROR] There are test failures.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ARTEMIS-1192) [extra-tests] both LargeMessageOverReplicationTest test methods fail

[Jiri Danek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Danek updated ARTEMIS-1192:

Labels: tests  (was: )

> [extra-tests] both LargeMessageOverReplicationTest test methods fail
> 
>
> Key: ARTEMIS-1192
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1192
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Jiri Danek
>  Labels: tests
>
> {noformat}
> commit de9cc2e708480084236c7e18e32454c3e3a01c93 (upstream/master)
> Merge: 28a60bcdf f63ffc7af
> Author: Martyn Taylor 
> Date:   Fri May 26 11:16:42 2017 +0100
> This closes #1294
> {noformat}
> {{mvn test -Ptests -Pextra-tests -Dtest=LargeMessageOverReplicationTest 
> -DfailIfNoTests=false -Drat.ignoreErrors=true -DskipStyleCheck=true}}
> {noformat}
> [...]
> java.lang.AssertionError: Expected a failure here
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage(LargeMessageOverReplicationTest.java:191)
> testSendLargeMessage(org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest)
>   Time elapsed: 33.998 sec  <<< FAILURE!
> java.lang.AssertionError: expected an exception
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage(LargeMessageOverReplicationTest.java:148)
> Results :
> Failed tests: 
>   LargeMessageOverReplicationTest.testReceiveLargeMessage:191->Assert.fail:88 
> Expected a failure here
>   LargeMessageOverReplicationTest.testSendLargeMessage:148->Assert.fail:88 
> expected an exception
> Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
> [ERROR] There are test failures.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ARTEMIS-1192) [extra-tests] both LargeMessageOverReplicationTest test methods fail

[Jiri Danek (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jiri Danek updated ARTEMIS-1192:

Component/s: Broker

> [extra-tests] both LargeMessageOverReplicationTest test methods fail
> 
>
> Key: ARTEMIS-1192
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1192
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.2.0
>Reporter: Jiri Danek
>  Labels: tests
>
> {noformat}
> commit de9cc2e708480084236c7e18e32454c3e3a01c93 (upstream/master)
> Merge: 28a60bcdf f63ffc7af
> Author: Martyn Taylor 
> Date:   Fri May 26 11:16:42 2017 +0100
> This closes #1294
> {noformat}
> {{mvn test -Ptests -Pextra-tests -Dtest=LargeMessageOverReplicationTest 
> -DfailIfNoTests=false -Drat.ignoreErrors=true -DskipStyleCheck=true}}
> {noformat}
> [...]
> java.lang.AssertionError: Expected a failure here
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage(LargeMessageOverReplicationTest.java:191)
> testSendLargeMessage(org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest)
>   Time elapsed: 33.998 sec  <<< FAILURE!
> java.lang.AssertionError: expected an exception
> at org.junit.Assert.fail(Assert.java:88)
> at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testSendLargeMessage(LargeMessageOverReplicationTest.java:148)
> Results :
> Failed tests: 
>   LargeMessageOverReplicationTest.testReceiveLargeMessage:191->Assert.fail:88 
> Expected a failure here
>   LargeMessageOverReplicationTest.testSendLargeMessage:148->Assert.fail:88 
> expected an exception
> Tests run: 2, Failures: 2, Errors: 0, Skipped: 0
> [ERROR] There are test failures.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (ARTEMIS-1191) [extra-tests] FailureXATest#testCrashServerAfterOnePhaseCommit fails in current master

[Jiri Danek (JIRA)]

Jiri Danek created ARTEMIS-1191:
---

 Summary: [extra-tests] 
FailureXATest#testCrashServerAfterOnePhaseCommit fails in current master
 Key: ARTEMIS-1191
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1191
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 2.2.0
Reporter: Jiri Danek


{noformat}
commit de9cc2e708480084236c7e18e32454c3e3a01c93 (upstream/master)
Merge: 28a60bcdf f63ffc7af
Author: Martyn Taylor 
Date:   Fri May 26 11:16:42 2017 +0100

This closes #1294
{noformat}

{{mvn test -Ptests -Pextra-tests 
-Dtest="FailureXATest#testCrashServerAfterOnePhaseCommit" -DfailIfNoTests=false 
-Drat.ignoreErrors=true -DskipStyleCheck=true}}

{noformat}
[INFO] 
[INFO] Building ActiveMQ Artemis Extra Tests 2.2.0-SNAPSHOT
[INFO] 
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4:enforce (enforce-maven) @ extra-tests ---
[INFO] 
[INFO] --- maven-enforcer-plugin:1.4:enforce (enforce-java) @ extra-tests ---
[INFO] 
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ extra-tests ---
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ 
extra-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/home/jdanek/Work/repos/activemq-artemis/tests/extra-tests/src/main/resources
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ extra-tests ---
[INFO] No sources to compile
[INFO] 
[INFO] --- maven-checkstyle-plugin:2.17:check (default) @ extra-tests ---
[INFO] 
[INFO] --- apache-rat-plugin:0.12:check (default) @ extra-tests ---
[INFO] Enabled default license matchers.
[INFO] Will parse SCM ignores for exclusions...
[INFO] Finished adding exclusions from SCM ignore files.
[INFO] 61 implicit excludes (use -debug for more details).
[INFO] Exclude: **/*.txt
[INFO] Exclude: **/*.md
[INFO] Exclude: etc/ide-settings/**
[INFO] Exclude: docs/**/*.json
[INFO] Exclude: docs/**/_book/
[INFO] Exclude: **/target/
[INFO] Exclude: **/META-INF/services/*
[INFO] Exclude: **/META-INF/MANIFEST.MF
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/*.jceks
[INFO] Exclude: **/*.jks
[INFO] Exclude: **/org/apache/activemq/artemis/utils/json/**
[INFO] Exclude: **/org/apache/activemq/artemis/utils/Base64.java
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/.project
[INFO] Exclude: **/.classpath
[INFO] Exclude: **/.editorconfig
[INFO] Exclude: **/.checkstyle
[INFO] Exclude: **/.factorypath
[INFO] Exclude: **/org.apache.activemq.artemis.cfg
[INFO] Exclude: **/nb-configuration.xml
[INFO] Exclude: **/*.data
[INFO] Exclude: **/*.bin
[INFO] Exclude: **/src/test/resources/keystore
[INFO] Exclude: **/*.log
[INFO] Exclude: **/*.redo
[INFO] Exclude: **/node/**
[INFO] Exclude: **/node_modules/**
[INFO] Exclude: **/package.json
[INFO] Exclude: **/npm-shrinkwrap.json
[INFO] Exclude: **/CMakeFiles/
[INFO] Exclude: **/Makefile
[INFO] Exclude: **/cmake_install.cmake
[INFO] Exclude: 
artemis-native/src/main/c/org_apache_activemq_artemis_jlibaio_LibaioContext.h
[INFO] Exclude: **/dependency-reduced-pom.xml
[INFO] 49 resources included (use -debug for more details)
[INFO] Rat check: Summary over all files. Unapproved: 0, unknown: 0, generated: 
0, approved: 49 licenses.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ 
extra-tests ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO] Copying 3 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.1:testCompile (default-testCompile) @ 
extra-tests ---
[INFO] Nothing to compile - all classes are up to date
[INFO] 
[INFO] --- maven-surefire-plugin:2.18.1:test (default-test) @ extra-tests ---
[INFO] Surefire report directory: 
/home/jdanek/Work/repos/activemq-artemis/tests/extra-tests/target/surefire-reports
[WARNING] The system property basedir is configured twice! The property appears 
in  and any of ,  or 
user property.

---
 T E S T S
---
Running org.apache.activemq.artemis.tests.extras.byteman.FailureXATest
byteman jar is 
/home/jdanek/.m2/repository/org/jboss/byteman/byteman/2.2.0/byteman-2.2.0.jar
Setting org.jboss.byteman.allow.config.update=true
[main] 13:50:45,514 INFO  [org.apache.activemq.artemis.core.server] #*#*# 
Starting test: testCrashServerAfterOnePhaseCommit()...
#test testCrashServerAfterOnePhaseCommit
[main] 13:50:45,773 INFO  [org.apache.activemq.artemis.core.server] AMQ221000: 
live Message Broker is starting with configuration Broker Configuration 

[jira] [Commented] (ARTEMIS-1190) Long/int type mismatch in JDBCSequentialFile.setWritePosition

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029252#comment-16029252
 ] 

ASF GitHub Bot commented on ARTEMIS-1190:
-

GitHub user dudaerich opened a pull request:

https://github.com/apache/activemq-artemis/pull/1302

ARTEMIS-1190 Long/int type mismatch in JDBCSequentialFile.setWritePos…

…ition

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dudaerich/activemq-artemis master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1302


commit 52b48949d97a7a786b868d8d5dc72bea25ce384b
Author: Erich Duda 
Date:   2017-05-30T10:34:42Z

ARTEMIS-1190 Long/int type mismatch in JDBCSequentialFile.setWritePosition




> Long/int type mismatch in JDBCSequentialFile.setWritePosition
> -
>
> Key: ARTEMIS-1190
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1190
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> In the {{JDBCSequentialFile.setWritePosition}} there is mismatch between 
> types. The parameter of the method has type {{int}} but the private field has 
> type {{long}}.
> {code:java}
> private long writePosition = 0;
> void setWritePosition(int writePosition) {
>this.writePosition = writePosition;
> }
> {code}
> Because of this in {{JDBCSequentialFileFactoryDriver.loadFile}} the long is 
> unnecessarily retype to int.
> {code:java}
> public void loadFile(JDBCSequentialFile file) throws SQLException {
> synchronized (connection) {
>connection.setAutoCommit(false);
>readLargeObject.setLong(1, file.getId());
>try (ResultSet rs = readLargeObject.executeQuery()) {
>   if (rs.next()) {
>  Blob blob = rs.getBlob(1);
>  if (blob != null) {
> file.setWritePosition((int) blob.length());
>  } else {
> logger.warn("ERROR NO BLOB FOR FILE" + "File: " + 
> file.getFileName() + " " + file.getId());
>  }
>   }
>   connection.commit();
>} catch (SQLException e) {
>   connection.rollback();
>   throw e;
>}
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (ARTEMIS-1190) Long/int type mismatch in JDBCSequentialFile.setWritePosition

[Erich Duda (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erich Duda updated ARTEMIS-1190:

Affects Version/s: 1.5.5

> Long/int type mismatch in JDBCSequentialFile.setWritePosition
> -
>
> Key: ARTEMIS-1190
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1190
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 1.5.5, 2.1.0
>Reporter: Erich Duda
>
> In the {{JDBCSequentialFile.setWritePosition}} there is mismatch between 
> types. The parameter of the method has type {{int}} but the private field has 
> type {{long}}.
> {code:java}
> private long writePosition = 0;
> void setWritePosition(int writePosition) {
>this.writePosition = writePosition;
> }
> {code}
> Because of this in {{JDBCSequentialFileFactoryDriver.loadFile}} the long is 
> unnecessarily retype to int.
> {code:java}
> public void loadFile(JDBCSequentialFile file) throws SQLException {
> synchronized (connection) {
>connection.setAutoCommit(false);
>readLargeObject.setLong(1, file.getId());
>try (ResultSet rs = readLargeObject.executeQuery()) {
>   if (rs.next()) {
>  Blob blob = rs.getBlob(1);
>  if (blob != null) {
> file.setWritePosition((int) blob.length());
>  } else {
> logger.warn("ERROR NO BLOB FOR FILE" + "File: " + 
> file.getFileName() + " " + file.getId());
>  }
>   }
>   connection.commit();
>} catch (SQLException e) {
>   connection.rollback();
>   throw e;
>}
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1176) Use text messages for management reply messages

[Guillaume Nodet (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028813#comment-16028813
 ] 

Guillaume Nodet commented on ARTEMIS-1176:
--

So the problem seems to be that the ActiveMQTextMessage which is built for the 
response eagerly reads the body as a string, so that the ManagementHelper which 
uses the ICoreMessage body can't work anymore as the body has been read already.

I see a few options:
  * keep the response as a text message and fix the management layer to support 
it (see patch below)
  * investigate changing the JMS messages to lazily read the body (but this 
could change some behavior)
  * don't fix the issue (the original issue is that the management layer can't 
be used with pure JMS api)

Patch for management layer:
{code}
diff --git 
a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java
 
b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java
index 946285da8..20c0cd076 100644
--- 
a/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java
+++ 
b/artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/ManagementHelper.java
@@ -197,7 +197,16 @@ public final class ManagementHelper {
public static Object[] getResults(final ICoreMessage message) throws 
Exception {
   SimpleString sstring = 
message.getBodyBuffer().readNullableSimpleString();
   String jsonString = (sstring == null) ? null : sstring.toString();
+  return getResults(jsonString);
+   }
 
+   /**
+* Returns the result of an operation invocation or an attribute value.
+* 
+* If an error occurred on the server, {@link 
#hasOperationSucceeded(Message)} will return {@code false}.
+* and the result will be a String corresponding to the server exception.
+*/
+   public static Object[] getResults(final String jsonString) throws Exception 
{
   if (jsonString != null) {
  JsonArray jsonArray = JsonUtil.readJsonArray(jsonString);
  return JsonUtil.fromJsonArray(jsonArray);
@@ -233,6 +242,22 @@ public final class ManagementHelper {
}
 
/**
+* Returns the result of an operation invocation or an attribute value.
+* 
+* If an error occurred on the server, {@link 
#hasOperationSucceeded(Message)} will return {@code false}.
+* and the result will be a String corresponding to the server exception.
+*/
+   public static Object getResult(final String message, Class desiredType) 
throws Exception {
+  Object[] res = ManagementHelper.getResults(message);
+
+  if (res != null) {
+ return JsonUtil.convertJsonValue(res[0], desiredType);
+  } else {
+ return null;
+  }
+   }
+
+   /**
 * Returns whether the invocation of the management operation on the server 
resource succeeded.
 */
public static boolean hasOperationSucceeded(final Message message) {
diff --git 
a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/JMSManagementHelper.java
 
b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/JMSManagementHelper.java
index 4d0306ba5..b7ba4a695 100644
--- 
a/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/JMSManagementHelper.java
+++ 
b/artemis-jms-client/src/main/java/org/apache/activemq/artemis/api/jms/management/JMSManagementHelper.java
@@ -18,6 +18,7 @@ package org.apache.activemq.artemis.api.jms.management;
 
 import javax.jms.JMSException;
 import javax.jms.Message;
+import javax.jms.TextMessage;
 
 import org.apache.activemq.artemis.api.core.client.ClientMessage;
 import org.apache.activemq.artemis.api.core.management.ManagementHelper;
@@ -147,7 +148,11 @@ public class JMSManagementHelper {
 * and the result will be a String corresponding to the server exception.
 */
public static Object getResult(final Message message, Class desiredType) 
throws Exception {
-  return 
ManagementHelper.getResult(JMSManagementHelper.getCoreMessage(message), 
desiredType);
+  if (message instanceof TextMessage) {
+ return ManagementHelper.getResult(((TextMessage) message).getText(), 
desiredType);
+  } else {
+ return 
ManagementHelper.getResult(JMSManagementHelper.getCoreMessage(message), 
desiredType);
+  }
}
 
private JMSManagementHelper() {
{code}

> Use text messages for management reply messages
> ---
>
> Key: ARTEMIS-1176
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1176
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
> Fix For: 2.2.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028801#comment-16028801
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1295
  
it is really a curse! Anyway thanks for the feedbacks...in particular for 
coding style and names...are 2 parts that make a big difference in usability of 
a feature, from the pov of dev/user!


> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028798#comment-16028798
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r119025093
  
--- Diff: 
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/journal/StatJournal.java
 ---
@@ -0,0 +1,288 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.cli.commands.tools.journal;
+
+import java.io.File;
+import java.io.FileOutputStream;
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Comparator;
+import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
+import java.util.concurrent.locks.LockSupport;
+
+import io.airlift.airline.Command;
+import io.airlift.airline.Option;
+import org.apache.activemq.artemis.cli.commands.ActionContext;
+import org.apache.activemq.artemis.cli.commands.Configurable;
+import org.apache.activemq.artemis.core.config.impl.FileConfiguration;
+import 
org.apache.activemq.artemis.core.io.buffer.counters.FlushSampleFlyweight;
+import org.apache.activemq.artemis.core.io.buffer.counters.Profiler;
+import org.apache.activemq.artemis.utils.collections.MulticastSample;
+
+@Command(name = "stat", description = "Provide performance statistics 
around the journal usage")
--- End diff --

It is a weird name...Do you have something in mind?
It is a journal sampling profiler and the ideas on how it works are taken 
from:
- https://linux.die.net/man/1/perf-record
- https://github.com/jvm-profiling-tools/honest-profiler
But in the future I'm planning to provide a single CLI command that could 
collect perf data using a filter of some kind or different CLI commands for 
macro profiling areas ...it is something I want to discuss on the dev list...



> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028795#comment-16028795
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r119024088
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/counters/Profiler.java
 ---
@@ -0,0 +1,72 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.core.io.buffer.counters;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.activemq.artemis.journal.ActiveMQJournalLogger;
+
+/**
+ * Factory class to instantiate {@link FlushProfiler}s classes.
+ */
+public final class Profiler {
+
+   private static final FlushProfiler BLACK_HOLE_PROFILER = new 
FlushProfiler() {
--- End diff --

The ``default`` method idea is good IMHO when you've methods not bounded 
each others, but when you have methods that makes sense to be implemented (and 
called) together (eg Lock::lock and Lock::unlock), I prefer to use normal 
methods and force the implementation to have both.


> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (ARTEMIS-1185) Inter-Process Journal Sampler Profiler + CLI command

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028794#comment-16028794
 ] 

ASF GitHub Bot commented on ARTEMIS-1185:
-

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1295#discussion_r119023463
  
--- Diff: 
artemis-journal/src/main/java/org/apache/activemq/artemis/core/io/buffer/TimedBuffer.java
 ---
@@ -93,10 +82,10 @@
public TimedBuffer(final int size, final int timeout, final boolean 
logRates) {
   bufferSize = size;
 
-  this.logRates = logRates;
-
   if (logRates) {
- logRatesTimer = new Timer(true);
+ this.flushProfiler = Profiler.instrumented();
+  } else {
+ this.flushProfiler = Profiler.none();
--- End diff --

About the compiler we're "lucky", because the noop impl will be inlined (is 
monomorphic with no code inside) and then wiped away (verified using JitWatch), 
leaving the TimedBuffer clean and without null checks too.
The guard statement that can be compiled out AFAIK are the ones that rely 
on final static fields, while normal instance members do not receive the same 
treatment from the JIT, sadly.
It is a different coding style: like having a null logger instance member 
or a noop logger implementation...wdyt?


> Inter-Process Journal Sampler Profiler + CLI command
> 
>
> Key: ARTEMIS-1185
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1185
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Reporter: Francesco Nigro
>Assignee: Francesco Nigro
>Priority: Minor
>
> It provides a sampling profiler on buffered ASYNCIO/NIO based journals.
> The profiling has a minimal cost in term of CPU time for each sample (the 
> dominant costs are System.nanoTime() and a single cache line invalidation) 
> and total memory footprint (~OS page size in bytes).
> A proper CLI command activates a sampler to collect (ie CSV) the profiled 
> data, showing the precision of the sampling: data loss is not considered a 
> failure condition.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)