Build failed in Jenkins: distributedlog-nightly-build #495

See -- [...truncated 253.78 KB...] [INFO] Downloaded:

[GitHub] merlimat commented on issue #754: Issue #753: Allow option to disable data sync on journal

merlimat commented on issue #754: Issue #753: Allow option to disable data sync on journal URL: https://github.com/apache/bookkeeper/pull/754#issuecomment-346540585 @eolivelli Updated the docs for the flag. PTAL This is an

[GitHub] jiazhai closed pull request #767: Issue 766: Bump master to 4.7.0-SNAPSHOT

jiazhai closed pull request #767: Issue 766: Bump master to 4.7.0-SNAPSHOT URL: https://github.com/apache/bookkeeper/pull/767 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] jiazhai closed issue #766: Bump master to 4.7.0-SNAPSHOT

jiazhai closed issue #766: Bump master to 4.7.0-SNAPSHOT URL: https://github.com/apache/bookkeeper/issues/766 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] eolivelli commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

eolivelli commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346538747 I am taking last look This is an automated message

[GitHub] sijie opened a new pull request #768: Issue 763: Javadoc layout should be reflected to new modules

sijie opened a new pull request #768: Issue 763: Javadoc layout should be reflected to new modules URL: https://github.com/apache/bookkeeper/pull/768 Descriptions of the changes in this PR: - add `org.apache.bookkeeper.client.api` in `BookKeeper Client (New Fluent API -

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152717258 ## File path:

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152717258 ## File path:

[GitHub] sijie commented on issue #766: Bump master to 4.7.0-SNAPSHOT

sijie commented on issue #766: Bump master to 4.7.0-SNAPSHOT URL: https://github.com/apache/bookkeeper/issues/766#issuecomment-346521705 /cc @jiazhai for release manager to be aware of this. This is an automated message from

[GitHub] sijie commented on issue #764: Issue-553: Documentation for new fluent API

sijie commented on issue #764: Issue-553: Documentation for new fluent API URL: https://github.com/apache/bookkeeper/pull/764#issuecomment-346521719 /cc @lucperkins This is an automated message from the Apache Git Service.

[GitHub] sijie opened a new issue #766: Bump master to 4.7.0-SNAPSHOT

sijie opened a new issue #766: Bump master to 4.7.0-SNAPSHOT URL: https://github.com/apache/bookkeeper/issues/766 *PROBLEM* The master was not bumped to `4.7.0` when branch-4.6 was created. This is an

[GitHub] sijie commented on issue #552: Update BookKeeper Tutorial to the new API

sijie commented on issue #552: Update BookKeeper Tutorial to the new API URL: https://github.com/apache/bookkeeper/issues/552#issuecomment-346521445 @ivankelly just check in here - are you picking this up? or shall I take it?

[GitHub] sijie opened a new issue #239: Use new bookkeeper fluent API

sijie opened a new issue #239: Use new bookkeeper fluent API URL: https://github.com/apache/distributedlog/issues/239 **FEATURE REQUEST** 1. Please describe the feature you are requesting. A new bookkeeper fluent API is introduced in apache/bookkeeper#506. DistributedLog

[GitHub] sijie opened a new issue #765: Add `isClosed()` to WriteHandle and ReadHandle

sijie opened a new issue #765: Add `isClosed()` to WriteHandle and ReadHandle URL: https://github.com/apache/bookkeeper/issues/765 1. Please describe the feature you are requesting. The new API is missing `isClosed()` on handles. It is hard to learn whether a ledger is closed or

[GitHub] sijie commented on issue #728: Issue-553 Documentation for new API (WIP)

sijie commented on issue #728: Issue-553 Documentation for new API (WIP) URL: https://github.com/apache/bookkeeper/pull/728#issuecomment-346520247 @eolivelli I sent the pull request #764 . I will close this one since there is no activity on this one anymore.

[GitHub] sijie closed pull request #728: Issue-553 Documentation for new API (WIP)

sijie closed pull request #728: Issue-553 Documentation for new API (WIP) URL: https://github.com/apache/bookkeeper/pull/728 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] sijie opened a new pull request #764: Issue-553: Documentation for new fluent API

sijie opened a new pull request #764: Issue-553: Documentation for new fluent API URL: https://github.com/apache/bookkeeper/pull/764 Descriptions of the changes in this PR: - Add documentation for the new fluent API: create/open/delete, append/write/read, createadv

[GitHub] ivankelly commented on issue #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on issue #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#issuecomment-346503785 +1 On Wed 22 Nov 2017, 23:48 Sijie Guo wrote:

[GitHub] sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152702805 ## File path:

[GitHub] sijie commented on issue #586: Provide an DCOS Universe package for bookkeeper

sijie commented on issue #586: Provide an DCOS Universe package for bookkeeper URL: https://github.com/apache/bookkeeper/issues/586#issuecomment-346501344 moved this to `4.7.0`. we need to make sure dcos is updated with latest bookkeeper release and apache/bookkeeper images.

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152699968 ## File path:

[GitHub] sijie closed issue #749: Update release date for 4.5.1

sijie closed issue #749: Update release date for 4.5.1 URL: https://github.com/apache/bookkeeper/issues/749 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie commented on issue #749: Update release date for 4.5.1

sijie commented on issue #749: Update release date for 4.5.1 URL: https://github.com/apache/bookkeeper/issues/749#issuecomment-346496426 This is merged by #758 This is an automated message from the Apache Git Service. To

[GitHub] sijie commented on issue #763: Javadoc layout should be reflected to new modules

sijie commented on issue #763: Javadoc layout should be reflected to new modules URL: https://github.com/apache/bookkeeper/issues/763#issuecomment-346494103 @jiazhai - we need to do this for 4.6.0 release. I marked it as a blocker.

[GitHub] sijie opened a new issue #763: Javadoc layout should be reflected to new modules

sijie opened a new issue #763: Javadoc layout should be reflected to new modules URL: https://github.com/apache/bookkeeper/issues/763 **FEATURE REQUEST** 1. Please describe the feature you are requesting. New modules (e.g. bookkeeper-proto) are introduced in 4.6.0 and

[GitHub] sijie opened a new issue #762: Codahale and Prometheus stats providers should be in a different package name

sijie opened a new issue #762: Codahale and Prometheus stats providers should be in a different package name URL: https://github.com/apache/bookkeeper/issues/762 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Codahale and Prometheus stats providers

[GitHub] sijie commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals

sijie commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/pull/760#discussion_r152692268 ## File path: site/bps/BP-template.md ## @@ -0,0 +1,42 @@ +--- +title: "BP-XYZ: capation of

[GitHub] sijie commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals

sijie commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/pull/760#discussion_r152692123 ## File path: site/bps/BP-template.md ## @@ -0,0 +1,42 @@ +--- +title: "BP-XYZ: capation of

[GitHub] itsuugo commented on issue #328: Docker image: add a Docker Compose example file

itsuugo commented on issue #328: Docker image: add a Docker Compose example file URL: https://github.com/apache/bookkeeper/issues/328#issuecomment-346483469 I guess that I found the problem: ``` bookkeeper_1 | BK_CLUSTER_ROOT_PATH is bookkeeper_1 | BK_bookiePort bookie

[GitHub] itsuugo commented on issue #328: Docker image: add a Docker Compose example file

itsuugo commented on issue #328: Docker image: add a Docker Compose example file URL: https://github.com/apache/bookkeeper/issues/328#issuecomment-346483469 I guess that I found the problem: ``` bookkeeper_1 | BK_CLUSTER_ROOT_PATH is bookkeeper_1 | BK_bookiePort bookie

[GitHub] itsuugo commented on issue #328: Docker image: add a Docker Compose example file

itsuugo commented on issue #328: Docker image: add a Docker Compose example file URL: https://github.com/apache/bookkeeper/issues/328#issuecomment-346483469 I found the problem: ``` bookkeeper_1 | BK_CLUSTER_ROOT_PATH is bookkeeper_1 | BK_bookiePort bookie service port is

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152675436 ## File path:

[GitHub] eolivelli commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals

eolivelli commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/pull/760#discussion_r152671762 ## File path: site/bps/BP-template.md ## @@ -0,0 +1,42 @@ +--- +title: "BP-XYZ: capation of

[GitHub] eolivelli commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals

eolivelli commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/pull/760#discussion_r152672076 ## File path: site/bps/BP-template.md ## @@ -0,0 +1,42 @@ +--- +title: "BP-XYZ: capation of

[GitHub] sijie opened a new issue #761: BP-20: Github workflow for bookkeeper proposals

sijie opened a new issue #761: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/issues/761 **BP** This is the master ticket for tracking BP-20 : Implementing a github workflow for bookkeeper proposals, so all the bookkeeper proposals

[GitHub] sijie opened a new pull request #760: BP-20: Github workflow for bookkeeper proposals

sijie opened a new pull request #760: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/pull/760 Descriptions of the changes in this PR: Implementing a github workflow for bookkeeper proposals, so all the bookkeeper proposals can be reviewed

[GitHub] sijie commented on issue #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

sijie commented on issue #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#issuecomment-346440293 @ivankelly I addressed your comments. please take a look.

[GitHub] sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152649602 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152645332 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152639133 ## File path:

[GitHub] sijie commented on a change in pull request #759: (WIP)Issue 695: add release notes for 4.6.0

sijie commented on a change in pull request #759: (WIP)Issue 695: add release notes for 4.6.0 URL: https://github.com/apache/bookkeeper/pull/759#discussion_r152638408 ## File path: site/docs/4.6.0/overview/releaseNotes.md ## @@ -2,16 +2,35 @@ title: Apache BookKeeper

[GitHub] sijie commented on a change in pull request #759: (WIP)Issue 695: add release notes for 4.6.0

sijie commented on a change in pull request #759: (WIP)Issue 695: add release notes for 4.6.0 URL: https://github.com/apache/bookkeeper/pull/759#discussion_r152638318 ## File path: site/docs/4.6.0/overview/releaseNotes.md ## @@ -2,16 +2,35 @@ title: Apache BookKeeper

[GitHub] sijie commented on a change in pull request #759: (WIP)Issue 695: add release notes for 4.6.0

sijie commented on a change in pull request #759: (WIP)Issue 695: add release notes for 4.6.0 URL: https://github.com/apache/bookkeeper/pull/759#discussion_r152638194 ## File path: site/docs/4.6.0/overview/releaseNotes.md ## @@ -2,16 +2,35 @@ title: Apache BookKeeper

[GitHub] sijie commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie

sijie commented on issue #712: Issue 544: Bootup cookie validation considers an empty journal to signify a new bookie URL: https://github.com/apache/bookkeeper/pull/712#issuecomment-346427007 @jvrao ping? This is an

[GitHub] sijie closed pull request #758: fix releases.md, add release date for 4.5.1 and clean up file

sijie closed pull request #758: fix releases.md, add release date for 4.5.1 and clean up file URL: https://github.com/apache/bookkeeper/pull/758 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] sijie commented on issue #758: fix releases.md, add release date for 4.5.1 and clean up file

sijie commented on issue #758: fix releases.md, add release date for 4.5.1 and clean up file URL: https://github.com/apache/bookkeeper/pull/758#issuecomment-346425884 lgtm +1 This is an automated message from the Apache Git

[GitHub] merlimat commented on a change in pull request #754: Issue #753: Allow option to disable data sync on journal

merlimat commented on a change in pull request #754: Issue #753: Allow option to disable data sync on journal URL: https://github.com/apache/bookkeeper/pull/754#discussion_r152632745 ## File path: bookkeeper-server/conf/bk_server.conf ## @@ -296,6 +296,10 @@

[GitHub] merlimat commented on a change in pull request #754: Issue #753: Allow option to disable data sync on journal

merlimat commented on a change in pull request #754: Issue #753: Allow option to disable data sync on journal URL: https://github.com/apache/bookkeeper/pull/754#discussion_r152632489 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152628155 ## File path:

[GitHub] zhaijack opened a new pull request #759: (WIP)Issue 695: add release notes for 4.6.0

zhaijack opened a new pull request #759: (WIP)Issue 695: add release notes for 4.6.0 URL: https://github.com/apache/bookkeeper/pull/759 Descriptions of the changes in this PR: add release notes for 4.6.0, this is still WIP. > --- > Be sure to do all of the following to help us

[GitHub] jiazhai commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

jiazhai commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152553438 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152550963 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152549714 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152548916 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152545958 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152544979 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152542991 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152543344 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152542872 ## File path:

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152541820 ## File path:

[GitHub] ivankelly commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346325678 @zhaijack it's good to have it here too, so that when we look at the git log, we don't have to jump back to the issue

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520301 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520412 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152522492 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152522259 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520795 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r15252 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152519495 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520927 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152519254 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520871 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152519840 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152522328 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152519764 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520550 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152520211 ## File path:

[GitHub] ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

ivankelly commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152521440 ## File path:

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346308299 @ivankelly @sijie updated. This is an automated message

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152518536 ## File path:

[GitHub] ivankelly commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

ivankelly commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r152518358 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152516308 ## File path:

[GitHub] jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on issue #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#issuecomment-346301408 @ivan, Thanks for the comments, the reason is described in the issue, will move it here.

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152515790 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] ivankelly commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

ivankelly commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r152515374 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152515198 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntries.java

[GitHub] sijie commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

sijie commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r152513783 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java

[GitHub] jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

jiazhai commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152513610 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152512523 ## File path:

[GitHub] ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

ivankelly commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152511643 ## File path:

[GitHub] ivankelly commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation

ivankelly commented on a change in pull request #738: Issue 731: refine LedgerEntry interface and implementation URL: https://github.com/apache/bookkeeper/pull/738#discussion_r152510710 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/api/LedgerEntry.java

[GitHub] sijie commented on a change in pull request #758: fix releases.md, add release date for 4.5.1 and clean up file

sijie commented on a change in pull request #758: fix releases.md, add release date for 4.5.1 and clean up file URL: https://github.com/apache/bookkeeper/pull/758#discussion_r152510397 ## File path: site/.ruby-version ## @@ -0,0 +1 @@ +2.4.1 Review comment: ?? what

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152509013 ## File path:

[GitHub] sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries

sijie commented on a change in pull request #727: Issue 693: add interface and implementation of LedgerEntries URL: https://github.com/apache/bookkeeper/pull/727#discussion_r152509013 ## File path:

[GitHub] sijie closed pull request #752: Add release 4.6.0 to releases menu

sijie closed pull request #752: Add release 4.6.0 to releases menu URL: https://github.com/apache/bookkeeper/pull/752 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle

sijie commented on a change in pull request #755: Issue 750: support ByteBuf, ByteBuffer, byte[] in both WriteHandle, WriteAdvHandle, ReadHandle URL: https://github.com/apache/bookkeeper/pull/755#discussion_r152492194 ## File path:

[GitHub] eolivelli closed issue #732: Release 4.5.1: update docker image file after 4.5.1 is released

eolivelli closed issue #732: Release 4.5.1: update docker image file after 4.5.1 is released URL: https://github.com/apache/bookkeeper/issues/732 This is an automated message from the Apache Git Service. To respond to the

[GitHub] sijie commented on issue #757: Improve javadoc for public interfaces that takes user input

sijie commented on issue #757: Improve javadoc for public interfaces that takes user input URL: https://github.com/apache/bookkeeper/issues/757#issuecomment-346274613 This is from a discussion at #755 This is an automated

[GitHub] sijie opened a new issue #757: Improve javadoc for public interfaces that takes user input

sijie opened a new issue #757: Improve javadoc for public interfaces that takes user input URL: https://github.com/apache/bookkeeper/issues/757 **FEATURE REQUEST** 1. Please describe the feature you are requesting. per review comment at

[GitHub] sijie commented on a change in pull request #754: Issue #753: Allow option to disable data sync on journal

sijie commented on a change in pull request #754: Issue #753: Allow option to disable data sync on journal URL: https://github.com/apache/bookkeeper/pull/754#discussion_r152491411 ## File path: bookkeeper-server/conf/bk_server.conf ## @@ -296,6 +296,10 @@

[GitHub] sijie opened a new issue #756: Introduce annotations for features / configuration settings

sijie opened a new issue #756: Introduce annotations for features / configuration settings URL: https://github.com/apache/bookkeeper/issues/756 **FEATURE REQUEST** 1. Please describe the feature you are requesting. We have `InterfaceAudience` and `InterfaceStability`

  1   2   >