[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli As I understand, if `hasArg` of an `Option` set to true, it means that an argument is required after this op

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli As I understand, if `hasArg` of an `Option` set to true, it means that an argument is required after this op

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli As I understand, if `hasArg` of an `Option` set to true, it means that an argument is required after this op

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli , I think maybe we has different understand on the `hasArg` flag. As I understand, if `hasArg` of an `Option` se

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli , I think maybe we has different understand on the `hasArg` flag. As I understand, if `hasArg` of an `Option` se

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli , I think maybe we has different understand on the `hasArg` flag in `org.apache.commons.cli.Options#addOption`.

[GitHub] [bookkeeper] aloyszhang commented on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang commented on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595296333 cc @eolivelli please have a look. This is an automated message from th

[GitHub] [bookkeeper] aloyszhang opened a new pull request #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang opened a new pull request #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280 Descriptions of the changes in this PR: This PR fix NullPointerException when exec readjournal command See issue #2279

[GitHub] [bookkeeper] eolivelli commented on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
eolivelli commented on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595302776 I am sorry. I clicked on 'close and comment' instead of 'comment' Th

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli , I think maybe we has different understand on the `hasArg` flag in `org.apache.commons.cli.Options#addOption`.

[GitHub] [bookkeeper] aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command

2020-03-05 Thread GitBox
aloyszhang edited a comment on issue #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280#issuecomment-595279073 @eolivelli , I think maybe we had different understand on the `hasArg` flag in `org.apache.commons.cli.Options#addOption`.

[GitHub] [bookkeeper] eolivelli closed issue #2178: JournalChannel should throw IOException if it cannot seek to desired position

2020-03-05 Thread GitBox
eolivelli closed issue #2178: JournalChannel should throw IOException if it cannot seek to desired position URL: https://github.com/apache/bookkeeper/issues/2178 This is an automated message from the Apache Git Service. To r

[GitHub] [bookkeeper] eolivelli merged pull request #2257: 2178: IOException Should Be Thrown When Journal Is Corrupted

2020-03-05 Thread GitBox
eolivelli merged pull request #2257: 2178: IOException Should Be Thrown When Journal Is Corrupted URL: https://github.com/apache/bookkeeper/pull/2257 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [bookkeeper] eolivelli commented on issue #2257: 2178: IOException Should Be Thrown When Journal Is Corrupted

2020-03-05 Thread GitBox
eolivelli commented on issue #2257: 2178: IOException Should Be Thrown When Journal Is Corrupted URL: https://github.com/apache/bookkeeper/pull/2257#issuecomment-595633930 Merged to master branch, thank you @atris sorry that it took so much time. I hope that our CI will be in bet

[GitHub] [bookkeeper] eolivelli commented on issue #2241: Fixes vertx can not receive the request body

2020-03-05 Thread GitBox
eolivelli commented on issue #2241: Fixes vertx can not receive the request body URL: https://github.com/apache/bookkeeper/pull/2241#issuecomment-595634129 @sijie I would like to merge this change, can you please take a look ?

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2240: fix the problem that the method InetAddress.getLocalHost().getHostAddress() gets ip as 127.0.0.1

2020-03-05 Thread GitBox
eolivelli commented on a change in pull request #2240: fix the problem that the method InetAddress.getLocalHost().getHostAddress() gets ip as 127.0.0.1 URL: https://github.com/apache/bookkeeper/pull/2240#discussion_r388745813 ## File path: bookkeeper-server/src/main/java/org/apache

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2240: fix the problem that the method InetAddress.getLocalHost().getHostAddress() gets ip as 127.0.0.1

2020-03-05 Thread GitBox
eolivelli commented on a change in pull request #2240: fix the problem that the method InetAddress.getLocalHost().getHostAddress() gets ip as 127.0.0.1 URL: https://github.com/apache/bookkeeper/pull/2240#discussion_r388745909 ## File path: bookkeeper-server/src/main/java/org/apache

[GitHub] [bookkeeper] eolivelli commented on issue #2206: Remove lock from URManager’s state only if lock znode deletion has succeeded

2020-03-05 Thread GitBox
eolivelli commented on issue #2206: Remove lock from URManager’s state only if lock znode deletion has succeeded URL: https://github.com/apache/bookkeeper/pull/2206#issuecomment-595635887 @reddycharan do you have time to move forward this work? It would be awesome to have this fix in 4.1

[GitHub] [bookkeeper] eolivelli commented on issue #2231: Fix batch read data in cache does not take effect

2020-03-05 Thread GitBox
eolivelli commented on issue #2231: Fix batch read data in cache does not take effect URL: https://github.com/apache/bookkeeper/pull/2231#issuecomment-595636193 @liudezhi2098 can you please merge with master branch so that CI kicks in again ? We had problems with GitHub actions, hopefu

[GitHub] [bookkeeper] eolivelli commented on issue #2176: Journal scan should throw IOException when it reads negative length

2020-03-05 Thread GitBox
eolivelli commented on issue #2176: Journal scan should throw IOException when it reads negative length URL: https://github.com/apache/bookkeeper/issues/2176#issuecomment-595637118 @atris it looks like we already merged a fix for this problem https://github.com/apache/bookkeeper/pull/217

[GitHub] [bookkeeper] eolivelli merged pull request #2268: Move the result of the BKCTL to the console by default

2020-03-05 Thread GitBox
eolivelli merged pull request #2268: Move the result of the BKCTL to the console by default URL: https://github.com/apache/bookkeeper/pull/2268 This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [bookkeeper] eolivelli commented on issue #2241: Fixes vertx can not receive the request body

2020-03-05 Thread GitBox
eolivelli commented on issue #2241: Fixes vertx can not receive the request body URL: https://github.com/apache/bookkeeper/pull/2241#issuecomment-595643052 @zymap can you please rebase to current master ? we have fixed a problem with github actions and checkout -

[GitHub] [bookkeeper] rdhabalia opened a new pull request #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-06 Thread GitBox
rdhabalia opened a new pull request #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281 ### Motivation As discussed at https://github.com/apache/pulsar/issues/6505 Bk-client was not abl

[GitHub] [bookkeeper] eolivelli commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-07 Thread GitBox
eolivelli commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#issuecomment-596061151 This is related to #2273 T

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-07 Thread GitBox
eolivelli commented on a change in pull request #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#discussion_r389238677 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeep

[GitHub] [bookkeeper] eolivelli commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-07 Thread GitBox
eolivelli commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#issuecomment-596083925 Okay. We are waiting for WQ - AQ +1 so: - WQ=2 AQ=2 wait for 1, it is okay as all boo

[GitHub] [bookkeeper] eolivelli commented on issue #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up

2020-03-07 Thread GitBox
eolivelli commented on issue #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up URL: https://github.com/apache/bookkeeper/pull/2219#issuecomment-596088170 This we have this problems: [ERROR] TableClientTest » ContainerLaunch Contain

[GitHub] [bookkeeper] eolivelli commented on issue #2233: Drop Maven Profile -Dstream

2020-03-07 Thread GitBox
eolivelli commented on issue #2233: Drop Maven Profile -Dstream URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-596089413 @jiazhai can you please help merging this patch ? This is an automated message from

[GitHub] [bookkeeper] jiazhai merged pull request #2233: Drop Maven Profile -Dstream

2020-03-07 Thread GitBox
jiazhai merged pull request #2233: Drop Maven Profile -Dstream URL: https://github.com/apache/bookkeeper/pull/2233 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [bookkeeper] dependabot[bot] closed pull request #2189: Bump jekyll from 3.7.0 to 3.7.4 in /site

2020-03-07 Thread GitBox
dependabot[bot] closed pull request #2189: Bump jekyll from 3.7.0 to 3.7.4 in /site URL: https://github.com/apache/bookkeeper/pull/2189 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [bookkeeper] dependabot[bot] closed pull request #2188: Bump nokogiri from 1.8.2 to 1.10.4 in /site

2020-03-07 Thread GitBox
dependabot[bot] closed pull request #2188: Bump nokogiri from 1.8.2 to 1.10.4 in /site URL: https://github.com/apache/bookkeeper/pull/2188 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [bookkeeper] dependabot[bot] opened a new pull request #2282: Bump nokogiri from 1.10.7 to 1.10.8 in /site

2020-03-07 Thread GitBox
dependabot[bot] opened a new pull request #2282: Bump nokogiri from 1.10.7 to 1.10.8 in /site URL: https://github.com/apache/bookkeeper/pull/2282 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.7 to 1.10.8. Release notes Sourced from https://github.com/spark

[GitHub] [bookkeeper] dependabot[bot] commented on issue #2189: Bump jekyll from 3.7.0 to 3.7.4 in /site

2020-03-07 Thread GitBox
dependabot[bot] commented on issue #2189: Bump jekyll from 3.7.0 to 3.7.4 in /site URL: https://github.com/apache/bookkeeper/pull/2189#issuecomment-596090325 Looks like jekyll is up-to-date now, so this is no longer needed. T

[GitHub] [bookkeeper] dependabot[bot] commented on issue #2188: Bump nokogiri from 1.8.2 to 1.10.4 in /site

2020-03-07 Thread GitBox
dependabot[bot] commented on issue #2188: Bump nokogiri from 1.8.2 to 1.10.4 in /site URL: https://github.com/apache/bookkeeper/pull/2188#issuecomment-596090350 Superseded by #2282. This is an automated message from the Apach

[GitHub] [bookkeeper] eolivelli opened a new pull request #2283: Make bookkeeper script work on Git Bash on Windows

2020-03-08 Thread GitBox
eolivelli opened a new pull request #2283: Make bookkeeper script work on Git Bash on Windows URL: https://github.com/apache/bookkeeper/pull/2283 Descriptions of the changes in this PR: ### Motivation Add the ability to run "bookkeeper" in a Windows environment with "G

[GitHub] [bookkeeper] eolivelli commented on issue #2283: Make bookkeeper script work on Git Bash on Windows

2020-03-08 Thread GitBox
eolivelli commented on issue #2283: Make bookkeeper script work on Git Bash on Windows URL: https://github.com/apache/bookkeeper/pull/2283#issuecomment-596199376 @mino181295 @dmercuriali please take a look. Unfortunately BK cannot be built on windows but you can use the patched 'bin/boo

[GitHub] [bookkeeper] ravisharda commented on issue #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up

2020-03-08 Thread GitBox
ravisharda commented on issue #2219: Issue #2212: Fix issues in Bookkeeper Docker image that prevented containers from starting up URL: https://github.com/apache/bookkeeper/pull/2219#issuecomment-596307143 @eolivelli sorry, I am not getting any time to debug/resolve the test issues, which

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2283: Make bookkeeper script work on Git Bash on Windows

2020-03-09 Thread GitBox
eolivelli commented on a change in pull request #2283: Make bookkeeper script work on Git Bash on Windows URL: https://github.com/apache/bookkeeper/pull/2283#discussion_r389579517 ## File path: bin/bookkeeper ## @@ -156,26 +162,27 @@ fi #Change to BK_HOME to support relat

[GitHub] [bookkeeper] eolivelli merged pull request #2241: Fixes vertx can not receive the request body

2020-03-09 Thread GitBox
eolivelli merged pull request #2241: Fixes vertx can not receive the request body URL: https://github.com/apache/bookkeeper/pull/2241 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [bookkeeper] rdhabalia commented on a change in pull request #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-09 Thread GitBox
rdhabalia commented on a change in pull request #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#discussion_r390007211 ## File path: bookkeeper-server/src/test/java/org/apache/bookkeep

[GitHub] [bookkeeper] rdhabalia commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-09 Thread GitBox
rdhabalia commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#issuecomment-596821669 @eolivelli @diegosalvi I have spent some time to cover most of the usecases with multiple

[GitHub] [bookkeeper] hangc0276 opened a new pull request #2284: fix bookie decommission sleep timeout value is negative bug

2020-03-10 Thread GitBox
hangc0276 opened a new pull request #2284: fix bookie decommission sleep timeout value is negative bug URL: https://github.com/apache/bookkeeper/pull/2284 when decommission a bookie, and the ledger size of the bookie is big enough, the thread timeout will get negative, and the decommission

[GitHub] [bookkeeper] eolivelli commented on issue #2284: fix bookie decommission sleep timeout value is negative bug

2020-03-10 Thread GitBox
eolivelli commented on issue #2284: fix bookie decommission sleep timeout value is negative bug URL: https://github.com/apache/bookkeeper/pull/2284#issuecomment-596970929 Nice catch This is an automated message from the Apach

[GitHub] [bookkeeper] hangc0276 commented on issue #2284: fix bookie decommission sleep timeout value is negative bug

2020-03-10 Thread GitBox
hangc0276 commented on issue #2284: fix bookie decommission sleep timeout value is negative bug URL: https://github.com/apache/bookkeeper/pull/2284#issuecomment-596997483 rerun This is an automated message from the Apache Git

[GitHub] [bookkeeper] eolivelli commented on issue #2284: fix bookie decommission sleep timeout value is negative bug

2020-03-10 Thread GitBox
eolivelli commented on issue #2284: fix bookie decommission sleep timeout value is negative bug URL: https://github.com/apache/bookkeeper/pull/2284#issuecomment-597020001 I am sorry, only users with write permissions can trigger a single check. I will do it. ---

[GitHub] [bookkeeper] eolivelli commented on issue #2284: fix bookie decommission sleep timeout value is negative bug

2020-03-10 Thread GitBox
eolivelli commented on issue #2284: fix bookie decommission sleep timeout value is negative bug URL: https://github.com/apache/bookkeeper/pull/2284#issuecomment-597038997 @jiazhai we are good to go now This is an automated me

[GitHub] [bookkeeper] eolivelli merged pull request #2284: fix bookie decommission sleep timeout value is negative bug

2020-03-10 Thread GitBox
eolivelli merged pull request #2284: fix bookie decommission sleep timeout value is negative bug URL: https://github.com/apache/bookkeeper/pull/2284 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [bookkeeper] hamadodene opened a new issue #2285: Spammy log when one bookie of ensemble is down

2020-03-10 Thread GitBox
hamadodene opened a new issue #2285: Spammy log when one bookie of ensemble is down URL: https://github.com/apache/bookkeeper/issues/2285 When one bookie of the ensemble is down, the other bookies client spam in the log ***org.apache.bookkeeper.proto.PerChannelBookieClient*** this except

[GitHub] [bookkeeper] rdhabalia commented on issue #1949: [bookie-gc] add option to cache entry-log metadata map into rocksDB

2020-03-10 Thread GitBox
rdhabalia commented on issue #1949: [bookie-gc] add option to cache entry-log metadata map into rocksDB URL: https://github.com/apache/bookkeeper/pull/1949#issuecomment-597276662 ping.. can we merge this or #1938.. we will be fine with either option as far as we have option to prevent this

[GitHub] [bookkeeper] rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories

2020-03-10 Thread GitBox
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-597278220 thanks @eolivelli , hopefully it passes once we retrigger the job again.. please let me know if you want me to re

[GitHub] [bookkeeper] eolivelli opened a new pull request #2286: Do not log WARNING about PlacementPolicy for tests and simple setups

2020-03-12 Thread GitBox
eolivelli opened a new pull request #2286: Do not log WARNING about PlacementPolicy for tests and simple setups URL: https://github.com/apache/bookkeeper/pull/2286 Descriptions of the changes in this PR: Do not log 'New ensemble: {} is not adhering to Placement Policy. quarantinedBo

[GitHub] [bookkeeper] eolivelli commented on issue #2286: Do not log WARNING about PlacementPolicy for tests and simple setups

2020-03-12 Thread GitBox
eolivelli commented on issue #2286: Do not log WARNING about PlacementPolicy for tests and simple setups URL: https://github.com/apache/bookkeeper/pull/2286#issuecomment-598092255 @atris @mino181295 @diegosalvi PTAL This is

[GitHub] [bookkeeper] mino181295 commented on issue #2286: Do not log WARNING about PlacementPolicy for tests and simple setups

2020-03-12 Thread GitBox
mino181295 commented on issue #2286: Do not log WARNING about PlacementPolicy for tests and simple setups URL: https://github.com/apache/bookkeeper/pull/2286#issuecomment-598162992 +1, LGTM This is an automated message from t

[GitHub] [bookkeeper] atris commented on issue #2286: Do not log WARNING about PlacementPolicy for tests and simple setups

2020-03-12 Thread GitBox
atris commented on issue #2286: Do not log WARNING about PlacementPolicy for tests and simple setups URL: https://github.com/apache/bookkeeper/pull/2286#issuecomment-598164297 +1, please go ahead -- Regards, Atri *l'apprenant* --

[GitHub] [bookkeeper] rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories

2020-03-12 Thread GitBox
rdhabalia commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-598473696 can we retrigger this job.. This is an autom

[GitHub] [bookkeeper] eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories

2020-03-12 Thread GitBox
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-598566709 Merging as soon as tests pass This is an automat

[GitHub] [bookkeeper] eolivelli closed pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories

2020-03-12 Thread GitBox
eolivelli closed pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245 This is an automated message from the Apache Git Service. To respond

[GitHub] [bookkeeper] eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories

2020-03-12 Thread GitBox
eolivelli commented on issue #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245#issuecomment-598566807 It failed again This is an automated message fro

[GitHub] [bookkeeper] rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories

2020-03-12 Thread GitBox
rdhabalia opened a new pull request #2245: [bookie-server-config] Avoid considering empty journalDirectories URL: https://github.com/apache/bookkeeper/pull/2245 As discussed at : https://github.com/apache/pulsar/issues/6042 ### Issue We have config management tool which manages bo

[GitHub] [bookkeeper] hangc0276 opened a new pull request #2287: Add Journal PageCache flush interval control when journalSyncData is disabled

2020-03-13 Thread GitBox
hangc0276 opened a new pull request #2287: Add Journal PageCache flush interval control when journalSyncData is disabled URL: https://github.com/apache/bookkeeper/pull/2287 Descriptions of the changes in this PR: ### Motivation There was a weird behavior observed: when journalSyncData

[GitHub] [bookkeeper] hangc0276 commented on issue #2287: Add Journal PageCache flush interval control when journalSyncData is disabled

2020-03-13 Thread GitBox
hangc0276 commented on issue #2287: Add Journal PageCache flush interval control when journalSyncData is disabled URL: https://github.com/apache/bookkeeper/pull/2287#issuecomment-598644378 ok, i will add test cases for this change. --

[GitHub] [bookkeeper] eolivelli commented on issue #2288: Add ledger metadata to Ledger created by StreamStorage Module

2020-03-14 Thread GitBox
eolivelli commented on issue #2288: Add ledger metadata to Ledger created by StreamStorage Module URL: https://github.com/apache/bookkeeper/issues/2288#issuecomment-599023099 a preparative work has been done by @dmercuriali with b84178af53d631b268143f9b8b0a3c3f731bf68a --

[GitHub] [bookkeeper] eolivelli opened a new issue #2288: Add ledger metadata to Ledger created by StreamStorage Module

2020-03-14 Thread GitBox
eolivelli opened a new issue #2288: Add ledger metadata to Ledger created by StreamStorage Module URL: https://github.com/apache/bookkeeper/issues/2288 **FEATURE REQUEST** 1. Please describe the feature you are requesting. Please add meaningful information to ledger created by Str

[GitHub] [bookkeeper] chairmank opened a new issue #2289: distribute Python apache-bookkeeper-client as a Conda package

2020-03-14 Thread GitBox
chairmank opened a new issue #2289: distribute Python apache-bookkeeper-client as a Conda package URL: https://github.com/apache/bookkeeper/issues/2289 **FEATURE REQUEST** 1. Please describe the feature you are requesting. I would like to be able to install the Python client libra

[GitHub] [bookkeeper] chairmank commented on issue #2289: distribute Python apache-bookkeeper-client as a Conda package

2020-03-14 Thread GitBox
chairmank commented on issue #2289: distribute Python apache-bookkeeper-client as a Conda package URL: https://github.com/apache/bookkeeper/issues/2289#issuecomment-599081277 I am familiar with Conda packages and volunteer to help. --

[GitHub] [bookkeeper] eolivelli commented on issue #2289: distribute Python apache-bookkeeper-client as a Conda package

2020-03-14 Thread GitBox
eolivelli commented on issue #2289: distribute Python apache-bookkeeper-client as a Conda package URL: https://github.com/apache/bookkeeper/issues/2289#issuecomment-599097315 @chairmank thank you, please send a PR. If we have to update our release procedure please send a PR for that as

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #1949: [bookie-gc] add option to cache entry-log metadata map into rocksDB

2020-03-15 Thread GitBox
eolivelli commented on a change in pull request #1949: [bookie-gc] add option to cache entry-log metadata map into rocksDB URL: https://github.com/apache/bookkeeper/pull/1949#discussion_r392799809 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCol

[GitHub] [bookkeeper] dmercuriali commented on issue #2288: Add ledger metadata to Ledger created by StreamStorage Module

2020-03-16 Thread GitBox
dmercuriali commented on issue #2288: Add ledger metadata to Ledger created by StreamStorage Module URL: https://github.com/apache/bookkeeper/issues/2288#issuecomment-599513834 Picking this up This is an automated message fro

[GitHub] [bookkeeper] hangc0276 commented on issue #2287: Add Journal PageCache flush interval control when journalSyncData is disabled

2020-03-17 Thread GitBox
hangc0276 commented on issue #2287: Add Journal PageCache flush interval control when journalSyncData is disabled URL: https://github.com/apache/bookkeeper/pull/2287#issuecomment-600025577 I add a test case, please take a look @jiazhai @eolivelli @sijie @merlimat when an entry add i

[GitHub] [bookkeeper] hangc0276 opened a new pull request #2290: fix some stats monitor metrics

2020-03-17 Thread GitBox
hangc0276 opened a new pull request #2290: fix some stats monitor metrics URL: https://github.com/apache/bookkeeper/pull/2290 Descriptions of the changes in this PR: The journalStats.getJournalQueueSize increase once and decrease twice, so this stat metric will be negative. It

[GitHub] [bookkeeper] eolivelli opened a new pull request #2291: Update Prometheus library to 0.8.1

2020-03-18 Thread GitBox
eolivelli opened a new pull request #2291: Update Prometheus library to 0.8.1 URL: https://github.com/apache/bookkeeper/pull/2291 Descriptions of the changes in this PR: Update Prometheus library to 0.8.1 ### Motivation We have an obsolete version ### Changes U

[GitHub] [bookkeeper] eolivelli opened a new issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0

2020-03-18 Thread GitBox
eolivelli opened a new issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0 URL: https://github.com/apache/bookkeeper/issues/2292 We are using the Utility function org.apache.zookeeper.ZKUtil.deleteRecursive that has been changed in 3.6.0. ***To Reproduce*** Use ZooKe

[GitHub] [bookkeeper] eolivelli commented on issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0

2020-03-18 Thread GitBox
eolivelli commented on issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0 URL: https://github.com/apache/bookkeeper/issues/2292#issuecomment-600793723 I have created an issue in ZooKeeper https://issues.apache.org/jira/browse/ZOOKEEPER-3763 -

[GitHub] [bookkeeper] sijie merged pull request #2291: Update Prometheus library to 0.8.1

2020-03-18 Thread GitBox
sijie merged pull request #2291: Update Prometheus library to 0.8.1 URL: https://github.com/apache/bookkeeper/pull/2291 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [bookkeeper] sijie merged pull request #2290: fix some stats monitor metrics

2020-03-18 Thread GitBox
sijie merged pull request #2290: fix some stats monitor metrics URL: https://github.com/apache/bookkeeper/pull/2290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [bookkeeper] sijie merged pull request #2287: Add Journal PageCache flush interval control when journalSyncData is disabled

2020-03-18 Thread GitBox
sijie merged pull request #2287: Add Journal PageCache flush interval control when journalSyncData is disabled URL: https://github.com/apache/bookkeeper/pull/2287 This is an automated message from the Apache Git Service. To

[GitHub] [bookkeeper] sijie merged pull request #2286: Do not log WARNING about PlacementPolicy for tests and simple setups

2020-03-18 Thread GitBox
sijie merged pull request #2286: Do not log WARNING about PlacementPolicy for tests and simple setups URL: https://github.com/apache/bookkeeper/pull/2286 This is an automated message from the Apache Git Service. To respond t

[GitHub] [bookkeeper] sijie commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-18 Thread GitBox
sijie commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#issuecomment-600903706 @eolivelli please take a look

[GitHub] [bookkeeper] sijie merged pull request #2151: [bookie-mtls] add BouncyCastleProvider for security-provider to avoid InvalidKeyException

2020-03-18 Thread GitBox
sijie merged pull request #2151: [bookie-mtls] add BouncyCastleProvider for security-provider to avoid InvalidKeyException URL: https://github.com/apache/bookkeeper/pull/2151 This is an automated message from the Apache Git

[GitHub] [bookkeeper] sijie commented on issue #2156: [bookie-mTLS] add support of hostname verification

2020-03-18 Thread GitBox
sijie commented on issue #2156: [bookie-mTLS] add support of hostname verification URL: https://github.com/apache/bookkeeper/pull/2156#issuecomment-600909215 @rdhabalia can you rebase this pull request? This is an automated m

[GitHub] [bookkeeper] sijie merged pull request #2280: #2279 fix NPE when exec readjournal command

2020-03-18 Thread GitBox
sijie merged pull request #2280: #2279 fix NPE when exec readjournal command URL: https://github.com/apache/bookkeeper/pull/2280 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [bookkeeper] eolivelli opened a new pull request #2293: Remove old Jenkins stuff for GitHub Create Pull Request template

2020-03-19 Thread GitBox
eolivelli opened a new pull request #2293: Remove old Jenkins stuff for GitHub Create Pull Request template URL: https://github.com/apache/bookkeeper/pull/2293 This is an automated message from the Apache Git Service. To res

[GitHub] [bookkeeper] eolivelli opened a new issue #2294: Full build download distributedlog from apache snapshots repository

2020-03-20 Thread GitBox
eolivelli opened a new issue #2294: Full build download distributedlog from apache snapshots repository URL: https://github.com/apache/bookkeeper/issues/2294 **BUG REPORT** ***Describe the bug*** If you fresh clone bookkeeper from github, with an empty Maven repository, Maven

[GitHub] [bookkeeper] zyllt commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active

2020-03-22 Thread GitBox
zyllt commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active URL: https://github.com/apache/bookkeeper/issues/2216#issuecomment-602229019 @aschiazza Hi,I started StreamStorageLifecycleComponent according to your configuration, but

[GitHub] [bookkeeper] eolivelli commented on issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0

2020-03-22 Thread GitBox
eolivelli commented on issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0 URL: https://github.com/apache/bookkeeper/issues/2292#issuecomment-602232456 With ZK 3.6.1 we won't have this problem anymore, see https://github.com/apache/zookeeper/pull/1287 ---

[GitHub] [bookkeeper] eolivelli edited a comment on issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0

2020-03-22 Thread GitBox
eolivelli edited a comment on issue #2292: BookKeeper is not compatible with ZookKeeper 3.6.0 URL: https://github.com/apache/bookkeeper/issues/2292#issuecomment-602232456 With ZK 3.6.1 we won't have this problem anymore, see the fix for ZOOKEEPER-3763 https://github.com/apache/zookee

[GitHub] [bookkeeper] zyllt opened a new issue #2295: Incorrect StreamStorageLifecycleComponent ip address registered in zookeeper

2020-03-23 Thread GitBox
zyllt opened a new issue #2295: Incorrect StreamStorageLifecycleComponent ip address registered in zookeeper URL: https://github.com/apache/bookkeeper/issues/2295 **QUESTION** when I start the streamtorage service use `extraServerComponents=org.apache.bookkeeper.stream.server.StreamSto

[GitHub] [bookkeeper] dmercuriali opened a new pull request #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
dmercuriali opened a new pull request #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296 Descriptions of the changes in this PR: Added 'application' and 'component' metadata to StreamStorage ledgers. application: bk-stream-stor

[GitHub] [bookkeeper] eolivelli commented on issue #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
eolivelli commented on issue #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296#issuecomment-602464451 @mino181295 PTAL This is an automated message from the Apache Git Se

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
eolivelli commented on a change in pull request #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296#discussion_r396293015 ## File path: stream/statelib/src/main/java/org/apache/bookkeeper/statelib/impl/rocksdb/checkpoint/dlog/DLC

[GitHub] [bookkeeper] dmercuriali commented on a change in pull request #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
dmercuriali commented on a change in pull request #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296#discussion_r396309472 ## File path: stream/statelib/src/main/java/org/apache/bookkeeper/statelib/impl/rocksdb/checkpoint/dlog/D

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
eolivelli commented on a change in pull request #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296#discussion_r396318361 ## File path: stream/statelib/src/main/java/org/apache/bookkeeper/statelib/impl/rocksdb/checkpoint/dlog/DLC

[GitHub] [bookkeeper] eolivelli commented on issue #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
eolivelli commented on issue #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296#issuecomment-602484590 @sijie all tests are passing. can you please take a look ? This i

[GitHub] [bookkeeper] mino181295 commented on issue #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
mino181295 commented on issue #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296#issuecomment-602532995 Looks good to me This is an automated message from the Apache Git S

[GitHub] [bookkeeper] jiazhai merged pull request #2293: Remove old Jenkins stuff for GitHub Create Pull Request template

2020-03-23 Thread GitBox
jiazhai merged pull request #2293: Remove old Jenkins stuff for GitHub Create Pull Request template URL: https://github.com/apache/bookkeeper/pull/2293 This is an automated message from the Apache Git Service. To respond to

[GitHub] [bookkeeper] jiazhai merged pull request #2296: #2288: add metadata to StreamStorage ledgers

2020-03-23 Thread GitBox
jiazhai merged pull request #2296: #2288: add metadata to StreamStorage ledgers URL: https://github.com/apache/bookkeeper/pull/2296 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [bookkeeper] eolivelli commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response

2020-03-23 Thread GitBox
eolivelli commented on issue #2281: [bookie-ledger-recovery] Fix bookie recovery stuck even with enough ack-quorum response URL: https://github.com/apache/bookkeeper/pull/2281#issuecomment-602539631 I will merge today if @diegosalvi do not have other comments -

[GitHub] [bookkeeper] aschiazza commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active

2020-03-23 Thread GitBox
aschiazza commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active URL: https://github.com/apache/bookkeeper/issues/2216#issuecomment-602563807 Hi @zyllt, I've attached my bookkeeper conf file. [bookkeeper.conf.txt](https://gith

[GitHub] [bookkeeper] zyllt commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active

2020-03-23 Thread GitBox
zyllt commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active URL: https://github.com/apache/bookkeeper/issues/2216#issuecomment-602640916 @aschiazza Thanks for your reply. I start bookie `bin/bookkeeper bookie` use your bookkeepe

[GitHub] [bookkeeper] aschiazza commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active

2020-03-23 Thread GitBox
aschiazza commented on issue #2216: Bookkeeper High CPU usage when StreamStorageLifecycleComponent extra component is active URL: https://github.com/apache/bookkeeper/issues/2216#issuecomment-602664097 If you start pulsar in standalone mode all components (broker, bookie zk) start in a sin

<    2   3   4   5   6   7   8   9   10   11   >