Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2678
@ravipesala Please review, Fixed failing test cases
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214616107
--- Diff:
core/src/main/java/org/apache/carbondata/core/datamap/dev/DataMap.java ---
@@ -35,7 +37,8 @@
/**
* It is called to load the
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2662
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8249/
---
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2670
@xuchuanyin
Yes, better to check the limitation.
What's your opinion about how to fix it?
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2684#discussion_r214627013
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
---
@@ -81,6 +81,7 @@ class
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214629195
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -68,11 +70,14 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214629556
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -68,11 +70,14 @@
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214630184
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -117,7 +116,7 @@ public TableSchema
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/2564
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2685
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/182/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2678
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/181/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214617306
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/CarbonIndexFileReader.java
---
@@ -79,6 +80,17 @@ public void
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214616899
--- Diff:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/SegmentIndexFileStore.java
---
@@ -354,6 +364,22 @@ private
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8251/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2685
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8253/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214617612
--- Diff:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
---
@@ -99,20 +100,21 @@ public static long
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2678#discussion_r214617416
--- Diff:
core/src/main/java/org/apache/carbondata/core/reader/ThriftReader.java ---
@@ -87,6 +88,15 @@ public void open() throws IOException {
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2628#discussion_r214583592
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -94,222 +98,240 @@ public void
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2628#discussion_r214583607
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/ColumnPage.java ---
@@ -66,15 +66,19 @@
protected static final boolean
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2663#discussion_r214592707
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
---
@@
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2684#discussion_r214619170
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
---
@@ -81,6 +81,7 @@ class
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2686
Can one of the admins verify this patch?
---
Github user zzcclp commented on the issue:
https://github.com/apache/carbondata/pull/2686
why need to upgrade scala version? doesn't it need to change any code?
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2686
Can one of the admins verify this patch?
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/180/
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2663#discussion_r214593863
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala
---
@@
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2678
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8252/
---
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2685#discussion_r214626402
--- Diff:
hadoop/src/main/java/org/apache/carbondata/hadoop/testutil/StoreCreator.java ---
@@ -101,18 +101,32 @@
private static
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2685#discussion_r214625972
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -590,12
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2685#discussion_r214627971
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -153,6 +165,14 @@ private static BitSet
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2685#discussion_r214627216
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/AbstractDataFileFooterConverter.java
---
@@ -135,6 +135,18 @@ private static BitSet
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2662
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/178/
---
Github user qiuchenjian commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2684#discussion_r214623582
--- Diff:
integration/spark2/src/main/scala/org/apache/spark/sql/CarbonDataFrameWriter.scala
---
@@ -81,6 +81,7 @@ class
GitHub user innovimax opened a pull request:
https://github.com/apache/carbondata/pull/2686
upgrade to scala 2.12.6 and binary 2.11
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2674
@jackylk Does these properties need to update in carbondata documents as
well?
---
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2644
@ravipesala
the blocklet level min/max will be added in another PR.
---
Github user jackylk closed the pull request at:
https://github.com/apache/carbondata/pull/2680
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2681
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2654
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/183/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2644
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8255/
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214705354
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -68,11 +70,14 @@
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2644
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/184/
---
GitHub user Indhumathi27 opened a pull request:
https://github.com/apache/carbondata/pull/2687
[CARBONDATA-2876]Fix Avro decimal datatype with precision and scale
**What is PR for?**
Add precision and scale for fieldvalue for Avro Decimal logical type
- [ ] Any
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2686
same question as @zzcclp .
It is better to raise one discussion first on mailing list.
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8258/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2663
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/185/
---
Github user chenliang613 commented on the issue:
https://github.com/apache/carbondata/pull/2614
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2676
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/187/
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214710189
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/store/writer/v3/CarbonFactDataWriterImplV3.java
---
@@ -68,11 +70,14 @@
[
https://issues.apache.org/jira/browse/CARBONDATA-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacky Li closed CARBONDATA-2905.
Resolution: Invalid
> Should allow set stream property on streaming table
>
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2663#discussion_r214643424
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/SparkCarbonFileFormat.scala
---
@@
Github user manishgupta88 commented on the issue:
https://github.com/apache/carbondata/pull/2663
@ravipesala ...handled review comments. Kindly review and merge
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2663#discussion_r214643373
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonSparkDataSourceUtil.scala
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2675
LGTM
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2663
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8256/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2642
@sujith71955 Please check MV module is failing with compilation issues.
http://136.243.101.176:8080/job/ManualApacheCarbonPRBuilder2.1/179/
---
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2663
LGTM
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2614
---
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/2672
LGTM
---
[
https://issues.apache.org/jira/browse/CARBONDATA-2837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Liang Chen resolved CARBONDATA-2837.
Resolution: Fixed
Assignee: Ravindra Pesala
Fix Version/s: 1.4.2
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2654
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8254/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2687
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8257/
---
Github user Indhumathi27 commented on the issue:
https://github.com/apache/carbondata/pull/2687
Retest this please
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2682#discussion_r214706037
--- Diff:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java
---
@@ -117,7 +116,7 @@ public TableSchema
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8275/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/204/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
GitHub user xuchuanyin reopened a pull request:
https://github.com/apache/carbondata/pull/2628
[CARBONDATA-2851][CARBONDATA-2852] Support zstd as column compressor in
final store
1. add zstd compressor for compressing column data
2. add zstd support in thrift
3. since zstd
GitHub user xuchuanyin reopened a pull request:
https://github.com/apache/carbondata/pull/2628
[CARBONDATA-2851][CARBONDATA-2852] Support zstd as column compressor in
final store
1. add zstd compressor for compressing column data
2. add zstd support in thrift
3. since zstd
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/2628
---
Github user xuchuanyin closed the pull request at:
https://github.com/apache/carbondata/pull/2628
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2661
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/202/
---
jiangmanhua created CARBONDATA-2911:
---
Summary: Remove unused BTree related code
Key: CARBONDATA-2911
URL: https://issues.apache.org/jira/browse/CARBONDATA-2911
Project: CarbonData
Issue
GitHub user kevinjmh opened a pull request:
https://github.com/apache/carbondata/pull/2688
[CARBONDATA-2911] Remove unused BTree related code
1. BTree related code is only used by a test class
called`BTreeBlockFinderTest`.
2. BTreeDataRefNodeFinder in
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8277/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2688
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8276/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2688
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/205/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2685
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8279/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2685
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/208/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/206/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2661
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/207/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2661
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8278/
---
Github user manishgupta88 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2687#discussion_r214790148
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
@@ -407,6 +413,19 @@ private Object
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2598
LGTM
---
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2681
This PR will print the whole size in the segment folder, even there are
update/delete, the output size includes them
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2674
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2682
---
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2661#discussion_r214738731
--- Diff:
integration/spark-datasource/src/main/scala/org/apache/spark/sql/carbondata/execution/datasources/CarbonFileIndexReplaceRule.scala
---
@@
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2687
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8260/
---
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2675
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2682
Build Success with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8263/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2628
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8265/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2654
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/193/
---
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/2465
@jackylk Yes i am working on this. Just need to fix the build. Will do it
soon
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2645
Build Failed with Spark 2.1.0, Please check CI
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/8267/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2685
Build Failed with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/201/
---
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2678
Build Success with Spark 2.2.1, Please check CI
http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/198/
---
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2628
retest this please
---
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2663#discussion_r214716461
--- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/Field.java
---
@@ -213,4 +218,58 @@ public String getColumnComment() {
public
1 - 100 of 136 matches
Mail list logo
