[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 @KanakaKumar Please review it again. ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10443/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2403/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10441/ ---

[jira] [Created] (CARBONDATA-3231) OOM exception is being thrown with varchar columns when local_dictionary is enabled

2019-01-06 Thread Kunal Kapoor (JIRA)
Kunal Kapoor created CARBONDATA-3231: Summary: OOM exception is being thrown with varchar columns when local_dictionary is enabled Key: CARBONDATA-3231 URL:

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2187/ ---

[GitHub] carbondata issue #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2996 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10440/ ---

[GitHub] carbondata issue #3046: [WIP] Fix OOM exception when dictionary map size is ...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2402/ ---

[GitHub] carbondata issue #3046: [WIP] Fix OOM exception when dictionary map size is ...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10442/ ---

[GitHub] carbondata issue #3046: [WIP] Fix OOM exception when dictionary map size is ...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3046 Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2186/ ---

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-06 Thread kunal642
Github user kunal642 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r24497 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -2076,4 +2076,15 @@ private

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2185/ ---

[jira] [Resolved] (CARBONDATA-3223) Datasize and Indexsize showing 0B for 1.1 store when show segments is done

2019-01-06 Thread Manish Gupta (JIRA)
[ https://issues.apache.org/jira/browse/CARBONDATA-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manish Gupta resolved CARBONDATA-3223. -- Resolution: Fixed Fix Version/s: 1.5.3 > Datasize and Indexsize showing 0B

[GitHub] carbondata issue #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2996 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2400/ ---

[GitHub] carbondata pull request #3047: [CARBONDATA-3223] Fixed Wrong Datasize and In...

2019-01-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/carbondata/pull/3047 ---

[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

2019-01-06 Thread kunal642
Github user kunal642 commented on the issue: https://github.com/apache/carbondata/pull/3046 @xuchuanyin The problem was that when using varchar column with email data the key for the dictionary map is very huge. When fallback happens the same data is kept in memory twice, which

[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-06 Thread Shubh18s
Github user Shubh18s commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r245553671 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1449,12 +1449,9 @@ private

[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-06 Thread Shubh18s
Github user Shubh18s commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r245553499 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateUtil.scala --- @@ -626,22 +626,29 @@

[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-06 Thread Shubh18s
Github user Shubh18s commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r245553484 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -1445,16 +1445,10 @@ private

[GitHub] carbondata pull request #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Is...

2019-01-06 Thread Shubh18s
Github user Shubh18s commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3010#discussion_r245553556 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala --- @@ -106,22 +106,29 @@ class

[GitHub] carbondata pull request #3032: [CARBONDATA-3210] Merge common method into Ca...

2019-01-06 Thread zzcclp
Github user zzcclp commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3032#discussion_r245553139 --- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/S3Example.scala --- @@ -18,52 +18,50 @@ package org.apache.carbondata.examples

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10439/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2399/ ---

[GitHub] carbondata issue #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2996 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2184/ ---

[GitHub] carbondata issue #3047: [CARBONDATA-3223] Fixed Wrong Datasize and Indexsize...

2019-01-06 Thread manishgupta88
Github user manishgupta88 commented on the issue: https://github.com/apache/carbondata/pull/3047 LGTM ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10438/ ---

[GitHub] carbondata issue #2996: [WIP] Fix Rename-Fail & Datamap-creation-Fail

2019-01-06 Thread Indhumathi27
Github user Indhumathi27 commented on the issue: https://github.com/apache/carbondata/pull/2996 retest this please ---

[GitHub] carbondata issue #3010: [CARBONDATA-3189] Fix PreAggregate Datamap Issue

2019-01-06 Thread Shubh18s
Github user Shubh18s commented on the issue: https://github.com/apache/carbondata/pull/3010 Respected Reviewer please Merge this PR. ---

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Optimize getVersionDetails

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2919 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10437/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2398/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2183/ ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3037 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10436/ ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-06 Thread QiangCai
Github user QiangCai commented on the issue: https://github.com/apache/carbondata/pull/2971 @ravipesala I agree with you to add it to the table properties. Even if it becomes the table property, maybe the user also can change it. right? Range_column is different from the

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Optimize getVersionDetails

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2919 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2396/ ---

[GitHub] carbondata issue #3032: [CARBONDATA-3210] Merge common method into CarbonSpa...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3032 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2182/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3048 retest this please ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10435/ ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 @XiaotaoYi Please fix the CI errors. ---

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3050 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2393/ ---

[GitHub] carbondata issue #2919: [CARBONDATA-3097] Optimize getVersionDetails

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/2919 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2181/ ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3037 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2395/ ---

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3050 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10434/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2394/ ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3037 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2180/ ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3052 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2392/ ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] Fix some spell errors in the proje...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3052 Build Failed with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10433/ ---

[GitHub] carbondata issue #3048: [CARBONDATA-3224] Support SDK/CSDK validate the impr...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3048 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2179/ ---

[GitHub] carbondata issue #3037: [CARBONDATA-3190] Open example module code style che...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3037 retest this please ---

[GitHub] carbondata issue #2971: [CARBONDATA-3219] Support range partition the input ...

2019-01-06 Thread ravipesala
Github user ravipesala commented on the issue: https://github.com/apache/carbondata/pull/2971 @QiangCai My question how the user can benefit if he chooses a different range column for each load. I feel range column should be at the table level not at the load level. And regarding

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3050 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2178/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/3045 LGTM ---

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245534858 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7

[GitHub] carbondata pull request #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3050#discussion_r245534776 --- Diff: datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneFineGrainDataMapFactory.java --- @@ -57,7 +57,7 @@ public

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 @XiaotaoYi Please optimize the title, like: [CARBONDATA-3227] Fix some spell errors in the project ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3052 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2177/ ---

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK/CSDK validate t...

2019-01-06 Thread xubo245
Github user xubo245 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3048#discussion_r245534079 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -179,7 +181,8 @@ public CarbonWriterBuilder

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3050 add to whitelist ---

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread xubo245
Github user xubo245 commented on the issue: https://github.com/apache/carbondata/pull/3052 add to whitelist ---

[GitHub] carbondata issue #3050: [CARBONDATA-3211] Optimize the documentation

2019-01-06 Thread bbinwang
Github user bbinwang commented on the issue: https://github.com/apache/carbondata/pull/3050 > @bbinwang Please optimize the title to:[CARBONDATA-3211] Optimize the documentation ok ---

[GitHub] carbondata pull request #3048: [CARBONDATA-3224] Support SDK/CSDK validate t...

2019-01-06 Thread KanakaKumar
Github user KanakaKumar commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3048#discussion_r245532720 --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java --- @@ -179,7 +181,8 @@ public CarbonWriterBuilder

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10432/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2391/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2176/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread shardul-cr7
Github user shardul-cr7 commented on the issue: https://github.com/apache/carbondata/pull/3045 retest this please ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2390/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10431/ ---

[GitHub] carbondata issue #3045: [CARBONDATA-3222]Fix dataload failure after creation...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3045 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2175/ ---

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245516216 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread shardul-cr7
Github user shardul-cr7 commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245516158 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread XiaotaoYi
Github user XiaotaoYi commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245512840 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -668,9 +668,9 @@ abstract class

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread kevinjmh
Github user kevinjmh commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245511058 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7 +110,29

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread kevinjmh
Github user kevinjmh commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245511008 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7 +110,29

[GitHub] carbondata issue #3046: [WIP] Added check to start fallback based on size

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on the issue: https://github.com/apache/carbondata/pull/3046 Hi @kunal642 ,in your PR, the threshold size for storage of the local dictionary is specified by system (maybe later can be specified by user). But it will come up with an obvious problem

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r245510146 --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/DecoderBasedFallbackEncoder.java --- @@ -57,10 +57,7 @@ public

[GitHub] carbondata pull request #3046: [WIP] Added check to start fallback based on ...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3046#discussion_r245510098 --- Diff: core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java --- @@ -2076,4 +2076,15 @@ private

[GitHub] carbondata pull request #3045: [CARBONDATA-3222]Fix dataload failure after c...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3045#discussion_r245509909 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/PreAggregateTableHelper.scala --- @@ -110,7

[GitHub] carbondata pull request #3023: [CARBONDATA-3197][BloomDataMap] Include bloom...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3023#discussion_r245509625 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/CarbonEnv.scala --- @@ -184,6 +184,9 @@ object CarbonEnv {

[GitHub] carbondata pull request #3023: [CARBONDATA-3197][BloomDataMap] Include bloom...

2019-01-06 Thread xuchuanyin
Github user xuchuanyin commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3023#discussion_r245509427 --- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/events/MergeBloomIndexEventListener.scala --- @@ -24,59 +24,96 @@ import

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505788 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -837,9 +837,9 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505775 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -821,10 +821,10 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505760 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -796,10 +796,10 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505699 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -697,9 +697,9 @@ abstract class

[GitHub] carbondata pull request #3052: [CARBONDATA-3227] There are some spell errors...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on a diff in the pull request: https://github.com/apache/carbondata/pull/3052#discussion_r245505691 --- Diff: integration/spark-common/src/main/scala/org/apache/spark/sql/catalyst/CarbonDDLSqlParser.scala --- @@ -668,9 +668,9 @@ abstract class

[GitHub] carbondata issue #3052: [CARBONDATA-3227] There are some spell errors in the...

2019-01-06 Thread qiuchenjian
Github user qiuchenjian commented on the issue: https://github.com/apache/carbondata/pull/3052 add to whitelist ---

[GitHub] carbondata issue #3023: [CARBONDATA-3197][BloomDataMap] Include bloomindex m...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3023 Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/2389/ ---

[GitHub] carbondata issue #3023: [CARBONDATA-3197][BloomDataMap] Include bloomindex m...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3023 Build Success with Spark 2.3.2, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/10430/ ---

[GitHub] carbondata issue #3023: [CARBONDATA-3197][BloomDataMap] Include bloomindex m...

2019-01-06 Thread CarbonDataQA
Github user CarbonDataQA commented on the issue: https://github.com/apache/carbondata/pull/3023 Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/2174/ ---