Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/3005#discussion_r243150083
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFile.java
---
@@ -95,15 +94,13 @@ public boolean renameForce
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2992
add to whitelist
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r243139107
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -49,17 +49,19 @@ object HiveExample
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
rebase because #PR2966
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3183:
Description:
command：
{code:java}
clean install -DskipTests -Pwindows -Pspark-2.2 -X
{code
xubo245 created CARBONDATA-3183:
---
Summary: There are some exception when compile in windows
Key: CARBONDATA-3183
URL: https://issues.apache.org/jira/browse/CARBONDATA-3183
Project: CarbonData
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242817598
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -43,28 +43,25 @@ object HiveExample
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242817509
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,19 +82,25 @@ object HiveExample
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chandrasaripaka Please rebase itã
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2992#discussion_r242803409
--- Diff: docs/ddl-of-carbondata.md ---
@@ -157,22 +157,22 @@ CarbonData DDL statements are documented here,which
includes:
* GLOBAL_SORT
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2919
retest this please
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242583802
--- Diff: docs/sdk-guide.md ---
@@ -816,13 +816,15 @@ Find example code at
[CarbonReaderExample](https://github.com/apache/carbondata
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242583526
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -241,12 +241,25 @@ private static Schema
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242583087
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CarbonSchemaReaderTest.java
---
@@ -236,6 +243,113 @@ public void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2931#discussion_r242444376
--- Diff: store/CSDK/test/main.cpp ---
@@ -822,16 +831,17 @@ int main(int argc, char *argv[]) {
// init jvm
JNIEnv *env;
env
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2919#discussion_r242429609
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -241,12 +241,52 @@ private static Schema
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2991
@BJangir Please rebase it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2992
@xuchuanyin I mean it's plan, just explain why do we change => , not require add it to document now.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2931
rebase and fix the conflict
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242400169
--- Diff:
integration/hive/src/main/java/org/apache/carbondata/hive/MapredCarbonInputFormat.java
---
@@ -106,9 +107,17 @@ private static CarbonTable
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242395640
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -193,5 +196,4 @@ object HiveExample
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242394285
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -31,7 +31,7 @@ object HiveExample
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2969
@SteNicholas Please optimize the title
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242391201
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,19 +82,25 @@ object HiveExample
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242391224
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -85,19 +82,25 @@ object HiveExample
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242390063
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -43,28 +43,25 @@ object HiveExample
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2969#discussion_r242389254
--- Diff:
integration/hive/src/main/scala/org/apache/carbondata/hiveexample/HiveExample.scala
---
@@ -43,28 +43,25 @@ object HiveExample
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2931#discussion_r242387341
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonSchemaReader.java
---
@@ -147,34 +170,55 @@ public static Schema readSchema
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chandrasaripaka Can you run with this code success? there are some error
in my machine:
`2018-12-17 11:24:11 ERROR AlluxioCarbonFile:107 -
/xubo/default/alluxio_table_1c201e20-d7df
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2991#discussion_r242015225
--- Diff: pom.xml ---
@@ -587,6 +587,9 @@
examples/spark2
datamap/lucene
datamap/bloom
+
Github user xubo245 commented on the pull request:
https://github.com/apache/carbondata/commit/ee91443a7449a53105bda1b8e818b8451d4a5d54#commitcomment-31695990
In docs/quick-start-guide.md:
In docs/quick-start-guide.md on line 83:
Can you optimize the path? unify path
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2992
@lamber-ken Can you optimize all documentation in this PR? not only for
quick-start-guide, such as "docs/ddl-of-carbondata.md", it also has the similar
place need to be
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2992#discussion_r242007651
--- Diff: docs/quick-start-guide.md ---
@@ -91,32 +90,31 @@ val carbon = SparkSession.builder().config(sc.getConf)
## Creating a Table
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2992
@lamber-ken Please finish the checklist in content of this PR.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
@jackylk @KanakaKumar @kunal642 @ravipesala rebased again, CI pass, Please
review it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2987
@jackylk @QiangCai @KanakaKumar @kunal642 Please review it.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
CI pass, please check it again @ajantha-bhat @KanakaKumar
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
need rebase again
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
rebase again
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241813858
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -77,8 +77,9 @@
/**
* Sets
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241811704
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char
*value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241802156
--- Diff:
integration/spark2/src/main/scala/org/apache/carbondata/spark/thriftserver/CarbonThriftServer.scala
---
@@ -48,8 +48,13 @@ object
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2925#discussion_r241802106
--- Diff: integration/spark2/pom.xml ---
@@ -134,6 +134,11 @@
+
--- End diff --
ok, done
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2973
I will work on this maybe next week.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2890#discussion_r241795430
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonLoaderUtil.java
---
@@ -569,25 +569,25 @@ public static Dictionary
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2890
@brijoobopanna @chenliang613 @jackylk CI pass. please check again.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
@ajantha-bhat @KanakaKumar CI pass, Please review again
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2925
@kunal642 In cluster, it also has this problem.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2914
@jackylk CI pass, please check it again
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
retest this please
---
[
https://issues.apache.org/jira/browse/CARBONDATA-3169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3169:
Description:
Enable non dynamic configuration can be configured dynamically
There are only
xubo245 created CARBONDATA-3172:
---
Summary: Optimize the property name
Key: CARBONDATA-3172
URL: https://issues.apache.org/jira/browse/CARBONDATA-3172
Project: CarbonData
Issue Type: Sub-task
xubo245 created CARBONDATA-3171:
---
Summary: Unify internal and external properties
Key: CARBONDATA-3171
URL: https://issues.apache.org/jira/browse/CARBONDATA-3171
Project: CarbonData
Issue Type
xubo245 created CARBONDATA-3170:
---
Summary: Optimize the properties documentation or comments
Key: CARBONDATA-3170
URL: https://issues.apache.org/jira/browse/CARBONDATA-3170
Project: CarbonData
xubo245 created CARBONDATA-3169:
---
Summary: Enable non dynamic configuration can be configured
dynamically
Key: CARBONDATA-3169
URL: https://issues.apache.org/jira/browse/CARBONDATA-3169
Project
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2914#discussion_r241631889
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -40,1372 +41,1024 @@ private CarbonCommonConstants
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2914#discussion_r241631816
--- Diff:
core/src/main/java/org/apache/carbondata/core/constants/CarbonCommonConstants.java
---
@@ -40,1372 +41,1024 @@ private CarbonCommonConstants
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2899
@ajantha-bhat Rebased and optimized.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241630042
--- Diff: store/CSDK/test/main.cpp ---
@@ -645,6 +653,278 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241629538
--- Diff: store/CSDK/test/main.cpp ---
@@ -645,6 +653,278 @@ bool testWriteData(JNIEnv *env, char *path, int argc,
char *argv
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241627445
--- Diff:
store/sdk/src/test/java/org/apache/carbondata/sdk/file/CSVCarbonWriterTest.java
---
@@ -543,4 +543,42 @@ public void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241627223
--- Diff:
store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
---
@@ -199,6 +203,22 @@ public CarbonWriterBuilder
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241627031
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -58,6 +58,35 @@ void CarbonWriter::outputPath(char *path) {
carbonWriterBuilderObject
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241626623
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char
*value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241626607
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char
*value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241626594
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char
*value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241626570
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -98,6 +127,158 @@ void CarbonWriter::withHadoopConf(char *key, char
*value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241626357
--- Diff: store/CSDK/src/CarbonWriter.cpp ---
@@ -58,6 +58,35 @@ void CarbonWriter::outputPath(char *path) {
carbonWriterBuilderObject
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241625910
--- Diff: docs/csdk-guide.md ---
@@ -214,6 +226,122 @@ release the memory and destroy JVM.
void withHadoopConf(char *key, char *value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2899#discussion_r241625744
--- Diff: docs/csdk-guide.md ---
@@ -214,6 +226,122 @@ release the memory and destroy JVM.
void withHadoopConf(char *key, char *value
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241625448
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -111,14 +112,9 @@ public static DataInputStream
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2987#discussion_r241622359
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameSDKS3Example.scala
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2987#discussion_r241622327
--- Diff:
examples/spark2/src/main/scala/org/apache/carbondata/examples/DataFrameSDKS3Example.scala
---
@@ -0,0 +1,184 @@
+/*
+ * Licensed
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2987
[CARBONDATA-3167] Add a example for DataFrame read/write non-transactional
table from/to S3
Add a example for DataFrame read/write non-transactional table from/to S3
Be sure to do all
xubo245 created CARBONDATA-3167:
---
Summary: Add a example for DataFrame read/write non-transactional
table from/to S3
Key: CARBONDATA-3167
URL: https://issues.apache.org/jira/browse/CARBONDATA-3167
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chandrasaripaka Please rebase carefully.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264812
--- Diff:
core/src/test/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFileTest.java
---
@@ -20,20 +20,16 @@
import
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264817
--- Diff:
core/src/test/java/org/apache/carbondata/core/datastore/filesystem/AlluxioCarbonFileTest.java
---
@@ -20,20 +20,16 @@
import
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264683
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java ---
@@ -99,11 +103,17 @@ public static ICarbonLock
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264716
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java ---
@@ -99,11 +103,17 @@ public static ICarbonLock
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264666
--- Diff:
core/src/main/java/org/apache/carbondata/core/locks/CarbonLockFactory.java ---
@@ -99,11 +103,17 @@ public static ICarbonLock
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264360
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -470,10 +475,11 @@ public static void
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241264313
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -432,7 +437,7 @@ public static long getDirectorySize
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2161#discussion_r241259379
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/impl/FileFactory.java
---
@@ -111,14 +112,9 @@ public static DataInputStream
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chandrasaripaka I confirmed and reproduced this issue based on carbonData
lastest master and spark-2.3.2.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chandrasaripaka OK. I will review this PR for detail this week, and plan
to merge it recently.
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2161
@chandrasaripaka Can you fix the CI error?
---
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2970
@qiuchenjian the checklist should be select correctly, you can refer
https://github.com/apache/carbondata/pull/2981
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2970#discussion_r240444131
--- Diff:
core/src/main/java/org/apache/carbondata/core/util/CarbonThreadFactory.java ---
@@ -34,14 +34,26 @@
*/
private String name
[
https://issues.apache.org/jira/browse/CARBONDATA-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xubo245 updated CARBONDATA-3156:
Issue Type: Sub-task (was: Improvement)
Parent: CARBONDATA-3155
> DataFrame do
xubo245 created CARBONDATA-3156:
---
Summary: DataFrame don't support read carbontable by load path
Key: CARBONDATA-3156
URL: https://issues.apache.org/jira/browse/CARBONDATA-3156
Project: CarbonData
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2940
@kumarvishal09 but the carbon.query.directQueryOnDataMap.enabled parameter
has been exposed to user and can't work.
---
Github user xubo245 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2981#discussion_r240026676
--- Diff:
integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/SparkCarbonDataSourceTest.scala
---
@@ -998,9 +999,19
xubo245 created CARBONDATA-3155:
---
Summary: DataFrame support read CarbonSession/SDK written data
Key: CARBONDATA-3155
URL: https://issues.apache.org/jira/browse/CARBONDATA-3155
Project: CarbonData
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2981
retest this please
---
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2981
[CARBONDATA-3154] Fix spark-2.1 test error
[CARBONDATA-3154] Fix spark-2.1 test error
This PR fix spark-2.1 test error, including:
1. fix 6 errors
xubo245 created CARBONDATA-3154:
---
Summary: Fix spark-2.1 test error
Key: CARBONDATA-3154
URL: https://issues.apache.org/jira/browse/CARBONDATA-3154
Project: CarbonData
Issue Type: Bug
xubo245 created CARBONDATA-3151:
---
Summary: SDK supports LOCAL_DICTIONARY_INCLUDE and
LOCAL_DICTIONARY_EXCLUDE
Key: CARBONDATA-3151
URL: https://issues.apache.org/jira/browse/CARBONDATA-3151
Project
Github user xubo245 commented on the issue:
https://github.com/apache/carbondata/pull/2969
LGTM
---
GitHub user xubo245 opened a pull request:
https://github.com/apache/carbondata/pull/2973
[WIP][CARBONDATA-3144] CarbonData support spark-2.4.0
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any
301 - 400 of 2151 matches
Mail list logo
