[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17378451#comment-17378451
]
Matt Juntunen commented on NUMBERS-77:
--
Closing this issue as no more utilities need to be moved
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17362902#comment-17362902
]
Matt Juntunen commented on NUMBERS-77:
--
Created TEXT-207 for moving {{DoubleFormats}} to
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360277#comment-17360277
]
Matt Juntunen commented on NUMBERS-77:
--
I sent an email to the dev list but received no interest,
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17360274#comment-17360274
]
Gilles Sadowski commented on NUMBERS-77:
Was there some discussion/conclusion about the latter
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334870#comment-17334870
]
Gilles Sadowski commented on NUMBERS-77:
bq. {{DoubleFunctionXN}}
It's unlikely that we'll
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334766#comment-17334766
]
Matt Juntunen commented on NUMBERS-77:
--
Some additional types/utilities to consider moving:
*
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334750#comment-17334750
]
Matt Juntunen commented on NUMBERS-77:
--
bq. We should add unit tests.
Added in PR
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329907#comment-17329907
]
Gilles Sadowski commented on NUMBERS-77:
We should [add unit
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329898#comment-17329898
]
Gilles Sadowski commented on NUMBERS-77:
I've modified {{Precision.compareTo}} according to
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329414#comment-17329414
]
Alex Herbert commented on NUMBERS-77:
-
Snapshots are deployed by Jenkins:
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329409#comment-17329409
]
Alex Herbert commented on NUMBERS-77:
-
{quote}Let's refer to what's in "master" (there were fixes).
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329376#comment-17329376
]
Matt Juntunen commented on NUMBERS-77:
--
Still not sold on the name but I'm 99% sure this will work
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329363#comment-17329363
]
Gilles Sadowski commented on NUMBERS-77:
bq. In your diff [...]
Let's refer to what's in
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329345#comment-17329345
]
Matt Juntunen commented on NUMBERS-77:
--
{quote}So currently the comparisons break down when NaN is
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329342#comment-17329342
]
Matt Juntunen commented on NUMBERS-77:
--
bq. So if we agree on the basic design, I could merge the
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329332#comment-17329332
]
Alex Herbert commented on NUMBERS-77:
-
{quote}I think that there is a problem when {{0 < |a| < eps}}
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329318#comment-17329318
]
Gilles Sadowski commented on NUMBERS-77:
Merged (with discussed changes) into master:
commit
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329237#comment-17329237
]
Gilles Sadowski commented on NUMBERS-77:
{quote}
{code}
default double signum(double a) {
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329202#comment-17329202
]
Gilles Sadowski commented on NUMBERS-77:
bq. [interface with default methods] is much cleaner.
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17329187#comment-17329187
]
Matt Juntunen commented on NUMBERS-77:
--
bq. Could the functionality be used as is in [Geometry]?
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327876#comment-17327876
]
Alex Herbert commented on NUMBERS-77:
-
Looking at Matt's PR I would agree that there is no need for
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327190#comment-17327190
]
Gilles Sadowski commented on NUMBERS-77:
I think that the {{sign(double a)}} method should be
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17327011#comment-17327011
]
Gilles Sadowski commented on NUMBERS-77:
I've just attached a [^NUMBERS-77.diff] with my idea of
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326917#comment-17326917
]
Matt Juntunen commented on NUMBERS-77:
--
I had an idea on the name: {{PrecisionComparator}}. I've put
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326883#comment-17326883
]
Matt Juntunen commented on NUMBERS-77:
--
bq. PR#88 fails the build.
Yes, I'm not sure what that's
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326762#comment-17326762
]
Gilles Sadowski commented on NUMBERS-77:
PR#88 fails the
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326761#comment-17326761
]
Gilles Sadowski commented on NUMBERS-77:
bq. {{DoublePrecisionContext}} [is not]
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17326563#comment-17326563
]
Matt Juntunen commented on NUMBERS-77:
--
I've created a PR for moving the {{DoublePrecisionContext}}
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720817#comment-16720817
]
Gilles commented on NUMBERS-77:
---
bq. my work on Fraction overflows
Commenting on the wrong JIRA page?
>
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720515#comment-16720515
]
Eric Barnhill commented on NUMBERS-77:
--
Apologies, but I realize belatedly that my work on Fraction
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719159#comment-16719159
]
Gilles commented on NUMBERS-77:
---
I was thinking about utilities that work tuples (e.g.
[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719089#comment-16719089
]
Matt Juntunen commented on NUMBERS-77:
--
Which utilities should be moved?
> Move utilities from
32 matches
Mail list logo
