[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175953#comment-16175953 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-09-21 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 @NicoK , I missed that message of `verifyAllBuffersReturned()` issue before. I have submitted the modifications of it. :) ---

[GitHub] flink pull request #4703: [FLINK-7659][REST] Unprotected access to inProgres...

2017-09-21 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4703 [FLINK-7659][REST] Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest ## What is the purpose of the change There's a thread accessing `inProgress`

[jira] [Commented] (FLINK-7659) Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175942#comment-16175942 ] ASF GitHub Bot commented on FLINK-7659: --- GitHub user bowenli86 opened a pull request:

[jira] [Updated] (FLINK-7659) Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest

2017-09-21 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-7659: Component/s: REST > Unprotected access to inProgress in >

[jira] [Assigned] (FLINK-7659) Unprotected access to inProgress in JobCancellationWithSavepointHandlers#handleNewRequest

2017-09-21 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-7659: --- Assignee: Bowen Li > Unprotected access to inProgress in >

[jira] [Commented] (FLINK-7635) Support sideOutput in ProcessWindowFunciton

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175888#comment-16175888 ] ASF GitHub Bot commented on FLINK-7635: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #4702: [FLINK-7635][DataStream API][Scala API] Support sideOutpu...

2017-09-21 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/4702 @aljoscha @chenqin Hi guys, can you please take a look? I'll write doc about this feature with [FLINK-7660](https://issues.apache.org/jira/browse/FLINK-7660). BTW, this is my first time writing

[jira] [Commented] (FLINK-7635) Support sideOutput in ProcessWindowFunciton

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175800#comment-16175800 ] ASF GitHub Bot commented on FLINK-7635: --- GitHub user bowenli86 opened a pull request:

[GitHub] flink pull request #4702: [FLINK-7635][DataStream API][Scala API] Support si...

2017-09-21 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/4702 [FLINK-7635][DataStream API][Scala API] Support sideOutput in ProcessWindowFunciton ## What is the purpose of the change Add support for sideOutput in ProcessWindowFunciton ##

[jira] [Commented] (FLINK-4319) Rework Cluster Management (FLIP-6)

2017-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175658#comment-16175658 ] Till Rohrmann commented on FLINK-4319: -- Hi [~suez1224], thanks for testing out the current state of

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175656#comment-16175656 ] Till Rohrmann commented on FLINK-7076: -- Hi [~yuemeng], are you still working on this? > Implement

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175640#comment-16175640 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4691#discussion_r140380156 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/ClusterConfigHandler.java --- @@ -33,20 +43,27 @@ /** *

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175639#comment-16175639 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175638#comment-16175638 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4691#discussion_r140381187 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/ClusterConfiguration.java --- @@ -0,0 +1,57 @@ +/*

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175637#comment-16175637 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175641#comment-16175641 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4691#discussion_r140382392 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/ClusterConfiguration.java --- @@ -0,0 +1,57 @@ +/*

[GitHub] flink pull request #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4691#discussion_r140381079 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/messages/ClusterConfiguration.java --- @@ -0,0 +1,57 @@ +/*

[GitHub] flink pull request #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4691#discussion_r140379775 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherRestEndpoint.java --- @@ -55,16 +59,19 @@ public class

[GitHub] flink pull request #4689: [FLINK-7655] [flip6] Set fencing token to null if ...

2017-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4689 ---

[jira] [Commented] (FLINK-7655) Revisit default non-leader id for FencedRpcEndpoints

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175614#comment-16175614 ] ASF GitHub Bot commented on FLINK-7655: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7655) Revisit default non-leader id for FencedRpcEndpoints

2017-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7655. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 42cc3a2a9c41dda7cf338db36b45131db9150674 >

[jira] [Commented] (FLINK-7655) Revisit default non-leader id for FencedRpcEndpoints

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175609#comment-16175609 ] ASF GitHub Bot commented on FLINK-7655: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4689: [FLINK-7655] [flip6] Set fencing token to null if not lea...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4689 Travis passed. Merging this PR. ---

[jira] [Commented] (FLINK-4319) Rework Cluster Management (FLIP-6)

2017-09-21 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175494#comment-16175494 ] Shuyi Chen commented on FLINK-4319: --- Hi [~till.rohrmann], thanks a lot for the pointers. I was trying

[jira] [Created] (FLINK-7666) ContinuousFileReaderOperator swallows chained watermarks

2017-09-21 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-7666: -- Summary: ContinuousFileReaderOperator swallows chained watermarks Key: FLINK-7666 URL: https://issues.apache.org/jira/browse/FLINK-7666 Project: Flink Issue

[jira] [Created] (FLINK-7665) Use wait/notify in ContinuousFileReaderOperator

2017-09-21 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-7665: -- Summary: Use wait/notify in ContinuousFileReaderOperator Key: FLINK-7665 URL: https://issues.apache.org/jira/browse/FLINK-7665 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7664) Replace FlinkFutureException by CompletionException

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175144#comment-16175144 ] ASF GitHub Bot commented on FLINK-7664: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #4701: [FLINK-7664] Replace FlinkFutureException by java....

2017-09-21 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4701 [FLINK-7664] Replace FlinkFutureException by java.util.concurrent.CompletionException ## What is the purpose of the change FlinkFutureException was introduced to fail a

[jira] [Created] (FLINK-7664) Replace FlinkFutureException by CompletionException

2017-09-21 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7664: Summary: Replace FlinkFutureException by CompletionException Key: FLINK-7664 URL: https://issues.apache.org/jira/browse/FLINK-7664 Project: Flink Issue

[jira] [Commented] (FLINK-7636) Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175091#comment-16175091 ] ASF GitHub Bot commented on FLINK-7636: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7636) Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175093#comment-16175093 ] ASF GitHub Bot commented on FLINK-7636: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7636) Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175090#comment-16175090 ] ASF GitHub Bot commented on FLINK-7636: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-7636) Introduce Flink RelOptTable, and remove tableSource from all TableSourceScan node constructor

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175092#comment-16175092 ] ASF GitHub Bot commented on FLINK-7636: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4681: [FLINK-7636][Table API & SQL]Introduce Flink RelOp...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4681#discussion_r140297123 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala --- @@ -0,0 +1,265 @@ +/* + *

[GitHub] flink pull request #4681: [FLINK-7636][Table API & SQL]Introduce Flink RelOp...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4681#discussion_r140291045 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala --- @@ -0,0 +1,265 @@ +/* + *

[GitHub] flink pull request #4681: [FLINK-7636][Table API & SQL]Introduce Flink RelOp...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4681#discussion_r140292203 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala --- @@ -0,0 +1,265 @@ +/* + *

[GitHub] flink pull request #4681: [FLINK-7636][Table API & SQL]Introduce Flink RelOp...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4681#discussion_r140290245 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala --- @@ -0,0 +1,265 @@ +/* + *

[jira] [Commented] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175080#comment-16175080 ] ASF GitHub Bot commented on FLINK-7649: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #4700: [FLINK-7649] [flip6] Extend JobTerminationHandler ...

2017-09-21 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4700 [FLINK-7649] [flip6] Extend JobTerminationHandler to support stop ## What is the purpose of the change Rename the JobCancellationHandler into JobTerminationHandler which is now

[GitHub] flink pull request #4699: [FLINK-7663] [flip6] Return BAD_REQUEST if Handler...

2017-09-21 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4699 [FLINK-7663] [flip6] Return BAD_REQUEST if HandlerRequest cannot be created ## What is the purpose of the change This commit changes the behaviour such that a failure in creating a

[jira] [Commented] (FLINK-7663) Allow AbstractRestHandler to handle bad requests

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175050#comment-16175050 ] ASF GitHub Bot commented on FLINK-7663: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175036#comment-16175036 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175034#comment-16175034 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175035#comment-16175035 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140291439 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java --- @@ -92,24 +101,26 @@ public

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140291476 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java --- @@ -92,24 +101,26 @@ public

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140291389 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java --- @@ -92,24 +101,26 @@ public

[jira] [Commented] (FLINK-7623) Detecting whether an operator is restored doesn't work with chained state

2017-09-21 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174974#comment-16174974 ] Aljoscha Krettek commented on FLINK-7623: - I think that would be incorrect, because then it would

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174972#comment-16174972 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174973#comment-16174973 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140281116 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java --- @@ -92,24 +101,26 @@ public

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140280832 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java --- @@ -92,24 +101,26 @@ public

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174969#comment-16174969 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140281028 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/legacy/CurrentJobsOverviewHandler.java --- @@ -92,24 +101,26 @@ public

[jira] [Commented] (FLINK-7439) Support variable arguments for UDTF in SQL

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174953#comment-16174953 ] ASF GitHub Bot commented on FLINK-7439: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4536: [FLINK-7439] [table] Support variable arguments fo...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4536#discussion_r140276174 --- Diff: docs/dev/table/udfs.md --- @@ -297,7 +297,7 @@ optionally implemented. While some of these methods allow the system more effici - `merge()`

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174926#comment-16174926 ] ASF GitHub Bot commented on FLINK-7378: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4485: [FLINK-7378][core]Create a fix size (non rebalanci...

2017-09-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4485#discussion_r140271306 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferPoolFactoryTest.java --- @@ -186,7 +186,7 @@ public void

[jira] [Created] (FLINK-7663) Allow AbstractRestHandler to handle bad requests

2017-09-21 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-7663: Summary: Allow AbstractRestHandler to handle bad requests Key: FLINK-7663 URL: https://issues.apache.org/jira/browse/FLINK-7663 Project: Flink Issue Type:

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174882#comment-16174882 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-21 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r140266297 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174880#comment-16174880 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4691 Sorry about that, local Travis tests pass, should be fine now. ---

[jira] [Assigned] (FLINK-7652) Port CurrentJobIdsHandler to new REST endpoint

2017-09-21 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-7652: -- Assignee: Tzu-Li (Gordon) Tai > Port CurrentJobIdsHandler to new REST endpoint

[jira] [Assigned] (FLINK-7648) Port TaskManagersHandler to new REST endpoint

2017-09-21 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-7648: -- Assignee: (was: Tzu-Li (Gordon) Tai) > Port TaskManagersHandler to new

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174875#comment-16174875 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r140263201 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,442 @@ +/*

[jira] [Created] (FLINK-7662) Remove unnecessary packaged licenses

2017-09-21 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-7662: --- Summary: Remove unnecessary packaged licenses Key: FLINK-7662 URL: https://issues.apache.org/jira/browse/FLINK-7662 Project: Flink Issue Type: Improvement

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r140262200 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174868#comment-16174868 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140258895 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -309,7 +309,7 @@ public boolean write(T

[GitHub] flink pull request #3511: [Flink-5734] code generation for normalizedkey sor...

2017-09-21 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/3511#discussion_r140258675 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/sort/NormalizedKeySorter.java --- @@ -47,61 +47,61 @@ public

[jira] [Commented] (FLINK-7661) Add credit field in PartitionRequest message

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174841#comment-16174841 ] ASF GitHub Bot commented on FLINK-7661: --- GitHub user zhijiangW opened a pull request:

[GitHub] flink pull request #4698: [FLINK-7661][network] Add credit field in Partitio...

2017-09-21 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/4698 [FLINK-7661][network] Add credit field in PartitionRequest message ## What is the purpose of the change *`PartitionRequest` message adds the credit field which corresponds to the number

[GitHub] flink pull request #4695: [FLINK-7661][network] Add credit field in Partitio...

2017-09-21 Thread zhijiangW
Github user zhijiangW closed the pull request at: https://github.com/apache/flink/pull/4695 ---

[jira] [Commented] (FLINK-7661) Add credit field in PartitionRequest message

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174839#comment-16174839 ] ASF GitHub Bot commented on FLINK-7661: --- Github user zhijiangW closed the pull request at:

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-21 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r140255052 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -0,0 +1,442 @@ +/* +

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174834#comment-16174834 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in the pull request:

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174815#comment-16174815 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-21 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r140251765 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[jira] [Commented] (FLINK-7378) Create a fix size (non rebalancing) buffer pool type for the floating buffers

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174757#comment-16174757 ] ASF GitHub Bot commented on FLINK-7378: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4485: [FLINK-7378][core]Create a fix size (non rebalancing) buf...

2017-09-21 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4485 @NicoK , sorry for the typos. I have submitted the updates. ---

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174746#comment-16174746 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandler to n...

2017-09-21 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4688 @tillrohrmann Yes that makes sense, lets do that separately in the future then. +1. ---

[jira] [Commented] (FLINK-7502) PrometheusReporter improvements

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174734#comment-16174734 ] ASF GitHub Bot commented on FLINK-7502: --- Github user mbode commented on the issue:

[GitHub] flink issue #4586: [FLINK-7502] [metrics] Improve PrometheusReporter

2017-09-21 Thread mbode
Github user mbode commented on the issue: https://github.com/apache/flink/pull/4586 @zentol It would be great if you could have another look on occasion, I added better handling for metrics that are registered e.g. by different subtasks. [green

[jira] [Assigned] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7649: Assignee: Till Rohrmann > Port JobStoppingHandler to new REST endpoint >

[jira] [Updated] (FLINK-7649) Port JobStoppingHandler to new REST endpoint

2017-09-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-7649: - Description: Port existing {{JobStoppingHandler}} to new REST endpoint (was: Port existing

[jira] [Commented] (FLINK-7647) Port JobManagerConfigHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174731#comment-16174731 ] ASF GitHub Bot commented on FLINK-7647: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4691: [FLINK-7647] [flip6] Port JobManagerConfigHandler to new ...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4691 Still failing with `ClusterConfigHandlerTest.testGetPaths:32 NullPointer` ---

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174724#comment-16174724 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandler to n...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4688 Thanks for the review @tzulitai. I've addressed your comments. Concerning the custom serialization logic, I think it does not hurt to have it, because it should be more efficient than the

[jira] [Commented] (FLINK-7638) Port CurrentJobsOverviewHandler to new REST endpoint

2017-09-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16174721#comment-16174721 ] ASF GitHub Bot commented on FLINK-7638: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4688: [FLINK-7638] [flip6] Port CurrentJobsOverviewHandl...

2017-09-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4688#discussion_r140236062 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/messages/webmonitor/JobDetails.java --- @@ -145,8 +180,89 @@ public String toString() {

[jira] [Closed] (FLINK-7571) Execution of TableSources with Time Indicators fails

2017-09-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-7571. Resolution: Fixed Fix Version/s: 1.4.0 Fixed for 1.4.0 with

[GitHub] flink pull request #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisp...

2017-09-21 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4571#discussion_r140235301 --- Diff: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java --- @@ -391,5 +391,8 @@ public void run() {

  1   2   3   >