[jira] [Updated] (FLINK-8244) There are two zookeeper client created when read data from hbase in the flink yarn session model

2017-12-12 Thread zhanglibing000 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanglibing000 updated FLINK-8244: -- Docs Text: (was: 2017-12-12 20:18:23.968 [flink-akka.actor.default-dispatcher-4] INFO

[jira] [Created] (FLINK-8247) Support Hadoop-free variant of Flink on Mesos

2017-12-12 Thread Eron Wright (JIRA)
Eron Wright created FLINK-8247: --- Summary: Support Hadoop-free variant of Flink on Mesos Key: FLINK-8247 URL: https://issues.apache.org/jira/browse/FLINK-8247 Project: Flink Issue Type: Bug

[jira] [Closed] (FLINK-8219) Kinesis Connector metrics

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8219. --- Resolution: Duplicate > Kinesis Connector metrics > - > >

[GitHub] flink pull request #5157: [hotfix] [docs] Consistent capitalization in Mesos...

2017-12-12 Thread joerg84
GitHub user joerg84 opened a pull request: https://github.com/apache/flink/pull/5157 [hotfix] [docs] Consistent capitalization in Mesos documentation. *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community

[jira] [Commented] (FLINK-8213) Prevent potential metric-related ClassCastExceptions

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288142#comment-16288142 ] ASF GitHub Bot commented on FLINK-8213: --- Github user zentol closed the pull request at:

[GitHub] flink pull request #5154: [FLINK-8213][metrics] Guard against metric-related...

2017-12-12 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/5154 ---

[jira] [Commented] (FLINK-8080) Rework "metrics.reporters" config option to an optional include list

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288130#comment-16288130 ] ASF GitHub Bot commented on FLINK-8080: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-8238) StreamTaskTestHarness should only allow one setup call

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288132#comment-16288132 ] ASF GitHub Bot commented on FLINK-8238: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7749) Refactor the ResultPartitionWriter into an interface

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7749. --- Resolution: Fixed Fix Version/s: 1.5.0 master:

[jira] [Closed] (FLINK-8241) Remove ResultPartitionWriter related PrepareForTest annotations

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8241. --- Resolution: Fixed master: c5efb1f208979fc5a787ba55dc185a7bf2991388 > Remove

[jira] [Commented] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288133#comment-16288133 ] ASF GitHub Bot commented on FLINK-7748: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7749) Refactor the ResultPartitionWriter into an interface

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288129#comment-16288129 ] ASF GitHub Bot commented on FLINK-7749: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-7748) remove event listener behaviour from ResultPartitionWriter

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7748. --- Resolution: Fixed Fix Version/s: 1.5.0 master:

[jira] [Commented] (FLINK-8241) Remove ResultPartitionWriter related PrepareForTest annotations

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288131#comment-16288131 ] ASF GitHub Bot commented on FLINK-8241: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-8080) Rework "metrics.reporters" config option to an optional include list

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8080. --- Resolution: Fixed master: 493c28571f22d9dde4edbec0ba38f2761fb51335 > Rework

[GitHub] flink pull request #5153: [FLINK-8238][FLINK-8239] Extend StreamTaskTestHarn...

2017-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5153 ---

[GitHub] flink pull request #5147: [FLINK-8241][tests] Remove ResultPartitionWriter-r...

2017-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5147 ---

[GitHub] flink pull request #5127: [FLINK-7749][network] refactor the ResultPartition...

2017-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5127 ---

[GitHub] flink pull request #4761: [FLINK-7748][network] properly use the TaskEventDi...

2017-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4761 ---

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5099 ---

[jira] [Closed] (FLINK-8239) Extend StreamTaskTestHarness to support TwoInput head operators

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8239. --- Resolution: Fixed master: c1665c12b49752af2f4d2c624095dcec432efe8e > Extend

[jira] [Closed] (FLINK-8238) StreamTaskTestHarness should only allow one setup call

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8238. --- Resolution: Fixed master: 6e89878166c0b8b8193ae69a675b6d085ffa9fe7 > StreamTaskTestHarness

[jira] [Closed] (FLINK-8213) Prevent potential metric-related ClassCastExceptions

2017-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8213. --- Resolution: Fixed Fix Version/s: 1.5.0 master:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287927#comment-16287927 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5105: [FLINK-8178][network] Introduce not threadsafe write only...

2017-12-12 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5105 oh, and FYI: since nothing (except the hotfix) is actually left of FLINK-8172 after this PR, you should squash it away and close #5104 as well ---

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287921#comment-16287921 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287914#comment-16287914 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287913#comment-16287913 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287902#comment-16287902 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287918#comment-16287918 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287899#comment-16287899 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287909#comment-16287909 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287904#comment-16287904 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287896#comment-16287896 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287907#comment-16287907 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287916#comment-16287916 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287920#comment-16287920 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287901#comment-16287901 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287906#comment-16287906 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287919#comment-16287919 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287915#comment-16287915 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287895#comment-16287895 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287912#comment-16287912 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287908#comment-16287908 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287905#comment-16287905 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287910#comment-16287910 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287897#comment-16287897 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287898#comment-16287898 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287917#comment-16287917 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287903#comment-16287903 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287900#comment-16287900 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287911#comment-16287911 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156404597 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java --- @@ -0,0 +1,104 @@

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156413073 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java --- @@ -169,33 +151,29 @@ public

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156416892 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156402616 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/MockEnvironment.java --- @@ -101,7 +90,8 @@ private final

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156418279 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156420568 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -179,7 +179,8 @@ public void

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156427022 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferBuilderTestUtils.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287894#comment-16287894 ] ASF GitHub Bot commented on FLINK-8178: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156412102 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java --- @@ -169,33 +151,29 @@ public

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156403311 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java --- @@ -0,0 +1,104 @@

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156421194 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -179,7 +179,8 @@ public void

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156418933 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156387848 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/util/TestBufferFactory.java --- @@ -40,37 +39,31 @@ private final

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156403467 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java --- @@ -0,0 +1,104 @@

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156414085 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/writer/RecordWriter.java --- @@ -129,8 +130,8 @@ private void sendToTarget(T

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156399551 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordCollectingResultPartitionWriter.java --- @@ -0,0 +1,88 @@ +/*

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156425243 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java --- @@ -118,7 +122,7 @@ public Buffer

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156420605 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -188,10 +189,16 @@ public Buffer requestBuffer()

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156411078 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java --- @@ -50,24 +51,15 @@

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156386302 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionViewTest.java --- @@ -48,8 +47,7 @@

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156426121 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/util/TestPooledBufferProvider.java --- @@ -28,66 +29,62 @@ import

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156422394 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/BufferBuilderTestUtils.java --- @@ -0,0 +1,36 @@ +/* + * Licensed to

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156389253 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java --- @@ -558,4 +565,10 @@ public void

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156418759 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156426879 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java --- @@ -155,13 +159,13 @@ public Void call()

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156404244 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java --- @@ -0,0 +1,104 @@

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156407089 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamMockEnvironment.java --- @@ -144,51 +136,12 @@ public void

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156397312 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolDestroyTest.java --- @@ -104,11 +104,10 @@ public void

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-12 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156392377 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java --- @@ -360,7 +367,7 @@ public void

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287852#comment-16287852 ] ASF GitHub Bot commented on FLINK-8220: --- Github user zentol commented on the issue:

[GitHub] flink issue #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5134 Skipping the `maven-deploy-plugin` should accomplish that: ``` org.apache.maven.plugins

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287845#comment-16287845 ] ASF GitHub Bot commented on FLINK-8220: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5134 I having a `flink-benchmarks` repo is not a solution that the community likes, we could check whether adding it in `test` scope is okay, if we ensure we do not publish a "test-jar" - that way

[jira] [Commented] (FLINK-8238) StreamTaskTestHarness should only allow one setup call

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287793#comment-16287793 ] ASF GitHub Bot commented on FLINK-8238: --- Github user zentol commented on the issue:

[GitHub] flink issue #5153: [FLINK-8238][FLINK-8239] Extend StreamTaskTestHarness

2017-12-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5153 merging. ---

[jira] [Commented] (FLINK-8213) Prevent potential metric-related ClassCastExceptions

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287788#comment-16287788 ] ASF GitHub Bot commented on FLINK-8213: --- Github user zentol commented on the issue:

[jira] [Created] (FLINK-8246) Download page must not link to dist.apache.org

2017-12-12 Thread Sebb (JIRA)
Sebb created FLINK-8246: --- Summary: Download page must not link to dist.apache.org Key: FLINK-8246 URL: https://issues.apache.org/jira/browse/FLINK-8246 Project: Flink Issue Type: Bug

[GitHub] flink issue #5154: [FLINK-8213][metrics] Guard against metric-related ClassC...

2017-12-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5154 I will squash the first 4 commits which resolves the comment, and merge it (after a rebase). ---

[jira] [Commented] (FLINK-8217) Properly annotate APIs of flink-connector-kinesis

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287780#comment-16287780 ] ASF GitHub Bot commented on FLINK-8217: --- Github user greghogan commented on the issue:

[jira] [Commented] (FLINK-8080) Rework "metrics.reporters" config option to an optional include list

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287781#comment-16287781 ] ASF GitHub Bot commented on FLINK-8080: --- Github user zentol commented on the issue:

[GitHub] flink issue #5099: [FLINK-8080][metrics] Remove need for "metrics.reporters"...

2017-12-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5099 @greghogan Thank your for reviewing this 👍, will fix the typo while merging. ---

[GitHub] flink issue #5138: [FLINK-8217] [Kinesis connector] Properly annotate APIs o...

2017-12-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5138 @bowenli86 the `@Public` annotation is much more than an acknowledgement, it promises that Flink will support that API essentially forever (despite the large number of "2.0" tickets, it's likely

[GitHub] flink issue #5144: [Minor][cleanup] Remove unnecessary semicolons

2017-12-12 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5144 Just use the static code analysis tool provided by IntelliJ IDEA. On menu bar click on `Analyze -> Inspect Code` :) ---

[jira] [Commented] (FLINK-8080) Rework "metrics.reporters" config option to an optional include list

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287702#comment-16287702 ] ASF GitHub Bot commented on FLINK-8080: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5099: [FLINK-8080][metrics] Remove need for "metrics.rep...

2017-12-12 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5099#discussion_r156386303 --- Diff: docs/monitoring/metrics.md --- @@ -333,7 +333,7 @@ reporters will be instantiated on each job and task manager when they are starte -

[jira] [Commented] (FLINK-8220) Implement set of network throughput benchmarks in Flink

2017-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287693#comment-16287693 ] ASF GitHub Bot commented on FLINK-8220: --- Github user greghogan commented on the issue:

[GitHub] flink issue #5134: [FLINK-8220] Implement set of network benchmarks

2017-12-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5134 @StephanEwen thanks for the link and thoughtful discussion. Including `jmh` benchmarks has come up multiple times. Do you see any path to including such a benchmark module in the main Flink repo?

[GitHub] flink issue #5144: [Minor][cleanup] Remove unnecessary semicolons

2017-12-12 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5144 @yew1eb thanks for this PR. It would be helpful if you could provide how you discovered these style issues (IntelliJ analysis?) and if there is a way to automatically discover and/or flag these in

  1   2   >