[jira] [Commented] (FLINK-9174) The type of state created in ProccessWindowFunction.proccess() is inconsistency

2018-04-24 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451673#comment-16451673 ] Sihua Zhou commented on FLINK-9174: --- Hi [~aljoscha], could you please have a look at this? Do you think

[jira] [Commented] (FLINK-8497) KafkaConsumer throws NPE if topic doesn't exist

2018-04-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451495#comment-16451495 ] vinoyang commented on FLINK-8497: - Hi [~alexey.lesnov] , are you on processing about this issue? >

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5904#discussion_r183922637 --- Diff: pom.xml --- @@ -636,6 +636,63 @@ under the License. + + fast +

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451488#comment-16451488 ] ASF GitHub Bot commented on FLINK-9249: --- Github user zhangminglei commented on a diff in the pull

[jira] [Comment Edited] (FLINK-7588) Document RocksDB tuning for spinning disks

2018-04-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258309#comment-16258309 ] Ted Yu edited comment on FLINK-7588 at 4/25/18 12:54 AM: - bq. Be careful about

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451228#comment-16451228 ] ASF GitHub Bot commented on FLINK-8689: --- Github user walterddr commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-24 Thread walterddr
Github user walterddr commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r183880939 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,15 @@ class

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450465#comment-16450465 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r183867019 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/OverWindowITCase.scala --- @@ -50,6 +50,155 @@ class

[jira] [Commented] (FLINK-8689) Add runtime support of distinct filter using MapView

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450464#comment-16450464 ] ASF GitHub Bot commented on FLINK-8689: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5555: [FLINK-8689][table]Add runtime support of distinct...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/#discussion_r183866776 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -151,8 +157,15 @@ class

[jira] [Comment Edited] (FLINK-8037) Missing cast in integer arithmetic in TransactionalIdsGenerator#generateIdsToAbort

2018-04-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427664#comment-16427664 ] Ted Yu edited comment on FLINK-8037 at 4/24/18 7:06 PM: Please rebase PR . was

[jira] [Updated] (FLINK-9048) LocalFlinkMiniClusterITCase#testLocalFlinkMiniClusterWithMultipleTaskManagers sometimes fails

2018-04-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9048: -- Description: As of commit e0bc37bef69f5376d03214578e9b95816add661b, I got the following : {code}

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450378#comment-16450378 ] ASF GitHub Bot commented on FLINK-9249: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5904#discussion_r183841885 --- Diff: pom.xml --- @@ -636,6 +636,63 @@ under the License. + + fast +

[jira] [Comment Edited] (FLINK-9219) Add support for OpenGIS features in Table & SQL API

2018-04-24 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450266#comment-16450266 ] Xingcan Cui edited comment on FLINK-9219 at 4/24/18 5:43 PM: - [~twalthr], it's

[jira] [Commented] (FLINK-9219) Add support for OpenGIS features in Table & SQL API

2018-04-24 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450266#comment-16450266 ] Xingcan Cui commented on FLINK-9219: [~twalthr], it's an ESRI type wrapped by Calcite. > Add support

[jira] [Resolved] (FLINK-9115) Support addition of part suffix in BucketingSink

2018-04-24 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lakshmi Rao resolved FLINK-9115. Resolution: Duplicate > Support addition of part suffix in BucketingSink >

[jira] [Updated] (FLINK-9251) Move MemoryStateBackend to flink-state-backends

2018-04-24 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-9251: -- Fix Version/s: 1.6.0 > Move MemoryStateBackend to flink-state-backends >

[jira] [Updated] (FLINK-9251) Move MemoryStateBackend to flink-state-backends

2018-04-24 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou updated FLINK-9251: -- Affects Version/s: 1.6.0 1.5.0 > Move MemoryStateBackend to flink-state-backends

[jira] [Assigned] (FLINK-9251) Move MemoryStateBackend to flink-state-backends

2018-04-24 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou reassigned FLINK-9251: - Assignee: Sihua Zhou > Move MemoryStateBackend to flink-state-backends >

[jira] [Created] (FLINK-9251) Move MemoryStateBackend to flink-state-backends

2018-04-24 Thread Sihua Zhou (JIRA)
Sihua Zhou created FLINK-9251: - Summary: Move MemoryStateBackend to flink-state-backends Key: FLINK-9251 URL: https://issues.apache.org/jira/browse/FLINK-9251 Project: Flink Issue Type:

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450135#comment-16450135 ] ASF GitHub Bot commented on FLINK-9249: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5904#discussion_r183790505 --- Diff: pom.xml --- @@ -636,6 +636,63 @@ under the License. + + fast +

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450124#comment-16450124 ] ASF GitHub Bot commented on FLINK-9249: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5904#discussion_r183787514 --- Diff: pom.xml --- @@ -636,6 +636,63 @@ under the License. + + fast +

[jira] [Updated] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-9231: Description: This allows sockets to be bound even if there are sockets from a previous application

[jira] [Comment Edited] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450111#comment-16450111 ] mingleizhang edited comment on FLINK-9231 at 4/24/18 3:51 PM: -- Hi, [~triones]

[jira] [Commented] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450111#comment-16450111 ] mingleizhang commented on FLINK-9231: - Hi, [~triones] I think you can push a PR first. Would not

[jira] [Commented] (FLINK-9219) Add support for OpenGIS features in Table & SQL API

2018-04-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450109#comment-16450109 ] Timo Walther commented on FLINK-9219: - [~xccui] is this type a Calcite or ESRI type? > Add support

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread Narayanan Arunachalam (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450075#comment-16450075 ] Narayanan Arunachalam commented on FLINK-9138: -- I will try the changes. Upgrading is going to

[jira] [Commented] (FLINK-9115) Support addition of part suffix in BucketingSink

2018-04-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450069#comment-16450069 ] Fabian Hueske commented on FLINK-9115: -- Thanks for helping to keep the JIRA clean [~glaksh100]! :-)

[jira] [Commented] (FLINK-9115) Support addition of part suffix in BucketingSink

2018-04-24 Thread Andrei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450056#comment-16450056 ] Andrei commented on FLINK-9115: --- OK, no problems > Support addition of part suffix in BucketingSink >

[jira] [Comment Edited] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448142#comment-16448142 ] Ted Yu edited comment on FLINK-9231 at 4/24/18 3:07 PM: Plan for

[jira] [Commented] (FLINK-9115) Support addition of part suffix in BucketingSink

2018-04-24 Thread Lakshmi Rao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450027#comment-16450027 ] Lakshmi Rao commented on FLINK-9115: Hi [~Poluliakh], thanks for offering to work on this. As I was

[jira] [Commented] (FLINK-9179) Deduplicate WebOptions.PORT and RestOptions.REST_PORT

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450021#comment-16450021 ] ASF GitHub Bot commented on FLINK-9179: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #5856: [FLINK-9179] [conf] Fix deduplicate WebOptions.PORT and R...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5856 Thanks for @zentol having an awesome review! Will have a update soon. ---

[jira] [Commented] (FLINK-9219) Add support for OpenGIS features in Table & SQL API

2018-04-24 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450019#comment-16450019 ] Xingcan Cui commented on FLINK-9219: That's fine. Thanks for your comment, [~fhueske]. > Add support

[jira] [Commented] (FLINK-9219) Add support for OpenGIS features in Table & SQL API

2018-04-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450012#comment-16450012 ] Fabian Hueske commented on FLINK-9219: -- I think we should implement a new built-in type including

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450003#comment-16450003 ] Fabian Hueske commented on FLINK-9138: -- [~narayaruna], we'd probably add this feature for 1.6.0 as we

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449984#comment-16449984 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449986#comment-16449986 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449985#comment-16449985 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449987#comment-16449987 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449990#comment-16449990 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449989#comment-16449989 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9138) Enhance BucketingSink to also flush data by time interval

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449988#comment-16449988 ] ASF GitHub Bot commented on FLINK-9138: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183754129 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -87,9

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183756583 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -536,6

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183757920 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -536,6

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183754480 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -472,6

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183753866 --- Diff: flink-connectors/flink-connector-filesystem/src/main/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSink.java --- @@ -87,9

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183758663 --- Diff: flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java --- @@ -436,6

[GitHub] flink pull request #5860: [FLINK-9138][filesystem-connectors] Implement time...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5860#discussion_r183758338 --- Diff: flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkTest.java --- @@ -436,6

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449972#comment-16449972 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r183756061 --- Diff: flink-end-to-end-tests/test-scripts/test-class/ElasticsearchStreamingJob.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r183753921 --- Diff: flink-end-to-end-tests/test-scripts/test-class/ElasticsearchStreamingJob.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449966#comment-16449966 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449957#comment-16449957 ] ASF GitHub Bot commented on FLINK-8686: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449961#comment-16449961 ] ASF GitHub Bot commented on FLINK-8686: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449959#comment-16449959 ] ASF GitHub Bot commented on FLINK-8686: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449960#comment-16449960 ] ASF GitHub Bot commented on FLINK-8686: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-8686) Improve basic embedded SQL client

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449958#comment-16449958 ] ASF GitHub Bot commented on FLINK-8686: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183748841 --- Diff: flink-dist/src/main/resources/flink-conf.yaml --- @@ -229,17 +229,26 @@ web.port: 8081 # Directory to upload completed jobs to. Add this

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183746951 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183743259 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -95,6 +95,8 @@ DEFAULT_ENV_LOG_MAX=5 # Maximum number of old log

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183721315 --- Diff: flink-libraries/flink-sql-client/bin/sql-client.sh --- @@ -44,20 +44,32 @@ bin=`dirname "$target"` . "$bin"/config.sh if [

[GitHub] flink pull request #5867: [FLINK-8686] [sql-client] Improve basic embedded S...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5867#discussion_r183729075 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/Environment.java --- @@ -91,6 +92,22 @@ public Deployment

[jira] [Commented] (FLINK-8480) Implement Java API to expose join functionality of TimeBoundedStreamJoinOperator

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449930#comment-16449930 ] ASF GitHub Bot commented on FLINK-8480: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #5482: [FLINK-8480][DataStream] Add Java API for timeboun...

2018-04-24 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5482#discussion_r183745456 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java --- @@ -137,6 +158,151 @@ public EqualTo

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449927#comment-16449927 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r183745076 --- Diff: flink-end-to-end-tests/test-scripts/test-class/ElasticsearchStreamingJob.java --- @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread Triones Deng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448079#comment-16448079 ] Triones Deng edited comment on FLINK-9231 at 4/24/18 2:05 PM: --

[jira] [Commented] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449911#comment-16449911 ] mingleizhang commented on FLINK-9231: - Come on [~triones]! :D > Enable SO_REUSEADDR on listen sockets

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449909#comment-16449909 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r183742072 --- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh --- @@ -0,0 +1,123 @@ +#!/usr/bin/env bash

[jira] [Commented] (FLINK-9008) End-to-end test: Quickstarts

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449903#comment-16449903 ] ASF GitHub Bot commented on FLINK-9008: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5823: [FLINK-9008] [e2e] Implements quickstarts end to e...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5823#discussion_r183741490 --- Diff: flink-end-to-end-tests/run-pre-commit-tests.sh --- @@ -53,6 +53,14 @@ if [ $EXIT_CODE == 0 ]; then EXIT_CODE=$? fi +if

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449902#comment-16449902 ] ASF GitHub Bot commented on FLINK-9249: --- Github user W4anD0eR96 commented on a diff in the pull

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread W4anD0eR96
Github user W4anD0eR96 commented on a diff in the pull request: https://github.com/apache/flink/pull/5904#discussion_r183741162 --- Diff: pom.xml --- @@ -636,6 +636,63 @@ under the License. + + fast +

[jira] [Comment Edited] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread Triones Deng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448079#comment-16448079 ] Triones Deng edited comment on FLINK-9231 at 4/24/18 1:56 PM: --

[jira] [Comment Edited] (FLINK-9231) Enable SO_REUSEADDR on listen sockets

2018-04-24 Thread Triones Deng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16448079#comment-16448079 ] Triones Deng edited comment on FLINK-9231 at 4/24/18 1:54 PM: --

[jira] [Commented] (FLINK-9219) Add support for OpenGIS features in Table & SQL API

2018-04-24 Thread Xingcan Cui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449889#comment-16449889 ] Xingcan Cui commented on FLINK-9219: Hi [~twalthr], I was working on this issue. Since the {{Geom}}

[jira] [Commented] (FLINK-9249) Add convenience profile for skipping non-essential plugins

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449878#comment-16449878 ] ASF GitHub Bot commented on FLINK-9249: --- Github user zhangminglei commented on a diff in the pull

[GitHub] flink pull request #5904: [FLINK-9249][build] Add convenience profile for sk...

2018-04-24 Thread zhangminglei
Github user zhangminglei commented on a diff in the pull request: https://github.com/apache/flink/pull/5904#discussion_r183735405 --- Diff: pom.xml --- @@ -636,6 +636,63 @@ under the License. + + fast +

[jira] [Commented] (FLINK-9115) Support addition of part suffix in BucketingSink

2018-04-24 Thread Andrei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449846#comment-16449846 ] Andrei commented on FLINK-9115: --- Hi [~glaksh100]. I'm ready to work on this > Support addition of part

[jira] [Commented] (FLINK-8480) Implement Java API to expose join functionality of TimeBoundedStreamJoinOperator

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449836#comment-16449836 ] ASF GitHub Bot commented on FLINK-8480: --- Github user florianschmidt1994 commented on a diff in the

[GitHub] flink pull request #5482: [FLINK-8480][DataStream] Add Java API for timeboun...

2018-04-24 Thread florianschmidt1994
Github user florianschmidt1994 commented on a diff in the pull request: https://github.com/apache/flink/pull/5482#discussion_r183727245 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/JoinedStreams.java --- @@ -137,6 +158,151 @@ public

[jira] [Commented] (FLINK-8912) Web UI does not render error messages correctly in FLIP-6 mode

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449835#comment-16449835 ] ASF GitHub Bot commented on FLINK-8912: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #5907: [FLINK-8912][WebUI] Update error handling for flip...

2018-04-24 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5907 [FLINK-8912][WebUI] Update error handling for flip6 ## What is the purpose of the change This PR updates the error handling in the webUI to support Flip6. Error reporting was standardized

[jira] [Commented] (FLINK-8497) KafkaConsumer throws NPE if topic doesn't exist

2018-04-24 Thread Aleksei Lesnov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449816#comment-16449816 ] Aleksei Lesnov commented on FLINK-8497: --- Hi [~snowch] , I'd like to take this ticket for

[jira] [Commented] (FLINK-9194) Finished jobs are not archived to HistoryServer

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449809#comment-16449809 ] ASF GitHub Bot commented on FLINK-9194: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5902: [FLINK-9194][history] Add HistoryServer support to...

2018-04-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5902#discussion_r183720759 --- Diff: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java --- @@ -211,7 +215,7 @@ public void

[jira] [Assigned] (FLINK-8912) Web UI does not render error messages correctly in FLIP-6 mode

2018-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-8912: --- Assignee: Chesnay Schepler > Web UI does not render error messages correctly in

[jira] [Commented] (FLINK-9213) Revert breaking change in checkpoint detail URL

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449806#comment-16449806 ] ASF GitHub Bot commented on FLINK-9213: --- GitHub user azagrebin opened a pull request:

[jira] [Updated] (FLINK-8912) Web UI does not render error messages correctly in FLIP-6 mode

2018-04-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8912: Affects Version/s: (was: 1.6.0) > Web UI does not render error messages correctly in

[GitHub] flink pull request #5906: [FLINK-9213] [REST] [docs] Revert checkpoint detai...

2018-04-24 Thread azagrebin
GitHub user azagrebin opened a pull request: https://github.com/apache/flink/pull/5906 [FLINK-9213] [REST] [docs] Revert checkpoint details URL from '/jobs/:jobid/checkpoints/:checkpointid' to '/jobs/:jobid/checkpoints/details/:checkpointid' as it was in 1.5 ## What is the purpose

[jira] [Commented] (FLINK-9229) Fix literal handling in code generation

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449788#comment-16449788 ] ASF GitHub Bot commented on FLINK-9229: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-9229) Fix literal handling in code generation

2018-04-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449789#comment-16449789 ] ASF GitHub Bot commented on FLINK-9229: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #5898: [FLINK-9229] [table] Fix literal handling in code ...

2018-04-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5898#discussion_r183716512 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -1274,30 +1276,46 @@ abstract class

  1   2   3   >