[jira] [Updated] (FLINK-30893) Replace not specifying a driver in Minikube by something else

2023-02-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30893: -- Description: Quoting [~wangyang0918] here from a [Github PR

[jira] [Commented] (FLINK-30893) Replace not specifying a driver in Minikube by something else

2023-02-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683723#comment-17683723 ] Matthias Pohl commented on FLINK-30893: --- I'm going to label this one as {{starter}} because fixing

[jira] [Updated] (FLINK-30893) Replace not specifying a driver in Minikube by something else

2023-02-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30893: -- Labels: starter (was: ) > Replace not specifying a driver in Minikube by something else >

[GitHub] [flink] XComp commented on pull request #21837: [BP-1.15][FLINK-30881][ci] Replaces optional minikube installation by mandatory removal

2023-02-02 Thread via GitHub
XComp commented on PR #21837: URL: https://github.com/apache/flink/pull/21837#issuecomment-1415272493 I created FLINK-30893 to cover the `none` driver improvement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (FLINK-30893) Replace not specifying a driver in Minikube by something else

2023-02-02 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30893: - Summary: Replace not specifying a driver in Minikube by something else Key: FLINK-30893 URL: https://issues.apache.org/jira/browse/FLINK-30893 Project: Flink

[GitHub] [flink-connector-jdbc] Shawn-Hx commented on pull request #3: [FLINK-15462][connectors] Add Trino dialect

2023-02-02 Thread via GitHub
Shawn-Hx commented on PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1415260837 @MartijnVisser Thanks for reminding, will review it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (FLINK-30881) Crictl/Minikube version mismatch causes errors in k8s setup

2023-02-02 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30881. --- Fix Version/s: 1.17.0 1.15.4 1.16.2 Resolution:

[GitHub] [flink] XComp merged pull request #21837: [BP-1.15][FLINK-30881][ci] Replaces optional minikube installation by mandatory removal

2023-02-02 Thread via GitHub
XComp merged PR #21837: URL: https://github.com/apache/flink/pull/21837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp merged pull request #21836: [BP-1.16][FLINK-30881][ci] Replaces optional minikube installation by mandatory removal

2023-02-02 Thread via GitHub
XComp merged PR #21836: URL: https://github.com/apache/flink/pull/21836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp merged pull request #21834: [FLINK-30881] Fixes Minikube version

2023-02-02 Thread via GitHub
XComp merged PR #21834: URL: https://github.com/apache/flink/pull/21834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp commented on pull request #21836: [BP-1.16][FLINK-30881][ci] Replaces optional minikube installation by mandatory removal

2023-02-02 Thread via GitHub
XComp commented on PR #21836: URL: https://github.com/apache/flink/pull/21836#issuecomment-1415246082 @wangyang0918 approved this approach in the 1.15 backport PR #21837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] XComp commented on pull request #21834: [FLINK-30881] Fixes Minikube version

2023-02-02 Thread via GitHub
XComp commented on PR #21834: URL: https://github.com/apache/flink/pull/21834#issuecomment-1415245828 @wangyang0918 approved this approach in the 1.15 backport PR #21837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] flinkbot commented on pull request #21840: [FLINK-29481] Show jobType in webUI

2023-02-02 Thread via GitHub
flinkbot commented on PR #21840: URL: https://github.com/apache/flink/pull/21840#issuecomment-1415238407 ## CI report: * c4e1123a4c629e8385c108a50b77ebf49986bc2c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-30845) Params in jarURI end up in file name

2023-02-02 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30845: -- Assignee: Fabio Wanner > Params in jarURI end up in file name >

[jira] [Updated] (FLINK-29481) Show JobType on WebUI

2023-02-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29481: --- Labels: features pull-request-available (was: features) > Show JobType on WebUI >

[GitHub] [flink] dangshazi opened a new pull request, #21840: [FLINK-29481] Show jobType in webUI

2023-02-02 Thread via GitHub
dangshazi opened a new pull request, #21840: URL: https://github.com/apache/flink/pull/21840 This close #29481 ## What is the purpose of the change *Show jobType(runtime.execution-mode) in webUI for each job* ## Brief change log *As following:* -

[jira] [Updated] (FLINK-30845) Params in jarURI end up in file name

2023-02-02 Thread Fabio Wanner (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabio Wanner updated FLINK-30845: - External issue URL: (was: https://github.com/apache/flink-kubernetes-operator/pull/522) >

[GitHub] [flink-kubernetes-operator] FabioWanner commented on pull request #522: [FLINK-30845] HttpArtifactFetcher: Fix filename

2023-02-02 Thread via GitHub
FabioWanner commented on PR #522: URL: https://github.com/apache/flink-kubernetes-operator/pull/522#issuecomment-1415211160 Sorry I accidentally linked the wrong issue in the title. The git-bot does not seem to pick up the change thou... -- This is an automated message from the Apache

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1094650744 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/Swing.java: ## @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (FLINK-30845) Params in jarURI end up in file name

2023-02-02 Thread Fabio Wanner (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabio Wanner updated FLINK-30845: - External issue URL: https://github.com/apache/flink-kubernetes-operator/pull/522

[jira] [Commented] (FLINK-30729) AggregateITCase generates stacktraces of IllegalStateExceptions in Maven output but doesn't fail

2023-02-02 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683708#comment-17683708 ] Yanfei Lei commented on FLINK-30729: Cause [most

[jira] [Created] (FLINK-30892) Clean codes for memory and tests

2023-02-02 Thread Feng Wang (Jira)
Feng Wang created FLINK-30892: - Summary: Clean codes for memory and tests Key: FLINK-30892 URL: https://issues.apache.org/jira/browse/FLINK-30892 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-30851) flink-kubernetes-operator - operator image should provide s3 support for jarUri

2023-02-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30851: --- Labels: pull-request-available (was: ) > flink-kubernetes-operator - operator image should

[GitHub] [flink-kubernetes-operator] FabioWanner opened a new pull request, #522: [FLINK-30851] HttpArtifactFetcher: Fix filename

2023-02-02 Thread via GitHub
FabioWanner opened a new pull request, #522: URL: https://github.com/apache/flink-kubernetes-operator/pull/522 ## What is the purpose of the change The HttpArtifactFetcher now only keeps the actual file name without the URI params as the file name. Previously the params were part of

[GitHub] [flink] godfreyhe commented on a diff in pull request #21828: [FLINK-30876][table-planner] Fix ResetTransformationProcessor don't reset the transformation of ExecNode in BatchExecMultiInput.r

2023-02-02 Thread via GitHub
godfreyhe commented on code in PR #21828: URL: https://github.com/apache/flink/pull/21828#discussion_r1095421034 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/processor/MultipleInputNodeCreationProcessorTest.java: ## @@ -102,11

[GitHub] [flink] flinkbot commented on pull request #21839: [hotfix] Set HybridPartitionDataConsumeConstraint to ALL_PRODUCERS_FINISHED for auto parallelism.

2023-02-02 Thread via GitHub
flinkbot commented on PR #21839: URL: https://github.com/apache/flink/pull/21839#issuecomment-1415151013 ## CI report: * 3e30ff4f30f28453731ebea03b0b725d5b5c10dc UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #202: [FLINK-30688] Disable Kryo fallback in Flink ML tests

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #202: URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095410791 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/GraphTest.java: ## @@ -49,13 +46,7 @@ public class GraphTest extends AbstractTestBase { @Before

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #202: [FLINK-30688] Disable Kryo fallback in Flink ML tests

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #202: URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095410791 ## flink-ml-core/src/test/java/org/apache/flink/ml/api/GraphTest.java: ## @@ -49,13 +46,7 @@ public class GraphTest extends AbstractTestBase { @Before

[GitHub] [flink] reswqa opened a new pull request, #21839: [hotfix] Set HybridPartitionDataConsumeConstraint to ALL_PRODUCERS_FINISHED for auto parallelism.

2023-02-02 Thread via GitHub
reswqa opened a new pull request, #21839: URL: https://github.com/apache/flink/pull/21839 ## What is the purpose of the change *In auto parallelism mode, If we set `HybridPartitionDataConsumeConstraint` to `ONLY_FINISHED_PRODUCERS` or `UNFINISHED_PRODUCERS`, the task scheduling

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #202: [FLINK-30688] Disable Kryo fallback in Flink ML tests

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #202: URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095404730 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/countvectorizer/CountVectorizer.java: ## @@ -78,7 +80,11 @@ public CountVectorizerModel fit(Table...

[GitHub] [flink] Myasuka commented on a diff in pull request #21835: [FLINK-30854][state] Support periodic compaction for RocksdbCompactFilterCleanupStrategy

2023-02-02 Thread via GitHub
Myasuka commented on code in PR #21835: URL: https://github.com/apache/flink/pull/21835#discussion_r1095402976 ## flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java: ## @@ -298,12 +298,40 @@ public Builder cleanupInRocksdbCompactFilter(long

[GitHub] [flink-table-store] JingsongLi commented on pull request #471: [FLINK-30608] support rename table

2023-02-02 Thread via GitHub
JingsongLi commented on PR #471: URL: https://github.com/apache/flink-table-store/pull/471#issuecomment-1415117636 @zhangjun0x01 Thanks! You should modify tests too. And I think you can document object store in renaming page. ``` If you use object storage, such as S3 or OSS, please

[GitHub] [flink] wanglijie95 commented on pull request #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
wanglijie95 commented on PR #21838: URL: https://github.com/apache/flink/pull/21838#issuecomment-1415112617 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-table-store] JingsongLi commented on pull request #494: [FLINK-30871] add bloom filter for orc

2023-02-02 Thread via GitHub
JingsongLi commented on PR #494: URL: https://github.com/apache/flink-table-store/pull/494#issuecomment-1415106972 > > purpose > > Hi,@JingsongLi , My purpose is to use various methods to improve the read and write performance as much as possible. Using bloom filter can improve the

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #202: [FLINK-30688] Disable Kryo fallback in Flink ML tests

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #202: URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095393813 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/ImputerTest.java: ## @@ -265,9 +265,7 @@ public void testNoValidDataOnMedianStrategy() { final

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #202: [FLINK-30688] Disable Kryo fallback in Flink ML tests

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #202: URL: https://github.com/apache/flink-ml/pull/202#discussion_r1095393813 ## flink-ml-lib/src/test/java/org/apache/flink/ml/feature/ImputerTest.java: ## @@ -265,9 +265,7 @@ public void testNoValidDataOnMedianStrategy() { final

[jira] [Closed] (FLINK-30891) Introduce Preconditions for table store

2023-02-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30891. Fix Version/s: table-store-0.4.0 Assignee: Shammon Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #496: [FLINK-30891] Introduce Preconditions for table store

2023-02-02 Thread via GitHub
JingsongLi merged PR #496: URL: https://github.com/apache/flink-table-store/pull/496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Comment Edited] (FLINK-30881) Crictl/Minikube version mismatch causes errors in k8s setup

2023-02-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683688#comment-17683688 ] Qingsheng Ren edited comment on FLINK-30881 at 2/3/23 6:12 AM: ---

[jira] [Updated] (FLINK-30882) Introduce partition.expiration-time to automatically delete expired partitions

2023-02-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-30882: - Fix Version/s: table-store-0.3.1 > Introduce partition.expiration-time to automatically delete

[jira] [Commented] (FLINK-30881) Crictl/Minikube version mismatch causes errors in k8s setup

2023-02-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683688#comment-17683688 ] Qingsheng Ren commented on FLINK-30881: ---

[jira] [Commented] (FLINK-30846) SpeculativeSchedulerITCase.testSpeculativeExecutionOfInputFormatSource fails

2023-02-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683689#comment-17683689 ] Qingsheng Ren commented on FLINK-30846: ---

[jira] [Updated] (FLINK-30882) Introduce partition.expiration-time to automatically delete expired partitions

2023-02-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30882: --- Labels: pull-request-available (was: ) > Introduce partition.expiration-time to

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #497: [FLINK-30882] Introduce partition.expiration-time to automatically delete expired partitions

2023-02-02 Thread via GitHub
JingsongLi opened a new pull request, #497: URL: https://github.com/apache/flink-table-store/pull/497 Same to snapshot expiration, we can also introduce partition expiration to automatically delete expired partitions in commit node. -- This is an automated message from the Apache Git

[GitHub] [flink] wanglijie95 commented on pull request #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
wanglijie95 commented on PR #21838: URL: https://github.com/apache/flink/pull/21838#issuecomment-1415073689 Accidentally merged the code before CI green, I will continue to pay attention. If the CI continuously failed, I will revert this change. -- This is an automated message from the

[jira] [Closed] (FLINK-28326) ResultPartitionTest.testIdleAndBackPressuredTime failed with AssertError

2023-02-02 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-28326. -- Resolution: Fixed Closed it, feel free to reopen this if it appears again. >

[GitHub] [flink] JunRuiLee commented on a diff in pull request #21829: [FLINK-30875][runtime] Remove legacy AdaptiveBatchScheduler configuration call.

2023-02-02 Thread via GitHub
JunRuiLee commented on code in PR #21829: URL: https://github.com/apache/flink/pull/21829#discussion_r1095378622 ## flink-end-to-end-tests/test-scripts/test_tpcds.sh: ## @@ -66,10 +66,10 @@ function run_test() { set_config_key "taskmanager.numberOfTaskSlots" "4"

[GitHub] [flink] wanglijie95 merged pull request #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
wanglijie95 merged PR #21838: URL: https://github.com/apache/flink/pull/21838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] JunRuiLee commented on pull request #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
JunRuiLee commented on PR #21838: URL: https://github.com/apache/flink/pull/21838#issuecomment-1415004719 @wanglijie95 I've addressed all comment. PTAL! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Closed] (FLINK-29735) Introduce Metadata tables for table store

2023-02-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-29735. Resolution: Fixed > Introduce Metadata tables for table store >

[jira] [Closed] (FLINK-30516) Support files table in table store

2023-02-02 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30516. Fix Version/s: table-store-0.4.0 Assignee: Shammon Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #484: [FLINK-30516] Introduce files table in table store

2023-02-02 Thread via GitHub
JingsongLi merged PR #484: URL: https://github.com/apache/flink-table-store/pull/484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
wanglijie95 commented on code in PR #21838: URL: https://github.com/apache/flink/pull/21838#discussion_r1095359402 ## docs/layouts/shortcodes/generated/batch_execution_configuration.html: ## @@ -39,7 +39,7 @@ The lower bound of allowed parallelism to set adaptively

[jira] [Commented] (FLINK-30874) Introduce configuration for table store

2023-02-02 Thread Shammon (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683660#comment-17683660 ] Shammon commented on FLINK-30874: - [~zhoupeijie] Sure! Hi [~lzljs3620320] can you help to assign it? >

[jira] [Updated] (FLINK-30891) Introduce Preconditions for table store

2023-02-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30891: --- Labels: pull-request-available (was: ) > Introduce Preconditions for table store >

[GitHub] [flink-table-store] zjureel opened a new pull request, #496: [FLINK-30891] Introduce Preconditions for table store

2023-02-02 Thread via GitHub
zjureel opened a new pull request, #496: URL: https://github.com/apache/flink-table-store/pull/496 Introduce Preconditions for table store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (FLINK-30891) Introduce Preconditions for table store

2023-02-02 Thread Shammon (Jira)
Shammon created FLINK-30891: --- Summary: Introduce Preconditions for table store Key: FLINK-30891 URL: https://issues.apache.org/jira/browse/FLINK-30891 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-02-02 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683655#comment-17683655 ] Feifan Wang commented on FLINK-28440: - Hi [~ym] , [~roman] , I communicated with [~Yanfei Lei] 

[jira] [Created] (FLINK-30890) Backup codespeed‘s data regularly

2023-02-02 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-30890: -- Summary: Backup codespeed‘s data regularly Key: FLINK-30890 URL: https://issues.apache.org/jira/browse/FLINK-30890 Project: Flink Issue Type: Sub-task

[jira] [Updated] (FLINK-28326) ResultPartitionTest.testIdleAndBackPressuredTime failed with AssertError

2023-02-02 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao updated FLINK-28326: Priority: Major (was: Minor) > ResultPartitionTest.testIdleAndBackPressuredTime failed with

[jira] [Updated] (FLINK-28326) ResultPartitionTest.testIdleAndBackPressuredTime failed with AssertError

2023-02-02 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao updated FLINK-28326: Priority: Minor (was: Critical) > ResultPartitionTest.testIdleAndBackPressuredTime failed with

[jira] [Commented] (FLINK-28326) ResultPartitionTest.testIdleAndBackPressuredTime failed with AssertError

2023-02-02 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683651#comment-17683651 ] Yingjie Cao commented on FLINK-28326: - master: 7980d4b7956bbb5952933d6f4c49e27f59c96834 >

[GitHub] [flink] wsry merged pull request #21815: [FLINK-28326][test] fix unstable test testIdleAndBackPressuredTime.

2023-02-02 Thread via GitHub
wsry merged PR #21815: URL: https://github.com/apache/flink/pull/21815 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wanglijie95 commented on pull request #21813: [Documentation] Fix ALL_EXCHANGES_BLOCKING (vs ALL-EXCHANGES-BLOCKING)

2023-02-02 Thread via GitHub
wanglijie95 commented on PR #21813: URL: https://github.com/apache/flink/pull/21813#issuecomment-1414898111 Thanks for creating this PR @noahshpak ! @reswqa is right, we should also fix the Chinese document: `docs/content.zh/docs/deployment/elastic_scaling.md` -- This is an

[GitHub] [flink] wsry commented on pull request #21815: [FLINK-28326][test] fix unstable test testIdleAndBackPressuredTime.

2023-02-02 Thread via GitHub
wsry commented on PR #21815: URL: https://github.com/apache/flink/pull/21815#issuecomment-1414897506 Thanks for the fix @reswqa . Test failure unrelated. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21739: [FLINK-30673][docs][table] Add documentation for "EXPLAIN PLAN_ADVICE" statement

2023-02-02 Thread via GitHub
lincoln-lil commented on code in PR #21739: URL: https://github.com/apache/flink/pull/21739#discussion_r1095333436 ## docs/content.zh/docs/dev/table/sql/explain.md: ## @@ -274,19 +331,190 @@ Union(all=[true], union=[count, word]) ## ExplainDetails +使用指定的 `ExplainDetail`

[GitHub] [flink] JunRuiLee commented on pull request #21829: [FLINK-30875][runtime] Remove legacy AdaptiveBatchScheduler configuration call.

2023-02-02 Thread via GitHub
JunRuiLee commented on PR #21829: URL: https://github.com/apache/flink/pull/21829#issuecomment-1414862033 @wanglijie95 Because the `JobManagerOptions` is annotated with @PublicEvolving so we don't want remove it to affect compatibility. -- This is an automated message from the

[jira] [Resolved] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-02-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-29427. --- Resolution: Fixed > LookupJoinITCase failed with classloader problem >

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2023-02-02 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683649#comment-17683649 ] Qingsheng Ren commented on FLINK-29427: --- Fixed on master: 0516427d198420fa28d586ed052ef26daf2845ba

[GitHub] [flink] PatrickRen merged pull request #21806: [FLINK-29427][table] Fix unstable test LookupJoinITCase by compiling Projection class in advance and run reload task using userCodeClassLoader

2023-02-02 Thread via GitHub
PatrickRen merged PR #21806: URL: https://github.com/apache/flink/pull/21806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-02-02 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feifan Wang updated FLINK-28440: Attachment: image-2023-02-03-12-03-56-614.png > EventTimeWindowCheckpointingITCase failed with

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-02-02 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feifan Wang updated FLINK-28440: Attachment: image-2023-02-03-12-03-16-155.png > EventTimeWindowCheckpointingITCase failed with

[GitHub] [flink] PatrickRen commented on pull request #21806: [FLINK-29427][table] Fix unstable test LookupJoinITCase by compiling Projection class in advance and run reload task using userCodeClassLo

2023-02-02 Thread via GitHub
PatrickRen commented on PR #21806: URL: https://github.com/apache/flink/pull/21806#issuecomment-1414857467 CI failure is caused by known issue FLINK-30881. Merging to master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] wanglijie95 commented on a diff in pull request #21829: [FLINK-30875][runtime] Remove legacy AdaptiveBatchScheduler configuration call.

2023-02-02 Thread via GitHub
wanglijie95 commented on code in PR #21829: URL: https://github.com/apache/flink/pull/21829#discussion_r1095332394 ## flink-end-to-end-tests/test-scripts/test_tpcds.sh: ## @@ -66,10 +66,10 @@ function run_test() { set_config_key "taskmanager.numberOfTaskSlots" "4"

[GitHub] [flink] flinkbot commented on pull request #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
flinkbot commented on PR #21838: URL: https://github.com/apache/flink/pull/21838#issuecomment-1414849195 ## CI report: * 10ac082046b5a0e81777dec697468b9bae198fe8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30889) Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30889: --- Labels: pull-request-available (was: ) > Fix the key of configuration SPECULATIVE_ENABLED.

[GitHub] [flink] JunRuiLee opened a new pull request, #21838: [FLINK-30889][conf] Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread via GitHub
JunRuiLee opened a new pull request, #21838: URL: https://github.com/apache/flink/pull/21838 ## What is the purpose of the change In [FLINK-30686](https://issues.apache.org/jira/browse/FLINK-30686) we refined the adaptive batch configuration. However, the key of a

[jira] [Assigned] (FLINK-30889) Rename the configuration key SPECULATIVE_ENABLED.

2023-02-02 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-30889: -- Assignee: Junrui Li > Rename the configuration key SPECULATIVE_ENABLED. >

[jira] [Updated] (FLINK-30889) Fix the key of configuration SPECULATIVE_ENABLED.

2023-02-02 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Li updated FLINK-30889: -- Summary: Fix the key of configuration SPECULATIVE_ENABLED. (was: Rename the configuration key

[jira] [Commented] (FLINK-30870) Performance regressions notifications in Slack are cut off

2023-02-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683644#comment-17683644 ] Leonard Xu commented on FLINK-30870: I downgrade the issue priority to Major as it's a known slack

[jira] [Updated] (FLINK-30870) Performance regressions notifications in Slack are cut off

2023-02-02 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-30870: --- Priority: Major (was: Critical) > Performance regressions notifications in Slack are cut off >

[jira] [Updated] (FLINK-30889) Rename the configuration key SPECULATIVE_ENABLED.

2023-02-02 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Li updated FLINK-30889: -- Description: In FLINK-30686 we refined the adaptive batch configuration. However, the key of a

[jira] [Created] (FLINK-30889) Rename the configuration key SPECULATIVE_ENABLED.

2023-02-02 Thread Junrui Li (Jira)
Junrui Li created FLINK-30889: - Summary: Rename the configuration key SPECULATIVE_ENABLED. Key: FLINK-30889 URL: https://issues.apache.org/jira/browse/FLINK-30889 Project: Flink Issue Type: Bug

[GitHub] [flink] reswqa commented on pull request #21813: [Documentation] Fix ALL_EXCHANGES_BLOCKING (vs ALL-EXCHANGES-BLOCKING)

2023-02-02 Thread via GitHub
reswqa commented on PR #21813: URL: https://github.com/apache/flink/pull/21813#issuecomment-1414816802 Also cc @wanglijie95 for the double review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] reswqa commented on pull request #21813: [Documentation] Fix ALL_EXCHANGES_BLOCKING (vs ALL-EXCHANGES-BLOCKING)

2023-02-02 Thread via GitHub
reswqa commented on PR #21813: URL: https://github.com/apache/flink/pull/21813#issuecomment-1414815212 BTW, the name of this commit can be changed to `[hotfix] Fix typo in elastic_scaling.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] reswqa commented on a diff in pull request #21813: [Documentation] Fix ALL_EXCHANGES_BLOCKING (vs ALL-EXCHANGES-BLOCKING)

2023-02-02 Thread via GitHub
reswqa commented on code in PR #21813: URL: https://github.com/apache/flink/pull/21813#discussion_r1095324163 ## docs/content/docs/deployment/elastic_scaling.md: ## @@ -166,7 +166,7 @@ To automatically decide parallelisms for operators with Adaptive Batch Scheduler

[jira] [Updated] (FLINK-30792) clean up not uploaded state changes after materialization complete

2023-02-02 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei updated FLINK-30792: --- Attachment: image-2023-02-03-11-30-40-198.png > clean up not uploaded state changes after

[jira] [Commented] (FLINK-30792) clean up not uploaded state changes after materialization complete

2023-02-02 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683642#comment-17683642 ] Yanfei Lei commented on FLINK-30792: [~Feifan Wang] Thanks for the investigation, after discussing

[jira] [Commented] (FLINK-28982) Start TaskInterrupter when task switch from DEPLOYING to CANCELING

2023-02-02 Thread LI Mingkun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683641#comment-17683641 ] LI Mingkun commented on FLINK-28982: Got it. Thanks [~zhuzh]  > Start TaskInterrupter when task

[GitHub] [flink] masteryhx commented on pull request #21835: [FLINK-30854][state] Support periodic compaction for RocksdbCompactFilterCleanupStrategy

2023-02-02 Thread via GitHub
masteryhx commented on PR #21835: URL: https://github.com/apache/flink/pull/21835#issuecomment-1414790782 @Myasuka Could you help to take a review ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] masteryhx commented on pull request #21835: [FLINK-30854][state] Support periodic compaction for RocksdbCompactFilterCleanupStrategy

2023-02-02 Thread via GitHub
masteryhx commented on PR #21835: URL: https://github.com/apache/flink/pull/21835#issuecomment-1414787413 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #192: [FLINK-30451] Add Estimator and Transformer for Swing

2023-02-02 Thread via GitHub
jiangxin369 commented on code in PR #192: URL: https://github.com/apache/flink-ml/pull/192#discussion_r1094587044 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/Swing.java: ## @@ -0,0 +1,452 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-benchmarks] fredia commented on pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2023-02-02 Thread via GitHub
fredia commented on PR #63: URL: https://github.com/apache/flink-benchmarks/pull/63#issuecomment-1414772214 Thanks for the reviewing and advice, and sorry for the late response, the update of codespeed_benchmark table at Jenkins master was done, and the update of `save_jmh_result.py` and

[GitHub] [flink] JunRuiLee commented on pull request #21801: [FLINK-30838][doc] Update documentation about the AdaptiveBatchScheduler

2023-02-02 Thread via GitHub
JunRuiLee commented on PR #21801: URL: https://github.com/apache/flink/pull/21801#issuecomment-1414763173 @wanglijie95 Thanks for CR. I've addressed all comments. Please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-benchmarks] fredia commented on a diff in pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2023-02-02 Thread via GitHub
fredia commented on code in PR #63: URL: https://github.com/apache/flink-benchmarks/pull/63#discussion_r1095312004 ## update_benchmark_fileds.py: ## @@ -0,0 +1,56 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*-

[GitHub] [flink-benchmarks] fredia commented on a diff in pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2023-02-02 Thread via GitHub
fredia commented on code in PR #63: URL: https://github.com/apache/flink-benchmarks/pull/63#discussion_r1095310674 ## regression_report.py: ## @@ -131,8 +133,12 @@ def checkBenchmark(args, exe, benchmark): median_trend = 0 if median != 0: median_trend =

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #471: [FLINK-30608] support rename table

2023-02-02 Thread via GitHub
zhangjun0x01 commented on code in PR #471: URL: https://github.com/apache/flink-table-store/pull/471#discussion_r1095310375 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/catalog/FileSystemCatalog.java: ## @@ -162,6 +162,11 @@ public void

[jira] [Commented] (FLINK-30874) Introduce configuration for table store

2023-02-02 Thread zhoupeijie (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683635#comment-17683635 ] zhoupeijie commented on FLINK-30874: Hello, can this ticket be assigned to me? I'm interested in

[jira] [Commented] (FLINK-30870) Performance regressions notifications in Slack are cut off

2023-02-02 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683634#comment-17683634 ] Yanfei Lei commented on FLINK-30870: [~martijnvisser] Thanks for the ping, this is a known issue

[GitHub] [flink] zhuzhurk commented on a diff in pull request #21807: [FLINK-30842][docs] Add document for sink supports speculative execution

2023-02-02 Thread via GitHub
zhuzhurk commented on code in PR #21807: URL: https://github.com/apache/flink/pull/21807#discussion_r1095298270 ## docs/content/docs/deployment/speculative_execution.md: ## @@ -92,6 +88,31 @@ No extra change is required for other sources to work with speculative execution and

  1   2   3   4   >