GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6419
[FLINK-9949][tests] Kill Flink processes in DB/teardown
## What is the purpose of the change
*Not killing Flink processes at the end of a test, can cause interference
with subsequent test runs
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6418
[FLINK-9939][runtime] Mesos: Not setting TMP dirs causes NPE
## What is the purpose of the change
*This fixes a possible NPE when deploying on Mesos.*
## Brief change log
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6406
[FLINK-9159][runtime] Sanity check default timeout values
## What is the purpose of the change
*Set the default timeouts for resource release to sane values. Consolidate
config keys
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204400729
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -504,6 +512,107 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204399866
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphSchedulingTest.java
---
@@ -504,6 +512,107 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204394265
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
---
@@ -384,6 +393,8 @@ private MultiTaskSlot
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6386
https://github.com/apache/flink/pull/6369 should also be merged after this
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204384134
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -983,7 +983,7 @@ private void startCheckpointScheduler(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204373664
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -323,7 +323,7 @@ public void disconnectResourceManager
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6386#discussion_r204368060
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotPool.java
---
@@ -1011,7 +1011,7 @@ public void failAllocation(final
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6369
[FLINK-9892][tests] Disable local recovery in Jepsen tests.
## What is the purpose of the change
*Until FLINK-9635 is fixed, local recovery should be disabled in the Jepsen
tests
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6368
[FLINK-9890] Remove obsolete class ResourceManagerConfiguration
## What is the purpose of the change
*The configuration values are effectively not used. This commit removes the
class
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
@dawidwys Please merge.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6320
I tested the tooling around docker-compose and it works for me when using
the local distribution.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202351378
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
+
+## Installation
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202348473
--- Diff: flink-container/docker/build.sh ---
@@ -0,0 +1,128 @@
+#!/bin/sh
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202336290
--- Diff: flink-container/docker/README.md ---
@@ -0,0 +1,44 @@
+# Apache Flink cluster deployment on docker using docker-compose
+
+## Installation
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202332741
--- Diff: flink-container/pom.xml ---
@@ -0,0 +1,67 @@
+
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202332323
--- Diff:
flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,89
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202299810
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,84
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202300463
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/EntrypointClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,84
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202305883
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterConfiguration.java
---
@@ -18,27 +18,43 @@
package
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202300255
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,82
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6320#discussion_r202300519
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterConfigurationParserFactoryTest.java
---
@@ -0,0 +1,82
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6319#discussion_r202271606
--- Diff: flink-container/docker/build.sh ---
@@ -0,0 +1,118 @@
+#!/bin/sh
--- End diff --
Just want to note that in other scripts, `bash
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
I extended the regular `README.md`.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202057663
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202020619
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r202017985
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
cc: @dawidwys @StephanEwen
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r201980407
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -386,10 +386,10 @@ private ClusterSpecification
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6297#discussion_r201981340
--- Diff: docs/ops/deployment/yarn_setup.md ---
@@ -101,12 +101,12 @@ Usage:
Optional
-D Dynamic properties
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6297
I will take a look later.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6296#discussion_r201570938
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -1189,7 +1189,7 @@ private static Path
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6279#discussion_r201329956
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -536,7 +540,25 @@ private JobManagerRunner
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6240#discussion_r201312394
--- Diff: flink-jepsen/src/jepsen/flink/db.clj ---
@@ -175,7 +175,7 @@
(c/su
(c/exec (c/lit (str "HADOOP_CLASSPATH=`&qu
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6240#discussion_r200667325
--- Diff: jepsen-flink/.gitignore ---
@@ -0,0 +1,17 @@
+*.class
+*.iml
+*.jar
+*.retry
+.DS_Store
+.hg/
+.hgignore
+.idea
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
It seems that we have to stick with `0.1.8` for now. According to legal,
there are no concerns so far: https://issues.apache.org/jira/browse/LEGAL-392
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
`0.1.9.` was problematic. Currently testing `0.1.10`.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6239
@zentol No problem, I opened a new one.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
As @zentol mentioned, we might want to exclude this from
create_source_release.sh.
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6240
[FLINK-9004][tests] Implement Jepsen tests to test job availability.
## What is the purpose of the change
*Use the Jepsen framework (https://github.com/jepsen-io/jepsen) to implement
tests
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199690915
--- Diff: jepsen-flink/README.md ---
@@ -0,0 +1,60 @@
+# jepsen.flink
+
+A Clojure project based on the
[Jepsen](https://github.com/jepsen-io/jepsen
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199622404
--- Diff: jepsen-flink/README.md ---
@@ -0,0 +1,60 @@
+# jepsen.flink
+
+A Clojure project based on the
[Jepsen](https://github.com/jepsen-io/jepsen
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199507669
--- Diff: jepsen-flink/docker/nodes ---
@@ -0,0 +1,3 @@
+n1
--- End diff --
file must be excluded from RAT plugin
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6239
[FLINK-9004][tests] Implement Jepsen tests to test job availability.
## What is the purpose of the change
*Use the Jepsen framework (https://github.com/jepsen-io/jepsen) to implement
tests
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6213#discussion_r198912529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -322,9 +322,6 @@ private JobManagerRunner
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5410
Taking a look once more.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r194109528
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r194109518
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r194109540
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193965626
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +155,24 @@ public
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5410
Thanks for updating @pduveau. There still some minor comments on
`RMQSinkPublishOptions` and `README` that are open for discussion.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964437
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964455
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964429
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964402
--- Diff: flink-connectors/flink-connector-rabbitmq/README.md ---
@@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client".
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193963772
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193963587
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126744
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193101683
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193127128
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126347
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126169
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193125374
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193122068
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193119522
--- Diff: flink-connectors/flink-connector-rabbitmq/README.md ---
@@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client".
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193070753
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -66,12 +79,19
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193120662
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126219
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193125823
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126189
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193122883
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193123998
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193010305
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193004950
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java
---
@@ -109,6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193010378
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193006836
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -124,7 +159,82
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190658100
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190888216
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190650550
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190654087
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.java
---
@@ -151,7 +151,9 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190888669
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +40,36
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190887946
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,50
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190648628
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +40,36
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r190647503
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -43,14 +49,27
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6069#discussion_r190605670
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -314,7 +319,8 @@ public JobSubmissionResult submitJob
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6069#discussion_r190605113
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -274,11 +275,17 @@ public JobSubmissionResult
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190603900
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -732,19 +744,10 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190603365
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1483,6 +1485,216 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190603934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -933,25 +956,35 @@ public void requestHeartbeat(ResourceID
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190583266
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -933,25 +956,35 @@ public void requestHeartbeat(ResourceID
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190557380
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -732,19 +744,10 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190602158
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1483,6 +1485,216 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190602807
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerTest.java
---
@@ -1139,6 +1147,61 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190500268
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190548385
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6068#discussion_r190548607
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherResourceCleanupTest.java
---
@@ -271,6 +279,80 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189004536
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -1605,9 +1609,16 @@ public void notifyHeartbeatTimeout(final
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6035#discussion_r189012246
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -947,6 +964,36 @@ private void
1 - 100 of 690 matches
Mail list logo
