[GitHub] [flink] zhijiangW commented on a change in pull request #8948: [FLINK-12889] Set FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool

2019-07-03 Thread GitBox
zhijiangW commented on a change in pull request #8948: [FLINK-12889] Set FatalExitExceptionHandler for StreamTask#asyncOperationsThreadPool URL: https://github.com/apache/flink/pull/8948#discussion_r299789891 ## File path:

[jira] [Updated] (FLINK-13073) BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13073: --- Labels: pull-request-available (was: ) > BinaryRow in Blink runtime has wrong

[GitHub] [flink] JingsongLi commented on a change in pull request #8959: [FLINK-13070][table-planner-blink] Remove TableImpl and use api.internal.TableImpl in blink

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8959: [FLINK-13070][table-planner-blink] Remove TableImpl and use api.internal.TableImpl in blink URL: https://github.com/apache/flink/pull/8959#discussion_r299797109 ## File path:

[GitHub] [flink] flinkbot commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread GitBox
flinkbot commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask URL: https://github.com/apache/flink/pull/8961#issuecomment-507962159 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877616#comment-16877616 ] zhijiang commented on FLINK-12852: -- Hey [~gaoyunhaii], considering the second point for long run, I

[GitHub] [flink] KurtYoung closed pull request #8959: [FLINK-13070][table-planner-blink] Remove TableImpl and use api.internal.TableImpl in blink

2019-07-03 Thread GitBox
KurtYoung closed pull request #8959: [FLINK-13070][table-planner-blink] Remove TableImpl and use api.internal.TableImpl in blink URL: https://github.com/apache/flink/pull/8959 This is an automated message from the Apache

[GitHub] [flink] Clarkkkkk commented on a change in pull request #7550: [FLINK-10245] [Streaming Connector] Add Pojo, Tuple, Row and Scala Product DataStream Sink and Upsert Table Sink for HBase

2019-07-03 Thread GitBox
Clark commented on a change in pull request #7550: [FLINK-10245] [Streaming Connector] Add Pojo, Tuple, Row and Scala Product DataStream Sink and Upsert Table Sink for HBase URL: https://github.com/apache/flink/pull/7550#discussion_r299848590 ## File path:

[GitHub] [flink] flinkbot commented on issue #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner

2019-07-03 Thread GitBox
flinkbot commented on issue #8962: [FLINK-13076] [table-planner-blink] Bump Calcite dependency to 1.20.0 in blink planner URL: https://github.com/apache/flink/pull/8962#issuecomment-508009036 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] knaufk commented on a change in pull request #8957: [hotfix][docs] fix broken links

2019-07-03 Thread GitBox
knaufk commented on a change in pull request #8957: [hotfix][docs] fix broken links URL: https://github.com/apache/flink/pull/8957#discussion_r299852233 ## File path: docs/redirects/filesystems.md ## @@ -1,8 +1,8 @@ --- title: "File Systems" layout: redirect -redirect:

[GitHub] [flink] lirui-apache commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable…

2019-07-03 Thread GitBox
lirui-apache commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable… URL: https://github.com/apache/flink/pull/8965#issuecomment-508019784 cc @zjuwangg @bowenli86 @xuefuz This is an

[GitHub] [flink] StephanEwen commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-07-03 Thread GitBox
StephanEwen commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r299865813 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,167 @@ +--- +title: Glossary

[GitHub] [flink] flinkbot commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable…

2019-07-03 Thread GitBox
flinkbot commented on issue #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable… URL: https://github.com/apache/flink/pull/8965#issuecomment-508019361 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] flinkbot commented on issue #8964: [FLINK-13067][docs] Fix broken links to contributing docs

2019-07-03 Thread GitBox
flinkbot commented on issue #8964: [FLINK-13067][docs] Fix broken links to contributing docs URL: https://github.com/apache/flink/pull/8964#issuecomment-508019372 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[jira] [Comment Edited] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877680#comment-16877680 ] Yun Gao edited comment on FLINK-12852 at 7/3/19 9:34 AM: - Hi [~zjwang] Thanks a

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877680#comment-16877680 ] Yun Gao commented on FLINK-12852: - [~zjwang] Thanks a lot for the explanation. I'm also still thinking

[GitHub] [flink] pnowojski merged pull request #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-03 Thread GitBox
pnowojski merged pull request #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455 This is an automated message from the

[GitHub] [flink] pnowojski commented on issue #8455: [FLINK-12284][Network, Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode

2019-07-03 Thread GitBox
pnowojski commented on issue #8455: [FLINK-12284][Network,Metrics]Fix the incorrect inputBufferUsage metric in credit-based network mode URL: https://github.com/apache/flink/pull/8455#issuecomment-508023371 Thanks for the fix @Aitozi and your patience with our reviews (especially that the

[GitHub] [flink] knaufk commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-07-03 Thread GitBox
knaufk commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r299870581 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,167 @@ +--- +title: Glossary

[jira] [Updated] (FLINK-13060) FailoverStrategies should respect restart constraints

2019-07-03 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-13060: - Description: RestartStrategies can define their own restrictions for whether job can be

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877556#comment-16877556 ] Yun Gao commented on FLINK-12852: - Hi all, very thanks for the discussion and all the valuable

[GitHub] [flink] sunjincheng121 commented on issue #8719: [FLINK-12767][python] Support user defined connectors/format

2019-07-03 Thread GitBox
sunjincheng121 commented on issue #8719: [FLINK-12767][python] Support user defined connectors/format URL: https://github.com/apache/flink/pull/8719#issuecomment-507983532 @dianfu I find that the code should be rebased, otherwise the test case can not be passed.

[jira] [Commented] (FLINK-13073) BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877622#comment-16877622 ] Kurt Young commented on FLINK-13073: Thanks for the reporting and fixing! [~LouisXu777] > BinaryRow

[GitHub] [flink] Clarkkkkk commented on a change in pull request #7550: [FLINK-10245] [Streaming Connector] Add Pojo, Tuple, Row and Scala Product DataStream Sink and Upsert Table Sink for HBase

2019-07-03 Thread GitBox
Clark commented on a change in pull request #7550: [FLINK-10245] [Streaming Connector] Add Pojo, Tuple, Row and Scala Product DataStream Sink and Upsert Table Sink for HBase URL: https://github.com/apache/flink/pull/7550#discussion_r299848380 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299854221 ## File path: flink-table/flink-table-planner/pom.xml ## @@ -88,26 +88,26 @@

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299855675 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299792915 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299835877 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299854677 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299855075 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299792712 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(…

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8844: [FLINK-12951][table-planner] Add logic to bridge DDL to table source(… URL: https://github.com/apache/flink/pull/8844#discussion_r299839029 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r299864252 ## File path:

[jira] [Updated] (FLINK-13067) Fix broken links to contributing docs

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13067: --- Labels: pull-request-available (was: ) > Fix broken links to contributing docs >

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r299864252 ## File path:

[GitHub] [flink] Myasuka opened a new pull request #8964: [FLINK-13067][docs] Fix broken links to contributing docs

2019-07-03 Thread GitBox
Myasuka opened a new pull request #8964: [FLINK-13067][docs] Fix broken links to contributing docs URL: https://github.com/apache/flink/pull/8964 ## What is the purpose of the change Fix broken links to contributing docs ## Brief change log Fix broken links to

[GitHub] [flink] flinkbot commented on issue #8963: [FLINK-13016][network] Fix StreamTaskNetworkInput#isAvailable

2019-07-03 Thread GitBox
flinkbot commented on issue #8963: [FLINK-13016][network] Fix StreamTaskNetworkInput#isAvailable URL: https://github.com/apache/flink/pull/8963#issuecomment-508018355 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] lirui-apache opened a new pull request #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable…

2019-07-03 Thread GitBox
lirui-apache opened a new pull request #8965: [FLINK-13068][hive] HiveTableSink should implement PartitionableTable… URL: https://github.com/apache/flink/pull/8965 …Sink ## What is the purpose of the change Make `HiveTableSink` implement `PartitionableTableSink`, so

[jira] [Updated] (FLINK-13060) FailoverStrategies should respect restart constraints

2019-07-03 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-13060: - Description: RestartStrategies can define their own restrictions for whether job can be

[GitHub] [flink] flinkbot commented on issue #8966: [FLINK-13074] Add PartitionableTableSink bridge logic to flink …

2019-07-03 Thread GitBox
flinkbot commented on issue #8966: [FLINK-13074] Add PartitionableTableSink bridge logic to flink … URL: https://github.com/apache/flink/pull/8966#issuecomment-508038633 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877737#comment-16877737 ] zhijiang commented on FLINK-12852: -- It is hardly to say whether we could get performance benefits via 

[GitHub] [flink] R-CodeBoy commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
R-CodeBoy commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r299791955 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the

[GitHub] [flink] flinkbot edited a comment on issue #8719: [FLINK-12767][python] Support user defined connectors/format

2019-07-03 Thread GitBox
flinkbot edited a comment on issue #8719: [FLINK-12767][python] Support user defined connectors/format URL: https://github.com/apache/flink/pull/8719#issuecomment-501548801 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Commented] (FLINK-13073) BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread Louis Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877633#comment-16877633 ] Louis Xu commented on FLINK-13073: -- You are welcome. I am looking forward to contributing more to

[jira] [Updated] (FLINK-13068) HiveTableSink should implement PartitionableTableSink

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13068: --- Labels: pull-request-available (was: ) > HiveTableSink should implement

[jira] [Updated] (FLINK-13068) HiveTableSink should implement PartitionableTableSink

2019-07-03 Thread Rui Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Li updated FLINK-13068: --- Component/s: Connectors / Hive > HiveTableSink should implement PartitionableTableSink >

[GitHub] [flink] asfgit closed pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge

2019-07-03 Thread GitBox
asfgit closed pull request #8872: [FLINK-12977][table]Port CsvTableSource to api-java-bridge URL: https://github.com/apache/flink/pull/8872 This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-13078) Add a type parser utility

2019-07-03 Thread Timo Walther (JIRA)
Timo Walther created FLINK-13078: Summary: Add a type parser utility Key: FLINK-13078 URL: https://issues.apache.org/jira/browse/FLINK-13078 Project: Flink Issue Type: Sub-task

[GitHub] [flink] pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox

2019-07-03 Thread GitBox
pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox URL: https://github.com/apache/flink/pull/8826#discussion_r299882387 ## File path:

[jira] [Comment Edited] (FLINK-13079) Make window state queryable

2019-07-03 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877734#comment-16877734 ] vinoyang edited comment on FLINK-13079 at 7/3/19 10:43 AM: --- [~aljoscha] WDYT?

[GitHub] [flink] klion26 commented on issue #8954: [FLINK-13065][doc] Corrected example snippet using KeySelector

2019-07-03 Thread GitBox
klion26 commented on issue #8954: [FLINK-13065][doc] Corrected example snippet using KeySelector URL: https://github.com/apache/flink/pull/8954#issuecomment-507951159 thanks for the contribution, LGTM This is an automated

[jira] [Comment Edited] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877556#comment-16877556 ] Yun Gao edited comment on FLINK-12852 at 7/3/19 7:22 AM: - Hi all, very thanks

[GitHub] [flink] StefanRRichter closed pull request #8853: [FLINK-12958] Integrate AsyncWaitOperator with mailbox

2019-07-03 Thread GitBox
StefanRRichter closed pull request #8853: [FLINK-12958] Integrate AsyncWaitOperator with mailbox URL: https://github.com/apache/flink/pull/8853 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] zhijiangW commented on issue #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-07-03 Thread GitBox
zhijiangW commented on issue #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#issuecomment-508000477 Thanks for opening this PR @Xpray ! Just quickly looked through the codes, the new

[GitHub] [flink] GJL commented on issue #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on issue #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#issuecomment-508012371 rebased to master This is an automated

[GitHub] [flink] pnowojski commented on issue #8621: [FLINK-12682][connectors] StringWriter support custom row delimiter

2019-07-03 Thread GitBox
pnowojski commented on issue #8621: [FLINK-12682][connectors] StringWriter support custom row delimiter URL: https://github.com/apache/flink/pull/8621#issuecomment-508026384 I agree with @StephanEwen. If we want to have this optimisation of avoiding the serialisation multiple times, it

[jira] [Updated] (FLINK-13073) BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread Louis Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Louis Xu updated FLINK-13073: - Description: BinaryRow which in blink runtime module has static constant named  FIRST_BYTE_ZERO, it's

[GitHub] [flink] mchro opened a new pull request #8967: [FLINK-13059][Cassandra Connector] Release Semaphore correctly on Exception in send()

2019-07-03 Thread GitBox
mchro opened a new pull request #8967: [FLINK-13059][Cassandra Connector] Release Semaphore correctly on Exception in send() URL: https://github.com/apache/flink/pull/8967 ## What is the purpose of the change Release the MaxConcurrentRequests Semaphore correctly, if an exception

[jira] [Updated] (FLINK-13059) Cassandra Connector leaks Semaphore on Exception; hangs on close

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13059: --- Labels: pull-request-available (was: ) > Cassandra Connector leaks Semaphore on Exception;

[GitHub] [flink] flinkbot commented on issue #8967: [FLINK-13059][Cassandra Connector] Release Semaphore correctly on Exception in send()

2019-07-03 Thread GitBox
flinkbot commented on issue #8967: [FLINK-13059][Cassandra Connector] Release Semaphore correctly on Exception in send() URL: https://github.com/apache/flink/pull/8967#issuecomment-508044485 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[jira] [Created] (FLINK-13073) BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread Louis Xu (JIRA)
Louis Xu created FLINK-13073: Summary: BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask Key: FLINK-13073 URL: https://issues.apache.org/jira/browse/FLINK-13073 Project: Flink Issue

[jira] [Created] (FLINK-13074) Add PartitionableTableSink bridge logic to blink planner

2019-07-03 Thread Danny Chan (JIRA)
Danny Chan created FLINK-13074: -- Summary: Add PartitionableTableSink bridge logic to blink planner Key: FLINK-13074 URL: https://issues.apache.org/jira/browse/FLINK-13074 Project: Flink Issue

[jira] [Commented] (FLINK-13072) RocksDBStateBachend is not thread safe and data loss silently

2019-07-03 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877586#comment-16877586 ] Yun Tang commented on FLINK-13072: -- [~zicat] After a quick look, I believe this is not a

[jira] [Created] (FLINK-13075) Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner

2019-07-03 Thread Jark Wu (JIRA)
Jark Wu created FLINK-13075: --- Summary: Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner Key: FLINK-13075 URL: https://issues.apache.org/jira/browse/FLINK-13075

[jira] [Created] (FLINK-13076) Bump Calcite dependency to 1.20.0 in blink planner

2019-07-03 Thread godfrey he (JIRA)
godfrey he created FLINK-13076: -- Summary: Bump Calcite dependency to 1.20.0 in blink planner Key: FLINK-13076 URL: https://issues.apache.org/jira/browse/FLINK-13076 Project: Flink Issue Type:

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877605#comment-16877605 ] zhijiang commented on FLINK-12852: -- The spill way could solve the deadlock issue in function, which is

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r299832097 ## File path:

[GitHub] [flink] dawidwys commented on issue #8953: [hotfix][table] rename defaultCatalog and defaultDatabase to currentCatalog and currentDatabase, to be consistent with namings

2019-07-03 Thread GitBox
dawidwys commented on issue #8953: [hotfix][table] rename defaultCatalog and defaultDatabase to currentCatalog and currentDatabase, to be consistent with namings URL: https://github.com/apache/flink/pull/8953#issuecomment-507997395 Personally I am against this change. Those field do not

[GitHub] [flink] R-CodeBoy commented on issue #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
R-CodeBoy commented on issue #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#issuecomment-508001359 @klion26 Hi,I just accept you suggestion and find that the travis-ci do not pass. is there any problem?thanks

[GitHub] [flink] JingsongLi commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

2019-07-03 Thread GitBox
JingsongLi commented on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC URL: https://github.com/apache/flink/pull/8867#issuecomment-508002153 Code Updated @wuchong This is an automated message from the

[jira] [Updated] (FLINK-13072) RocksDBStateBachend is not thread safe and data loss silently

2019-07-03 Thread lynn1.zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lynn1.zhang updated FLINK-13072: Attachment: image-2019-07-03-17-04-17-253.png > RocksDBStateBachend is not thread safe and data

[jira] [Commented] (FLINK-13072) RocksDBStateBachend is not thread safe and data loss silently

2019-07-03 Thread lynn1.zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877657#comment-16877657 ] lynn1.zhang commented on FLINK-13072: - I think we can modify the document 

[jira] [Updated] (FLINK-13076) Bump Calcite dependency to 1.20.0 in blink planner

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13076: --- Labels: pull-request-available (was: ) > Bump Calcite dependency to 1.20.0 in blink

[GitHub] [flink] aljoscha commented on issue #8951: [FLINK-13062] Set ScheduleMode based on boundedness of streaming Pipeline

2019-07-03 Thread GitBox
aljoscha commented on issue #8951: [FLINK-13062] Set ScheduleMode based on boundedness of streaming Pipeline URL: https://github.com/apache/flink/pull/8951#issuecomment-508008749 Another alternative would be to set the `ScheduleMode` based on the `ExecutionMode`, which is already

[jira] [Updated] (FLINK-13016) StreamTaskNetworkInput can linger records for longer period of times

2019-07-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13016: --- Labels: pull-request-available (was: ) > StreamTaskNetworkInput can linger records for

[GitHub] [flink] pnowojski opened a new pull request #8963: [FLINK-13016][network] Fix StreamTaskNetworkInput#isAvailable

2019-07-03 Thread GitBox
pnowojski opened a new pull request #8963: [FLINK-13016][network] Fix StreamTaskNetworkInput#isAvailable URL: https://github.com/apache/flink/pull/8963 This PR introduces two changes: [FLINK-13016][network] Fix StreamTaskNetworkInput#isAvailable [FLINK-13013][network] Request

[GitHub] [flink] AjaxXu commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread GitBox
AjaxXu commented on issue #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask URL: https://github.com/apache/flink/pull/8961#issuecomment-508027875 > LGTM. > > Merging Sorry for this pr, I have found a new bug with 0xFFF0,

[GitHub] [flink] pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox

2019-07-03 Thread GitBox
pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox URL: https://github.com/apache/flink/pull/8826#discussion_r299880631 ## File path:

[jira] [Commented] (FLINK-13079) Make window state queryable

2019-07-03 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877734#comment-16877734 ] vinoyang commented on FLINK-13079: -- [~aljoscha] WDYT? > Make window state queryable >

[jira] [Created] (FLINK-13079) Make window state queryable

2019-07-03 Thread vinoyang (JIRA)
vinoyang created FLINK-13079: Summary: Make window state queryable Key: FLINK-13079 URL: https://issues.apache.org/jira/browse/FLINK-13079 Project: Flink Issue Type: Improvement

[GitHub] [flink] JingsongLi commented on a change in pull request #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread GitBox
JingsongLi commented on a change in pull request #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask URL: https://github.com/apache/flink/pull/8961#discussion_r299890623 ## File path:

[GitHub] [flink] R-CodeBoy commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
R-CodeBoy commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r299787675 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the

[GitHub] [flink] KurtYoung commented on a change in pull request #8959: [FLINK-13070][table-planner-blink] Remove TableImpl and use api.internal.TableImpl in blink

2019-07-03 Thread GitBox
KurtYoung commented on a change in pull request #8959: [FLINK-13070][table-planner-blink] Remove TableImpl and use api.internal.TableImpl in blink URL: https://github.com/apache/flink/pull/8959#discussion_r299795262 ## File path:

[jira] [Commented] (FLINK-12852) Deadlock occurs when requiring exclusive buffer for RemoteInputChannel

2019-07-03 Thread Guowei Ma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877524#comment-16877524 ] Guowei Ma commented on FLINK-12852: --- In long run there may be another way to avoid the dead lock. Task

[GitHub] [flink] AjaxXu commented on a change in pull request #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread GitBox
AjaxXu commented on a change in pull request #8961: [FLINK-13073][table-blink-runtime]BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask URL: https://github.com/apache/flink/pull/8961#discussion_r299810579 ## File path:

[jira] [Commented] (FLINK-13072) RocksDBStateBachend is not thread safe and data loss silently

2019-07-03 Thread lynn1.zhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877608#comment-16877608 ] lynn1.zhang commented on FLINK-13072: - from beginning, I also think the {{input.iterator()}} is not

[jira] [Commented] (FLINK-12833) Add Klaviyo to Chinese PoweredBy page

2019-07-03 Thread yelun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877609#comment-16877609 ] yelun commented on FLINK-12833: --- Hi [~jark],I did not find the poweredby.md,is there some page like 

[jira] [Closed] (FLINK-13070) Remove TableImpl and use api.internal.TableImpl in blink

2019-07-03 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-13070. -- Resolution: Fixed Fix Version/s: 1.9.0 merged in 1.9.0:

[GitHub] [flink] zhijiangW removed a comment on issue #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client

2019-07-03 Thread GitBox
zhijiangW removed a comment on issue #8756: [FLINK-12406] [Runtime] Report BLOCKING_PERSISTENT result partition meta back to client URL: https://github.com/apache/flink/pull/8756#issuecomment-508000477 Thanks for opening this PR @Xpray ! Just quickly looked through the codes, the

[GitHub] [flink] knaufk commented on a change in pull request #8957: [hotfix][docs] fix broken links

2019-07-03 Thread GitBox
knaufk commented on a change in pull request #8957: [hotfix][docs] fix broken links URL: https://github.com/apache/flink/pull/8957#discussion_r299849905 ## File path: docs/dev/libs/state_processor_api.zh.md ## @@ -0,0 +1,330 @@ +--- Review comment: I think, you

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r299850017 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r299850228 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler

2019-07-03 Thread GitBox
GJL commented on a change in pull request #8922: [FLINK-12876][runtime] Add an adapter of region failover NG for legacy scheduler URL: https://github.com/apache/flink/pull/8922#discussion_r299850087 ## File path:

[GitHub] [flink] sunjincheng121 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations

2019-07-03 Thread GitBox
sunjincheng121 commented on issue #8926: [FLINK-13021][table][hive] unify catalog partition implementations URL: https://github.com/apache/flink/pull/8926#issuecomment-508012508 @bowenli86 please wait the CI passed when merging the PR! This commit caused the CI failed as the

[GitHub] [flink] StephanEwen commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary

2019-07-03 Thread GitBox
StephanEwen commented on a change in pull request #8607: [FLINK-12652] [documentation] add first version of a glossary URL: https://github.com/apache/flink/pull/8607#discussion_r299866696 ## File path: docs/concepts/glossary.md ## @@ -0,0 +1,167 @@ +--- +title: Glossary

[jira] [Commented] (FLINK-13075) Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner

2019-07-03 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877696#comment-16877696 ] Jark Wu commented on FLINK-13075: - Please open test

[jira] [Assigned] (FLINK-13075) Project pushdown rule shouldn't require the TableSource return a modified schema in blink planner

2019-07-03 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13075: --- Assignee: godfrey he > Project pushdown rule shouldn't require the TableSource return a modified

[GitHub] [flink] mans2singh commented on issue #8839: [FLINK-12952][docs] Minor doc correction to incremental window functions

2019-07-03 Thread GitBox
mans2singh commented on issue #8839: [FLINK-12952][docs] Minor doc correction to incremental window functions URL: https://github.com/apache/flink/pull/8839#issuecomment-508025672 @klion26 @rmetzger - Do you have any thoughts on this doc correction ? Thanks

[GitHub] [flink] pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox

2019-07-03 Thread GitBox
pnowojski commented on a change in pull request #8826: [FLINK-12479][operators] Integrate StreamInputProcessor(s) with mailbox URL: https://github.com/apache/flink/pull/8826#discussion_r299877889 ## File path:

[jira] [Commented] (FLINK-13073) BinaryRow in Blink runtime has wrong FIRST_BYTE_ZERO mask

2019-07-03 Thread Louis Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877732#comment-16877732 ] Louis Xu commented on FLINK-13073: -- [~jark] [~lzljs3620320] [~ykt836] I find some problem when I review

[GitHub] [flink] klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese

2019-07-03 Thread GitBox
klion26 commented on a change in pull request #8943: [FLINK-11637][doc-zh]Translate Checkpoints page into Chinese URL: https://github.com/apache/flink/pull/8943#discussion_r299794529 ## File path: docs/ops/state/checkpoints.zh.md ## @@ -26,69 +26,49 @@ under the License.

  1   2   3   4   5   6   >