flinkbot commented on pull request #17560:
URL: https://github.com/apache/flink/pull/17560#issuecomment-951002521
## CI report:
* 1e594013c3d2aaf43c3a537cd0f1dff033b3ef4f UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure:
infoverload commented on a change in pull request #476:
URL: https://github.com/apache/flink-web/pull/476#discussion_r735674314
##
File path: _posts/2021-10-15-sort-shuffle-part1.md
##
@@ -0,0 +1,224 @@
+---
+layout: post
+title: "Sort-Based Blocking Shuffle Implementation in
fapaul commented on a change in pull request #17539:
URL: https://github.com/apache/flink/pull/17539#discussion_r735674263
##
File path:
flink-connectors/flink-connector-kafka/src/test/resources/log4j2-test.properties
##
@@ -18,7 +18,7 @@
# Set root logger level to OFF to
[
https://issues.apache.org/jira/browse/FLINK-22315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-22315:
---
Labels: pull-request-available (was: )
> Support ADD column/constraint/watermark for ALTER
fapaul commented on a change in pull request #17539:
URL: https://github.com/apache/flink/pull/17539#discussion_r735674093
##
File path:
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaUtil.java
##
@@ -43,6 +45,46 @@
RocMarshal opened a new pull request #17560:
URL: https://github.com/apache/flink/pull/17560
## What is the purpose of the change
*(For example: This pull request makes task deployment go through the blob
server, rather than through RPC. That way we avoid re-transferring
alpreu commented on a change in pull request #17538:
URL: https://github.com/apache/flink/pull/17538#discussion_r735672210
##
File path:
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure:
infoverload commented on a change in pull request #476:
URL: https://github.com/apache/flink-web/pull/476#discussion_r735670720
##
File path: _posts/2021-10-15-sort-shuffle-part1.md
##
@@ -0,0 +1,224 @@
+---
+layout: post
+title: "Sort-Based Blocking Shuffle Implementation in
akalash commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735666888
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferSizeEMA.java
##
@@ -0,0 +1,58 @@
+/*
+ *
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
pnowojski commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735657956
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloater.java
##
@@ -94,10 +97,10 @@
pnowojski commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735657956
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloater.java
##
@@ -94,10 +97,10 @@
flinkbot edited a comment on pull request #17550:
URL: https://github.com/apache/flink/pull/17550#issuecomment-949779530
## CI report:
* 66c9ead84d9309bce59c77d12a913bd3471edec1 Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
[
https://issues.apache.org/jira/browse/FLINK-24597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433794#comment-17433794
]
Roman Khachatryan commented on FLINK-24597:
---
Thanks for pulling me in [~mayuehappy], I think
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
akalash commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735646141
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloater.java
##
@@ -94,10 +97,10 @@
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17374:
URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201
## CI report:
* dfc6d981a6aee5cbc50dfd2b55b0a9fe58ceb555 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
Airblader commented on a change in pull request #17549:
URL: https://github.com/apache/flink/pull/17549#discussion_r735637141
##
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java
##
@@ -0,0
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
[
https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433774#comment-17433774
]
Piotr Nowojski edited comment on FLINK-24384 at 10/25/21, 2:00 PM:
---
[
https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433774#comment-17433774
]
Piotr Nowojski commented on FLINK-24384:
Ohh, thanks for the explanation [~Feifan Wang]. Now I
[
https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski updated FLINK-24384:
---
Component/s: Runtime / Metrics
> Count checkpoints failed in trigger phase into
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
twalthr commented on a change in pull request #17549:
URL: https://github.com/apache/flink/pull/17549#discussion_r735621787
##
File path:
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/BuiltInAggregateFunctionTestBase.java
##
@@ -0,0
[
https://issues.apache.org/jira/browse/FLINK-24384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Nowojski updated FLINK-24384:
---
Affects Version/s: 1.14.1
> Count checkpoints failed in trigger phase into
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
alpreu commented on a change in pull request #17538:
URL: https://github.com/apache/flink/pull/17538#discussion_r735621610
##
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17542:
URL: https://github.com/apache/flink/pull/17542#issuecomment-949170131
## CI report:
* 9b11c30444ab1519ade5b7572a36d426739fc672 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735605118
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/utils/LogicalTypeCasts.java
##
@@ -500,8 +497,7 @@
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17542:
URL: https://github.com/apache/flink/pull/17542#issuecomment-949170131
## CI report:
* 9b11c30444ab1519ade5b7572a36d426739fc672 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* 28a3bcb44f4d8a33896b77c6927290b13bda13bd Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* bffd142aa4e8aa6bc598f1a39c9c7ebfeedbd184 Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735604158
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##
@@ -77,6 +77,33 @@ public
meetjunsu commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r735603570
##
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##
@@ -126,13 +134,27 @@
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
meetjunsu commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r735603151
##
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##
@@ -141,6 +163,11 @@ private
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* bffd142aa4e8aa6bc598f1a39c9c7ebfeedbd184 Azure:
Airblader commented on a change in pull request #17549:
URL: https://github.com/apache/flink/pull/17549#discussion_r735600154
##
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlJsonUtils.java
##
@@ -58,7 +61,11 @@ public
flinkbot edited a comment on pull request #17556:
URL: https://github.com/apache/flink/pull/17556#issuecomment-950605426
## CI report:
* 974ba5b8300fcb03b38a4762f50f246597ce7e92 Azure:
flinkbot edited a comment on pull request #17538:
URL: https://github.com/apache/flink/pull/17538#issuecomment-948574914
## CI report:
* bffd142aa4e8aa6bc598f1a39c9c7ebfeedbd184 Azure:
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
twalthr commented on a change in pull request #17550:
URL: https://github.com/apache/flink/pull/17550#discussion_r735597583
##
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/logical/LogicalType.java
##
@@ -77,6 +77,33 @@ public
Airblader commented on a change in pull request #17549:
URL: https://github.com/apache/flink/pull/17549#discussion_r734689757
##
File path:
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlJsonUtils.java
##
@@ -58,7 +61,9 @@ public
alpreu commented on a change in pull request #17538:
URL: https://github.com/apache/flink/pull/17538#discussion_r735595928
##
File path:
flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java
flinkbot edited a comment on pull request #17549:
URL: https://github.com/apache/flink/pull/17549#issuecomment-949678124
## CI report:
* 39d5c4b60c6a071c06e8c6b46970c3202841bf65 Azure:
flinkbot edited a comment on pull request #17557:
URL: https://github.com/apache/flink/pull/17557#issuecomment-950730253
## CI report:
* 5832bbee1c111c463db26e53e2a09347d02814e1 Azure:
[
https://issues.apache.org/jira/browse/FLINK-24500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timo Walther closed FLINK-24500.
Fix Version/s: 1.15.0
Resolution: Fixed
Fixed in master:
twalthr closed pull request #17454:
URL: https://github.com/apache/flink/pull/17454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Aitozi created FLINK-24633:
--
Summary: JobManager pod may stuck in containerCreating status
during failover
Key: FLINK-24633
URL: https://issues.apache.org/jira/browse/FLINK-24633
Project: Flink
snuyanzin commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r735578442
##
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##
@@ -141,6 +163,11 @@ private
snuyanzin commented on a change in pull request #17542:
URL: https://github.com/apache/flink/pull/17542#discussion_r735575324
##
File path:
flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriter.java
##
@@ -126,13 +134,27 @@
[
https://issues.apache.org/jira/browse/FLINK-24294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433746#comment-17433746
]
Piotr Nowojski commented on FLINK-24294:
I also had something like guava's {{Closer}} or our
snuyanzin commented on a change in pull request #17556:
URL: https://github.com/apache/flink/pull/17556#discussion_r735569642
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterExtension.java
##
@@ -0,0 +1,215 @@
+/*
+ * Licensed to the
xuyang created FLINK-24632:
--
Summary: "where ... in(..)" has wrong result
Key: FLINK-24632
URL: https://issues.apache.org/jira/browse/FLINK-24632
Project: Flink
Issue Type: Bug
snuyanzin commented on a change in pull request #17533:
URL: https://github.com/apache/flink/pull/17533#discussion_r735554131
##
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/TaskExecutorProcessUtils.java
##
@@ -128,7 +128,10 @@ public
pnowojski commented on a change in pull request #17473:
URL: https://github.com/apache/flink/pull/17473#discussion_r735539660
##
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloater.java
##
@@ -94,10 +97,10 @@
flinkbot edited a comment on pull request #17556:
URL: https://github.com/apache/flink/pull/17556#issuecomment-950605426
## CI report:
* ce08ce642324fbefc3b0855111d6ec298a68c0b3 Azure:
flinkbot edited a comment on pull request #17559:
URL: https://github.com/apache/flink/pull/17559#issuecomment-950868488
## CI report:
* 2214d852ab3eca0c3250b20e7964d9adaa3a5660 Azure:
akalash commented on a change in pull request #17559:
URL: https://github.com/apache/flink/pull/17559#discussion_r735544012
##
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##
@@ -1133,23 +1133,27 @@ public
flinkbot commented on pull request #17559:
URL: https://github.com/apache/flink/pull/17559#issuecomment-950868732
Thanks a lot for your contribution to the Apache Flink project. I'm the
@flinkbot. I help the community
to review your pull request. We will use this comment to track the
flinkbot commented on pull request #17559:
URL: https://github.com/apache/flink/pull/17559#issuecomment-950868488
## CI report:
* 2214d852ab3eca0c3250b20e7964d9adaa3a5660 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot
[
https://issues.apache.org/jira/browse/FLINK-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-15550:
---
Labels: pull-request-available (was: )
> testCancelTaskExceptionAfterTaskMarkedFailed
akalash opened a new pull request #17559:
URL: https://github.com/apache/flink/pull/17559
…skExceptionAfterTaskMarkedFailed
## What is the purpose of the change
*This PR fixes test but I suppose it doesn't fix the reason*
## Brief change log
-
[
https://issues.apache.org/jira/browse/FLINK-24539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433717#comment-17433717
]
Piotr Nowojski commented on FLINK-24539:
{quote}
(I presume it's busy recovering it's state,
curcur closed pull request #17558:
URL: https://github.com/apache/flink/pull/17558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
curcur commented on pull request #17558:
URL: https://github.com/apache/flink/pull/17558#issuecomment-950846726
Let's keep it as it as, and I will squash on CL next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
flinkbot edited a comment on pull request #17374:
URL: https://github.com/apache/flink/pull/17374#issuecomment-929172201
## CI report:
* 1cbbf84c0bcaa8ea21a8f1d589b1733d7ddced94 Azure:
[
https://issues.apache.org/jira/browse/FLINK-24381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17433707#comment-17433707
]
Jark Wu commented on FLINK-24381:
-
I think {{isSecret}} is useful for extension than hardcode way.
201 - 300 of 403 matches
Mail list logo