[jira] [Commented] (FLINK-8276) Annotation for Kafka connector

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317912#comment-16317912 ] ASF GitHub Bot commented on FLINK-8276: --- Github user zhangminglei commented on the i

[GitHub] flink issue #5173: [FLINK-8276] [kafka connector] Properly annotate API for ...

2018-01-08 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/5173 Thanks @pnowojski. ---

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2018-01-08 Thread Sihua Zhou (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317829#comment-16317829 ] Sihua Zhou commented on FLINK-3089: --- [~phoenixjiangnan] Maybe we shouldn't enforce TtlDB

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2018-01-08 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317800#comment-16317800 ] Bowen Li commented on FLINK-3089: - [~srichter] [~aljoscha] guys, I want to follow up on th

[jira] [Commented] (FLINK-8302) Support shift_left and shift_right in TableAPI

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317730#comment-16317730 ] ASF GitHub Bot commented on FLINK-8302: --- Github user dubin555 commented on the issue

[GitHub] flink issue #5202: [FLINK-8302][table]Add SHIFT_LEFT and SHIFT_RIGHT support...

2018-01-08 Thread dubin555
Github user dubin555 commented on the issue: https://github.com/apache/flink/pull/5202 Hi @sunjincheng121 , thanks for the overall review of my code. I've done some typo fix and add some test case base on your comment. Really appreciate for your careful review! Du Bin ---

[jira] [Updated] (FLINK-7775) Remove unreferenced method PermanentBlobCache#getNumberOfCachedJobs

2018-01-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7775: -- Description: {code} public int getNumberOfCachedJobs() { return jobRefCounters.size(); } {code} The met

[jira] [Assigned] (FLINK-8369) Port SubtaskExecutionAttemptAccumulatorsHandler to new REST endpoint

2018-01-08 Thread Biao Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Liu reassigned FLINK-8369: --- Assignee: Biao Liu > Port SubtaskExecutionAttemptAccumulatorsHandler to new REST endpoint > -

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317529#comment-16317529 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2018-01-08 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 Already close it ---

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2018-01-08 Thread zhijiangW
Github user zhijiangW closed the pull request at: https://github.com/apache/flink/pull/4509 ---

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317530#comment-16317530 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW closed the pull reque

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2018-01-08 Thread zhijiangW
Github user zhijiangW closed the pull request at: https://github.com/apache/flink/pull/4533 ---

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317516#comment-16317516 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW closed the pull reque

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317515#comment-16317515 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on the issu

[GitHub] flink issue #4533: [FLINK-7416][network] Implement Netty receiver outgoing p...

2018-01-08 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4533 Sure, I close it. ---

[jira] [Commented] (FLINK-8381) Document more flexible schema definition

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317262#comment-16317262 ] ASF GitHub Bot commented on FLINK-8381: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5257: [FLINK-8381] [table] Document more flexible schema...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5257#discussion_r160275286 --- Diff: docs/dev/table/common.md --- @@ -802,7 +802,87 @@ val dsTuple: DataSet[(String, Int)] = tableEnv.toDataSet[(String, Int)](table) ### Map

[jira] [Commented] (FLINK-8381) Document more flexible schema definition

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317263#comment-16317263 ] ASF GitHub Bot commented on FLINK-8381: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8381) Document more flexible schema definition

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317264#comment-16317264 ] ASF GitHub Bot commented on FLINK-8381: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5257: [FLINK-8381] [table] Document more flexible schema...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5257#discussion_r160274966 --- Diff: docs/dev/table/common.md --- @@ -802,7 +802,87 @@ val dsTuple: DataSet[(String, Int)] = tableEnv.toDataSet[(String, Int)](table) ### Map

[GitHub] flink pull request #5257: [FLINK-8381] [table] Document more flexible schema...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5257#discussion_r160275240 --- Diff: docs/dev/table/common.md --- @@ -802,7 +802,87 @@ val dsTuple: DataSet[(String, Int)] = tableEnv.toDataSet[(String, Int)](table) ### Map

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317225#comment-16317225 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317218#comment-16317218 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317220#comment-16317220 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317223#comment-16317223 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317217#comment-16317217 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317228#comment-16317228 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317230#comment-16317230 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317233#comment-16317233 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317224#comment-16317224 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317234#comment-16317234 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317227#comment-16317227 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317231#comment-16317231 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317221#comment-16317221 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317219#comment-16317219 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317232#comment-16317232 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317229#comment-16317229 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317222#comment-16317222 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317226#comment-16317226 ] ASF GitHub Bot commented on FLINK-8325: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160253551 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -383,12 +388,16 @@ class Aggregati

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160255960 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggfunctions/AggFunctionTestBase.scala --- @@ -146,14 +146,31 @@ abstrac

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160267929 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -145,6 +145,14 @@ cla

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160250581 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -139,7 +139,7 @@ class Aggregation

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160257426 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala --- @@ -254,7 +254,7 @@ class JoinITCase(

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160260174 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/GroupWindowITCase.scala --- @@ -0,0 +1,122 @@ +/* + *

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160259534 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala --- @@ -278,7 +278,14 @@ class SetOpe

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160255883 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggfunctions/AggFunctionTestBase.scala --- @@ -146,14 +146,31 @@ abstrac

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160268630 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1130,259 +1134,263 @@ object Aggre

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160250423 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -121,7 +121,7 @@ class Aggregation

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160253454 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -359,12 +359,17 @@ class Aggregati

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160260046 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/GroupWindowITCase.scala --- @@ -0,0 +1,122 @@ +/* + *

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160268601 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1130,259 +1134,263 @@ object Aggre

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160250511 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala --- @@ -121,7 +121,7 @@ class Aggregation

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160251387 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CountAggFunction.scala --- @@ -33,7 +33,20 @@ class Count

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160271966 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -1130,259 +1134,263 @@ object Aggre

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160251401 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/CountAggFunction.scala --- @@ -33,7 +33,20 @@ class Count

[GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...

2018-01-08 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5241#discussion_r160265977 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -145,6 +145,14 @@ cla

[jira] [Comment Edited] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-08 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317067#comment-16317067 ] Shuyi Chen edited comment on FLINK-8275 at 1/8/18 10:00 PM: Hi

[jira] [Commented] (FLINK-8320) Flink cluster does not work on Java 9

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317126#comment-16317126 ] Chesnay Schepler commented on FLINK-8320: - docs adjusted for 1.4 in 6f50ed256a8a2c

[jira] [Closed] (FLINK-8200) RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8200. --- Resolution: Fixed Fix Version/s: 1.4.1 1.4: 78e3405becb13ec74d6edd4624727f7fd40fea07 >

[jira] [Updated] (FLINK-8390) Refactor Hadoop kerberos integration test code

2018-01-08 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen updated FLINK-8390: -- Description: As suggested in [Flink-8270| https://issues.apache.org/jira/browse/FLINK-8270] and [Flink-

[jira] [Created] (FLINK-8390) Refactor Hadoop kerberos integration test code

2018-01-08 Thread Shuyi Chen (JIRA)
Shuyi Chen created FLINK-8390: - Summary: Refactor Hadoop kerberos integration test code Key: FLINK-8390 URL: https://issues.apache.org/jira/browse/FLINK-8390 Project: Flink Issue Type: Bug

[jira] [Comment Edited] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-08 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317067#comment-16317067 ] Shuyi Chen edited comment on FLINK-8275 at 1/8/18 9:12 PM: --- Hi,

[jira] [Commented] (FLINK-8275) Flink YARN deployment with Kerberos enabled not working

2018-01-08 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317067#comment-16317067 ] Shuyi Chen commented on FLINK-8275: --- [~tzulitai], [~eronwright], I've added unittest to

[jira] [Commented] (FLINK-7797) Add support for windowed outer joins for streaming tables

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316873#comment-16316873 ] ASF GitHub Bot commented on FLINK-7797: --- Github user fhueske commented on the issue:

[GitHub] flink issue #5140: [FLINK-7797] [table] Add support for windowed outer joins...

2018-01-08 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5140 Thanks for the update and excellent work. PR is good to merge :-) ---

[jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316860#comment-16316860 ] ASF GitHub Bot commented on FLINK-7511: --- Github user dawidwys commented on the issue

[GitHub] flink issue #4587: [FLINK-7511] [cep] Remove dead code after dropping backwa...

2018-01-08 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4587 @pnowojski I've updated the PR, will be grateful for your review, thx! ---

[jira] [Updated] (FLINK-8383) flink-mesos build failing: duplicate Jackson relocation in shaded jar

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8383: Affects Version/s: 1.5.0 > flink-mesos build failing: duplicate Jackson relocation in shaded

[jira] [Commented] (FLINK-8383) flink-mesos build failing: duplicate Jackson relocation in shaded jar

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316840#comment-16316840 ] Chesnay Schepler commented on FLINK-8383: - Band-aid merged to master in 7c2a32c286

[jira] [Updated] (FLINK-8383) flink-mesos build failing: duplicate Jackson relocation in shaded jar

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8383: Fix Version/s: 1.5.0 > flink-mesos build failing: duplicate Jackson relocation in shaded jar

[jira] [Closed] (FLINK-8292) Remove unnecessary force cast in DataStreamSource

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8292. --- Resolution: Fixed Fix Version/s: (was: 1.4.1) master: 3cdc5d1dce7c8cf0db0352d86867f

[jira] [Commented] (FLINK-8388) Snapshot documentation redirects to 1.4

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316834#comment-16316834 ] ASF GitHub Bot commented on FLINK-8388: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8250) Remove RecordSerializer#instantiateMetrics

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316832#comment-16316832 ] ASF GitHub Bot commented on FLINK-8250: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5263: [FLINK-8388][docs] Fix baseUrl for master branch

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5263 ---

[GitHub] flink pull request #5258: [FLINK-8383][mesos] Disable test-jar shading

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5258 ---

[jira] [Commented] (FLINK-8383) flink-mesos build failing: duplicate Jackson relocation in shaded jar

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316833#comment-16316833 ] ASF GitHub Bot commented on FLINK-8383: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8320) Flink cluster does not work on Java 9

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316826#comment-16316826 ] Chesnay Schepler commented on FLINK-8320: - docs adjusted for master in 1ef1f321192

[jira] [Closed] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8280. --- Resolution: Fixed Fix Version/s: 1.5.0 master: 50301254182283433d52b5359b1afa6093d0514b

[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316831#comment-16316831 ] ASF GitHub Bot commented on FLINK-8280: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-8200) RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316828#comment-16316828 ] Chesnay Schepler commented on FLINK-8200: - master: 4ac348d1fa539d64ce9317035716243

[jira] [Closed] (FLINK-8250) Remove RecordSerializer#instantiateMetrics

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8250. --- Resolution: Fixed master: 10aae991833447506e8e8231c32fb9f816920597 > Remove RecordSerializer#

[jira] [Updated] (FLINK-8200) RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-8200: Fix Version/s: 1.5.0 > RocksDBAsyncSnapshotTest should use temp fold instead of fold with fi

[GitHub] flink pull request #5213: [Minor][docs][metrics] Fix typo of metrics docs

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5213 ---

[GitHub] flink pull request #5175: [FLINK-8280][checkstyle] fix checkstyle in BlobSer...

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5175 ---

[GitHub] flink pull request #5162: [FLINK-8250][runtime] Remove unused RecordSerializ...

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5162 ---

[GitHub] flink pull request #5249: [hotfix] [docs] Fix Iterations documentation in da...

2018-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5249 ---

[jira] [Closed] (FLINK-8388) Snapshot documentation redirects to 1.4

2018-01-08 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-8388. --- Resolution: Fixed master: f16335d427592007a5b242a1b4b0cfcd5bd36858 > Snapshot documentation r

[jira] [Commented] (FLINK-8347) Make Cluster id typesafe

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316731#comment-16316731 ] ASF GitHub Bot commented on FLINK-8347: --- Github user GJL commented on a diff in the

[jira] [Commented] (FLINK-8347) Make Cluster id typesafe

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316730#comment-16316730 ] ASF GitHub Bot commented on FLINK-8347: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5232: [FLINK-8347] [flip6] Make cluster id used by Clust...

2018-01-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5232#discussion_r160216156 --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java --- @@ -98,24 +103,26 @@ public void testUnknownJobId() throws Except

[GitHub] flink pull request #5232: [FLINK-8347] [flip6] Make cluster id used by Clust...

2018-01-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5232#discussion_r160209875 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java --- @@ -83,7 +83,7 @@ public void testClusterClientRetrievalOfFinishedYarn

[jira] [Commented] (FLINK-8389) Release all slots upon closing of JobMaster connection

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316672#comment-16316672 ] ASF GitHub Bot commented on FLINK-8389: --- GitHub user tillrohrmann opened a pull requ

[GitHub] flink pull request #5265: [FLINK-8389] [flip6] Release all slots upon closin...

2018-01-08 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5265 [FLINK-8389] [flip6] Release all slots upon closing of JobManager connection ## What is the purpose of the change Release the slots assigned to a `JobMaster` once it disconnects from

[jira] [Commented] (FLINK-8343) Add support for job cluster deployment

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316664#comment-16316664 ] ASF GitHub Bot commented on FLINK-8343: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5229: [FLINK-8343] [flip6] Remove Yarn specific commands...

2018-01-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5229#discussion_r160209100 --- Diff: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java --- @@ -56,7 +57,15 @@ * @return Cluster client to talk

[jira] [Commented] (FLINK-8347) Make Cluster id typesafe

2018-01-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316656#comment-16316656 ] ASF GitHub Bot commented on FLINK-8347: --- Github user GJL commented on a diff in the

[GitHub] flink pull request #5232: [FLINK-8347] [flip6] Make cluster id used by Clust...

2018-01-08 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5232#discussion_r160208748 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java --- @@ -367,40 +366,31 @@ public ClusterClient retrieve(String appli

[jira] [Created] (FLINK-8389) Release all slots upon closing of JobMaster connection

2018-01-08 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8389: Summary: Release all slots upon closing of JobMaster connection Key: FLINK-8389 URL: https://issues.apache.org/jira/browse/FLINK-8389 Project: Flink Issue Ty

  1   2   3   4   >