[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969654 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -25,17 +25,16

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969840 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -48,62 +47,52

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969524 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -25,17 +25,16

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969652 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -25,17 +25,16

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969750 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -48,62 +47,52

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969597 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -25,17 +25,16

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969785 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -48,62 +47,52

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969736 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -48,62 +47,52

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969780 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -48,62 +47,52

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969642 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -25,17 +25,16

[GitHub] [flink] klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese

2019-05-03 Thread GitBox
klion26 commented on a change in pull request #8319: [FLINK-11636] [docs-zh] Translate "State Schema Evolution" into Chinese URL: https://github.com/apache/flink/pull/8319#discussion_r280969812 ## File path: docs/dev/stream/state/schema_evolution.zh.md ## @@ -48,62 +47,52

[GitHub] [flink] bowenli86 commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
bowenli86 commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969694 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
bowenli86 commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969694 ## File path:

[GitHub] [flink] bowenli86 commented on issue #8340: [FLINK-12395][table] Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces

2019-05-03 Thread GitBox
bowenli86 commented on issue #8340: [FLINK-12395][table] Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces URL: https://github.com/apache/flink/pull/8340#issuecomment-489295088 cc @xuefuz

[jira] [Updated] (FLINK-12395) Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces

2019-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12395: --- Labels: pull-request-available (was: ) > Add more detailed javadoc for getDescription()

[GitHub] [flink] flinkbot commented on issue #8340: [FLINK-12395][table] Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces

2019-05-03 Thread GitBox
flinkbot commented on issue #8340: [FLINK-12395][table] Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces URL: https://github.com/apache/flink/pull/8340#issuecomment-489295083 Thanks a lot for your contribution to the Apache Flink

[GitHub] [flink] bowenli86 opened a new pull request #8340: [FLINK-12395][table] Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces

2019-05-03 Thread GitBox
bowenli86 opened a new pull request #8340: [FLINK-12395][table] Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces URL: https://github.com/apache/flink/pull/8340 ## What is the purpose of the change This PR adds more detailed

[jira] [Updated] (FLINK-12395) Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object interfaces

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12395: - Summary: Add more detailed javadoc for getDescription() and getDetailedDescription() in catalog object

[jira] [Updated] (FLINK-12395) Document description and detailed description in catalog object interfaces

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12395: - Summary: Document description and detailed description in catalog object interfaces (was: Document

[jira] [Assigned] (FLINK-12395) Document description and detailed description in catalog object interfaces

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-12395: Assignee: Bowen Li > Document description and detailed description in catalog object interfaces

[GitHub] [flink] xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969214 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969532 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969550 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280968990 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969275 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-03 Thread GitBox
xuefuz commented on a change in pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#discussion_r280969459 ## File path:

[jira] [Comment Edited] (FLINK-12395) Document description and detailed description in CatalogBaseTable

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832986#comment-16832986 ] Bowen Li edited comment on FLINK-12395 at 5/4/19 5:05 AM: -- Agree to improve the

[jira] [Commented] (FLINK-11637) Translate "Checkpoints" page into Chinese

2019-05-03 Thread Congxian Qiu(klion26) (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832987#comment-16832987 ] Congxian Qiu(klion26) commented on FLINK-11637: --- [~lsy] I'm not working on this now, if

[jira] [Updated] (FLINK-12395) Document description and detailed description in CatalogBaseTable

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12395: - Description: We need to add more javadoc for {{getDescritpion()}} and {{getDetailedDescription()}} APIs

[jira] [Commented] (FLINK-12395) Reconcile description and detailed description in CatalogBaseTable

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832986#comment-16832986 ] Bowen Li commented on FLINK-12395: -- Agree to improve the javadoc, as I've also been confused... I'll

[jira] [Updated] (FLINK-12395) Document description and detailed description in CatalogBaseTable

2019-05-03 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12395: - Summary: Document description and detailed description in CatalogBaseTable (was: Reconcile description

[jira] [Updated] (FLINK-12240) Support view related operations in GenericHiveMetastoreCatalog

2019-05-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12240: --- Labels: pull-request-available (was: ) > Support view related operations in

[GitHub] [flink] flinkbot commented on issue #8339: [FLINK-12240][hive] Support view related operations in GenericHiveMetastoreCatalog

2019-05-03 Thread GitBox
flinkbot commented on issue #8339: [FLINK-12240][hive] Support view related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8339#issuecomment-489287613 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] bowenli86 opened a new pull request #8339: [FLINK-12240][hive] Support view related operations in GenericHiveMetastoreCatalog

2019-05-03 Thread GitBox
bowenli86 opened a new pull request #8339: [FLINK-12240][hive] Support view related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8339 ## What is the purpose of the change This PR added support for views in GenericHiveMetastoreCatalog,

[GitHub] [flink] flinkbot commented on issue #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators

2019-05-03 Thread GitBox
flinkbot commented on issue #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators URL: https://github.com/apache/flink/pull/8338#issuecomment-489284633 Thanks a lot for your contribution to the Apache Flink project. I'm

[GitHub] [flink] klion26 opened a new pull request #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators

2019-05-03 Thread GitBox
klion26 opened a new pull request #8338: [BP-1.6][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators URL: https://github.com/apache/flink/pull/8338 ## What is the purpose of the change cherry-pick #8263 to release-1.6 manually.

[jira] [Created] (FLINK-12399) FilterableTableSource does not use filters on job run

2019-05-03 Thread Josh Bradt (JIRA)
Josh Bradt created FLINK-12399: -- Summary: FilterableTableSource does not use filters on job run Key: FLINK-12399 URL: https://issues.apache.org/jira/browse/FLINK-12399 Project: Flink Issue

[jira] [Created] (FLINK-12398) Support partitioned view in catalog API

2019-05-03 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12398: Summary: Support partitioned view in catalog API Key: FLINK-12398 URL: https://issues.apache.org/jira/browse/FLINK-12398 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-12397) Drop flink-shaded-asm-5

2019-05-03 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-12397: Summary: Drop flink-shaded-asm-5 Key: FLINK-12397 URL: https://issues.apache.org/jira/browse/FLINK-12397 Project: Flink Issue Type: Improvement

[jira] [Closed] (FLINK-12390) Fully migrate to asm6

2019-05-03 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-12390. Resolution: Fixed master: 9975e0393a9e09dbde21ca61f1a5751cc5934411 > Fully migrate to

[jira] [Created] (FLINK-12396) KafkaITCase.testOneSourceMultiplePartitions doesn't fail properly

2019-05-03 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12396: Summary: KafkaITCase.testOneSourceMultiplePartitions doesn't fail properly Key: FLINK-12396 URL: https://issues.apache.org/jira/browse/FLINK-12396 Project: Flink

[GitHub] [flink] zentol merged pull request #8332: [FLINK-12390][build] Fully migrate to flink-shaded-asm-6

2019-05-03 Thread GitBox
zentol merged pull request #8332: [FLINK-12390][build] Fully migrate to flink-shaded-asm-6 URL: https://github.com/apache/flink/pull/8332 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] bowenli86 commented on issue #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-03 Thread GitBox
bowenli86 commented on issue #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#issuecomment-489180854 Thanks @dawidwys for the feedback! Let's sync up on Monday offline as planned

[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-03 Thread GitBox
bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280866583 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-03 Thread GitBox
bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280858643 ## File path:

[GitHub] [flink] GJL commented on issue #8332: [FLINK-12390][build] Fully migrate to flink-shaded-asm-6

2019-05-03 Thread GitBox
GJL commented on issue #8332: [FLINK-12390][build] Fully migrate to flink-shaded-asm-6 URL: https://github.com/apache/flink/pull/8332#issuecomment-489154787 @flinkbot approve all This is an automated message from the Apache

[GitHub] [flink] sjwiesman commented on a change in pull request #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation

2019-05-03 Thread GitBox
sjwiesman commented on a change in pull request #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation URL: https://github.com/apache/flink/pull/8326#discussion_r280830610 ## File path: docs/ops/deployment/aws.md ## @@ -64,81 +64,11 @@

[GitHub] [flink] piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-05-03 Thread GitBox
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-489140860 Ok I think I didn't catch the issue as I was using mvn 3.5 and it seems that the shade plugin behaves a bit differently on it.

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280777174 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280761093 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280771723 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280769132 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280761548 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280713033 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280786571 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280787008 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280713503 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280795534 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280766308 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280769682 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280777174 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280762347 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280762928 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280777824 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280761093 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280703833 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
twalthr commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280798765 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy

2019-05-03 Thread GitBox
GJL commented on a change in pull request #8309: [FLINK-12229] [runtime] Implement LazyFromSourcesScheduling Strategy URL: https://github.com/apache/flink/pull/8309#discussion_r280775926 ## File path:

[GitHub] [flink] sjwiesman commented on issue #8330: [FLINK-12388][docs] Update the production readiness checklist

2019-05-03 Thread GitBox
sjwiesman commented on issue #8330: [FLINK-12388][docs] Update the production readiness checklist URL: https://github.com/apache/flink/pull/8330#issuecomment-489107895 Thanks for the review, I've updated the JobManager section to be more clear and also fixed a few other grammar issues I

[GitHub] [flink] StephanEwen edited a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-05-03 Thread GitBox
StephanEwen edited a comment on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-489105632 This PR does a few things at the same time: 1. It recurses into fields, cleaning them. 2. It skips

[GitHub] [flink] StephanEwen commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function

2019-05-03 Thread GitBox
StephanEwen commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle the wrapped function URL: https://github.com/apache/flink/pull/8280#issuecomment-489105632 This PR does a few things at the same time: 1. It recurses into fields, cleaning them. 2. It skips closure

[GitHub] [flink] StephanEwen commented on a change in pull request #8282: [FLINK-12338] Update Apache Avro test to use try-with-resources

2019-05-03 Thread GitBox
StephanEwen commented on a change in pull request #8282: [FLINK-12338] Update Apache Avro test to use try-with-resources URL: https://github.com/apache/flink/pull/8282#discussion_r280777846 ## File path:

[GitHub] [flink] StephanEwen commented on a change in pull request #8282: [FLINK-12338] Update Apache Avro test to use try-with-resources

2019-05-03 Thread GitBox
StephanEwen commented on a change in pull request #8282: [FLINK-12338] Update Apache Avro test to use try-with-resources URL: https://github.com/apache/flink/pull/8282#discussion_r280776846 ## File path:

[GitHub] [flink] StephanEwen commented on a change in pull request #8282: [FLINK-12338] Update Apache Avro test to use try-with-resources

2019-05-03 Thread GitBox
StephanEwen commented on a change in pull request #8282: [FLINK-12338] Update Apache Avro test to use try-with-resources URL: https://github.com/apache/flink/pull/8282#discussion_r280778538 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication

2019-05-03 Thread GitBox
pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication URL: https://github.com/apache/flink/pull/7688#discussion_r280773729 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication

2019-05-03 Thread GitBox
pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication URL: https://github.com/apache/flink/pull/7688#discussion_r280771834 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication

2019-05-03 Thread GitBox
pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication URL: https://github.com/apache/flink/pull/7688#discussion_r280771141 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication

2019-05-03 Thread GitBox
pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication URL: https://github.com/apache/flink/pull/7688#discussion_r280772939 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication

2019-05-03 Thread GitBox
pnowojski commented on a change in pull request #7688: [FLINK-9816][network] add option to configure SSL engine provider for TM communication URL: https://github.com/apache/flink/pull/7688#discussion_r280775627 ## File path:

[GitHub] [flink] piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-05-03 Thread GitBox
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-489094928 Yeah let me check. I kicked off a `mvn clean install -DskipTests` on my machine before submitting and that seems to have gone

[GitHub] [flink] flinkbot edited a comment on issue #8285: FLINK- Fix typo in "Window Operator" documentation

2019-05-03 Thread GitBox
flinkbot edited a comment on issue #8285: FLINK- Fix typo in "Window Operator" documentation URL: https://github.com/apache/flink/pull/8285#issuecomment-487081426 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] StephanEwen commented on issue #8285: FLINK- Fix typo in "Window Operator" documentation

2019-05-03 Thread GitBox
StephanEwen commented on issue #8285: FLINK- Fix typo in "Window Operator" documentation URL: https://github.com/apache/flink/pull/8285#issuecomment-489093278 @flinkbot approve all This is an automated message from the

[GitHub] [flink] StephanEwen commented on issue #8285: FLINK- Fix typo in "Window Operator" documentation

2019-05-03 Thread GitBox
StephanEwen commented on issue #8285: FLINK- Fix typo in "Window Operator" documentation URL: https://github.com/apache/flink/pull/8285#issuecomment-489093241 Thanks for the patch. Merging this... This is an automated

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280736591 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280742847 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280737135 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280764585 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280744074 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280733755 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280738815 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280761541 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280755454 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280762367 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280738605 ## File path:

[GitHub] [flink] zentol commented on issue #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-05-03 Thread GitBox
zentol commented on issue #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316#issuecomment-489086627 We should also add some tests for the `Execution*` classes to

[GitHub] [flink] twalthr commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-03 Thread GitBox
twalthr commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280763754 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-05-03 Thread GitBox
zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316#discussion_r280747402 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-05-03 Thread GitBox
zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316#discussion_r280752971 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-05-03 Thread GitBox
zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316#discussion_r280758391 ## File path:

[GitHub] [flink] zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-05-03 Thread GitBox
zentol commented on a change in pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316#discussion_r280759213 ## File path:

  1   2   >