[GitHub] [flink] beyond1920 commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

beyond1920 commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058118429 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the

[GitHub] [flink] beyond1920 commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

beyond1920 commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058116587 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,149 @@ +/* + * Licensed to the

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

jiangxin369 commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1057228565 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/MinHashLSH.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[jira] [Assigned] (FLINK-29859) TPC-DS end-to-end test with adaptive batch scheduler failed due to oo non-empty .out files.

[ https://issues.apache.org/jira/browse/FLINK-29859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-29859: -- Assignee: Lijie Wang > TPC-DS end-to-end test with adaptive batch scheduler failed due to oo

[jira] [Resolved] (FLINK-29859) TPC-DS end-to-end test with adaptive batch scheduler failed due to oo non-empty .out files.

[ https://issues.apache.org/jira/browse/FLINK-29859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang resolved FLINK-29859. Fix Version/s: 1.17.0 1.16.1 Resolution: Fixed > TPC-DS end-to-end test

[jira] [Commented] (FLINK-29859) TPC-DS end-to-end test with adaptive batch scheduler failed due to oo non-empty .out files.

[ https://issues.apache.org/jira/browse/FLINK-29859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652398#comment-17652398 ] Lijie Wang commented on FLINK-29859: Fixed via master 14a61f368332320d7e38cc93a04f95bb63c66788

[jira] [Created] (FLINK-30516) Add file count and row count in snapshots table

Shammon created FLINK-30516: --- Summary: Add file count and row count in snapshots table Key: FLINK-30516 URL: https://issues.apache.org/jira/browse/FLINK-30516 Project: Flink Issue Type: Sub-task

[GitHub] [flink] xintongsong commented on a diff in pull request #21560: [FLINK-29768] Hybrid shuffle supports consume partial finished subtask

xintongsong commented on code in PR #21560: URL: https://github.com/apache/flink/pull/21560#discussion_r1058108777 ## flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/InternalExecutionGraphAccessor.java: ## @@ -122,4 +122,6 @@ List

[GitHub] [flink] wanglijie95 closed pull request #21559: [FLINK-29859][e2e] Running TPC-DS with adaptive batch scheduler supports custom exceptions check

wanglijie95 closed pull request #21559: [FLINK-29859][e2e] Running TPC-DS with adaptive batch scheduler supports custom exceptions check URL: https://github.com/apache/flink/pull/21559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #489: [FLINK-30406] Detect when jobmanager never started

morhidi commented on PR #489: URL: https://github.com/apache/flink-kubernetes-operator/pull/489#issuecomment-1366390439 +1 nice job @gyfora ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-ml] jiangxin369 commented on pull request #193: [FLINK-30515] Add benchmark for CountVectorizer, Imputer, RobustScale…

jiangxin369 commented on PR #193: URL: https://github.com/apache/flink-ml/pull/193#issuecomment-1366389187 @lindong28 Could you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] Mulavar commented on a diff in pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

Mulavar commented on code in PR #21545: URL: https://github.com/apache/flink/pull/21545#discussion_r1058069998 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/hint/FlinkHints.java: ## @@ -189,18 +191,33 @@ public static RelNode

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #489: [FLINK-30406] Detect when jobmanager never started

morhidi commented on code in PR #489: URL: https://github.com/apache/flink-kubernetes-operator/pull/489#discussion_r1058069736 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/ApplicationReconciler.java: ## @@ -112,18

[GitHub] [flink] LadyForest commented on a diff in pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

LadyForest commented on code in PR #21504: URL: https://github.com/apache/flink/pull/21504#discussion_r1058054716 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -417,6 +422,92 @@ void

[GitHub] [flink] fsk119 commented on a diff in pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

fsk119 commented on code in PR #21504: URL: https://github.com/apache/flink/pull/21504#discussion_r1058050529 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -417,6 +422,92 @@ void

[GitHub] [flink] fsk119 commented on pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

fsk119 commented on PR #21504: URL: https://github.com/apache/flink/pull/21504#issuecomment-1366360753 +1 to move to another task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] fsk119 commented on a diff in pull request #19329: [FLINK-22318][table] Support RENAME column name for ALTER TABLE statement

fsk119 commented on code in PR #19329: URL: https://github.com/apache/flink/pull/19329#discussion_r1058046923 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -144,6 +147,163 @@ public static Operation

[jira] [Updated] (FLINK-30515) Add benchmark for CountVectorizer, Imputer, RobustScaler, UnivariateFeatureSelector and VarianceThresholdSelector

[ https://issues.apache.org/jira/browse/FLINK-30515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30515: --- Labels: pull-request-available (was: ) > Add benchmark for CountVectorizer, Imputer,

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #193: [FLINK-30515] Add benchmark for CountVectorizer, Imputer, RobustScale…

jiangxin369 opened a new pull request, #193: URL: https://github.com/apache/flink-ml/pull/193 …r, UnivariateFeatureSelector and VarianceThresholdSelector ## What is the purpose of the change Add benchmark for CountVectorizer, Imputer, RobustScaler,

[jira] [Created] (FLINK-30515) Add benchmark for CountVectorizer, Imputer, RobustScaler, UnivariateFeatureSelector and VarianceThresholdSelector

Jiang Xin created FLINK-30515: - Summary: Add benchmark for CountVectorizer, Imputer, RobustScaler, UnivariateFeatureSelector and VarianceThresholdSelector Key: FLINK-30515 URL:

[jira] [Comment Edited] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652361#comment-17652361 ] Jiankun Feng edited comment on FLINK-30314 at 12/28/22 4:05 AM: Hello,

[jira] [Commented] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652361#comment-17652361 ] Jiankun Feng commented on FLINK-30314: -- Hello, everyone. This problem also occurs in 1.14.3 when

[GitHub] [flink] lincoln-lil commented on pull request #20800: [FLINK-28850][table-planner] Support table alias in LOOKUP hint

lincoln-lil commented on PR #20800: URL: https://github.com/apache/flink/pull/20800#issuecomment-1366346357 @godfreyhe thanks for reviewing this! I've updated the pr according to your comments, the Snapshot was formatted correctly in the first commit and added two more cases that use table

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058031265 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [flink] beyond1920 commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

beyond1920 commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058030752 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink busy join reorder rule which based on greedy algorithm

swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1058027477 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBusyJoinReorderRule.java: ## @@ -0,0 +1,688 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink busy join reorder rule which based on greedy algorithm

swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1058025322 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBusyJoinReorderRule.java: ## @@ -0,0 +1,688 @@ +/* + *

[GitHub] [flink-table-store] tsreaper merged pull request #445: [FLINK-30506] Add documentation for writing Table Store with Spark3

tsreaper merged PR #445: URL: https://github.com/apache/flink-table-store/pull/445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink busy join reorder rule which based on greedy algorithm

swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1058020032 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -135,6 +135,24 @@ public class

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink busy join reorder rule which based on greedy algorithm

swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1058019619 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkBusyJoinReorderRule.java: ## @@ -0,0 +1,688 @@ +/* + *

[GitHub] [flink] swuferhong commented on a diff in pull request #21530: [FLINK-30376][table-planner] Introduce a new flink busy join reorder rule which based on greedy algorithm

swuferhong commented on code in PR #21530: URL: https://github.com/apache/flink/pull/21530#discussion_r1058019236 ## docs/layouts/shortcodes/generated/optimizer_config_configuration.html: ## @@ -89,5 +89,17 @@ Boolean When it is true, the optimizer

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058018678 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058014713 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058014428 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [flink] lsyldliu commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

lsyldliu commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1058014011 ## flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveSumAggFunction.java: ## @@ -0,0 +1,167 @@ +/* + * Licensed to the

[GitHub] [flink-kubernetes-operator] nowke commented on a diff in pull request #487: [FLINK-30411] Validate empty JmSpec and TmSpec

nowke commented on code in PR #487: URL: https://github.com/apache/flink-kubernetes-operator/pull/487#discussion_r1057990470 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -241,15 +245,35 @@ private

[GitHub] [flink-connector-opensearch] reta commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

reta commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1366207021 @ypark2103 that is correct, the Flink Opensearch Connector was following the Flink's externalization model for connectors, the necessary scaffolding is only available in Flink

[GitHub] [flink-connector-opensearch] ypark2103 commented on pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

ypark2103 commented on PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#issuecomment-1366195952 @reta @MartijnVisser Is this Flink-Connector-Opensearch only available for flink 1.16 version? What about flink 1.11 or 1.12? -- This is an automated message from the

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #8: [FLINK-14102] Introduce DB2Dialect.

eskabetxe commented on code in PR #8: URL: https://github.com/apache/flink-connector-jdbc/pull/8#discussion_r1057924897 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/dialect/db2/Db2TestBaseITCase.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #8: [FLINK-14102] Introduce DB2Dialect.

eskabetxe commented on code in PR #8: URL: https://github.com/apache/flink-connector-jdbc/pull/8#discussion_r1057922321 ## flink-connector-jdbc/pom.xml: ## @@ -195,13 +202,13 @@ under the License. test - - +

[GitHub] [flink] yuzelin commented on pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

yuzelin commented on PR #21525: URL: https://github.com/apache/flink/pull/21525#issuecomment-1366075740 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #21564: [FLINK-30514] HybridSource savepoint recovery sequence fix

flinkbot commented on PR #21564: URL: https://github.com/apache/flink/pull/21564#issuecomment-1366067992 ## CI report: * b68145ccb94f51f4ef510cb2246b6c423a064347 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30514) HybridSource savepoint recovery sequence

[ https://issues.apache.org/jira/browse/FLINK-30514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30514: --- Labels: pull-request-available (was: ) > HybridSource savepoint recovery sequence >

[GitHub] [flink] WonderBeat opened a new pull request, #21564: [FLINK-30514] HybridSource savepoint recovery sequence fix

WonderBeat opened a new pull request, #21564: URL: https://github.com/apache/flink/pull/21564 ## What is the purpose of the change This PR tweaks `HybridSourceReader` underlying reader initialization sequence to make it compatible with `FileSourceReader`. ## Brief

[jira] [Updated] (FLINK-30514) HybridSource savepoint recovery sequence

[ https://issues.apache.org/jira/browse/FLINK-30514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Golovachev updated FLINK-30514: - Description: {{org.apache.flink.connector.base.source.hybrid.HybridSourceReader}}

[jira] [Updated] (FLINK-30514) HybridSource savepoint recovery sequence

[ https://issues.apache.org/jira/browse/FLINK-30514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Denis Golovachev updated FLINK-30514: - Description: {{org.apache.flink.connector.base.source.hybrid.HybridSourceReader}}

[jira] [Created] (FLINK-30514) HybridSource savepoint recovery sequence

Denis Golovachev created FLINK-30514: Summary: HybridSource savepoint recovery sequence Key: FLINK-30514 URL: https://issues.apache.org/jira/browse/FLINK-30514 Project: Flink Issue Type:

[GitHub] [flink] LadyForest commented on pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

LadyForest commented on PR #21504: URL: https://github.com/apache/flink/pull/21504#issuecomment-1366041944 > BTW, I think we should also take `OperationConverterUtils.convertChangeColumn` into consideration. Will you help to clean the code about this? Sure, I'd like to. However, it

[GitHub] [flink] LadyForest commented on a diff in pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

LadyForest commented on code in PR #21504: URL: https://github.com/apache/flink/pull/21504#discussion_r1057779254 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -417,6 +422,92 @@ void

[jira] [Commented] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652279#comment-17652279 ] Krzysztof Chmielewski commented on FLINK-27246: --- Hi [~TsReaper] Thanks for the feedback.

[GitHub] [flink] LadyForest commented on a diff in pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

LadyForest commented on code in PR #21504: URL: https://github.com/apache/flink/pull/21504#discussion_r1057779254 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -417,6 +422,92 @@ void

[GitHub] [flink] gyfora commented on pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

gyfora commented on PR #21515: URL: https://github.com/apache/flink/pull/21515#issuecomment-1366000815 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Closed] (FLINK-30456) OLM Bundle Description Version Problems

[ https://issues.apache.org/jira/browse/FLINK-30456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30456. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #491: [FLINK-30456] Fixing Version and provider in OLM Description

gyfora merged PR #491: URL: https://github.com/apache/flink-kubernetes-operator/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #487: [FLINK-30411] Validate empty JmSpec and TmSpec

gyfora commented on code in PR #487: URL: https://github.com/apache/flink-kubernetes-operator/pull/487#discussion_r1057748254 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/validation/DefaultValidator.java: ## @@ -241,15 +245,35 @@ private

[jira] [Assigned] (FLINK-27571) Recognize "less is better" benchmarks in regression detection script

[ https://issues.apache.org/jira/browse/FLINK-27571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan reassigned FLINK-27571: - Assignee: Yanfei Lei (was: Roman Khachatryan) > Recognize "less is better"

[GitHub] [flink] fsk119 commented on pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

fsk119 commented on PR #21504: URL: https://github.com/apache/flink/pull/21504#issuecomment-1365913657 BTW, I think we should also take `OperationConverterUtils.convertChangeColumn` into consideration. Will you help to clean the code about this? -- This is an automated message from the

[jira] [Updated] (FLINK-30513) HA storage dir leaks on cluster termination

[ https://issues.apache.org/jira/browse/FLINK-30513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-30513: -- Issue Type: Bug (was: Improvement) > HA storage dir leaks on cluster termination >

[jira] [Updated] (FLINK-30513) HA storage dir leaks on cluster termination

[ https://issues.apache.org/jira/browse/FLINK-30513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-30513: -- Description: *Problem* We found that HA storage dir leaks on cluster termination for a Flink

[jira] [Created] (FLINK-30513) HA storage dir leaks on cluster termination

Zhanghao Chen created FLINK-30513: - Summary: HA storage dir leaks on cluster termination Key: FLINK-30513 URL: https://issues.apache.org/jira/browse/FLINK-30513 Project: Flink Issue Type:

[GitHub] [flink] fsk119 commented on a diff in pull request #21504: [FLINK-22316][table] Support MODIFY column/constraint/watermark for ALTER TABLE statement

fsk119 commented on code in PR #21504: URL: https://github.com/apache/flink/pull/21504#discussion_r1057674344 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -607,6 +607,195 @@ class TableEnvironmentTest {

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

gyfora commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057676553 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public

[GitHub] [flink] luoyuxia commented on pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

luoyuxia commented on PR #21257: URL: https://github.com/apache/flink/pull/21257#issuecomment-1365896752 @beyond1920 Thanks for reviewing. I prefer to append a commit with tests to mock the speculative execution to validate these operators. -- This is an automated message from the

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

gyfora commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057664132 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

gyfora commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057663391 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

mxm commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057660487 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public

[GitHub] [flink] beyond1920 commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

beyond1920 commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1057658616 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/CompactFileUtils.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the

[jira] [Closed] (FLINK-30494) Introduce TableChange to represents SET/RESET change

[ https://issues.apache.org/jira/browse/FLINK-30494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-30494. - Resolution: Implemented Merged into master: 75a92efd7b35501698e5de253e5231d680830c16 >

[GitHub] [flink] fsk119 merged pull request #21554: [FLINK-30493][table-api] Introduce TableChange to SET/RESET options

fsk119 merged PR #21554: URL: https://github.com/apache/flink/pull/21554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] beyond1920 commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

beyond1920 commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1057645105 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchFileWriter.java: ## @@ -0,0 +1,115 @@ +/* + *

[jira] [Updated] (FLINK-30512) Flink SQL state TTL has no effect when using Interval Join

[ https://issues.apache.org/jira/browse/FLINK-30512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wangkang updated FLINK-30512: - Description: Take the following join SQL program as an example: {code:java} SET 'table.exec.state.ttl'

[jira] [Created] (FLINK-30512) Flink SQL state TTL has no effect when using Interval Join

wangkang created FLINK-30512: Summary: Flink SQL state TTL has no effect when using Interval Join Key: FLINK-30512 URL: https://issues.apache.org/jira/browse/FLINK-30512 Project: Flink Issue

[jira] [Commented] (FLINK-25421) Port JDBC Sink to new Unified Sink API (FLIP-143)

[ https://issues.apache.org/jira/browse/FLINK-25421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652232#comment-17652232 ] RocMarshal commented on FLINK-25421: Get it. Thanks a lot~ [~eskabetxe]  > Port JDBC Sink to new

[jira] [Updated] (FLINK-30511) Ignore the Exception in user-timer Triggerble when recover form state.

[ https://issues.apache.org/jira/browse/FLINK-30511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-30511: --- Description: * Code segment: {code:java} public class OnTimerDemo { public static void

[jira] [Created] (FLINK-30511) Ignore the Exception in user-timer Triggerble when recover form state.

RocMarshal created FLINK-30511: -- Summary: Ignore the Exception in user-timer Triggerble when recover form state. Key: FLINK-30511 URL: https://issues.apache.org/jira/browse/FLINK-30511 Project: Flink

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

gyfora commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057607945 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public

[GitHub] [flink] flinkbot commented on pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of columnar format

flinkbot commented on PR #21563: URL: https://github.com/apache/flink/pull/21563#issuecomment-1365806084 ## CI report: * 0f3cbc42fcab5f2f351290cae304ed6ea2cca78d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-19889) Supports nested projection pushdown for filesystem connector of columnar format

[ https://issues.apache.org/jira/browse/FLINK-19889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-19889: --- Labels: pull-request-available (was: ) > Supports nested projection pushdown for

[GitHub] [flink] LadyForest commented on a diff in pull request #19329: [FLINK-22318][table] Support RENAME column name for ALTER TABLE statement

LadyForest commented on code in PR #19329: URL: https://github.com/apache/flink/pull/19329#discussion_r1057594885 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -144,6 +147,163 @@ public static Operation

[GitHub] [flink] yuchuanchen opened a new pull request, #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of columnar forma

yuchuanchen opened a new pull request, #21563: URL: https://github.com/apache/flink/pull/21563 …sted projection pushdown for filesystem connector of columnar format ## What is the purpose of the change Supports nested projection pushdown for filesystem connector of columnar

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #493: [FLINK-30464] Exclude metrics during stabilization and ensure a full metric window

mxm commented on code in PR #493: URL: https://github.com/apache/flink-kubernetes-operator/pull/493#discussion_r1057588877 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java: ## @@ -122,7 +130,15 @@ public

[jira] [Updated] (FLINK-29950) Refactor ResultSet to an interface

[ https://issues.apache.org/jira/browse/FLINK-29950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29950: Description: Currently, the 'ResultSet' only contains Schema and data for execution result, witch is not

[jira] [Created] (FLINK-30510) Allow configuring minimum and maximum metrics window size

Maximilian Michels created FLINK-30510: -- Summary: Allow configuring minimum and maximum metrics window size Key: FLINK-30510 URL: https://issues.apache.org/jira/browse/FLINK-30510 Project: Flink

[jira] [Updated] (FLINK-29950) Refactor ResultSet to an interface

[ https://issues.apache.org/jira/browse/FLINK-29950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29950: Description: Currently, the 'ResultSet' only contains Schema and data for execution result, witch is not

[jira] [Updated] (FLINK-29950) Refactor ResultSet to a interface

[ https://issues.apache.org/jira/browse/FLINK-29950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29950: Summary: Refactor ResultSet to a interface (was: ResultSet Refactor) > Refactor ResultSet to a interface

[jira] [Updated] (FLINK-29950) Refactor ResultSet to an interface

[ https://issues.apache.org/jira/browse/FLINK-29950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yuzelin updated FLINK-29950: Summary: Refactor ResultSet to an interface (was: Refactor ResultSet to a interface) > Refactor

[GitHub] [flink] MartijnVisser commented on pull request #21542: [FLINK-27640][Connector/Hive] Exclude Pentaho dependency from Hive

MartijnVisser commented on PR #21542: URL: https://github.com/apache/flink/pull/21542#issuecomment-1365743830 > I'm back. I have verified with Hive 2.3.9 & Hive 3.1.3, it still works after we exclude pentaho dependency. Thanks for checking! > `mvn dependency:tree` tells that

[GitHub] [flink] flinkbot commented on pull request #21562: [FLINK-30509] Modify sql-client.sh

flinkbot commented on PR #21562: URL: https://github.com/apache/flink/pull/21562#issuecomment-1365742842 ## CI report: * a0fbb989f0315cf2c0e757f0e53f17b390359a2e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30509) Modify sql-client.sh

[ https://issues.apache.org/jira/browse/FLINK-30509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30509: --- Labels: pull-request-available (was: ) > Modify sql-client.sh > > >

[GitHub] [flink] yuzelin opened a new pull request, #21562: [FLINK-30509] Modify sql-client.sh

yuzelin opened a new pull request, #21562: URL: https://github.com/apache/flink/pull/21562 ## What is the purpose of the change New design of SQL client will depend on the sql-gateway module. So add the jar to the jar path in starting script. ## Brief change log

[jira] [Created] (FLINK-30509) Modify sql-client.sh

yuzelin created FLINK-30509: --- Summary: Modify sql-client.sh Key: FLINK-30509 URL: https://issues.apache.org/jira/browse/FLINK-30509 Project: Flink Issue Type: Sub-task Components: Table

[jira] [Closed] (FLINK-30368) Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

[ https://issues.apache.org/jira/browse/FLINK-30368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He closed FLINK-30368. -- Resolution: Fixed Fixed in master: dc862dae28a172f674a9b8a2198c603275304550 > Fix calcite method

[jira] [Assigned] (FLINK-30368) Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

[ https://issues.apache.org/jira/browse/FLINK-30368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Godfrey He reassigned FLINK-30368: -- Assignee: Yunhong Zheng > Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero

[GitHub] [flink] godfreyhe closed pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than n

godfreyhe closed pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected URL: https://github.com/apache/flink/pull/21490 -- This is an automated message from the Apache

[jira] [Commented] (FLINK-30505) Close the connection between TM and JM when task executor failed

[ https://issues.apache.org/jira/browse/FLINK-30505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652188#comment-17652188 ] Yongming Zhang commented on FLINK-30505: [~xtsong] Thanks for participating in this discussion

[GitHub] [flink] yuzelin commented on a diff in pull request #21525: [FLINK-30416][sql-gateway] Add configureSession REST API in the SQL Gateway

yuzelin commented on code in PR #21525: URL: https://github.com/apache/flink/pull/21525#discussion_r1057502548 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/rest/SqlGatewayRestEndpointITCase.java: ## @@ -58,154 +58,139 @@ import