Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190583266
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -933,25 +956,35 @@ public void requestHeartbeat(ResourceID
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190557380
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -732,19 +744,10 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190603934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
---
@@ -933,25 +956,35 @@ public void requestHeartbeat(ResourceID
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6067#discussion_r190603365
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
@@ -1483,6 +1485,216 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6069#discussion_r190605670
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -314,7 +319,8 @@ public JobSubmissionResult submitJob
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6069#discussion_r190605113
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -274,11 +275,17 @@ public JobSubmissionResult
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5410
Thanks for updating @pduveau. There still some minor comments on
`RMQSinkPublishOptions` and `README` that are open for discussion.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r194109528
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r194109518
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r194109540
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964402
--- Diff: flink-connectors/flink-connector-rabbitmq/README.md ---
@@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client".
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193963772
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193963587
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193965626
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +155,24 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964437
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964455
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193964429
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193120662
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193122068
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193119522
--- Diff: flink-connectors/flink-connector-rabbitmq/README.md ---
@@ -9,3 +9,7 @@ nor packages binaries from the "RabbitMQ AMQP Java Client".
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193127128
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -105,7 +153,18 @@ public
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126347
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126169
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193125374
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126219
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193125823
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126744
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193070753
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -66,12 +79,19
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193126189
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193101683
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -83,7 +103,22
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193122883
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193123998
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkPublishOptions.java
---
@@ -0,0 +1,70
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193010305
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193004950
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQConnectionConfig.java
---
@@ -109,6
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193010378
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -40,22 +42,63
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5410#discussion_r193006836
--- Diff:
flink-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSinkTest.java
---
@@ -124,7 +159,82
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6239
[FLINK-9004][tests] Implement Jepsen tests to test job availability.
## What is the purpose of the change
*Use the Jepsen framework (https://github.com/jepsen-io/jepsen) to implement
tests
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199622404
--- Diff: jepsen-flink/README.md ---
@@ -0,0 +1,60 @@
+# jepsen.flink
+
+A Clojure project based on the
[Jepsen](https://github.com/jepsen-io/jepsen
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199690915
--- Diff: jepsen-flink/README.md ---
@@ -0,0 +1,60 @@
+# jepsen.flink
+
+A Clojure project based on the
[Jepsen](https://github.com/jepsen-io/jepsen
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/6240
[FLINK-9004][tests] Implement Jepsen tests to test job availability.
## What is the purpose of the change
*Use the Jepsen framework (https://github.com/jepsen-io/jepsen) to implement
tests
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6239
@zentol No problem, I opened a new one.
---
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/6240
As @zentol mentioned, we might want to exclude this from
create_source_release.sh.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/6239#discussion_r199507669
--- Diff: jepsen-flink/docker/nodes ---
@@ -0,0 +1,3 @@
+n1
--- End diff --
file must be excluded from RAT plugin
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5933#discussion_r185596918
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -137,6 +142,7 @@ public int
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5944#discussion_r185739056
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
---
@@ -109,7 +119,11 @@ public MiniDispatcher
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5944
I will try it out.
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5944#discussion_r185163799
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
---
@@ -109,7 +119,11 @@ public MiniDispatcher
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5944#discussion_r185163871
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnJobClusterEntrypoint.java
---
@@ -131,6 +133,17 @@ protected JobGraph retrieveJobGraph
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5944#discussion_r185164034
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/MiniDispatcher.java
---
@@ -109,7 +119,11 @@ public MiniDispatcher
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5933#discussion_r184892264
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -149,6 +155,7 @@ public void before
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5933#discussion_r184892245
--- Diff:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java
---
@@ -137,6 +142,7 @@ public int
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5931
@sihuazhou Thx for the review. I'll take a look at your comments later.
Unfortunately with this patch it can still happen that a job is not running
even if enough TMs are available. I have uploaded
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4356
Thanks for your contribution. I have a few questions because the submitted
code does not match with what the ticket currently says:
From https://issues.apache.org/jira/browse/FLINK-5486
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4910
[FLINK-7784] [kafka-producer] Don't fail TwoPhaseCommitSinkFunction when
failing to commit during job recovery
## What is the purpose of the change
This makes it possible to configure
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4910
@aljoscha
---
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4913
[hotfix] [javadoc] Fix typo in Javadoc of
ManagedSnapshotContext#getCheckpointId()
This fixes a typo in the Javadoc of
ManagedSnapshotContext#getCheckpointId().
You can merge this pull request
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4912
[hotfix] [docs] Fix broken downloads page url
This fixes a broken *Downloads Page* url on the AWS page of the
documentation:
https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/aws.html
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147436687
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -483,11
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/4914
[hotfix] [docs] Fix typos in types serialization documentation
This fixes typos in the types serialization documentation.
You can merge this pull request into a Git repository by running:
$ git
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/4915
ð
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/4915#discussion_r147442314
--- Diff:
flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java
---
@@ -563,7 +553,7
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5216
There are some checkstyle violations:
```
[ERROR]
src/main/java/org/apache/flink/yarn/cli/YarnApplicationStatusMonitor.java:[33,8]
(imports) UnusedImports: Unused import
GitHub user GJL opened a pull request:
https://github.com/apache/flink/pull/5207
[FLINK-8299][flip6] Poll JobExecutionResult after job submission
## What is the purpose of the change
*Poll JobExecutionResult after job submission. This is needed, for example,
to enable
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160108309
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160208748
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
@@ -367,40 +366,31 @@ public ClusterClient retrieve(String
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160216156
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -98,24 +103,26 @@ public void testUnknownJobId() throws
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5232#discussion_r160209875
--- Diff:
flink-yarn/src/test/java/org/apache/flink/yarn/AbstractYarnClusterTest.java ---
@@ -83,7 +83,7 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160209100
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java
---
@@ -56,7 +57,15 @@
* @return Cluster client
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5229#discussion_r160165694
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -534,215 +557,235 @@ private Configuration
applyYarnProperties
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5209#discussion_r160638625
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/JarWithProgramUtils.java
---
@@ -0,0 +1,416 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5219#discussion_r160699710
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/CliFrontendSavepointTest.java
---
@@ -128,13 +131,14 @@ public void
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r160699235
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -660,7 +570,25 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5215#discussion_r160699294
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -717,7 +645,26 @@ public int run
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5194#discussion_r160942627
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/job/JobExecutionResultHandlerTest.java
---
@@ -0,0 +1,160
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160980332
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -104,11 +122,26 @@ protected JobSubmissionResult
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160976558
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/retry/ExponentialWaitStrategy.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160979808
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/retry/ExponentialWaitStrategy.java
---
@@ -0,0 +1,45 @@
+/*
+ * Licensed
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160994352
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r160995333
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/DefaultCLI.java ---
@@ -51,45 +45,23 @@ public String getId
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5207#discussion_r160997382
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -148,6 +181,39 @@ private void submitJob(JobGraph
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159430427
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -587,9 +526,7 @@ protected int cancel(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159425958
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -274,19 +251,13 @@ protected int run(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159431758
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159429333
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -515,33 +464,28 @@ protected int stop(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159422003
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
retrieveClient
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159435504
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -292,20 +267,14 @@ protected int run(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159439656
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendStopTest.java
---
@@ -99,6 +69,44 @@ public void testStop() throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159422039
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -882,42 +784,28 @@ protected ClusterClient
retrieveClient
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5220#discussion_r159432084
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -598,189 +535,154 @@ protected int cancel(String[] args
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r159826471
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
---
@@ -936,17 +936,19 @@ private void jobStatusChanged
Github user GJL commented on the issue:
https://github.com/apache/flink/pull/5226
This PR is based on #5225
---
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159885568
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
---
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5226#discussion_r159883795
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/CliFrontendPackageProgramTest.java
---
@@ -60,220 +59,178 @@ public static void init
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5226#discussion_r159874411
--- Diff:
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -183,93 +204,43 @@ public FlinkYarnSessionCli(String shortPrefix
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159706464
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/DefaultCLITest.java ---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159703483
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -561,7 +640,7 @@ protected int cancel(String[] args) throws Exception
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159706927
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707313
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyClusterDescriptor.java
---
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159707553
--- Diff:
flink-clients/src/test/java/org/apache/flink/client/cli/util/DummyCustomCommandLine.java
---
@@ -62,12 +63,21 @@ public void addGeneralOptions
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5225#discussion_r159702188
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
@@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception
201 - 300 of 690 matches
Mail list logo
