[GitHub] incubator-hawq issue #932: HAWQ-1024. Add rollback before all necessary exit...

[wengyanqing]

Github user wengyanqing commented on the issue:

https://github.com/apache/incubator-hawq/pull/932
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #932: HAWQ-1024. Add rollback before all necessary exit...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/932
  
cc @ictmalili @zhangh43 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #932: HAWQ-1024. Add rollback before all necessa...

[xunzhang]

GitHub user xunzhang opened a pull request:

https://github.com/apache/incubator-hawq/pull/932

HAWQ-1024. Add rollback before all necessary exit.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xunzhang/incubator-hawq HAWQ-1024

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/932.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #932


commit 313639400b5a5bdf8afcb8c3123f141b580f238b
Author: xunzhang 
Date:   2016-09-23T03:23:58Z

HAWQ-1024. Add rollback before all necessary exit.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #931: HAWQ-1061. Bugfix for specific eof is zeor and ch...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/931
  
Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #930: HAWQ-1061. Ensure filepath is not regex-like.

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/930
  
Merged into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #930: HAWQ-1061. Ensure filepath is not regex-li...

[xunzhang]

Github user xunzhang closed the pull request at:

https://github.com/apache/incubator-hawq/pull/930


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #931: HAWQ-1061. Bugfix for specific eof is zeor...

[xunzhang]

Github user xunzhang closed the pull request at:

https://github.com/apache/incubator-hawq/pull/931


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80169925
  
--- Diff: tools/bin/hawqregister ---
@@ -469,8 +481,8 @@ class HawqRegister(object):
 self.filepath = self.files[0][:self.files[0].rfind('/')] if 
self.files else ''
 check_file_not_folder()
 check_database_encoding()
-if self.mode != 'force' and self.mode != 'repair':
-if not create_table():
+if self.mode != 'repair':
+if not create_table() and self.mode != 'force':
--- End diff --

I got.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80169912
  
--- Diff: tools/bin/hawqregister ---
@@ -583,7 +595,7 @@ class HawqRegister(object):
 logger.error("Files to be registered and the table are not in 
the same hdfs cluster.\nFile(s) to be registered: '%s'\nTable path in HDFS: 
'%s'." % (filepath, tabledir))
 sys.exit(1)
 
-def _get_files_in_hdfs(self, filepath):
+def _get_files_in_hdfs(self, filepath, mode):
--- End diff --

good ❤️ 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[zhangh43]

Github user zhangh43 commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80168324
  
--- Diff: tools/bin/hawqregister ---
@@ -469,8 +481,8 @@ class HawqRegister(object):
 self.filepath = self.files[0][:self.files[0].rfind('/')] if 
self.files else ''
 check_file_not_folder()
 check_database_encoding()
-if self.mode != 'force' and self.mode != 'repair':
-if not create_table():
+if self.mode != 'repair':
+if not create_table() and self.mode != 'force':
--- End diff --

Since table is created by create_table()
I think there is no need to self.mode='usage2_table_non_exist' instead of 
'force'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[zhangh43]

Github user zhangh43 commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80168200
  
--- Diff: tools/bin/hawqregister ---
@@ -469,8 +481,8 @@ class HawqRegister(object):
 self.filepath = self.files[0][:self.files[0].rfind('/')] if 
self.files else ''
 check_file_not_folder()
 check_database_encoding()
-if self.mode != 'force' and self.mode != 'repair':
-if not create_table():
+if self.mode != 'repair':
+if not create_table() and self.mode != 'force':
--- End diff --

I just want to create table if not exist in --force mode 
And if mode is --force we donot change the it
if not create_table() and self.mode != 'force':
self.mode = 'usage2_table_exist'




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80166350
  
--- Diff: tools/bin/hawqregister ---
@@ -469,8 +481,8 @@ class HawqRegister(object):
 self.filepath = self.files[0][:self.files[0].rfind('/')] if 
self.files else ''
 check_file_not_folder()
 check_database_encoding()
-if self.mode != 'force' and self.mode != 'repair':
-if not create_table():
+if self.mode != 'repair':
+if not create_table() and self.mode != 'force':
--- End diff --

A little confused here, I think handle the edge case in _init_mode() could 
be much more clear. In detail, in this case set 
self.mode='usage2_table_non_exist' instead of 'force'. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80166393
  
--- Diff: tools/bin/hawqregister ---
@@ -168,6 +175,10 @@ class GpRegisterAccessor(object):
 def get_table_existed(self, tablename):
 qry = """select count(*) from pg_class where relname = '%s';""" % 
tablename.split('.')[-1].lower()
 return self.exec_query(qry)[0]['count'] == 1
+
+def get_table_column_num(self, tablename):
--- End diff --

I like this modification here!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[zhangh43]

Github user zhangh43 commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80163629
  
--- Diff: tools/bin/hawqregister ---
@@ -583,7 +595,7 @@ class HawqRegister(object):
 logger.error("Files to be registered and the table are not in 
the same hdfs cluster.\nFile(s) to be registered: '%s'\nTable path in HDFS: 
'%s'." % (filepath, tabledir))
 sys.exit(1)
 
-def _get_files_in_hdfs(self, filepath):
+def _get_files_in_hdfs(self, filepath, mode):
--- End diff --

fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #914: HAWQ-1045. RPM updates for side by side install/u...

[ljainpivotalio]

Github user ljainpivotalio commented on the issue:

https://github.com/apache/incubator-hawq/pull/914
  
pxf-json.rpm should be part of pxf-hdfs.rpm IMHO.

LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #913: HAWQ-1048. Support OR, NOT logical operato...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/913#discussion_r80160834
  
--- Diff: src/backend/access/external/pxffilters.c ---
@@ -187,38 +208,19 @@ pxf_make_filter_list(List *quals)
{
case T_OpExpr:
{
-   OpExpr  *expr   = (OpExpr *) 
node;
-   PxfFilterDesc   *filter;
-
-   filter = (PxfFilterDesc *) 
palloc0(sizeof(PxfFilterDesc));
-   elog(DEBUG5, "pxf_make_filter_list: node tag %d 
(T_OpExpr)", tag);
-
-   if (opexpr_to_pxffilter(expr, filter))
-   result = lappend(result, filter);
-   else
-   pfree(filter);
-
+   result = lappend(result, node);
break;
}
case T_BoolExpr:
{
BoolExpr*expr = (BoolExpr *) node;
-   BoolExprType boolType = expr->boolop;
-   elog(DEBUG5, "pxf_make_filter_list: node tag %d 
(T_BoolExpr), bool node type %d %s",
-   tag, boolType, 
boolType==AND_EXPR ? "(AND_EXPR)" : "");
-
-   /* only AND_EXPR is supported */
-   if (expr->boolop == AND_EXPR)
-   {
-   List *inner_result = 
pxf_make_filter_list(expr->args);
-   elog(DEBUG5, "pxf_make_filter_list: 
inner result size %d", list_length(inner_result));
-   result = list_concat(result, 
inner_result);
-   }
+   List *inner_result = 
pxf_make_expression_items_list(expr->args);
+   result = list_concat(result, inner_result);
+   result = lappend(result, node);
break;
}
default:
-   /* expression not supported. ignore */
-   elog(DEBUG5, "pxf_make_filter_list: unsupported 
node tag %d", tag);
+   elog(DEBUG5, "pxf_make_expression_items_list: 
unsupported node tag %d", tag);
--- End diff --

lets make this DEBUG1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/914#discussion_r80146788
  
--- Diff: pxf/build.gradle ---
@@ -293,14 +316,15 @@ project('pxf-hdfs') {
 }
 
 ospackage {
+packageName = versionedPackageName("${project.name}")
 summary = 'HAWQ Extension Framework (PXF), HDFS plugin'
 description = 'Querying external data stored in HDFS'
 packager = ' '
 packageGroup = 'Development/Libraries'
 release = buildNumber() + '.' + project.osFamily
 buildHost = ' '
 
-requires('pxf-service', project.version, GREATER | EQUAL)
+requires(versionedPackageName('pxf-service'), project.version, 
GREATER | EQUAL)
 requires('hadoop', "$hadoopVersion", GREATER | EQUAL)
--- End diff --

The only decision we made was to remove dependancies on hbase and hive.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...

[shivzone]

Github user shivzone commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/914#discussion_r80146264
  
--- Diff: pxf/build.gradle ---
@@ -48,6 +48,12 @@ if (hddist != 'phd' && hddist != 'hdp') {
 throw new GradleException("hadoop distribution parameter (hd) set to 
invalid value: $hddist")
 }
 
+// Some package names need to be renamed to include the version number
+// as part of the package name to enable side by side install of two 
versions of the same package.
+def versionedPackageName(packageName) {
+packageName + "_" + "${version}".replaceAll("-", "-")
--- End diff --

My bad, will update this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...

[denalex]

Github user denalex commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/914#discussion_r80141800
  
--- Diff: pxf/build.gradle ---
@@ -48,6 +48,12 @@ if (hddist != 'phd' && hddist != 'hdp') {
 throw new GradleException("hadoop distribution parameter (hd) set to 
invalid value: $hddist")
 }
 
+// Some package names need to be renamed to include the version number
+// as part of the package name to enable side by side install of two 
versions of the same package.
+def versionedPackageName(packageName) {
+packageName + "_" + "${version}".replaceAll("-", "-")
--- End diff --

should be .replaceAll(".", "_") ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...

[denalex]

Github user denalex commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/914#discussion_r80143149
  
--- Diff: pxf/build.gradle ---
@@ -266,10 +273,7 @@ project('pxf-service') {
 into '/opt/pivotal/pxf/tomcat-templates'
--- End diff --

line 259 -- dropping pxf-service into /etc/init.d would that conflict with 
side-by-side install ? should the script inside /etc/init.d be also a symlink ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #914: HAWQ-1045. RPM updates for side by side in...

[denalex]

Github user denalex commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/914#discussion_r80143757
  
--- Diff: pxf/build.gradle ---
@@ -293,14 +316,15 @@ project('pxf-hdfs') {
 }
 
 ospackage {
+packageName = versionedPackageName("${project.name}")
 summary = 'HAWQ Extension Framework (PXF), HDFS plugin'
 description = 'Querying external data stored in HDFS'
 packager = ' '
 packageGroup = 'Development/Libraries'
 release = buildNumber() + '.' + project.osFamily
 buildHost = ' '
 
-requires('pxf-service', project.version, GREATER | EQUAL)
+requires(versionedPackageName('pxf-service'), project.version, 
GREATER | EQUAL)
 requires('hadoop', "$hadoopVersion", GREATER | EQUAL)
--- End diff --

we are still not removing hadoop- dependencies ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (HAWQ-1069) Support Kerberos and token impersonation

[Kyle R Dunn (JIRA)]

Kyle R Dunn created HAWQ-1069:
-

 Summary: Support Kerberos and token impersonation
 Key: HAWQ-1069
 URL: https://issues.apache.org/jira/browse/HAWQ-1069
 Project: Apache HAWQ
  Issue Type: Improvement
  Components: libhdfs
Reporter: Kyle R Dunn
Assignee: Lei Chang
 Fix For: backlog


Created as a carryover for [libhdfs3 Github PR 
#45|https://github.com/Pivotal-Data-Attic/pivotalrd-libhdfs3/pull/45] on behalf 
of [bdrosen96|https://github.com/bdrosen96].





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #930: HAWQ-1061. Ensure filepath is not regex-li...

[xunzhang]

GitHub user xunzhang opened a pull request:

https://github.com/apache/incubator-hawq/pull/930

HAWQ-1061. Ensure filepath is not regex-like.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/xunzhang/incubator-hawq hotfix1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/930.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #930






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...

[stanlyxiang]

Github user stanlyxiang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/928#discussion_r80054816
  
--- Diff: src/backend/resourcemanager/requesthandler.c ---
@@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg)
fts_client_ip_len = strlen(fts_client_ip);
inet_aton(fts_client_ip, _client_addr);
fts_client_host = gethostbyaddr(_client_addr, 4, AF_INET);
-   Assert(fts_client_host != NULL);
+   if (fts_client_host == NULL)
+   {
+   elog(WARNING, "Failed to reverse DNS lookup for ip %s.", 
fts_client_ip);
+   return true;
+   }
 
--- End diff --

Not quit after "reverse dns lookup" failure. This function handles the 
IMAlive message from segment resource manager process.  "return true" just 
ignore this message and do not continue the followup work after a lookup 
failure.  IP address is not enough since followup work needs the hostname.

For replace gethostbyaddr(), @jiny2 could you give some comments ? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[xunzhang]

Github user xunzhang commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/929#discussion_r80041438
  
--- Diff: tools/bin/hawqregister ---
@@ -583,7 +595,7 @@ class HawqRegister(object):
 logger.error("Files to be registered and the table are not in 
the same hdfs cluster.\nFile(s) to be registered: '%s'\nTable path in HDFS: 
'%s'." % (filepath, tabledir))
 sys.exit(1)
 
-def _get_files_in_hdfs(self, filepath):
+def _get_files_in_hdfs(self, filepath, mode):
--- End diff --

why don't you use self.mode in this function directly?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #929: HAWQ-1033. Fix bug in hawq register --forc...

[zhangh43]

GitHub user zhangh43 opened a pull request:

https://github.com/apache/incubator-hawq/pull/929

HAWQ-1033. Fix bug in hawq register --force.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zhangh43/incubator-hawq hawq10331

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/929.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #929


commit 2df377e8b9f20c4b764e99e6b2ba04fd0d9e6c25
Author: hzhang2 
Date:   2016-09-22T13:25:03Z

HAWQ-1033. Fix bug in hawq register --force.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...

[paul-guo-]

Github user paul-guo- commented on a diff in the pull request:

https://github.com/apache/incubator-hawq/pull/928#discussion_r80015438
  
--- Diff: src/backend/resourcemanager/requesthandler.c ---
@@ -627,7 +627,11 @@ bool handleRMSEGRequestIMAlive(void **arg)
fts_client_ip_len = strlen(fts_client_ip);
inet_aton(fts_client_ip, _client_addr);
fts_client_host = gethostbyaddr(_client_addr, 4, AF_INET);
-   Assert(fts_client_host != NULL);
+   if (fts_client_host == NULL)
+   {
+   elog(WARNING, "Failed to reverse DNS lookup for ip %s.", 
fts_client_ip);
+   return true;
+   }
 
--- End diff --

If it is easy to modify we could use the replacement of gethostbyaddr().
By the way, why need to quit after "reverse dns lookup" failure. Should not
an IP address work also?

DESCRIPTION
   The gethostbyname*() and gethostbyaddr*()  functions  are  obsolete. 
  Applications
   should use getaddrinfo(3) and getnameinfo(3) instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #926: HAWQ-991. Disable --repair mode and partit...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hawq/pull/926


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #926: HAWQ-991. Disable --repair mode and partiton tabl...

[ictmalili]

Github user ictmalili commented on the issue:

https://github.com/apache/incubator-hawq/pull/926
  
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #928: HAWQ-1051. Failing in reverse DNS lookup c...

[stanlyxiang]

GitHub user stanlyxiang opened a pull request:

https://github.com/apache/incubator-hawq/pull/928

HAWQ-1051. Failing in reverse DNS lookup causes resource manager core…

… dump

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyxiang/incubator-hawq reversefail

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #928


commit 0f5cec04203304c22558e89f4ce29266f4643f33
Author: stanlyxiang 
Date:   2016-09-21T15:57:27Z

HAWQ-1051. Failing in reverse DNS lookup causes resource manager core dump




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (HAWQ-1068) master process panic with signal 11 when call get_ao_compression_ratio(null)

[Ming LI (JIRA)]

[ 
https://issues.apache.org/jira/browse/HAWQ-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512444#comment-15512444
 ] 

Ming LI commented on HAWQ-1068:
---

Add check for this function:

postgres=# select get_ao_compression_ratio(null);
ERROR:  failed to get relname for this function. (aosegfiles.c:1553)
postgres=# select get_ao_compression_ratio(0);
ERROR:  failed to get valid relation id for this function. (aosegfiles.c:1575)

> master process panic with signal 11 when call get_ao_compression_ratio(null)
> 
>
> Key: HAWQ-1068
> URL: https://issues.apache.org/jira/browse/HAWQ-1068
> Project: Apache HAWQ
>  Issue Type: Bug
>  Components: Catalog
>Reporter: Ming LI
>Assignee: Lei Chang
> Fix For: backlog
>
>
> Customer has a function which will call get_ao_compression_ratio() to pass 
> the relation name dynamically. However in some corner case 
> get_ao_compression_ratio() will be passed with NULL, which triggered a signal 
> 11 and crashed the master process. 
> The issue could be easily reproduced in house as shown below:
> gpadmin=# select get_ao_compression_ratio(null);
> server closed the connection unexpectedly
>   This probably means the server terminated abnormally
>   before or while processing the request.
> The connection to the server was lost. Attempting reset: Failed.
> !> \q



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq pull request #927: HAWQ-1068. Fixed crash at calling get_ao_c...

[liming01]

GitHub user liming01 opened a pull request:

https://github.com/apache/incubator-hawq/pull/927

HAWQ-1068. Fixed crash at calling get_ao_compression_ratio(null)



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liming01/incubator-hawq mli/HAWQ-1068

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hawq/pull/927.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #927


commit 7a2de804918086016802351e891c6020335b46be
Author: Ming LI 
Date:   2016-09-22T07:17:11Z

HAWQ-1068. Fixed crash at calling get_ao_compression_ratio(null)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (HAWQ-910) "hawq register": before registration, need check the consistency between the file and HAWQ table

[Chunling Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/HAWQ-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chunling Wang updated HAWQ-910:
---
Description: 
As a user,
I can be notified that the uploading file is not consistent to the table I want 
to register to during registration
so that I can do corresponding modifications as early as possible. 
There are two situations we need to check:
1. Hawq register a single file or folder, it should check the consistent to the 
table and uploading files.
2. Hawq register a .yml file, it should check the consistent to the table (if 
the table exists), .yml file and file(s) need to move. 

  was:
As a user,
I can be notified that the uploading file is not consistent to the table I want 
to register to during registration
so that I can do corresponding modifications as early as possible.


> "hawq register": before registration, need check the consistency between the 
> file and HAWQ table
> 
>
> Key: HAWQ-910
> URL: https://issues.apache.org/jira/browse/HAWQ-910
> Project: Apache HAWQ
>  Issue Type: Sub-task
>  Components: Storage
>Reporter: Lili Ma
>Assignee: Lei Chang
> Fix For: backlog
>
>
> As a user,
> I can be notified that the uploading file is not consistent to the table I 
> want to register to during registration
> so that I can do corresponding modifications as early as possible. 
> There are two situations we need to check:
> 1. Hawq register a single file or folder, it should check the consistent to 
> the table and uploading files.
> 2. Hawq register a .yml file, it should check the consistent to the table (if 
> the table exists), .yml file and file(s) need to move. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (HAWQ-1068) master process panic with signal 11 when call get_ao_compression_ratio(null)

[Ming LI (JIRA)]

Ming LI created HAWQ-1068:
-

 Summary: master process panic with signal 11 when call 
get_ao_compression_ratio(null)
 Key: HAWQ-1068
 URL: https://issues.apache.org/jira/browse/HAWQ-1068
 Project: Apache HAWQ
  Issue Type: Bug
  Components: Catalog
Reporter: Ming LI
Assignee: Lei Chang
 Fix For: backlog


Customer has a function which will call get_ao_compression_ratio() to pass the 
relation name dynamically. However in some corner case 
get_ao_compression_ratio() will be passed with NULL, which triggered a signal 
11 and crashed the master process. 
The issue could be easily reproduced in house as shown below:
gpadmin=# select get_ao_compression_ratio(null);
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Failed.
!> \q



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-hawq issue #926: HAWQ-991. Disable --repair mode and partiton tabl...

[xunzhang]

Github user xunzhang commented on the issue:

https://github.com/apache/incubator-hawq/pull/926
  
cc @wcl14 @ictmalili 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---