[GitHub] [hbase] Apache-HBase commented on issue #713: HBASE-23152 Compaction_switch does not work by RegionServer name

2019-10-11 Thread GitBox
Apache-HBase commented on issue #713: HBASE-23152 Compaction_switch does not work by RegionServer name URL: https://github.com/apache/hbase/pull/713#issuecomment-541288677 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] Apache-HBase commented on issue #717: HBASE-23154 list_deadservers return incorrect no of rows

2019-10-11 Thread GitBox
Apache-HBase commented on issue #717: HBASE-23154 list_deadservers return incorrect no of rows URL: https://github.com/apache/hbase/pull/717#issuecomment-541288710 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] karthikhw opened a new pull request #717: HBASE-23154 list_deadservers return incorrect no of rows

2019-10-11 Thread GitBox
karthikhw opened a new pull request #717: HBASE-23154 list_deadservers return incorrect no of rows URL: https://github.com/apache/hbase/pull/717 No of rows should be equivalent to no of dead region servers but mistakenly included current system time in it.

[jira] [Created] (HBASE-23154) list_deadservers return incorrect no of rows

2019-10-11 Thread Karthik Palanisamy (Jira)
Karthik Palanisamy created HBASE-23154: -- Summary: list_deadservers return incorrect no of rows Key: HBASE-23154 URL: https://issues.apache.org/jira/browse/HBASE-23154 Project: HBase

[GitHub] [hbase] Apache-HBase commented on issue #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread GitBox
Apache-HBase commented on issue #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded URL: https://github.com/apache/hbase/pull/714#issuecomment-541283414 :broken_heart: **-1 overall** | Vote | Subsystem |

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Pattern where possible

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949896#comment-16949896 ] Hudson commented on HBASE-23093: Results for branch branch-2.1 [build #1676 on

[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949897#comment-16949897 ] Hudson commented on HBASE-23115: Results for branch branch-2.1 [build #1676 on

[jira] [Work started] (HBASE-23151) Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1

2019-10-11 Thread chenxu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23151 started by chenxu. -- > Backport HBASE-23083 (Collect Executor status info periodically and report to > metrics

[GitHub] [hbase] chenxu14 opened a new pull request #716: HBASE-23151 Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1

2019-10-11 Thread GitBox
chenxu14 opened a new pull request #716: HBASE-23151 Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1 URL: https://github.com/apache/hbase/pull/716 periodically and report to metrics system) to branch-1

[GitHub] [hbase] sunhelly opened a new pull request #715: HBASE-22940 Fix snapshot NoNode error

2019-10-11 Thread GitBox
sunhelly opened a new pull request #715: HBASE-22940 Fix snapshot NoNode error URL: https://github.com/apache/hbase/pull/715 This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (HBASE-22940) Fix snapshot NoNode error

2019-10-11 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha updated HBASE-22940: --- Summary: Fix snapshot NoNode error (was: Snapshot NoNode error) > Fix snapshot NoNode error >

[GitHub] [hbase] Apache-HBase commented on issue #711: HBASE-22738 Add fallback groups to choose RS when there are no …

2019-10-11 Thread GitBox
Apache-HBase commented on issue #711: HBASE-22738 Add fallback groups to choose RS when there are no … URL: https://github.com/apache/hbase/pull/711#issuecomment-541278064 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] chenxu14 commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-11 Thread GitBox
chenxu14 commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#discussion_r334217500 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java

[jira] [Commented] (HBASE-23107) Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-11 Thread Zheng Hu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949868#comment-16949868 ] Zheng Hu commented on HBASE-23107: -- Left few comments , please take a look. [~javaman_chen] > Avoid

[GitHub] [hbase] openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-11 Thread GitBox
openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#discussion_r334215487 ## File path:

[GitHub] [hbase] openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-11 Thread GitBox
openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#discussion_r334215958 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java

[GitHub] [hbase] openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-11 Thread GitBox
openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte array creation when doing cacheDataOnWrite URL: https://github.com/apache/hbase/pull/678#discussion_r334215650 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java

[jira] [Commented] (HBASE-22370) ByteBuf LEAK ERROR

2019-10-11 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949866#comment-16949866 ] Lijin Bin commented on HBASE-22370: --- [~zhangduo] If FanOutOneBlockAsyncDFSOutput#endBlock throw

[jira] [Updated] (HBASE-22370) ByteBuf LEAK ERROR

2019-10-11 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-22370: -- Description: We do failover test and throw a leak error, this is hard to reproduce. {code}

[jira] [Updated] (HBASE-22370) ByteBuf LEAK ERROR

2019-10-11 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin updated HBASE-22370: -- Attachment: HBASE-22370-master-v1.patch > ByteBuf LEAK ERROR > -- > >

[jira] [Assigned] (HBASE-22370) ByteBuf LEAK ERROR

2019-10-11 Thread Lijin Bin (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijin Bin reassigned HBASE-22370: - Component/s: wal rpc Assignee: Lijin Bin Summary: ByteBuf LEAK

[jira] [Commented] (HBASE-23149) hbase shouldPerformMajorCompaction logic is not correct

2019-10-11 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949864#comment-16949864 ] jackylau commented on HBASE-23149: -- Hi [~zhangduo], I read the code hbase master today and foud that it

[jira] [Comment Edited] (HBASE-23149) hbase shouldPerformMajorCompaction logic is not correct

2019-10-11 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949864#comment-16949864 ] jackylau edited comment on HBASE-23149 at 10/12/19 1:42 AM: Hi [~zhangduo],

[jira] [Comment Edited] (HBASE-23149) hbase shouldPerformMajorCompaction logic is not correct

2019-10-11 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949336#comment-16949336 ] jackylau edited comment on HBASE-23149 at 10/12/19 1:32 AM: hi [~zhangduo],

[jira] [Assigned] (HBASE-23151) Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-23151: --- Assignee: chenxu > Backport HBASE-23083 (Collect Executor status info

[jira] [Commented] (HBASE-23151) Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949858#comment-16949858 ] Andrew Kyle Purtell commented on HBASE-23151: - Thanks! > Backport HBASE-23083 (Collect

[jira] [Commented] (HBASE-23151) Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1

2019-10-11 Thread chenxu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949857#comment-16949857 ] chenxu commented on HBASE-23151: assign it to me? > Backport HBASE-23083 (Collect Executor status info

[jira] [Commented] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949856#comment-16949856 ] Andrew Kyle Purtell commented on HBASE-23153: - Done > PrimaryRegionCountSkewCostFunction

[GitHub] [hbase] apurtell commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread GitBox
apurtell commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded URL: https://github.com/apache/hbase/pull/714#discussion_r334213281 ## File path:

[jira] [Commented] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread David Manning (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949852#comment-16949852 ] David Manning commented on HBASE-23153: --- Thanks [~apurtell] for doing literally all the work. I

[GitHub] [hbase] smerkerg commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread GitBox
smerkerg commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded URL: https://github.com/apache/hbase/pull/714#discussion_r334212682 ## File path:

[GitHub] [hbase] smerkerg commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread GitBox
smerkerg commented on a change in pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded URL: https://github.com/apache/hbase/pull/714#discussion_r334212397 ## File path:

[jira] [Updated] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23153: Description: The PrimaryRegionCountSkewCostFunction SLB function should implement

[jira] [Updated] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23153: Status: Patch Available (was: Open) > PrimaryRegionCountSkewCostFunction SLB

[jira] [Commented] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949850#comment-16949850 ] Andrew Kyle Purtell commented on HBASE-23153: - Patch on PR applies everywhere >

[jira] [Commented] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949848#comment-16949848 ] Andrew Kyle Purtell commented on HBASE-23153: - Reported by [~dmanning] >

[GitHub] [hbase] apurtell opened a new pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread GitBox
apurtell opened a new pull request #714: HBASE-23153 PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded URL: https://github.com/apache/hbase/pull/714 This is an automated message from

[jira] [Updated] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-23153: Fix Version/s: 1.5.1 2.1.8 2.2.2

[jira] [Assigned] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell reassigned HBASE-23153: --- Assignee: Andrew Kyle Purtell > PrimaryRegionCountSkewCostFunction SLB

[jira] [Created] (HBASE-23153) PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded

2019-10-11 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-23153: --- Summary: PrimaryRegionCountSkewCostFunction SLB function should implement CostFunction#isNeeded Key: HBASE-23153 URL:

[GitHub] [hbase] karthikhw opened a new pull request #713: HBASE-23152 Compaction_switch does not work by RegionServer name

2019-10-11 Thread GitBox
karthikhw opened a new pull request #713: HBASE-23152 Compaction_switch does not work by RegionServer name URL: https://github.com/apache/hbase/pull/713 Compaction_switch is used to stop running compaction on regionservers. This switch works good by using "compaction_switch true/false"

[jira] [Commented] (HBASE-23152) Compaction_switch does not work by RegionServer name

2019-10-11 Thread Karthik Palanisamy (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949837#comment-16949837 ] Karthik Palanisamy commented on HBASE-23152: Please find the corresponding ref link, 

[jira] [Created] (HBASE-23152) Compaction_switch does not work by RegionServer name

2019-10-11 Thread Karthik Palanisamy (Jira)
Karthik Palanisamy created HBASE-23152: -- Summary: Compaction_switch does not work by RegionServer name Key: HBASE-23152 URL: https://issues.apache.org/jira/browse/HBASE-23152 Project: HBase

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Pattern where possible

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949797#comment-16949797 ] Hudson commented on HBASE-23093: Results for branch branch-2.2 [build #659 on

[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949798#comment-16949798 ] Hudson commented on HBASE-23115: Results for branch branch-2.2 [build #659 on

[jira] [Commented] (HBASE-23129) Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949789#comment-16949789 ] Hudson commented on HBASE-23129: Results for branch branch-2 [build #2320 on

[jira] [Commented] (HBASE-23017) [Forward-port] Verify the file integrity in persistent IOEngine

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949787#comment-16949787 ] Hudson commented on HBASE-23017: Results for branch branch-2 [build #2320 on

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Pattern where possible

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949788#comment-16949788 ] Hudson commented on HBASE-23093: Results for branch branch-2 [build #2320 on

[jira] [Commented] (HBASE-22874) Define a public interface for Canary and move existing implementation to LimitedPrivate

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949784#comment-16949784 ] Hudson commented on HBASE-22874: Results for branch branch-1.4 [build #1053 on

[jira] [Resolved] (HBASE-23127) Compile rule to avoid Optional<> params as argument of method

2019-10-11 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani resolved HBASE-23127. -- Resolution: Won't Fix As suggested by [~zhangduo], there are some places where we can use

[jira] [Created] (HBASE-23151) Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1

2019-10-11 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-23151: --- Summary: Backport HBASE-23083 (Collect Executor status info periodically and report to metrics system) to branch-1 Key: HBASE-23151 URL:

[jira] [Resolved] (HBASE-23083) Collect Executor status info periodically and report to metrics system

2019-10-11 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23083. --- Fix Version/s: 2.3.0 3.0.0 Hadoop Flags: Reviewed Resolution:

[GitHub] [hbase] saintstack merged pull request #664: HBASE-23083 Collect Executor status info periodically and report to metric system

2019-10-11 Thread GitBox
saintstack merged pull request #664: HBASE-23083 Collect Executor status info periodically and report to metric system URL: https://github.com/apache/hbase/pull/664 This is an automated message from the Apache Git Service.

[jira] [Assigned] (HBASE-23145) Remove out-of-date comments in StoreFlusher.java

2019-10-11 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack reassigned HBASE-23145: - Assignee: Oleg > Remove out-of-date comments in StoreFlusher.java >

[jira] [Commented] (HBASE-23145) Remove out-of-date comments in StoreFlusher.java

2019-10-11 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949705#comment-16949705 ] Michael Stack commented on HBASE-23145: --- I added you as a contributor [~OlegPT]. Thanks. > Remove

[jira] [Resolved] (HBASE-23145) Remove out-of-date comments in StoreFlusher.java

2019-10-11 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-23145. --- Fix Version/s: 3.0.0 Resolution: Fixed Merged. Thanks for the patch [~OlegPT] >

[GitHub] [hbase] saintstack merged pull request #709: HBASE-23145 Remove out-of-date comments in StoreFlusher.java

2019-10-11 Thread GitBox
saintstack merged pull request #709: HBASE-23145 Remove out-of-date comments in StoreFlusher.java URL: https://github.com/apache/hbase/pull/709 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [hbase] joshelser commented on a change in pull request #712: HBASE-23136

2019-10-11 Thread GitBox
joshelser commented on a change in pull request #712: HBASE-23136 URL: https://github.com/apache/hbase/pull/712#discussion_r334093821 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBulkLoadReplication.java ## @@ -232,6 +253,23 @@ public

[GitHub] [hbase] joshelser commented on a change in pull request #712: HBASE-23136

2019-10-11 Thread GitBox
joshelser commented on a change in pull request #712: HBASE-23136 URL: https://github.com/apache/hbase/pull/712#discussion_r334093600 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFiles.java ## @@ -84,6 +84,10 @@ public Path getFilePath()

[GitHub] [hbase] joshelser commented on a change in pull request #712: HBASE-23136

2019-10-11 Thread GitBox
joshelser commented on a change in pull request #712: HBASE-23136 URL: https://github.com/apache/hbase/pull/712#discussion_r334093708 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/tool/BulkLoadHFiles.java ## @@ -84,6 +84,10 @@ public Path getFilePath()

[jira] [Resolved] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser resolved HBASE-23150. Resolution: Fixed Came along to figure out why Wellington's initial patch was reverted :) I see

[jira] [Work started] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-23150 started by Wellington Chevreuil. > TestBulkLoadReplication is broken >

[GitHub] [hbase] wchevreuil opened a new pull request #712: HBASE-23136

2019-10-11 Thread GitBox
wchevreuil opened a new pull request #712: HBASE-23136 URL: https://github.com/apache/hbase/pull/712 Additional PR to address test issues introduced by having more than one test methods in TestBulkLoadReplication class. This will also amend the previous PR that had been reverted.

[jira] [Commented] (HBASE-23129) Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949584#comment-16949584 ] Michael Stack commented on HBASE-23129: --- [~psomogyi] Thanks. 2.3 and 3.0 are right places for this

[jira] [Commented] (HBASE-23093) Avoid Optional Anti-Pattern where possible

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949565#comment-16949565 ] Hudson commented on HBASE-23093: Results for branch master [build #1502 on

[jira] [Commented] (HBASE-23017) [Forward-port] Verify the file integrity in persistent IOEngine

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949563#comment-16949563 ] Hudson commented on HBASE-23017: Results for branch master [build #1502 on

[jira] [Commented] (HBASE-23144) Compact_rs throw wrong number of arguments

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949564#comment-16949564 ] Hudson commented on HBASE-23144: Results for branch master [build #1502 on

[jira] [Commented] (HBASE-23107) Avoid temp byte array creation when doing cacheDataOnWrite

2019-10-11 Thread chenxu (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949549#comment-16949549 ] chenxu commented on HBASE-23107: {quote}Ping Anoop Sam John, would you like to give a review? You have

[jira] [Commented] (HBASE-23055) Alter hbase:meta

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949491#comment-16949491 ] Hudson commented on HBASE-23055: Results for branch HBASE-23055 [build #11 on

[jira] [Resolved] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki resolved HBASE-23115. -- Resolution: Fixed > Unit change for StoreFileSize and MemStoreSize >

[jira] [Commented] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949486#comment-16949486 ] Toshihiro Suzuki commented on HBASE-23115: -- Pushed into branch-2.1 and branch-2.2. Thank you

[jira] [Updated] (HBASE-23115) Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread Toshihiro Suzuki (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toshihiro Suzuki updated HBASE-23115: - Fix Version/s: 2.1.8 2.2.2 > Unit change for StoreFileSize and

[GitHub] [hbase] brfrn169 merged pull request #710: HBASE-23115 Unit change for StoreFileSize and MemStoreSize

2019-10-11 Thread GitBox
brfrn169 merged pull request #710: HBASE-23115 Unit change for StoreFileSize and MemStoreSize URL: https://github.com/apache/hbase/pull/710 This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949477#comment-16949477 ] Wellington Chevreuil commented on HBASE-23150: -- Reverted it. Will post an amending PR on

[jira] [Commented] (HBASE-23129) Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949476#comment-16949476 ] Duo Zhang commented on HBASE-23129: --- OK it's HBASE-23091. Resolved as duplicated. > Move core to use

[jira] [Resolved] (HBASE-23091) Upgrade to hbase-thirdparty 3.1.0

2019-10-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-23091. --- Resolution: Duplicate > Upgrade to hbase-thirdparty 3.1.0 > - > >

[jira] [Assigned] (HBASE-23091) Upgrade to hbase-thirdparty 3.1.0

2019-10-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23091: - Assignee: (was: Duo Zhang) > Upgrade to hbase-thirdparty 3.1.0 >

[jira] [Commented] (HBASE-23129) Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949466#comment-16949466 ] Duo Zhang commented on HBASE-23129: --- I think I've also filed an issue for this... > Move core to use

[jira] [Commented] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949464#comment-16949464 ] Wellington Chevreuil commented on HBASE-23150: -- Failures seem to be introduced by commit 

[jira] [Commented] (HBASE-23148) Please upload the Hbase connector jar to the Maven central repository

2019-10-11 Thread Sean Busbey (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949458#comment-16949458 ] Sean Busbey commented on HBASE-23148: - Those weren't the correct maven coordinates. The only release

[jira] [Commented] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949438#comment-16949438 ] Wellington Chevreuil commented on HBASE-23150: -- Let me check on this [~psomogyi], since I

[jira] [Assigned] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wellington Chevreuil reassigned HBASE-23150: Assignee: Wellington Chevreuil > TestBulkLoadReplication is broken >

[jira] [Created] (HBASE-23150) TestBulkLoadReplication is broken

2019-10-11 Thread Peter Somogyi (Jira)
Peter Somogyi created HBASE-23150: - Summary: TestBulkLoadReplication is broken Key: HBASE-23150 URL: https://issues.apache.org/jira/browse/HBASE-23150 Project: HBase Issue Type: Bug

[jira] [Resolved] (HBASE-23129) Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi resolved HBASE-23129. --- Fix Version/s: 2.3.0 3.0.0 Resolution: Fixed Merged to master and

[jira] [Assigned] (HBASE-23129) Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi reassigned HBASE-23129: - Assignee: Michael Stack > Move core to use hbase-thirdparty-3.1.1 >

[GitHub] [hbase] Apache-HBase commented on issue #711: HBASE-22738 Fallback to default group to choose RS when there are no …

2019-10-11 Thread GitBox
Apache-HBase commented on issue #711: HBASE-22738 Fallback to default group to choose RS when there are no … URL: https://github.com/apache/hbase/pull/711#issuecomment-541052664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[jira] [Commented] (HBASE-22514) Move rsgroup feature into core of HBase

2019-10-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949407#comment-16949407 ] Hudson commented on HBASE-22514: Results for branch HBASE-22514 [build #145 on

[jira] [Commented] (HBASE-23056) Block count is 0 when BucketCache using persistent IOEngine and retrieve from file

2019-10-11 Thread HBase QA (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949405#comment-16949405 ] HBase QA commented on HBASE-23056: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[GitHub] [hbase] petersomogyi merged pull request #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread GitBox
petersomogyi merged pull request #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.1 URL: https://github.com/apache/hbase/pull/695 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] petersomogyi commented on issue #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread GitBox
petersomogyi commented on issue #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.1 URL: https://github.com/apache/hbase/pull/695#issuecomment-541036404 TestBulkLoadReplication is broken, it is on the flaky list now. Failure shouldn't be related to this change.

[jira] [Resolved] (HBASE-23017) [Forward-port] Verify the file integrity in persistent IOEngine

2019-10-11 Thread Reid Chan (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Reid Chan resolved HBASE-23017. --- Hadoop Flags: Reviewed Resolution: Fixed > [Forward-port] Verify the file integrity in

[jira] [Commented] (HBASE-23017) [Forward-port] Verify the file integrity in persistent IOEngine

2019-10-11 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949383#comment-16949383 ] Anoop Sam John commented on HBASE-23017: It should be fine for only 2.3.0 . > [Forward-port]

[jira] [Comment Edited] (HBASE-23017) [Forward-port] Verify the file integrity in persistent IOEngine

2019-10-11 Thread Anoop Sam John (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949383#comment-16949383 ] Anoop Sam John edited comment on HBASE-23017 at 10/11/19 11:28 AM: --- It

[GitHub] [hbase] Apache-HBase commented on issue #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.1

2019-10-11 Thread GitBox
Apache-HBase commented on issue #695: HBASE-23129 Move core to use hbase-thirdparty-3.1.1 URL: https://github.com/apache/hbase/pull/695#issuecomment-541023479 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment |

[GitHub] [hbase] sunhelly opened a new pull request #711: HBASE-22738 Fallback to default group to choose RS when there are no …

2019-10-11 Thread GitBox
sunhelly opened a new pull request #711: HBASE-22738 Fallback to default group to choose RS when there are no … URL: https://github.com/apache/hbase/pull/711 …RS in current group This is an automated message from the Apache

[jira] [Assigned] (HBASE-22738) Fallback to default group to choose RS when there are no RS in current group

2019-10-11 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaolin Ha reassigned HBASE-22738: -- Assignee: Xiaolin Ha > Fallback to default group to choose RS when there are no RS in

[jira] [Commented] (HBASE-22784) OldWALs not cleared in a replication slave cluster (cyclic replication bw 2 clusters)

2019-10-11 Thread Wellington Chevreuil (Jira)
[ https://issues.apache.org/jira/browse/HBASE-22784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949361#comment-16949361 ] Wellington Chevreuil commented on HBASE-22784: -- [~KarthickRam], can you open a new Jira and

[jira] [Commented] (HBASE-23149) hbase shouldPerformMajorCompaction logic is not correct

2019-10-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949357#comment-16949357 ] Duo Zhang commented on HBASE-23149: --- Assigned the issue to you. Feel free to open a PR. Thanks. >

[jira] [Assigned] (HBASE-23149) hbase shouldPerformMajorCompaction logic is not correct

2019-10-11 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-23149: - Assignee: jackylau > hbase shouldPerformMajorCompaction logic is not correct >

[jira] [Updated] (HBASE-23149) hbase shouldPerformMajorCompaction logic is not correct

2019-10-11 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated HBASE-23149: - Description: we can know that the major compaction is skipping  from the below regionserver's log, but

  1   2   >