[jira] [Updated] (HBASE-25988) Store the store file list by a file

[ https://issues.apache.org/jira/browse/HBASE-25988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25988: -- Parent Issue: HBASE-26067 (was: HBASE-24749) > Store the store file list by a file >

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874440853 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-26064) Introduce a StoreFileTrackingManager to abstract the store file tracking logic

[ https://issues.apache.org/jira/browse/HBASE-26064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-26064: -- Parent Issue: HBASE-26067 (was: HBASE-24749) > Introduce a StoreFileTrackingManager to abstract the

[jira] [Created] (HBASE-26067) Change the way on how we track store file list

Duo Zhang created HBASE-26067: - Summary: Change the way on how we track store file list Key: HBASE-26067 URL: https://issues.apache.org/jira/browse/HBASE-26067 Project: HBase Issue Type:

[GitHub] [hbase] Apache9 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

Apache9 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r664199790 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[jira] [Commented] (HBASE-25761) POC: hbase:meta,,1 as ROOT

[ https://issues.apache.org/jira/browse/HBASE-25761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375133#comment-17375133 ] Duo Zhang commented on HBASE-25761: --- I'm OK on 8AM. So it is the Thursday in China or Thursday in US?

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r664196551 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-874403672 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-874401683 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-874401039 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Comment Edited] (HBASE-26054) Fix hbase-operator-tools build with HBase 2.4.4

[ https://issues.apache.org/jira/browse/HBASE-26054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375059#comment-17375059 ] Andrew Kyle Purtell edited comment on HBASE-26054 at 7/5/21, 11:44 PM:

[jira] [Commented] (HBASE-26054) Fix hbase-operator-tools build with HBase 2.4.4

[ https://issues.apache.org/jira/browse/HBASE-26054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17375059#comment-17375059 ] Andrew Kyle Purtell commented on HBASE-26054: - Someone needs to add the spot bugs

[jira] [Commented] (HBASE-25761) POC: hbase:meta,,1 as ROOT

[ https://issues.apache.org/jira/browse/HBASE-25761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374961#comment-17374961 ] Michael Stack commented on HBASE-25761: --- [~toffer] Thanks. Lets do a call Thursday if it works for

[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for some operations

[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374959#comment-17374959 ] Michael Stack commented on HBASE-26036: --- I was going to ask how we guarantee integrity between

[GitHub] [hbase-operator-tools] virajjasani commented on pull request #90: HBASE-26054 Fix hbase-operator-tools build with HBase 2.4.4

virajjasani commented on pull request #90: URL: https://github.com/apache/hbase-operator-tools/pull/90#issuecomment-874262467 We are good to ship this I think. @z-york are you also planning to bump HBase version to 2.4.x on follow up Jira? Thanks for catching these issues. -- This

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-874261850 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26062) SIGSEGV in AsyncFSWAL consume

[ https://issues.apache.org/jira/browse/HBASE-26062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374957#comment-17374957 ] Michael Stack commented on HBASE-26062: --- {quote}...so should not be related to Scan/Lease expiry

[jira] [Commented] (HBASE-26054) Fix hbase-operator-tools build with HBase 2.4.4

[ https://issues.apache.org/jira/browse/HBASE-26054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374955#comment-17374955 ] Viraj Jasani commented on HBASE-26054: -- FYI [~apurtell] > Fix hbase-operator-tools build with

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-874258918 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] saintstack commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

saintstack commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r664071519 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java ## @@ -221,22 +223,25 @@ private boolean

[GitHub] [hbase] virajjasani edited a comment on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…

virajjasani edited a comment on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-874257535 > Do you guys face any problems? > > The master local region is not a typical table, so in general it should not be conflict with any real tables or regions. You

[GitHub] [hbase] virajjasani commented on pull request #3447: HBASE-26055 Master local region "table" should be considered a system…

virajjasani commented on pull request #3447: URL: https://github.com/apache/hbase/pull/3447#issuecomment-874257535 > Do you guys face any problems? > > The master local region is not a typical table, so in general it should not be conflict with any real tables or regions. You could

[GitHub] [hbase] Apache-HBase commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

Apache-HBase commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-874198949 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-26033) Complement admin operations in Thrift2 after HBASE-21674

[ https://issues.apache.org/jira/browse/HBASE-26033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374902#comment-17374902 ] Hudson commented on HBASE-26033: Results for branch branch-1 [build #144 on

[jira] [Commented] (HBASE-21674) Port HBASE-21652 (Refactor ThriftServer making thrift2 server inherited from thrift1 server) to branch-1

[ https://issues.apache.org/jira/browse/HBASE-21674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374903#comment-17374903 ] Hudson commented on HBASE-21674: Results for branch branch-1 [build #144 on

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-874186587 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r664000118 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-874182575 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache-HBase commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-874180818 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] catalin-luca commented on pull request #3369: [BACKPORT] HBASE-25859 Reference class incorrectly parses the protobuf magic marker

catalin-luca commented on pull request #3369: URL: https://github.com/apache/hbase/pull/3369#issuecomment-874172878 @saintstack Thanks for the build. Still seems to be failing with docker issues, though. Currently we are kind of locked on HBase 1.4 (with no plans to upgrade in

[GitHub] [hbase] wchevreuil commented on pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on pull request #3389: URL: https://github.com/apache/hbase/pull/3389#issuecomment-874170544 Thanks for the comments, @saintstack . Had addressed some, tried to explain on others. Please let me know on your extra thoughts. -- This is an automated message from the

[GitHub] [hbase] Apache9 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

Apache9 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663987253 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663979746 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectStoreCompactor.java ## @@ -0,0 +1,85 @@ +/** + *

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663979457 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DirectStoreCompactor.java ## @@ -0,0 +1,85 @@ +/** + *

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663977978 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[jira] [Assigned] (HBASE-26065) StripeStoreFileManager does not need to throw IOException for most methods

[ https://issues.apache.org/jira/browse/HBASE-26065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-26065: - Assignee: Duo Zhang > StripeStoreFileManager does not need to throw IOException for most

[jira] [Resolved] (HBASE-26065) StripeStoreFileManager does not need to throw IOException for most methods

[ https://issues.apache.org/jira/browse/HBASE-26065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-26065. --- Fix Version/s: 3.0.0-alpha-2 2.5.0 Hadoop Flags: Reviewed Resolution:

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663974669 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -533,4 +550,46 @@ protected

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663966127 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -278,6 +280,21 @@ protected final

[GitHub] [hbase] Apache9 merged pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache9 merged pull request #3459: URL: https://github.com/apache/hbase/pull/3459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [hbase] Apache9 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

Apache9 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663964357 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663958206 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -278,6 +280,21 @@ protected final

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663957101 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java ## @@ -135,7 +135,7 @@ public

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663949806 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1192,7 +1195,7 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663949806 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1192,7 +1195,7 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663947613 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -694,7 +700,7 @@ private void

[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-874071503 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-874067385 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874047514 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874046750 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874046121 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874031673 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874030324 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

Apache-HBase commented on pull request #3436: URL: https://github.com/apache/hbase/pull/3436#issuecomment-874029214 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663837361 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -431,7 +437,7 @@ public static long

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-874015177 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-874011345 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663828425 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -1372,7 +1372,7 @@ public RegionInfo getRegionInfo() {

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663781091 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663822974 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1167,7 +1170,7 @@ public StoreFileWriter

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663822333 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java ## @@ -1145,16 +1151,13 @@ public StoreFileWriter

[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-873989658 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[GitHub] [hbase] pankaj72981 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

pankaj72981 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873988222 > > IMO we should not allow empty cluster key when endpoint is HBaseInterClusterReplicationEndpoint. > > WDYT @Apache9 > > We have this check logic in

[GitHub] [hbase] mokai87 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

mokai87 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873984724 > Oh, I think this is a bad case for spotbugs, but let's fix the pattern to not trigger the spotbugs warning? > > Maybe just write > `this.clusterKey = clusterKey !=

[GitHub] [hbase] Apache-HBase commented on pull request #3117: HBASE-25709 Close region may stuck when region is compacting and skip…

Apache-HBase commented on pull request #3117: URL: https://github.com/apache/hbase/pull/3117#issuecomment-873983074 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] sunhelly commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

sunhelly commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663798510 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java ## @@ -476,6 +476,7 @@ boolean checkAndRowMutate(byte [] row,

[GitHub] [hbase] sunhelly commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

sunhelly commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663797975 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -4044,60 +4047,58 @@ private static Get toGet(final

[GitHub] [hbase] sunhelly commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

sunhelly commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663797695 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -3244,18 +3244,21 @@ private void

[GitHub] [hbase] sunhelly commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

sunhelly commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663797364 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/MultiRowMutationEndpoint.java ## @@ -221,22 +223,25 @@ private boolean

[GitHub] [hbase] Apache-HBase commented on pull request #3117: HBASE-25709 Close region may stuck when region is compacting and skip…

Apache-HBase commented on pull request #3117: URL: https://github.com/apache/hbase/pull/3117#issuecomment-873973643 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] sunhelly commented on a change in pull request #3436: HBASE-26036 DBB released too early in HRegion.get() and dirty data for some operations

sunhelly commented on a change in pull request #3436: URL: https://github.com/apache/hbase/pull/3436#discussion_r663794570 ## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBuffAllocator.java ## @@ -70,6 +71,8 @@ public static final String

[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for some operations

[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374710#comment-17374710 ] Xiaolin Ha commented on HBASE-26036: [~anoop.hbase] thanks, I'll change the patch as your advice. >

[GitHub] [hbase] Apache9 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache9 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873966447 Oh, I think this is a bad case for spotbugs, but let's fix the pattern to not trigger the spotbugs warning? Maybe just write `this.clusterKey = clusterKey != null ?

[GitHub] [hbase] Apache9 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

Apache9 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873965375 > IMO we should not allow empty cluster key when endpoint is HBaseInterClusterReplicationEndpoint. > > WDYT @Apache9 We have this check logic in

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663781334 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DirectStoreFlushContext.java ## @@ -30,14 +30,14 @@ * directly in the

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663781091 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] wchevreuil commented on a change in pull request #3389: HBASE-25392 Direct insert compacted HFiles into data directory.

wchevreuil commented on a change in pull request #3389: URL: https://github.com/apache/hbase/pull/3389#discussion_r663780661 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java ## @@ -291,12 +291,36 @@ public void

[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-873924913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-873919591 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 3m

[jira] [Updated] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-22923: - Release Note: Introduced new config: hbase.min.version.move.system.tables When the operator

[GitHub] [hbase] Apache-HBase commented on pull request #3425: HBASE-25991 Do compaction on compaction server

Apache-HBase commented on pull request #3425: URL: https://github.com/apache/hbase/pull/3425#issuecomment-873914091 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374661#comment-17374661 ] Viraj Jasani commented on HBASE-22923: -- {quote}Is this a config we will provide as part of our

[GitHub] [hbase] pankaj72981 commented on pull request #3458: HBASE-25700 Enhance znode parent validation when add_peer

pankaj72981 commented on pull request #3458: URL: https://github.com/apache/hbase/pull/3458#issuecomment-873910448 IMO we should not allow empty cluster key when endpoint is HBaseInterClusterReplicationEndpoint. WDYT @Apache9 -- This is an automated message from the Apache Git

[GitHub] [hbase] Apache-HBase commented on pull request #3117: HBASE-25709 Close region may stuck when region is compacting and skip…

Apache-HBase commented on pull request #3117: URL: https://github.com/apache/hbase/pull/3117#issuecomment-873887103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m

[jira] [Commented] (HBASE-26036) DBB released too early and dirty data for some operations

[ https://issues.apache.org/jira/browse/HBASE-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374617#comment-17374617 ] Anoop Sam John commented on HBASE-26036: In case of get calls from Client layer, the

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374610#comment-17374610 ] Anoop Sam John commented on HBASE-22923: hbase.min.version.move.system.tables Is this a config

[GitHub] [hbase] nyl3532016 commented on a change in pull request #3425: HBASE-25991 Do compaction on compaction server

nyl3532016 commented on a change in pull request #3425: URL: https://github.com/apache/hbase/pull/3425#discussion_r663703557 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/compactionserver/CompactionThreadManager.java ## @@ -19,41 +18,446 @@ package

[GitHub] [hbase] Apache-HBase commented on pull request #3459: HBASE-26065 StripeStoreFileManager does not need to throw IOException…

Apache-HBase commented on pull request #3459: URL: https://github.com/apache/hbase/pull/3459#issuecomment-873838343 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-22923) hbase:meta is assigned to localhost when we downgrade the hbase version

[ https://issues.apache.org/jira/browse/HBASE-22923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374557#comment-17374557 ] Hudson commented on HBASE-22923: Results for branch branch-2.3 [build #251 on