Apache9 commented on PR #4953:
URL: https://github.com/apache/hbase/pull/4953#issuecomment-1376839227
Please run `mvn spotless:apply` to fix the format error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/HBASE-27489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang resolved HBASE-27489.
---
Fix Version/s: 2.6.0
3.0.0-alpha-4
Hadoop Flags: Reviewed
Resolution:
Apache9 merged PR #4903:
URL: https://github.com/apache/hbase/pull/4903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Apache9 commented on code in PR #4916:
URL: https://github.com/apache/hbase/pull/4916#discussion_r1065376444
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java:
##
@@ -55,6 +55,8 @@ public class TableStateManager {
private final ConcurrentMap
Apache-HBase commented on PR #4950:
URL: https://github.com/apache/hbase/pull/4950#issuecomment-1376793679
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 47s |
Apache9 commented on PR #4950:
URL: https://github.com/apache/hbase/pull/4950#issuecomment-1376786909
So the problem here is that, if the table is disabled, we will skip checking
but in the old code, we will still record the previous region info, so the
check for the previous table's last
Apache-HBase commented on PR #4952:
URL: https://github.com/apache/hbase/pull/4952#issuecomment-1376732447
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 15s |
EungsopYoo commented on PR #4942:
URL: https://github.com/apache/hbase/pull/4942#issuecomment-1376732392
@Apache9
This PR does not close the warmed up region. It just closes the store file
reader in the region.
--
This is an automated message from the Apache Git Service.
To respond
Apache-HBase commented on PR #4952:
URL: https://github.com/apache/hbase/pull/4952#issuecomment-1376728213
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #4953:
URL: https://github.com/apache/hbase/pull/4953#issuecomment-1376689380
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 20s |
curie71 commented on PR #4951:
URL: https://github.com/apache/hbase/pull/4951#issuecomment-1376685476
>
I see, so the AccessChecker log access deny/allow at warn/info level may
solve the log duplication problems?
--
This is an automated message from the Apache Git Service.
To
Apache9 commented on PR #4951:
URL: https://github.com/apache/hbase/pull/4951#issuecomment-1376675022
So the intention here is that, only if we have already enabled
AccessChecker, calling grant and revoke is useful?
AccessChecker is a coprocessor, so we will not always enable it.
--
Apache-HBase commented on PR #4950:
URL: https://github.com/apache/hbase/pull/4950#issuecomment-1376672187
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
dongjoon-hyun commented on PR #4953:
URL: https://github.com/apache/hbase/pull/4953#issuecomment-1376642686
Could you review this, @ndimiduk ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dongjoon-hyun opened a new pull request, #4953:
URL: https://github.com/apache/hbase/pull/4953
This PR aims to publish SBOM artifacts along with the other Apache projects.
- https://cwiki.apache.org/confluence/display/COMDEV/SBOM
Here is an article to give some context.
-
Dongjoon Hyun created HBASE-27562:
-
Summary: Publish SBOM artifacts
Key: HBASE-27562
URL: https://issues.apache.org/jira/browse/HBASE-27562
Project: HBase
Issue Type: Improvement
Apache-HBase commented on PR #4952:
URL: https://github.com/apache/hbase/pull/4952#issuecomment-1376613001
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 22s |
apurtell commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1065100096
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java:
##
@@ -166,6 +169,16 @@ public void call(RegionServerObserver
apurtell commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1065100096
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java:
##
@@ -166,6 +169,16 @@ public void call(RegionServerObserver
Apache-HBase commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1376570352
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 12s |
[
https://issues.apache.org/jira/browse/HBASE-27561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-27561:
Description:
Setting of hbase.master.port is ignored in default processing of
[
https://issues.apache.org/jira/browse/HBASE-27561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Kyle Purtell updated HBASE-27561:
Status: Patch Available (was: Open)
> hbase.master.port is ignored in processing
apurtell opened a new pull request, #4952:
URL: https://github.com/apache/hbase/pull/4952
Setting of hbase.master.port is ignored in default processing of
hbase.masters.
For example,
hbase.masters=localhost
hbase.master.port=8100
"Server at localhost:16000"
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376553921
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 40s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376551643
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 41s |
Andrew Kyle Purtell created HBASE-27561:
---
Summary: hbase.master.port is ignored in processing of
hbase.masters
Key: HBASE-27561
URL: https://issues.apache.org/jira/browse/HBASE-27561
Project:
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376543516
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 0s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376513501
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 2m 10s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376504667
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376504764
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 0s |
Apache-HBase commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1376483276
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 24s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376480439
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 3s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376468127
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 59s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376467818
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 45s |
jarrydlee commented on code in PR #4933:
URL: https://github.com/apache/hbase/pull/4933#discussion_r1065187059
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java:
##
@@ -69,6 +69,12 @@ public RestoreTablesClient(Connection conn,
bbeaudreault commented on code in PR #4933:
URL: https://github.com/apache/hbase/pull/4933#discussion_r1065180780
##
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreJob.java:
##
@@ -32,12 +33,13 @@
public interface RestoreJob extends Configurable {
/**
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376439190
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 25s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376438518
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 4m 59s |
Apache-HBase commented on PR #4933:
URL: https://github.com/apache/hbase/pull/4933#issuecomment-1376438235
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 25s |
rmdmattingly commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1065148860
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -1072,6 +1077,22 @@ public static ClientProtos.Scan toScan(final Scan
Apache-HBase commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1376333162
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 44s |
apurtell commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1065102733
##
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationWithWALExtendedAttributes.java:
##
@@ -0,0 +1,295 @@
+/*
+ * Licensed to the Apache
apurtell commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1065100096
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java:
##
@@ -166,6 +169,16 @@ public void call(RegionServerObserver
apurtell commented on code in PR #4924:
URL: https://github.com/apache/hbase/pull/4924#discussion_r1065100096
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionServerCoprocessorHost.java:
##
@@ -166,6 +169,16 @@ public void call(RegionServerObserver
Apache-HBase commented on PR #4951:
URL: https://github.com/apache/hbase/pull/4951#issuecomment-1376187433
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 7s |
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1376176703
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1376169755
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1375911408
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 45s |
Apache-HBase commented on PR #4951:
URL: https://github.com/apache/hbase/pull/4951#issuecomment-1375892379
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 17s |
[
https://issues.apache.org/jira/browse/HBASE-27525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Beibei Zhao updated HBASE-27525:
Summary: AccessChecker records auditlog at trace level, while RPCServices
record allow at info,
[
https://issues.apache.org/jira/browse/HBASE-27525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Beibei Zhao updated HBASE-27525:
Issue Type: Improvement (was: Bug)
> AccessChecker records auditlog at trace level, while
[
https://issues.apache.org/jira/browse/HBASE-27554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656153#comment-17656153
]
Duo Zhang commented on HBASE-27554:
---
Thanks [~psomogyi] for fixing this!
> Test failures on
Apache-HBase commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1375781194
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 32s |
bbeaudreault commented on code in PR #4770:
URL: https://github.com/apache/hbase/pull/4770#discussion_r1064748623
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##
@@ -254,16 +255,19 @@ public void write(ImmutableBytesWritable row, V
curie71 opened a new pull request, #4951:
URL: https://github.com/apache/hbase/pull/4951
[HBASE-27528](https://issues.apache.org/jira/browse/HBASE-27528)
MasterRpcServices record audit log in privileged operations **(grant, revoke)**.
```java
public RevokeResponse
rda3mon commented on code in PR #4770:
URL: https://github.com/apache/hbase/pull/4770#discussion_r1064711670
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##
@@ -254,16 +255,19 @@ public void write(ImmutableBytesWritable row, V
rda3mon commented on code in PR #4770:
URL: https://github.com/apache/hbase/pull/4770#discussion_r1064711670
##
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java:
##
@@ -254,16 +255,19 @@ public void write(ImmutableBytesWritable row, V
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1375711891
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1375705066
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s |
Apache-HBase commented on PR #4950:
URL: https://github.com/apache/hbase/pull/4950#issuecomment-1375701241
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 38s |
Apache-HBase commented on PR #4950:
URL: https://github.com/apache/hbase/pull/4950#issuecomment-1375696939
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 47s |
bbeaudreault commented on code in PR #4940:
URL: https://github.com/apache/hbase/pull/4940#discussion_r1064690832
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -426,6 +426,8 @@ private boolean nextInternal(List results,
Apache-HBase commented on PR #4950:
URL: https://github.com/apache/hbase/pull/4950#issuecomment-1375696417
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 22s |
bbeaudreault commented on code in PR #4940:
URL: https://github.com/apache/hbase/pull/4940#discussion_r1064658796
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -426,6 +426,8 @@ private boolean nextInternal(List results,
comnetwork commented on code in PR #4940:
URL: https://github.com/apache/hbase/pull/4940#discussion_r1064654921
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -426,6 +426,8 @@ private boolean nextInternal(List results,
bbeaudreault commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1064648281
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -1072,6 +1077,22 @@ public static ClientProtos.Scan toScan(final Scan
bbeaudreault commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1064644139
##
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##
@@ -1072,6 +1077,22 @@ public static ClientProtos.Scan toScan(final Scan
bbeaudreault commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1064639625
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/OnlineLogRecord.java:
##
@@ -261,15 +311,17 @@ public boolean equals(Object o) {
Leo89 created HBASE-27560:
-
Summary: CatalogJanitor consistencyCheck cannot report the hole on
last region if next table is disabled in meta
Key: HBASE-27560
URL: https://issues.apache.org/jira/browse/HBASE-27560
Apache-HBase commented on PR #4940:
URL: https://github.com/apache/hbase/pull/4940#issuecomment-1375505602
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 43s |
Apache-HBase commented on PR #4945:
URL: https://github.com/apache/hbase/pull/4945#issuecomment-1375469315
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 59s |
[
https://issues.apache.org/jira/browse/HBASE-27554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi resolved HBASE-27554.
---
Resolution: Fixed
Recent nightly tests were successful on branch-2.4 after the cleanup.
>
wchevreuil commented on code in PR #4945:
URL: https://github.com/apache/hbase/pull/4945#discussion_r1064492323
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/TransitRegionStateProcedure.java:
##
@@ -107,6 +108,20 @@
private static final Logger LOG
Apache-HBase commented on PR #4949:
URL: https://github.com/apache/hbase/pull/4949#issuecomment-1375329347
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 37s |
74 matches
Mail list logo
