[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15578538#comment-15578538
]
Edward Bortnikov commented on HBASE-14920:
--
Opened the doc for commenting, thanks for suggesting
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576985#comment-15576985
]
stack commented on HBASE-14920:
---
You might want to open the doc up for comments [~ebortnik]
I love the
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15574866#comment-15574866
]
Edward Bortnikov commented on HBASE-14920:
--
Good catch [~devaraj]. We've started working on a
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15295576#comment-15295576
]
Eshcar Hillel commented on HBASE-14920:
---
Thank you [~ram_krish] [~anoop.hbase] and [~stack] for
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293539#comment-15293539
]
Hudson commented on HBASE-14920:
FAILURE: Integrated in HBase-Trunk_matrix #935 (See
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293150#comment-15293150
]
stack commented on HBASE-14920:
---
I pushed the patch. Thanks for the mighty work [~eshcar] (and [~anastas])
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293147#comment-15293147
]
stack commented on HBASE-14920:
---
[~anastas] or [~eshcar], you have any feedback on [~ram_krish]'s notes
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15293054#comment-15293054
]
Edward Bortnikov commented on HBASE-14920:
--
[~ram_krish] absolutely documentation is super
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290994#comment-15290994
]
ramkrishna.s.vasudevan commented on HBASE-14920:
Thanks for the great work. I have just
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290925#comment-15290925
]
Edward Bortnikov commented on HBASE-14920:
--
+1 for [~anastas] and myself - reviewed internally.
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290550#comment-15290550
]
ramkrishna.s.vasudevan commented on HBASE-14920:
[~saint@gmail.com]
By today or
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290502#comment-15290502
]
stack commented on HBASE-14920:
---
+1 from me (Skimmed the new patch. Good cleanup). [~anoop.hbase] I'll
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284779#comment-15284779
]
Eshcar Hillel commented on HBASE-14920:
---
[~anoop.hbase] the FlushNonSloppyStoresFirstPolicy first
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284725#comment-15284725
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284637#comment-15284637
]
Anoop Sam John commented on HBASE-14920:
I see. my bad eyes.. Saw it is in
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284458#comment-15284458
]
Eshcar Hillel commented on HBASE-14920:
---
The ThreadPoolExecutor is static so it is not one per
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284426#comment-15284426
]
Anoop Sam John commented on HBASE-14920:
I agree.. Let us get this in first..Big patch. It will
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284425#comment-15284425
]
Anoop Sam John commented on HBASE-14920:
Mainly gone through changed files this time. On the new
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15284365#comment-15284365
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280253#comment-15280253
]
Anoop Sam John commented on HBASE-14920:
Yes me too want it to be in asap.. We need this feature
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15280216#comment-15280216
]
Edward Bortnikov commented on HBASE-14920:
--
[anoop.hbase], you have a point. The whole space of
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15279191#comment-15279191
]
stack commented on HBASE-14920:
---
On the latter [~anoop.hbase], there is a new flush policy which will pick
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277940#comment-15277940
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277864#comment-15277864
]
Anoop Sam John commented on HBASE-14920:
Did not go through the latest patch..
So it will work
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15276076#comment-15276076
]
Eshcar Hillel commented on HBASE-14920:
---
There are two distinct issues here.
bq. dont you think
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275404#comment-15275404
]
stack commented on HBASE-14920:
---
Here is an attempt at addressing [~anoop.hbase] concern that in-memory
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15275363#comment-15275363
]
Edward Bortnikov commented on HBASE-14920:
--
[~anoop.hbase], would it help if we added a
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272754#comment-15272754
]
Anoop Sam John commented on HBASE-14920:
So how will it behave when system call region flush
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272694#comment-15272694
]
stack commented on HBASE-14920:
---
I went over page #1 of the patch and skimmed page #2. Left some comments.
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272631#comment-15272631
]
stack commented on HBASE-14920:
---
Good point. Any input here [~eshcar] since you deep in here? Could be a
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272626#comment-15272626
]
stack commented on HBASE-14920:
---
bq. If we only consider the second case and flush the entire content to
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271643#comment-15271643
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271382#comment-15271382
]
Eshcar Hillel commented on HBASE-14920:
---
A core property of the new in-memory flush and compaction
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268971#comment-15268971
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268737#comment-15268737
]
Anoop Sam John commented on HBASE-14920:
bq.None of the counters (RS, region, segment) are new,
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268734#comment-15268734
]
Anoop Sam John commented on HBASE-14920:
IMHO, when a user calls to flush a region, all the cells
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267896#comment-15267896
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267488#comment-15267488
]
Eshcar Hillel commented on HBASE-14920:
---
New patch is available. Also available in RB
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15258689#comment-15258689
]
stack commented on HBASE-14920:
---
Unused import import static
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257222#comment-15257222
]
Ted Yu commented on HBASE-14920:
Can review board be updated ?
When I clicked Download,
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253879#comment-15253879
]
Anoop Sam John commented on HBASE-14920:
After an in memory flush, we will reduce some heap
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253829#comment-15253829
]
Anoop Sam John commented on HBASE-14920:
bq.public final static double
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252522#comment-15252522
]
Edward Bortnikov commented on HBASE-14920:
--
Just a remark - finishing this JIRA will expedite
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250093#comment-15250093
]
stack commented on HBASE-14920:
---
I was going to say the same, is it an executor per region?
Static is
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250068#comment-15250068
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248177#comment-15248177
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245493#comment-15245493
]
Eshcar Hillel commented on HBASE-14920:
---
Well, now that you ask - one pool per region seems a
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245400#comment-15245400
]
Anoop Sam John commented on HBASE-14920:
Excellent. Ya Specially when the key and/or value size
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245390#comment-15245390
]
Eshcar Hillel commented on HBASE-14920:
---
Working on the patch.
Following some recent benchmarks we
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219986#comment-15219986
]
stack commented on HBASE-14920:
---
[~eshcar] I suggested changing stopCompact to stopCompacting, etc. Don't
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219648#comment-15219648
]
Eshcar Hillel commented on HBASE-14920:
---
OK, thanks [~anoop.hbase] for clarifying this.
I will
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219456#comment-15219456
]
Anoop Sam John commented on HBASE-14920:
Ya it is clear now why need the seqId update after in
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219382#comment-15219382
]
Eshcar Hillel commented on HBASE-14920:
---
I recently updated YCSB to support also delete operations.
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218533#comment-15218533
]
Anoop Sam John commented on HBASE-14920:
So in memory flush will move the cur active segment
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218326#comment-15218326
]
Anoop Sam John commented on HBASE-14920:
{code}
// The scanner is doing all the elimination logic
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218312#comment-15218312
]
Anoop Sam John commented on HBASE-14920:
BTW , when in memory flush or compaction happens,
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218305#comment-15218305
]
Anoop Sam John commented on HBASE-14920:
The in memory compaction is happening by scanning the
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218149#comment-15218149
]
ramkrishna.s.vasudevan commented on HBASE-14920:
Printing the cell would be helpful to
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15218098#comment-15218098
]
stack commented on HBASE-14920:
---
bq. which reside in a segment and have very small sequence id (e.g.,
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217973#comment-15217973
]
Eshcar Hillel commented on HBASE-14920:
---
Hi,
[~stack] I will get back with answers to your
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217314#comment-15217314
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216864#comment-15216864
]
stack commented on HBASE-14920:
---
s/startCompact/startCompaction/g
s/doCompact/doCompaction/g
No need of
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216812#comment-15216812
]
stack commented on HBASE-14920:
---
I see/remember why the isCompactingMemStore method. Makes sense. Make it
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216720#comment-15216720
]
stack commented on HBASE-14920:
---
I like the notion of a 'CompactionMemStore' instead of a plain old
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212981#comment-15212981
]
stack commented on HBASE-14920:
---
A few notes on the patch
Is the comment right when it says we are going
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204210#comment-15204210
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-14920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203346#comment-15203346
]
Hadoop QA commented on HBASE-14920:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
67 matches
Mail list logo
