[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-02 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142033#comment-13142033 ] Hudson commented on HBASE-1744: --- Integrated in HBase-TRUNK #2399 (See

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-02 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142197#comment-13142197 ] Ted Yu commented on HBASE-1744: --- From

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-02 Thread Hudson (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13142209#comment-13142209 ] Hudson commented on HBASE-1744: --- Integrated in HBase-TRUNK #2400 (See

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Tim Sell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141613#comment-13141613 ] Tim Sell commented on HBASE-1744: - I don't think the patch is getting submitted to

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141648#comment-13141648 ] Ted Yu commented on HBASE-1744: --- @Tim: HadoopQA won't recognize patch v9 which requires -p1

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141793#comment-13141793 ] Hadoop QA commented on HBASE-1744: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141799#comment-13141799 ] Ted Yu commented on HBASE-1744: --- @Tim: Do you want to take care of the following ? {code}

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Hadoop QA (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141855#comment-13141855 ] Hadoop QA commented on HBASE-1744: -- -1 overall. Here are the results of testing the

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141860#comment-13141860 ] Ted Yu commented on HBASE-1744: --- Failed tested were caused by 'Too many open files'

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141902#comment-13141902 ] stack commented on HBASE-1744: -- +1 on commit to TRUNK. Thrift server to

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-11-01 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13141911#comment-13141911 ] Ted Yu commented on HBASE-1744: --- Integrated to TRUNK. Thanks for the patch, Lars and Tim.

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-28 Thread Jonathan Gray (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138740#comment-13138740 ] Jonathan Gray commented on HBASE-1744: -- One more requested change. Over in

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-28 Thread Tim Sell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13138751#comment-13138751 ] Tim Sell commented on HBASE-1744: - I think that should be a follow up issue to this rather

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-12 Thread stack (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126051#comment-13126051 ] stack commented on HBASE-1744: -- Fancy, you have democlient for thrift2 too! Thanks for

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-12 Thread Tim Sell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126065#comment-13126065 ] Tim Sell commented on HBASE-1744: - Well, Lars did a lot of the work and deserves credit,

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-12 Thread Bob Copeland (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13126202#comment-13126202 ] Bob Copeland commented on HBASE-1744: - +1 from me. Just tested with latest patch on

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-10 Thread Bob Copeland (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124482#comment-13124482 ] Bob Copeland commented on HBASE-1744: - I think it would be useful to take care of this

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-10 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13124663#comment-13124663 ] Ted Yu commented on HBASE-1744: --- @Bob: Can you combine your patch with Tim's patch v7 ?

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-08 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123531#comment-13123531 ] Ted Yu commented on HBASE-1744: --- +1 on patch v7. Thrift server to match

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-07 Thread Tim Sell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122938#comment-13122938 ] Tim Sell commented on HBASE-1744: - Is run the HBase Thrift2 server ok? What do you mean

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122947#comment-13122947 ] Ted Yu commented on HBASE-1744: --- run the HBase Thrift2 server is fine. By experience, usage

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-07 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13123254#comment-13123254 ] Ted Yu commented on HBASE-1744: --- src/examples/thrift2/DemoClient.java needs license.

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-06 Thread Tim Sell (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121851#comment-13121851 ] Tim Sell commented on HBASE-1744: - Thanks Bob, my patch still doesn't have tests, looking

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122048#comment-13122048 ] Ted Yu commented on HBASE-1744: --- I applied patch v4 and got the following:

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-06 Thread Ted Yu (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13122083#comment-13122083 ] Ted Yu commented on HBASE-1744: --- TestThriftHBaseServiceHandler passed for patch v5. Can we

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-05 Thread Bob Copeland (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121512#comment-13121512 ] Bob Copeland commented on HBASE-1744: - Hi, I put some fixes for the above issues Ted

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-10-05 Thread Bob Copeland (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13121698#comment-13121698 ] Bob Copeland commented on HBASE-1744: - Also, seems checkAndPut() should allow

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084614#comment-13084614 ] Ted Yu commented on HBASE-1744: --- I made ThriftServer package private so that the test

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-08-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13084616#comment-13084616 ] Ted Yu commented on HBASE-1744: --- TestThriftServer.testAll() is commented out. Same with the

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-08-08 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13081208#comment-13081208 ] Ted Yu commented on HBASE-1744: --- Sorry to get back to this so late. I got the following:

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-06-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056883#comment-13056883 ] Ted Yu commented on HBASE-1744: --- @Tim, any update ? Thrift server to match the new java

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-06-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054029#comment-13054029 ] Ted Yu commented on HBASE-1744: --- I tried to apply latest patch on TRUNK. It doesn't compile:

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-06-23 Thread Tim Sell (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054036#comment-13054036 ] Tim Sell commented on HBASE-1744: - I have been working on this, continuing work I did at

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-04-26 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13025153#comment-13025153 ] Lars Francke commented on HBASE-1744: -

[jira] [Commented] (HBASE-1744) Thrift server to match the new java api.

2011-04-26 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13025249#comment-13025249 ] stack commented on HBASE-1744: -- @Lars Some fellas figured it ahead of you (smile). See

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2011-03-14 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13006375#comment-13006375 ] Lars Francke commented on HBASE-1744: - I'm afraid I will finally have to say that I

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2011-02-14 Thread ryan rawson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12994573#comment-12994573 ] ryan rawson commented on HBASE-1744: talking about this recently with stack, I made

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-12-07 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12968988#action_12968988 ] stack commented on HBASE-1744: -- @Lars Any chance of your updating this patch? I'd like to get

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-10-18 Thread Bryan Duxbury (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12922173#action_12922173 ] Bryan Duxbury commented on HBASE-1744: -- Stack asked me to take a look at your Thrift

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-10-17 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921845#action_12921845 ] Lars Francke commented on HBASE-1744: - {quote}So, you are going to have a thrift2

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-10-17 Thread ryan rawson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921920#action_12921920 ] ryan rawson commented on HBASE-1744: i would be against the thrift2 and package moving

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-10-17 Thread Lars Francke (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921924#action_12921924 ] Lars Francke commented on HBASE-1744: - Services can extend each other so I can - in

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-10-16 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12921787#action_12921787 ] stack commented on HBASE-1744: -- So, you are going to have a thrift2 package for the new stuff.

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-10-05 Thread Jonathan Gray (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12918211#action_12918211 ] Jonathan Gray commented on HBASE-1744: -- Lars, what's time estimate for this? Should

[jira] Commented: (HBASE-1744) Thrift server to match the new java api.

2010-08-27 Thread Jean-Daniel Cryans (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903511#action_12903511 ] Jean-Daniel Cryans commented on HBASE-1744: --- I don't know if it's on your list