[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations

jerryshao commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations URL: https://github.com/apache/incubator-iceberg/pull/395#discussion_r315498411 ## File path:

[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations

jerryshao commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations URL: https://github.com/apache/incubator-iceberg/pull/395#discussion_r315483176 ## File path:

[GitHub] [incubator-iceberg] rdblue closed issue #269: Fix BaseTableScan to include column_sizes in stats columns

rdblue closed issue #269: Fix BaseTableScan to include column_sizes in stats columns URL: https://github.com/apache/incubator-iceberg/issues/269 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-iceberg] rdblue merged pull request #393: include column_sizes in stats columns

rdblue merged pull request #393: include column_sizes in stats columns URL: https://github.com/apache/incubator-iceberg/pull/393 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-iceberg] rdblue commented on issue #393: include column_sizes in stats columns

rdblue commented on issue #393: include column_sizes in stats columns URL: https://github.com/apache/incubator-iceberg/pull/393#issuecomment-522805147 Looks great, thanks for fixing this @manishmalhotrawork! This is an

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog

rdblue commented on a change in pull request #362: Support create and replace transactions in Catalog URL: https://github.com/apache/incubator-iceberg/pull/362#discussion_r315465619 ## File path: hive/src/test/java/org/apache/iceberg/hive/HiveCreateReplaceTableTest.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315464699 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315464625 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315464103 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315464206 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315463778 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315463525 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315463525 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315462678 ## File path: core/src/main/java/org/apache/iceberg/OverwriteData.java

[GitHub] [incubator-iceberg] manishmalhotrawork commented on issue #193: Support Page Skipping in Iceberg Parquet Reader

manishmalhotrawork commented on issue #193: Support Page Skipping in Iceberg Parquet Reader URL: https://github.com/apache/incubator-iceberg/issues/193#issuecomment-522801245 @aokolnychyi this is interesting. is this still valid ?

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315462125 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

rdblue commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315461591 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java

[GitHub] [incubator-iceberg] rdblue commented on issue #279: Transforming timestamp to date should produce date

rdblue commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522800271 > can you point me to any other test-case or code path, where [getResultType] is being used can be verified. There

[GitHub] [incubator-iceberg] manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date

manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522798222 @rdblue quick questions. 1. while validating my changes, didn't see that transfor.getResultType is

[GitHub] [incubator-iceberg] danielcweeks merged pull request #381: [python]Bringing expression implementations back into synchronization

danielcweeks merged pull request #381: [python]Bringing expression implementations back into synchronization URL: https://github.com/apache/incubator-iceberg/pull/381 This is an automated message from the Apache Git

[GitHub] [incubator-iceberg] danielcweeks merged pull request #382: [python]Bringing type module into sync

danielcweeks merged pull request #382: [python]Bringing type module into sync URL: https://github.com/apache/incubator-iceberg/pull/382 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-iceberg] manishmalhotrawork commented on issue #393: include column_sizes in stats columns

manishmalhotrawork commented on issue #393: include column_sizes in stats columns URL: https://github.com/apache/incubator-iceberg/pull/393#issuecomment-522790993 @rdblue please see, if we can merge it. thanks ! This is an

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table

aokolnychyi commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r315169933 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table

chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r315162272 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations

aokolnychyi commented on a change in pull request #395: Remove Hadoop Configuration dependency in BaseMetastoreTableOperations URL: https://github.com/apache/incubator-iceberg/pull/395#discussion_r315155798 ## File path:

[GitHub] [incubator-iceberg] chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table

chenjunjiedada commented on a change in pull request #374: Migrate spark table to iceberg table URL: https://github.com/apache/incubator-iceberg/pull/374#discussion_r315150212 ## File path: spark/src/main/scala/org/apache/iceberg/spark/SparkTableUtil.scala ## @@ -297,5

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315093153 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315093153 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315093153 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java

[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes

aokolnychyi commented on a change in pull request #351: Extend Iceberg with a way to overwrite files for eager updates/deletes URL: https://github.com/apache/incubator-iceberg/pull/351#discussion_r315093153 ## File path: api/src/main/java/org/apache/iceberg/OverwriteFiles.java