[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373703 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java ## @@ -362,4 +368,197 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373662 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java ## @@ -362,4 +368,197 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373638 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java ## @@ -362,4 +368,197 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373623 ## File path: api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java ## @@ -362,4 +368,197 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373269 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java ## @@ -19,19

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373153 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +149,40 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373107 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +149,40 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317373006 ## File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java ## @@ -39,37 +37,35 @@ public R

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317372831 ## File path: api/src/main/java/org/apache/iceberg/expressions/BoundSetPredicate.java ## @@ -0,0 +1,176 @@ +/* +

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317372784 ## File path: api/src/main/java/org/apache/iceberg/expressions/BoundSetPredicate.java ## @@ -0,0 +1,176 @@ +/* +

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317372657 ## File path: api/src/main/java/org/apache/iceberg/expressions/BoundSetPredicate.java ## @@ -0,0 +1,176 @@ +/* +

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r317372625 ## File path: api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java ## @@ -51,6 +53,10 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314875570 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +154,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314873793 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +180,65 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314869628 ## File path: api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java ## @@ -49,21 +50,22 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314868900 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,140 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314867459 ## File path: api/src/main/java/org/apache/iceberg/expressions/Binder.java ## @@ -140,6 +140,11 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314831880 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java ## @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314831740 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314831603 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314830695 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ## @@ -109,6 +110,26 @@ public T

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r314830563 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313978735 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313978864 ## File path: api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java ## @@ -246,12

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313970266 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java ## @@ -330,12

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313970180 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java ## @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313966518 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +154,38 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313964026 ## File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java ## @@ -19,15 +19,49 @@ package

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313963715 ## File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java ## @@ -19,15 +19,49 @@ package

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313963009 ## File path: api/src/main/java/org/apache/iceberg/expressions/ManifestEvaluator.java ## @@ -245,12 +245,12 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313961855 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313961395 ## File path: api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java ## @@ -89,12 +93,12 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313961073 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ## @@ -109,6 +110,26 @@ public T

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313959744 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313959518 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313958393 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313957904 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313957552 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,212 @@ +/* + *

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313633929 ## File path: api/src/main/java/org/apache/iceberg/expressions/Evaluator.java ## @@ -134,18 +134,18 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313499455 ## File path: api/src/main/java/org/apache/iceberg/expressions/Evaluator.java ## @@ -134,18 +134,18 @@ public

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313498614 ## File path: api/src/main/java/org/apache/iceberg/expressions/Predicate.java ## @@ -19,15 +19,44 @@ package

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313093437 ## File path: api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java ## @@ -89,11 +91,11 @@

[GitHub] [incubator-iceberg] rdblue commented on a change in pull request #357: Add in and not in predicates

rdblue commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r313093251 ## File path: api/src/main/java/org/apache/iceberg/expressions/Evaluator.java ## @@ -134,13 +135,13 @@ public