jfrazee opened a new pull request #4479:
URL: https://github.com/apache/nifi/pull/4479
Description of PR
This changes the noLocal flag on the JMS consumer to false. It was
previously being set to true for all Topic destinations which is unnecessary
and breaks with some brokers.
jfrazee commented on pull request #4460:
URL: https://github.com/apache/nifi/pull/4460#issuecomment-673723245
@joewitt @MikeThomsen Can I suggest that this be a build arg in the
Dockerfile (they can be used in a FROM) and a property in the pom? That'd make
the build pretty flexible and let
joewitt commented on pull request #4321:
URL: https://github.com/apache/nifi/pull/4321#issuecomment-673707607
this needs to be rebased against the lastest 'main'. Master is no longer
being used.
and please use a far smaller test file. We have too many of these 1MB test
files and th
bbende commented on a change in pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#discussion_r470210095
##
File path:
nifi-registry-core/nifi-registry-web-ui/src/main/java/org/apache/nifi/registry/web/filter/LogoutFilter.java
##
@@ -0,0 +1,56 @@
+/*
+ *
mattyb149 commented on a change in pull request #3735:
URL: https://github.com/apache/nifi/pull/3735#discussion_r470234851
##
File path:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi/t
[
https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177310#comment-17177310
]
ASF subversion and git services commented on NIFI-7692:
---
Commit fb57
[
https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177309#comment-17177309
]
ASF subversion and git services commented on NIFI-7692:
---
Commit 303d
[
https://issues.apache.org/jira/browse/MINIFICPP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpad Boda updated MINIFICPP-1333:
--
Labels: selected-for-development (was: )
> PublishKafka should penalize flowfiles sent to
arpadboda commented on a change in pull request #872:
URL: https://github.com/apache/nifi-minifi-cpp/pull/872#discussion_r470218080
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -701,6 +701,7 @@ void PublishKafka::onTrigger(const
std::shared_ptr &contex
if (s
szaszm commented on a change in pull request #872:
URL: https://github.com/apache/nifi-minifi-cpp/pull/872#discussion_r470211664
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -701,6 +701,7 @@ void PublishKafka::onTrigger(const
std::shared_ptr &contex
if (succ
[
https://issues.apache.org/jira/browse/NIFIREG-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177303#comment-17177303
]
Nathan Gough commented on NIFIREG-313:
--
Hi Christian,
I've added a PR for this ti
arpadboda opened a new pull request #872:
URL: https://github.com/apache/nifi-minifi-cpp/pull/872
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
[
https://issues.apache.org/jira/browse/MINIFICPP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpad Boda updated MINIFICPP-1333:
--
Description:
Flowfiles sent to PublishKafka and looped back are not penalised, so they
imm
Arpad Boda created MINIFICPP-1333:
-
Summary: PublishKafka should penalize flowfiles sent to failure
Key: MINIFICPP-1333
URL: https://issues.apache.org/jira/browse/MINIFICPP-1333
Project: Apache NiFi Mi
[
https://issues.apache.org/jira/browse/MINIFICPP-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpad Boda updated MINIFICPP-1333:
--
Description:
Flowfiles sent to PublishKafka and looped back are not penalised, so they
imm
thenatog edited a comment on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-673631378
This change matches, as close as possible, the OIDC authentication code in
NiFi. When opening the NiFi Registry UI with OIDC configured, there should be a
Login butt
thenatog commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-673631378
This change matches, as close as possible, the OIDC authentication code in
NiFi. When opening the NiFi Registry UI with OIDC configured, there should be a
Login button in t
thenatog opened a new pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296
NIFIREG-313 - Added Login and Logout filters. Added unit tests.
NIFIREG-313 - Added changes from NiFi PR #4344. Fixing tests.
NIFIREG-313 - alopresto provided a patch to fix failing t
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470123463
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470123463
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470123463
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
lordgamez commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470070629
##
File path: extensions/libarchive/MergeContent.h
##
@@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin {
}
};
+cla
lordgamez commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470065882
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
Nissim Shiman created NIFI-7738:
---
Summary: Provenance Search Events - add feature to allow inverse
query
Key: NIFI-7738
URL: https://issues.apache.org/jira/browse/NIFI-7738
Project: Apache NiFi
[
https://issues.apache.org/jira/browse/NIFI-7738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nissim Shiman updated NIFI-7738:
Attachment: provenanceSearchEvents_InverseSearch.png
> Provenance Search Events - add feature to all
alopresto commented on pull request #4476:
URL: https://github.com/apache/nifi/pull/4476#issuecomment-673560087
Reviewing...
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470052761
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
[
https://issues.apache.org/jira/browse/NIFI-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177111#comment-17177111
]
ASF subversion and git services commented on NIFI-7692:
---
Commit 1b12
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
hunyadi-dev commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r470048623
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -342,6 +352,50 @@ std::shared_ptr
ZipMerge::merge(core::ProcessContext *context, c
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r470035889
##
File path: libminifi/include/io/Stream.h
##
@@ -0,0 +1,52 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
Woutifier opened a new pull request #4478:
URL: https://github.com/apache/nifi/pull/4478
Description of PR
_adds string[] array option to putcassandrarecord; implements NIFI-7737._
In order to streamline the review of the contribution we ask you
to ensure the following
Wouter de Vries created NIFI-7737:
-
Summary: Add support for String[] to PutCassandraRecord
Key: NIFI-7737
URL: https://issues.apache.org/jira/browse/NIFI-7737
Project: Apache NiFi
Issue Type
[
https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne resolved NIFI-7736.
--
Resolution: Fixed
> Duplicated permission checks in Empty All Queues
> -
[
https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177067#comment-17177067
]
ASF subversion and git services commented on NIFI-7736:
---
Commit 6c3c
markap14 commented on pull request #4477:
URL: https://github.com/apache/nifi/pull/4477#issuecomment-673520174
Thanks @tpalfy all looks good to me. +1 merged to main.
This is an automated message from the Apache Git Service.
markap14 merged pull request #4477:
URL: https://github.com/apache/nifi/pull/4477
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
[
https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-7736:
---
Fix Version/s: 1.12.0
> Duplicated permission checks in Empty All Queues
> ---
[
https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt resolved NIFI-.
Resolution: Fixed
> InvokeHTTP should provide a User-agent header
>
[
https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17177040#comment-17177040
]
Joe Witt commented on NIFI-:
It did. That was removed for similar concerns you had.
hunyadi-dev commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469969075
##
File path: extensions/jni/jvm/JVMLoader.h
##
@@ -349,7 +349,7 @@ class JVMLoader {
}
#ifdef _MSC_VER
-#pragma warning( suppress: 4054
hunyadi-dev commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469969174
##
File path: main/AgentDocs.cpp
##
@@ -129,7 +129,7 @@ void AgentDocs::generate(const std::string &docsdir,
std::ostream &genStream) {
au
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469966242
##
File path: libminifi/include/io/OutputStream.h
##
@@ -0,0 +1,107 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
tpalfy opened a new pull request #4477:
URL: https://github.com/apache/nifi/pull/4477
Fix: Empty All Queues performance - When authorizing request, checking
read/write credentials on encapsulated process groups and connections was
doubly recursive (for each element it added all child eleme
Arpad Boda created MINIFICPP-1332:
-
Summary: MiNiFi should properly handle running out of diskspace
Key: MINIFICPP-1332
URL: https://issues.apache.org/jira/browse/MINIFICPP-1332
Project: Apache NiFi Mi
[
https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176862#comment-17176862
]
Wouter de Vries edited comment on NIFI- at 8/13/20, 1:33 PM:
---
[
https://issues.apache.org/jira/browse/NIFI-7696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahieddine Cherif reassigned NIFI-7696:
---
Assignee: Mahieddine Cherif
> MultiQueryRecord Processor
> --
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469928037
##
File path: extensions/coap/tests/CoapC2VerifyHeartbeat.cpp
##
@@ -132,18 +132,18 @@ class VerifyCoAPServer : public CoapIntegrationBase {
szaszm commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469923156
##
File path: extensions/coap/tests/CoapC2VerifyHeartbeat.cpp
##
@@ -132,18 +132,18 @@ class VerifyCoAPServer : public CoapIntegrationBase {
{
szaszm commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469916009
##
File path: libminifi/include/io/OutputStream.h
##
@@ -0,0 +1,107 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
szaszm commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469864618
##
File path: libminifi/include/io/Stream.h
##
@@ -0,0 +1,52 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * c
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469903259
##
File path: libminifi/src/io/BufferStream.cpp
##
@@ -0,0 +1,56 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469902822
##
File path: libminifi/src/io/InputStream.cpp
##
@@ -0,0 +1,141 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469902504
##
File path: libminifi/src/io/OutputStream.cpp
##
@@ -0,0 +1,118 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one o
adamdebreceni commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469901701
##
File path: libminifi/test/unit/FileStreamTests.cpp
##
@@ -235,12 +235,12 @@ TEST_CASE("TestFileExceedSize", "[TestLoader]") {
std::vecto
lordgamez commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469899411
##
File path: extensions/libarchive/MergeContent.h
##
@@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin {
}
};
+cla
[
https://issues.apache.org/jira/browse/NIFI-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Palfy reassigned NIFI-7736:
-
Assignee: Tamas Palfy
> Duplicated permission checks in Empty All Queues
> --
szaszm commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469883065
##
File path: extensions/libarchive/MergeContent.h
##
@@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin {
}
};
+class
Peter Turcsanyi created NIFI-7736:
-
Summary: Duplicated permission checks in Empty All Queues
Key: NIFI-7736
URL: https://issues.apache.org/jira/browse/NIFI-7736
Project: Apache NiFi
Issue Ty
Venkatesh Raman created NIFI-7735:
-
Summary: MongoDB Connection Issue
Key: NIFI-7735
URL: https://issues.apache.org/jira/browse/NIFI-7735
Project: Apache NiFi
Issue Type: Bug
Compon
szaszm commented on a change in pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871#discussion_r469841552
##
File path: extensions/jni/jvm/JVMLoader.h
##
@@ -349,7 +349,7 @@ class JVMLoader {
}
#ifdef _MSC_VER
-#pragma warning( suppress: 4054 )
R
arpadboda commented on a change in pull request #864:
URL: https://github.com/apache/nifi-minifi-cpp/pull/864#discussion_r469787490
##
File path: libminifi/include/io/OutputStream.h
##
@@ -0,0 +1,107 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or
szaszm commented on a change in pull request #868:
URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469830729
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter {
struct rd_kafka_topic_conf_deleter {
lordgamez commented on a change in pull request #868:
URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469828169
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter {
struct rd_kafka_topic_conf_deleter {
adamdebreceni commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469823575
##
File path: extensions/libarchive/MergeContent.cpp
##
@@ -156,7 +159,7 @@ void MergeContent::onSchedule(core::ProcessContext
*context, core
adamdebreceni commented on a change in pull request #870:
URL: https://github.com/apache/nifi-minifi-cpp/pull/870#discussion_r469822537
##
File path: extensions/libarchive/MergeContent.h
##
@@ -259,20 +259,56 @@ class ZipMerge: public ArchiveMerge, public MergeBin {
}
};
szaszm commented on a change in pull request #868:
URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469819190
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter {
struct rd_kafka_topic_conf_deleter {
lordgamez commented on a change in pull request #868:
URL: https://github.com/apache/nifi-minifi-cpp/pull/868#discussion_r469808973
##
File path: extensions/librdkafka/PublishKafka.cpp
##
@@ -144,6 +159,305 @@ struct rd_kafka_conf_deleter {
struct rd_kafka_topic_conf_deleter {
[
https://issues.apache.org/jira/browse/NIFI-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176862#comment-17176862
]
Wouter de Vries commented on NIFI-:
---
Looking at user-agents in general, we are (
[
https://issues.apache.org/jira/browse/MINIFICPP-1331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adam Hunyadi updated MINIFICPP-1331:
Description:
*Background:*
Parsing the value "NULL" for a configuration node currently
Adam Hunyadi created MINIFICPP-1331:
---
Summary: Upgrade yaml-cpp to eliminate issues with "NULL" string
in config
Key: MINIFICPP-1331
URL: https://issues.apache.org/jira/browse/MINIFICPP-1331
Project
hunyadi-dev opened a new pull request #871:
URL: https://github.com/apache/nifi-minifi-cpp/pull/871
Automatic fixes done using:
```zsh
➜ make linter |& egrep -v '^Done processing|^Ignoring' |& tee errors.txt |
less
➜ cat errors.txt | grep "Extra space before (" | tr ":" " " | c
76 matches
Mail list logo