[jira] [Commented] (NIFI-7787) Release Apache NiFi 1.12.1

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191905#comment-17191905 ] ASF subversion and git services commented on NIFI-7787: --- Commit

[jira] [Commented] (NIFI-7787) Release Apache NiFi 1.12.1

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191906#comment-17191906 ] ASF subversion and git services commented on NIFI-7787: --- Commit

[GitHub] [nifi] MikeThomsen commented on pull request #4514: NIFI-7768 Added support for monogdb+srv connection strings.

2020-09-07 Thread GitBox
MikeThomsen commented on pull request #4514: URL: https://github.com/apache/nifi/pull/4514#issuecomment-688551004 @jfrazee I do most of my development on my company laptop (with management's strong approval), but we installed a MITM tool that wrecks havoc on me testing this with Atlas.

[GitHub] [nifi] MikeThomsen opened a new pull request #4514: NIFI-7768 Added support for monogdb+srv connection strings.

2020-09-07 Thread GitBox
MikeThomsen opened a new pull request #4514: URL: https://github.com/apache/nifi/pull/4514 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[jira] [Commented] (NIFI-7754) JettyWebSocketClient to support HTTP Proxy

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191885#comment-17191885 ] ASF subversion and git services commented on NIFI-7754: --- Commit

[jira] [Commented] (NIFI-7506) CompressContent Add Snappy-Hadoop

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191884#comment-17191884 ] ASF subversion and git services commented on NIFI-7506: --- Commit

[jira] [Updated] (NIFI-7754) JettyWebSocketClient to support HTTP Proxy

2020-09-07 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-7754: --- Fix Version/s: 1.12.1 > JettyWebSocketClient to support HTTP Proxy >

[jira] [Updated] (NIFI-7506) CompressContent Add Snappy-Hadoop

2020-09-07 Thread Joe Witt (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-7506: --- Fix Version/s: 1.12.1 > CompressContent Add Snappy-Hadoop > - > >

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #889: MINIFICPP-952 remove travis and appveyor

2020-09-07 Thread GitBox
arpadboda closed pull request #889: URL: https://github.com/apache/nifi-minifi-cpp/pull/889 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #888: MINIFICPP-1347 Do not override MergeContent output attributes

2020-09-07 Thread GitBox
arpadboda closed pull request #888: URL: https://github.com/apache/nifi-minifi-cpp/pull/888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #878: MINIFICPP-1104 Add SSL docker tests for PublishKafka and automate them in CI

2020-09-07 Thread GitBox
arpadboda commented on a change in pull request #878: URL: https://github.com/apache/nifi-minifi-cpp/pull/878#discussion_r484555099 ## File path: docker/test/integration/minifi/test/__init__.py ## @@ -166,20 +184,33 @@ def log_nifi_output(self): stats =

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #878: MINIFICPP-1104 Add SSL docker tests for PublishKafka and automate them in CI

2020-09-07 Thread GitBox
arpadboda commented on a change in pull request #878: URL: https://github.com/apache/nifi-minifi-cpp/pull/878#discussion_r484555055 ## File path: docker/test/integration/minifi/__init__.py ## @@ -413,7 +426,7 @@ def __init__(self, self.controller_services =

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #882: MINIFICPP-1343 Create a minimal docker image target

2020-09-07 Thread GitBox
arpadboda commented on a change in pull request #882: URL: https://github.com/apache/nifi-minifi-cpp/pull/882#discussion_r484554812 ## File path: docker/Dockerfile ## @@ -16,113 +16,144 @@ # under the License. # -# First stage: the build environment -# Edge required for

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
szaszm closed pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi] pgyori commented on a change in pull request #4481: NIFI-7624: ListenFTP processor

2020-09-07 Thread GitBox
pgyori commented on a change in pull request #4481: URL: https://github.com/apache/nifi/pull/4481#discussion_r484541741 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ftp/NifiFtpServer.java ## @@

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
szaszm closed pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
szaszm commented on pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#issuecomment-688443647 > I see what you mean, but I disagree. I would definitely avoid adding states like this to an object. I found it already quite a task to decipher in what state can we

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#issuecomment-688432366 > Since the requirement of "one has to call load before start" is not documented anywhere, I would restore the `initialized_` variable to prevent invalid usage of

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484517048 ## File path: libminifi/src/FlowController.cpp ## @@ -320,12 +320,12 @@ void FlowController::initializeUninitializedSchedulers() {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484517048 ## File path: libminifi/src/FlowController.cpp ## @@ -320,12 +320,12 @@ void FlowController::initializeUninitializedSchedulers() {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
szaszm commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484513034 ## File path: libminifi/src/FlowController.cpp ## @@ -320,12 +320,12 @@ void FlowController::initializeUninitializedSchedulers() {

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484516482 ## File path: libminifi/src/FlowController.cpp ## @@ -320,12 +320,12 @@ void FlowController::initializeUninitializedSchedulers() {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
szaszm commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484513034 ## File path: libminifi/src/FlowController.cpp ## @@ -320,12 +320,12 @@ void FlowController::initializeUninitializedSchedulers() {

[jira] [Resolved] (MINIFICPP-1335) TailFile generates an empty flowfile in every onTrigger call when used without delimiter

2020-09-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved MINIFICPP-1335. --- Resolution: Fixed > TailFile generates an empty flowfile in every onTrigger call

[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #896: MINIFICPP-1353 Fix a heap-use-after-free error

2020-09-07 Thread GitBox
arpadboda closed pull request #896: URL: https://github.com/apache/nifi-minifi-cpp/pull/896 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (NIFI-7754) JettyWebSocketClient to support HTTP Proxy

2020-09-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-7754. -- Fix Version/s: 1.13.0 Resolution: Fixed > JettyWebSocketClient to support HTTP Proxy >

[GitHub] [nifi] pvillard31 commented on pull request #4502: NIFI-7754 Support HTTP Proxy for JettyWebSocketClient

2020-09-07 Thread GitBox
pvillard31 commented on pull request #4502: URL: https://github.com/apache/nifi/pull/4502#issuecomment-688384440 Merged to main, thanks @xasx ! This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (NIFI-7754) JettyWebSocketClient to support HTTP Proxy

2020-09-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7754: - Issue Type: Improvement (was: Bug) > JettyWebSocketClient to support HTTP Proxy >

[jira] [Updated] (NIFI-7754) JettyWebSocketClient to support HTTP Proxy

2020-09-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7754: - Component/s: Extensions > JettyWebSocketClient to support HTTP Proxy >

[jira] [Commented] (NIFI-7754) JettyWebSocketClient to support HTTP Proxy

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191750#comment-17191750 ] ASF subversion and git services commented on NIFI-7754: --- Commit

[GitHub] [nifi] asfgit closed pull request #4502: NIFI-7754 Support HTTP Proxy for JettyWebSocketClient

2020-09-07 Thread GitBox
asfgit closed pull request #4502: URL: https://github.com/apache/nifi/pull/4502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484451982 ## File path: docker/test/integration/test_http.py ## @@ -34,3 +33,26 @@ def test_invoke_listen(): cluster.deploy_flow(invoke_flow,

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484451198 ## File path: libminifi/include/utils/ByteArrayCallback.h ## @@ -65,7 +66,7 @@ class ByteInputCallBack : public InputStreamCallback { }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
szaszm commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484405587 ## File path: libminifi/include/utils/ByteArrayCallback.h ## @@ -65,7 +66,7 @@ class ByteInputCallBack : public InputStreamCallback { }

[jira] [Updated] (MINIFICPP-1359) FollowRedirects feature is unavailable in InvokeHTTP

2020-09-07 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1359: - Description: InvokeHTTP processor does not use FollowRedirects property, so if a

[jira] [Created] (MINIFICPP-1359) FollowRedirects feature is unavailable in InvokeHTTP

2020-09-07 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1359: Summary: FollowRedirects feature is unavailable in InvokeHTTP Key: MINIFICPP-1359 URL: https://issues.apache.org/jira/browse/MINIFICPP-1359 Project: Apache

[jira] [Created] (MINIFICPP-1358) SendBody property is unused in InvokeHTTP

2020-09-07 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1358: Summary: SendBody property is unused in InvokeHTTP Key: MINIFICPP-1358 URL: https://issues.apache.org/jira/browse/MINIFICPP-1358 Project: Apache NiFi MiNiFi

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484405469 ## File path: extensions/http-curl/processors/InvokeHTTP.cpp ## @@ -246,6 +246,20 @@ void InvokeHTTP::onSchedule(const std::shared_ptr if

[jira] [Comment Edited] (NIFI-7749) listSFTP - Failed "Should not reach here"

2020-09-07 Thread Wiktor Kubicki (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191663#comment-17191663 ] Wiktor Kubicki edited comment on NIFI-7749 at 9/7/20, 12:01 PM: Same on

[jira] [Resolved] (NIFI-7506) CompressContent Add Snappy-Hadoop

2020-09-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-7506. -- Fix Version/s: 1.13.0 Resolution: Fixed > CompressContent Add Snappy-Hadoop >

[jira] [Updated] (NIFI-7506) CompressContent Add Snappy-Hadoop

2020-09-07 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7506: - Component/s: Extensions > CompressContent Add Snappy-Hadoop > - >

[jira] [Commented] (NIFI-7749) listSFTP - Failed "Should not reach here"

2020-09-07 Thread Wiktor Kubicki (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191663#comment-17191663 ] Wiktor Kubicki commented on NIFI-7749: -- Same on nifi 1.11.4 and openjdk 11.0.8 2020-07-14 LTS >

[GitHub] [nifi] pvillard31 commented on pull request #4321: NIFI-7506 - CompressContent Add Snappy-Hadoop

2020-09-07 Thread GitBox
pvillard31 commented on pull request #4321: URL: https://github.com/apache/nifi/pull/4321#issuecomment-688276758 Merged to main, thanks @noedetore This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484384960 ## File path: libminifi/src/FlowController.cpp ## @@ -311,56 +302,62 @@ void FlowController::unload() { if (running_) { stop(); } -

[GitHub] [nifi] asfgit closed pull request #4321: NIFI-7506 - CompressContent Add Snappy-Hadoop

2020-09-07 Thread GitBox
asfgit closed pull request #4321: URL: https://github.com/apache/nifi/pull/4321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (NIFI-7506) CompressContent Add Snappy-Hadoop

2020-09-07 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191660#comment-17191660 ] ASF subversion and git services commented on NIFI-7506: --- Commit

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484382473 ## File path: libminifi/include/FlowController.h ## @@ -338,6 +335,10 @@ class FlowController : public

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484376022 ## File path: libminifi/include/FlowController.h ## @@ -100,18 +100,15 @@ class FlowController : public

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #890: MINIFICPP-1288 - FlowController start/load refactor

2020-09-07 Thread GitBox
arpadboda commented on a change in pull request #890: URL: https://github.com/apache/nifi-minifi-cpp/pull/890#discussion_r484368876 ## File path: libminifi/include/FlowController.h ## @@ -338,6 +335,10 @@ class FlowController : public

[GitHub] [nifi] simonbence commented on a change in pull request #4420: NIFI-7429 Adding status history for system level metrics

2020-09-07 Thread GitBox
simonbence commented on a change in pull request #4420: URL: https://github.com/apache/nifi/pull/4420#discussion_r484373564 ## File path:

[GitHub] [nifi] simonbence commented on a change in pull request #4420: NIFI-7429 Adding status history for system level metrics

2020-09-07 Thread GitBox
simonbence commented on a change in pull request #4420: URL: https://github.com/apache/nifi/pull/4420#discussion_r484372894 ## File path:

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484365864 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -300,6 +319,9 @@ class BaseHTTPClient { virtual void

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484365267 ## File path: docker/test/integration/test_http.py ## @@ -34,3 +33,26 @@ def test_invoke_listen(): cluster.deploy_flow(invoke_flow,

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484364547 ## File path: libminifi/include/utils/ByteArrayCallback.h ## @@ -57,6 +57,7 @@ class ByteInputCallBack : public InputStreamCallback { }

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
lordgamez commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484364547 ## File path: libminifi/include/utils/ByteArrayCallback.h ## @@ -57,6 +57,7 @@ class ByteInputCallBack : public InputStreamCallback { }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
szaszm commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484344801 ## File path: docker/test/integration/test_http.py ## @@ -34,3 +33,26 @@ def test_invoke_listen(): cluster.deploy_flow(invoke_flow,

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
hunyadi-dev commented on pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#issuecomment-688205425 Please check the CI errors, they seem related to the change. This is an automated message from the

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
arpadboda commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484283890 ## File path: extensions/http-curl/processors/InvokeHTTP.cpp ## @@ -246,6 +246,20 @@ void InvokeHTTP::onSchedule(const std::shared_ptr if

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
adamdebreceni commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484279314 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -300,6 +319,9 @@ class BaseHTTPClient { virtual void

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
adamdebreceni commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484279314 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -300,6 +319,9 @@ class BaseHTTPClient { virtual void

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484278690 ## File path: nanofi/src/sitetosite/CRawSocketProtocol.c ## @@ -153,7 +153,7 @@ int handShake(struct CRawSiteToSiteClient * client) { if

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484278402 ## File path: nanofi/src/sitetosite/CRawSocketProtocol.c ## @@ -72,10 +72,10 @@ typedef struct { int handShake(struct CRawSiteToSiteClient *

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484269857 ## File path: nanofi/src/sitetosite/CRawSocketProtocol.c ## @@ -72,10 +72,10 @@ typedef struct { int handShake(struct CRawSiteToSiteClient *

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484268701 ## File path: nanofi/src/core/cstream.c ## @@ -149,7 +149,7 @@ int readUTFLen(uint32_t * utflen, cstream * stream) { } int readUTF(char *

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484268088 ## File path: nanofi/include/sitetosite/CSiteToSite.h ## @@ -332,7 +332,7 @@ static int writeData(CTransaction * transaction, const uint8_t

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484267747 ## File path: nanofi/include/sitetosite/CSiteToSite.h ## @@ -267,7 +267,7 @@ typedef struct { // Whether received data is available int

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484266683 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -115,7 +115,7 @@ void TailEventLog::onTrigger(const std::shared_ptr

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484266987 ## File path: main/MiNiFiWindowsService.cpp ## @@ -27,7 +27,7 @@ #include "MainHelper.h" #include "core/FlowConfiguration.h" -//#define

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #865: MINIFICPP-1325 - Separate process group processor lookups for IDs and names, allow constructing ID-s from strings

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #865: URL: https://github.com/apache/nifi-minifi-cpp/pull/865#discussion_r484265845 ## File path: libminifi/src/utils/Id.cpp ## @@ -48,6 +48,8 @@ namespace nifi { namespace minifi { namespace utils { +const char*

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #897: MINIFICPP-1357 Implement and test proxy handling in InvokeHTTP

2020-09-07 Thread GitBox
adamdebreceni commented on a change in pull request #897: URL: https://github.com/apache/nifi-minifi-cpp/pull/897#discussion_r484263666 ## File path: extensions/http-curl/processors/InvokeHTTP.cpp ## @@ -246,6 +246,20 @@ void InvokeHTTP::onSchedule(const std::shared_ptr

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484263554 ## File path: extensions/sftp/tests/FetchSFTPTests.cpp ## @@ -142,7 +142,7 @@ class FetchSFTPTestsFixture { std::fstream file;

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484260676 ## File path: extensions/libarchive/FocusArchiveEntry.cpp ## @@ -130,7 +130,7 @@ void FocusArchiveEntry::onTrigger(core::ProcessContext

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484260410 ## File path: extensions/jni/jvm/JniProcessContext.h ## @@ -69,8 +69,8 @@ DLL_EXPORT jstring JNICALL

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484259906 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -428,7 +428,7 @@ class HeartbeatHandler : public ServerAwareHandler { void

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #884: MINIFICPP-1203 - Correct linter reported missing spaces around comments

2020-09-07 Thread GitBox
hunyadi-dev commented on a change in pull request #884: URL: https://github.com/apache/nifi-minifi-cpp/pull/884#discussion_r484259666 ## File path: extensions/http-curl/tests/CivetStream.h ## @@ -119,7 +119,7 @@ class CivetStream : public io::BaseStream { return

[jira] [Created] (MINIFICPP-1357) Proxy properties of invokehttp are not respected

2020-09-07 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1357: Summary: Proxy properties of invokehttp are not respected Key: MINIFICPP-1357 URL: https://issues.apache.org/jira/browse/MINIFICPP-1357 Project: Apache NiFi

[jira] [Commented] (NIFI-7761) Allow HandleHttpRequest to add specified form data to FlowFile attributes

2020-09-07 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191462#comment-17191462 ] Otto Fowler commented on NIFI-7761: --- PR is up with implementation as mentioned. > Allow

[GitHub] [nifi] ottobackwards opened a new pull request #4513: NIFI-7761 Allow HandleHttpRequest to add specified form data to FlowF…

2020-09-07 Thread GitBox
ottobackwards opened a new pull request #4513: URL: https://github.com/apache/nifi/pull/4513 …ile attributes To verify: - add the attached template - configure the HandleHttpRequest `Parameters to Attributes List` property to have `data1,DataTwo` - Enable the context