greyp9 opened a new pull request, #6781:
URL: https://github.com/apache/nifi/pull/6781
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue
adamdebreceni commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048466865
##
extensions/standard-processors/tests/unit/PutTCPTests.cpp:
##
@@ -141,16 +120,16 @@ class PutTCPTestFixture {
}
size_t
turcsanyip commented on code in PR #6740:
URL: https://github.com/apache/nifi/pull/6740#discussion_r1048458190
##
nifi-nar-bundles/nifi-dropbox-bundle/nifi-dropbox-processors/src/main/java/org/apache/nifi/processors/dropbox/PutDropbox.java:
##
@@ -0,0 +1,324 @@
+/*
+ * Licensed
adamdebreceni commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048458529
##
extensions/standard-processors/tests/unit/ListenUDPTests.cpp:
##
@@ -29,49 +29,67 @@ using namespace std::literals::chrono_literals;
namespace
adamdebreceni commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048455640
##
extensions/standard-processors/tests/unit/ListenTcpTests.cpp:
##
@@ -134,60 +147,64 @@ TEST_CASE("Test ListenTCP with SSL connection",
martinzink commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048441787
##
extensions/standard-processors/processors/PutTCP.cpp:
##
@@ -160,339 +177,145 @@ void PutTCP::onSchedule(core::ProcessContext* const
context,
adamdebreceni commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048384528
##
extensions/standard-processors/processors/PutTCP.cpp:
##
@@ -160,339 +177,145 @@ void PutTCP::onSchedule(core::ProcessContext* const
context,
adamdebreceni commented on code in PR #1457:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1457#discussion_r1048381787
##
extensions/standard-processors/processors/PutTCP.cpp:
##
@@ -160,339 +177,145 @@ void PutTCP::onSchedule(core::ProcessContext* const
context,
lordgamez opened a new pull request, #1477:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1477
https://issues.apache.org/jira/browse/MINIFICPP-2016
--
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline
arun-prakash-fokus commented on PR #6651:
URL: https://github.com/apache/nifi/pull/6651#issuecomment-1350965158
Furthermore, I would like to suggest the following naming convention for the
`environment` variables keeping in line with the naming conventions of the
`TLS` and `LDAP`
arun-prakash-fokus commented on PR #6651:
URL: https://github.com/apache/nifi/pull/6651#issuecomment-1350855023
Please correct me if I am wrong, but as of v1.19.1 (of `nifi` and
`nifi-registry`), the correct properties for OIDC as written in the
`nifi.properties` and
martinzink opened a new pull request, #1476:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1476
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
adamdebreceni commented on code in PR #1413:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1413#discussion_r1048177387
##
minifi_main/JsonSchema.h:
##
@@ -0,0 +1,26 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license
lizhizhou commented on code in PR #6416:
URL: https://github.com/apache/nifi/pull/6416#discussion_r1048073076
##
nifi-nar-bundles/nifi-iotdb-bundle/pom.xml:
##
@@ -0,0 +1,48 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
lizhizhou commented on code in PR #6416:
URL: https://github.com/apache/nifi/pull/6416#discussion_r1048072863
##
nifi-nar-bundles/nifi-iotdb-bundle/nifi-iotdb-processors/src/test/java/org/apache/nifi/processors/AbstractIoTDBUT.java:
##
@@ -0,0 +1,282 @@
+/*
+ * Licensed to the
emiliosetiadarma opened a new pull request, #6780:
URL: https://github.com/apache/nifi/pull/6780
…Azure Key Vault Client and added unit tests
# Summary
[NIFI-10971](https://issues.apache.org/jira/browse/NIFI-10971)
#
exceptionfactory opened a new pull request, #6779:
URL: https://github.com/apache/nifi/pull/6779
# Summary
[NIFI-10975](https://issues.apache.org/jira/browse/NIFI-10975) Adds an
initial implementation of Kubernetes cluster leader election and state
management, supporting deployments
dan-s1 commented on PR #6753:
URL: https://github.com/apache/nifi/pull/6753#issuecomment-1349646454
@exceptionfactory I see ImportFlowIt on line 59 still has
`import org.junit.Test;
`
instead of
`import org.junit.jupiter.api.Test;`
--
This is an automated message
exceptionfactory commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1047648938
##
exceptionfactory commented on PR #6775:
URL: https://github.com/apache/nifi/pull/6775#issuecomment-1349491017
> I had tried to expand last night and nothing expanded and the only thing I
saw was error. Today I see the logs. Is there a delay of some sort for that to
be populated?
The
MikeThomsen commented on code in PR #6778:
URL: https://github.com/apache/nifi/pull/6778#discussion_r1047383469
##
nifi-commons/nifi-record-path/src/main/java/org/apache/nifi/record/path/functions/Count.java:
##
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software
dan-s1 commented on PR #6775:
URL: https://github.com/apache/nifi/pull/6775#issuecomment-1349308626
> > @exceptionfactory I took care of those. Let me know if there is anything
else. Thank you for pointing out the the Checkstyle issues as from the
CI-workflow it did not give any
exceptionfactory closed pull request #6775: [NIFI-10877] Conversion of
nifi-framework-core tests from Junit4 to J…
URL: https://github.com/apache/nifi/pull/6775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
exceptionfactory commented on PR #6670:
URL: https://github.com/apache/nifi/pull/6670#issuecomment-1349199366
@turcsanyip It looks like the commit did not get applied to the `main`
branch, and instead references a different branch named `commit`:
exceptionfactory commented on PR #6775:
URL: https://github.com/apache/nifi/pull/6775#issuecomment-1349006249
> @exceptionfactory I took care of those. Let me know if there is anything
else. Thank you for pointing out the the Checkstyle issues as from the
CI-workflow it did not give any
dan-s1 commented on PR #6775:
URL: https://github.com/apache/nifi/pull/6775#issuecomment-1348862970
@exceptionfactory I took care of those. Let me know if there is anything
else. Thank you for pointing out the the Checkstyle issues as from the
CI-workflow it did not give any information
mattyb149 commented on PR #6725:
URL: https://github.com/apache/nifi/pull/6725#issuecomment-1348813980
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
szaszm opened a new pull request, #1475:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1475
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have
szaszm closed pull request #1471: MINIFICPP-2012 - Make free unconditional
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
szaszm closed pull request #1469: MINIFICPP-1932 Increase the timeout in
TailFileTest
URL: https://github.com/apache/nifi-minifi-cpp/pull/1469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
szaszm commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1047284129
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
tpalfy commented on PR #6670:
URL: https://github.com/apache/nifi/pull/6670#issuecomment-1348708673
LGTM
Thanks for your work @Lehel44 and @turcsanyip for closing the PR (after I
forgot it during the merge).
--
This is an automated message from the Apache Git Service.
To respond to
turcsanyip commented on PR #6670:
URL: https://github.com/apache/nifi/pull/6670#issuecomment-1348704501
Closing PR manually due to missing PR reference in the commit message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
turcsanyip closed pull request #6670: NIFI-10832: Create PutSalesforceObject
processor
URL: https://github.com/apache/nifi/pull/6670
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
adamdebreceni commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1047179473
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
szaszm commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1047169874
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
martinzink opened a new pull request, #1474:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1474
…iggers in ScheduleAgents
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the
martinzink opened a new pull request, #1473:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1473
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
martinzink opened a new pull request, #1472:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1472
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
turcsanyip commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1046970850
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java:
##
@@ -0,0 +1,25 @@
adamdebreceni commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1046845372
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
szaszm commented on code in PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#discussion_r1046825301
##
libminifi/test/unit/OsUtilTests.cpp:
##
@@ -0,0 +1,41 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
exceptionfactory commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046647523
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/wali/EncryptedSequentialAccessWriteAheadLogTest.groovy:
github-actions[bot] commented on PR #5745:
URL: https://github.com/apache/nifi/pull/5745#issuecomment-1347561235
Automated review is marking this PR as stale due to lack of updates in the
past four months. This PR will be closed in 15 days if the stale label is not
removed. This stale
Lehel44 commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1046534890
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java:
##
@@ -0,0 +1,207 @@
emiliosetiadarma commented on PR #6545:
URL: https://github.com/apache/nifi/pull/6545#issuecomment-1347548297
Hi @VadimBabich,
Thank you for reaching out, I am gonna file a new issue to capture this as
well as making the AzureKeyVaultSecretsParameterProvider just more robust in
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046532506
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046502289
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
exceptionfactory commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046493258
##
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046487866
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
mattyb149 closed pull request #6774: NIFI-10958 Adjust Script Engine handling
to avoid errors on Java 17
URL: https://github.com/apache/nifi/pull/6774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mattyb149 commented on PR #6774:
URL: https://github.com/apache/nifi/pull/6774#issuecomment-1347381540
+1 LGTM, thanks for the improvement! Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
turcsanyip commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1046417139
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java:
##
@@ -0,0 +1,25 @@
turcsanyip commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1046417139
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java:
##
@@ -0,0 +1,25 @@
exceptionfactory commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046366136
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardFlowServiceTest.java:
##
@@ -111,13
exceptionfactory commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046364814
##
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046364030
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardFlowServiceTest.java:
##
@@ -111,13 +112,16
dan-s1 commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046356567
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/groovy/org/apache/nifi/controller/repository/crypto/EncryptedFileSystemRepositoryTest.groovy:
markap14 opened a new pull request, #6778:
URL: https://github.com/apache/nifi/pull/6778
# Summary
[NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
# Tracking
Please complete the following tracking steps
exceptionfactory commented on code in PR #6775:
URL: https://github.com/apache/nifi/pull/6775#discussion_r1046275711
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/StandardProcessorNodeIT.java:
##
@@ -206,9
exceptionfactory commented on PR #6775:
URL: https://github.com/apache/nifi/pull/6775#issuecomment-1347129068
Thanks for resolving the conflicts @dan-s1. I had made some of the related
changes under NIFI-10941 as part of removing TestNG references, I will review
the changes in this PR.
pvillard31 commented on PR #6589:
URL: https://github.com/apache/nifi/pull/6589#issuecomment-1347061165
Note - I do see the additionalDetails page on the pull request but it's not
showing in the usage page of the processor. Maybe something wrong somewhere
when building the documentation?
tpalfy commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1046116928
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java:
##
@@ -0,0 +1,207 @@
tpalfy commented on code in PR #6670:
URL: https://github.com/apache/nifi/pull/6670#discussion_r1046116928
##
nifi-nar-bundles/nifi-salesforce-bundle/nifi-salesforce-processors/src/main/java/org/apache/nifi/processors/salesforce/PutSalesforceObject.java:
##
@@ -0,0 +1,207 @@
exceptionfactory commented on code in PR #6777:
URL: https://github.com/apache/nifi/pull/6777#discussion_r1046061504
##
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/signer/AwsCustomSignerFactory.java:
##
@@ -0,0
martinzink commented on PR #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471#issuecomment-1346665510
Awesome find :pray: thanks for digging this out.
Could you please add the explanation here or in the Jira how this could
cause a memory leak?
Also adding a unit
dan-s1 commented on PR #6775:
URL: https://github.com/apache/nifi/pull/6775#issuecomment-1346580500
@exceptionfactory Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1045813064
##
extensions/sftp/tests/ListSFTPTests.cpp:
##
@@ -187,7 +180,7 @@ TEST_CASE_METHOD(ListSFTPTestsFixture, "ListSFTP list one
file", "[ListSFTP][bas
adamdebreceni opened a new pull request, #1471:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1471
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
szaszm merged PR #70:
URL: https://github.com/apache/nifi-site/pull/70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
turcsanyip opened a new pull request, #6777:
URL: https://github.com/apache/nifi/pull/6777
…cessors
Also added Signer Override property in
AWSCredentialsProviderControllerService with Custom Signer extension point.
Made Assume Role related properties dependent on Assume Role ARN
Kerr0220 commented on PR #6508:
URL: https://github.com/apache/nifi/pull/6508#issuecomment-1345362616
> Thanks for the contribution @Kerr0220.
>
> The `TestHttpClient` class does not fail under normal execution, so any
changes must ensure consistent test behavior. These changes break
VadimBabich commented on PR #6545:
URL: https://github.com/apache/nifi/pull/6545#issuecomment-1345356444
Hi
Getting a certificate from an Azure Key Vault throws a
**java.lang.NullPointerException** at the line:
Kerr0220 commented on PR #6508:
URL: https://github.com/apache/nifi/pull/6508#issuecomment-1345341918
@exceptionfactory Could please help figure out the reason of the
cancellation of `ci-workflow / Ubuntu Zulu JDK 17 EN (pull_request)`? Other
checks can pass now except this one. :)
--
TheGreatRandall opened a new pull request, #6776:
URL: https://github.com/apache/nifi/pull/6776
# Summary
[NIFI-10968](https://issues.apache.org/jira/browse/NIFI-10968)
Following the problem in the issue NIFI-10968. I set several
Kerr0220 opened a new pull request, #6508:
URL: https://github.com/apache/nifi/pull/6508
# Summary
[NIFI-10623](https://issues.apache.org/jira/browse/NIFI-10623)
These flaky tests were caused by the feature of Map since the
Kerr0220 commented on PR #6508:
URL: https://github.com/apache/nifi/pull/6508#issuecomment-1344843580
@exceptionfactory Hi, could you please reopen this PR? I've pushed a new
commit to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044871408
##
extensions/jni/jvm/JniReferenceObjects.h:
##
@@ -299,24 +278,26 @@ class JniSessionFactory : public core::WeakReference {
}
}
- jobject
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044842683
##
libminifi/test/unit/FileStreamTests.cpp:
##
@@ -301,32 +267,25 @@ TEST_CASE("Existing file read/write test") {
stream.seek(0);
}
-#if
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044840784
##
extensions/sftp/tests/ListThenFetchSFTPTests.cpp:
##
@@ -121,7 +120,7 @@ class ListThenFetchSFTPTestsFixture {
plan->setProperty(list_sftp, "Minimum
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044839048
##
extensions/sftp/tests/PutSFTPTests.cpp:
##
@@ -244,7 +240,7 @@ TEST_CASE_METHOD(PutSFTPTestsFixture, "PutSFTP bad
password", "[PutSFTP][authent
}
dan-s1 opened a new pull request, #6775:
URL: https://github.com/apache/nifi/pull/6775
…unit5
# Summary
[NIFI-0](https://issues.apache.org/jira/browse/NIFI-0)
# Tracking
Please complete the following
exceptionfactory closed pull request #6517: NIFI-10576 - ParquetRecordSetWriter
doesn't write avro schema to attribute
URL: https://github.com/apache/nifi/pull/6517
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
NissimShiman commented on PR #6725:
URL: https://github.com/apache/nifi/pull/6725#issuecomment-1344673531
This is a really nice enhancement.
Tested with csv files being converted to json files before and after fix
for csv files of 21 and 63 bytes, there was 25 -30% speed up in
exceptionfactory opened a new pull request, #6774:
URL: https://github.com/apache/nifi/pull/6774
# Summary
[NIFI-10958](https://issues.apache.org/jira/browse/NIFI-10958) Adjusts
Script Engine property handling in `ScriptingComponentsHelper` to avoid
exceptions on Java 17 during
fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044702728
##
extensions/sftp/tests/ListThenFetchSFTPTests.cpp:
##
@@ -121,7 +120,7 @@ class ListThenFetchSFTPTestsFixture {
plan->setProperty(list_sftp, "Minimum
thenatog commented on PR #6517:
URL: https://github.com/apache/nifi/pull/6517#issuecomment-1344598862
Thanks, if the avro.schema attribute is coming through on flowfiles coming
out of the runner, then that sounds good to me. The simplest test would be to
see that the attributes are now
fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044661369
##
libminifi/test/unit/FileStreamTests.cpp:
##
@@ -301,32 +267,25 @@ TEST_CASE("Existing file read/write test") {
stream.seek(0);
}
-#if !defined(WIN32)
fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044660504
##
libminifi/test/rocksdb-tests/RocksDBTests.cpp:
##
@@ -232,9 +231,9 @@ void
withDefaultEnv(minifi::internal::Writable& db_opts) {
}
fgerlits commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044659717
##
libminifi/test/rocksdb-tests/EncryptionTests.cpp:
##
@@ -77,8 +75,8 @@ TEST_CASE_METHOD(FFRepoFixture, "FlowFileRepository creates
checkpoint and loads
exceptionfactory closed pull request #6754: NIFI-10637 Fixing Flaky Test In
TestGenerateTableFetch
URL: https://github.com/apache/nifi/pull/6754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
exceptionfactory commented on code in PR #6480:
URL: https://github.com/apache/nifi/pull/6480#discussion_r1044616560
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateFakeRecord.java:
##
@@ -0,0 +1,1021
arpadboda closed pull request #1470: MINIFICPP-2010 Disable systemd on non-linux
URL: https://github.com/apache/nifi-minifi-cpp/pull/1470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044596070
##
extensions/sftp/tests/ListSFTPTests.cpp:
##
@@ -139,15 +139,8 @@ class ListSFTPTestsFixture {
std::fstream file;
std::stringstream ss;
ss
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044593149
##
extensions/standard-processors/tests/unit/TailFileTests.cpp:
##
@@ -99,18 +89,16 @@ TEST_CASE("TailFile reads the file until the first
delimiter",
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044592592
##
libminifi/src/core/ProcessSessionReadCallback.cpp:
##
@@ -22,18 +22,19 @@
#include
#include
#include
+#include
#include
martinzink commented on code in PR #1424:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1424#discussion_r1044592071
##
libminifi/test/rocksdb-tests/EncryptionTests.cpp:
##
@@ -77,8 +75,8 @@ TEST_CASE_METHOD(FFRepoFixture, "FlowFileRepository creates
checkpoint and loads
701 - 800 of 40571 matches
Mail list logo
