[jira] [Commented] (NIFI-3579) Nifi Failed to Start: nio Files.getFileStore(Path) is buggy in Windows

[Puspendu Banerjee (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906039#comment-15906039
 ] 

Puspendu Banerjee commented on NIFI-3579:
-

Hi [~mosermw]! 
The ./content_repository actually exists, but NIO based implementation thinks 
that it doesn't, whereas the io based implementation calculates the size 
correctly .
Can you please run the sample code that I have share here.
Here goes my output:
{quote}
==>c:\Users\puspendu
190.77246GB
190.77246GB
==>D:\workspace\nifi
98.96289GB
java.nio.file.NoSuchFileException: D:\workspace\nifi
{quote}

> Nifi Failed to Start: nio Files.getFileStore(Path) is buggy in Windows
> --
>
> Key: NIFI-3579
> URL: https://issues.apache.org/jira/browse/NIFI-3579
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0, 1.1.1
> Environment: Win 10 with Oracle JDK 1.8.0_121 on NTFS
>Reporter: Puspendu Banerjee
>Assignee: Puspendu Banerjee
>Priority: Critical
>  Labels: windows
> Attachments: nifi-app.log
>
>
> Nifi is failing to start due to IOException originating from 
> FileSystemRepository during calls to {code:java}
> Files.getFileStore(path).getTotalSpace();
> Files.getFileStore(path).getUsableSpace();
>  {code} with a read-access denied status.
> It looks like a buggy JDK implementation as on the other hand the following 
> code is yielding result:
> {code:java}
> path.toFile().getTotalSpace();
> path.toFile().getUsableSpace();
> {code}
> Interestingly, the both of the codes are yielding same results for C:\ or 
> System Drive.
> *sample*
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.file.Files;
> import java.nio.file.Path;
> import java.nio.file.Paths;
> import java.util.Arrays;
> import static java.lang.System.out;
> public class Blah {
> public static void main(String [] args) throws IOException{
> String [] _paths= {"D:\\workspace\\nifi", "c:\\Program Files"};
> final float divisor=1024 * 1024 * 1024f;
> for(String _path : _paths) {
> try {
> Path path = Paths.get(_path);
> out.println(path.toFile().getTotalSpace() /divisor  + "GB");
> out.println(Files.getFileStore(path).getTotalSpace()/divisor 
> +"GB");
> }catch (Exception ex){
> ex.printStackTrace();
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906011#comment-15906011
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r105522726
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,9 +1131,9 @@ public boolean accept(final File dir, final String 
filename) {
 process = builder.start();
 handleLogging(process);
 
-pid = getPid(process, defaultLogger);
+pid = OSUtil.getProcessId(process, defaultLogger);
 if (pid == null) {
-cmdLogger.info("Launched Apache NiFi but could not 
obtain the Process ID");
+cmdLogger.error("Launched Apache NiFi but could 
not obtain the Process ID");
--- End diff --

Hi @alopresto , it should be warn. good catch. I shall change in-place.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1586: NIFI-3586: Fix for retrieving ProcessID for NiFi un...

[PuspenduBanerjee]

Github user PuspenduBanerjee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r105522726
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,9 +1131,9 @@ public boolean accept(final File dir, final String 
filename) {
 process = builder.start();
 handleLogging(process);
 
-pid = getPid(process, defaultLogger);
+pid = OSUtil.getProcessId(process, defaultLogger);
 if (pid == null) {
-cmdLogger.info("Launched Apache NiFi but could not 
obtain the Process ID");
+cmdLogger.error("Launched Apache NiFi but could 
not obtain the Process ID");
--- End diff --

Hi @alopresto , it should be warn. good catch. I shall change in-place.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-3575) Can lose entire process group when moving components into it from parent PG

[Andy LoPresto (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andy LoPresto updated NIFI-3575:

Resolution: Fixed
Status: Resolved  (was: Patch Available)

> Can lose entire process group when moving components into it from parent PG
> ---
>
> Key: NIFI-3575
> URL: https://issues.apache.org/jira/browse/NIFI-3575
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
>Priority: Critical
> Fix For: 1.2.0
>
>
> When you move any component from the parent group and drag and drop it into a 
> process group, if you immediately enter the process group (within 
> approximately half a second) the process group will cease to exist (even if 
> it had contents already). 
> If the UI renders the graph initially, attempting to refreshing the canvas 
> returns "Unable to locate group with id: ". 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3575) Can lose entire process group when moving components into it from parent PG

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906003#comment-15906003
 ] 

ASF GitHub Bot commented on NIFI-3575:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1582


> Can lose entire process group when moving components into it from parent PG
> ---
>
> Key: NIFI-3575
> URL: https://issues.apache.org/jira/browse/NIFI-3575
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
>Priority: Critical
> Fix For: 1.2.0
>
>
> When you move any component from the parent group and drag and drop it into a 
> process group, if you immediately enter the process group (within 
> approximately half a second) the process group will cease to exist (even if 
> it had contents already). 
> If the UI renders the graph initially, attempting to refreshing the canvas 
> returns "Unable to locate group with id: ". 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3575) Can lose entire process group when moving components into it from parent PG

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906004#comment-15906004
 ] 

ASF GitHub Bot commented on NIFI-3575:
--

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1582
  
Ran contrib-check and tests and verified that the behavior was no longer 
possible. Merged. 


> Can lose entire process group when moving components into it from parent PG
> ---
>
> Key: NIFI-3575
> URL: https://issues.apache.org/jira/browse/NIFI-3575
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
>Priority: Critical
> Fix For: 1.2.0
>
>
> When you move any component from the parent group and drag and drop it into a 
> process group, if you immediately enter the process group (within 
> approximately half a second) the process group will cease to exist (even if 
> it had contents already). 
> If the UI renders the graph initially, attempting to refreshing the canvas 
> returns "Unable to locate group with id: ". 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1582: NIFI-3575: Prevent unintended move events

[alopresto]

Github user alopresto commented on the issue:

https://github.com/apache/nifi/pull/1582
  
Ran contrib-check and tests and verified that the behavior was no longer 
possible. Merged. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1582: NIFI-3575: Prevent unintended move events

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1582


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3575) Can lose entire process group when moving components into it from parent PG

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906002#comment-15906002
 ] 

ASF subversion and git services commented on NIFI-3575:
---

Commit 977aa6919cd97dacb1214c631f7055646e109472 in nifi's branch 
refs/heads/master from [~mcgilman]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=977aa69 ]

NIFI-3575:
- Verify that when moving a snippet, we do not attempt to move a process group 
into itself.
- Update the UI to ensure a subsequent move event cannot be triggered while a 
previous move event is still in progress.

This closes #1582.

Signed-off-by: Andy LoPresto 


> Can lose entire process group when moving components into it from parent PG
> ---
>
> Key: NIFI-3575
> URL: https://issues.apache.org/jira/browse/NIFI-3575
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
>Priority: Critical
> Fix For: 1.2.0
>
>
> When you move any component from the parent group and drag and drop it into a 
> process group, if you immediately enter the process group (within 
> approximately half a second) the process group will cease to exist (even if 
> it had contents already). 
> If the UI renders the graph initially, attempting to refreshing the canvas 
> returns "Unable to locate group with id: ". 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15906000#comment-15906000
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r105521647
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,9 +1131,9 @@ public boolean accept(final File dir, final String 
filename) {
 process = builder.start();
 handleLogging(process);
 
-pid = getPid(process, defaultLogger);
+pid = OSUtil.getProcessId(process, defaultLogger);
 if (pid == null) {
-cmdLogger.info("Launched Apache NiFi but could not 
obtain the Process ID");
+cmdLogger.error("Launched Apache NiFi but could 
not obtain the Process ID");
--- End diff --

Why is this at `error` level when the same message above is at `warn`?


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1586: NIFI-3586: Fix for retrieving ProcessID for NiFi un...

[alopresto]

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1586#discussion_r105521647
  
--- Diff: 
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java ---
@@ -1131,9 +1131,9 @@ public boolean accept(final File dir, final String 
filename) {
 process = builder.start();
 handleLogging(process);
 
-pid = getPid(process, defaultLogger);
+pid = OSUtil.getProcessId(process, defaultLogger);
 if (pid == null) {
-cmdLogger.info("Launched Apache NiFi but could not 
obtain the Process ID");
+cmdLogger.error("Launched Apache NiFi but could 
not obtain the Process ID");
--- End diff --

Why is this at `error` level when the same message above is at `warn`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3575) Can lose entire process group when moving components into it from parent PG

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905978#comment-15905978
 ] 

ASF GitHub Bot commented on NIFI-3575:
--

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1582#discussion_r105520036
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
 ---
@@ -2261,6 +2262,23 @@ private void verifyContents(final Snippet snippet) 
throws NullPointerException,
 }
 
 /**
+ * Verifies the a move request cannot attempt to move a process group 
into itself.
--- End diff --

Fixed this typo locally, will merge. 


> Can lose entire process group when moving components into it from parent PG
> ---
>
> Key: NIFI-3575
> URL: https://issues.apache.org/jira/browse/NIFI-3575
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.1.1
>Reporter: Joseph Percivall
>Assignee: Matt Gilman
>Priority: Critical
> Fix For: 1.2.0
>
>
> When you move any component from the parent group and drag and drop it into a 
> process group, if you immediately enter the process group (within 
> approximately half a second) the process group will cease to exist (even if 
> it had contents already). 
> If the UI renders the graph initially, attempting to refreshing the canvas 
> returns "Unable to locate group with id: ". 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1582: NIFI-3575: Prevent unintended move events

[alopresto]

Github user alopresto commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1582#discussion_r105520036
  
--- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java
 ---
@@ -2261,6 +2262,23 @@ private void verifyContents(final Snippet snippet) 
throws NullPointerException,
 }
 
 /**
+ * Verifies the a move request cannot attempt to move a process group 
into itself.
--- End diff --

Fixed this typo locally, will merge. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3587) Nifi build fails for CEF Parser when Language is not English

[Andre F de Miranda (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905913#comment-15905913
 ] 

Andre F de Miranda commented on NIFI-3587:
--

I will release a new version when I am satisfied the code fixes the issue, 
something I am still waiting on feedback to assert. 

 just keep an eye on the ticket you duplicated in irder to be kept up to date 
on this issue 

> Nifi build fails for CEF Parser when Language is not English
> 
>
> Key: NIFI-3587
> URL: https://issues.apache.org/jira/browse/NIFI-3587
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
> Environment: Junit
>Reporter: Puspendu Banerjee
>
> Nifi build fails for CEF Parser when Language is not English. The issue in 
> ParCEFone library has been fixed at version 1.2.1-SNAPSHOT at 
> [GitHub|https://github.com/fluenda/ParCEFone/commit/45d97c1002f2dfcbdc2ddf32e682f8b6a5f30e34]
> [~trixpan] as ParCEFone is your creation, please release a new version and 
> incorporate.
> {quote}
> [pool-1-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=94d0782a-389f-4830-aff7-5ca1a5df0997] Failed to parse 
> FlowFile[0,197280016436937.mockFlowFile,25B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-2-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-2-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=5cbfd906-9933-461a-9ea8-5acb57eda4d8] Failed to parse 
> FlowFile[0,197280050157962.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-3-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-3-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=ff52d793-ee5b-497e-95a6-422bd27fc3fb] Failed to parse 
> FlowFile[0,197280060692476.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-4-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-4-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=83c6c134-04f2-4344-8978-534ef603dfb6] Failed to parse 
> FlowFile[0,197280063882911.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-5-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-5-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=f3f25e5f-df5a-4958-831d-f76f0c538185] Failed to parse 
> FlowFile[0,197280066272777.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-6-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-6-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=360ff998-772b-4686-9bf5-4f14b187c41a] Failed to parse 
> FlowFile[0,197280073146699.mockFlowFile,529B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (NIFI-3587) Nifi build fails for CEF Parser when Language is not English

[Andre F de Miranda (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andre F de Miranda resolved NIFI-3587.
--
Resolution: Duplicate

> Nifi build fails for CEF Parser when Language is not English
> 
>
> Key: NIFI-3587
> URL: https://issues.apache.org/jira/browse/NIFI-3587
> Project: Apache NiFi
>  Issue Type: Bug
>Affects Versions: 1.2.0
> Environment: Junit
>Reporter: Puspendu Banerjee
>
> Nifi build fails for CEF Parser when Language is not English. The issue in 
> ParCEFone library has been fixed at version 1.2.1-SNAPSHOT at 
> [GitHub|https://github.com/fluenda/ParCEFone/commit/45d97c1002f2dfcbdc2ddf32e682f8b6a5f30e34]
> [~trixpan] as ParCEFone is your creation, please release a new version and 
> incorporate.
> {quote}
> [pool-1-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=94d0782a-389f-4830-aff7-5ca1a5df0997] Failed to parse 
> FlowFile[0,197280016436937.mockFlowFile,25B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-2-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-2-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=5cbfd906-9933-461a-9ea8-5acb57eda4d8] Failed to parse 
> FlowFile[0,197280050157962.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-3-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-3-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=ff52d793-ee5b-497e-95a6-422bd27fc3fb] Failed to parse 
> FlowFile[0,197280060692476.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-4-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-4-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=83c6c134-04f2-4344-8978-534ef603dfb6] Failed to parse 
> FlowFile[0,197280063882911.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-5-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-5-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=f3f25e5f-df5a-4958-831d-f76f0c538185] Failed to parse 
> FlowFile[0,197280066272777.mockFlowFile,422B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> [pool-6-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
> com.fluenda.parcefone.event.CEFHandlingException: Error setting value to 
> field rt
> [pool-6-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
> ParseCEF[id=360ff998-772b-4686-9bf5-4f14b187c41a] Failed to parse 
> FlowFile[0,197280073146699.mockFlowFile,529B] as a CEF message: it does not 
> conform to the CEF standard; routing to failure
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (NIFI-3587) Nifi build fails for CEF Parser when Language is not English

[Puspendu Banerjee (JIRA)]

Puspendu Banerjee created NIFI-3587:
---

 Summary: Nifi build fails for CEF Parser when Language is not 
English
 Key: NIFI-3587
 URL: https://issues.apache.org/jira/browse/NIFI-3587
 Project: Apache NiFi
  Issue Type: Bug
Affects Versions: 1.2.0
 Environment: Junit
Reporter: Puspendu Banerjee


Nifi build fails for CEF Parser when Language is not English. The issue in 
ParCEFone library has been fixed at version 1.2.1-SNAPSHOT at 
[GitHub|https://github.com/fluenda/ParCEFone/commit/45d97c1002f2dfcbdc2ddf32e682f8b6a5f30e34]
[~trixpan] as ParCEFone is your creation, please release a new version and 
incorporate.

{quote}
[pool-1-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
ParseCEF[id=94d0782a-389f-4830-aff7-5ca1a5df0997] Failed to parse 
FlowFile[0,197280016436937.mockFlowFile,25B] as a CEF message: it does not 
conform to the CEF standard; routing to failure
[pool-2-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
com.fluenda.parcefone.event.CEFHandlingException: Error setting value to field 
rt
[pool-2-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
ParseCEF[id=5cbfd906-9933-461a-9ea8-5acb57eda4d8] Failed to parse 
FlowFile[0,197280050157962.mockFlowFile,422B] as a CEF message: it does not 
conform to the CEF standard; routing to failure
[pool-3-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
com.fluenda.parcefone.event.CEFHandlingException: Error setting value to field 
rt
[pool-3-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
ParseCEF[id=ff52d793-ee5b-497e-95a6-422bd27fc3fb] Failed to parse 
FlowFile[0,197280060692476.mockFlowFile,422B] as a CEF message: it does not 
conform to the CEF standard; routing to failure
[pool-4-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
com.fluenda.parcefone.event.CEFHandlingException: Error setting value to field 
rt
[pool-4-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
ParseCEF[id=83c6c134-04f2-4344-8978-534ef603dfb6] Failed to parse 
FlowFile[0,197280063882911.mockFlowFile,422B] as a CEF message: it does not 
conform to the CEF standard; routing to failure
[pool-5-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
com.fluenda.parcefone.event.CEFHandlingException: Error setting value to field 
rt
[pool-5-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
ParseCEF[id=f3f25e5f-df5a-4958-831d-f76f0c538185] Failed to parse 
FlowFile[0,197280066272777.mockFlowFile,422B] as a CEF message: it does not 
conform to the CEF standard; routing to failure
[pool-6-thread-1] ERROR com.fluenda.parcefone.parser.CEFParser - 
com.fluenda.parcefone.event.CEFHandlingException: Error setting value to field 
rt
[pool-6-thread-1] ERROR org.apache.nifi.processors.standard.ParseCEF - 
ParseCEF[id=360ff998-772b-4686-9bf5-4f14b187c41a] Failed to parse 
FlowFile[0,197280073146699.mockFlowFile,529B] as a CEF message: it does not 
conform to the CEF standard; routing to failure
{quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-2907) Schema for flow.xml outdated

[James Wing (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905893#comment-15905893
 ] 

James Wing commented on NIFI-2907:
--

I made a list of recent changes to StandardFlowSerializer and related changes 
to FlowConfiguration.xsd.  Good news, Bryan Rosander already fixed most of the 
outstanding items for NIFI-3138, which is waiting to go in 1.2.0.  That 
includes Mikhail's transportProtocol error above.  I believe the *template* 
element issue is the only outstanding item not yet in 1.2.0.

||Date||Ticket||Focus||Serializer||XSD||Elements||
|2017-03-06|[NIFI-3541|https://issues.apache.org/jira/browse/NIFI-3541]|RPG 
network interface|yes|yes|networkInterface|
|2016-12-07|[NIFI-3138|https://issues.apache.org/jira/browse/NIFI-3138]|RPG 
multiple URLs, HTTPS site-to-site|no|yes|urls, transportProtocol, proxyHost, 
proxyPort, proxyUser, proxyPassword|
|2016-12-02|[NIFI-3026|https://issues.apache.org/jira/browse/NIFI-3026]|RPG 
multiple URLs|yes|above|urls|
|2016-11-08|[NIFI-401|https://issues.apache.org/jira/browse/NIFI-401]|Processor 
execution node|yes|yes|executionNode|
|2016-07-20|[NIFI-2326|https://issues.apache.org/jira/browse/NIFI-2326]|(whitespace
 only)| | | |
|2016-07-17|[NIFI-2033|https://issues.apache.org/jira/browse/NIFI-2033]|Controller
 services at controller level|yes|ok|controllerServices|
|2016-06-09|[NIFI-1857|https://issues.apache.org/jira/browse/NIFI-1857]|HTTPS 
site-to-site|yes|above|transportProtocol, proxyHost, proxyPort, proxyUser, 
proxyPassword|
|2016-06-08|[NIFI-1052|https://issues.apache.org/jira/browse/NIFI-1052]|Ghost 
processors, services|yes|ok|class|
|2016-05-16|[NIFI-1801|https://issues.apache.org/jira/browse/NIFI-1801]|Templates
 in process groups|yes|*no*|*template*|
|2016-05-11|[NIFI-1800|https://issues.apache.org/jira/browse/NIFI-1800]|Controller
 services in process groups|yes|yes|controllerService|
|2016-03-11|[NIFI-1464|https://issues.apache.org/jira/browse/NIFI-1464]|RPG 
compression|yes|ok|useCompression|

> Schema for flow.xml outdated
> 
>
> Key: NIFI-2907
> URL: https://issues.apache.org/jira/browse/NIFI-2907
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Mark Payne
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.2.0
>
>
> The schema that the framework uses to validate the flow.xml file is outdated. 
> It does not account for the the 'template' element in the flow. As a result, 
> it logs the following error on startup, within the bootstrap.log file:
> 2016-10-17 09:45:12,784 ERROR [NiFi logging handler] org.apache.nifi.StdErr 
> [Error] :10:38: cvc-complex-type.2.4.a: Invalid content was found starting 
> with element 'template'. One of '{processor, inputPort, outputPort, label, 
> funnel, processGroup, remoteProcessGroup, connection, controllerService}' is 
> expected.
> We should add the 'template' element to the schema and ensure that all other 
> elements are accounted for



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3585) DB Adapter for MS SQL 2008

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905831#comment-15905831
 ] 

ASF GitHub Bot commented on NIFI-3585:
--

Github user jfrazee commented on the issue:

https://github.com/apache/nifi/pull/1584
  
@mattyb149 I think I'll be able to say LGTM if this `orderByClause` thing 
gets fixed. Right now I think it only works on tables where the max value 
column is ID.


> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1584: NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008

[jfrazee]

Github user jfrazee commented on the issue:

https://github.com/apache/nifi/pull/1584
  
@mattyb149 I think I'll be able to say LGTM if this `orderByClause` thing 
gets fixed. Right now I think it only works on tables where the max value 
column is ID.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3585) DB Adapter for MS SQL 2008

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905829#comment-15905829
 ] 

ASF GitHub Bot commented on NIFI-3585:
--

Github user jfrazee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1584#discussion_r105506187
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/MSSQL2008DatabaseAdapter.java
 ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db.impl;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.processors.standard.db.DatabaseAdapter;
+
+/**
+ * A database adapter that generates MS SQL Compatible SQL for version 
2008.
+ */
+public class MSSQL2008DatabaseAdapter implements DatabaseAdapter {
+@Override
+public String getName() {
+return "MS SQL 2008";
+}
+
+@Override
+public String getDescription() {
+return "Generates MS SQL Compatible SQL for version 2008";
+}
+
+@Override
+public String getSelectStatement(String tableName, String columnNames, 
String whereClause, String orderByClause, Long limit, Long offset) {
+if (StringUtils.isEmpty(tableName)) {
+throw new IllegalArgumentException("Table name cannot be null 
or empty");
+}
+
+final StringBuilder query = new StringBuilder("SELECT ");
+
+// If this is a limit query and not a paging query then use TOP in 
MS SQL
+if (limit != null) {
+
+if (offset != null) {
+query.append("* FROM (SELECT ");
+}
+final long effectiveOffset = (offset == null) ? 0 : offset;
+if (effectiveOffset + limit > 0) {
+query.append("TOP ");
+query.append(effectiveOffset + limit);
+query.append(" ");
+}
+}
+
+if (StringUtils.isEmpty(columnNames) || 
columnNames.trim().equals("*")) {
+query.append("*");
+} else {
+query.append(columnNames);
+}
+
+if (limit != null && offset != null) {
+query.append(", ROW_NUMBER() OVER(ORDER BY ID asc) rnum");
--- End diff --

@mattyb149 I don't think there's a guarantee that the `ORDBER BY` column is 
`ID`. You meant for this to be `orderByClause`, right?


> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1584: NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008

[jfrazee]

Github user jfrazee commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1584#discussion_r105506187
  
--- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/impl/MSSQL2008DatabaseAdapter.java
 ---
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.standard.db.impl;
+
+import org.apache.commons.lang3.StringUtils;
+import org.apache.nifi.processors.standard.db.DatabaseAdapter;
+
+/**
+ * A database adapter that generates MS SQL Compatible SQL for version 
2008.
+ */
+public class MSSQL2008DatabaseAdapter implements DatabaseAdapter {
+@Override
+public String getName() {
+return "MS SQL 2008";
+}
+
+@Override
+public String getDescription() {
+return "Generates MS SQL Compatible SQL for version 2008";
+}
+
+@Override
+public String getSelectStatement(String tableName, String columnNames, 
String whereClause, String orderByClause, Long limit, Long offset) {
+if (StringUtils.isEmpty(tableName)) {
+throw new IllegalArgumentException("Table name cannot be null 
or empty");
+}
+
+final StringBuilder query = new StringBuilder("SELECT ");
+
+// If this is a limit query and not a paging query then use TOP in 
MS SQL
+if (limit != null) {
+
+if (offset != null) {
+query.append("* FROM (SELECT ");
+}
+final long effectiveOffset = (offset == null) ? 0 : offset;
+if (effectiveOffset + limit > 0) {
+query.append("TOP ");
+query.append(effectiveOffset + limit);
+query.append(" ");
+}
+}
+
+if (StringUtils.isEmpty(columnNames) || 
columnNames.trim().equals("*")) {
+query.append("*");
+} else {
+query.append(columnNames);
+}
+
+if (limit != null && offset != null) {
+query.append(", ROW_NUMBER() OVER(ORDER BY ID asc) rnum");
--- End diff --

@mattyb149 I don't think there's a guarantee that the `ORDBER BY` column is 
`ID`. You meant for this to be `orderByClause`, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3579) Nifi Failed to Start: nio Files.getFileStore(Path) is buggy in Windows

[Michael Moser (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905823#comment-15905823
 ] 

Michael Moser commented on NIFI-3579:
-

I confirmed that if the ./content_repository directory does not exist, then 
Files.getFileStore(path) throws NoSuchFileException.   
path.toFile().getTotalSpace() succeeds, however, but returns 0.  I have a 
feeling that FileSystemRepository won't work very well if it thinks it's 
capacity it 0.

Since ./content_repository is created in the FileSystemRepository constructor 
(just 50 lines higher), maybe we should verify that the OS thinks the directory 
exists before moving on?

> Nifi Failed to Start: nio Files.getFileStore(Path) is buggy in Windows
> --
>
> Key: NIFI-3579
> URL: https://issues.apache.org/jira/browse/NIFI-3579
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.2.0, 1.1.1
> Environment: Win 10 with Oracle JDK 1.8.0_121 on NTFS
>Reporter: Puspendu Banerjee
>Assignee: Puspendu Banerjee
>Priority: Critical
>  Labels: windows
> Attachments: nifi-app.log
>
>
> Nifi is failing to start due to IOException originating from 
> FileSystemRepository during calls to {code:java}
> Files.getFileStore(path).getTotalSpace();
> Files.getFileStore(path).getUsableSpace();
>  {code} with a read-access denied status.
> It looks like a buggy JDK implementation as on the other hand the following 
> code is yielding result:
> {code:java}
> path.toFile().getTotalSpace();
> path.toFile().getUsableSpace();
> {code}
> Interestingly, the both of the codes are yielding same results for C:\ or 
> System Drive.
> *sample*
> {code:java}
> import java.io.File;
> import java.io.IOException;
> import java.nio.file.Files;
> import java.nio.file.Path;
> import java.nio.file.Paths;
> import java.util.Arrays;
> import static java.lang.System.out;
> public class Blah {
> public static void main(String [] args) throws IOException{
> String [] _paths= {"D:\\workspace\\nifi", "c:\\Program Files"};
> final float divisor=1024 * 1024 * 1024f;
> for(String _path : _paths) {
> try {
> Path path = Paths.get(_path);
> out.println(path.toFile().getTotalSpace() /divisor  + "GB");
> out.println(Files.getFileStore(path).getTotalSpace()/divisor 
> +"GB");
> }catch (Exception ex){
> ex.printStackTrace();
> }
> }
> }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3576) QueryElasticsearchHttp should have a "Not Found"/"Zero results" relationship

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905780#comment-15905780
 ] 

Joseph Percivall commented on NIFI-3576:


[~puspendu.baner...@gmail.com] nope, from my testing there is nothing emitted. 

I believe this is because when it hits this for loop[1] (where it creates the 
flowfiles to send) the hits.size() is 0 so it never does any iterations and the 
session.transfer(page, REL_SUCCESS) doesn't have any flowfiles in the list.


[1] 
https://github.com/JPercivall/nifi/blob/69b23adf1b0fdfb7e1e344c833adfbeb1f4980e5/nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/QueryElasticsearchHttp.java#L336-L336

> QueryElasticsearchHttp should have a "Not Found"/"Zero results" relationship
> 
>
> Key: NIFI-3576
> URL: https://issues.apache.org/jira/browse/NIFI-3576
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Joseph Percivall
>Priority: Minor
>
> In the event of a successful call, QueryElasticsearchHttp always drops the 
> incoming flowfile and then emits pages of results to the success 
> relationship. If the search returns no results then no pages of results are 
> emitted to the success relationship. 
> The processor should offer other options for handling when there are no 
> results returned.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905737#comment-15905737
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@joewitt Another easy-fix before doing something more complex.
I am not sure why do we need travis build for BR, FR, JP.


> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1586: NIFI-3586: Fix for retrieving ProcessID for NiFi under win...

[PuspenduBanerjee]

Github user PuspenduBanerjee commented on the issue:

https://github.com/apache/nifi/pull/1586
  
@joewitt Another easy-fix before doing something more complex.
I am not sure why do we need travis build for BR, FR, JP.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3586) Nifi is not returning PID in Windows

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905728#comment-15905728
 ] 

ASF GitHub Bot commented on NIFI-3586:
--

GitHub user PuspenduBanerjee opened a pull request:

https://github.com/apache/nifi/pull/1586

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [X] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PuspenduBanerjee/nifi NIFI-3586

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1586


commit 5bb912e111bb476fec9ccc19abb100881cf6b747
Author: Puspendu Banerjee 
Date:   2017-03-10T21:09:49Z

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.




> Nifi is not returning PID in Windows
> 
>
> Key: NIFI-3586
> URL: https://issues.apache.org/jira/browse/NIFI-3586
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Affects Versions: 1.0.0, 0.5.0, 0.6.0, 0.7.0, 1.2.0, 1.1.1, 1.0.1
> Environment: Java <=8, Windows
>Reporter: Puspendu Banerjee
>Priority: Minor
>
> Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1586: NIFI-3586: Fix for retrieving ProcessID for NiFi un...

[PuspenduBanerjee]

GitHub user PuspenduBanerjee opened a pull request:

https://github.com/apache/nifi/pull/1586

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [X] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [X] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [X] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [X] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PuspenduBanerjee/nifi NIFI-3586

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1586.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1586


commit 5bb912e111bb476fec9ccc19abb100881cf6b747
Author: Puspendu Banerjee 
Date:   2017-03-10T21:09:49Z

NIFI-3586: Fix for retrieving ProcessID for NiFi under windows.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (NIFI-3586) Nifi is not returning PID in Windows

[Puspendu Banerjee (JIRA)]

Puspendu Banerjee created NIFI-3586:
---

 Summary: Nifi is not returning PID in Windows
 Key: NIFI-3586
 URL: https://issues.apache.org/jira/browse/NIFI-3586
 Project: Apache NiFi
  Issue Type: Bug
  Components: Core Framework
Affects Versions: 1.0.1, 1.1.1, 0.7.0, 0.6.0, 0.5.0, 1.0.0, 1.2.0
 Environment: Java <=8, Windows
Reporter: Puspendu Banerjee
Priority: Minor


Nifi PID is unavailable during startup under Windows



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (NIFI-3380) Multiple Versions of the Same Component

[Bryan Bende (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bryan Bende updated NIFI-3380:
--
Status: Patch Available  (was: Open)

> Multiple Versions of the Same Component
> ---
>
> Key: NIFI-3380
> URL: https://issues.apache.org/jira/browse/NIFI-3380
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Bryan Bende
>Assignee: Bryan Bende
> Fix For: 1.2.0
>
>
> This ticket is to track the work for supporting multiple versions of the same 
> component within NiFi. The overall design for this feature is described in 
> detail at the following wiki page:
> https://cwiki.apache.org/confluence/display/NIFI/Multiple+Versions+of+the+Same+Extension
> This ticket will track only the core NiFi work, and a separate ticket will be 
> created to track enhancements for the NAR Maven Plugin.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3380) Multiple Versions of the Same Component

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905625#comment-15905625
 ] 

ASF GitHub Bot commented on NIFI-3380:
--

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1585

NIFI-3380 Support Multiple Versions of the Same Component

This PR introduces support for running multiple versions of the same 
component. 

In order to make full use of this capability we need to release and updated 
version of the NAR Maven plugin (currently 1.1.0, need to release 1.2.0) and 
then update NiFi's master branch to use this new version. In this PR we have 
left it using the 1.1.0 NAR plugin, and NiFi is able to run as it normally 
does, but you can't actually run multiple versions of the same component yet 
because the framework needs the new information from the new NAR plugin.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-3380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1585


commit f965f87f3cd85ac160218f0308e4651d1e4363e0
Author: Bryan Bende 
Date:   2017-01-23T15:33:12Z

NIFI-3380 Bumping NAR plugin to 1.2.0-SNAPSHOT development to leverage 
changes from master, adding buildnumber-maven-plugin to nifi-nar-bundles to 
properly set build info in MANIFEST of NARs
- Refactoring NarDetails to include all info from MANIFEST
- Adding the concept of a Bundle and refactoring NarClassLoaders to pass 
Bundles to ExtensionManager
- Adding logic to fail start-up when multiple NARs with same coordinates 
exist, moving Bundle classes to framework API
- Refactoring bundle API to classes and creating BundleCoordinate
- Updating FlowController to use BundleCoordinate

commit 98216f00ec8ea0e8e113d7b1a5ad75db84b38bd6
Author: Matt Gilman 
Date:   2017-01-24T18:58:57Z

NIFI-3380: - Updating the UI and DTO model to support showing bundle 
details that loaded an extension type.
- Adding bundle details for processor canvas node, processor dialogs, 
controller service dialogs, and reporting task dialogs.
- Updating the formating of the bundle coordinates.
- Addressing text overflow in the configuration/details dialog.
- Fixing self referencing functions.
- Updating extension UI mapping to incorporate bundle coordinates.
- Discovering custom UIs through the supplied bundles.
- Adding verification methods for creating extensions through the rest api.
- Only returning extensions that are common amongst all nodes.
- Rendering the ghost processors using a dotted border.
- Adding bundle details to the flow.xml.
- Loading NiFi build and version details from the framework NAR.
- Removing properties for build and version details.
- Wiring together front end and back end changes.
- Including bundle coordinates in the component data model.
- Wiring together component data model and flow.xml.
- Addressing issue when resolve unvesioned dependent NARs.

commit 95cf4007b6c16f73305fad9f2ff8ed66b0794b0d
Author: Bryan Bende 
Date:   2017-01-31T17:05:40Z

NIFI-3380 Updating unit tests to pass based on framework changes
- Fixing logging of extension types during start up

commit e1782b13c71b7897a7b5105012fd2a687c9c9961
Author: Matt Gilman 
Date:   2017-02-02T21:09:45Z

NIFI-3380: - Allowing the application to start if there is a compatible 
bundle found. - Reporting missing bundle when the a compatible bundle is not 
found. - Fixing table height in new component dialogs.

commit 4b188857f59fe85ca38303b0b20448867072e18d
Author: Bryan Bende 
Date:   2017-02-03T14:39:38Z

NIFI-3380 Fixing chechstyle error and increasing test timeout for 
TestStandardControllerServiceProvider
- Adding ability to change processor type at runtime
- Adding backend code to change type for controller services

commit d71ba9d33c811d0eee3a29378c7048b5443957aa
Author: Matt Gilman 
Date:   2017-02-09T18:58:59Z

NIFI-3380:
- Cleaning up instance classloaders for temp components.
- Creating a dialog for changing the version of a component.
- Updating the formatting of the component type and bundle throughout.
- Updating the new component dialogs to support selecting source group.
- Cleaning up new component dialogs.
- Cleaning up documentation in the cluster node endpoint.

commit 8892c4a64f861ac98c6cac9370298cda444e0da8
Author: Bryan Bende 
Date:   2017-02-09T20:07:20Z

NIFI-3380 Adding missing include in nifi-web-ui pom compressor 

[GitHub] nifi pull request #1585: NIFI-3380 Support Multiple Versions of the Same Com...

[bbende]

GitHub user bbende opened a pull request:

https://github.com/apache/nifi/pull/1585

NIFI-3380 Support Multiple Versions of the Same Component

This PR introduces support for running multiple versions of the same 
component. 

In order to make full use of this capability we need to release and updated 
version of the NAR Maven plugin (currently 1.1.0, need to release 1.2.0) and 
then update NiFi's master branch to use this new version. In this PR we have 
left it using the 1.1.0 NAR plugin, and NiFi is able to run as it normally 
does, but you can't actually run multiple versions of the same component yet 
because the framework needs the new information from the new NAR plugin.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbende/nifi NIFI-3380

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1585


commit f965f87f3cd85ac160218f0308e4651d1e4363e0
Author: Bryan Bende 
Date:   2017-01-23T15:33:12Z

NIFI-3380 Bumping NAR plugin to 1.2.0-SNAPSHOT development to leverage 
changes from master, adding buildnumber-maven-plugin to nifi-nar-bundles to 
properly set build info in MANIFEST of NARs
- Refactoring NarDetails to include all info from MANIFEST
- Adding the concept of a Bundle and refactoring NarClassLoaders to pass 
Bundles to ExtensionManager
- Adding logic to fail start-up when multiple NARs with same coordinates 
exist, moving Bundle classes to framework API
- Refactoring bundle API to classes and creating BundleCoordinate
- Updating FlowController to use BundleCoordinate

commit 98216f00ec8ea0e8e113d7b1a5ad75db84b38bd6
Author: Matt Gilman 
Date:   2017-01-24T18:58:57Z

NIFI-3380: - Updating the UI and DTO model to support showing bundle 
details that loaded an extension type.
- Adding bundle details for processor canvas node, processor dialogs, 
controller service dialogs, and reporting task dialogs.
- Updating the formating of the bundle coordinates.
- Addressing text overflow in the configuration/details dialog.
- Fixing self referencing functions.
- Updating extension UI mapping to incorporate bundle coordinates.
- Discovering custom UIs through the supplied bundles.
- Adding verification methods for creating extensions through the rest api.
- Only returning extensions that are common amongst all nodes.
- Rendering the ghost processors using a dotted border.
- Adding bundle details to the flow.xml.
- Loading NiFi build and version details from the framework NAR.
- Removing properties for build and version details.
- Wiring together front end and back end changes.
- Including bundle coordinates in the component data model.
- Wiring together component data model and flow.xml.
- Addressing issue when resolve unvesioned dependent NARs.

commit 95cf4007b6c16f73305fad9f2ff8ed66b0794b0d
Author: Bryan Bende 
Date:   2017-01-31T17:05:40Z

NIFI-3380 Updating unit tests to pass based on framework changes
- Fixing logging of extension types during start up

commit e1782b13c71b7897a7b5105012fd2a687c9c9961
Author: Matt Gilman 
Date:   2017-02-02T21:09:45Z

NIFI-3380: - Allowing the application to start if there is a compatible 
bundle found. - Reporting missing bundle when the a compatible bundle is not 
found. - Fixing table height in new component dialogs.

commit 4b188857f59fe85ca38303b0b20448867072e18d
Author: Bryan Bende 
Date:   2017-02-03T14:39:38Z

NIFI-3380 Fixing chechstyle error and increasing test timeout for 
TestStandardControllerServiceProvider
- Adding ability to change processor type at runtime
- Adding backend code to change type for controller services

commit d71ba9d33c811d0eee3a29378c7048b5443957aa
Author: Matt Gilman 
Date:   2017-02-09T18:58:59Z

NIFI-3380:
- Cleaning up instance classloaders for temp components.
- Creating a dialog for changing the version of a component.
- Updating the formatting of the component type and bundle throughout.
- Updating the new component dialogs to support selecting source group.
- Cleaning up new component dialogs.
- Cleaning up documentation in the cluster node endpoint.

commit 8892c4a64f861ac98c6cac9370298cda444e0da8
Author: Bryan Bende 
Date:   2017-02-09T20:07:20Z

NIFI-3380 Adding missing include in nifi-web-ui pom compressor plugin
- Refactoring so ConfigurableComponent provides getLogger() and so the 
nodes provide the ConfigurableComponent
- Creating LoggableComponent to pass around the component, logger, and 
coordinate with in the framework

commit 

[GitHub] nifi issue #1323: NIFI-3034 update counter processor and test

[joewitt]

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1323
  
I'm hardly a git guru but what we'd like to end up with is your commits 
after the current point on master.  So first you need to pull latest master.  
Let's say 'origin' is pointing at the canonical apache nifi repository.

git fetch --all
git rebase origin/master

After this you should end up with your commits after all the other already 
merged commits.  Then you can do 'rebase -i HEAD~5' (assuming there are 5 of 
your commits at the end).  You can mark the last 4 commits in the list as 's' 
which will squash them with the first commit in the list resulting in a single 
commit.

Hopefully that helps.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3034) New Processor to use Counters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905606#comment-15905606
 ] 

ASF GitHub Bot commented on NIFI-3034:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1323
  
I'm hardly a git guru but what we'd like to end up with is your commits 
after the current point on master.  So first you need to pull latest master.  
Let's say 'origin' is pointing at the canonical apache nifi repository.

git fetch --all
git rebase origin/master

After this you should end up with your commits after all the other already 
merged commits.  Then you can do 'rebase -i HEAD~5' (assuming there are 5 of 
your commits at the end).  You can mark the last 4 commits in the list as 's' 
which will squash them with the first commit in the list resulting in a single 
commit.

Hopefully that helps.



> New Processor to use Counters
> -
>
> Key: NIFI-3034
> URL: https://issues.apache.org/jira/browse/NIFI-3034
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Sai Peddy
>Priority: Minor
> Attachments: 0002-NIFI-3034-fixed-checkstyle-and-cleaned-up-code.patch
>
>
> The processor lets you update counters (increment and decrement). To help 
> keep track of data going through the system. This allows for use of counters 
> within the flow - not just API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1323: NIFI-3034 update counter processor and test

[joewitt]

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1323
  
@speddy93 hello.  the git commit history now is quite muddied.  Can you 
please try to create a single squashed commit representing the totality of the 
change you'd like.  Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3034) New Processor to use Counters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905599#comment-15905599
 ] 

ASF GitHub Bot commented on NIFI-3034:
--

Github user speddy93 commented on the issue:

https://github.com/apache/nifi/pull/1323
  
@joewitt Thanks for the review! Also by the looks of it above I don't 
believe I squashed my commits correctly... any recommendations on how to squash 
them? 


> New Processor to use Counters
> -
>
> Key: NIFI-3034
> URL: https://issues.apache.org/jira/browse/NIFI-3034
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Sai Peddy
>Priority: Minor
> Attachments: 0002-NIFI-3034-fixed-checkstyle-and-cleaned-up-code.patch
>
>
> The processor lets you update counters (increment and decrement). To help 
> keep track of data going through the system. This allows for use of counters 
> within the flow - not just API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1323: NIFI-3034 update counter processor and test

[speddy93]

Github user speddy93 commented on the issue:

https://github.com/apache/nifi/pull/1323
  
@joewitt Thanks for the review! Also by the looks of it above I don't 
believe I squashed my commits correctly... any recommendations on how to squash 
them? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3034) New Processor to use Counters

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905598#comment-15905598
 ] 

ASF GitHub Bot commented on NIFI-3034:
--

Github user joewitt commented on the issue:

https://github.com/apache/nifi/pull/1323
  
@speddy93 hello.  the git commit history now is quite muddied.  Can you 
please try to create a single squashed commit representing the totality of the 
change you'd like.  Thanks


> New Processor to use Counters
> -
>
> Key: NIFI-3034
> URL: https://issues.apache.org/jira/browse/NIFI-3034
> Project: Apache NiFi
>  Issue Type: New Feature
>Reporter: Sai Peddy
>Priority: Minor
> Attachments: 0002-NIFI-3034-fixed-checkstyle-and-cleaned-up-code.patch
>
>
> The processor lets you update counters (increment and decrement). To help 
> keep track of data going through the system. This allows for use of counters 
> within the flow - not just API.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (NIFI-2907) Schema for flow.xml outdated

[James Wing (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Wing reassigned NIFI-2907:


Assignee: James Wing

> Schema for flow.xml outdated
> 
>
> Key: NIFI-2907
> URL: https://issues.apache.org/jira/browse/NIFI-2907
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Mark Payne
>Assignee: James Wing
>Priority: Minor
> Fix For: 1.2.0
>
>
> The schema that the framework uses to validate the flow.xml file is outdated. 
> It does not account for the the 'template' element in the flow. As a result, 
> it logs the following error on startup, within the bootstrap.log file:
> 2016-10-17 09:45:12,784 ERROR [NiFi logging handler] org.apache.nifi.StdErr 
> [Error] :10:38: cvc-complex-type.2.4.a: Invalid content was found starting 
> with element 'template'. One of '{processor, inputPort, outputPort, label, 
> funnel, processGroup, remoteProcessGroup, connection, controllerService}' is 
> expected.
> We should add the 'template' element to the schema and ensure that all other 
> elements are accounted for



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3585) DB Adapter for MS SQL 2008

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905576#comment-15905576
 ] 

ASF GitHub Bot commented on NIFI-3585:
--

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1584

NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-3585

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1584


commit 30efa7234185ee2c059a326e9f4c62d8b6c1cffc
Author: Matt Burgess 
Date:   2017-03-10T19:16:07Z

NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008




> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3585) DB Adapter for MS SQL 2008

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905577#comment-15905577
 ] 

ASF GitHub Bot commented on NIFI-3585:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1584
  
@patricker do you mind taking a look at this? I am no MS SQL expert by any 
means, but I tested GenerateTableFetch and QueryDatabaseTable and they seem ok 
to me.


> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (NIFI-3585) DB Adapter for MS SQL 2008

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3585:
---
Status: Patch Available  (was: In Progress)

> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1584: NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1584
  
@patricker do you mind taking a look at this? I am no MS SQL expert by any 
means, but I tested GenerateTableFetch and QueryDatabaseTable and they seem ok 
to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1584: NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008

[mattyb149]

GitHub user mattyb149 opened a pull request:

https://github.com/apache/nifi/pull/1584

NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [x] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [x] Is your initial contribution a single, squashed commit?

### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mattyb149/nifi NIFI-3585

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1584.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1584


commit 30efa7234185ee2c059a326e9f4c62d8b6c1cffc
Author: Matt Burgess 
Date:   2017-03-10T19:16:07Z

NIFI-3585: Add DatabaseAdapter impl for MS SQL 2008




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-2907) Schema for flow.xml outdated

[James Wing (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-2907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905547#comment-15905547
 ] 

James Wing commented on NIFI-2907:
--

Reported by Mikhail on the users list:

bq. 2017-03-10 05:37:13,330 ERROR \[NiFi logging handler] 
org.apache.nifi.StdErr \[Error] :3355:26: cvc-complex-type.2.4.a: Invalid 
content was found starting with element 'transportProtocol'. One of 
'{inputPort, outputPort}' is expected.

> Schema for flow.xml outdated
> 
>
> Key: NIFI-2907
> URL: https://issues.apache.org/jira/browse/NIFI-2907
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework
>Reporter: Mark Payne
>Priority: Minor
> Fix For: 1.2.0
>
>
> The schema that the framework uses to validate the flow.xml file is outdated. 
> It does not account for the the 'template' element in the flow. As a result, 
> it logs the following error on startup, within the bootstrap.log file:
> 2016-10-17 09:45:12,784 ERROR [NiFi logging handler] org.apache.nifi.StdErr 
> [Error] :10:38: cvc-complex-type.2.4.a: Invalid content was found starting 
> with element 'template'. One of '{processor, inputPort, outputPort, label, 
> funnel, processGroup, remoteProcessGroup, connection, controllerService}' is 
> expected.
> We should add the 'template' element to the schema and ensure that all other 
> elements are accounted for



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi-minifi-cpp issue #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/YAML_SU...

[benqiu2016]

Github user benqiu2016 commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/66
  
Instead of commenting on every macro, perhaps an alternative is to, at 
build time, include files that are appropriate to your unit. If you want YAML, 
have a configuration class that's only built as a result of Yaml. This may 
require having a different directory or including specific files but that's 
better than the definitions here. 
Above is ideal, still we need to have some #define in the caller to 
indicate which one to call or we need to have two set of files, one is just 
stub if the feature was disable, one has the feature dependent stuff.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/...

[benqiu2016]

Github user benqiu2016 commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/66#discussion_r105460203
  
--- Diff: libminifi/src/io/TLSSocket.cpp ---
@@ -20,23 +20,29 @@
 #include "Configure.h"
--- End diff --

same as above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/...

[benqiu2016]

Github user benqiu2016 commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/66#discussion_r105460135
  
--- Diff: libminifi/include/io/TLSSocket.h ---
@@ -24,8 +24,10 @@
 #include 
--- End diff --

it is difficult because we need to add more # define in other files. I 
tried that before


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-1352) Add ability to add a zip comment in MergeContent

[Gray Gwizdz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gray Gwizdz updated NIFI-1352:
--
Attachment: 0001-NIFI-1352-Add-ability-to-add-a-zip-comment-in-MergeC.patch

That's a fantastic bit of code, thanks for sharing! I've just implemented your 
recommended change and re-patched, please let me know if you see anything else 
and I'll be happy to make updates.

Thanks!
Gray

> Add ability to add a zip comment in MergeContent
> 
>
> Key: NIFI-1352
> URL: https://issues.apache.org/jira/browse/NIFI-1352
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Brandon DeVries
>Assignee: Gray Gwizdz
>Priority: Trivial
> Attachments: 
> 0001-NIFI-1352-Add-ability-to-add-a-zip-comment-in-MergeC.patch
>
>
> The Zip format includes a file comment, which can be written with a 
> ZipOutputStream \[1\].  Modify MergeContent to optionally include a comment 
> (possibly via a "zip.comment" attribute or something...).
> \[1\] 
> https://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipOutputStream.html#setComment%28java.lang.String%29



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (NIFI-1352) Add ability to add a zip comment in MergeContent

[Gray Gwizdz (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gray Gwizdz updated NIFI-1352:
--
Attachment: (was: 
0001-NIFI-1352-Add-ability-to-add-a-zip-comment-in-MergeC.patch)

> Add ability to add a zip comment in MergeContent
> 
>
> Key: NIFI-1352
> URL: https://issues.apache.org/jira/browse/NIFI-1352
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Brandon DeVries
>Assignee: Gray Gwizdz
>Priority: Trivial
> Attachments: 
> 0001-NIFI-1352-Add-ability-to-add-a-zip-comment-in-MergeC.patch
>
>
> The Zip format includes a file comment, which can be written with a 
> ZipOutputStream \[1\].  Modify MergeContent to optionally include a comment 
> (possibly via a "zip.comment" attribute or something...).
> \[1\] 
> https://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipOutputStream.html#setComment%28java.lang.String%29



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (NIFI-3585) DB Adapter for MS SQL 2008

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3585:
---
Description: 
NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL Server 
2012+, it is not compatible with MS SQL 2008 because of its use of OFFSET and 
FETCH, e.g.

This case is to introduce support for earlier versions of SQL Server to the 
database fetching processors such as QueryDatabaseTable and GenerateTableFetch. 
It may be the case that the generated SQL is awkward and less-than-ideal (more 
like Oracle's pagination query), but this will enable those processors to 
interact with SQL Server versions prior to 2012.

  was:
Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries differently 
then other RDBMS', including a lack of "LIMIT".

This adds functionality for TOP and OFFSET/FETCH for paging of results with the 
GenerateTableFetch. 


> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> NIFI-3481 introduced a DatabaseAdapter implementation for Microsoft SQL 
> Server 2012+, it is not compatible with MS SQL 2008 because of its use of 
> OFFSET and FETCH, e.g.
> This case is to introduce support for earlier versions of SQL Server to the 
> database fetching processors such as QueryDatabaseTable and 
> GenerateTableFetch. It may be the case that the generated SQL is awkward and 
> less-than-ideal (more like Oracle's pagination query), but this will enable 
> those processors to interact with SQL Server versions prior to 2012.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (NIFI-3585) DB Adapter for MS SQL 2008

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess reassigned NIFI-3585:
--

Assignee: Matt Burgess  (was: Peter Wicks)

> DB Adapter for MS SQL 2008
> --
>
> Key: NIFI-3585
> URL: https://issues.apache.org/jira/browse/NIFI-3585
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Matt Burgess
>Assignee: Matt Burgess
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (NIFI-3585) DB Adapter for MS SQL 2008

[Matt Burgess (JIRA)]

Matt Burgess created NIFI-3585:
--

 Summary: DB Adapter for MS SQL 2008
 Key: NIFI-3585
 URL: https://issues.apache.org/jira/browse/NIFI-3585
 Project: Apache NiFi
  Issue Type: Improvement
  Components: Core Framework
Affects Versions: 1.2.0
Reporter: Matt Burgess
Assignee: Peter Wicks
Priority: Minor
 Fix For: 1.2.0


Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries differently 
then other RDBMS', including a lack of "LIMIT".

This adds functionality for TOP and OFFSET/FETCH for paging of results with the 
GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3093) HIVE Support for QueryDatabaseTable

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905417#comment-15905417
 ] 

ASF GitHub Bot commented on NIFI-3093:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1281
  
#1510 is now merged, do you mind rebasing this one? Please and thanks!


> HIVE Support for QueryDatabaseTable
> ---
>
> Key: NIFI-3093
> URL: https://issues.apache.org/jira/browse/NIFI-3093
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>
> Update Query Database Table so that it can pull data from HIVE tables.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1281: NIFI-3093 HIVE Support for QueryDatabaseTable

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1281
  
#1510 is now merged, do you mind rebasing this one? Please and thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-3481) DB Adapter for MS SQL 2012+

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3481:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3481) DB Adapter for MS SQL 2012+

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905400#comment-15905400
 ] 

ASF subversion and git services commented on NIFI-3481:
---

Commit 18f05856ffebd911a9681845434a3415a215451a in nifi's branch 
refs/heads/master from patricker
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=18f0585 ]

NIFI-3481 - Add DB Adapter for MS SQL 2012+

Signed-off-by: Matt Burgess 

NIFI-3481 Added support for Database Adapter Descriptions

Signed-off-by: Matt Burgess 

NIFI-3481 Updated Adapter Name

Signed-off-by: Matt Burgess 

This closes #1510


> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3481) DB Adapter for MS SQL 2012+

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905402#comment-15905402
 ] 

ASF subversion and git services commented on NIFI-3481:
---

Commit 18f05856ffebd911a9681845434a3415a215451a in nifi's branch 
refs/heads/master from patricker
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=18f0585 ]

NIFI-3481 - Add DB Adapter for MS SQL 2012+

Signed-off-by: Matt Burgess 

NIFI-3481 Added support for Database Adapter Descriptions

Signed-off-by: Matt Burgess 

NIFI-3481 Updated Adapter Name

Signed-off-by: Matt Burgess 

This closes #1510


> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3481) DB Adapter for MS SQL 2012+

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905398#comment-15905398
 ] 

ASF GitHub Bot commented on NIFI-3481:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1510
  
+1 LGTM, ran unit tests and contrib-check, also tested with a real NiFi 
using GenerateTableFetch and QueryDatabaseTable against SQL Server 2012. Thank 
you very much for this contribution! Merging to master.


> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (NIFI-3481) DB Adapter for MS SQL 2012+

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3481:
---
Fix Version/s: 1.2.0

> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3481) DB Adapter for MS SQL 2012+

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905401#comment-15905401
 ] 

ASF subversion and git services commented on NIFI-3481:
---

Commit 18f05856ffebd911a9681845434a3415a215451a in nifi's branch 
refs/heads/master from patricker
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=18f0585 ]

NIFI-3481 - Add DB Adapter for MS SQL 2012+

Signed-off-by: Matt Burgess 

NIFI-3481 Added support for Database Adapter Descriptions

Signed-off-by: Matt Burgess 

NIFI-3481 Updated Adapter Name

Signed-off-by: Matt Burgess 

This closes #1510


> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3481) DB Adapter for MS SQL 2012+

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905403#comment-15905403
 ] 

ASF GitHub Bot commented on NIFI-3481:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1510


> DB Adapter for MS SQL 2012+
> ---
>
> Key: NIFI-3481
> URL: https://issues.apache.org/jira/browse/NIFI-3481
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Core Framework
>Affects Versions: 1.2.0
>Reporter: Peter Wicks
>Assignee: Peter Wicks
>Priority: Minor
> Fix For: 1.2.0
>
>
> Adding a new DB Adapter for MS SQL.  MS SQL does paging of queries 
> differently then other RDBMS', including a lack of "LIMIT".
> This adds functionality for TOP and OFFSET/FETCH for paging of results with 
> the GenerateTableFetch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1510: NIFI-3481 DB Adapter for MS SQL

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1510


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1510: NIFI-3481 DB Adapter for MS SQL

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1510
  
+1 LGTM, ran unit tests and contrib-check, also tested with a real NiFi 
using GenerateTableFetch and QueryDatabaseTable against SQL Server 2012. Thank 
you very much for this contribution! Merging to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3574:
---
Resolution: Fixed
Status: Resolved  (was: Patch Available)

> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
> Fix For: 1.2.0
>
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3574:
---
Fix Version/s: 1.2.0

> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
> Fix For: 1.2.0
>
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905312#comment-15905312
 ] 

ASF subversion and git services commented on NIFI-3574:
---

Commit cd8eb775e626cca351bf24f9ae174c38d32d591b in nifi's branch 
refs/heads/master from [~bryanrosan...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=cd8eb77 ]

NIFI-3574 - PutHiveStreaming UGI fixes

Signed-off-by: Matt Burgess 

This closes #1578


> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
> Fix For: 1.2.0
>
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905313#comment-15905313
 ] 

ASF GitHub Bot commented on NIFI-3574:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1578


> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
> Fix For: 1.2.0
>
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1578


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1578: NIFI-3574 - PutHiveStreaming UGI fixes

[mattyb149]

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1578
  
+1 LGTM, ran unit tests and contrib-check, thank you for the fix! Merging 
to master


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905311#comment-15905311
 ] 

ASF GitHub Bot commented on NIFI-3574:
--

Github user mattyb149 commented on the issue:

https://github.com/apache/nifi/pull/1578
  
+1 LGTM, ran unit tests and contrib-check, thank you for the fix! Merging 
to master


> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1961) Test Resource - nifi.properties

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905276#comment-15905276
 ] 

Matt Gilman commented on NIFI-1961:
---

To provide a little more background, because NiFiProperties was previously only 
accessible as a singleton through a static getInstance() methods, tests would 
need to supply their own copy of the file in order to inject a specific value. 
Now that this is no longer the case, I'm wondering if the tests can be updated 
to mock NiFiProperties and allow us to completely remove the nifi.properties in 
test resources. I'm not sure this is the case, but would probably be the most 
desirable outcome if possible.

> Test Resource - nifi.properties
> ---
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Joseph Niemiec
>Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905255#comment-15905255
 ] 

ASF GitHub Bot commented on NIFI-3574:
--

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1578#discussion_r105418460
  
--- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java
 ---
@@ -74,7 +74,8 @@ public HiveConf getConfigurationFromFiles(final String 
configFiles) {
 
 public void preload(Configuration configuration) {
 try {
-FileSystem.get(configuration);
+FileSystem.get(configuration).close();
--- End diff --

Hey @mattyb149 

The two clusters I was testing against (secure and unsecure) were both 
configured for HA so I did test preloading with HA inadvertently :smile:


> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

[brosander]

Github user brosander commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1578#discussion_r105418460
  
--- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java
 ---
@@ -74,7 +74,8 @@ public HiveConf getConfigurationFromFiles(final String 
configFiles) {
 
 public void preload(Configuration configuration) {
 try {
-FileSystem.get(configuration);
+FileSystem.get(configuration).close();
--- End diff --

Hey @mattyb149 

The two clusters I was testing against (secure and unsecure) were both 
configured for HA so I did test preloading with HA inadvertently :smile:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Comment Edited] (NIFI-1961) Test Resource - nifi.properties

[Joseph Niemiec (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905221#comment-15905221
 ] 

Joseph Niemiec edited comment on NIFI-1961 at 3/10/17 3:10 PM:
---

So I did alittle analysis just to get started - 

There are 16 unique properties files, out of 35. Of these 16 unique (non-dupes) 
files we have 4 that are only minor lib path changes, the other 12 have a 
number of changes and will require me to compare deeper. 

{code:bash}
diff 
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
 
./nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/test/resources/conf/nifi.properties
30,31c30,32
< nifi.nar.library.directory=./target/resources/NiFiProperties/lib/
< nifi.nar.library.directory.alt=./target/resources/NiFiProperties/lib2/
---
> nifi.nar.library.directory=./target/test-classes/lib/
> nifi.nar.library.directory.alt=./target/test-classes/lib2/
>
{code}

It would seem to me the best way may be to reference the centralized 
nifi.properties somehow as a resource?  ie - 
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
 and then if they have different properties mock them to overwrite in the 
tests? 

Another idea was just to build a script that crawls, looks for differences from 
the latest and prior nifi.properties nifi-commons config from the located one.  
Then see if its properties where originally a default (prior or latest) or 
different; if different leave the changed value but produce an output report? 
And if its a prior default just update to the latest automatically? This way if 
there are tests that need an external nifi.properties file we are still 
managing them with the same method. 

This may be a bit more then trivial :) 


was (Author: josephxsxn):
So I did alittle analysis just to get started - 

There are 16 unique properties files, out of 35. Of these 16 unique (non-dupes) 
files we have 4 that are only minor lib path changes, the other 12 have a 
number of changes and will require me to compare deeper. 

{code:bash}
diff 
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
 
./nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/test/resources/conf/nifi.properties
30,31c30,32
< nifi.nar.library.directory=./target/resources/NiFiProperties/lib/
< nifi.nar.library.directory.alt=./target/resources/NiFiProperties/lib2/
---
> nifi.nar.library.directory=./target/test-classes/lib/
> nifi.nar.library.directory.alt=./target/test-classes/lib2/
>
{code}

It would seem to me the best way may be to reference the centralized 
nifi.properties somehow as a resource?  ie - 
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
 and then if they have different properties mock them to overwrite in the 
tests? 

Another idea was just to build a script that crawls, looks for differences from 
the latest and prior nifi.properties nifi-commons config from the located one.  
Then see if its properties where originally a default (prior or latest) or 
different; if different leave the changed value but produce an output report? 
And if its a prior default just update to the latest automatically? 

This may be a bit more then trivial :) 

> Test Resource - nifi.properties
> ---
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Joseph Niemiec
>Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1961) Test Resource - nifi.properties

[Joseph Niemiec (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905221#comment-15905221
 ] 

Joseph Niemiec commented on NIFI-1961:
--

So I did alittle analysis just to get started - 

There are 16 unique properties files, out of 35. Of these 16 unique (non-dupes) 
files we have 4 that are only minor lib path changes, the other 12 have a 
number of changes and will require me to compare deeper. 

{code:bash}
diff 
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
 
./nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-documentation/src/test/resources/conf/nifi.properties
30,31c30,32
< nifi.nar.library.directory=./target/resources/NiFiProperties/lib/
< nifi.nar.library.directory.alt=./target/resources/NiFiProperties/lib2/
---
> nifi.nar.library.directory=./target/test-classes/lib/
> nifi.nar.library.directory.alt=./target/test-classes/lib2/
>
{code}

It would seem to me the best way may be to reference the centralized 
nifi.properties somehow as a resource?  ie - 
./nifi-commons/nifi-properties/src/test/resources/NiFiProperties/conf/nifi.properties
 and then if they have different properties mock them to overwrite in the 
tests? 

Another idea was just to build a script that crawls, looks for differences from 
the latest and prior nifi.properties nifi-commons config from the located one.  
Then see if its properties where originally a default (prior or latest) or 
different; if different leave the changed value but produce an output report? 
And if its a prior default just update to the latest automatically? 

This may be a bit more then trivial :) 

> Test Resource - nifi.properties
> ---
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Joseph Niemiec
>Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi pull request #1578: NIFI-3574 - PutHiveStreaming UGI fixes

[mattyb149]

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1578#discussion_r105409335
  
--- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java
 ---
@@ -74,7 +74,8 @@ public HiveConf getConfigurationFromFiles(final String 
configFiles) {
 
 public void preload(Configuration configuration) {
 try {
-FileSystem.get(configuration);
+FileSystem.get(configuration).close();
--- End diff --

Did you test this with respect to why this line was added in the first 
place (High Availability clusters I think)? Just wanted to make sure it 
wouldn't introduce a regression.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905196#comment-15905196
 ] 

ASF GitHub Bot commented on NIFI-3574:
--

Github user mattyb149 commented on a diff in the pull request:

https://github.com/apache/nifi/pull/1578#discussion_r105409335
  
--- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/util/hive/HiveConfigurator.java
 ---
@@ -74,7 +74,8 @@ public HiveConf getConfigurationFromFiles(final String 
configFiles) {
 
 public void preload(Configuration configuration) {
 try {
-FileSystem.get(configuration);
+FileSystem.get(configuration).close();
--- End diff --

Did you test this with respect to why this line was added in the first 
place (High Availability clusters I think)? Just wanted to make sure it 
wouldn't introduce a regression.


> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1131) InvokeHttp relationships don't match other processors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905189#comment-15905189
 ] 

ASF GitHub Bot commented on NIFI-1131:
--

Github user josephxsxn commented on the issue:

https://github.com/apache/nifi/pull/1583
  
Trival change in names didnt impact tests. 


> InvokeHttp relationships don't match other processors
> -
>
> Key: NIFI-1131
> URL: https://issues.apache.org/jira/browse/NIFI-1131
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Joseph Percivall
>Assignee: Joseph Niemiec
>Priority: Trivial
>  Labels: newbie
>
> The current InvokeHttp relationships are "Original", "Response", "Retry", "No 
> Retry" and "Failure". They should be renamed as such:
> "Original" -> "Success Request"
> "Response" -> stays same
> "Retry" -> "Retry Request"
> "No Retry" -> "No Retry Request"
> "Failure" -> "Failure Request"
> In other processors the "Original" relationship is the unmodified original 
> flowfile but in InvokeHttp it is used as a destination for a modified 
> request. In InvokeHttp the request flowfile coming in is routed to different 
> relationships depending on the status code received and is modified with new 
> attributes.
> This would be a breaking change and would be slated for 1.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1131) InvokeHttp relationships don't match other processors

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905188#comment-15905188
 ] 

ASF GitHub Bot commented on NIFI-1131:
--

GitHub user josephxsxn opened a pull request:

https://github.com/apache/nifi/pull/1583

NIFI-1131 renamed relationships

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/josephxsxn/nifi NIFI-1131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1583


commit 7a3dc0d96db303837a05ed7be1ddbe1916850d43
Author: Joseph Niemiec 
Date:   2017-03-09T19:48:12Z

NIFI-1131 renamed relationships




> InvokeHttp relationships don't match other processors
> -
>
> Key: NIFI-1131
> URL: https://issues.apache.org/jira/browse/NIFI-1131
> Project: Apache NiFi
>  Issue Type: Improvement
>Affects Versions: 1.0.0
>Reporter: Joseph Percivall
>Assignee: Joseph Niemiec
>Priority: Trivial
>  Labels: newbie
>
> The current InvokeHttp relationships are "Original", "Response", "Retry", "No 
> Retry" and "Failure". They should be renamed as such:
> "Original" -> "Success Request"
> "Response" -> stays same
> "Retry" -> "Retry Request"
> "No Retry" -> "No Retry Request"
> "Failure" -> "Failure Request"
> In other processors the "Original" relationship is the unmodified original 
> flowfile but in InvokeHttp it is used as a destination for a modified 
> request. In InvokeHttp the request flowfile coming in is routed to different 
> relationships depending on the status code received and is modified with new 
> attributes.
> This would be a breaking change and would be slated for 1.0.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi issue #1583: NIFI-1131 renamed relationships

[josephxsxn]

Github user josephxsxn commented on the issue:

https://github.com/apache/nifi/pull/1583
  
Trival change in names didnt impact tests. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1583: NIFI-1131 renamed relationships

[josephxsxn]

GitHub user josephxsxn opened a pull request:

https://github.com/apache/nifi/pull/1583

NIFI-1131 renamed relationships

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/josephxsxn/nifi NIFI-1131

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/1583.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1583


commit 7a3dc0d96db303837a05ed7be1ddbe1916850d43
Author: Joseph Niemiec 
Date:   2017-03-09T19:48:12Z

NIFI-1131 renamed relationships




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (NIFI-1352) Add ability to add a zip comment in MergeContent

[Brandon DeVries (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905119#comment-15905119
 ] 

Brandon DeVries commented on NIFI-1352:
---

[~ggwizdz1], cool!.  Just one thought... would it be worth trying to truncate 
the comment if it is too long, rather than throwing an exception?  We do 
something similar in StandardRecordWriter.getCharsInUTF8Limit()\[1].  We can 
probably just copy and use that with a limit of 0x.

\[1] 
https://github.com/jskora/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/StandardRecordWriter.java#L219-L242

> Add ability to add a zip comment in MergeContent
> 
>
> Key: NIFI-1352
> URL: https://issues.apache.org/jira/browse/NIFI-1352
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Brandon DeVries
>Assignee: Gray Gwizdz
>Priority: Trivial
> Attachments: 
> 0001-NIFI-1352-Add-ability-to-add-a-zip-comment-in-MergeC.patch
>
>
> The Zip format includes a file comment, which can be written with a 
> ZipOutputStream \[1\].  Modify MergeContent to optionally include a comment 
> (possibly via a "zip.comment" attribute or something...).
> \[1\] 
> https://docs.oracle.com/javase/7/docs/api/java/util/zip/ZipOutputStream.html#setComment%28java.lang.String%29



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1961) Test Resource - nifi.properties

[Matt Gilman (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905097#comment-15905097
 ] 

Matt Gilman commented on NIFI-1961:
---

[~josephxsxn] Something should be done. Exactly what, I'm not sure. Many tests 
have copies of nifi.properties from the time the test was added. As the 
supported properties evolve, it becomes cumbersome to keep everything in sync. 
There was work done a bit ago to inject NiFiProperties as needed and not access 
it through a static getInstance() method. I'm not 100% but we may now be able 
to update these tests to mock the necessary method(s) in NiFiProperties and get 
rid of the copied test resources. That may be the best path forward if it's 
feasible. To find the tests, search for 'nifi.properties' in any test resources.

However, there may be some tests where this isn't possible. I know there are 
some integration tests in the web-api that stand up an instance of NiFi. Pretty 
sure we'd need to keep the nifi.properties test resources in those cases.

Thanks!

> Test Resource - nifi.properties
> ---
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Joseph Niemiec
>Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (NIFI-1961) Test Resource - nifi.properties

[Joseph Niemiec (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joseph Niemiec reassigned NIFI-1961:


Assignee: Joseph Niemiec

> Test Resource - nifi.properties
> ---
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Reporter: Matt Gilman
>Assignee: Joseph Niemiec
>Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-1961) Test Resource - nifi.properties

[Joseph Niemiec (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905064#comment-15905064
 ] 

Joseph Niemiec commented on NIFI-1961:
--

Is there still a need to get this done, ill gladdly take it up and investigate 
just merging all the files vs mocks in the tests. [~mcgilman]

> Test Resource - nifi.properties
> ---
>
> Key: NIFI-1961
> URL: https://issues.apache.org/jira/browse/NIFI-1961
> Project: Apache NiFi
>  Issue Type: Task
>  Components: Core Framework
>Reporter: Matt Gilman
>Priority: Trivial
>
> Many tests reference a copy of nifi.properties. These copies have become 
> increasingly stale with as the application has evolved. With the changes in 
> 1.x we should at the very least update the copies or better yet, update the 
> tests to mock out the necessary configuration to avoid the copies all 
> together.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] nifi-minifi-cpp issue #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/YAML_SU...

[phrocker]

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/66
  
Here's an idea. We could include the files as a result. You could make it 
so that you have only one or two macros that define, perhaps, template 
metaprogramming. Look into SFINAE. At the very least you could have only a 
handful of macro definitions instead of the numerous that exist here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/...

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/66#discussion_r105258693
  
--- Diff: libminifi/include/io/TLSSocket.h ---
@@ -24,8 +24,10 @@
 #include 
--- End diff --

Can't we just exclude this entire class from compilation without OpenSSL?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp pull request #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/...

[phrocker]

Github user phrocker commented on a diff in the pull request:

https://github.com/apache/nifi-minifi-cpp/pull/66#discussion_r105394608
  
--- Diff: libminifi/src/io/TLSSocket.cpp ---
@@ -20,23 +20,29 @@
 #include "Configure.h"
--- End diff --

The entire class should be excluded. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi-minifi-cpp issue #66: MINIFI-215: IOS port, add OPENSSL_SUPPORT/YAML_SU...

[phrocker]

Github user phrocker commented on the issue:

https://github.com/apache/nifi-minifi-cpp/pull/66
  
Instead of commenting on every macro, perhaps an alternative is to, at 
build time, include files that are appropriate to your unit. If you want YAML, 
have a configuration class that's only built as a result of Yaml. This may 
require having a different directory or including specific files but that's 
better than the definitions here. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (NIFI-3574) PutHiveStreaming affected by UserGroupInformation static side effects

[Matt Burgess (JIRA)]

 [ 
https://issues.apache.org/jira/browse/NIFI-3574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Burgess updated NIFI-3574:
---
Status: Patch Available  (was: Open)

> PutHiveStreaming affected by UserGroupInformation static side effects 
> --
>
> Key: NIFI-3574
> URL: https://issues.apache.org/jira/browse/NIFI-3574
> Project: Apache NiFi
>  Issue Type: Bug
>Reporter: Bryan Rosander
>Assignee: Bryan Rosander
>
> Currently if you point a PutHiveStreaming processor at a secure cluster, 
> start it, stop it, and then reconfigure it to point at a different unsecured 
> cluster, some state from the first connection is used by the underlying Hive 
> and Hadoop libraries when attempting to connect to the second cluster.
> This can be mitigated by ensuring that the 
> UserGroupInformation.setConfiguration() method is used in onSetup() and that 
> the approprate UserGroupInformation instance is used in ugi.doAs calls.
> In order to isolate multiple PutHiveStreaming processors, a 
> RequiresInstanceClassLoading annotation should be added to the processor.  
> This should insulate it from other static side effects.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (NIFI-3584) DBConnectionPool ControllerService

[Mohammed Nadeem (JIRA)]

Mohammed Nadeem created NIFI-3584:
-

 Summary: DBConnectionPool ControllerService
 Key: NIFI-3584
 URL: https://issues.apache.org/jira/browse/NIFI-3584
 Project: Apache NiFi
  Issue Type: Task
Reporter: Mohammed Nadeem


When I use DBConnectionPool ControllerService into Custom Processor for Oracle 
Connection its not giving me underlying Oracle Connection But it is returning 
Generic Connection. The Generic Connection can't to cast to underlying Oracle 
Connection.
Could anyone help with this please.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)