[GitHub] nifi issue #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-30 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1004 @trixpan sure... 1) mvn clean install on this branch 2) In some other directory: `mvn archetype:generate -DarchetypeGroupId=org.apache.nifi -DarchetypeArtifactId=nifi

[GitHub] nifi pull request #1097: NIFI-2865: Refactored PublishKafka and PublishKafka...

2016-10-05 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1097#discussion_r82078303 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-10-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/PublisherLease.java --- @@ -0,0

[GitHub] nifi issue #1075: NIFI-2828: Fix Hive NAR dependencies

2016-10-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1075 Tried this out on against an HDP 2.4 sandbox and got an exception that boiled down to: ``` Caused by: java.io.IOException: No FileSystem for scheme: hdfs

[GitHub] nifi issue #1097: NIFI-2865: Refactored PublishKafka and PublishKafka_0_10 t...

2016-10-05 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1097 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1097: NIFI-2865: Refactored PublishKafka and PublishKafka...

2016-10-05 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1097#discussion_r82070115 --- Diff: nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-10-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/PublishKafka_0_10.java

[GitHub] nifi issue #1038: Correcting download URIs for OTPs

2016-09-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1038 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1029: Fixed issue uploading templates into descendant Process Gr...

2016-09-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1029 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1028: Restore upstream/downstream connections dialog

2016-09-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1028 Minor comment, i noticed viewing downstream connections on input ports, the component name shows "Object object" rather than the name of the port. --- If your project is set up for it, you

[GitHub] nifi issue #1028: Restore upstream/downstream connections dialog

2016-09-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1028 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #513: PutHBaseJSON processor treats all values as Strings

2016-09-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/513 @rtempleton can you close this PR since it was included in PR 542? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1010: NIFI-2757: Site-to-Site with DN mapping

2016-09-19 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1010 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1010: NIFI-2757: Site-to-Site with DN mapping

2016-09-19 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1010 +1 looks good, verified this fixes the problem when using identity mapping with RAW site-to-site, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1047: Fix creating NiFi RPM

2016-09-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1047 @fidget83 thank you for the contribution, can you please create a JIRA that describes the problem this is trying to fix? and then update this PR to include the JIRA number. Thanks. --- If your

[GitHub] nifi issue #879: NIFI-2586 - Javadocs, ExitCode cleanup, password generation...

2016-08-18 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/879 Looks good, will merge to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #887: NIFI-2574 Fixing NPE when using kerberos keytab loca...

2016-08-18 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/887 NIFI-2574 Fixing NPE when using kerberos keytab location from context… …s, and cleaning up hadoop/hbase/hive kerberos variables You can merge this pull request into a Git repository by running

[GitHub] nifi pull request #887: NIFI-2574 Fixing NPE when using kerberos keytab loca...

2016-08-18 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/887 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #892: Updating ReportingTasks to use ComponentLogger instead of c...

2016-08-18 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/892 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #892: Updating ReportingTasks to use ComponentLogger instead of c...

2016-08-18 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/892 Looks good, verified that I can see the controller level bulletins when I have access to the reporting task, and can't when I remove access, will merge to master --- If your project is set up

[GitHub] nifi pull request #946: NIFI-2664 Moving System.setProperty for krb5.conf to...

2016-08-25 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/946 NIFI-2664 Moving System.setProperty for krb5.conf to NiFi startup, an… …d removing conflicting property from KerberosProvider config Rather than add code to all of the Kafka processors

[GitHub] nifi pull request #834: NIFI-1831 Implemented encrypted configuration capabi...

2016-08-23 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/834#discussion_r75917246 --- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy --- @@ -0,0 +1,540

[GitHub] nifi issue #834: NIFI-1831 Implemented encrypted configuration capabilities

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/834 Ok that is not working for me... If I run the tool a second time using the same password, even without changing anything I get: ``` ./nifi-toolkit-1.0.0-SNAPSHOT/bin/encrypt-config.sh -b nifi

[GitHub] nifi issue #922: NIFI-2622: Added support for complex types in SelectHiveQL

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/922 Looks good, verified this work with array and map columns, will merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #834: NIFI-1831 Implemented encrypted configuration capabilities

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/834 Performed a couple of test runs and everything is working nicely, thanks for making all the updates. My last comment is that we may need to add something to the toolkit NOTICE for Grooby

[GitHub] nifi issue #834: NIFI-1831 Implemented encrypted configuration capabilities

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/834 Running the latest commit, nifi.properties ends up with: ``` nifi.sensitive.props.key.protected=aes/gcm/128 nifi.sensitive.props.key.protected= ``` The app then fails to start because

[GitHub] nifi issue #902: NIFI-2609: Ensure that we handle URIs for Remote Process Gr...

2016-08-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/902 Looks good, will merge to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #914: Adding support for Binary Row Keys

2016-08-23 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/914#discussion_r75858286 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/AbstractPutHBase.java --- @@ -170,7 +193,7 @@ public

[GitHub] nifi pull request #834: NIFI-1831 Implemented encrypted configuration capabi...

2016-08-22 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/834#discussion_r75733078 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-properties-loader/src/main/java/org/apache/nifi/properties/AESSensitivePropertyProvider.java

[GitHub] nifi pull request #834: NIFI-1831 Implemented encrypted configuration capabi...

2016-08-22 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/834#discussion_r75728485 --- Diff: nifi-commons/nifi-properties/pom.xml --- @@ -21,4 +21,10 @@ 1.0.0-SNAPSHOT nifi-properties

[GitHub] nifi issue #834: NIFI-1831 Implemented encrypted configuration capabilities

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/834 General comment that may be outside the scope of this effort, but have we thought about being able to undo the protection using the toolkit? Basically once you have run the tool, if you overwrote your

[GitHub] nifi pull request #834: NIFI-1831 Implemented encrypted configuration capabi...

2016-08-23 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/834#discussion_r75874508 --- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy --- @@ -0,0 +1,540

[GitHub] nifi pull request #834: NIFI-1831 Implemented encrypted configuration capabi...

2016-08-23 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/834#discussion_r75870493 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties --- @@ -131,8 +131,10

[GitHub] nifi pull request #834: NIFI-1831 Implemented encrypted configuration capabi...

2016-08-23 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/834#discussion_r75871505 --- Diff: nifi-toolkit/nifi-toolkit-encrypt-config/src/test/groovy/org/apache/nifi/properties/ConfigEncryptionToolTest.groovy --- @@ -0,0 +1,1225

[GitHub] nifi pull request #914: Adding support for Binary Row Keys

2016-08-23 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/914#discussion_r75858615 --- Diff: nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseCell.java --- @@ -82,8 +84,19 @@ public void

[GitHub] nifi issue #914: Adding support for Binary Row Keys

2016-08-23 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/914 Overall this looks good, thanks Andrew! One overall comment is that we now have several places where we create a new string from a byte[] like `new String(byte[])` and I think we want

[GitHub] nifi pull request #1088: NIFI-2841 Refactoring logic in SplitAvro RecordSpli...

2016-10-03 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1088 NIFI-2841 Refactoring logic in SplitAvro RecordSplitter to avoid maki… …ng two calls in a row to reader.hasNext() You can merge this pull request into a Git repository by running: $ git pull

[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code

2016-09-26 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1057 @trixpan @pvillard31 since the three changes in question are not part of the public API we should be ok to change them as long as it is done on a second number version change (1.1.0 and not 1.0.1

[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code

2016-09-26 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1057 @pvillard31 I agree, lets remove the deprecated versions and just have the corrected versions, I'm a +1 after that change, and thanks to @trixpan for putting this together, didn't realize how many

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86839408 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java --- @@ -67,6

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86825589 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java --- @@ -67,6

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86839525 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java --- @@ -67,6

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-07 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86822779 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java --- @@ -67,6

[GitHub] nifi issue #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1156 @olegz cool thanks! regarding the per-instance vs. per-lifecycle, in this first pass we are basically loading the resources at the time the properties are applied in order to be available during

[GitHub] nifi issue #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-07 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1156 @olegz just pushed up a commit with some changes from the last round of feedback (renaming jarFile, fixing empty catch block, fixing empty IllegalArgumentException). Have you had a chance

[GitHub] nifi issue #1150: NIFI-2925: When swapping in FlowFiles, do not assume that ...

2016-10-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1150 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-10-24 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1156 NIFI-2909 and NIFI-1712 Per-Instance ClassLoading Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...

2016-10-24 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1148 Thank you for contributing. In addition to adding the expressionLanguageSupported flag on the property descriptors, we would also need to go through the code and find every place where the properties

[GitHub] nifi issue #1252: NIFI-2927: Added Validation Query to HiveConnectionPool

2016-11-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1252 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1256: NIFI-3079: Ensure that in all cases we increment session's...

2016-11-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1256 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1219: NIFI-3003 Upgrading hadoop.version to 2.7.3 & cleaning up ...

2016-11-15 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1219 PR updated to address feedback from @olegz, and incorporated licensing patch posted by @joewitt in JIRA --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #1219: NIFI-3003 Upgrading hadoop.version to 2.7.3 and fix...

2016-11-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1219#discussion_r88030428 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-nar-utils/src/main/java/org/apache/nifi/nar/InstanceClassLoader.java --- @@ -88,7 +89,7

[GitHub] nifi pull request #1219: NIFI-3003 Upgrading hadoop.version to 2.7.3 and fix...

2016-11-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1219#discussion_r88030680 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java --- @@ -205,177 +207,186

[GitHub] nifi pull request #1219: NIFI-3003 Upgrading hadoop.version to 2.7.3 and fix...

2016-11-15 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1219#discussion_r88032664 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java

[GitHub] nifi pull request #1232: NIFI-2909 Fix logic in AbstractConfiguredComponent ...

2016-11-16 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1232 NIFI-2909 Fix logic in AbstractConfiguredComponent setProperties() for setting classpath resources in the InstanceClassLoader. Before if you updated other properties that were not classpath

[GitHub] nifi pull request #1219: NIFI-3003 Upgrading hadoop.version to 2.7.3 and fix...

2016-11-14 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1219 NIFI-3003 Upgrading hadoop.version to 2.7.3 and fixing TDE issue with… Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86212571 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java --- @@ -52,23 +86,29 @@ public static ClassLoader

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86212641 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java --- @@ -24,23 +24,57 @@ import java.net.URL

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86213356 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86212943 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86212718 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java --- @@ -24,23 +24,57 @@ import java.net.URL

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86213277 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86216168 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractConfiguredComponent.java

[GitHub] nifi pull request #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1156#discussion_r86226932 --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/classloader/ClassLoaderUtils.java --- @@ -52,23 +86,29 @@ public static ClassLoader

[GitHub] nifi issue #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1156 @olegz thanks for reviewing, I posted a couple of replies to the inline comments. I also wanted to mention that after submitting this PR, I realized that a slight modification to the approach

[GitHub] nifi issue #1153: NIFI-2931: Global Policy User Actions Hidden

2016-11-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1153 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1156: NIFI-2909 and NIFI-1712 Per-Instance ClassLoading

2016-11-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1156 @olegz I pushed up a second commit that with the change that I described above, and also some of the changes from your feedback. Unfortunately I had already rebased my branch before you had started

[GitHub] nifi issue #1155: Edit Policy - Bulk user/group add

2016-10-27 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1155 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1277: Consider Controller Service references in template and sni...

2016-11-29 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1277 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1307: NIFI-2585: Add attributes to track where a flow file came ...

2016-12-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1307 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1307: NIFI-2585: Add attributes to track where a flow file came ...

2016-12-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1307 @randerzander I tested this out and I think we have to move the addition of the attributes to inside the loop where the flow files are being created. If we do it after the loop, then session.transfer

[GitHub] nifi issue #1307: NIFI-2585: Add attributes to track where a flow file came ...

2016-12-08 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1307 Thanks for pointing that out, let me give it a try with minif-cpp and see if I can reproduce. I was hoping that by putting the attributes in AbstractFlowFileServerProtocol it would automatically work

[GitHub] nifi issue #1307: NIFI-2585: Add attributes to track where a flow file came ...

2016-12-09 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1307 @randerzander I haven't been able to reproduce this yet. Running a simple GetFile -> RPG on minifi-cpp to a regular NiFi with InputPort -> LogAttribute, I am seeing the two attributes come t

[GitHub] nifi pull request #1329: NIFI-190: Initial commit of Wait and Notify process...

2016-12-16 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1329#discussion_r92809224 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/Wait.java --- @@ -0,0 +1,266

[GitHub] nifi pull request #1329: NIFI-190: Initial commit of Wait and Notify process...

2016-12-16 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1329#discussion_r92808940 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/Notify.java --- @@ -0,0 +1,191

[GitHub] nifi pull request #1329: NIFI-190: Initial commit of Wait and Notify process...

2016-12-16 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1329#discussion_r92815826 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/Wait.java --- @@ -0,0 +1,266

[GitHub] nifi issue #1317: NIFI-3186: Fixed NPE that was overlooked

2016-12-15 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1317 Looks good, will merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1329: NIFI-190: Initial commit of Wait and Notify processors

2016-12-16 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1329 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1329: NIFI-190: Initial commit of Wait and Notify processors

2016-12-16 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1329 That makes sense, I think we can add that functionality later. I created this JIRA to track the changes for the DistributedMapCacheClient https://issues.apache.org/jira/browse/NIFI-3214, then we can

[GitHub] nifi issue #1307: NIFI-2585: Add attributes to track where a flow file came ...

2016-12-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1307 @randerzander I wrote a simple Java main method with the following: ``` URI uri = new URI("nifi://techops_web-service.dev_1.techops_dev:42626"); System.out.println("Host:

[GitHub] nifi pull request #1338: NIFI-3220 Add support for basic auth to Solr proces...

2016-12-16 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1338 NIFI-3220 Add support for basic auth to Solr processors Also made the Solr Location support expression location so it can be paramterized with the variable registry. You can merge this pull request

[GitHub] nifi pull request #1320: NIFI-2585 Add attributes to track s2s host and port

2016-12-12 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1320 NIFI-2585 Add attributes to track s2s host and port I left the three commits to show the history of how this evolved. We can squash my two commits when merging, but I wanted Randy to get credit

[GitHub] nifi issue #1411: NIFI-3309 ensures that CS are deleted when a process group...

2017-01-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1411 I was able to resolve the checkstyle issues and folded it into your commit, so I'm a +1 and will merge it master, thanks! --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #1411: NIFI-3309 ensures that CS are deleted when a process group...

2017-01-12 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1411 Looks like a checkstyle failure when I ran the contrib-check: [WARNING] src/main/java/org/apache/nifi/groups/StandardProcessGroup.java[621] (regexp) RegexpSinglelineJava: Line has trailing

[GitHub] nifi issue #1287: NIFI-3135 - Authorizing restricted components on snippet u...

2016-12-02 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1287 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1285: Loading the correct type of temporary instance during comp...

2016-11-30 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1285 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1360: NIFI-3259 - Process group level option in Ambari reporting...

2017-01-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1360 +1 Tested this out with Ambari and was able to run two instances of the reporting task, one for all of NiFi and one for a specific process group, then created a second dashboard in Grafana

[GitHub] nifi pull request #1404: NIFI-3299 Adding example of sensitive property key ...

2017-01-06 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1404 NIFI-3299 Adding example of sensitive property key migration to the a… …dmin guide Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1361: NIFI-3231 Added EL support to hostname and port in PutTCP/...

2017-01-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1361 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1352: NIFI-3240 - AttributesToJson performance improvements

2017-01-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1352 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1352: NIFI-3240 - AttributesToJson performance improvements

2017-01-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1352 +1 Looks good, I'll get this merged in, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1361: NIFI-3231 Added EL support to hostname and port in PutTCP/...

2017-01-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1361 +1 looks good now, will merge to master, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1309: NIFI-2695: Provide more meaningful authorization error mes...

2017-01-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1309 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1309: NIFI-2695: Provide more meaningful authorization error mes...

2017-01-04 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1309 +1 Verified I now get the more descriptive messages when doing things like deleting a processor referencing a controller service that I don't have access to. I'll merge to master. --- If your

[GitHub] nifi pull request #1383: NIFI-2859 - Ignore files starting with a dot in Lis...

2017-01-06 Thread bbende
Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi/pull/1383#discussion_r94950985 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/ListHDFS.java --- @@ -176,7 +176,7

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-20 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 @ijokarumawak thanks for digging in to this! I closed the other PR. Everything you described makes sense... I'm on the fence about the attribute names... lets say we have MiNiFi ->

[GitHub] nifi pull request #1349: NIFI-1784 Initial commit for FetchHBaseRow processo...

2016-12-21 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1349 NIFI-1784 Initial commit for FetchHBaseRow processor This processor takes an incoming flow file to trigger execution, and the table name, row id, and columns (optional) can all come from flow file

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-21 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 Thanks @ijokarumawak ! I was testing this and I noticed that whenever I do a push model from nifi-1 to nifi-2, the value of s2s.hostname on the flow file in nifi-2 ends up being the IP

[GitHub] nifi pull request #1357: NIFI-3250 Fixing logic in StandardFlowFileQueue whe...

2016-12-27 Thread bbende
Github user bbende closed the pull request at: https://github.com/apache/nifi/pull/1357 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1342: NIFI-2585 Add attributes to track s2s host and port

2016-12-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1342 I think the issue was that I had left nifi.remote.input.host blank on both instances. So in the push model it was getting the ip address of the incoming connection which was my laptop's internal IP

[GitHub] nifi pull request #1357: NIFI-3250 Fixing logic in StandardFlowFileQueue whe...

2016-12-22 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/1357 NIFI-3250 Fixing logic in StandardFlowFileQueue when migrating flow f… …iles to the active queue You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1338: NIFI-3220 Add support for basic auth to Solr processors

2016-12-22 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/1338 @ijokarumawak yes we should definitely create another JIRA to convert GetSolr to use state management, I keep forgetting that it doesn't do that already. If you need any help with the basic

<    1   2   3   4   5   6   7   8   9   >