GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1806
NIFI-3909: If we have a FlowFile with 0 records, ensure that PublishKâ¦
â¦afkaRecord_0_10 handles the flowfile properly
Thank you for submitting a contribution to Apache NiFi.
In
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1807
NIFI-3910: Fixed issue where CSVRecordReader throws an Exception if aâ¦
⦠field is missing instead of using a null value
Thank you for submitting a contribution to Apache NiFi
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1804
@joewitt I rebased against master. There was a new unit test that needed to
be updated. Pushed an update to the PR that addresses that new unit test.
Should be good now.
---
If your project is set
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1807
@jfrazee great catch! I pushed a new commit that addresses that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1796
@ijokarumawak I was unable to replicate the issue, running on OSX. However,
I did review the code and it looks good. Makes sense. I also could verify that
I didn't find any problems with ho
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1809
NIFI-3912: Fixed NPE that would result in validation failure for Freeâ¦
â¦FormTextRecordSetWriter
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1810
NIFI-3914: Do not validate that remote group ports can start transmitâ¦
â¦ting if there is no connection
Thank you for submitting a contribution to Apache NiFi.
In order to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1812#discussion_r116857276
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1812#discussion_r116857203
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1812#discussion_r116860008
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1812#discussion_r116860379
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1817
NIFI-3923: Only start processors after repositories have been initialâ¦
â¦ized
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1813
@ijokarumawak All looks good. Build passes with contrib-check. Code changes
look good. +1 merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1815
@ijokarumawak all looks good here. I did some testing and things seem to
work properly I merged to master but unfortunately forgot to update the commit
message to indicate "this closes #1815.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1816
@ijokarumawak thanks! The changes look good. I ran build with contrib-check
and unit test helps. +1 merged to master.
---
If your project is set up for it, you can reply to this email and have your
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1819
NIFI-3917: Use a default value of 'false' for CSV Reader's Skip Headeâ¦
â¦r Line property
Thank you for submitting a contribution to Apache NiFi.
In order to
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1825
NIFI 3863 - Add LookupRecord, PartitionRecord processors
I still need to add some more documentation and unit tests but wanted to go
ahead and get this up so that if anyone has a chance to review
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1825#discussion_r117351574
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PartitionRecord.java
---
@@ -0,0
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1831
@bbende I very much like the idea of this PR. I tried to test it out,
though, and it didn't behave as I was hoping.
I downloaded the GeoLite2 database for ASN and for City. I se
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1833
NIFI-3946: Update LookupService to take a Map instead of a String forâ¦
⦠the input
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1834
NIFI-3948: Added flush() method to RecordWriter and call it when writâ¦
â¦ing a single record to OutputStream for PublishKafkaRecord. Also removed
no-longer-used class WriteAvroResult
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1833#discussion_r117738580
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1833#discussion_r117738594
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/maxmind
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1833
@jfrazee addressed those null's, not Optional issues. Pushed a new commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1831
@bbende all looks good now. Was able to verify the functionality. +1 merged
to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1835
NIFI-3951: Fixed bug that calculated the index incorrectly when filteâ¦
â¦ring for ArrayIndexPath
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1836
NIFI-3952: Updated UpdateRecord to pass field-related variables to thâ¦
â¦e Expression Language
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1837
Nifi 3953
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1839
NIFI-3949: Updated Grok Reader to allow for sub-patterns to be used wâ¦
â¦hen determining the schema
Thank you for submitting a contribution to Apache NiFi.
In order to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1838#discussion_r117835377
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster-protocol/src/main/java/org/apache/nifi/cluster/coordination/heartbeat
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1838
+1 all looks good. Was able to verify behavior. Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1846
NIFI-3962: Updated ConsumerLease to better handle batching of messageâ¦
â¦s into a single FlowFile in the same way that it is handled for
demarcated data
Thank you for submitting a
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1850
NIFI-3969: Prevent merging flowfiles prematurely when all bins fill bâ¦
â¦ut some are already full and can be processed
Thank you for submitting a contribution to Apache NiFi.
In
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1852
NIFI-3671: Ensure that we use the existing ResourceClaim (if it existâ¦
â¦s) when swapping data in, instead of creating a new one. Otherwise, if
the ResourceClaim is still writable, then we may
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1832
@joewitt @mosermw the change looks good to me, too. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1832
Was able to test and verify functionality. +1 merged to master. Thanks
@mosermw!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1854
NIFI-3971: Fixed bug in calculating content size that was transferredâ¦
⦠when cloning a relationship
Thank you for submitting a contribution to Apache NiFi.
In order to
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1855
NIFI-3972: Ensure that we wait until service state becomes enabled beâ¦
â¦fore triggering completable future that says that it's enabled
Thank you for submitting a contribution to A
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1861
NIFI-3981: When serializing flow to cluster, use the Scheduled State â¦
â¦of ports as they are configured to be, not the current state, since the
current state may change as soon as the
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1864
NIFI-3985: Added 'Starting Position' property to SiteToSiteReportingTâ¦
â¦ask; also added additionalDetails.html that explains the schema and
updated the reporting task to stop publi
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1868
NIFI-3986: When we encounted EOFException from sequential record readâ¦
â¦er event iterator, just treat it as not having any more events
Thank you for submitting a contribution to Apache
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1869
NIFI-3989: Avoid calling Long.parseLong, etc. in order to determine iâ¦
â¦f a String is a valid number because we don't want the Exceptions that
occur if it is not
Thank yo
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1870
NIFI-3990: Avoided creating garbage when we can avoid it in the JSON â¦
â¦and csv readers and json writer
Thank you for submitting a contribution to Apache NiFi.
In order to
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1872
NIFI-106: Expose processors' counters in Stats History
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to e
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1871
@mcgilman all looks good. I have merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1872
@mcgilman great point! When I looked through the code, I saw the section of
code that was handling permissions around the Status History but didn't look
close enough. I had assumed that if the
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1873
NIFI-3995: No longer use the 14th byte in the header for hwx content-â¦
â¦encoded schema reference
Thank you for submitting a contribution to Apache NiFi.
In order to streamline
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1876
NIFI-3995: Updated Hwx Encoded Schema Ref Writer to write 13 bytes foâ¦
â¦r header instead of 14; added unit test to verify
Thank you for submitting a contribution to Apache NiFi
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1879
NIFI-4003: Expose configuration option for cache size and duration
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1879
Thanks @bbende . Have pushed a new commit that addresses this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1881
NIFI-4009: Added support for several key functions in RecordPath
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1896
@bbende looks good. +1 merged to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1895
Will Review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1902
NIFI-3921: Allow Record Writers to inherit schema from Record
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1906
NIFI-4046: If we are unable to parse out any records from a Kafka Mesâ¦
â¦aage with ConsumeKafkaRecord, then we should route all of the bytes
received to 'parse.failure'
Tha
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1907
NIFI-4047: Addressed issue with inconsistent Lexical policy between uâ¦
â¦sed cached schemas and non-cached schemas
Thank you for submitting a contribution to Apache NiFi.
In
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1912
NIFI-1921: Fixed bug in how average lineage duration was calculated fâ¦
â¦or cluster stat
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1872
@mcgilman I pushed a new commit that addresses your concern, such that
counters are included in the stats only if the user is authorized to read the
processor that the counters belong to. Of note
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1895
Hey @champagst sorry for the delay in getting this reviewed. I think the
solution that you provided here will work for this use case, but I'm a little
bit concerned with this approach. I say
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122723598
--- Diff:
nifi-api/src/main/java/org/apache/nifi/context/PropertyContext.java ---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122725606
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/state-management.xml
---
@@ -63,4 +63,68
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122728877
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisConnectionPoolService.java
---
@@ -0,0
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122731744
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122732793
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122736750
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateMapJsonSerDe.java
---
@@ -0,0 +1,103
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122742378
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/state/RedisStateProvider.java
---
@@ -0,0 +1,271
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122761028
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/util/RedisUtils.java
---
@@ -0,0 +1,422
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1918#discussion_r122761385
--- Diff:
nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/util/RedisUtils.java
---
@@ -0,0 +1,422
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1150
NIFI-2925: When swapping in FlowFiles, do not assume that its Resourcâ¦
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1115#discussion_r86136287
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/bin/BinFiles.java
---
@@ -273,25 +262,26 @@ private int
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1115#discussion_r86138383
--- Diff:
nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/bin/BinFiles.java
---
@@ -273,25 +262,26 @@ private int
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1115
@olegz Thanks for reviewing! I have responded to your concerns above. If
you feel they need more discussion, then we certainly can. Thanks!
---
If your project is set up for it, you can reply to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1115#discussion_r87260657
--- Diff:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/processors/hive/PutHiveStreaming.java
---
@@ -377,7 +377,7
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1202
NIFI-2854: Refactor repositories and swap files to use schema-based sâ¦
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1189
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1189
+1 Looks good. Verified that all works as expected. Thanks for jumping on
this! Merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1210
NIFI-2999: When Cluster Coordinator changes, purge any old heartbeatsâ¦
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1208#discussion_r87630105
--- Diff:
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
---
@@ -560,7 +560,8 @@ public
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87631735
--- Diff:
nifi-framework-api/src/main/java/org/apache/nifi/controller/repository/claim/ResourceClaim.java
---
@@ -64,4 +64,28 @@
* @return true if
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87631938
--- Diff:
nifi-commons/nifi-schema-utils/src/main/java/org/apache/nifi/repository/schema/UnionRecordField.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87631992
--- Diff:
nifi-commons/nifi-schema-utils/src/main/java/org/apache/nifi/repository/schema/Requirement.java
---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87632081
--- Diff:
nifi-commons/nifi-schema-utils/src/main/java/org/apache/nifi/repository/schema/RecordSchema.java
---
@@ -0,0 +1,183 @@
+/*
+ * Licensed to
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1209
@combineads thanks for the contribution! All looks good. I have merged to
master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1116
@olegz thanks for jumping on this. Sorry it's taken me so long to get back
to it. I verified the changes are good now. I added an additional unit test to
verify a corner case that was problemat
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1202
@joshelser I did actually look into using both Protocol Buffers as well as
Avro to perform the serialization/deserialization. That really would be
preferred, as they are both very stable libraries
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87804332
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87804314
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87806305
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87806443
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/swap/SimpleSwapSerializer.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87807209
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/swap
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87808270
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87807516
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/schema
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87824046
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/swap/TestFlowFile.java
Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1202#discussion_r87825804
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/swap
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1202
@joshelser no worries - I am glad that someone at least doubted that
decision :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1202
@JPercivall i have pushed a new commit that I believe should address your
feedback. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1107
@mathiastiberghien my apologies. I didn't see where @pvillard31 had
mentioned me. I'll review now & if all is good will merge to master this
afternoon. Thanks!
---
If your project is
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1107
@mathiastiberghien this is great work - sorry it took so long to get this
reviewed. All looks good, though. I have merged to master and will close the
JIRA as fixed. Thanks for the contribution
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/1188
@mcgilman I'd be happy to review this if you need another reviewer given
that you and @scottyaslan have both provided commits for this PR.
---
If your project is set up for it, you can rep
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/1223
NIFI-3036: When we replay a FlowFile, ensure that we are using the 'gâ¦
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution w
301 - 400 of 1392 matches
Mail list logo
