ajantha-bhat commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3047577325
@poojanilangekar or @XN137: ASF infra team has updated the CI settings and
resolved my ticket.
Can any one of you (others who are watching thread and not a committer is
also
ajantha-bhat commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3047502633
Voting has passed and here is the infra ticket for the same:
https://issues.apache.org/jira/browse/INFRA-26985
I will keep you guys updated.
--
This is an automated message
gfakbar20 commented on PR #1990:
URL: https://github.com/apache/polaris/pull/1990#issuecomment-3047279676
and no, i do not intend to permanently closed this pr as I believe @snazy
concern lead to a bigger issue.
--
This is an automated message from the Apache Git Service.
To respond to th
gfakbar20 commented on PR #1990:
URL: https://github.com/apache/polaris/pull/1990#issuecomment-3047277248
Hi @dimas-b , after i took a closer look of the code last night, the
complete removal of the gradle dependency will make this PR scope to huge.
Hence i:
* will reopen this PR soon (b
MonkeyCanCode commented on PR #1995:
URL: https://github.com/apache/polaris/pull/1995#issuecomment-3047269631
> > @MonkeyCanCode Thanks for improving the Makefile! Overall LGTM
> > There are some discussion around doing the code check/format in a
different way: #1986. Since the current on
github-actions[bot] closed pull request #1595: example: Add getting-started
example for Polaris with Minio, Spark & Trino
URL: https://github.com/apache/polaris/pull/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
github-actions[bot] commented on PR #1825:
URL: https://github.com/apache/polaris/pull/1825#issuecomment-3047120489
This PR is stale because it has been open 30 days with no activity. Remove
stale label or comment or this will be closed in 5 days.
--
This is an automated message from the
eric-maynard merged PR #1925:
URL: https://github.com/apache/polaris/pull/1925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on code in PR #2007:
URL: https://github.com/apache/polaris/pull/2007#discussion_r2191259218
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfiguration.java:
##
@@ -124,6 +124,18 @@ T cast(Object value) {
return this.typ.cast(va
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2191257187
##
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##
@@ -34,11 +35,12 @@ public class BehaviorChangeConfiguration exte
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2191208352
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191201319
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191201319
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191198935
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191196908
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191194457
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
poojanilangekar commented on PR #2007:
URL: https://github.com/apache/polaris/pull/2007#issuecomment-3046827679
CC @dimas-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
poojanilangekar opened a new pull request, #2007:
URL: https://github.com/apache/polaris/pull/2007
As pointed out in #1959, this change converts all public member variable to
private variables.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191191610
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
MonkeyCanCode commented on code in PR #1995:
URL: https://github.com/apache/polaris/pull/1995#discussion_r2191188253
##
client/python/Makefile:
##
@@ -30,6 +58,22 @@ test-integration:
@echo "Polaris is healthy. Starting integration tests..."
poetry run pytest int
MonkeyCanCode commented on code in PR #1995:
URL: https://github.com/apache/polaris/pull/1995#discussion_r2191187455
##
client/python/Makefile:
##
@@ -15,10 +15,38 @@
# specific language governing permissions and limitations
# under the License.
+VENV_DIR := .venv
+
+.PHON
MonkeyCanCode commented on PR #1986:
URL: https://github.com/apache/polaris/pull/1986#issuecomment-3046806304
As discussed on the other PR, I will convert this to draft mode. Once the
makefile is updated to supports additional functionalities, we can revisit this
one.
--
This is an autom
MonkeyCanCode commented on PR #2001:
URL: https://github.com/apache/polaris/pull/2001#issuecomment-3046804447
> > Not a blocker: Hi @MonkeyCanCode and @adutra , can we move the
helm/polaris/README.md to the site so that people can visit it from Polaris
website?
>
> Sure thing. I can
dimas-b commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191184378
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
MonkeyCanCode opened a new pull request, #2006:
URL: https://github.com/apache/polaris/pull/2006
The challenge with publishing helm doc to hugo site is the helm doc is
outside of the `content` dir used by hugo (quick test with symbolic link
doesn't appear to be working and hugo doesn't read
eric-maynard commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191172265
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
HonahX commented on PR #1986:
URL: https://github.com/apache/polaris/pull/1986#issuecomment-3046758373
Thanks @eric-maynard and @MonkeyCanCode for the thorough explanations! I
think the idea of adding convenient task in gradle is great. The questions lie
more on the practical side that we s
dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191153809
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191154829
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191153809
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
MonkeyCanCode commented on PR #1995:
URL: https://github.com/apache/polaris/pull/1995#issuecomment-3046736188
> @MonkeyCanCode Thanks for improving the Makefile! Overall LGTM
>
> There are some discussion around doing the code check/format in a
different way: #1986. Since the current
HonahX commented on code in PR #1995:
URL: https://github.com/apache/polaris/pull/1995#discussion_r2191124000
##
client/python/Makefile:
##
@@ -15,10 +15,38 @@
# specific language governing permissions and limitations
# under the License.
+VENV_DIR := .venv
+
+.PHONY: rege
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191127645
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191127645
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2191114314
##
spec/polaris-management-service.yml:
##
@@ -917,6 +917,7 @@ components:
- OAUTH
- BEARER
- SIGV4
+- IMPLIC
MonkeyCanCode commented on PR #2001:
URL: https://github.com/apache/polaris/pull/2001#issuecomment-3046689166
> Not a blocker: Hi @MonkeyCanCode and @adutra , can we move the
helm/polaris/README.md to the site so that people can visit it from Polaris
website?
Will do.
--
This i
flyrain closed issue #1324: Update "Access Control" page to add more privileges
URL: https://github.com/apache/polaris/issues/1324
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
flyrain commented on issue #1322:
URL: https://github.com/apache/polaris/issues/1322#issuecomment-3046684359
This is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
flyrain closed issue #1322: Document new entities(Generic Table, Policy)
URL: https://github.com/apache/polaris/issues/1322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
flyrain commented on PR #2001:
URL: https://github.com/apache/polaris/pull/2001#issuecomment-3046683277
Not a blocker: Hi @MonkeyCanCode and @adutra , can we move the
helm/polaris/README.md to the site so that people can visit it from Polaris
website?
--
This is an automated message fr
dimas-b commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191103324
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
flyrain commented on issue #1750:
URL: https://github.com/apache/polaris/issues/1750#issuecomment-3046676535
Didn't happen for a while, close it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
flyrain closed issue #1750: Hugo site CI failed randomly
URL: https://github.com/apache/polaris/issues/1750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191081163
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
flyrain commented on code in PR #2000:
URL: https://github.com/apache/polaris/pull/2000#discussion_r2191080243
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -145,6 +145,8 @@ polaris.rate-limiter.token-bucket.requests-per-second=
polaris.rate-limiter.t
dimas-b commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191072789
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
dimas-b commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2191067698
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
eric-maynard commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191021689
##
LICENSE:
##
@@ -222,6 +222,7 @@ This product includes code from Apache Iceberg.
*
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/Cata
MonkeyCanCode commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191020311
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
eric-maynard commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191020935
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
MonkeyCanCode commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191020311
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
dimas-b commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2190983846
##
LICENSE:
##
@@ -222,6 +222,7 @@ This product includes code from Apache Iceberg.
*
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/CatalogHa
dimas-b commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2191007304
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
dimas-b commented on code in PR #1966:
URL: https://github.com/apache/polaris/pull/1966#discussion_r2190984586
##
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##
@@ -327,4 +327,17 @@ public static void enforceFeatureEnabledOrThrow(
flyrain commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3046490462
I will close this one, as @ajantha-bhat has started to configure the project
such that only first time contributors need approval.
--
This is an automated message from the Apache Git Se
flyrain closed pull request #1984: Add new contributors
URL: https://github.com/apache/polaris/pull/1984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dimas-b commented on PR #1990:
URL: https://github.com/apache/polaris/pull/1990#issuecomment-3046457057
@gfakbar20 : your contribution is still valuable, but may need a bit extra
work, I guess... If you feel like continuing this effort, I'd propose starting
a `dev` email discussion, so as t
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2190951037
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2190943418
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2190943418
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on code in PR #1989:
URL: https://github.com/apache/polaris/pull/1989#discussion_r2190940269
##
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##
@@ -756,7 +756,7 @@ public boolean removeProperties(Namespace namespa
dimas-b commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3046387959
If a PR from a non-committer does not get attention, I'd propose sending an
email about it to the `dev` list.
--
This is an automated message from the Apache Git Service.
To respond to
MonkeyCanCode commented on PR #2001:
URL: https://github.com/apache/polaris/pull/2001#issuecomment-3046383066
@adutra thanks for the review. I had addressed the changes based on
feedback. Please take another look when you get a chance.
--
This is an automated message from the Apache Git S
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2190837839
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
adutra commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190772648
##
helm/polaris/README.md.gotmpl:
##
@@ -89,22 +71,7 @@ eval $(minikube -p minikube docker-env)
-Dquarkus.container-image.build=true
```
-### Installing the char
MonkeyCanCode commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190763877
##
helm/polaris/README.md.gotmpl:
##
@@ -113,67 +80,59 @@ Below are two sample deployment models for installing the
chart: one with a non-
> **These files are i
adutra commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190760143
##
helm/polaris/README.md.gotmpl:
##
@@ -113,67 +80,59 @@ Below are two sample deployment models for installing the
chart: one with a non-
> **These files are intended
MonkeyCanCode commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190759612
##
helm/polaris/README.md.gotmpl:
##
@@ -198,27 +157,18 @@ The following tools are required to run the tests:
* [Chart Testing](https://github.com/helm/chart-tes
adutra commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190756015
##
helm/polaris/README.md.gotmpl:
##
@@ -198,27 +157,18 @@ The following tools are required to run the tests:
* [Chart Testing](https://github.com/helm/chart-testing)
MonkeyCanCode commented on PR #2002:
URL: https://github.com/apache/polaris/pull/2002#issuecomment-3046071030
> > Thanks @MonkeyCanCode for this change.
> > I'm generally OK with it, but this is a breaking change in the Helm
chart, and since it will be released after 1.0.0, I wonder if we
gh-yzou commented on PR #1991:
URL: https://github.com/apache/polaris/pull/1991#issuecomment-3046053195
@snazy sorry for the confusion, by source jar, i don't refer to the
*-source.jar, I am referring to the jar without any classifier, here is what we
expected to see once we do publish to m
MonkeyCanCode commented on PR #1966:
URL: https://github.com/apache/polaris/pull/1966#issuecomment-3045969969
> But I really am open to changing the name @MonkeyCanCode -- I toyed with
`DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` but wasn't sure about it. Let
me know if you have any ide
MonkeyCanCode commented on PR #2002:
URL: https://github.com/apache/polaris/pull/2002#issuecomment-3045959805
> Thanks @MonkeyCanCode for this change.
>
> I'm generally OK with it, but this is a breaking change in the Helm chart,
and since it will be released after 1.0.0, I wonder if
MonkeyCanCode commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190637002
##
helm/polaris/README.md.gotmpl:
##
@@ -89,22 +71,7 @@ eval $(minikube -p minikube docker-env)
-Dquarkus.container-image.build=true
```
-### Installing t
RussellSpitzer commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190654645
##
plugins/spark/v3.5/spark/build.gradle.kts:
##
@@ -46,6 +46,47 @@ dependencies {
// TODO: extract a polaris-rest module as a thin layer for
// client to
eric-maynard commented on PR #1984:
URL: https://github.com/apache/polaris/pull/1984#issuecomment-3045949088
@dimas-b
> A formal reviewer assignment is not necessary for that.
It's not necessary, but it is nice to have. I have noticed this in Iceberg,
too, where people end up jus
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2190647754
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
gh-yzou commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2190646135
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
dimas-b commented on PR #1981:
URL: https://github.com/apache/polaris/pull/1981#issuecomment-3045931222
Please allow some more review time. From my POV the dev list discussion does
not have a conclusion yet :thinking:
--
This is an automated message from the Apache Git Service.
To respon
eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190638411
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/PolarisCatalogUtils.java:
##
@@ -64,9 +92,13 @@ public static boolean
isTableWithSparkMan
eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190630881
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##
@@ -68,7 +68,7 @@ public Table loadTable(Identifier identifier) thr
eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190630881
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##
@@ -68,7 +68,7 @@ public Table loadTable(Identifier identifier) thr
eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190633794
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/utils/HudiCatalogUtils.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the Apache Software Founda
eric-maynard commented on code in PR #1862:
URL: https://github.com/apache/polaris/pull/1862#discussion_r2190630881
##
plugins/spark/v3.5/spark/src/main/java/org/apache/polaris/spark/PolarisSparkCatalog.java:
##
@@ -68,7 +68,7 @@ public Table loadTable(Identifier identifier) thr
dimas-b commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2190628731
##
spec/polaris-management-service.yml:
##
@@ -917,6 +917,7 @@ components:
- OAUTH
- BEARER
- SIGV4
+- IMPLICIT
Revi
poojanilangekar commented on code in PR #1984:
URL: https://github.com/apache/polaris/pull/1984#discussion_r2190626573
##
.asf.yaml:
##
@@ -77,6 +77,14 @@ github:
- nssalian
- adnanhemani
- HotSushi
+- rahil-c
Review Comment:
As of 07/07, the CI runs are n
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2190623796
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
eric-maynard commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2190623796
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
poojanilangekar commented on code in PR #1925:
URL: https://github.com/apache/polaris/pull/1925#discussion_r2190622641
##
runtime/service/src/test/java/org/apache/polaris/service/quarkus/admin/PolarisAdminServiceAuthzTest.java:
##
@@ -151,7 +152,8 @@ public void testCreateCatalo
eric-maynard commented on PR #1966:
URL: https://github.com/apache/polaris/pull/1966#issuecomment-3045905014
But I really am open to changing the name @MonkeyCanCode -- I toyed with
`DEFAULT_LOCATION_OBJECT_STORAGE_PREFIX_ENABLED` but wasn't sure about it. Let
me know if you have any ideas.
adutra commented on code in PR #2002:
URL: https://github.com/apache/polaris/pull/2002#discussion_r2190569573
##
helm/polaris/values.yaml:
##
@@ -583,18 +583,27 @@ authentication:
# -- The type of token broker to use. Two built-in types are supported:
rsa-key-pair and symmet
poojanilangekar commented on code in PR #1959:
URL: https://github.com/apache/polaris/pull/1959#discussion_r2190568285
##
polaris-core/src/main/java/org/apache/polaris/core/config/PolarisConfigurationStore.java:
##
@@ -99,7 +99,25 @@ public interface PolarisConfigurationStore {
MonkeyCanCode commented on PR #1966:
URL: https://github.com/apache/polaris/pull/1966#issuecomment-3045833941
> Good point @MonkeyCanCode re: the name. A previous version had a truly
random prefix, but now it's deterministic based on a hash of the table
identifier. I don't actually have a p
eric-maynard commented on PR #1966:
URL: https://github.com/apache/polaris/pull/1966#issuecomment-3045822019
Good point @MonkeyCanCode re: the name. A previous version had a truly
random prefix, but now it's deterministic based on a hash of the table
identifier. I don't actually have a pref
eric-maynard merged PR #1998:
URL: https://github.com/apache/polaris/pull/1998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
eric-maynard commented on code in PR #2005:
URL: https://github.com/apache/polaris/pull/2005#discussion_r2190491861
##
api/iceberg-service/build.gradle.kts:
##
@@ -109,16 +122,16 @@ openApiGenerate {
)
}
-listOf("sourcesJar", "compileJava").forEach { task ->
+listOf("sou
adutra commented on code in PR #2001:
URL: https://github.com/apache/polaris/pull/2001#discussion_r2190419070
##
helm/polaris/README.md.gotmpl:
##
@@ -89,22 +71,7 @@ eval $(minikube -p minikube docker-env)
-Dquarkus.container-image.build=true
```
-### Installing the char
dimas-b commented on code in PR #1991:
URL: https://github.com/apache/polaris/pull/1991#discussion_r2190248247
##
plugins/spark/v3.5/spark-bundle/build.gradle.kts:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor lice
dimas-b merged PR #2004:
URL: https://github.com/apache/polaris/pull/2004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apa
dimas-b commented on PR #2004:
URL: https://github.com/apache/polaris/pull/2004#issuecomment-3045597985
This looks like a reasonable and valuable build improvement to me...
merging. If there are objections later we can certainly discuss / make
follow-up PRs.
--
This is an automated messa
1 - 100 of 109 matches
Mail list logo
