Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1934808197 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -2039,8 +1975,7 @@ private List listTableLike(PolarisEntitySubType subT

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

eric-maynard merged PR #724: URL: https://github.com/apache/polaris/pull/724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1934664361 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOUtil.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1934665278 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -2039,8 +1975,7 @@ private List listTableLike(PolarisEntitySubType subTyp

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

eric-maynard commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1934410743 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOUtil.java: ## @@ -0,0 +1,131 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1934216769 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -2039,8 +1975,7 @@ private List listTableLike(PolarisEntitySubType subT

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1934216769 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -2039,8 +1975,7 @@ private List listTableLike(PolarisEntitySubType subT

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1932958069 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -18,19 +18,112 @@ */ package org.apache.polaris.service.catalog.io

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1932957905 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalog.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1932957395 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -18,10 +18,50 @@ */ package org.apache.polaris.service.catalog.io; +imp

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on PR #724: URL: https://github.com/apache/polaris/pull/724#issuecomment-2620190721 Hi folks, I think this PR is ready to be merged into main branch. I have addressed all the comments, there are still some followup tasks, but we can do them later: e.g. remove test only

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

sfc-gh-rxing commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1932936731 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/io/TestFileIOFactory.java: ## @@ -18,23 +18,32 @@ */ package org.apache.polaris.servic

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

sfc-gh-rxing commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1932929000 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -2039,8 +1975,7 @@ private List listTableLike(PolarisEntitySubType

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1931421167 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -2039,8 +1975,7 @@ private List listTableLike(PolarisEntitySubType subT

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1931321987 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalo

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1931321370 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalo

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

eric-maynard commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1931284262 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.c

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1931282700 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalog.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

snazy commented on PR #724: URL: https://github.com/apache/polaris/pull/724#issuecomment-2616568422 Recent changes LGTM - deferring to @dimas-b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930873247 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalo

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930868160 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -18,10 +18,50 @@ */ package org.apache.polaris.service.catalog.io; +i

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930039154 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOUtil.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930038496 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -18,19 +18,112 @@ */ package org.apache.polaris.service.catalog.io

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930037401 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalog.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930037401 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/WasbTranslatingFileIOFactory.java: ## @@ -19,19 +19,63 @@ package org.apache.polaris.service.catalog.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1930035899 ## service/common/src/main/java/org/apache/polaris/service/catalog/BasePolarisCatalog.java: ## @@ -1586,27 +1525,22 @@ protected String viewName() { } } - privat

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1929397864 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -18,10 +18,50 @@ */ package org.apache.polaris.service.catalog.io; +i

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on PR #724: URL: https://github.com/apache/polaris/pull/724#issuecomment-2613606575 Hey @snazy @dimas-b May I get another review for this PR, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

sfc-gh-dhuo commented on PR #724: URL: https://github.com/apache/polaris/pull/724#issuecomment-2613574203 @snazy @dimas-b Looks like all the major comments have been resolved; any final/remaining suggestions before merging this? -- This is an automated message from the Apache Git Service.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1926115162 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/BasePolarisCatalogTest.java: ## @@ -1458,6 +1461,55 @@ public void testDropTableWithPurgeDisable

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

snazy commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925795624 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925819438 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

snazy commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925800848 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925789588 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

snazy commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925788298 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925785800 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925784309 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925777263 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925776021 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925776697 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

snazy commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925763780 ## quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/BasePolarisCatalogTest.java: ## @@ -1458,6 +1461,55 @@ public void testDropTableWithPurgeDisable

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925687603 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925699733 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

sfc-gh-rxing commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925684954 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

sfc-gh-rxing commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1925684954 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

snazy commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924733131 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924533290 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -19,9 +19,21 @@ package org.apache.polaris.service.catalog.io; import

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924531116 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -19,9 +19,21 @@ package org.apache.polaris.service.catalog.io; import ja

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924531116 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -19,9 +19,21 @@ package org.apache.polaris.service.catalog.io; import ja

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

XJDKC commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924530185 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924524612 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -19,9 +19,21 @@ package org.apache.polaris.service.catalog.io; import

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924524612 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/FileIOFactory.java: ## @@ -19,9 +19,21 @@ package org.apache.polaris.service.catalog.io; import

Re: [PR] Extend FileIOFactory to Improve Customization [polaris]

dimas-b commented on code in PR #724: URL: https://github.com/apache/polaris/pull/724#discussion_r1924517072 ## service/common/src/main/java/org/apache/polaris/service/catalog/io/DefaultFileIOFactory.java: ## @@ -19,18 +19,157 @@ package org.apache.polaris.service.catalog.io;